Re: [Mesa-dev] [PATCH 1/2] intel/aubinator_error_decode: Avoid printing long ascii85 lines

2017-04-07 Thread Chris Wilson
On Thu, Apr 06, 2017 at 01:37:54PM -0700, Jordan Justen wrote: > Since '---' can exist within an ascii85 encoded string, we should > avoid these strings when looking for header lines in the error state > file. > > One of the things we do inside the 'if (dashes) {' block is to print > the entire li

Re: [Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

2017-04-07 Thread Chris Wilson
On Thu, Apr 06, 2017 at 10:53:07PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_descriptor_set.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/intel/vulkan/anv_descriptor_set.c > b/src/intel/vulkan/anv_descriptor_set.c > index

Re: [Mesa-dev] [PATCH] anv/query: Use snooping on !LLC platforms

2017-04-07 Thread Chris Wilson
On Thu, Apr 06, 2017 at 08:49:54PM -0700, Jason Ekstrand wrote: > Commit b2c97bc789198427043cd902bc76e194e7e81c7d which made us start > using a busy-wait for individual query results also messed up cache > flushing on !LLC platforms. For one thing, I forgot the mfence after > the clflush so memory

Re: [Mesa-dev] [PATCH] st/pbo: select the right swizzle for instance IDs

2017-04-07 Thread Michel Dänzer
On 06/04/17 11:50 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The system value only has an X component, and radeonsi started > checking that in debug builds. > > Reported-by: Michel Dänzer > Fixes: 4cf29427770f ("radeonsi: support 64-bit system values") Thanks Nicolai. A bunch of oth

Re: [Mesa-dev] [PATCH] st/pbo: select the right swizzle for instance IDs

2017-04-07 Thread Samuel Pitoiset
On 04/07/2017 10:45 AM, Michel Dänzer wrote: On 06/04/17 11:50 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The system value only has an X component, and radeonsi started checking that in debug builds. Reported-by: Michel Dänzer Fixes: 4cf29427770f ("radeonsi: support 64-bit system value

Re: [Mesa-dev] [PATCH 2/2] egl, dri: Propagate context priority hint to driver->CreateContext

2017-04-07 Thread Chris Wilson
On Thu, Apr 06, 2017 at 08:29:55PM -0400, Rob Clark wrote: > On Thu, Apr 6, 2017 at 3:12 PM, Chris Wilson wrote: > > Jump through the layers of abstraction between egl and dri in order to > > feed the context priority attribute through to the backend. This > > requires us to read the value from th

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-07 Thread Thomas Hellstrom
Hi, Rob, On 04/04/2017 07:12 PM, Rob Clark wrote: > On Tue, Apr 4, 2017 at 12:10 PM, Thomas Hellstrom > wrote: >> On 04/04/2017 05:36 PM, Rob Clark wrote: >>> On Tue, Apr 4, 2017 at 10:28 AM, Thomas Hellstrom >>> wrote: On 04/04/2017 04:06 PM, Rob Clark wrote: > On Tue, Apr 4, 2017 at

[Mesa-dev] [Bug 100609] glGetFramebufferAttachmentParameteriv() returns GL_INVALID_ENUM when getting attachment size from back buffer

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100609 Bug ID: 100609 Summary: glGetFramebufferAttachmentParameteriv() returns GL_INVALID_ENUM when getting attachment size from back buffer Product: Mesa Version: 17.0

[Mesa-dev] [Bug 100609] glGetFramebufferAttachmentParameteriv() returns GL_INVALID_ENUM when getting attachment size from back buffer

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100609 --- Comment #1 from nfx...@gmail.com --- By the way, I'm not sure, but this test seems to trigger this case, and expects that it doesn't trigger an error? https://cgit.freedesktop.org/piglit/tree/tests/bugs/fdo28551.c -- You are receiving this

Re: [Mesa-dev] [PATCH] st/pbo: select the right swizzle for instance IDs

2017-04-07 Thread Nicolai Hähnle
On 07.04.2017 10:45, Michel Dänzer wrote: On 06/04/17 11:50 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The system value only has an X component, and radeonsi started checking that in debug builds. Reported-by: Michel Dänzer Fixes: 4cf29427770f ("radeonsi: support 64-bit system values")

Re: [Mesa-dev] [PATCH] anv: provide anv_gem_busy() stub for the tests

2017-04-07 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Thu, 2017-04-06 at 13:07 +0100, Emil Velikov wrote: > From: Emil Velikov > > Otherwise linking way fail. > > Cc: Jason Ekstrand > Cc: Vinson Lee > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100600 > Fixes: f195d40eca4 ("anv/device: Add a hel

[Mesa-dev] [Bug 100600] anv_device.c:1337: undefined reference to `anv_gem_busy'

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100600 --- Comment #1 from Juan A. Suarez --- Patch at https://patchwork.freedesktop.org/patch/148737/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

[Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

2017-04-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Enable code sanitizers by adding -fsanitize=$foo flags for the compiler and linker. In addition, this also disables checking for undefined symbols: running the address sanitizer requires additional symbols which should be provided by a preloaded libasan.so (preloaded for hoo

Re: [Mesa-dev] [PATCH] mesa: simplify and optimise vertex bindings tracking

2017-04-07 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Thu, 2017-04-06 at 14:47 +1000, Timothy Arceri wrote: > We only need to update it if something changes. Also > _mesa_bind_vertex_buffer() will update the mask when binding to a > NULL or default buffer so no need to do that update here. > --- > src/mesa/mai

[Mesa-dev] [PATCH] util: fix swizzle of INSTANCEID system value

2017-04-07 Thread Nicolai Hähnle
From: Nicolai Hähnle radeonsi added stricter checking for correct swizzles in debug builds. Reported-by: Michel Dänzer Fixes: 4cf29427770f ("radeonsi: support 64-bit system values") --- src/gallium/auxiliary/util/u_simple_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

2017-04-07 Thread Bartosz Tomczyk
Reviewed-by: Bartosz Tomczyk I was using similar patch locally for a long time. On Fri, Apr 7, 2017 at 12:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking

[Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Qiang Yu
V2: 1. export gbmint.h and test backend/libgbm ABI compatible 2. drop GBM_BACKEND_DIR, specify backend path in config file 3. add GBM_CONFIG_DIR for config file 4. add per backend priority 5. take care of thread safe Third-party can put their backend to a directory and create a /etc/gbm.

[Mesa-dev] [PATCH v2 0/2] Add ignore file for bin/get-{extra, fixes}-pick-list.sh scripts

2017-04-07 Thread Juan A. Suarez Romero
Those two scripts suggest about commits that could be potential candidates to be in stable. But if we decided some of those commits arent, the scripts will continue suggesting them. The first patch adds a bin/.cherry-ignore-extra, similar to bin/.cherry-ignore, where we can put the commits we are

[Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

2017-04-07 Thread Juan A. Suarez Romero
Both scripts does not use a file with the commits to ignore. So if we have handled one of the suggested commits and decided we won't pick it, the scripts will continue suggesting them. This commits adds support for a bin/.cherry-ignore-extra where we can put the commits not explicitly rejected (th

[Mesa-dev] [PATCH v2 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

2017-04-07 Thread Juan A. Suarez Romero
Show the commit hash and the title in a way that it is easier to copy and paste in the bin/.cherry-ignore-extra file if we want to ignore those commits for the future. v2: - Use printf instead echo (Eric Engestrom) Reviewed-by: Eric Engestrom --- bin/get-fixes-pick-list.sh | 7 +-- 1 file c

[Mesa-dev] [PATCH v2 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

2017-04-07 Thread Juan A. Suarez Romero
Show the commit hash and the title in a way that it is easier to copy and paste in the bin/.cherry-ignore-extra file if we want to ignore those commits for the future. v2: - Use printf instead echo (Eric Engestrom) Reviewed-by: Eric Engestrom --- Forgot to use printf also in the get-extra-pick-l

[Mesa-dev] [PATCH v2 0/3] Make travis green

2017-04-07 Thread Andres Gomez
A couple of fixes to use a bit more standard syntax to pull the LLVM dependencies and to make scons check pass. Andres Gomez (3): travis: replace Trusty-based LLVM toolchain apt-get with apt addon travis: remove the libtxc-dxtn-s2tc0 library so scons check can pass travis: add the possibilit

[Mesa-dev] [PATCH 1/3] travis: replace Trusty-based LLVM toolchain apt-get with apt addon

2017-04-07 Thread Andres Gomez
Trusty's LLVM toochain repository was whitelisted some time ago. See: https://github.com/travis-ci/apt-source-whitelist/commit/479067c5e74cb0c1e2419209179b1afe2edce274 Signed-off-by: Andres Gomez Cc: Rhys Kidd Cc: Emil Velikov Reviewed-by: Rhys Kidd --- .travis.yml | 15 +++ 1 fil

[Mesa-dev] [PATCH 2/3] travis: remove the libtxc-dxtn-s2tc0 library so scons check can pass

2017-04-07 Thread Andres Gomez
The packaged libtxc-dxtn-s2tc0 will make scons check fail. Manually remove this package. v2: - scons check will pass just by not having an available libtxc_dxtn.so, as noticed by Rhys. - remove the installaton of the patent covered txc-dxtn library, as commented by Eric. Signed-off-by

[Mesa-dev] [PATCH 3/3] travis: add the possibility of using the txc-dxtn library

2017-04-07 Thread Andres Gomez
The txc-dxtn library implements the patented S3 Texture Compression algorithm. By default it won't be used but we add the possibility of setting the USE_TXC_DXTN variable to yes in the travis web UI so it will be installed and used for the scons tests. Signed-off-by: Andres Gomez Cc: Eric Anholt

[Mesa-dev] [PATCH v2] etnaviv: native fence fd support

2017-04-07 Thread Philipp Zabel
This adds native fence fd support to etnaviv, similarly to commit 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel driver version 1.1 or later. Signed-off-by: Philipp Zabel --- v2: address review comments - always call etna_cmd_stream_flush2 - remove FIXME comment about in_fence_fd

Re: [Mesa-dev] [PATCH 2/2] travis: add the txc-dxtn library so scons check can pass

2017-04-07 Thread Andres Gomez
On Thu, 2017-04-06 at 01:35 -0400, Rhys Kidd wrote: > On 5 April 2017 at 13:27, Andres Gomez wrote: > > The packaged libtxc-dxtn-s2tc0 will make scons check fail. Manually > > remove this package and install libtxc-dxtn instead. > > > > Signed-off-by: Andres Gomez > > Cc: Eric Anholt > > Cc: Em

Re: [Mesa-dev] [PATCH 2/2] travis: add the txc-dxtn library so scons check can pass

2017-04-07 Thread Andres Gomez
On Thu, 2017-04-06 at 09:59 -0700, Eric Anholt wrote: > Andres Gomez writes: > > > The packaged libtxc-dxtn-s2tc0 will make scons check fail. Manually > > remove this package and install libtxc-dxtn instead. > > I don't think we should be automatically installing and using this > software on oth

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-07 Thread Rob Clark
On Fri, Apr 7, 2017 at 5:06 AM, Thomas Hellstrom wrote: > Hi, Rob, > > On 04/04/2017 07:12 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 12:10 PM, Thomas Hellstrom >> wrote: >>> On 04/04/2017 05:36 PM, Rob Clark wrote: On Tue, Apr 4, 2017 at 10:28 AM, Thomas Hellstrom wrote: > O

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 3:28 AM, Qiang Yu wrote: > V2: > 1. export gbmint.h and test backend/libgbm ABI compatible > 2. drop GBM_BACKEND_DIR, specify backend path in config file > 3. add GBM_CONFIG_DIR for config file > 4. add per backend priority > 5. take care of thread safe > > Third-p

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Yu, Qiang
>> +dnl Directory for GBM >> + >> +AC_ARG_WITH([gbm-configdir], >> +[AS_HELP_STRING([--with-gbm-configdir=DIR], >> +[directory for the GBM configs @<:@/etc/gbm.conf.d@:>@])], >> +[GBM_CONFIG_DIR="$withval"], >> +[GBM_CONFIG_DIR='/etc/gbm.conf.d']) > > Without commenting on the

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 9:43 AM, Yu, Qiang wrote: > >>> +dnl Directory for GBM >>> + >>> +AC_ARG_WITH([gbm-configdir], >>> +[AS_HELP_STRING([--with-gbm-configdir=DIR], >>> +[directory for the GBM configs @<:@/etc/gbm.conf.d@:>@])], >>> +[GBM_CONFIG_DIR="$withval"], >>> +[GBM_CON

Re: [Mesa-dev] [PATCH] util: fix swizzle of INSTANCEID system value

2017-04-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Apr 7, 2017 at 12:24 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > radeonsi added stricter checking for correct swizzles in debug builds. > > Reported-by: Michel Dänzer > Fixes: 4cf29427770f ("radeonsi: support 64-bit system values") > --- > src/

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 Thread Marek Olšák
On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk wrote: > Signed-off-by: Gustaw Smolarczyk > --- > src/mesa/main/enable.c | 1 + > src/mesa/main/fog.c| 9 + > src/mesa/main/mtypes.h | 14 ++ > 3 files changed, 24 insertions(+) > > diff --git a/src/mesa/main/enable.c b

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 Thread Marek Olšák
On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk wrote: > Signed-off-by: Gustaw Smolarczyk > --- > src/mesa/main/mtypes.h | 83 ++ > src/mesa/main/texstate.c | 103 > +++ > 2 files changed, 186 insertions(+) >

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 Bug ID: 100613 Summary: Regression in Mesa 17 on s390x (zSystems) Product: Mesa Version: 17.0 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 Stefan Dirsch changed: What|Removed |Added CC||srol...@vmware.com -- You are receivin

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 Thread Marek Olšák
On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák wrote: > On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk > wrote: >> Signed-off-by: Gustaw Smolarczyk >> --- >> src/mesa/main/mtypes.h | 83 ++ >> src/mesa/main/texstate.c | 103 >> ++

Re: [Mesa-dev] [PATCH 14/14] st/mesa: Use compressed fog mode for atifs.

2017-04-07 Thread Marek Olšák
For patches 12-14: Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk wrote: > Signed-off-by: Gustaw Smolarczyk > --- > src/mesa/state_tracker/st_atifs_to_tgsi.c | 6 +++--- > src/mesa/state_tracker/st_atom_shader.c | 17 + > 2 files changed

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #1 from Roland Scheidegger --- I can't say I'm terribly surprised this commit broke it. That it might not work on BE certainly came to my mind when I did this, despite my efforts... I suspect the affected format didn't work with SoA

[Mesa-dev] [Bug 99618] AVX Intrinsics Run in GUI thread only

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99618 --- Comment #4 from ch...@circlecvi.com --- (In reply to Bruce Cherniak from comment #3) > Any chance you've been able to try the suggestion I made > (KNOB_MAX_WORKER_THREADS) to resolve this issue? Hi Bruce, my apologies for the late reply. Yes,

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Brian Paul
On 04/06/2017 03:55 PM, Timothy Arceri wrote: We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCount to 0. Fixes: 32141e53d1520 (mesa: t

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 Stefan Dirsch changed: What|Removed |Added CC||msta...@suse.de -- You are receiving t

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

2017-04-07 Thread Eric Engestrom
On Friday, 2017-04-07 12:00:04 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking for undefined symbols: running > the address sanitizer requires additional sym

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Bartosz Tomczyk
Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allocated from: #0 0x7fe18d168800 in calloc (/usr/lib/clang/3.9.1/lib/linux/ libclang_rt.asan-x86_64.so+0xf6800) #1 0x7fe181c141f6 in st_new_renderbuffer_fb /home/bartek/Devel/m

[Mesa-dev] [PATCH 2/2] vbo: fix gl_DrawID handling in glMultiDrawArrays

2017-04-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes a bug in KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c in

[Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

2017-04-07 Thread Nicolai Hähnle
From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/api_validate.c | 38 ++ src/mesa/main/api_validate.h | 4 src/mesa/m

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 12:30 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When any count[i] is negative, we must skip all draws. > > Moving to vbo makes the subsequent change easier. > --- > src/mapi/glapi/gen/gl_API.xml | 2 +- > src/mesa/main/api_validate.c | 38 +

[Mesa-dev] [PATCH] st/glx: Add awareness for multisample pixel formats to st/glx-xlib.

2017-04-07 Thread Bruce Cherniak
In preparation for enabling MSAA in OpenSWR, the state trackers need to be aware of multisample pixel formats for software renderers. This patch allows glx-xlib to query the renderer for support of pixel formats with multisample, and create multisample resources. This change is benign to softpipe

[Mesa-dev] RFH: Android support in Apitrace

2017-04-07 Thread José Fonseca
Hi, Another area of Apitrace I'm struggling with is Android support, because: - I don't have a feeling if / how much it actually matters to users - I have no idea if it even works or not I'm afraid the status quo is unbearable, whereby Android support is officially advertised, but users keep co

[Mesa-dev] [PATCH] ac: add unreachable() in ac_build_image_opcode()

2017-04-07 Thread Samuel Pitoiset
To silent the following compiler warning: common/ac_llvm_build.c: In function ‘ac_build_image_opcode’: common/ac_llvm_build.c:1080:3: warning: ‘name’ may be used uninitialized in this function [-Wmaybe-uninitialized] snprintf(intr_name, sizeof(intr_name), "%s%s%s%s.v4f32.%s.v8i32", ^~~~

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 Thread Gustaw Smolarczyk
2017-04-07 16:31 GMT+02:00 Marek Olšák : > On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk > wrote: >> Signed-off-by: Gustaw Smolarczyk >> --- >> src/mesa/main/enable.c | 1 + >> src/mesa/main/fog.c| 9 + >> src/mesa/main/mtypes.h | 14 ++ >> 3 files changed, 24 ins

[Mesa-dev] [PATCH 2/2] genxml: Make BLEND_STATE command support variable length array.

2017-04-07 Thread Rafael Antognolli
We need to emit BLEND_STATE, which size is 1 + 2 * nr_draw_buffers dwords (on gen8+), but the BLEND_STATE struct length is always 17. By marking it size 1, which is actually the size of the struct minus the BLEND_STATE_ENTRY's, we can emit a BLEND_STATE of variable number of entries. For gen6 and

[Mesa-dev] [PATCH 1/2] genxml: Fix python crash when no dwords are found.

2017-04-07 Thread Rafael Antognolli
If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. This case could happen when we have an instruction that is only an array of other structs, with variable length. Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen_pack_header.py | 2 +- 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 Thread Gustaw Smolarczyk
2017-04-07 16:40 GMT+02:00 Marek Olšák : > On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák wrote: >> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >> wrote: >>> Signed-off-by: Gustaw Smolarczyk >>> --- >>> src/mesa/main/mtypes.h | 83 ++ >>> src/mesa/mai

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

2017-04-07 Thread Brian Paul
On 04/07/2017 10:30 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/api_validate.c | 38 ++

Re: [Mesa-dev] [PATCH 1/2] genxml: Fix python crash when no dwords are found.

2017-04-07 Thread Dylan Baker
Quoting Rafael Antognolli (2017-04-07 09:52:16) > If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. > This case could happen when we have an instruction that is only an array > of other structs, with variable length. > > Signed-off-by: Rafael Antognolli > --- > src/intel/gen

Re: [Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

2017-04-07 Thread Jason Ekstrand
On Fri, Apr 7, 2017 at 1:14 AM, Chris Wilson wrote: > On Thu, Apr 06, 2017 at 10:53:07PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_descriptor_set.c | 22 +++--- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/src/intel/vulkan/anv_des

Re: [Mesa-dev] [PATCH] st/glx: Add awareness for multisample pixel formats to st/glx-xlib.

2017-04-07 Thread Roland Scheidegger
I'm not an expert on glx, but looks alright to me. Albeit strictly speaking, you don't really need this for MSAA with software renderers, since you can still you use fbos with msaa. But of course you probably want to support it with winsys buffers. Reviewed-by: Roland Scheidegger Am 07.04.2017 u

Re: [Mesa-dev] [PATCH] glsl: fix lower jumps for nested non-void returns

2017-04-07 Thread Roland Scheidegger
Looks alright to me though I still don't really understand this code :-) Reviewed-by: Roland Scheidegger Am 07.04.2017 um 03:24 schrieb Timothy Arceri: > Fixes the case were a loop contains a return and the loop is > nested inside an if. > > https://bugs.freedesktop.org/show_bug.cgi?id=100303 >

Re: [Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

2017-04-07 Thread Nanley Chery
On Fri, Apr 07, 2017 at 10:40:49AM -0700, Jason Ekstrand wrote: > On Fri, Apr 7, 2017 at 1:14 AM, Chris Wilson > wrote: > > > On Thu, Apr 06, 2017 at 10:53:07PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_descriptor_set.c | 22 +++--- > > > 1 file changed, 1

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

2017-04-07 Thread Emil Velikov
On 7 April 2017 at 11:00, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking for undefined symbols: running > the address sanitizer requires additional symbols which sh

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

2017-04-07 Thread Emil Velikov
On 7 April 2017 at 12:30, Juan A. Suarez Romero wrote: > Both scripts does not use a file with the commits to ignore. So if we > have handled one of the suggested commits and decided we won't pick it, > the scripts will continue suggesting them. > > This commits adds support for a bin/.cherry-igno

Re: [Mesa-dev] [PATCH v2 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

2017-04-07 Thread Emil Velikov
On 7 April 2017 at 12:48, Juan A. Suarez Romero wrote: > Show the commit hash and the title in a way that it is easier to copy > and paste in the bin/.cherry-ignore-extra file if we want to ignore > those commits for the future. > > v2: > - Use printf instead echo (Eric Engestrom) > > Reviewed-by:

Re: [Mesa-dev] [PATCH 3/3] travis: add the possibility of using the txc-dxtn library

2017-04-07 Thread Emil Velikov
On 7 April 2017 at 13:16, Andres Gomez wrote: > The txc-dxtn library implements the patented S3 Texture Compression > algorithm. > > By default it won't be used but we add the possibility of setting the > USE_TXC_DXTN variable to yes in the travis web UI so it will be > installed and used for the

[Mesa-dev] [Bug 100600] anv_device.c:1337: undefined reference to `anv_gem_busy'

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100600 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 04/13] travis: enable apt cache

2017-04-07 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index b426c0b6184..9c8234ac88e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ sudo: false dist: trusty cache: + apt: true directories:

[Mesa-dev] [PATCH 00/13] Better Travis-CI integration

2017-04-07 Thread Emil Velikov
Hi all, Inspired by the work from Andres, I've went ahead and made our integration a bit better. Highlights include: - run in container - faster startup times, always 2 cores - removed unneeded packages - "build everything" - st/vdpau and ANV cannot be build at this stage, with the respectiv

[Mesa-dev] [PATCH 01/13] travis: explicitly LD_LIBRARY_PATH the local libraries

2017-04-07 Thread Emil Velikov
From: Emil Velikov Some of the libraries may be dlopened, which may not always work due to the non-standard prefix that we're using. Signed-off-by: Emil Velikov --- Adding this is a good idea imho, regardless if we opt for or against libtxc_dxtn. --- .travis.yml | 1 + 1 file changed, 1 insert

[Mesa-dev] [PATCH 03/13] travis: add the possibility of using the txc-dxtn library

2017-04-07 Thread Emil Velikov
From: Andres Gomez The txc-dxtn library implements the patented S3 Texture Compression algorithm. By default it won't be used but we add the possibility of setting the USE_TXC_DXTN variable to yes in the travis web UI so it will be installed and used for the scons tests. Cc: Eric Anholt Cc: Rh

[Mesa-dev] [PATCH 05/13] travis: automatically manage ccache caching

2017-04-07 Thread Emil Velikov
From: Emil Velikov According to the manual "If you are using ccache, use: language: c # or other C/C++ variants cache: ccache to cache $HOME/.ccache and automatically add /usr/lib/ccache to your $PATH." Signed-off-by: Emil Velikov --- .travis.yml | 4 +--- 1 file changed, 1 insertion(+

[Mesa-dev] [PATCH 07/13] travis: rework if test blocks in the script section

2017-04-07 Thread Emil Velikov
From: Emil Velikov Split the "if test" blocks so that we get more sensible output in case of a failure. Signed-off-by: Emil Velikov --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 350ffa63dab..bf1f710dea3 100644 --- a/.trav

[Mesa-dev] [PATCH 06/13] travis: remove unused -dev packages

2017-04-07 Thread Emil Velikov
From: Emil Velikov We effectively override libdrm-dev and libxcb-dri2-0-dev since we build and install the package locally. Signed-off-by: Emil Velikov --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 144b14fd82e..350ffa63dab 100644 --- a/.tr

[Mesa-dev] [PATCH 10/13] travis: add "scons swr" to the build matrix

2017-04-07 Thread Emil Velikov
From: Emil Velikov Requires GCC 5.0 (due to the C++14 requirement) and LLVM 3.9. Signed-off-by: Emil Velikov --- .travis.yml | 26 ++ 1 file changed, 26 insertions(+) diff --git a/.travis.yml b/.travis.yml index ebacf90c79d..36d614c21a8 100644 --- a/.travis.yml +++ b/.

[Mesa-dev] [PATCH 02/13] travis: replace Trusty-based LLVM toolchain apt-get with apt addon

2017-04-07 Thread Emil Velikov
From: Andres Gomez Trusty's LLVM toochain repository was whitelisted some time ago. See: https://github.com/travis-ci/apt-source-whitelist/commit/479067c5e74cb0c1e2419209179b1afe2edce274 Signed-off-by: Andres Gomez [Emil Velikov] - set sudo to false - reference the Trusty change (Rhys) Signed

[Mesa-dev] [PATCH 12/13] travis: split the make target to three separate ones

2017-04-07 Thread Emil Velikov
Split the target to allow faster builds for each run. The overall build time will be more, yet Travis runs multiple builds in parallel so we're limited by the slowest one. Things are split roughly as: - DRI loaders, classic DRI drivers, classic OSMesa - All Gallium drivers (minus the SWR) along

[Mesa-dev] [PATCH 09/13] travis: add separate "scons" and "scons llvm" targets

2017-04-07 Thread Emil Velikov
From: Emil Velikov The former does not require any LLVM, while the latter uses LLVM 3.3. This way we'll quickly catch any LLVM 3.3+ functionality that gets introduced where it shouldn't. Add the full list of addons for each build permutation. Signed-off-by: Emil Velikov --- .travis.yml | 57

[Mesa-dev] [PATCH 08/13] travis: split out matrix from env

2017-04-07 Thread Emil Velikov
From: Emil Velikov With next commits we'll add a couple of more options. Signed-off-by: Emil Velikov --- .travis.yml | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index bf1f710dea3..bd7ccb8917c 100644 --- a/.travis.yml +++ b/.t

[Mesa-dev] [PATCH 13/13] travis: add Gallium state-tracker targets

2017-04-07 Thread Emil Velikov
From: Emil Velikov Split into OpenCL and others, since the former is quite time consuming. Signed-off-by: Emil Velikov --- .travis.yml | 65 + 1 file changed, 65 insertions(+) diff --git a/.travis.yml b/.travis.yml index 98c2c594328.

[Mesa-dev] [PATCH 11/13] travis: add "make swr" to the build matrix

2017-04-07 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 36d614c21a8..b5d9df5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -34,6 +34,9 @@ matri

Re: [Mesa-dev] [PATCH] swr: fix unused variable warnings

2017-04-07 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 6, 2017, at 7:10 PM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/swr_screen.cpp | 1 - > src/gallium/drivers/swr/swr_shader.cpp | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/gallium/drivers/swr/swr_screen.cpp > b/src/gallium/drivers/s

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98502 Eugene Shalygin changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH 03/13] travis: add the possibility of using the txc-dxtn library

2017-04-07 Thread Jan Vesely
On Fri, 2017-04-07 at 20:05 +0100, Emil Velikov wrote: > From: Andres Gomez > > The txc-dxtn library implements the patented S3 Texture Compression > algorithm. > > By default it won't be used but we add the possibility of setting the > USE_TXC_DXTN variable to yes in the travis web UI so it wil

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-07 Thread gregory hainaut
On Thu, 6 Apr 2017 00:21:19 +0200 gregory hainaut wrote: > On Wed, 5 Apr 2017 14:22:00 -0400 > Ilia Mirkin wrote: > > > On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut > > wrote: > > > Context: > > > Nouveau uses NULL strings for unnamed parameter of texture gather > > > offsets opcode. > > >

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #26 from Eugene Shalygin --- (In reply to Eugene Shalygin from comment #25) > Just found that dGPU wakes up when I connect an Android phone via USB. No, any USB device makes that. kernel 4.10.8. -- You are receiving this mail beca

[Mesa-dev] [PATCH v3 1/6] anv: Add helpers for converting access flags to pipe bits

2017-04-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 59 ++ src/intel/vulkan/genX_cmd_buffer.c | 48 ++- 2 files changed, 62 insertions(+), 45 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 5e0780

[Mesa-dev] [PATCH v3 3/6] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

2017-04-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_descriptor_set.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 56a08ce..4797c1e 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++ b/src/i

[Mesa-dev] [PATCH v3 4/6] anv/pass: Use anv_multialloc for allocating the anv_pass

2017-04-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c| 106 + src/intel/vulkan/anv_private.h | 1 - 2 files changed, 44 insertions(+), 63 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 4a1a340..15c4275 100644 --- a/src/intel/vulka

[Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Jason Ekstrand
We tend to try to reduce the number of allocation calls the Vulkan driver uses by doing a single allocation whenever possible for a data structure. While this has certain downsides (usually code complexity), it does mean error handling and cleanup is much easier. This commit adds a nice little he

[Mesa-dev] [PATCH v3 5/6] anv/pass: Record required pipe flushes

2017-04-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c| 88 ++ src/intel/vulkan/anv_private.h | 2 + 2 files changed, 90 insertions(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 15c4275..dcd9aaf 100644 --- a/src/intel/vulkan/anv_pass.c +++ b

[Mesa-dev] [PATCH v3 6/6] anv: Use subpass dependencies for flushes

2017-04-07 Thread Jason Ekstrand
Instead of figuring it all out ourselves, just use the information given to us by the client. --- src/intel/vulkan/anv_blorp.c | 88 -- src/intel/vulkan/genX_cmd_buffer.c | 10 + 2 files changed, 18 insertions(+), 80 deletions(-) diff --git a/src/inte

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > We tend to try to reduce the number of allocation calls the Vulkan > driver uses by doing a single allocation whenever possible for a data > structure. While this has certain downsides (usually code complexity), > it does mean error

[Mesa-dev] [Mesa-dev, kmscube 05/10] gst-decoder.c: Use element factory name to detect V4L2 video decoder

2017-04-07 Thread Carlos Rafael Giani
Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c index 51304a2..05d73b7 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -115,15 +115,24 @@ gst_thread_func(void *args) static v

[Mesa-dev] [Mesa-dev, kmscube 03/10] gst-decoder.c: add support for YUY2 pixel format

2017-04-07 Thread Carlos Rafael Giani
This format is used for example by the i.MX6 CODA hardware video codec Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gst-decoder.c b/gst-decoder.c index 22dc068..fd28201 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -91,6 +91,9 @@

[Mesa-dev] [Mesa-dev, kmscube 01/10] output more and improved information about EGL and OpenGL ES 2.x

2017-04-07 Thread Carlos Rafael Giani
Signed-off-by: Carlos Rafael Giani --- common.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/common.c b/common.c index 4bf3c5a..4d29eef 100644 --- a/common.c +++ b/common.c @@ -97,9 +97,12 @@ int init_egl(struct egl *egl, const struct gbm *gbm) pr

[Mesa-dev] [Mesa-dev, kmscube 08/10] gst-decoder.c: use a custom appsink subclass to make sure videometa exists

2017-04-07 Thread Carlos Rafael Giani
Signed-off-by: Carlos Rafael Giani --- Makefile.am | 2 +- gst-decoder.c | 20 - gst-video-appsink.c | 126 gst-video-appsink.h | 31 + kmscube.c | 2 + 5 files changed, 178 insertions(+), 3 del

[Mesa-dev] [Mesa-dev, kmscube 04/10] gst-decoder.c: look at the caps event instead of the allocation query

2017-04-07 Thread Carlos Rafael Giani
Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c index fd28201..51304a2 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -63,24 +63,23 @@ static GstPadProbeReturn pad_probe(GstPad

[Mesa-dev] [Mesa-dev, kmscube 09/10] gst-decoder.c: Improve synchronicity of video output

2017-04-07 Thread Carlos Rafael Giani
sync=false causes a sink to output data as fast as it can. This explains why without max-buffers=2 the pipeline used to use up 100's of MB of buffers. Instead, set sync to true, and enable frame dropping, to make sure the video playback speed remains intact. Signed-off-by: Carlos Rafael Giani --

[Mesa-dev] [Mesa-dev, kmscube 02/10] add "kmscube" GStreamer debug category

2017-04-07 Thread Carlos Rafael Giani
Without this, the various GST_* log macros won't output anything. To enable, add "kmscube:" to the GST_DEBUG environment variable. Example: GST_DEBUG=kmscube:5 Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 3 +++ kmscube.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)

[Mesa-dev] [Mesa-dev, kmscube 10/10] gst-decoder.c: improve buffer_to_image() function

2017-04-07 Thread Carlos Rafael Giani
* Make EGL image attribute specification code more generic, and not specific to certain pixel formats, implicitely gaining support for YUY2 * Better handling of gstbuffers with multiple memory blocks * Print out more information about the stream * Use the GST_VIDEO_INFO_* macros instead of direct

  1   2   >