Re: [Mesa-dev] [PATCH] egl: fix gcc warning braces around scalar initializer

2016-09-12 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 12/09/16 01:24, Timothy Arceri wrote: > --- > src/egl/main/eglcurrent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c > index 345f4cc..2a225bc 100644 > --- a/src/egl/main/eglcurren

Re: [Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

2016-09-12 Thread Philip Guenther
On Thu, 8 Sep 2016, Jonathan Gray wrote: > On Thu, Sep 08, 2016 at 06:57:44PM +0100, Emil Velikov wrote: ... > > For a long while the intent has been to use --enable-glx-tls by > > default and kill off the other codepaths. But with the write xor > > execute policy, it's going to be (close to) impos

Re: [Mesa-dev] [PATCH 3/4] i965/blorp: Add a copy_miptrees helper

2016-09-12 Thread Michael Schellenberger Costa
Hi Jason, On 09.09.2016 19:05, Jason Ekstrand wrote: --- src/mesa/drivers/dri/i965/brw_blorp.c | 71 +++ src/mesa/drivers/dri/i965/brw_blorp.h | 10 + 2 files changed, 81 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/driver

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

2016-09-12 Thread Michel Dänzer
On 10/09/16 12:49 AM, Nayan Deshmukh wrote: > In case of prime when rendering is done on GPU other then the > server GPU, use a seprate linear buffer for each back buffer > which will be displayed using present extension. > > v2: Use a seprate linear buffer for each back buffer (Michel) > v3: chan

Re: [Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

2016-09-12 Thread Erik Faye-Lund
An easy-ish way of upgrading a single source file from an upstream and keeping the changes that were done on top, is to branch out from the last update-commit, and update there. Then when merged, git will understand that the changes on top should still be applied when merging. Unfortunately, it bre

Re: [Mesa-dev] [PATCH 00/57] i965/ir: Switch representation of register offsets and sizes to byte units.

2016-09-12 Thread Iago Toral
On Fri, 2016-09-09 at 11:37 +0200, Iago Toral wrote: > On Thu, 2016-09-08 at 11:36 +0200, Iago Toral wrote: > > > > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > > > > > > > > > This series reworks the representation of register region offsets > > > in > > > the i965 IR to be unive

Re: [Mesa-dev] [PATCH v2 2/3] egl: return corresponding offset of EGLImage instead of 0.

2016-09-12 Thread Emil Velikov
On 9 September 2016 at 22:03, Axel Davy wrote: > I'm not sure calling queryImage with an unsupported attribute is legal, thus > I think a small check doesn't hurt. > > It'd give > > if (offsets) { >offsets[0] = 0; >if (dri2_dpy->image->base.version >= 13) { > EGLint img_offset = 0; >

Re: [Mesa-dev] [PATCH 2/7] EGL: Implement eglLabelObjectKHR

2016-09-12 Thread Emil Velikov
On 9 September 2016 at 18:51, Adam Jackson wrote: > On Fri, 2016-09-09 at 11:27 +0100, Emil Velikov wrote: >> > On 8 September 2016 at 18:46, Adam Jackson wrote: >> > From: Kyle Brenneman >> >> Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource >> structs. Implemented the function

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 07:44, Jonathan Gray wrote: > On Mon, Sep 12, 2016 at 09:28:58AM +1000, Timothy Arceri wrote: >> On Thu, 2016-09-08 at 18:39 +0100, Emil Velikov wrote: >> > On 1 September 2016 at 18:12, Jonathan Gray wrote: >> > > >> > > program_invocation_short_name is a gnu extension.??

Re: [Mesa-dev] [PATCH v2] tgsi: document semantics for compute shaders

2016-09-12 Thread Nicolai Hähnle
Thanks for doing this! Reviewed-by: Nicolai Hähnle On 10.09.2016 17:10, Samuel Pitoiset wrote: Cc: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/tgsi.rst | 28 1 file changed, 28 insertions(+) diff --git a/src/gallium/docs/source/tgs

[Mesa-dev] [PATCH 2/2] aubinator: print_help swap "FILE *file" with "bool critical"

2016-09-12 Thread Emil Velikov
From: Emil Velikov Derive file locally and exit() accordingly based on the bool. Allows us to save a couple lines of code. Signed-off-by: Emil Velikov --- s/print_help/print_help_and_exit/ and/or too bike sheddy ? --- src/intel/tools/aubinator.c | 22 ++ 1 file changed, 10

[Mesa-dev] [PATCH 1/2] aubinator: rework print_help()

2016-09-12 Thread Emil Velikov
From: Emil Velikov Rather than using platform specific methods to retrieve the program name pass it explicitly. The function is called directly from main(). Similarly - basename comes in two versions POSIX (can modify string, always pass a copy) and GNU (never modifies the string). Just printou

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák This fixes 8 fs-interpolateat* piglit crashes on radeonsi, because it can't handle non-input operands in interpolateAt*. --- src/compiler/glsl/link_varyings.cpp | 5 + src/compiler/glsl/opt_algebraic.c

Re: [Mesa-dev] [PATCH] mesa: fix glGetFramebufferAttachmentParameteriv w/ on-demand FRONT_BACK alloc

2016-09-12 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák This fixes 66 CTS tests on st/mesa. Cc: 12.0 --- src/mesa/main/fbobject.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbo

Re: [Mesa-dev] [PATCH] tgsi/scan: don't set interp flags for inputs only used by INTERP instructions

2016-09-12 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák radeonsi depends on the interp flags a little bit too much. This fixes 9 randomly failing tests: GL45-CTS.shader_multisample_interpolation.render.interpolate_at_centroid.* --- src/gallium/auxiliary/tgsi/

Re: [Mesa-dev] [PATCH 1/2] aubinator: rework print_help()

2016-09-12 Thread Jonathan Gray
On Mon, Sep 12, 2016 at 12:59:11PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Rather than using platform specific methods to retrieve the program > name pass it explicitly. The function is called directly from main(). > > Similarly - basename comes in two versions POSIX (can modify stri

[Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Emil Velikov
From: Emil Velikov A earlier sync with the Khronos headers added _extension_ prototype guards to all the GLES2/3/31/32 core entry points. Effectively breaking all the applications that aim to be portable and do not set the define. The issue has been reported to Khronos (internal bugzilla #14206)

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Marek Olšák
On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Support multi-planar YUV for external EGLImage's (currently just in the > dma-buf import path) by lowering to multiple texture fetch's for each > plane and CSC in shader. > > Signed-off-by: Rob Clark > --- > src/gallium/auxiliary/util/u_inlines

Re: [Mesa-dev] [PATCH 4/7] mesa/st: a bit of basic_variant refactoring

2016-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Add a helper to initialize the key, and pass the key into the helper > that iterates the variants, similar to how it works for vp/fp variants. > > The 'prog' arg to the helper gets used in a following patch, and

Re: [Mesa-dev] [PATCH 5/7] mesa/st: pass st_compute_program to st_get_cp_variant

2016-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Makes it more consistent with vp/fp variants, and will be needed in a > following patch. > > Signed-off-by: Rob Clark > --- > src/mesa/state_tracker/st_atom_shader.c | 2 +- > src/mesa/state_tracker/st_program

Re: [Mesa-dev] [PATCH 6/7] mesa/st: pass prog to st_get_basic_variant()

2016-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Needed in a following patch. > > Signed-off-by: Rob Clark > --- > src/mesa/state_tracker/st_atom_shader.c | 6 +++--- > src/mesa/state_tracker/st_program.c | 16 > src/mesa/state_tracker/s

Re: [Mesa-dev] [PATCH 7/7] mesa/st: support for YUV in VS/VS/GS/TCS/TEC..

2016-09-12 Thread Marek Olšák
On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > maybe we don't keep these bits? Yeah, I don't like this. It's just additional overhead for nothing. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Christian König
Am 12.09.2016 um 15:01 schrieb Marek Olšák: On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: Support multi-planar YUV for external EGLImage's (currently just in the dma-buf import path) by lowering to multiple texture fetch's for each plane and CSC in shader. Signed-off-by: Rob Clark --- s

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Daniel Stone
Hi, On 12 September 2016 at 13:37, Emil Velikov wrote: > A earlier sync with the Khronos headers added _extension_ prototype > guards to all the GLES2/3/31/32 core entry points. Effectively breaking > all the applications that aim to be portable and do not set the define. > > The issue has been r

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

2016-09-12 Thread Leo Liu
On 09/12/2016 04:31 AM, Michel Dänzer wrote: On 10/09/16 12:49 AM, Nayan Deshmukh wrote: In case of prime when rendering is done on GPU other then the server GPU, use a seprate linear buffer for each back buffer which will be displayed using present extension. v2: Use a seprate linear buffer

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Ilia Mirkin
On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov wrote: > From: Emil Velikov > > A earlier sync with the Khronos headers added _extension_ prototype > guards to all the GLES2/3/31/32 core entry points. Effectively breaking > all the applications that aim to be portable and do not set the define. > >

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Rob Clark
On Mon, Sep 12, 2016 at 9:01 AM, Marek Olšák wrote: > On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: >> Support multi-planar YUV for external EGLImage's (currently just in the >> dma-buf import path) by lowering to multiple texture fetch's for each >> plane and CSC in shader. >> >> Signed-off-

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Connor Abbott
Since demoted inputs become global variables, wouldn't it be more efficient to simply turn it into a straight assignment? Then the backend wouldn't have to initialize it to a constant (since it would be undefined). On Fri, Sep 9, 2016 at 10:06 AM, Marek Olšák wrote: > From: Marek Olšák > > This

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

2016-09-12 Thread Emil Velikov
Hi James, On 8 September 2016 at 17:27, Emil Velikov wrote: > In order to clear any ambiguity in EGL_EXT_device_drm we need to > "s/DRM driver./DRM driver which support KMS./". With that small change > things should be fine. > > Further to the above (trivial) clarification can we update the spec

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 14:51, Ilia Mirkin wrote: > On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> A earlier sync with the Khronos headers added _extension_ prototype >> guards to all the GLES2/3/31/32 core entry points. Effectively breaking >> all the applic

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

2016-09-12 Thread Brian Paul
I'm still using the MinGW gcc 4.6 compiler. I'd rather not go through the upgrade hassle if I don't have to. -Brian On 09/06/2016 10:28 PM, Timothy Arceri wrote: The last time this was bumped we settled on 4.2.0 because OpenBSD wasn't shipping anything greater than 4.2.1 (as that was the la

[Mesa-dev] [Bug 35607] glXWaitVideoSyncSGI() function freezes at resolution change

2016-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35607 Eero Tamminen changed: What|Removed |Added Status|NEW |NEEDINFO CC|

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Ilia Mirkin
On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov wrote: > Keeping diff/patches in git always felt like a hack, imho. Plus > most/all(?) distros rely on the Mesa headers, so I'm not sure how that > is going to work. The alternatives are considerably more painful for just a handful of files with a sm

Re: [Mesa-dev] [PATCH 1/2] i965: check for GL_TEXTURE_EXTERNAL_OES at miptree_create_for_teximage

2016-09-12 Thread Alejandro Piñeiro
I forgot to CC Jason, that made the review of the original commit. Sorry for the noise. On 11/09/16 00:07, Alejandro Piñeiro wrote: > Forgotten on commit "i965: Fix calculation of the image height at start > level". > > Thanks to Ilia Mirkin for point it. > > Fixes the following regressions on

[Mesa-dev] [Bug 97608] Account request

2016-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97608 Brian Paul changed: What|Removed |Added Version|git |unspecified Component|Other

Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-12 Thread Weng, Chuanbo
Ping for review. -Original Message- From: mesa-stable [mailto:mesa-stable-boun...@lists.freedesktop.org] On Behalf Of Chuanbo Weng Sent: Tuesday, September 6, 2016 5:29 PM To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com Cc: mesa-sta...@lists.freedesktop.org; Weng, Chuanbo Su

Re: [Mesa-dev] [PATCH v2 08/14] gallium: add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK

2016-09-12 Thread Nicolai Hähnle
On 11.09.2016 20:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

2016-09-12 Thread James Jones
On 09/12/2016 07:00 AM, Emil Velikov wrote: Hi James, On 8 September 2016 at 17:27, Emil Velikov wrote: In order to clear any ambiguity in EGL_EXT_device_drm we need to "s/DRM driver./DRM driver which support KMS./". With that small change things should be fine. Further to the above (trivi

[Mesa-dev] [Bug 34495] Selecting objects in Blender 2.56 slow due the software gl_select mode

2016-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34495 Eero Tamminen changed: What|Removed |Added See Also||https://bugs.freedesktop.or

Re: [Mesa-dev] [PATCH v2 11/14] st/mesa: expose ARB_compute_variable_group_size

2016-09-12 Thread Nicolai Hähnle
On 11.09.2016 20:45, Samuel Pitoiset wrote: This extension is only exposed if the underlying driver supports ARB_compute_shader and if PIPE_COMPUTE_MAX_VARIABLE_THREADS_PER_BLOCK is set. v2: - expose the ext based on that new cap Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_

Re: [Mesa-dev] [PATCH 1/2] i965: check for GL_TEXTURE_EXTERNAL_OES at miptree_create_for_teximage

2016-09-12 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sat, Sep 10, 2016 at 3:07 PM, Alejandro Piñeiro wrote: > Forgotten on commit "i965: Fix calculation of the image height at start > level". > > Thanks to Ilia Mirkin for point it. > > Fixes the following regressions on Haswell and Broadwell: > ES2-CTS.gtf.GL2Extens

Re: [Mesa-dev] [PATCH v2 08/14] gallium: add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK

2016-09-12 Thread Nicolai Hähnle
On 11.09.2016 20:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c |

Re: [Mesa-dev] [PATCH v2 08/14] gallium: add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK

2016-09-12 Thread Samuel Pitoiset
On 09/12/2016 05:35 PM, Nicolai Hähnle wrote: On 11.09.2016 20:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++

Re: [Mesa-dev] [PATCH v2 08/14] gallium: add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK

2016-09-12 Thread Samuel Pitoiset
On 09/12/2016 05:19 PM, Nicolai Hähnle wrote: On 11.09.2016 20:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++

Re: [Mesa-dev] [PATCH v2 11/14] st/mesa: expose ARB_compute_variable_group_size

2016-09-12 Thread Samuel Pitoiset
On 09/12/2016 05:26 PM, Nicolai Hähnle wrote: On 11.09.2016 20:45, Samuel Pitoiset wrote: This extension is only exposed if the underlying driver supports ARB_compute_shader and if PIPE_COMPUTE_MAX_VARIABLE_THREADS_PER_BLOCK is set. v2: - expose the ext based on that new cap Signed-off-by:

Re: [Mesa-dev] [PATCH] st/mesa: fix is_scissor_enabled when X/Y are negative

2016-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Sep 11, 2016 at 7:40 PM, Ilia Mirkin wrote: > Similar to commit 49c24d8a24 ("i965: fix noop_scissor range issue on > width/height") - take the X/Y into account to determine whether the > scissor covers the whole area or not. > > Fixes the recently-added gl

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 15:35, Ilia Mirkin wrote: > On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov > wrote: >> Keeping diff/patches in git always felt like a hack, imho. Plus >> most/all(?) distros rely on the Mesa headers, so I'm not sure how that >> is going to work. > > The alternatives are c

Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-12 Thread Emil Velikov
On 12 September 2016 at 16:09, Weng, Chuanbo wrote: > Ping for review. > R-b and pushed to master. Thanks for the reminder Chuanbo. Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-12 Thread Ilia Mirkin
On Mon, Sep 12, 2016 at 11:55 AM, Emil Velikov wrote: > On 12 September 2016 at 15:35, Ilia Mirkin wrote: >> On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov >> wrote: >>> Keeping diff/patches in git always felt like a hack, imho. Plus >>> most/all(?) distros rely on the Mesa headers, so I'm not

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

2016-09-12 Thread Jose Fonseca
We're internally building and shipping Mesa compiled with GCC 4.4 (more specifically 4.4.3). It's fine if you require GCC 4.8 on automake, but please leave support for GCC 4.4.x in SCons. Jose On 07/09/16 05:28, Timothy Arceri wrote: The last time this was bumped we settled on 4.2.0 because

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Marek Olšák
On Mon, Sep 12, 2016 at 4:04 PM, Rob Clark wrote: > On Mon, Sep 12, 2016 at 9:01 AM, Marek Olšák wrote: >> On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: >>> Support multi-planar YUV for external EGLImage's (currently just in the >>> dma-buf import path) by lowering to multiple texture fetch'

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Marek Olšák
On Mon, Sep 12, 2016 at 4:05 PM, Connor Abbott wrote: > Since demoted inputs become global variables, wouldn't it be more > efficient to simply turn it into a straight assignment? Then the > backend wouldn't have to initialize it to a constant (since it would > be undefined). Maybe, but there are

Re: [Mesa-dev] [PATCH v2 11/14] st/mesa: expose ARB_compute_variable_group_size

2016-09-12 Thread Nicolai Hähnle
On 12.09.2016 17:43, Samuel Pitoiset wrote: On 09/12/2016 05:26 PM, Nicolai Hähnle wrote: On 11.09.2016 20:45, Samuel Pitoiset wrote: This extension is only exposed if the underlying driver supports ARB_compute_shader and if PIPE_COMPUTE_MAX_VARIABLE_THREADS_PER_BLOCK is set. v2: - expose

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

2016-09-12 Thread Nayan Deshmukh
Hi Michel, On Mon, Sep 12, 2016 at 7:02 PM, Leo Liu wrote: > > > On 09/12/2016 04:31 AM, Michel Dänzer wrote: > >> On 10/09/16 12:49 AM, Nayan Deshmukh wrote: >> >>> In case of prime when rendering is done on GPU other then the >>> server GPU, use a seprate linear buffer for each back buffer >>

Re: [Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

2016-09-12 Thread Nanley Chery
On Fri, Sep 09, 2016 at 07:25:46PM -0700, Jason Ekstrand wrote: > On Fri, Sep 9, 2016 at 5:47 PM, Nanley Chery wrote: > > > On Wed, Aug 31, 2016 at 02:22:49PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/Makefile.sources | 1 - > > > src/intel/vulkan/anv_blorp.c | 184 +++

Re: [Mesa-dev] [PATCH 00/57] i965/ir: Switch representation of register offsets and sizes to byte units.

2016-09-12 Thread Francisco Jerez
Iago Toral writes: > On Fri, 2016-09-09 at 11:37 +0200, Iago Toral wrote: >> On Thu, 2016-09-08 at 11:36 +0200, Iago Toral wrote: >> > >> > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: >> > > >> > > >> > > This series reworks the representation of register region offsets >> > > in

[Mesa-dev] [PATCH v2 30.1/33] anv/blorp: Add a gcd_pow2_u64 helper and use it

2016-09-12 Thread Jason Ekstrand
This is a lot cleaner and easier to read than the old piles of if statements. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_blorp.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel

[Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
Three new features: 1. Disk/block I/O device read/write stats MB/ps. 2. Network Interface RX/TX transfer statistics as a percentage of the overall NIC speed. 3. lmsensor power, voltage and temperature sensors. The lmsensor changes makes a dependency on libsensors so support so the change is opt

Re: [Mesa-dev] [PATCH v2 30.1/33] anv/blorp: Add a gcd_pow2_u64 helper and use it

2016-09-12 Thread Nanley Chery
On Mon, Sep 12, 2016 at 11:11:25AM -0700, Jason Ekstrand wrote: > This is a lot cleaner and easier to read than the old piles of if > statements. > > Signed-off-by: Jason Ekstrand > --- > src/intel/vulkan/anv_blorp.c | 48 > ++-- > 1 file changed, 24 inse

Re: [Mesa-dev] [PATCH 2/2] aubinator: print_help swap "FILE *file" with "bool critical"

2016-09-12 Thread Kristian Høgsberg
On Mon, Sep 12, 2016 at 4:59 AM, Emil Velikov wrote: > From: Emil Velikov > > Derive file locally and exit() accordingly based on the bool. > Allows us to save a couple lines of code. > If we're nit-picking, I'd rather just pass the exit code than a bool parameter. Kristian > Signed-off-by: Em

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Karol Herbst
Hey, nice work regarding the lmsensor bits. But I think it makes sense to also wire the power things in, cause we actually expose them within nouveau. Others might want or actually do the same as well. Many thanks 2016-09-12 20:33 GMT+02:00 Steven Toth : > Three new features: > 1. Disk/block I/O

Re: [Mesa-dev] [PATCH 27/33] anv: Use blorp for CopyImageToBuffer

2016-09-12 Thread Nanley Chery
On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 134 > +++ > src/intel/vulkan/anv_meta_copy.c | 16 - > 2 files changed, 134 insertions(+), 16 deletions(-) > > diff --git a/src/intel/vulkan/anv_bl

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Rob Clark
On Sat, Sep 10, 2016 at 10:04 AM, Roland Scheidegger wrote: > Am 09.09.2016 um 02:58 schrieb Rob Clark: >> On Thu, Sep 8, 2016 at 8:28 PM, Roland Scheidegger >> wrote: >>> Am 09.09.2016 um 02:19 schrieb Rob Clark: On Thu, Sep 8, 2016 at 7:54 PM, Rob Clark wrote: > On Thu, Sep 8, 2016 a

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Brian Paul
Steven, Can you enclose all the unix-specific parts in #ifdef PIPE_OS_UNIX to allow this to build for Windows? -Brian On Mon, Sep 12, 2016 at 1:22 PM, Karol Herbst wrote: > Hey, > > nice work regarding the lmsensor bits. But I think it makes sense to > also wire the power things in, cause we

Re: [Mesa-dev] [PATCH 27/33] anv: Use blorp for CopyImageToBuffer

2016-09-12 Thread Jason Ekstrand
On Mon, Sep 12, 2016 at 12:30 PM, Nanley Chery wrote: > On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 134 ++ > + > > src/intel/vulkan/anv_meta_copy.c | 16 - > > 2 files changed, 134 insert

[Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL.

2016-09-12 Thread Kyle Brenneman
Remove a couple of leftover hacks in the previous libglvnd patch. --- src/egl/main/egldispatchstubs.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/egl/main/egldispatchstubs.c b/src/egl/main/egldispatchstubs.c index 212a1fd..e02abd7 100644 --- a/src/egl

Re: [Mesa-dev] [PATCH 27/33] anv: Use blorp for CopyImageToBuffer

2016-09-12 Thread Nanley Chery
On Mon, Sep 12, 2016 at 12:45:51PM -0700, Jason Ekstrand wrote: > On Mon, Sep 12, 2016 at 12:30 PM, Nanley Chery > wrote: > > > On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_blorp.c | 134 ++ > > + > >

Re: [Mesa-dev] [PATCH 00/57] i965/ir: Switch representation of register offsets and sizes to byte units.

2016-09-12 Thread Francisco Jerez
Francisco Jerez writes: > Iago Toral writes: > >> On Fri, 2016-09-09 at 11:37 +0200, Iago Toral wrote: >>> On Thu, 2016-09-08 at 11:36 +0200, Iago Toral wrote: >>> > >>> > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: >>> > > >>> > > >>> > > This series reworks the representation

Re: [Mesa-dev] [PATCH 27/33] anv: Use blorp for CopyImageToBuffer

2016-09-12 Thread Jason Ekstrand
On Sep 12, 2016 1:31 PM, "Nanley Chery" wrote: > > On Mon, Sep 12, 2016 at 12:45:51PM -0700, Jason Ekstrand wrote: > > On Mon, Sep 12, 2016 at 12:30 PM, Nanley Chery > > wrote: > > > > > On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote: > > > > --- > > > > src/intel/vulkan/anv_blor

Re: [Mesa-dev] [PATCH 48/95] i965/vec4: add a force_vstride0 flag to src_reg

2016-09-12 Thread Francisco Jerez
Iago Toral Quiroga writes: > We will use this in cases where we want to force the vstride of a src_reg > to 0 to exploit a particular behavior of the hardware. It will come in > handy to implement access to components Z/W. > --- > src/mesa/drivers/dri/i965/brw_ir_vec4.h | 1 + > src/mesa/drivers

Re: [Mesa-dev] [PATCH 53/95] i965/disasm: fix subreg for dst in Align16 mode

2016-09-12 Thread Francisco Jerez
Iago Toral Quiroga writes: > There is a single bit for this, so it is a binary 0 or 1 meaning > offset 0B or 16B respectively. > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c > b/src/m

[Mesa-dev] [PATCH 1/2] ddebug: fix a crash in resource_get_handle

2016-09-12 Thread Marek Olšák
From: Marek Olšák broken recently --- src/gallium/drivers/ddebug/dd_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_screen.c b/src/gallium/drivers/ddebug/dd_screen.c index 4050e39..a0c0dd0 100644 --- a/src/gallium/drivers/ddebug/dd_scre

[Mesa-dev] [PATCH 2/2] ddebug: dump shader buffers and images

2016-09-12 Thread Marek Olšák
From: Marek Olšák this was unimplemented --- src/gallium/auxiliary/util/u_dump.h | 3 +++ src/gallium/auxiliary/util/u_dump_state.c | 19 +++ src/gallium/drivers/ddebug/dd_draw.c | 30 +++--- 3 files changed, 49 insertions(+), 3 deletions(-) d

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> nice work regarding the lmsensor bits. But I think it makes sense to > also wire the power things in, cause we actually expose them within > nouveau. Others might want or actually do the same as well. Karol, thank you for your feedback. I'm happy and willing to adapt to any changes recommended.

Re: [Mesa-dev] [PATCH 62/95] i965/vec4: Add a shuffle_64bit_data helper

2016-09-12 Thread Francisco Jerez
Iago Toral Quiroga writes: > SIMD4x2 64bit data is stored in register space like this: > > r0.0:DF x0 y0 z0 w0 > r0.1:DF x1 y1 z1 w1 > > When we need to write data such as this to memory using 32-bit write > messages we need to shuffle it in this fashion: > > r0.0:DF x0 y0 x1 y1 > r0.1:DF z0

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> Can you enclose all the unix-specific parts in #ifdef PIPE_OS_UNIX to allow > this to build for Windows? > > -Brian Brian, thank you for your feedback. Whoops! Yes, I'll take care of this. -- Steven Toth - Kernel Labs http://www.kernellabs.com +1.646.355.8490 _

[Mesa-dev] [PATCH shader-db] add a new option for selecting the render node ID

2016-09-12 Thread Samuel Pitoiset
When multiple GPUs are plugged in the same box, we might want to use /dev/dri/renderD129 without updating/compiling the code. This doesn't change the existing behaviour. --- run.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/run.c b/run.c index c7f0b

[Mesa-dev] [PATCH] anv/cmd_buffer: Set the L3 atomic disable mask bit in CHICKEN3 on HSW

2016-09-12 Thread Jason Ekstrand
Without this bit set, the value in "L3 Atomic Disable" won't get applied by the hardware so we won't properly get L3 atomic caching. Fixes dEQP-VK.spirv_assembly.instruction.compute.opatomic.compex on HSW Signed-off-by: Jason Ekstrand Cc: Lionel Landwerlin Cc: Francisco Jerez --- src/intel/ge

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Set the L3 atomic disable mask bit in CHICKEN3 on HSW

2016-09-12 Thread Francisco Jerez
Jason Ekstrand writes: > Without this bit set, the value in "L3 Atomic Disable" won't get applied by > the hardware so we won't properly get L3 atomic caching. > > Fixes dEQP-VK.spirv_assembly.instruction.compute.opatomic.compex on HSW > > Signed-off-by: Jason Ekstrand > Cc: Lionel Landwerlin >

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Karol Herbst
2016-09-12 23:20 GMT+02:00 Steven Toth : >> nice work regarding the lmsensor bits. But I think it makes sense to >> also wire the power things in, cause we actually expose them within >> nouveau. Others might want or actually do the same as well. > > Karol, thank you for your feedback. > > I'm happ

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> I think you expose Temperature, Voltage and Current. But Nouveau exposes > Temperature, Voltage, Fan and Power through hwmon. > > Read the "power" section here for more info: > https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface Ahh, my nouveau card must be too old then. I only get te

[Mesa-dev] [PATCH 2/3] blorp: Handle the 512 layers restriction on Sandy Bridge

2016-09-12 Thread Jason Ekstrand
--- src/intel/blorp/blorp.c | 6 ++ src/intel/blorp/blorp_clear.c | 17 + 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c index 17c1ff4..8dfebbc 100644 --- a/src/intel/blorp/blorp.c +++ b/src/intel/blorp/b

[Mesa-dev] [PATCH 1/3] intel/isl: Treat 3-D textures as 2-D arrays for rendering

2016-09-12 Thread Jason Ekstrand
In particular, this means that isl_view::base_array_layer and isl_view::array_len get applied to 3-D textures but only when rendering. We were already applying isl_view::base_array_layer for rendering into 3-D textures so this isn't a huge deviation. Signed-off-by: Jason Ekstrand Cc: Chad Versace

[Mesa-dev] [PATCH 3/3] Revert "i965: Drop the maximum 3D texture size to 512 on Sandy Bridge"

2016-09-12 Thread Jason Ekstrand
This reverts commit 6ba88bce64b343761aabe3a6c7ee285c6020a959. The commit was erroneous because GL already provides a separate guard on the number of layers you are allowed to render into. On Sandy Bridge, we set this guard correctly so creating a 3D texture bigger than 512 is fine, you just can't

[Mesa-dev] [PATCH 00/14] EGL_KHR_debug v3

2016-09-12 Thread Adam Jackson
This gets us to basically the same end state as before, but I've rearranged the sequence of changes to be a little easier to review and not introduce broken intermediate states. 01 updates eglext.h to the very latest. 02 is a bugfix for leaking images and syncs at eglTerminate, pointed out in revi

[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them when appropriate. This would be useful enough for debugging on its own,

[Mesa-dev] [PATCH 07/14] egl: Factor out _eglWaitClientCommon

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index fac2d18..a74e5e4 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1081,8 +1081,8 @@ eglCopyBuffers(

[Mesa-dev] [PATCH 04/14] egl: Factor out _eglGetPlatformDisplayCommon

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index ba8305e..df355a5 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -295,9 +295,9 @@ eglGetDis

[Mesa-dev] [PATCH 02/14] egl: Tear down images and syncs at eglTerminate

2016-09-12 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/main/egldisplay.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c index bbc3063..3d4eb81 100644 --- a/src/egl/main/egldisplay.c +++ b/src/egl/main/egldisplay.c @@ -44,6 +44,8

[Mesa-dev] [PATCH 09/14] egl: Lock the display in _eglCreateSync's callers

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 658d0d7..dc61d5f 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1384,11 +1384,10 @@ eglDestroy

[Mesa-dev] [PATCH 03/14] egl: Fix typo

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglglobals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglglobals.c b/src/egl/main/eglglobals.c index 938d953..04bb5ba 100644 --- a/src/egl/main/eglglobals.c +++ b/src/egl/main/eglglobals.c @@ -50,7 +50,7 @@ struct _egl

[Mesa-dev] [PATCH 05/14] egl: Use _eglCreateWindowSurfaceCommon consistently

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman This moves the native window fixup to a helper function so we don't repeat ourselves. --- src/egl/main/eglapi.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index df355a5..dd2

[Mesa-dev] [PATCH 10/14] egl: Factor out _eglWaitSyncCommon

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index dc61d5f..c285c20 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1509,11 +1509,9 @@ eglCli

[Mesa-dev] [PATCH 11/14] egl: Factor out _eglGetSyncAttribCommon

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index c285c20..0477ad9 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1570,11 +1570,9 @@ eglSig

[Mesa-dev] [PATCH 12/14] egl: Add storage for EGL_KHR_debug's state to EGL objects

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglcurrent.c | 3 +-- src/egl/main/eglcurrent.h | 8 src/egl/main/egldisplay.h | 4 src/egl/main/eglglobals.c | 5 - src/egl/main/eglglobals.h | 10 ++ 5 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/egl/main

[Mesa-dev] [PATCH 06/14] egl: Use _eglCreatePixmapSurfaceCommon consistently

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman This moves the native pixmap fixup to a helper function so we don't repeat ourselves. --- src/egl/main/eglapi.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index dd2b

[Mesa-dev] [PATCH 01/14] egl: Update eglext.h (v2)

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman Updated eglext.h to revision 33111 from the Khronos repository. v2: - Don't (re)move extension includes from eglext.h (Emil Velikov) - Bump to revision 33111 (Adam Jackson) Reviewed-by: Adam Jackson --- include/EGL/eglext.h | 121 ++

[Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman Wire up the debug entrypoints to EGL dispatch, and add the extension string to the client extension list. --- src/egl/main/eglapi.c | 140 ++ src/egl/main/eglglobals.c | 3 +- 2 files changed, 142 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 08/14] egl: Factor out _eglCreateImageCommon

2016-09-12 Thread Adam Jackson
From: Kyle Brenneman --- src/egl/main/eglapi.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index a74e5e4..658d0d7 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1309,11 +1309,10 @@ eglRele

Re: [Mesa-dev] [PATCH 1/3] intel/isl: Treat 3-D textures as 2-D arrays for rendering

2016-09-12 Thread Kenneth Graunke
On Monday, September 12, 2016 3:16:29 PM PDT Jason Ekstrand wrote: > In particular, this means that isl_view::base_array_layer and > isl_view::array_len get applied to 3-D textures but only when rendering. > We were already applying isl_view::base_array_layer for rendering into 3-D > textures so th

  1   2   >