Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

2016-05-04 Thread Iago Toral
On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: Connor Abbott > > > > Similar to retype() and offset(). > > --- > > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/mesa/dri

Re: [Mesa-dev] [PATCHv2 10/23] i965/fs: Stop using the LOAD_PAYLOAD instruction in lower_simd_width.

2016-05-04 Thread Iago Toral
Thanks Curro! I have tested this with our fp64 branch in BDW and it works fine. FWIW, I also tested it in IVB with shader.py and did not see any regressions, so we will include it in our branch. Iago On Tue, 2016-05-03 at 21:26 -0700, Francisco Jerez wrote: > Instead of using the LOAD_PAYLOAD in

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

2016-05-04 Thread Iago Toral
On Wed, 2016-05-04 at 09:50 +0200, Iago Toral wrote: > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > > Samuel Iglesias Gonsálvez writes: > > > > > From: Connor Abbott > > > > > > Similar to retype() and offset(). > > > --- > > > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 >

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

2016-05-04 Thread Francisco Jerez
Iago Toral writes: > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: Connor Abbott >> > >> > Similar to retype() and offset(). >> > --- >> > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 >> > 1 file changed, 8 insertions(+) >>

Re: [Mesa-dev] [PATCH] i965/fs: Follow pow(16) instructions with a NOP.

2016-05-04 Thread Francisco Jerez
Matt Turner writes: > On Tue, May 3, 2016 at 3:28 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on >>> Gen >= 8 platforms. This patch avoids the GPU hangs, but does not >>> implement a full work around for the restr

Re: [Mesa-dev] [PATCH 37/59] i965/fs: generalize SIMD16 interference workaround

2016-05-04 Thread Francisco Jerez
Connor Abbott writes: > On Tue, May 3, 2016 at 6:16 PM, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> From: Connor Abbott >>> >>> Work based on registers read/written instead of dispatch_width, so that >>> the interferences are added for 64-bit sources/destinations as well

Re: [Mesa-dev] [PATCH] vulkan: Fix use of uninitialized variable.

2016-05-04 Thread Eric Engestrom
On Tue, May 03, 2016 at 06:46:39PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > The return variable was not set for failure paths. > It has now been changed to VK_ERROR_INITIALIZATION_FAILED > for failure paths. > > Coverity: 1358944 > Signed-off-by: Robert Foss > --- > src/

Re: [Mesa-dev] [PATCH 03/59] freedreno/ir3: lower lrp when operating with double operands

2016-05-04 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 This patch is still unreviewed. Rob, Can you take a look at it? Sam On 29/04/16 13:29, Samuel Iglesias Gonsálvez wrote: > Lower lrp when operating with double operands because float version > of lrp is also lowered. > > Signed-off-by: Samuel Igles

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

2016-05-04 Thread Iago Toral
On Wed, 2016-05-04 at 01:15 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > >> Samuel Iglesias Gonsálvez writes: > >> > >> > From: Connor Abbott > >> > > >> > Similar to retype() and offset(). > >> > --- > >> > src/mesa/driv

[Mesa-dev] [PATCH] egl/wayland: Avoid race conditions when on non-main thread

2016-05-04 Thread Jonas Ådahl
When EGL is used on some other thread than the thread that drives the main wl_display queue, the Wayland EGL dri2 implementation is vulnerable to a race condition related to display round trips and global object advertisements. The race that may happen is that after after a proxy is created, but b

Re: [Mesa-dev] [PATCH 31/59] i965/fs: optimize pack double

2016-05-04 Thread Iago Toral
On Mon, 2016-05-02 at 15:11 -0400, Connor Abbott wrote: > On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez > wrote: > > From: Iago Toral Quiroga > > > > When we are actually creating a double using values obtained from a > > previous unpack operation we can bypass the unpack and source

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-04 Thread Iago Toral
On Mon, 2016-05-02 at 11:38 +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez wrote: > > From: Iago Toral Quiroga > > > > When we are actually unpacking from a double that we have previously > > packed from its 32-bit components we can bypass th

Re: [Mesa-dev] [PATCH] egl/wayland: Avoid race conditions when on non-main thread

2016-05-04 Thread Daniel Stone
Hi Jonas, On 4 May 2016 at 09:53, Jonas Ådahl wrote: > When EGL is used on some other thread than the thread that drives the > main wl_display queue, the Wayland EGL dri2 implementation is > vulnerable to a race condition related to display round trips and global > object advertisements. > > The

[Mesa-dev] [PATCH] glsl: Copy propagate in array index function parameters

2016-05-04 Thread Juan A. Suarez Romero
Copy propagate is not applied in function parameters when they are out or inout. But if the parameter is an array, we can copy propagate the index array. This also fixes several shaders@out-parameter-indexing piglit tests, that exposes a wrong handling of inout function parameters in Mesa. This

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-04 Thread Iago Toral
On Tue, 2016-05-03 at 17:37 -0700, Jason Ekstrand wrote: > > > On Tue, May 3, 2016 at 5:21 AM, Samuel Iglesias Gonsálvez > wrote: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the > start > of the region. This m

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

2016-05-04 Thread Kenneth Graunke
On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: > From: Alejandro Piñeiro > > This commit adds support for PASSTHRU format when pushing > double-precision attributes. > > Check glarray->Doubles in order to know if we should choose a format > that does a conversion to float, or ju

Re: [Mesa-dev] [PATCH 12/15] i965: abort linking if URB read length greater than 15

2016-05-04 Thread Kenneth Graunke
On Thursday, April 28, 2016 1:40:42 PM PDT Antia Puentes wrote: > From: "Juan A. Suarez Romero" > > In scalar mode, URB read length limit is 15. Abort if we go beyond it. > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/dri

[Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

2016-05-04 Thread Emil Velikov
From: Emil Velikov Bail early, as opposed to later on during the build. Signed-off-by: Emil Velikov --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 5f75c60..0932871 100644 --- a/configure.ac +++ b/configure.ac @@ -142,6 +142,12 @@ el

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

2016-05-04 Thread Kenneth Graunke
On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > From the Broadwell specification, structure VERTEX_ELEMENT_STATE > description: > >"When SourceElementFormat is set to one of the *64*_PASSTHRU > formats, 64-bit components are stored in the URB without any > conversion

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

2016-05-04 Thread Antía Puentes
Hi Kenneth, thanks for reviewing. On mié, 2016-05-04 at 03:36 -0700, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > > > > From the Broadwell specification, structure VERTEX_ELEMENT_STATE > > description: > > > >    "When SourceElementFormat is set to

Re: [Mesa-dev] [PATCH 12/15] i965: abort linking if URB read length greater than 15

2016-05-04 Thread Juan A. Suarez Romero
On Wed, 2016-05-04 at 03:43 -0700, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:42 PM PDT Antia Puentes wrote: > > > > From: "Juan A. Suarez Romero" > > > > In scalar mode, URB read length limit is 15. Abort if we go beyond > > it. > > --- > >  src/mesa/drivers/dri/i965/brw_vec4.cpp

Re: [Mesa-dev] [PATCH 03/59] freedreno/ir3: lower lrp when operating with double operands

2016-05-04 Thread Rob Clark
On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez wrote: > Lower lrp when operating with double operands because float version of > lrp is also lowered. > > Signed-off-by: Samuel Iglesias Gonsálvez > CC: Rob Clark > --- > src/gallium/drivers/freedreno/ir3/ir3_nir.c | 1 + > 1 file chan

Re: [Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

2016-05-04 Thread Ilia Mirkin
Only if building Intel vulkan, no? Could that script just be fixed to work with python2 BTW? On May 4, 2016 6:44 AM, "Emil Velikov" wrote: > From: Emil Velikov > > Bail early, as opposed to later on during the build. > > Signed-off-by: Emil Velikov > --- > configure.ac | 6 ++ > 1 file cha

Re: [Mesa-dev] [PATCH] configure.ac: error out when building from git without python3

2016-05-04 Thread Emil Velikov
On 4 May 2016 at 13:08, Ilia Mirkin wrote: > Only if building Intel vulkan, no? I believe the idea is to move from python2 so this will do no harm as is. > Could that script just be fixed to work > with python2 BTW? > Possibly. The above 'moving away from python2' topic still applies imho. If we

Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

2016-05-04 Thread Rowley, Timothy O
After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. > On May 3, 2016, at 5:45 PM, robert.f...@collabora.com wrote: > > From: Robert Foss > > M

[Mesa-dev] [PATCH v2] vulkan: Fix use of uninitialized variable.

2016-05-04 Thread robert . foss
From: Robert Foss The return variable was not set for failure paths. It has now been changed to VK_ERROR_INITIALIZATION_FAILED for failure paths. Coverity: 1358944 Signed-off-by: Robert Foss --- Changes since v1: - Started using vk_error(). src/intel/vulkan/anv_wsi_wayland.c | 8 ++-- 1

[Mesa-dev] [PATCH v3] vulkan: Fix use of uninitialized variable.

2016-05-04 Thread robert . foss
From: Robert Foss The return variable was not set for failure paths. It has now been changed to VK_ERROR_INITIALIZATION_FAILED for failure paths. Coverity: 1358944 Reviewed-by: Eric Engestrom Signed-off-by: Robert Foss --- Changes since v1: - Started using vk_error(). Changes since v2: - Add

Re: [Mesa-dev] [PATCH] swr: Fix resource leak in object.

2016-05-04 Thread Robert Foss
On 05/04/2016 08:52 AM, Rowley, Timothy O wrote: After shader compilation, the gallivm_state is owned by ShaderVariant<> and destroyed by its destructor (swr_state.h) so that the generated JIT code and gallivm_state can be freed when no longer needed. Oh. Splendid. Thanks for looking into

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

2016-05-04 Thread Alejandro Piñeiro
On 04/05/16 12:31, Kenneth Graunke wrote: > On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: >> From: Alejandro Piñeiro >> >> This commit adds support for PASSTHRU format when pushing >> double-precision attributes. >> >> Check glarray->Doubles in order to know if we should choose

[Mesa-dev] [PATCH] anv: fix hang during generation of dev_icd.json.

2016-05-04 Thread Knut Andre Tidemann
--- src/intel/vulkan/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index fd8aae0..662d720 100644 --- a/src/intel/vulkan/Makefile.am +++ b/src/intel/vulkan/Makefile.am @@ -156,7 +156,7 @@ noinst_DATA = dev

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-05-04 Thread Knut Andre Tidemann
On fredag 22. april 2016 19.55.10 CEST Emil Velikov wrote: > From: Emil Velikov > > It's used only by dev_icd.json so just call it that way. While we're > here, manually expand $< (as it might cause issue on some systems) > and drop the unneeded install_libdir substitution. > > Cc: Jason Ekstran

Re: [Mesa-dev] [PATCHv2 10/23] i965/fs: Stop using the LOAD_PAYLOAD instruction in lower_simd_width.

2016-05-04 Thread Michael Schellenberger Costa
Hi Curro, Am 04.05.2016 um 06:26 schrieb Francisco Jerez: > Instead of using the LOAD_PAYLOAD instruction (emitted through the > emit_transpose() helper that is no longer useful and this commit > removes) which had to be marked force_writemask_all in some cases, > emit a series of moves to apply p

[Mesa-dev] [Bug 95211] scons TypeError: 'tuple' object is not callable

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95211 Jose Fonseca changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jfons...@vmware.com |or

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

2016-05-04 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/05/16 20:59, Kenneth Graunke wrote: > Other than patches 37, 56, and ones you agreed to drop, the series > is: Reviewed-by: Kenneth Graunke > > I think you can go ahead and land all except those, and we can > land new solutions for those pr

[Mesa-dev] [RFC demos] a mesa equivalent to vulkaninfo

2016-05-04 Thread Alejandro Piñeiro
Hi, some weeks ago Dave Airlie made the review for the ARB_internalformat_query2 extension support (again, thanks a lot), and at the end he suggested to create a "mesa-demos glxinfo super query app. Something that does what vulkaninfo kinda does" [1]. As I mentioned at the moment, I had a heavily

Re: [Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

2016-05-04 Thread Adam Jackson
On Mon, 2016-03-28 at 11:10 -0700, Ian Romanick wrote: > > @@ -428,7 +428,7 @@ class PrintGlxReqSize_h(PrintGlxReqSize_common): >   def printBody(self, api): > >  for func in api.functionIterateGlx(): > >  if not func.ignore and func.has_variable_size_request(): > > -  

Re: [Mesa-dev] [PATCH] swr: Remove stall waiting for core query counters.

2016-05-04 Thread Kyriazis, George
Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Thursday, April 28, 2016 12:13 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Remove stall waiting for core q

Re: [Mesa-dev] [PATCH] main: uses casts to silence some _mesa_debug() format warnings

2016-05-04 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh On Mon, May 02, 2016 at 07:15:11PM -0600, Brian Paul wrote: > Silences warnings with 32-bit Linux gcc builds and MinGW which doesn't > recognize the ‘t’ conversion character. > --- > src/mesa/main/bufferobj.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletio

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-05-04 Thread Eric Engestrom
On Tue, May 03, 2016 at 11:11:56AM -0400, Rob Clark wrote: > > Ok, I've renamed to REVIEWERS and scripts/get_reviewer.pl and updated > the verbage appropriately. scripts/get_reviewer.pl still obeys .get_maintainer.conf and .get_maintainer.ignore. Is that something we want to make more consistent?

[Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Andres Gomez
Hi, as part of the work done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Due to this, I've been checking and making modifications into the

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-05-04 Thread Rob Clark
On Wed, May 4, 2016 at 1:04 PM, Eric Engestrom wrote: > On Tue, May 03, 2016 at 11:11:56AM -0400, Rob Clark wrote: >> >> Ok, I've renamed to REVIEWERS and scripts/get_reviewer.pl and updated >> the verbage appropriately. > > scripts/get_reviewer.pl still obeys .get_maintainer.conf and > .get_maint

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Matt Turner
On Wed, May 4, 2016 at 10:05 AM, Andres Gomez wrote: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features > added by this addition.

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Connor Abbott
On Wed, May 4, 2016 at 1:05 PM, Andres Gomez wrote: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features > added by this addition.

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Ilia Mirkin
On Wed, May 4, 2016 at 1:41 PM, Connor Abbott wrote: > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez wrote: >> Hi, >> >> as part of the work done to "Add FP64 support to the i965 shader >> backends" at: >> https://bugs.freedesktop.org/show_bug.cgi?id=92760 >> >> I've been working to add piglit tes

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 Bug ID: 95266 Summary: Geometry missing from rendering, only when using Mesa. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #1 from David Lonie --- The "Reproduction of issue" attachment is a tar.bz2 file, btw. When I try to download it it just dumps the binary as character data to my browser...Let me know if I should re-upload it and do something differen

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #23 from David Lonie --- Opened a new bug: https://bugs.freedesktop.org/show_bug.cgi?id=95266 Feel free to close this one. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bu

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #2 from Ilia Mirkin --- You might consider including an apitrace that reproduces the issue. People are probably going to be less inclined to run some random binary off the interwebs. Also, is this only a bug with llvmpipe (and/or gal

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 Ilia Mirkin changed: What|Removed |Added Attachment #123465|text/plain |application/bzip2 mime type|

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Eirik Byrkjeflot Anonsen
Andres Gomez writes: > Hi, > > as part of the work done to "Add FP64 support to the i965 shader > backends" at: > https://bugs.freedesktop.org/show_bug.cgi?id=92760 > > I've been working to add piglit tests that would check the new features > added by this addition. > > Due to this, I've been che

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #3 from David Lonie --- I included an apitrace on the last bug, and was told that it was not suitable for reproducing bugs (something about apitrace forcing a 4.5 context IIRC). I can make one for this issue if anyone needs it. I sha

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Jan Vesely
On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez > > wrote: > > > > > > Hi, > > > > > > as part of the work done to "Add FP64 support to the i965 shader > > > backends" at: > > >

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #5 from Ilia Mirkin --- FWIW I was able to run your trace from the other bug with MESA_GL_VERSION_OVERRIDE=4.5 MESA_GLSL_VERSION_OVERRIDE=450 so I suspect that a trace of this issue would be nice to have as well. -- You are receiv

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #4 from Ilia Mirkin --- (In reply to David Lonie from comment #3) > I included an apitrace on the last bug, and was told that it was not > suitable for reproducing bugs (something about apitrace forcing a 4.5 > context IIRC). I can ma

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #6 from Jose Fonseca --- (In reply to David Lonie from comment #3) > I included an apitrace on the last bug, and was told that it was not > suitable for reproducing bugs (something about apitrace forcing a 4.5 > context IIRC). I can m

Re: [Mesa-dev] [PATCH] st/nine: clean up WINAPI definition

2016-05-04 Thread Christian Schmidbauer
On Sun, May 1, 2016 at 12:02 PM, Emil Velikov wrote: > Hi Christian, > > On 29 April 2016 at 19:53, Christian Schmidbauer > wrote: >> As Emil pointed out, only gcc, clang and MSVC compatibility is required. >> Hence the check for GNUC can be skipped, as __i386__ and __x86_64__ are >> only defined

Re: [Mesa-dev] [PATCH] st/nine: clean up WINAPI definition

2016-05-04 Thread Christian Schmidbauer
On Sun, May 1, 2016 at 6:03 PM, Axel Davy wrote: > Do we need the #ifndef WINAPI part ? > > Axel > > > On 29/04/2016 20:53, Christian Schmidbauer wrote: >> >> As Emil pointed out, only gcc, clang and MSVC compatibility is required. >> Hence the check for GNUC can be skipped, as __i386__ and __x86_

Re: [Mesa-dev] [PATCH 01/15] i965: get the proper vertex surface type for doubles on gen8+

2016-05-04 Thread Kenneth Graunke
On Wednesday, May 4, 2016 3:30:13 PM PDT Alejandro Piñeiro wrote: > > On 04/05/16 12:31, Kenneth Graunke wrote: > > On Thursday, April 28, 2016 1:40:31 PM PDT Antia Puentes wrote: > >> From: Alejandro Piñeiro > >> > >> This commit adds support for PASSTHRU format when pushing > >> double-precisio

Re: [Mesa-dev] [PATCH 02/15] i965: Configure how to store *64*PASSTHRU vertex components

2016-05-04 Thread Kenneth Graunke
On Wednesday, May 4, 2016 1:01:33 PM PDT Antía Puentes wrote: > Hi Kenneth, > > thanks for reviewing. > > On mié, 2016-05-04 at 03:36 -0700, Kenneth Graunke wrote: > > On Thursday, April 28, 2016 1:40:32 PM PDT Antia Puentes wrote: > > > > > > From the Broadwell specification, structure VERTEX_E

[Mesa-dev] [PATCH 1/6] glapi: Fix whitespace droppings when printing the license header

2016-05-04 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 2e7123e..e11f6fc 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++ b/src/mapi/glapi/gen/gl_XML.py @@ -130,

[Mesa-dev] [PATCH 2/6] glapi: Add the safe_{add, mul, pad} functions from xserver

2016-05-04 Thread Adam Jackson
We're about to update the generator scripts to use these, easier not to vary between client and server. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_send.py | 24 1 file changed, 24 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b/src/m

[Mesa-dev] [PATCH 0/6] Update generated GLX server code

2016-05-04 Thread Adam Jackson
Another attempt at syncing the GLX generator scripts with xserver. Jon mentioned a couple of issues in the last series, namely that these two patches were still necessary: https://lists.x.org/archives/xorg-devel/2014-April/041597.html https://lists.x.org/archives/xorg-devel/2014-April/041919.html

[Mesa-dev] [PATCH 6/6] glapi/gen: Copy some GL 1.0 enum details into ARB_viewport_array

2016-05-04 Thread Adam Jackson
Otherwise the instances in the extension XML override the core definitions, and we stop knowing their sizes in indirect_size_get.c Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/ARB_viewport_array.xml | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 5/6] glapi: Define PURE for Sun Studio as well

2016-05-04 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 4f35343..8036a02 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++ b/src/mapi/glapi/gen/gl_XML.py @@ -183,

[Mesa-dev] [PATCH 4/6] glapi/glx: Mark byteswap functions as _X_UNUSED (v2)

2016-05-04 Thread Adam Jackson
Squashes the one remaining warning in the xserver build. v2: Also clean up some non-standard whitespace (Ian Romanick) Reviewed-by: Ian Romanick Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[Mesa-dev] [PATCH 3/6] glapi: Harden GLX request size processing (v2)

2016-05-04 Thread Adam Jackson
v2: Use == not is for equality testing (Dylan Baker) Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_recv.py | 2 -- src/mapi/glapi/gen/glX_proto_send.py | 2 -- src/mapi/glapi/gen/glX_proto_size.py | 24 +++- src/m

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #7 from David Lonie --- I'm trying to get a trace, but apitrace is failing an assertion: $ apitrace trace --api gl bin/vtkRenderingCoreCxxTests "TestTranslucentLUTDepthPeeling" vtkRend

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

2016-05-04 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 03/05/16 20:59, Kenneth Graunke wrote: >> Other than patches 37, 56, and ones you agreed to drop, the series >> is: Reviewed-by: Kenneth Graunke >> >> I think you can go ahead and land all except th

[Mesa-dev] [PATCH] mesa: include texture format in glGenerateMipmap error message

2016-05-04 Thread Brian Paul
--- src/mesa/main/genmipmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/genmipmap.c b/src/mesa/main/genmipmap.c index 1a6ae9a..d917220 100644 --- a/src/mesa/main/genmipmap.c +++ b/src/mesa/main/genmipmap.c @@ -139,7 +139,8 @@ _mesa_generate_texture_mipmap(

[Mesa-dev] [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml

2016-05-04 Thread Brian Paul
The function returns GLuint, not GLfloat values. --- src/mapi/glapi/gen/es_EXT.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/mapi/glapi/gen/es_EXT.xml index bf67eae..e453401 100644 --- a/src/mapi/glapi/gen/es_EXT.xml +++ b/src/mapi/glap

Re: [Mesa-dev] [PATCH] mesa: include texture format in glGenerateMipmap error message

2016-05-04 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, May 4, 2016 1:03 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Sinclair Yeh Subject: [PATCH] mesa: include texture format in glGenerateMipmap error message --- src/mesa/main/genmipm

Re: [Mesa-dev] [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml

2016-05-04 Thread Ilia Mirkin
My bad (iirc)... copy/paste error. Also need to fix the OES variant. With that, Reviewed-by: Ilia Mirkin On Wed, May 4, 2016 at 4:03 PM, Brian Paul wrote: > The function returns GLuint, not GLfloat values. > --- > src/mapi/glapi/gen/es_EXT.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [Mesa-dev] [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml

2016-05-04 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, May 4, 2016 1:03 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Sinclair Yeh Subject: [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml The function ret

Re: [Mesa-dev] [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in es_EXT.xml

2016-05-04 Thread Brian Paul
Missed that. Will do. I should probably also cc this for 11.2 Thanks. -Brian On 05/04/2016 02:05 PM, Ilia Mirkin wrote: My bad (iirc)... copy/paste error. Also need to fix the OES variant. With that, Reviewed-by: Ilia Mirkin On Wed, May 4, 2016 at 4:03 PM, Brian Paul wrote: The function

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #8 from Jose Fonseca --- (In reply to David Lonie from comment #7) > Is this issue familiar to anyone? I'll keep trying to get this working, but > would appreciate any tips if this is a known issue :) It looks like apitrace is about

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #9 from Roland Scheidegger --- FWIW it was not the samplers returning NaN for the float texture, but rather the _coords_ being NaNs (thus the results from sampling could be anything, though it is possible some implementations would us

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #10 from Jose Fonseca --- (In reply to Jose Fonseca from comment #8) > It looks like apitrace is about to enter an infinite loop: the address of > the supposedly "real" glXCreateContextAttribsARB function is actually > pointing to the

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

2016-05-04 Thread Francisco Jerez
Iago Toral writes: > On Wed, 2016-05-04 at 01:15 -0700, Francisco Jerez wrote: >> Iago Toral writes: >> >> > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: >> >> Samuel Iglesias Gonsálvez writes: >> >> >> >> > From: Connor Abbott >> >> > >> >> > Similar to retype() and offset(). >

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #11 from Jose Fonseca --- Created attachment 123472 --> https://bugs.freedesktop.org/attachment.cgi?id=123472&action=edit TestTranslucentLUTDepthPeeling.trace Trace. -- You are receiving this mail because: You are the assignee fo

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #12 from David Lonie --- (In reply to Jose Fonseca from comment #10) > The proper way of using a custom libGL.so is to simply set LD_LIBRARY_PATH > to the directory that has it: > > ln -sf libGL.so libGL.so,1 > LD_LIBRARY_PATH=$P

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #13 from Ilia Mirkin --- FWIW this is what it looks like on i965: http://i.imgur.com/LMmcGkM.png I'm guessing that's correct, but the "correct" screenshot is inside an archive and I'm lazy. It is indeed totally messed up with llvmpip

Re: [Mesa-dev] [PATCHv2 10/23] i965/fs: Stop using the LOAD_PAYLOAD instruction in lower_simd_width.

2016-05-04 Thread Francisco Jerez
Michael Schellenberger Costa writes: > Hi Curro, > > Am 04.05.2016 um 06:26 schrieb Francisco Jerez: >> Instead of using the LOAD_PAYLOAD instruction (emitted through the >> emit_transpose() helper that is no longer useful and this commit >> removes) which had to be marked force_writemask_all in

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #14 from David Lonie --- (In reply to Ilia Mirkin from comment #13) > FWIW this is what it looks like on i965: http://i.imgur.com/LMmcGkM.png > > I'm guessing that's correct, but the "correct" screenshot is inside an > archive and I'

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #15 from Emil Velikov --- Just pointing out something that may not be that obvious - David is using the xlib powered gallium libGL. That one uses the (iirc) unsupported split shared LLVM libraries. -- You are receiving this mail bec

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

2016-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #16 from Jose Fonseca --- (In reply to David Lonie from comment #12) > Just tried that here, no such luck: > > $ ln -s libGL.so libGL.so.1 > $ LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH apitrace trace --api gl > ./vtkRenderingCoreCxxTest

[Mesa-dev] [PATCH] radeonsi: set DECOMPRESS_Z_ON_FLUSH if nr_samples >= 4

2016-05-04 Thread Marek Olšák
From: Marek Olšák Vulkan always sets this. It only affects in-place Z decompression. This is recommended for performance, but what app uses MSAA depth texturing? --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 2/3] i965: Add infrastucture for sample lod-zero operations.

2016-05-04 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp| 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 14 ++ src/mesa/drivers/

[Mesa-dev] [PATCH 3/3] i965/fs: Recognize and emit ld_lz, sample_lz, sample_c_lz.

2016-05-04 Thread Matt Turner
Ken suggested instead of a big and complicated optimization pass, to just recognize the operations here. It's certainly less code and a lot prettier, but it seems to actually perform worse for currently unknown reasons. total instructions in shared programs: 8514403 -> 8495373 (-0.22%) instruction

[Mesa-dev] [PATCH 1/3] i965/fs: Add and use get_nir_src_imm().

2016-05-04 Thread Matt Turner
Terrible name. Suggest something else, or even a better way to do this. Basically, the next patch wants to inspect the LOD argument and do something different if it's 0.0f. But at that point we've emitted a MOV for it and we just have a register to look at. --- This is an alternative approach to t

[Mesa-dev] [PATCH 2/2] i965/borp: Don't blend integer values during MSAA resolves

2016-05-04 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index 882f9ed..dc68eab 100644 --- a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 1/2] meta/blit: Don't blend integer values during MSAA resolves

2016-05-04 Thread Jason Ekstrand
--- src/mesa/drivers/common/meta_blit.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 6761238..bb79c46 100644 --- a/src/mesa/drivers/common/meta_blit.c +++ b/src/mesa/drivers/commo

Re: [Mesa-dev] [PATCH 37/59] i965/fs: generalize SIMD16 interference workaround

2016-05-04 Thread Connor Abbott
On Curro's suggestion, I tried reproducing the problem that the patch fixes. Not only could I not reproduce it, but it seems like the original workaround that Jason added back when he reworked the fs backend ages ago is unnecessary at least on my ivybridge and broadwell machines. Since reproducing

[Mesa-dev] [PATCH] i965/fs: Don't follow pow with an instruction with two dest regs.

2016-05-04 Thread Matt Turner
Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on Gen >= 8 platforms. Evidently that commit allowed the scheduler to make different choices that somehow finally ran afoul of a hardware bug in which POW and FDIV instructions may not be followed by an instruction with two desti

Re: [Mesa-dev] [PATCH] i965/fs: Don't follow pow with an instruction with two dest regs.

2016-05-04 Thread Francisco Jerez
Matt Turner writes: > Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on > Gen >= 8 platforms. > > Evidently that commit allowed the scheduler to make different choices > that somehow finally ran afoul of a hardware bug in which POW and FDIV > instructions may not be followed

[Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

2016-05-04 Thread Marek Olšák
Hi, This patch series completely rewrites texture copying with SDMA for CIK & VI. It only uses the "partial" copy packets, which makes it a lot simpler (one packet per layered/3D copy). Most of the complexity is in handling hw limitations, but luckily the SDMA path can be used in the majority o

[Mesa-dev] [PATCH 05/14] gallium/radeon: implement randomized SDMA texture copy testing (v2)

2016-05-04 Thread Marek Olšák
From: Marek Olšák v2: - adjustments for exercising all important SDMA code paths - decrease the probability of getting huge sizes (faster testing) - increase the probability of getting power-of-two dimensions - change the memory cap to 128MB (faster testing) - better detect which

[Mesa-dev] [PATCH 03/14] gallium/radeon: use a common function for DMA blit preparation

2016-05-04 Thread Marek Olšák
From: Marek Olšák this is more robust and probably fixes some bugs already --- src/gallium/drivers/r600/evergreen_state.c| 10 ++--- src/gallium/drivers/r600/r600_state.c | 5 ++- src/gallium/drivers/radeon/r600_pipe_common.h | 7 src/gallium/drivers/radeon/r600_texture.c

[Mesa-dev] [PATCH 02/14] gallium/radeon: split out code for discarding DCC

2016-05-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 6df013a..ac11380 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH 04/14] gallium/radeon: discard CMASK or DCC if overwriting a whole texture by DMA

2016-05-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 46 ++- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 0dba045..d6d95af 100644 --- a/src/gall

[Mesa-dev] [PATCH 06/14] radeonsi: only expose *_init_*dma_functions from (S)DMA files

2016-05-04 Thread Marek Olšák
From: Marek Olšák just normalizing the interfaces --- src/gallium/drivers/radeonsi/cik_sdma.c | 19 --- src/gallium/drivers/radeonsi/si_dma.c | 19 --- src/gallium/drivers/radeonsi/si_pipe.c | 5 + src/gallium/drivers/radeonsi/si_pipe.h | 16 ++---

  1   2   >