Re: [Mesa-dev] [PATCH v2 22/42] glsl: Don't lower_variable_index_to_cond_assign for shared variables

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/lower_variable_index_to_cond_assign.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/glsl/lower_variable_index_to_cond_assign.cpp > b/src/glsl/lower_variable_index_to_cond_

[Mesa-dev] [PATCH v2 1/2] st/va: if h264 then delay decoder creation until max_references is known

2015-11-25 Thread Julien Isorce
From: Julien Isorce In general max_references cannot be based on num_render_targets. This patch allow to allocate accurate sizes for buffers. For other codecs it is a fixed value to 2. This is similar behaviour as vaapi/vdpau-driver. XXX: do the same for HEVC Signed-off-by: Julien Isorce ---

Re: [Mesa-dev] [PATCH v2 1/2] st/va: if h264 then delay decoder creation until max_references is known

2015-11-25 Thread Julien Isorce
For commit message please read: "HEVC case is left unchanged since delaying decoder creation is not needed on AMD hardware." instead of "XXX: do the same for HEVC" On 25 November 2015 at 09:07, Julien Isorce wrote: > From: Julien Isorce > > In general max_references cannot be based on num_re

[Mesa-dev] [PATCH v2 2/2] st/va: also retrieve reference frames info for h264

2015-11-25 Thread Julien Isorce
From: Julien Isorce Other hardwares than AMD require to parse: VAPictureParameterBufferH264.ReferenceFrames[16] Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/picture_h264.c | 53 1 file changed, 53 insertions(+) diff --git a/src/gallium/state_trac

Re: [Mesa-dev] [PATCH] i965: Don't inline intel_batchbuffer_require_space().

2015-11-25 Thread Chris Wilson
On Tue, Nov 24, 2015 at 11:07:54PM -0800, Kenneth Graunke wrote: > On Tuesday, November 24, 2015 05:17:29 PM Matt Turner wrote: > > It's called by the inline intel_batchbuffer_begin() function which > > itself is used in BEGIN_BATCH. So in sequence of code emitting multiple > > packets, we have inl

Re: [Mesa-dev] [PATCH v2 23/42] glsl: Add lowering pass for shared variable references

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > In this lowering pass, shared variables are decomposed into intrinsic > calls. > > v2: > * Send mem_ctx as a parameter (Iago) > > Signed-off-by: Jordan Justen > --- > src/glsl/Makefile.sources | 1 + > src/glsl/ir_optimizati

Re: [Mesa-dev] [PATCH v2 21/42] glsl: Add default matrix ordering in lower_buffer_access

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > For compute shader shared variable we will set a default of column > major. > > Signed-off-by: Jordan Justen > --- > src/glsl/lower_buffer_access.cpp | 5 +++-- > src/glsl/lower_buffer_access.h | 10 ++ > 2 files changed, 13 i

Re: [Mesa-dev] [PATCH 1/3] dri_interface: Introduce __DRI_IMAGE_USE_SCANOUT_ROTATION_* flags (v3)

2015-11-25 Thread Michel Dänzer
On 21.11.2015 12:38, Vivek Kasireddy wrote: > These flags can be used by the DRI driver to set additional requirements > such as tiling while creating buffers. > > v2: Added a brief comment to explain the rotation orientation. > > v3: Corrected a typo in the comment added in v2 and removed an emp

[Mesa-dev] [Bug 93100] [IVB]piglit/spec/opengl_3.3/gl-3.2-layered-rendering-framebuffertexture fails

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93100 Bug ID: 93100 Summary: [IVB]piglit/spec/opengl_3.3/gl-3.2-layered-rendering-f ramebuffertexture fails Product: Mesa Version: unspecified Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH v2 24/42] nir: Translate glsl shared var load intrinsic to nir intrinsic

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/nir/glsl_to_nir.cpp | 29 + > src/glsl/nir/nir_intrinsics.h | 1 + > 2 files changed, 30 insertions(+) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/ni

Re: [Mesa-dev] [PATCH v2 1/2] st/va: if h264 then delay decoder creation until max_references is known

2015-11-25 Thread Christian König
On 25.11.2015 10:12, Julien Isorce wrote: For commit message please read: "HEVC case is left unchanged since delaying decoder creation is not needed on AMD hardware." In this case please update the commit message, but honestly I'm not sure if we don't use the max_references somewhere in the

Re: [Mesa-dev] [PATCH v2 2/2] st/va: also retrieve reference frames info for h264

2015-11-25 Thread Christian König
On 25.11.2015 10:13, Julien Isorce wrote: From: Julien Isorce Other hardwares than AMD require to parse: VAPictureParameterBufferH264.ReferenceFrames[16] Signed-off-by: Julien Isorce Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture_h264.c | 53

[Mesa-dev] SSO fixes V3

2015-11-25 Thread Timothy Arceri
V3: - Fixed explicit location optimisation (Patch 1) - Added fix for assigning varyings to the same location when using arrays (Patch 6) - Pushed some clean-up patches reviewed in v2 V2: I've dropped most of my fix from V1 and instead included the fixes from Gregory which I have cleaned up slight

[Mesa-dev] [PATCH 1/6] glsl: optimise inputs/outputs with explicit locations

2015-11-25 Thread Timothy Arceri
This change allows used defined inputs/outputs with explicit locations to be removed if they are detected to not be used between shaders at link time. To enable this we change the is_unmatched_generic_inout field to be flagged when we have a user defined varying. Previously explicit_location was a

[Mesa-dev] [PATCH 2/6] glsl: copy how_declared when lowering interface blocks

2015-11-25 Thread Timothy Arceri
Cc: Gregory Hainaut --- src/glsl/lower_named_interface_blocks.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/lower_named_interface_blocks.cpp b/src/glsl/lower_named_interface_blocks.cpp index 114bb58..f29eba4 100644 --- a/src/glsl/lower_named_interface_blocks.cpp +++ b/src/glsl

[Mesa-dev] [PATCH 6/6] glsl: fix overlapping of varying locations for arrays

2015-11-25 Thread Timothy Arceri
Previously we were not reserving the full array for explicit locations. We also didn't take into account implicit locations clashing with explicit locations when assigning locations for their arrays. This patch fixes both issues. There is no effort to make arrays of arrays work here because we s

[Mesa-dev] [PATCH 3/6] glsl: add always_active_io attribute to ir_variable

2015-11-25 Thread Timothy Arceri
From: Gregory Hainaut The value will be set in separate-shader program when an input/output must remains active. e.g. when deadcode removal isn't allowed because it will create interface location/name-matching mismatch. v3: * Rename the attribute * Use ir_variable directly instead of ir_variable

[Mesa-dev] [PATCH 4/6] glsl: don't dead code remove SSO varyings marked as active

2015-11-25 Thread Timothy Arceri
From: Gregory Hainaut GL_ARB_separate_shader_objects allow matching by name variable or block interface. Input varyings can't be removed because it is will impact the location assignment. This fixes the bug 79783 and likely any application that uses GL_ARB_separate_shader_objects extension. V2

[Mesa-dev] [PATCH 5/6] glsl: don't sort varying in separate shader mode

2015-11-25 Thread Timothy Arceri
From: Gregory Hainaut This fixes an issue where the addition of the FLAT qualifier in varying_matches::record() can break the expected varying order. It also avoids a future issue with the relaxing of interpolation qualifier matching constraints in GLSL 4.50. V2: (by Timothy Arceri) * reworked

Re: [Mesa-dev] [PATCH v2 25/42] nir: Translate glsl shared var store intrinsic to nir intrinsic

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/nir/glsl_to_nir.cpp | 33 + > src/glsl/nir/nir_intrinsics.h | 3 ++- > 2 files changed, 35 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/glsl_to_

[Mesa-dev] [Bug 93100] [IVB]piglit/spec/opengl_3.3/gl-3.2-layered-rendering-framebuffertexture fails

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93100 marius predut changed: What|Removed |Added Depends on||91670 -- You are receiving this mail be

Re: [Mesa-dev] [PATCH v2 26/42] i965: Disable vector splitting on shared variables

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp >

[Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Marius Predut
Open GL 3.3 reference document says: samples must be in the range zero to GL_MAX_TEXTURE_SIZE - 1. Open GL.4 clearly states: An INVALID_VALUE error is generated if samples is zero. Fixing the piglit test case gl-3.2-layered-rendering-framebuffertexture. Bugzilla: https://bugs.freedesktop.org/show

[Mesa-dev] [Bug 93100] [IVB]piglit/spec/opengl_3.3/gl-3.2-layered-rendering-framebuffertexture fails

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93100 --- Comment #1 from marius predut --- The pair that fix this issue: Patch sent to the piglit mailing list: http://lists.freedesktop.org/archives/piglit/2015-November/018182.html Patch sent to the mesa mailing list: http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Tapani Pälli
Hi; On 11/25/2015 01:15 PM, Marius Predut wrote: Open GL 3.3 reference document says: samples must be in the range zero to GL_MAX_TEXTURE_SIZE - 1. Open GL.4 clearly states: An INVALID_VALUE error is generated if samples is zero. OpenGL ES 3.1 spec also says "An INVALID_VALUE error is generate

Re: [Mesa-dev] [PATCH v2 27/42] i965/fs: Handle nir shared variable load intrinsic

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 33 > > 2 files changed, 35 insertions(+) > > diff --git a/src/mesa/driv

Re: [Mesa-dev] [PATCH] gallium/util: Fix util_blitter_clear_render_target() for num_layers>1

2015-11-25 Thread Marek Olšák
On Tue, Nov 24, 2015 at 1:03 PM, Edward O'Callaghan wrote: > Previously util_blitter_clear_render_target() could not clear more > than the first layer. We need to generalise this so that > ARB_clear_texture can pass the 3d piglit test. > > Signed-off-by: Edward O'Callaghan > --- > src/gallium/au

[Mesa-dev] [Bug 93100] [IVB]piglit/spec/opengl_3.3/gl-3.2-layered-rendering-framebuffertexture fails

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93100 --- Comment #2 from Timothy Arceri --- I think this is just a bug in the reference pages see my comments in bug 91670 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH v2 28/42] i965/fs: Handle nir shared variable store intrinsic function

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 54 > > 1 file changed, 54 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Timothy Arceri
On Wed, 2015-11-25 at 12:47 +0200, Tapani Pälli wrote: > Hi; > > On 11/25/2015 01:15 PM, Marius Predut wrote: > > Open GL 3.3 reference document says: > > samples must be in the range zero to GL_MAX_TEXTURE_SIZE - 1. > > Open GL.4 clearly states: > > An INVALID_VALUE error is generated if samples

[Mesa-dev] [PATCH v2] mesa: remove ARB_geometry_shader4

2015-11-25 Thread Marta Lofstedt
From: Marta Lofstedt No drivers currently implement ARB_geometry_shader4, nor are there any plans to implement it. We only support the version of geometry shaders that was incorporated into OpenGL 3.2 / GLSL 1.50. Signed-off-by: Marta Lofstedt --- src/mapi/glapi/gen/ARB_geometry_shader4.xml |

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Tapani Pälli
On 11/25/2015 01:11 PM, Timothy Arceri wrote: On Wed, 2015-11-25 at 12:47 +0200, Tapani Pälli wrote: Hi; On 11/25/2015 01:15 PM, Marius Predut wrote: Open GL 3.3 reference document says: samples must be in the range zero to GL_MAX_TEXTURE_SIZE - 1. Open GL.4 clearly states: An INVALID_VALUE er

Re: [Mesa-dev] [PATCH 11/11] winsys/amdgpu/addrlib: do not wrap header inclusion in extern "C"

2015-11-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Nov 24, 2015 at 5:29 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/gallium/winsys/amdgpu/drm/addrlib/addrinterface.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/wins

Re: [Mesa-dev] [PATCH v2 29/42] i965: Enable shared local memory for CS shared variables

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_cs.c| 2 ++ > src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ > src/mesa/drivers/dri/i965/gen7_cs_state.c | 12 > 3 files changed, 16 insertions(+)

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Wednesday, November 25, 2015 12:24 PM > To: Timothy Arceri; Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultis

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Predut, Marius
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Wednesday, November 25, 2015 1:23 PM To: Timothy Arceri; Predut, Marius; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs

Re: [Mesa-dev] [PATCH v2 31/42] glsl: Allow atomic functions to be used with shared variables

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Reviewed-by: Timothy Arceri Reviewed-by: Iago Toral Quiroga > --- > src/glsl/ast_function.cpp | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/src/glsl/ast_fun

Re: [Mesa-dev] [PATCH v2 30/42] i965: Lower shared variable references to intrinsic calls

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 0/3] mesa: delayed initialization of performance monitor groups

2015-11-25 Thread Nicolai Hähnle
Hi, since performance monitors are almost never used, we want to avoid the startup cost associated with setting up the group information. This mostly affects Gallium, where that initialization is rather inefficient right now. For radeonsi with my performance counter series, the first two patches

[Mesa-dev] [PATCH 1/3] mesa/main: allow delayed initialization of performance monitors

2015-11-25 Thread Nicolai Hähnle
Most applications never use performance counters, so allow drivers to skip potentially expensive initialization steps. A driver that wants to use this must enable the appropriate extension(s) at context initialization and set the InitPerfMonitorGroups driver function which will be called the first

[Mesa-dev] [PATCH 2/3] st/mesa: delay initialization of performance counters

2015-11-25 Thread Nicolai Hähnle
--- src/mesa/state_tracker/st_cb_perfmon.c | 28 +--- src/mesa/state_tracker/st_cb_perfmon.h | 2 +- src/mesa/state_tracker/st_context.c| 2 +- 3 files changed, 19 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tr

[Mesa-dev] [PATCH 3/3] radeon: delay the generation of driver query names until first use

2015-11-25 Thread Nicolai Hähnle
This shaves a bit more time off the startup of programs that don't actually use performance counters. --- src/gallium/drivers/radeon/r600_perfcounter.c | 192 ++ src/gallium/drivers/radeon/r600_query.h | 10 +- src/gallium/drivers/radeonsi/si_perfcounter.c | 15 +-

Re: [Mesa-dev] [PATCH v2 35/42] glsl: Translate atomic intrinsic functions on shared variables

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > When an intrinsic atomic operation is used on a shared variable, we > translate it to a new 'share variable' specific intrinsic function s/share/shared > call. > > For example, add call to __intrinsic_atomic_add when used on a shared > va

Re: [Mesa-dev] [PATCH 0/8] radeonsi: Implement AMD_performance_monitor

2015-11-25 Thread Nicolai Hähnle
On 24.11.2015 17:20, Marek Olšák wrote: On Tue, Nov 24, 2015 at 5:08 PM, Ilia Mirkin wrote: On Tue, Nov 24, 2015 at 11:00 AM, Nicolai Hähnle wrote: One annoyance of the series as it currently stands is that exposing thousands of counters affects the context creation time due to the way the Me

Re: [Mesa-dev] [PATCH v2 36/42] glsl: Buffer atomics are supported for compute shaders

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/builtin_functions.cpp | 70 > +++--- > 1 file changed, 38 insertions(+), 32 deletions(-) > > diff --git a/src/glsl/builti

Re: [Mesa-dev] [PATCH v2 37/42] glsl: Disable several optimizations on shared variables

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Shared variables can be accessed by other threads within the same > local workgroup. This prevents us from performing certain > optimizations with shared variables. > > Signed-off-by: Jordan Justen > --- >

[Mesa-dev] [PATCH 0/1] Do not loose steps when dumping to file with INTEL_DEBUG=optimizer

2015-11-25 Thread Juan A. Suarez Romero
The BRW functions that run then optimizations in the FS (fs_visitor::optimize()) and in the VS (vec4_visitor::run()) can be called more than once. This means when using INTEL_DEBUG=optimizer the output files with the optimization in each step are overwritten in successive calls. The quick and e

[Mesa-dev] [PATCH 1/1] i965: Do not overwrite optimizer dumps

2015-11-25 Thread Juan A. Suarez Romero
When using INTEL_DEBUG=optimizer, each optimizing step is dump to disk, in a separate file. But as fs_visitor::optimize() and vec4_visitor::run() are called more than once, it ends up overwriting the files already on disk, loosing then previous optimizer steps. To avoid this, add a new static var

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
On 18/11/15 06:54, Jordan Justen wrote: > From: Francisco Jerez > > It should be possible to use additional L3 configurations other than > the ones listed in the tables of validated allocations ("BSpec » > 3D-Media-GPGPU Engine » L3 Cache and URB [IVB+] » L3 Cache and URB [*] > » L3 Allocation

Re: [Mesa-dev] [PATCH v2 38/42] nir: Add nir intrinsics for shared variable atomic operations

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/nir/glsl_to_nir.cpp | 53 > +++ > src/glsl/nir/nir_intrinsics.h | 25 > 2 files changed, 78 insertions(+) > > diff --git a/src/gl

Re: [Mesa-dev] [PATCH v2 39/42] i965/nir: Implement shared variable atomic operations

2015-11-25 Thread Iago Toral
On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 60 > > 2 files changed, 62 insertions(+) > > diff --git a/src/mesa/driv

Re: [Mesa-dev] [PATCH 1/1] i965: Do not overwrite optimizer dumps

2015-11-25 Thread Juan A. Suarez Romero
On Wed, 2015-11-25 at 13:15 +0100, Juan A. Suarez Romero wrote: > When using INTEL_DEBUG=optimizer, each optimizing step is dump to > disk, > in a separate file. > > But as fs_visitor::optimize() and vec4_visitor::run() are called more > than once, it ends up overwriting the files already on disk,

[Mesa-dev] [PATCH] i965: Do not overwrite optimizer dumps

2015-11-25 Thread Juan A. Suarez Romero
When using INTEL_DEBUG=optimizer, each optimizing step is dump to disk, in a separate file. But as fs_visitor::optimize() and vec4_visitor::run() are called more than once, it ends up overwriting the files already on disk, loosing then previous optimizer steps. To avoid this, add a new static var

Re: [Mesa-dev] [PATCH v2 40/42] i965: Enable ARB_compute_shader extension on supported hardware

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Enable ARB_compute_shader on gen7+, on hardware that supports the > OpenGL 4.3 requirements of a local group size of 1024. > > With SIMD16 support, this is limited to Ivy Bridge and Haswell. > > Broadwell

Re: [Mesa-dev] [PATCH v2 41/42] docs: Mark ARB_compute_shader as done for i965

2015-11-25 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > docs/GL3.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index b768eea..cb4415f 100644 > --- a/docs/GL3.

Re: [Mesa-dev] [PATCH v2 42/42] docs: Add ARB_compute_shader to 11.1.0 release notes

2015-11-25 Thread Iago Toral
I think we are too late for 11.1.0. On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > docs/relnotes/11.1.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html > index 6654311..c89b822 10

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote: > > > On 18/11/15 06:54, Jordan Justen wrote: >> From: Francisco Jerez >> >> It should be possible to use additional L3 configurations other than >> the ones listed in the tables of validated allocations ("BSpec » >> 3D-Media-GPGPU Engine » L

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 18/11/15 06:54, Jordan Justen wrote: >> From: Francisco Jerez >> >> It should be possible to use additional L3 configurations other than >> the ones listed in the tables of validated allocations ("BSpec » >> 3D-Media-GPGPU Engine » L3 Cache and URB [IVB+]

Re: [Mesa-dev] [PATCH v3] mesa: error out in indirect draw when vertex bindings mismatch

2015-11-25 Thread Tapani Pälli
On 11/25/2015 08:21 AM, Fredrik Höglund wrote: On Tuesday 24 November 2015, Tapani Pälli wrote: Patch adds additional mask for tracking which vertex arrays have associated vertex buffer binding set. This array can be directly compared to which vertex arrays are enabled and should match when draw

Re: [Mesa-dev] [PATCH 1/3] mesa/main: allow delayed initialization of performance monitors

2015-11-25 Thread Samuel Pitoiset
This is definitely a good performance improvement at initialization time. This is not going to affect Nouveau because we don't have as much as performance counters as Radeon, but it's great anyway. One comment below. Reviewed-by: Samuel Pitoiset On 11/25/2015 01:00 PM, Nicolai Hähnle wrote:

Re: [Mesa-dev] [PATCH 2/3] st/mesa: delay initialization of performance counters

2015-11-25 Thread Samuel Pitoiset
One comment below. Reviewed-by: Samuel Pitoiset On 11/25/2015 01:00 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 28 +--- src/mesa/state_tracker/st_cb_perfmon.h | 2 +- src/mesa/state_tracker/st_context.c| 2 +- 3 files changed, 19 i

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
On 25/11/15 13:56, Samuel Iglesias Gonsálvez wrote: > > > On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote: >> >> >> On 18/11/15 06:54, Jordan Justen wrote: >>> From: Francisco Jerez >>> >>> It should be possible to use additional L3 configurations other than >>> the ones listed in the table

Re: [Mesa-dev] [PATCH 1/3] mesa/main: allow delayed initialization of performance monitors

2015-11-25 Thread Nicolai Hähnle
On 25.11.2015 14:10, Samuel Pitoiset wrote: This is definitely a good performance improvement at initialization time. This is not going to affect Nouveau because we don't have as much as performance counters as Radeon, but it's great anyway. One comment below. Reviewed-by: Samuel Pitoiset On

Re: [Mesa-dev] [PATCH 2/3] st/mesa: delay initialization of performance counters

2015-11-25 Thread Nicolai Hähnle
On 25.11.2015 14:11, Samuel Pitoiset wrote: One comment below. Reviewed-by: Samuel Pitoiset On 11/25/2015 01:00 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 28 +--- src/mesa/state_tracker/st_cb_perfmon.h | 2 +- src/mesa/state_tracker/st

Re: [Mesa-dev] [PATCH 1/3] mesa/main: allow delayed initialization of performance monitors

2015-11-25 Thread Samuel Pitoiset
On 11/25/2015 02:17 PM, Nicolai Hähnle wrote: On 25.11.2015 14:10, Samuel Pitoiset wrote: This is definitely a good performance improvement at initialization time. This is not going to affect Nouveau because we don't have as much as performance counters as Radeon, but it's great anyway. One c

[Mesa-dev] [PATCH] st/mesa: remove outdated comment

2015-11-25 Thread Nicolai Hähnle
From: Nicolai Hähnle The enable of AMD_performance_monitor is no longer related to whether queries are run by the GPU since the commit mentioned below. Suggested-by: Samuel Pitoiset commit ddf27a3dd062c78ff49a69a1396be4de9c1b5d37 Author: Nicolai Hähnle Date: Tue Nov 10 13:35:01 2015 +0100

Re: [Mesa-dev] [PATCH] st/mesa: remove outdated comment

2015-11-25 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset Thanks Nicolai. On 11/25/2015 02:29 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The enable of AMD_performance_monitor is no longer related to whether queries are run by the GPU since the commit mentioned below. Suggested-by: Samuel Pitoiset commit ddf27a3dd

[Mesa-dev] [PATCH 0/2] Run post opt_vector_float() opts in a loop

2015-11-25 Thread Juan A. Suarez Romero
When checking output VS in glsl-mat-from-int-ctor-03 piglit, I got the following (part of) code. mov(8) g19<1>.xyzF g6<4,4,1>.xyzzD { align16 1Q }; dp4(8) g115<1>.wF g4<4,4,1>F g2.4<0,4,1>F{ align16 NoDDChk 1Q }; cmp.nz.f0(8)nu

[Mesa-dev] [PATCH 2/2] i965: run brw_vec4 optimizations in loop

2015-11-25 Thread Juan A. Suarez Romero
When analyzing output for glsl-mat-from-int-ctor-03 piglit test, found that the following piece of generated asm code: mov(8) g19<1>.xyzF g6<4,4,1>.xyzzD { align16 1Q }; dp4(8) g115<1>.wF g4<4,4,1>F g2.4<0,4,1>F{ align16 NoDDChk 1Q }; cmp.nz.f0(

[Mesa-dev] [PATCH 1/2] i965: Do not apply CSE opt to MOV immediate

2015-11-25 Thread Juan A. Suarez Romero
If the shader asm code is something like: mov vgrf2767.0:F, [13F, 14F, 15F, 16F] mov vgrf2768.0:F, [9F, 10F, 11F, 12F] mov m8:F, [13F, 14F, 15F, 16F] mov m7:F, [9F, 10F, 11F, 12F] And we apply Common Subexpresion Elimination optimization, we get the following one: mov vgrf2771.0:F, [13F, 14F, 15

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 25/11/15 13:56, Samuel Iglesias Gonsálvez wrote: >> >> >> On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote: >>> >>> >>> On 18/11/15 06:54, Jordan Justen wrote: From: Francisco Jerez It should be possible to use additional L3 configuration

Re: [Mesa-dev] [PATCH 7/8] radeonsi: implement AMD_performance_monitor for CIK+

2015-11-25 Thread Marek Olšák
R600_PC_SHADER_WINDOWING seems unused. What is it good for? BTW, I think the EVENT_WRITE_EOP workaround is indeed required. The series is: Reviewed-by: Marek Olšák Marek On Tue, Nov 24, 2015 at 5:00 PM, Nicolai Hähnle wrote: > Expose most of the performance counter groups that are exposed by

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
On 25/11/15 14:45, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> On 25/11/15 13:56, Samuel Iglesias Gonsálvez wrote: >>> >>> >>> On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote: On 18/11/15 06:54, Jordan Justen wrote: > From: Francisco Jerez > >

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Predut, Marius
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of > Timothy Arceri > Sent: Wednesday, November 25, 2015 1:12 PM > To: Palli, Tapani; Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultis

[Mesa-dev] [PATCH v2 5.5/42] i965: Add slice count to the brw_device_info structure.

2015-11-25 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_device_info.c | 20 src/mesa/drivers/dri/i965/brw_device_info.h | 5 + 2 files changed, 25 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c index 4550550..bf31898 10064

[Mesa-dev] [PATCH v3 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Francisco Jerez
It should be possible to use additional L3 configurations other than the ones listed in the tables of validated allocations ("BSpec » 3D-Media-GPGPU Engine » L3 Cache and URB [IVB+] » L3 Cache and URB [*] » L3 Allocation and Programming"), but it seems sensible for now to hard-code the tables in or

[Mesa-dev] [PATCH v3 11/42] i965: Implement L3 state atom.

2015-11-25 Thread Francisco Jerez
The L3 state atom calculates the target L3 partition weights when the program bound to some shader stage is modified, and in case they are far enough from the current partitioning it makes sure that the L3 state is re-emitted. v3: Fix for inconsistent units the context URB size is expressed in.

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On 25/11/15 14:45, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> On 25/11/15 13:56, Samuel Iglesias Gonsálvez wrote: On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote: > > > On 18/11/15 06:54, Jordan Justen wro

Re: [Mesa-dev] [PATCH v2 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
On 25/11/15 15:21, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> On 25/11/15 14:45, Francisco Jerez wrote: >>> Samuel Iglesias Gonsálvez writes: >>> On 25/11/15 13:56, Samuel Iglesias Gonsálvez wrote: > > > On 25/11/15 13:20, Samuel Iglesias Gonsálvez wrote:

[Mesa-dev] [PATCH] i965: Document inconsistent units the URB size is represented in.

2015-11-25 Thread Francisco Jerez
src/mesa/drivers/dri/i965/brw_context.h | 8 +++- src/mesa/drivers/dri/i965/brw_device_info.h | 5 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index ee3b6a3..30e5c48 100644 --- a/src

Re: [Mesa-dev] [PATCH v2 09/42] i965: Implement selection of the closest L3 configuration based on a vector of weights.

2015-11-25 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 18/11/15 06:54, Jordan Justen wrote: > From: Francisco Jerez > > The input of the L3 set-up code is a vector giving the approximate > desired relative size of each partition. This implements logic to > compare the input vector against the table of val

Re: [Mesa-dev] [PATCH 7/8] radeonsi: implement AMD_performance_monitor for CIK+

2015-11-25 Thread Nicolai Hähnle
On 25.11.2015 14:56, Marek Olšák wrote: R600_PC_SHADER_WINDOWING seems unused. What is it good for? Ah yes, that's totally non-obvious in the code, sorry about that. It makes query->shader non-zero, which will cause SQ_PERFCOUNTER_CTRL to be written. I've added a short comment about this.

Re: [Mesa-dev] [PATCH v2 1/2] st/va: if h264 then delay decoder creation until max_references is known

2015-11-25 Thread Emil Velikov
Hi Julien, On 25 November 2015 at 09:07, Julien Isorce wrote: > From: Julien Isorce > > In general max_references cannot be based on num_render_targets. > > This patch allow to allocate accurate sizes for buffers. > For other codecs it is a fixed value to 2. > > This is similar behaviour as vaap

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Tapani Pälli
On 11/25/2015 04:00 PM, Predut, Marius wrote: -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Timothy Arceri Sent: Wednesday, November 25, 2015 1:12 PM To: Palli, Tapani; Predut, Marius; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev]

Re: [Mesa-dev] [PATCH v2 24/42] nir: Translate glsl shared var load intrinsic to nir intrinsic

2015-11-25 Thread Connor Abbott
On Wed, Nov 25, 2015 at 4:48 AM, Iago Toral wrote: > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: >> Signed-off-by: Jordan Justen >> --- >> src/glsl/nir/glsl_to_nir.cpp | 29 + >> src/glsl/nir/nir_intrinsics.h | 1 + >> 2 files changed, 30 insertions(+) >

[Mesa-dev] question on GL_RED and gles

2015-11-25 Thread Julien Isorce
Hi, In EXT_texture_rg.txt it is mentioned of GL_RED_EXT on gles 2.0. In glformats.c::_mesa_es_error_check_format_and_type returns GL_INVALID_VALUE if GL_RED_EXT(as it reaches default case) so glTexImage2D(..., GL_RED_EXT, GL_UNSIGNED_BYTE, data) fails. Though GL_EXTENSIONS contains GL_EXT_text

[Mesa-dev] [PATCH] docs: minimum required python mako version is 0.3.4

2015-11-25 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- docs/install.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install.html b/docs/install.html index a90c2b2..c826d64 100644 --- a/docs/install.html +++ b/docs/install.html @@ -39,7 +39,7 @@ Version 2.6.4 or later should wo

Re: [Mesa-dev] [PATCH v2 2/2] targets: use the non-inline sw helpers

2015-11-25 Thread Nick Sarnie
On Mon, Nov 23, 2015 at 10:28 AM, Emil Velikov wrote: > Previously (with the inline ones) things were embedded into the > pipe-loader, which means that we cannot control/select what we want in > each target. > > That also meant that at runtime we ended up with the empty > sw_screen_create() as th

Re: [Mesa-dev] [PATCH] docs: minimum required python mako version is 0.3.4

2015-11-25 Thread Emil Velikov
On 25 November 2015 at 15:35, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > docs/install.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/install.html b/docs/install.html > index a90c2b2..c826d64 100644 > --- a/docs/install.

[Mesa-dev] [Bug 93103] llvm symbols leak through, cause trouble with software rendering in llvm-linked software

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93103 Bug ID: 93103 Summary: llvm symbols leak through, cause trouble with software rendering in llvm-linked software Product: Mesa Version: 10.1 Hardware: Other

Re: [Mesa-dev] [PATCH v2 5.5/42] i965: Add slice count to the brw_device_info structure.

2015-11-25 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 25/11/15 15:22, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_device_info.c | 20 > src/mesa/drivers/dri/i965/brw_device_info.h | 5 + > 2 files changed, 25 insertions(+) > > diff --git a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] mesa/main: TexImage2DMultisample needs to pass OpenGL3.3 conformance test.

2015-11-25 Thread Timothy Arceri
On Wed, 2015-11-25 at 17:13 +0200, Tapani Pälli wrote: > On 11/25/2015 04:00 PM, Predut, Marius wrote: > > > -Original Message- > > > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > > > Behalf Of > > > Timothy Arceri > > > Sent: Wednesday, November 25, 2015 1:12 PM > > >

Re: [Mesa-dev] [PATCH v3 06/42] i965: Import tables enumerating the set of validated L3 configurations.

2015-11-25 Thread Samuel Iglesias Gonsálvez
Just to make it explicit, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 25/11/15 15:24, Francisco Jerez wrote: > It should be possible to use additional L3 configurations other than > the ones listed in the tables of validated allocations ("BSpec » > 3D-Media-GPGPU Engine » L3 Cache and URB [IV

Re: [Mesa-dev] [PATCH] gallium/tests: fix build with clang compiler

2015-11-25 Thread Samuel Pitoiset
On 11/25/2015 05:16 PM, Eirik Byrkjeflot Anonsen wrote: Samuel Pitoiset writes: Nested functions are supported as an extension in GNU C, but Clang don't support them. This fixes compilation errors when (manually) building compute.c, or by setting --enable-gallium-tests to the configure scri

[Mesa-dev] [Bug 93103] llvm symbols leak through, cause trouble with software rendering in llvm-linked software

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93103 Jose Fonseca changed: What|Removed |Added CC||jfons...@vmware.com --- Comment #1 from J

[Mesa-dev] [Bug 93103] llvm symbols leak through, cause trouble with software rendering in llvm-linked software

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93103 --- Comment #2 from Emil Velikov --- Hmm I'm pretty sure that I removed all of those an year or two ago. And looking at the patches in said report, it seems that it was a problem on their end -> they were not hiding the (should be) internal sym

Re: [Mesa-dev] [PATCH] gallium/tests: fix build with clang compiler

2015-11-25 Thread Eirik Byrkjeflot Anonsen
Samuel Pitoiset writes: > Nested functions are supported as an extension in GNU C, but Clang > don't support them. > > This fixes compilation errors when (manually) building compute.c, > or by setting --enable-gallium-tests to the configure script. > > Bugzilla: https://bugs.freedesktop.org/show_

[Mesa-dev] [Bug 93103] llvm symbols leak through, cause trouble with software rendering in llvm-linked software

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93103 --- Comment #3 from Emil Velikov --- (In reply to Jose Fonseca from comment #1) > In addition to that, we probably also need to use a LD version script to > ensure that LLVM symbols don't pop in the dynamic symbol table. We have those for a whil

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #7 from Aaron Watry --- Bah, ignore me. I could still reproduce the issue yesterday to the best of my knowledge, but after an llvm/mesa rebuild with the patch applied this morning, things are working correctly... -- You are receivi

Re: [Mesa-dev] [Mesa-announce] Mesa 11.1.0 release candidate 1

2015-11-25 Thread Mark Janes
Hi Emil, I noticed that this branchpoint is after the KHR_DEBUG patches which broke GL conformance. Is the plan to resolve this bug before release? https://bugs.freedesktop.org/show_bug.cgi?id=93048 -Mark Emil Velikov writes: > On 23 November 2015 at 09:18, Thierry Vignaud > wrote: >> On 2

  1   2   3   >