So, afaiu, everything that might insert a sampler is using
tgsi_transform_shader()? There aren't too many of those, and I think
I can fix them up to not violate that constraint.
(It does occur to me that I may end up needing to fix u_blitter to
differentiate between blitting float vs int to avoid
Yes, I think nowadays everybody uses tgsi_transform_shader() to do that,
so that should probably work.
Roland
Am 10.06.2015 um 20:59 schrieb Rob Clark:
> So, afaiu, everything that might insert a sampler is using
> tgsi_transform_shader()? There aren't too many of those, and I think
> I can fix
I'll admit to not having followed the conversation *too* closely, but
just want to point out that nouveau has its own blitter implementation
(which has the advantage of actually working for stencil given some
reasonable assumptions about formats), please don't break it. [The
downside of it is that
On Mon, Jun 8, 2015 at 4:44 PM, Jason Ekstrand wrote:
> Generally, liveness information propagates up the program, not down.
I'd replace this with an actual quote from the cited text:
"To determine which variables are live at each point in a flowgraph,
we perform a backward data-flow analysis"
There is also the option of adding the sampler type to either the SAMP
declaration or texture instructions. This will move us further away
from adopting SVIEW, but I don't see that happening for OpenGL anyway.
Marek
On Wed, Jun 10, 2015 at 8:59 PM, Rob Clark wrote:
> So, afaiu, everything that m
Whoops. I re-wrote this last night:
http://cgit.freedesktop.org/~jljusten/mesa/commit/?h=cs-33&id=3ebe7b79
On 2015-06-04 21:41:15, Tapani Pälli wrote:
> Before 9b5e92f get_gl_override was called only once, but now it is
> called for multiple APIs (GLES2, GL), version needs to be set always.
>
>
that is starting to look more attractive, mostly just because
tgsi_transform stuff is so cumbersome..
(I did start thinking about just adding type to decl's in general,
since really it would be better to have for type information for IN's
and OUT's too.. but then decided I'd probably rather spend
On Jun 10, 2015 9:57 AM, "Neil Roberts" wrote:
>
> Kenneth Graunke writes:
>
> > _mesa_meta_fb_tex_blit_begin(ctx, &blit);
> > + ctx->Extensions.ARB_texture_stencil8 = true;
>
> Maybe you could put assert(ctx->Extensions.ARB_texture_stencil8==false)
> just before setting it to true so that
LGTM
Reviewed-by: Jason Ekstrand
On Jun 10, 2015 7:39 AM, "Francisco Jerez" wrote:
> Instead use fs_builder::null_reg_f() which has the correct register
> width. Avoids the assertion failure in fs_builder::emit() hit by the
> "ES3-CTS.shaders.loops.for_dynamic_iterations.unconditional_break_fr
On Wed, 2015-06-10 at 18:08 +0200, Marc-André Lureau wrote:
> + if (!xshm_error && shmid >= 0) {
> + pdp->shminfo.shmid = shmid;
> + pdp->ximage = XShmCreateImage(dpy,
> +pdp->visinfo->visual,
> +pdp->visinfo->dept
I think it make sense for us to start using SVIEW regardless, and
uniformize things.
Even if GLSL will never support independent texture/samplers, D3D10,
OpenCL, Metal, and potential SPIR-V all do.
Roland, could you prepare a patch for llvmpipe, so that it infers from
SAMPLE_* opcode count
Thank you.
I think there should be a way to calculate the size of the memory location
pointed by that pointer.
For cases where there is no shared memory between the client and the
server, the memory contents should be copied back and forth, which means
the size of the pointer should be known (unles
On Wed, Jun 10, 2015 at 5:13 PM, Jose Fonseca wrote:
> I think it make sense for us to start using SVIEW regardless, and uniformize
> things.
>
>
> Even if GLSL will never support independent texture/samplers, D3D10, OpenCL,
> Metal, and potential SPIR-V all do.
>
> Roland, could you prepare a pat
https://bugs.freedesktop.org/show_bug.cgi?id=90927
Ian Romanick changed:
What|Removed |Added
Severity|critical|enhancement
--- Comment #1 from Ian Roman
On 06/10/2015 11:25 AM, Shervin Sharifi wrote:
> Hi,
>
> This may not be the right forum to ask this, but I didn't know of a
> better forum, so I thought I can ask here.
>
> I'm new to OpenGL. I am looking at XML registry for OpenGL and there
> are some parameters with attributes containing a
Thanks Ian.
If I want to implement the actual CompSize function, how should I figure
out the details?
Thanks,
Shervin
On Wed, Jun 10, 2015 at 2:56 PM, Ian Romanick wrote:
> On 06/10/2015 11:25 AM, Shervin Sharifi wrote:
> > Hi,
> >
> > This may not be the right forum to ask this, but I didn
I'm not sure what you are trying to accomplish.
if you're doing some sort of serialization of OpenGL calls other than
GLX, then it might be worthwhile to look at
https://github.com/apitrace/apitrace/blob/master/specs/glapi.py
https://github.com/apitrace/apitrace/blob/master/helpers/glsize.
Am 10.06.2015 um 23:31 schrieb Rob Clark:
> On Wed, Jun 10, 2015 at 5:13 PM, Jose Fonseca wrote:
>> I think it make sense for us to start using SVIEW regardless, and uniformize
>> things.
>>
>>
>> Even if GLSL will never support independent texture/samplers, D3D10, OpenCL,
>> Metal, and potential
In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm
using drm_intel_bo_alloc_tiled(). But, In case of YF/YS tiled buffers
libdrm need not know about the tiling format because these buffers
don't have hardware support to be tiled or detiled through a fenced
region. libdrm still need
Buffers with Yf/Ys tiling end up using meta upload / download
paths or the blitter for cases where they used tiled_memcpy paths
in case of Y tiling. This has exposed some bugs in meta path. To
avoid any piglit regressions on SKL this patch keeps the Yf/Ys
tiling disabled at the moment.
V3: Make br
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
Jenkins showed no piglit regressions with this series.
src/mesa/drivers/dri/i965/brw_tex_layout.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/driv
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index c0ef5cc..c185e41 100644
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index c185e41..
This patch enables using XY_FAST_COPY_BLT only for Yf/Ys tiled buffers.
It can be later turned on for other tiling patterns (X,Y) too.
V3: Flush in between sequential fast copy blits.
Fix src/dst alignment requirements.
Make can_fast_copy_blit() helper.
Use ffs(), is_power_of_two()
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_blit.c | 93 ++
1 file changed, 61 insertions(+), 32 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
b/src/mesa/drivers/dri/i965/intel_blit.c
index 800ed7e..987b5f5 100644
--- a/src/m
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
src/mesa/state_tracker/st_cb_drawpixels.c | 30 +++---
1 file changed, 3 insertions(+), 27 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c
b/src/mesa/state_tracker/st_cb_drawpixels.c
index a6a98c8..e736
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
Jenkins showed no piglit regressions with this series.
src/mesa/main/blit.c | 26 ++
src/mesa/main/blit.h | 6 ++
2 files changed, 32 insertions(+)
diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c
index db8fee
Signed-off-by: Anuj Phogat
---
src/mesa/swrast/s_copypix.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/src/mesa/swrast/s_copypix.c b/src/mesa/swrast/s_copypix.c
index 68c83e4..8fde0c2 100644
--- a/src/mesa/swrast/s_copypix.c
+++ b/src/mesa/swrast/s_copypi
https://bugs.freedesktop.org/show_bug.cgi?id=90905
--- Comment #3 from Emil Velikov ---
Yes the situation is a "bit" messy, and considering the interesting use of
xmlconfig by the loader (and effectively libGL) I intentionally stayed away
from it.
Anywho, I've picked Erik's approach, updated+tes
Based on commit 101142c4010(xa: support for drivers which use NIR)
Cc: "10.6"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90466
Signed-off-by: Emil Velikov
---
src/gallium/targets/d3dadapter9/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/targets/d3dada
Just like every other place in gallium.
Signed-off-by: Emil Velikov
---
src/gallium/drivers/freedreno/Makefile.am | 2 +-
src/gallium/drivers/nouveau/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/freedreno/Makefile.am
b/src/gallium/driv
From: Erik Faye-Lund
As we use the file from both the dri modules and loader, we end up with
multiple definition of the symbols provided in our gallium dri modules.
Additionally we compile the file twice.
Resolve both issues, effectively enabling the build on toolchains which
don't support -Wl,
Cc: Rob Clark
Cc: "10.6"
Signed-off-by: Emil Velikov
---
src/gallium/drivers/freedreno/Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/freedreno/Makefile.am
b/src/gallium/drivers/freedreno/Makefile.am
index 4b2629f..e798e44 100644
--- a/src
Based on commit 101142c4010(xa: support for drivers which use NIR)
Cc: Rob Clark
Cc: "10.6"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90466
Signed-off-by: Emil Velikov
---
src/gallium/targets/pipe-loader/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium
Rather than forcing everyone to provide their own definition of the symbol
provide a common (dummy) one.
This helps us resolve the build of the standalone pipe-drivers (amongst
others), which are missing the symbol.
Cc: Rob Clark
Cc: "10.6"
Signed-off-by: Emil Velikov
---
src/Makefile.am
Silence the warnings about the future incompatibility with automake 2.0
Cc: Eric Anholt
Signed-off-by: Emil Velikov
---
src/gallium/drivers/vc4/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/vc4/Makefile.am
b/src/gallium/drivers/vc4/Makefile.am
index 7744
On 06/10/2015 03:05 PM, Shervin Sharifi wrote:
> Thanks Ian.
> If I want to implement the actual CompSize function, how should I figure
> out the details?
The way I did it for the GLX protocol code in Mesa is to make a
glFoo_compsize function for each GL function that has a variable sized
array a
For 1-3,
Reviewed-by: Brian Paul
On 06/10/2015 04:34 PM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
Cc: Ben Widawsky
---
Jenkins showed no piglit regressions with this series.
src/mesa/main/blit.c | 26 ++
src/mesa/main/blit.h | 6 ++
2 files changed, 32
On Wed, Jun 10, 2015 at 3:54 PM, Emil Velikov wrote:
> From: Erik Faye-Lund
>
> As we use the file from both the dri modules and loader, we end up with
> multiple definition of the symbols provided in our gallium dri modules.
> Additionally we compile the file twice.
>
> Resolve both issues, eff
From: Haixia Shi
The surfaceless platform is for off-screen rendering only. Render node support
is required.
Only consider the render nodes. Do not use normal nodes as they require
auth hooks.
v3: egl/dri2: change platform_null to platform_surfaceless
Signed-off-by: Haixia Shi
Signed-off-by:
On 5 June 2015 at 22:08, Rob Clark wrote:
> so, maybe a bit off topic (and maybe doesn't really help with the
> whole finding a mentor thing).. but a sort of wish-list thing for
> piglit that I've had in the back of my head is something like "tig"
> for piglit. I suppose it doesn't have to necess
---
Emil,
With your series, I think we can enable subdir-objects globally!
Please give it a test.
configure.ac | 2 +-
src/Makefile.am | 2 --
src/gallium/auxiliary/Makefile.am | 2 --
src/gallium/drivers/freedreno/Makef
https://bugs.freedesktop.org/show_bug.cgi?id=90264
Furkan changed:
What|Removed |Added
CC||bri...@vmware.com
Component|Drivers/Ga
https://bugs.freedesktop.org/show_bug.cgi?id=90264
--- Comment #20 from Furkan ---
I booted up a Haswell (i7-4770) machine from an Ubuntu 15.04 live USB, and was
able to reproduce the same glitch.
It looks like we can reproduce this on radeon, nouveau, and i965, but not
llvmpipe. What does that
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_blit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
b/src/mesa/drivers/dri/i965/intel_blit.c
index 987b5f5..068565c 100644
--- a/src/mesa/drivers/dri/i965/intel_blit.c
+++ b/src/mesa/dr
I don't know where this alignment restriction came from. We have an
assert() in intel_miptree_map_movntdqa() which expects the pitch to
be 16 byte aligned.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/common/meta_blit.c
index bb21642..9cace2b 100644
--- a/src/mesa/drivers/common/meta_blit.c
+++ b/src
This will be used by _mesa_meta_pbo_GetTexSubImage() in a later patch.
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 11 ++-
src/mesa/main/readpix.h | 3 +++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index 9166a50..cba9db8 100644
--- a/src/mesa/main/readpix.c
+++ b/src/mesa/main/readpix.c
@@ -421,7 +421,7 @@ re
After recent addition of pbo testing in piglit test getteximage-luminance,
it fails on i965. This patch makes a sub test pass.
Signed-off-by: Anuj Phogat
Cc:
---
src/mesa/drivers/common/meta_tex_subimage.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/common/meta_
On Wed, Jun 10, 2015 at 7:28 PM, Emil Velikov wrote:
> On 5 June 2015 at 22:08, Rob Clark wrote:
>> so, maybe a bit off topic (and maybe doesn't really help with the
>> whole finding a mentor thing).. but a sort of wish-list thing for
>> piglit that I've had in the back of my head is something li
Hi gents,
On 10 June 2015 at 23:20, Zach Reizner wrote:
> From: Haixia Shi
>
> The surfaceless platform is for off-screen rendering only. Render node support
> is required.
>
> Only consider the render nodes. Do not use normal nodes as they require
> auth hooks.
>
> v3: egl/dri2: change platform
From: Nanley Chery
On Gen9+, vertical and horizontal alignment values for compressed textures are
equal to the pre-Gen9 value squared. Each miplevel must be aligned to this
value.
Signed-off-by: Nanley Chery
---
This fixes an FXT1 Piglit test regression and shows no failures on Jenkins.
src
On Wednesday, June 10, 2015 09:07:32 AM Iago Toral Quiroga wrote:
> In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
> to break a dEQP test that renders wide lines in some multisampling scenar
On 10 June 2015 at 23:56, Rob Clark wrote:
> On Wed, Jun 10, 2015 at 7:28 PM, Emil Velikov
> wrote:
>> On 5 June 2015 at 22:08, Rob Clark wrote:
>>> so, maybe a bit off topic (and maybe doesn't really help with the
>>> whole finding a mentor thing).. but a sort of wish-list thing for
>>> piglit
On Wed, Jun 10, 2015 at 5:04 PM, Emil Velikov wrote:
> On 10 June 2015 at 23:56, Rob Clark wrote:
>> On Wed, Jun 10, 2015 at 7:28 PM, Emil Velikov
>> wrote:
>>> On 5 June 2015 at 22:08, Rob Clark wrote:
so, maybe a bit off topic (and maybe doesn't really help with the
whole finding a
On Wednesday, June 10, 2015 05:57:05 PM Neil Roberts wrote:
> Kenneth Graunke writes:
>
> > _mesa_meta_fb_tex_blit_begin(ctx, &blit);
> > + ctx->Extensions.ARB_texture_stencil8 = true;
>
> Maybe you could put assert(ctx->Extensions.ARB_texture_stencil8==false)
> just before setting it to t
From: Rob Clark
To allow for shaders which use SVIEW decls for TEX* instructions, we
need to preserve the constraint that the shader either has no SVIEW's or
it has one matching SVIEW for each SAMP.
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/util/u_pstipple.c | 25 -
From: Rob Clark
To allow for shaders which use SVIEW decls for TEX* instructions, we
need to preserve the constraint that the shader either has no SVIEW's or
it has one matching SVIEW for each SAMP.
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/draw/draw_pipe_aaline.c | 20 +
From: Rob Clark
Based on mailing list discussion here:
http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html
Signed-off-by: Rob Clark
---
src/gallium/docs/source/tgsi.rst | 12
1 file changed, 12 insertions(+)
diff --git a/src/gallium/docs/source/tgsi.rst b/sr
From: Rob Clark
v2: rebased on using SVIEW to hold type information
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 44 -
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/
From: Rob Clark
Some hardware needs to know the sampler type. Update the blit related
shaders to include SVIEW decl.
Signed-off-by: Rob Clark
---
Possibly I should have refactored the existing code to pass around a
return_type rather than doing the is_uint/is_sint thing everywhere.
And this do
From: Rob Clark
Freedreno needs sampler type information to deal with int/uint textures.
To accomplish this, start creating sampler-view declarations, as
suggested here:
http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html
create a sampler-view with index matching the sampl
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/tgsi/tgsi_transform.h | 24
1 file changed, 24 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.h
b/src/gallium/auxiliary/tgsi/tgsi_transform.h
index 921aa906..e7de49e 100644
--- a/
On Wed, Jun 10, 2015 at 03:34:50PM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> Cc: Ben Widawsky
1 and 2 are:
Reviewed-by: Ben Widawsky
[snip]
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/
On 11.06.2015 04:55, Alex Deucher wrote:
> Module: Mesa
> Branch: amdgpu
> Commit: 0d60a4fb3a41817346a18f56acecdff566effed5
> URL:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d60a4fb3a41817346a18f56acecdff566effed5
>
> Author: Alex Deucher
> Date: Wed Jun 10 11:39:30 2015 -0400
>
>
Reviewed-by: Tapani Pälli
On 06/11/2015 02:46 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_blit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
b/src/mesa/drivers/dri/i965/intel_blit.c
index 987b5f5..06
From: Haixia Shi
The surfaceless platform is for off-screen rendering only. Render node support
is required.
Only consider the render nodes. Do not use normal nodes as they require
auth hooks.
v3: change platform_null to platform_surfaceless
v4: make libdrm required for surfaceless
Signed-off-
On 10/06/2015 18:08, Marc-André Lureau wrote :
Hi,
XPutImage requires to copy the images around, and the request may be
split over several chunks. Using XShm should improve performance.
Another way of doing that is to make the swrast loader allocate the buffers,
and have swrast swap buffers
Add pbuffer support for drm platform, because some customers are still using
this feature.
Signed-off-by: Ying Liu
---
src/egl/drivers/dri2/egl_dri2.c | 3 +++
src/egl/drivers/dri2/platform_drm.c | 30 +++---
2 files changed, 26 insertions(+), 7 deletions(-)
diff -
On Wed, 2015-06-10 at 17:03 -0700, Kenneth Graunke wrote:
> On Wednesday, June 10, 2015 09:07:32 AM Iago Toral Quiroga wrote:
> > In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> > match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
> > to brea
Reviewed-by: Tapani Pälli
On 06/11/2015 02:50 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/common/meta_blit.c
index
Alignment restriction is for _mm_stream_load_si128 used by
_mesa_streaming_load_memcpy
("The 128-bit (V)MOVNTDQA addresses must be 16-byte aligned or the
instruction will cause a #GP.")
Reviewed-by: Tapani Pälli
On 06/11/2015 02:50 AM, Anuj Phogat wrote:
I don't know where this alignment r
Hi, Matt,
I have updated the patch based on your review comments. As for
createNewDrawable, I add the condition to only use dri2_surf for pbuffer and
keep everything else unchanged.
Hi, Emil,
I have rebased my patch to master branch. Our QA team had run several 3D
workloads in windows7 VM us
On 06/11/2015 01:30 AM, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> Cc: Ben Widawsky
> ---
> Jenkins showed no piglit regressions with this series.
>
> src/mesa/drivers/dri/i965/brw_tex_layout.c | 20 +---
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --gi
In commit fe74fee8fa721a we rounded the line width to the nearest integer to
match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
to break a dEQP test that renders wide lines in some multisampling scenarios.
Ian noted that the Open 4.4 spec has the following similar text:
On Monday, June 08, 2015 02:53:26 PM Tapani Pälli wrote:
> v2: && -> ||, we enable on gles3 or if ARB_texture_rg is enabled
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90748
> ---
> src/mesa/main/glformats.c | 4
> 1 file changed, 4 insertions(+)
Not sure if we should care, but this could cause issues on G80 where you
can only set memtype on vram mappings. Pretty sure that's already
semi-broken though. But something to consider.
On Jun 10, 2015 5:29 AM, "Dave Airlie" wrote:
> When we import a dma-buf fd from another driver the kernel
> gi
On 09/06/15 19:34, Jordan Justen wrote:
> On 2015-06-09 00:30:45, Samuel Iglesias Gonsálvez wrote:
>> On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote:
>>> On 08/06/15 23:36, Jordan Justen wrote:
On 2015-06-03 00:00:59, Iago Toral Quiroga wrote:
> This includes the array of bindings, t
This makes the SSA definitions use sequential numbers (0, 1, 2, ...)
instead of seemingly random ones. There's not much point normally,
but it makes debug output much easier to read.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_nir.c | 6 ++
1 file changed, 6 insertions(
> Whether you need to pass the image
> dimensions and data type to the kernel as explicit parameters or not
> (e.g. because your hardware already supports some sort of image metadata
> query opcode) is driver-specific, so it would probably be a better idea
> to append these parameters at the end of
These are basically just moves, so they should be safe as well.
When disabling i965's GLSL IR level scalarizer (channel expressions)
pass, I started seeing NIR code like this:
if ssa_21 {
block block_1:
/* preds: block_0 */
vec4 ssa_120 = ve
Shaders with excessive number of attributes (>16) can produce a crash
due to buffer overflow in assign_attribute_or_color_locations. The
overflow can happen because we declare a fixed size array that can hold
up to 16 attributes and we don't check that we don't go beyond that
limit.
This patch cha
Just implement it in terms of util_resource_copy_region(). Both the
original code and util_resource_copy_region() boil down to mapping,
calling util_copy_box() and unmapping.
No piglit regressions. This will also help to implement GL_ARB_copy_image.
---
src/gallium/drivers/llvmpipe/lp_surface.c
A freshly constructed instruction defaults to having a base_mrf of 0
which means that if nothing disables it it will default to using
send-from-MRF. Previously this didn't matter because the constant load
instructions on Gen7 were ignoring the base_mrf anyway. However in the
next patch the brw_send
Matt Turner writes:
>> I'll have another look at moving it into brw_send_indirect_message.
>
> Thanks. I'm not really sure what the right solution is, so if you
> decide this patch is good as is, that's fine with me.
Here's what the patches would look like if we made
brw_send_indirect_message lo
Previously when setting up the sample instruction for an indirect
sampler the vec4 backend was directly passing the pseudo opcode's
src0. However vec4_visitor::visit(ir_texture *) doesn't set the
texture operation's src0 -- it's left as BAD_FILE, which when
translated into a brw_reg gives the null
Indeed I don't see any reason not to use util_resource_copy_region.
In fact, it might actually fix some bugs, as llvmpipe_transfer_map()
which has some extra smarts for tracking diry constant buffers, which
was not being exercised by lp_resource_copy().
Reviewed-by: Jose Fonseca
Jose
On
I don't think this can potentially fix anything, since buffers were
falling back to using util_resource_copy_region() already.
I am actually wondering though if the separate flushing done in
lp_resource_copy() is still necessary given that it should be done when
getting the transfers in util_resour
Instead use fs_builder::null_reg_f() which has the correct register
width. Avoids the assertion failure in fs_builder::emit() hit by the
"ES3-CTS.shaders.loops.for_dynamic_iterations.unconditional_break_fragment"
GLES3 conformance test introduced by 4af4cfba9ee1014baa4a777660fc9d53d57e4c82.
Repor
Implements putImageShm from DRIswrastLoaderExtension.
If XShm extension is not available, or fails, it will fallback on
regular XPutImage().
Tested on Linux only with 16bpp and 32bpp visual.
---
src/glx/drisw_glx.c | 164 +++
src/glx/drisw_priv.h
Add a new API to put an image using shared memory. Instead of only
passing the data pointer, 3 arguments are given: the shmid, the data
offset and the shmaddr.
Bump interface version.
---
include/GL/internal/dri_interface.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff
If drisw_loader_funcs implements put_image_shm, allocates display
target data with shared memory and display with put_image_shm().
---
src/gallium/winsys/sw/dri/dri_sw_winsys.c | 72 +--
1 file changed, 60 insertions(+), 12 deletions(-)
diff --git a/src/gallium/winsys/
Hi,
XPutImage requires to copy the images around, and the request may be
split over several chunks. Using XShm should improve performance.
In particular, the performances are bad when using gnome-shell with
Spice and playing video. Chunking the update confuses the video
detection heuristic: unfor
If the DRIswrastLoaderExtension implements putImageShm, bind it to
drisw_loader_funcs.
---
src/gallium/include/state_tracker/drisw_api.h | 3 +++
src/gallium/state_trackers/dri/drisw.c| 37 +--
2 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/src/gal
On Wed, Jun 10, 2015 at 06:08:57PM +0200, Marc-André Lureau wrote:
> static void
> -swrastPutImage2(__DRIdrawable * draw, int op,
> +swrastXPutImage(__DRIdrawable * draw, int op,
> int x, int y, int w, int h, int stride,
> -char *data, void *loaderPrivate)
> +
From: Marek Olšák
---
include/GL/internal/dri_interface.h | 5 +
src/egl/drivers/dri2/egl_dri2.c | 23 +++
src/egl/drivers/dri2/egl_dri2.h | 1 +
3 files changed, 29 insertions(+)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_inter
From: Marek Olšák
The problem is it makes Ubuntu Unity dark. It's probably using
OpenGL ES 2.0, chooses an sRGB-capable config and there is no way
to turn off sRGB rendering then.
---
src/glx/dri_common.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/glx/dri_common.c b/src/glx
From: Marek Olšák
---
src/mesa/main/blend.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c
index d869fa2..d365305 100644
--- a/src/mesa/main/blend.c
+++ b/src/mesa/main/blend.c
@@ -930,12 +930,10 @@ void _mesa_init_col
From: Marek Olšák
They are only useful for EGL currently, because the previous patch disables
them for GLX.
---
src/gallium/state_trackers/dri/dri2.c | 2 ++
src/gallium/state_trackers/dri/dri_screen.c | 23 +++
src/mesa/state_tracker/st_manager.c | 1 +
3 fil
1 - 100 of 121 matches
Mail list logo
