On Wednesday, June 10, 2015 05:57:05 PM Neil Roberts wrote:
> Kenneth Graunke <kenn...@whitecape.org> writes:
> 
> >     _mesa_meta_fb_tex_blit_begin(ctx, &blit);
> > +   ctx->Extensions.ARB_texture_stencil8 = true;
> 
> Maybe you could put assert(ctx->Extensions.ARB_texture_stencil8==false)
> just before setting it to true so that we'll definitely remember to
> remove it if we eventually enable the extension. Otherwise as it stands
> if we forget about this it would probably not break any tests but the
> extension would mysteriously disable itself and no-one would notice
> because they would probably check the extensions just once upfront.
> 
> - Neil

Great idea.  Added, retested, and pushed.  Thanks all!

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to