---
src/glsl/ast_to_hir.cpp | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index dfe106b..350f6ed 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3850,7 +3850,15 @@ ast_declarator_list::hir(exec
From: Haixia Shi
The surfaceless platform is for off-screen rendering only. Render node support
is required.
Only consider the render nodes. Do not use normal nodes as they require
auth hooks.
v3: change platform_null to platform_surfaceless
Signed-off-by: Haixia Shi
Signed-off-by: Zach Reizn
On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote:
> On 08/06/15 23:36, Jordan Justen wrote:
>> On 2015-06-03 00:00:59, Iago Toral Quiroga wrote:
>>> This includes the array of bindings, the current buffer bound to the
>>> GL_SHADER_STORAGE_BUFFER target and a set of general limits and default
>
Reviewed-by: Tapani Pälli
On 06/09/2015 10:03 AM, Timothy Arceri wrote:
---
src/glsl/ast_to_hir.cpp | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index dfe106b..350f6ed 100644
--- a/src/glsl/ast_to_hir.cpp
+++
Signed-off-by: Tapani Pälli
---
src/glsl/link_varyings.cpp | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 7b2d4bd..a19ee39 100644
--- a/src/glsl/link_varyings.cpp
+++ b/src/glsl/link_varyings.cpp
@@ -1
On Thursday, June 04, 2015 02:03:21 AM Kenneth Graunke wrote:
> On Thursday, June 04, 2015 11:38:52 AM Abdiel Janulgue wrote:
> >
> > On 06/02/2015 10:54 AM, Kenneth Graunke wrote:
> > > On Monday, June 01, 2015 03:14:26 PM Abdiel Janulgue wrote:
> [snip]
> > I'm the one who is being funny here. A
On Tuesday, June 09, 2015 09:53:42 AM Tapani Pälli wrote:
> Mesa supports EXT_texture_rg and OES_texture_float. This patch adds
> support for using unsized enums GL_RED and GL_RG for floating point
> targets and writes proper checks for internalformat when format is
> GL_RED or GL_RG and type is of
On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote:
> In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
> to break a dEQP test that renders wide lines in some multisampling scenario
On 09/06/15 04:03, Rob Clark wrote:
On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger wrote:
Am 09.06.2015 um 04:40 schrieb Rob Clark:
On Mon, Jun 8, 2015 at 10:36 PM, Roland Scheidegger wrote:
Am 09.06.2015 um 04:20 schrieb Rob Clark:
On Mon, Jun 8, 2015 at 9:40 PM, Roland Scheidegger w
> Why keeping the assertion commented out?
Because to test the image support functionality I'm working on, I have to
create an image and pass it to a kernel, which triggers the assertion ATM.
> Can you just fix evergreen_set_cs_sampler_view so that it supports
views==NULL?
Fair point, will do th
Ok, thanks for the feedback.
On Mon, Jun 8, 2015 at 2:18 PM, Francisco Jerez
wrote:
> Zoltan Gilian writes:
>
> > Image attributes are passed to the kernel as hidden parameters after the
> > image attribute itself. An llvm pass replaces the getter builtins to
> > the appropriate parameters.
> >
On 06/09/2015 11:25 AM, Kenneth Graunke wrote:
On Tuesday, June 09, 2015 09:53:42 AM Tapani Pälli wrote:
Mesa supports EXT_texture_rg and OES_texture_float. This patch adds
support for using unsized enums GL_RED and GL_RG for floating point
targets and writes proper checks for internalformat w
Mesa supports EXT_texture_rg and OES_texture_float. This patch adds
support for using unsized enums GL_RED and GL_RG for floating point
targets and writes proper checks for internalformat when format is
GL_RED or GL_RG and type is of GL_FLOAT or GL_HALF_FLOAT.
Later, internalformat will get adjust
On Tue, 2015-06-09 at 01:49 -0700, Kenneth Graunke wrote:
> On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote:
> > In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> > match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
> > to break
Matt Turner writes:
> On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez wrote:
>> Matt Turner writes:
>>
>>> On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez
>>> wrote:
Matt Turner writes:
> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez
> wrote:
>> The purpose of this
Both patches look good to me and I can confirm they make the Piglit
tests pass on Skylake.
Reviewed-by: Neil Roberts
My original assumption of the problem was that the implied writes from
the SCRATCH_WRITE instruction aren't taken into account when calculating
the liveliness of the registers and
Here's a series of patches to tackle bug 84225.
Previous series was discussed in this thread:
http://lists.freedesktop.org/archives/mesa-dev/2015-May/084604.html
Thanks;
Tapani Pälli (4):
glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00
mesa/glsl: new compiler option UnrollSamp
Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00.
Earlier versions allow 'constant-index-expression' indexing, where
index can contain a loop induction variable.
Patch allows dynamic indexing for sampler arrays when GLSL ES < 3.00.
This change makes 'sampler-array-index.frag' parse
Patch provides new compiler option for backend to force unroll loops
that have non-constant expression indexing on sampler arrays.
This makes sure that we can never end up with a shader that uses loop
induction variable as sampler array index but does not unroll because
of having too much instruct
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index 652d9a3..38c6f72 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/
Desktop GLSL < 130 and GLSL ES < 300 allow sampler array indexing where
index can contain a loop induction variable. This extra check will warn
during linking if some of the indexes could not be turned in to constant
expressions.
v2: warning instead of error for backends that did not enable
Un
Thanks a lot Ken! Your help in debugging this pointed me in the right
direction! I had some further observations below:
On 06/09/2015 11:08 AM, Kenneth Graunke wrote:
>
> (To bring the mailing list up to speed: Abdiel mentioned on IRC tonight
> that this is actually still necessary---some Pigli
Tapani Pälli writes:
> Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00.
> Earlier versions allow 'constant-index-expression' indexing, where
> index can contain a loop induction variable.
>
> Patch allows dynamic indexing for sampler arrays when GLSL ES < 3.00.
> This change make
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
> Iago Toral Quiroga
> Sent: Tuesday, June 09, 2015 9:50 AM
> To: mesa-dev@lists.freedesktop.org
> Subject: [Mesa-dev] [PATCH] i965: do not round line width when multisampling
> or antialiasin
Reviewed-by: Martin Peres
Sorry for the delay...
On 06/05/15 13:43, Tapani Pälli wrote:
(increases ES31-CTS.draw_indirect.basic.* passing tests)
v2: only expose DRAW_INDIRECT_BUFFER_BINDING for GL core + ES3.1
Signed-off-by: Tapani Pälli
---
src/mesa/main/get.c | 12 +
Tapani Pälli writes:
> Patch provides new compiler option for backend to force unroll loops
> that have non-constant expression indexing on sampler arrays.
>
> This makes sure that we can never end up with a shader that uses loop
> induction variable as sampler array index but does not unroll bec
Tapani Pälli writes:
> Signed-off-by: Tapani Pälli
> ---
> src/mesa/drivers/dri/i965/brw_context.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c
> b/src/mesa/drivers/dri/i965/brw_context.c
> index 652d9a3..38c6f72 100644
> --- a/src/mesa/d
On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca wrote:
> On 09/06/15 04:03, Rob Clark wrote:
>>
>> On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger
>> wrote:
>>>
>>> Am 09.06.2015 um 04:40 schrieb Rob Clark:
On Mon, Jun 8, 2015 at 10:36 PM, Roland Scheidegger
wrote:
>
> Am
Tapani Pälli writes:
> Desktop GLSL < 130 and GLSL ES < 300 allow sampler array indexing where
> index can contain a loop induction variable. This extra check will warn
> during linking if some of the indexes could not be turned in to constant
> expressions.
>
> v2: warning instead of error for b
Francisco Jerez writes:
> Tapani Pälli writes:
>
>> Desktop GLSL < 130 and GLSL ES < 300 allow sampler array indexing where
>> index can contain a loop induction variable. This extra check will warn
>> during linking if some of the indexes could not be turned in to constant
>> expressions.
>>
>>
On 09/06/15 03:00, Roland Scheidegger wrote:
Am 08.06.2015 um 09:33 schrieb Chih-Sheng Lin:
Hi,
I am working on parallelizing softpipe of Mesa-9.1 by using OpenMP.
My idea is trying to do sp_setup_tri in parallel with multiple threads.
So first in the function sp_vbuf_draw_elements, I duplica
Am 09.06.2015 um 11:01 schrieb Jose Fonseca:
> On 09/06/15 04:03, Rob Clark wrote:
>> On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger
>> wrote:
>>> Am 09.06.2015 um 04:40 schrieb Rob Clark:
On Mon, Jun 8, 2015 at 10:36 PM, Roland Scheidegger
wrote:
> Am 09.06.2015 um 04:20 schri
Am 09.06.2015 um 15:00 schrieb Rob Clark:
> On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca wrote:
>> On 09/06/15 04:03, Rob Clark wrote:
>>>
>>> On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger
>>> wrote:
Am 09.06.2015 um 04:40 schrieb Rob Clark:
>
> On Mon, Jun 8, 2015 at 10:3
We're only using fairly portable standard Unix calls here, so might as
well save ourselves future trouble by enabling on all Unices by default.
https://bugs.freedesktop.org/show_bug.cgi?id=90904
---
src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 06/09/2015 07:48 AM, Jose Fonseca wrote:
We're only using fairly portable standard Unix calls here, so might as
well save ourselves future trouble by enabling on all Unices by default.
https://bugs.freedesktop.org/show_bug.cgi?id=90904
---
src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +-
Am 09.06.2015 um 15:48 schrieb Jose Fonseca:
> We're only using fairly portable standard Unix calls here, so might as
> well save ourselves future trouble by enabling on all Unices by default.
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D90904
https://bugs.freedesktop.org/show_bug.cgi?id=90904
José Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 06/08/2015 11:49 PM, Iago Toral Quiroga wrote:
> In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> match the GLES3 spec requirements stated in section 13.4.2.1, but that seems
> to break a dEQP test that renders wide lines in some multisampling scenarios.
>
> Ian no
On 05/06/2015 03:43 AM, Tapani Pälli wrote:
> (increases ES31-CTS.draw_indirect.basic.* passing tests)
>
> v2: only expose DRAW_INDIRECT_BUFFER_BINDING for GL core + ES3.1
>
> Signed-off-by: Tapani Pälli
I would have rather seen adding the EXTRA_API_ES31 bits and the
DRAW_INDIRECT_BUFFER_BINDIN
On 05/06/2015 01:53 AM, Marta Lofstedt wrote:
> GL_ARB_shader_image_load store support is required for GLES 3.1
> conformance.
>
> Signed-off-by: Marta Lofstedt
> ---
> src/mesa/main/get.c | 6 ++
> src/mesa/main/get_hash_params.py | 8
> 2 files changed, 14 insertions(
On Mon, Jun 8, 2015 at 9:50 AM, Matt Turner wrote:
> On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez wrote:
>> Matt Turner writes:
>>> On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez
>>> wrote:
Matt Turner writes:
> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez
> wrote:
>
On Tue, Jun 9, 2015 at 9:32 AM, Roland Scheidegger wrote:
> Am 09.06.2015 um 15:00 schrieb Rob Clark:
>> On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca wrote:
>>> On 09/06/15 04:03, Rob Clark wrote:
On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger
wrote:
>
> Am 09.06.2015
On 06/09/2015 08:48 AM, Ian Romanick wrote:
> On 05/06/2015 01:53 AM, Marta Lofstedt wrote:
>> GL_ARB_shader_image_load store support is required for GLES 3.1
>> conformance.
>>
>> Signed-off-by: Marta Lofstedt
>> ---
>> src/mesa/main/get.c | 6 ++
>> src/mesa/main/get_hash_param
On 06/09/2015 09:08 AM, Ian Romanick wrote:
> On 06/09/2015 08:48 AM, Ian Romanick wrote:
>> On 05/06/2015 01:53 AM, Marta Lofstedt wrote:
>>> GL_ARB_shader_image_load store support is required for GLES 3.1
>>> conformance.
>>>
>>> Signed-off-by: Marta Lofstedt
>>> ---
>>> src/mesa/main/get.c
On 05/07/2015 12:57 AM, Marta Lofstedt wrote:
> From: Marta Lofstedt
>
> v2: only expose enums from GL_ARB_shader_image_load_store
> for gles 3.1 and GL core
We expose all of these extensions on compatibility profile, so only
allowing the queries in core profile is going to break everything. Th
On Tue, Jun 9, 2015 at 4:05 AM, Neil Roberts wrote:
> Both patches look good to me and I can confirm they make the Piglit
> tests pass on Skylake.
>
> Reviewed-by: Neil Roberts
>
> My original assumption of the problem was that the implied writes from
> the SCRATCH_WRITE instruction aren't taken
On 05/12/2015 01:46 AM, Marta Lofstedt wrote:
> From: Marta Lofstedt
>
> v2 : Refine the restriction to Version == 30.
>
> Signed-off-by: Marta Lofstedt
> ---
> src/mesa/main/multisample.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/multisample.c
On 05/12/2015 08:00 AM, Ilia Mirkin wrote:
> On Tue, May 12, 2015 at 10:53 AM, Marta Lofstedt
> wrote:
>> From: Marta Lofstedt
>>
>> Signed-off-by: Marta Lofstedt
>> ---
>> src/glsl/builtin_functions.cpp | 3 +--
>> src/glsl/builtin_types.cpp | 2 +-
>> src/glsl/glsl_lexer.ll | 13
On 05/29/2015 02:44 AM, Michel Dänzer wrote:
>
> Hi Ian,
>
>
> On 29.05.2015 09:00, i...@kemper.freedesktop.org (Ian Romanick) wrote:
>> Module: Mesa
>> Branch: master
>> Commit: 9b5e92f4ccc6ee1cb9caea947f6efaad2b391cf1
>> URL:
>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b5e92f4ccc6
On Mon, Jun 8, 2015 at 3:50 PM, Ben Widawsky
wrote:
> Previously the number needed to be divided by 4 to get the proper results. Now
> the hardware does the right thing. Through experimentation it seems Braswell
> (CHV) does also need this.
>
> Fixes piglit test:
> arb_pipeline_statistics_query-fr
On Mon, Jun 8, 2015 at 3:38 PM, Ben Widawsky
wrote:
> There are several constraints when determining if one can fast clear a
> surface.
> Some of these are alignment, pixel density, tiling formats, and others that
> vary
> by generation. The helper function which exists today does a suitable job
On 03/11/2015 02:01 AM, Eduardo Lima Mitev wrote:
> From: Antia Puentes
>
> From section 3.4 ("Preprocessor") of the GLSL ES 3.00 specification:
> "#line must have, after macro substitution, one of the following forms:
> #line line
> #line line source-string-number
> where line and so
If you only want to modify TGSI and not all the users, you only have
to fix tgsi_ureg. tgsi_ureg is a layer that can hide a lot of small
ugly details if needed, including sampler view declarations when the
users don't even know about them.
Marek
On Tue, Jun 9, 2015 at 6:01 PM, Rob Clark wrot
On Tuesday, June 09, 2015 03:01:00 PM Abdiel Janulgue wrote:
>
> Thanks a lot Ken! Your help in debugging this pointed me in the right
> direction! I had some further observations below:
>
> On 06/09/2015 11:08 AM, Kenneth Graunke wrote:
>
> >
> > (To bring the mailing list up to speed: Abdiel
On Tuesday, June 09, 2015 11:29:48 AM Iago Toral wrote:
> On Tue, 2015-06-09 at 01:49 -0700, Kenneth Graunke wrote:
> > On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote:
> > > In commit fe74fee8fa721a we rounded the line width to the nearest integer
> > > to
> > > match the GLES3 spe
On Tue, Jun 09 2015, Ian Romanick wrote:
>> From section 3.4 ("Preprocessor") of the GLSL ES 3.00 specification:
>> "#line must have, after macro substitution, one of the following forms:
>> #line line
>> #line line source-string-number
>> where line and source-string-number are constant
On 06/04/2015 06:38 PM, Ben Widawsky wrote:
> On Wed, Mar 11, 2015 at 10:01:24AM +0100, Eduardo Lima Mitev wrote:
>> Page 68, section 7.2 'Shader Binaries" of the of the OpenGL ES 3.1,
>> and page 88 of the OpenGL 4.5 specs state:
>>
>> "An INVALID_VALUE error is generated if count or length is
Jason Ekstrand writes:
> On Mon, Jun 8, 2015 at 9:50 AM, Matt Turner wrote:
>> On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez
>> wrote:
>>> Matt Turner writes:
On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez
wrote:
> Matt Turner writes:
>> On Thu, Jun 4, 2015 at 9:04 AM,
On 03/11/2015 02:01 AM, Eduardo Lima Mitev wrote:
> From: Iago Toral Quiroga
>
> Shaders with excessive number of attributes (>16) can produce a crash
> due to buffer overflow in assign_attribute_or_color_locations. The
> overflow can happen because we declare a fixed size array that can hold
> u
On Tuesday, June 09, 2015 12:26:48 PM Tapani Pälli wrote:
> Mesa supports EXT_texture_rg and OES_texture_float. This patch adds
> support for using unsized enums GL_RED and GL_RG for floating point
> targets and writes proper checks for internalformat when format is
> GL_RED or GL_RG and type is of
On 06/09/2015 10:40 AM, Carl Worth wrote:
> On Tue, Jun 09 2015, Ian Romanick wrote:
>>> From section 3.4 ("Preprocessor") of the GLSL ES 3.00 specification:
>>> "#line must have, after macro substitution, one of the following forms:
>>> #line line
>>> #line line source-string-number
>>> wh
On 2015-06-09 00:30:45, Samuel Iglesias Gonsálvez wrote:
> On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote:
> > On 08/06/15 23:36, Jordan Justen wrote:
> >> On 2015-06-03 00:00:59, Iago Toral Quiroga wrote:
> >>> This includes the array of bindings, the current buffer bound to the
> >>> GL_SHADE
On 2015-06-03 00:01:01, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez
>
> See GLSL 4.30 spec, section 4.4.5 "Uniform and Shader Storage Block
> Layout Qualifiers".
>
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> src/glsl/ast_to_hir.cpp | 29 -
> s
Jason Ekstrand writes:
> The only place when the fact that the MRFs are virtual matters is in
> register allocation. Implied MRF writes are taken into account in
> setup_mrf_hack_interference. We figure out what MRFs are used and
> then mark them as conflicting with *all* of the VGRFs. We also
On 2015-06-03 00:01:02, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez
>
> Section 4.3.7 "Buffer Variables" of the GLSL 4.30 spec:
>
> "Buffer variables cannot have initializers."
>
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> src/glsl/ast_to_hir.cpp | 9 +
> 1
On Tue, Jun 9, 2015 at 11:11 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
>> The only place when the fact that the MRFs are virtual matters is in
>> register allocation. Implied MRF writes are taken into account in
>> setup_mrf_hack_interference. We figure out what MRFs are used and
>> th
On 06/01/2015 10:13 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/main/texcompress.c | 22 ++
> src/mesa/main/teximage.c| 28
> 2 files changed, 50 insertions(+)
>
> diff --git a/src/mesa/main/
On 06/01/2015 10:13 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> v2: remove extra newline.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/main/format_info.py | 2 ++
> src/mesa/main/formats.c | 28
> 2 files changed, 6 insertions(+), 24 deletions(-)
>
Should this patch be last? It looks like later patches fix bugs.
On 06/01/2015 10:13 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> v2: remove OES ASTC extension reference.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/drivers/dri/i965/intel_extensions.c | 5 +
> 1 file changed, 5 i
On 06/01/2015 10:13 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> In agreement with commit 4ab8d59a23, vertical alignment values are equal to
> four times the block height on Gen9+.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/drivers/dri/i965/brw_tex_layout.c | 7 +--
> 1 file chan
On 06/01/2015 10:13 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> - Remove redundant checks and comments by grouping our calculations for
> align_w and align_h wherever possible.
> - Don't pass more parameters than necessary.
> - Minor code simplifications.
>
> Signed-off-by: Nanley Chery
https://bugs.freedesktop.org/show_bug.cgi?id=90249
--- Comment #2 from José Fonseca ---
It might be better to send the patch to mesa-dev for review.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
---
src/gallium/auxiliary/Android.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/Android.mk b/src/gallium/auxiliary/Android.mk
index 2d91752..4e204f9 100644
--- a/src/gallium/auxiliary/Android.mk
+++ b/src/gallium/auxiliary/Android.mk
@@ -30,6 +30,7 @@ include $(CLE
---
Android.mk| 2 +-
src/gallium/Android.mk| 5 +
src/gallium/drivers/vc4/Android.mk| 39 +++
src/gallium/targets/dri/Android.mk| 4
src/gallium/winsys/vc4/drm/Android.mk | 34 +
This was part of gallium_egl, and we now have the normal libEGL Android
winsys support to handle it.
---
src/gallium/winsys/sw/android/Android.mk | 34 ---
.../winsys/sw/android/android_sw_winsys.cpp| 264 -
src/gallium/winsys/sw/android/android_sw_winsys.h
---
src/egl/drivers/dri2/Android.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/drivers/dri2/Android.mk
index d4d809b..109e4d4 100644
--- a/src/egl/drivers/dri2/Android.mk
+++ b/src/egl/drivers/dri2/Android.mk
@@ -36,6 +36,7 @@ LOCAL_CFLAGS := \
Back in 2013, a patch was added (with 2 reviewers!) at the end of the
block to early exit the loop in this case, without noticing that the loop
already did. I added another early exit case, again without noticing, but
Rob caught me. Just drop the loop condition that apparently surprises
most of u
Hi Grigori,
Grigori Goronzy writes:
> Wrap MapBuffer and MapImage as hard_event actions, like other
> operations. This enables correct profiling. Also make sure to wait
> for events to finish when blocking is requested by the caller.
> ---
> src/gallium/state_trackers/clover/api/transfer.cpp |
On 06/09/2015 01:06 PM, Eric Anholt wrote:
> Back in 2013, a patch was added (with 2 reviewers!) at the end of the
> block to early exit the loop in this case, without noticing that the loop
> already did. I added another early exit case, again without noticing, but
> Rob caught me. Just drop the
Grigori Goronzy writes:
> Mapping can fail, and this should be handled. Return the proper error
> code and abort the associated event in this case.
> ---
> src/gallium/state_trackers/clover/api/transfer.cpp | 16 ++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git
Hello,
Unfortunately, this patch breaks things further, because...
On Fri, Jun 5, 2015 at 5:14 PM, Chris Wilson wrote:
> @@ -76,8 +77,14 @@ do_blit_drawpixels(struct gl_context * ctx,
> struct gl_renderbuffer *rb = ctx->DrawBuffer->_ColorDrawBuffers[0];
> struct intel_renderbuffer *irb =
On Tue, Jun 9, 2015 at 2:24 PM, Alexander Monakov wrote:
> Hello,
>
> Unfortunately, this patch breaks things further, because...
>
> On Fri, Jun 5, 2015 at 5:14 PM, Chris Wilson wrote:
>> @@ -76,8 +77,14 @@ do_blit_drawpixels(struct gl_context * ctx,
>> struct gl_renderbuffer *rb = ctx->Draw
On Tue, Jun 2, 2015 at 2:51 PM, Anuj Phogat wrote:
> Patch sets the alignments for texture and renderbuffer surfaces.
>
> V3: Make changes inside horizontal_alignment() and
> vertical_alignment() (Topi)
>
> Signed-off-by: Anuj Phogat
> Cc: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/
Hi,
The spec doesn't specify any behavior for
GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB other than it being accepted by a few
functions, so it's questionable whether we should do anything for it,
but all drivers currently only support FALSE.
All the infrastructure is there. Drivers only have to add a mesa
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
> - extension table
> - additions to gl_framebuffer
>
> v2:
> Formatting fixes.
>
> v3:
> mtypes.h: Correct comment on _HasAttachments.
>
> v4:
> Formatting fixes.
>
With the whitespace issues pointed out by Ilia fixed (which I noticed
too... lol), this patch is
Reviewed-by: Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Add convenience helper functions for fetching geometry of gl_framebuffer
> that return the geometry of the gl_framebuffer inst
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Define the enumeration constants, function entry points and
> glGet for the GL_ARB_framebuffer_no_attachments.
>
> v2:
> Add output="true" for GetFramebufferParameteriv parameter params.
> Alphabetical insertion.
>
> v3:
> Implement _mesa_GetFra
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Implement GL_ARB_framebuffer_no_attachments in Mesa core
> - changes to conditions for framebuffer completenss
> - implement set/get functions for framebuffers for
>new functions in GL_ARB_framebuffer_no_attachments
>
> v2:
> Spacing and excee
With the comment typo noticed by Ilia fixed (which I did not notice),
this patch is
Reviewed-by: Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Change references to gl_framebuffer::Width, Height, MaxNumLayers
> and Visual::samples to use the _mesa_geometry_ convenience functions
> f
This patch is
Reviewed-by: Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Add helper function that checks if current fragment shader active
> of gl_context has atomic buffer access.
>
> v3:
> Added in v3 of patch series.
>
> v4:
> Formatting fixes.
>
> Signed-off-by: Kevin Rogo
This patch is
Reviewed-by: Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Ensure that the GPU spawns the fragment shader thread for those
> fragment shaders with atomic buffer access.
>
> v2:
> No change.
>
> v3:
> Use utility function _mesa_active_fragment_shader_has_atomic_ops
I've sent out review for all of the patches that don't already have R-b
on them. Before pushing, you should double check the whitespace. In
particular, it's hard to notice tabs and trailing whitespace when
reviewing. If you do 'git show origin/master..' and search for tab or
'[[:space:]]*$'
Als
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Add helper convenience function that intersects the scissor values
> against a passed bounding box. In addition, to avoid replicated code,
> make the function _mesa_scissor_bounding_box() use this new function.
>
> v2:
> Split from patch "mesa:helper
Prefix the commit message with docs: and you can keep the R-b. :)
On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
> Mark GL_ARB_framebuffer_no_attachments as done for i965.
>
> v2:
> File added to patch series
>
> v3:
> docs/GL3.txt : add done mark under GLES3.1
> docs/relnotes/10.6.0.html : mai
Broadwell's stencil blitting code attempts to bind a renderbuffer as a
texture, using dd->BindRenderbufferTexImage().
This calls _mesa_init_teximage_fields(), which then attempts to set
img->_BaseFormat = _mesa_base_tex_format(ctx, internalFormat), which
assert fails if internalFormat is GL_STENCI
Hi all,
So here goes my first "RFC" on the value range pass
for NIR that I'm attacking as part of my GSoC.
"RFC" as it is not nearly done, and should be treated
as a "this is how I imagine it ending up" instead of
"close to functioning implementation".
For that reason, whoever feels like looking a
On Tue, Jun 9, 2015 at 4:06 PM, Eric Anholt wrote:
> Back in 2013, a patch was added (with 2 reviewers!) at the end of the
> block to early exit the loop in this case, without noticing that the loop
> already did. I added another early exit case, again without noticing, but
> Rob caught me. Just
On 10 June 2015 at 07:45, Marek Olšák wrote:
> Hi,
>
> The spec doesn't specify any behavior for
> GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB other than it being accepted by a few
> functions, so it's questionable whether we should do anything for it,
> but all drivers currently only support FALSE.
>
> All
This reverts commit f3b709c0ac073cd0ec90a3a0d91d1ee94668e043.
The "dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_4.
interpolation.lines_wide" test appears to be broken on Cherryview when
we expose line widths greater than 12.0. I'm not sure why.
For now, just go back to the limits we u
Connor and I have both hit bugs where code (such as dump_instructions())
attempts to use live intervals or VGRF information, and wasted a bunch
of time trying to debug that.
By freeing the arrays and zeroing the counts, we make any array access
out of bounds, which results in an obvious problem th
1 - 100 of 117 matches
Mail list logo
