On Tue, Jun 9, 2015 at 4:06 PM, Eric Anholt <e...@anholt.net> wrote:
> Back in 2013, a patch was added (with 2 reviewers!) at the end of the
> block to early exit the loop in this case, without noticing that the loop
> already did. I added another early exit case, again without noticing, but
> Rob caught me. Just drop the loop condition that apparently surprises
> most of us, instead of leaving the end of the loop conspicuously not
> exiting on success.
Reviewed-by: Rob Clark <robdcl...@gmail.com>
> ---
> src/egl/drivers/dri2/egl_dri2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 44a6c96..dceb9a0 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -397,7 +397,7 @@ dri2_open_driver(_EGLDisplay *disp)
>
> dri2_dpy->driver = NULL;
> end = search_paths + strlen(search_paths);
> - for (p = search_paths; p < end && dri2_dpy->driver == NULL; p = next + 1)
> {
> + for (p = search_paths; p < end; p = next + 1) {
> int len;
> next = strchr(p, ':');
> if (next == NULL)
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
