[Mesa-dev] [PATCH 2/7] draw: add stream member to stats callback

2015-05-27 Thread Dave Airlie
This just adds space for the member to the callback, doesn't change anything else. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_pt_so_emit.c | 2 +- src/gallium/auxiliary/draw/draw_vbuf.h | 1 + src/gallium/drivers/llvmpipe/lp_setup_vbuf.c | 2 +- src/gallium/drivers/soft

[Mesa-dev] [PATCH 1/7] draw/tgsi: implement geom shader invocation support.

2015-05-27 Thread Dave Airlie
From: Dave Airlie This is just for softpipe, llvmpipe won't work without some changes. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c | 47 +- src/gallium/auxiliary/draw/draw_gs.h | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++

[Mesa-dev] [PATCH 4/7] softpipe: add support for indexed queries.

2015-05-27 Thread Dave Airlie
We need indexed queries to retrieve the geom shader info. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_context.h | 2 +- src/gallium/drivers/softpipe/sp_prim_vbuf.c | 4 ++-- src/gallium/drivers/softpipe/sp_query.c | 23 --- src/gallium/include/pipe/

[Mesa-dev] [PATCH 6/7] softpipe: add support for vertex streams

2015-05-27 Thread Dave Airlie
This enables the ARB_gpu_shader5 vertex streams on softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index a688

[Mesa-dev] [RFC] softpipe/draw: gpu_shader5 geometry shader features.

2015-05-27 Thread Dave Airlie
Hey, First posting of these, Mainly looking for feedback on the approach, or any pitfalls anyone might notice, they pass most of the tests, need to schedule piglit runs for llvmpipe to make sure I haven't broken anything. Dave. ___ mesa-dev mailing lis

[Mesa-dev] [PATCH 7/7] docs/GL3.txt: update softpipe arb_gpu_shader5 status.

2015-05-27 Thread Dave Airlie
Signed-off-by: Dave Airlie --- docs/GL3.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 8e1c8cd..9fbde36 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -99,13 +99,13 @@ GL 4.0, GLSL 4.00: GL_ARB_gpu_shader5

[Mesa-dev] [PATCH 5/7] draw: add support to tgsi paths for geometry streams.

2015-05-27 Thread Dave Airlie
This hooks up the geometry shader processing to the TGSI support added in the previous commits. It doesn't change the llvm interface other than to keep things building. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c | 195 + src/gallium/aux

[Mesa-dev] [PATCH 3/7] tgsi: add support for geometry shader streams.

2015-05-27 Thread Dave Airlie
This adds support to retrieve the primitive counts for each stream, along with the offset for each primitive into the output array. It also adds support for parsing the stream argument to the emit and end instructions. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 59 +

[Mesa-dev] [PATCH] nir: Fix output swizzle in get_mul_for_src

2015-05-27 Thread Iago Toral Quiroga
When we compute the output swizzle we want to consider the writemask of the add operation, not the one from the multiplication. --- src/glsl/nir/nir_opt_peephole_ffma.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir_opt_peephole_ffma.c b/src/gl

[Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays.

2015-05-27 Thread Dave Airlie
This is required for ARB_gpu_shader5 support in softpipe. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_ex

Re: [Mesa-dev] [PATCH 1/2] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays (v2)

2015-05-27 Thread Michel Dänzer
On 27.05.2015 07:34, Marek Olšák wrote: > From: Marek Olšák > > v2: - don't use realloc (tgsi_shader_info provides the size) The series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

[Mesa-dev] [v4 PATCH 00/10] Implement extension ARB_framebuffer_no_attachments

2015-05-27 Thread Kevin Rogovin
This patch series implements: - the needed functionality in Mesa-core for ARB_framebuffer_no_attachments - implements and enables the extension i965 Kevin Rogovin (10): mesa: Define infrastructure for ARB_framebuffer_no_attachments mesa: Constants and functions for ARB_framebuffer_no_attac

[Mesa-dev] [v4 PATCH 02/10] mesa: Constants and functions for ARB_framebuffer_no_attachments

2015-05-27 Thread Kevin Rogovin
Define the enumeration constants, function entry points and glGet for the GL_ARB_framebuffer_no_attachments. v2: Add output="true" for GetFramebufferParameteriv parameter params. Alphabetical insertion. v3: Implement _mesa_GetFramebufferParameteriv and _mesa_FramebufferParameteri as always

[Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Kevin Rogovin
Add helper convenience function that intersects the scissor values against a passed bounding box. In addition, to avoid replicated code, make the function _mesa_scissor_bounding_box() use this new function. v2: Split from patch "mesa:helper-conveniance functions for drivers to implement ARB_fram

[Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-05-27 Thread Kevin Rogovin
Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then the gl_framebuffer has no attachments. v2: Split from patch "mesa:helper-conveniance functions for driver

[Mesa-dev] [v4 PATCH 08/10] i965: execution of frag-shader when it has atomic buffer

2015-05-27 Thread Kevin Rogovin
Ensure that the GPU spawns the fragment shader thread for those fragment shaders with atomic buffer access. v2: No change. v3: Use utility function _mesa_active_fragment_shader_has_atomic_ops(). v4: Formatting fixes. Reviewed-by: Tapani Pälli (v1) Signed-off-by: Kevin Rogovin --- src/mesa

[Mesa-dev] [v4 PATCH 09/10] i965: enable ARB_framebuffer_no_attachments for Gen7+

2015-05-27 Thread Kevin Rogovin
Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. v2: No changes. v3: intel_extensions.c: Alphabetize insertion. v4: No changes. Reviewed-by: Ian Romanick (v2) Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/drivers/dr

[Mesa-dev] [v4 PATCH 03/10] mesa: Complete ARB_framebuffer_no_attachments in Mesa core

2015-05-27 Thread Kevin Rogovin
Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in GL_ARB_framebuffer_no_attachments v2: Spacing and exceed 80 characters per line fixes. v3: Implement DSA functio

[Mesa-dev] [v4 PATCH 01/10] mesa: Define infrastructure for ARB_framebuffer_no_attachments

2015-05-27 Thread Kevin Rogovin
Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer v2: Formatting fixes. v3: mtypes.h: Correct comment on _HasAttachments. v4: Formatting fixes. mtypes.h: Clarify comments Signed-off-by: Kevin Rogovin --- src/

[Mesa-dev] [v4 PATCH 10/10] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-05-27 Thread Kevin Rogovin
Mark GL_ARB_framebuffer_no_attachments as done for i965. v2: File added to patch series v3: docs/GL3.txt : add done mark under GLES3.1 docs/relnotes/10.6.0.html : maintain alphabetical order v4: Move mark from 10.6.0.html to 10.7.0.html. Reviewed-by: Ian Romanick (v2) Signed-off-by: Kevin

[Mesa-dev] [v4 PATCH 07/10] mesa: function for testing if current frag-shader has atomics

2015-05-27 Thread Kevin Rogovin
Add helper function that checks if current fragment shader active of gl_context has atomic buffer access. v3: Added in v3 of patch series. v4: Formatting fixes. Signed-off-by: Kevin Rogovin --- src/mesa/main/mtypes.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-05-27 Thread Kevin Rogovin
Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection of the attachments of the gl_framebuffer). This

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-27 Thread Marek Olšák
Wow, I hadn't expected such a hateful comment on GLES1. Does anyone else want to convince me that GLES1 should burn in hell? Marek On Wed, May 27, 2015 at 7:01 AM, Dave Airlie wrote: > On 26 May 2015 at 22:08, Marek Olšák wrote: >> It's mainly for distributions. You can turn it off, but it won

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-27 Thread Dave Airlie
> Wow, I hadn't expected such a hateful comment on GLES1. > > Does anyone else want to convince me that GLES1 should burn in hell? So I dug around, commit 4c06853833996d990eb76b195ca5d6838c6f3d6b Author: Adam Jackson Date: Wed May 8 18:03:21 2013 -0400 Switch to Mesa master (pre 9.2)

[Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
Cc: Kenneth Graunke --- It looks like this may never have actually worked, at least there is no way it could have for inteface block arrays :) No piglit regressions. src/glsl/ast_to_hir.cpp | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glsl/

Re: [Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-05-27 Thread Ilia Mirkin
Just some trivia: On Wed, May 27, 2015 at 5:49 AM, Kevin Rogovin wrote: > Change references to gl_framebuffer::Width, Height, MaxNumLayers > and Visual::samples to use the _mesa_geometry_ convenience functions Both here and in the subject, I presume you meant _mesa_geometric_* ? > for those pla

Re: [Mesa-dev] [PATCH] tgsi: handle indirect sampler arrays.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 10:38 schrieb Dave Airlie: > This is required for ARB_gpu_shader5 support in softpipe. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxi

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Ilia Mirkin
More trivia: On Wed, May 27, 2015 at 5:49 AM, Kevin Rogovin wrote: > Add helper convenience function that intersects the scissor values > against a passed bounding box. In addition, to avoid replicated code, > make the function _mesa_scissor_bounding_box() use this new function. > > v2: > Split

Re: [Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-05-27 Thread Ilia Mirkin
More trivia: On Wed, May 27, 2015 at 5:49 AM, Kevin Rogovin wrote: > Add convenience helper functions for fetching geometry of gl_framebuffer > that return the geometry of the gl_framebuffer instead of the geometry of > the buffers of the gl_framebuffer when then the gl_framebuffer has no > attac

Re: [Mesa-dev] [PATCH 7/7] docs/GL3.txt: update softpipe arb_gpu_shader5 status.

2015-05-27 Thread Ilia Mirkin
On Wed, May 27, 2015 at 3:46 AM, Dave Airlie wrote: > Signed-off-by: Dave Airlie > --- > docs/GL3.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 8e1c8cd..9fbde36 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3.txt > @@ -99,13 +

Re: [Mesa-dev] [PATCH 1/7] draw/tgsi: implement geom shader invocation support.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 09:45 schrieb Dave Airlie: > From: Dave Airlie > > This is just for softpipe, llvmpipe won't work without > some changes. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/draw/draw_gs.c | 47 > +- > src/gallium/auxiliary/draw/draw

Re: [Mesa-dev] [PATCH 1/7] draw/tgsi: implement geom shader invocation support.

2015-05-27 Thread Ilia Mirkin
On Wed, May 27, 2015 at 7:42 AM, Roland Scheidegger wrote: > Am 27.05.2015 um 09:45 schrieb Dave Airlie: >> From: Dave Airlie >> >> This is just for softpipe, llvmpipe won't work without >> some changes. >> >> Signed-off-by: Dave Airlie >> --- >> src/gallium/auxiliary/draw/draw_gs.c | 47 >>

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-27 Thread Emil Velikov
On 27 May 2015 at 11:23, Dave Airlie wrote: >> Wow, I hadn't expected such a hateful comment on GLES1. >> >> Does anyone else want to convince me that GLES1 should burn in hell? > > So I dug around, > > commit 4c06853833996d990eb76b195ca5d6838c6f3d6b > Author: Adam Jackson > Date: Wed May 8 18:

Re: [Mesa-dev] [PATCH 1/7] draw/tgsi: implement geom shader invocation support.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 13:47 schrieb Ilia Mirkin: > On Wed, May 27, 2015 at 7:42 AM, Roland Scheidegger > wrote: >> Am 27.05.2015 um 09:45 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This is just for softpipe, llvmpipe won't work without >>> some changes. >>> >>> Signed-off-by: Dave Airlie >>>

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-27 Thread Marek Olšák
The cost of shipping GLES1 is 27KB for libGLESv1_CM.so.1.1.0, so I honestly think there shouldn't even be an option to disable it. It's not something I particularly care about though. Marek On Wed, May 27, 2015 at 1:53 PM, Emil Velikov wrote: > On 27 May 2015 at 11:23, Dave Airlie wrote: >>> Wo

Re: [Mesa-dev] [PATCH 02/11] tgsi/scan: get more information about arrays and handle arrays correctly

2015-05-27 Thread Roland Scheidegger
Yes, that looks better to me. It may be a bit inconsistent to only do that for inputs/outputs and not for temp but at least this way there's no additional limit on the number of arrays. Roland Am 26.05.2015 um 13:04 schrieb Marek Olšák: > From: Marek Olšák > > v2: use less memory for the inform

[Mesa-dev] Mesa 10.6.0 release candidate 2

2015-05-27 Thread Emil Velikov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The second release candidate for Mesa 10.6.0 is now available. The release mostly consists of nouveau driver patches, although some freedreno, i965, radeonsi, glapi and build fixes are also present. Alan Coopersmith (1): swrast: Build fix for

Re: [Mesa-dev] [PATCH] clover: log build options when dumping clc source

2015-05-27 Thread Francisco Jerez
EdB writes: > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp > b/src/gallium/state_trackers/clover/llvm/invocation.cpp > index 7d2d941..fc7ab9c 10064

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Rogovin, Kevin
Hi, > 44 instances of a leading + in mesa/main compared to 78 trailing ones. > Huh, I was going to say that it's really uncommon to do this in mesa, but > that may not be supported by fact. Considering there is a formatting issue below, I can change it to trailing. I don’t care. >> + if (

Re: [Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-05-27 Thread Rogovin, Kevin
Hi, >> +static inline GLuint >Here and below, why 2 spaces between "inline" and "GLuint"? I have no clue. I suspect it is a scar from some search/replace fiasco over 3 weeks ago. You are the first person who spotted that nit. >> --- a/src/mesa/main/mtypes.h >> +++ b/src/mesa/main/mtypes.h >>

Re: [Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-05-27 Thread Ilia Mirkin
On Wed, May 27, 2015 at 9:21 AM, Rogovin, Kevin wrote: > Hi, >>> +static inline GLuint >>Here and below, why 2 spaces between "inline" and "GLuint"? > > I have no clue. I suspect it is a scar from some search/replace fiasco over > 3 weeks ago. You are the first person who spotted that nit. > >

Re: [Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-05-27 Thread Rogovin, Kevin
> You should wait until you get a "real" review from someone before reposting. I think that is good advice. Indeed, I am not going to post a v5 of this series until for each patch there is: Two review bys, possibly qualified with "fix the mentioned formatting issues" OR Specific change reques

Re: [Mesa-dev] [PATCH] gallivm: Do not use NoFramePointerElim with LLVM 3.7

2015-05-27 Thread Tom Stellard
On Tue, May 26, 2015 at 10:27:34PM -0700, Vinson Lee wrote: > TargetOptions::NoFramePointerElim was removed in llvm-3.7.0svn r238244 > "Remove NoFramePointerElim and NoFramePointerElimOverride from > TargetOptions and remove ExecutionEngine's dependence on CodeGen. NFC." > Reviewed-by: Tom Stella

Re: [Mesa-dev] [PATCH] nir: Fix output swizzle in get_mul_for_src

2015-05-27 Thread Jason Ekstrand
Upon further consideration and actually seeing the patch, I think using num_components would be better. Calling it writemask isn't really true since it isn't the writemask for the mul. I thought about calling it read_mask but that isn't really true either because it isn't the components of the mu

Re: [Mesa-dev] [PATCH 13/15 v2] mesa: Use the profile instead of an extension bit to validate GL_TEXTURE_CUBE_MAP

2015-05-27 Thread Fredrik Höglund
On Thursday 21 May 2015, Ian Romanick wrote: > From: Ian Romanick > > The extension on which this depends will always be enabled in core > profile, and the extension bit is about to be removed. > > Signed-off-by: Ian Romanick > Cc: "10.6" > Cc: Fredrik Höglund > --- > src/mesa/main/fbobject.

Re: [Mesa-dev] [PATCH 2/2] configure.ac: enable building the EGL DRM platform by default

2015-05-27 Thread Marek Olšák
On Wed, May 27, 2015 at 3:21 AM, Emil Velikov wrote: > Hmm > > ./autogen.sh --with-gallium-drivers=radeonsi --enable-egl --enable-gbm > > seems to work fine here. Although... if I drop the --enable-gbm it > complains "EGL platform drm needs gbm", which is an entirely different > kettle of fish. I

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-27 Thread Matt Turner
On Wed, May 27, 2015 at 4:53 AM, Emil Velikov wrote: > On 27 May 2015 at 11:23, Dave Airlie wrote: >>> Wow, I hadn't expected such a hateful comment on GLES1. >>> >>> Does anyone else want to convince me that GLES1 should burn in hell? >> >> So I dug around, >> >> commit 4c06853833996d990eb76b195

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Kenneth Graunke
On Wednesday, May 27, 2015 01:17:21 PM Rogovin, Kevin wrote: > Hi, > > > 44 instances of a leading + in mesa/main compared to 78 trailing ones. > > Huh, I was going to say that it's really uncommon to do this in mesa, but > > that may not be supported by fact. > > Considering there is a formatti

Re: [Mesa-dev] [PATCH 6/5] i965/vs: Rework the logic for generating NIR from ARB vertex programs

2015-05-27 Thread Matt Turner
On Wed, May 20, 2015 at 12:06 PM, Jason Ekstrand wrote: > Whether or not to use NIR is now equivalent to brw->scalar_vs. We can > simplify the logic and make it far less confusing. > --- I'm fine with removing the old visitor code and the old ARB fp backends. The series is Reviewed-by: Matt Tur

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Matt Turner
On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri wrote: > Cc: Kenneth Graunke > --- > > It looks like this may never have actually worked, at least there > is no way it could have for inteface block arrays :) > > No piglit regressions. > > src/glsl/ast_to_hir.cpp | 22 ++ >

Re: [Mesa-dev] [PATCH 2/5] mesa/es3.1: Enable ES 3.1 API and shading language version

2015-05-27 Thread Tapani
On 05/26/2015 10:37 PM, Ian Romanick wrote: From: Ian Romanick This is a bit of a hack for now. Several of the extensions required for OpenGL ES 3.1 have no support, at all, in Mesa. However, with this patch and a patch to allow MESA_GL_VERSION_OVERRIDE to work with ES contexts, people can be

Re: [Mesa-dev] [PATCH V2 17/22] i965/gen9: Add XY_FAST_COPY_BLT support to intelEmitCopyBlit()

2015-05-27 Thread Ben Widawsky
On Thu, May 21, 2015 at 05:46:48PM -0700, Anuj Phogat wrote: > On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote: SNIP > > As I mentioned above wrt the CL alignment, I think it's safe to do for both > > modes. Something like: > > > > /* Check both are at least cacheline aligned */ > > if (brw

Re: [Mesa-dev] [PATCH 0/5] Remainder of GLES3.1 foundation work

2015-05-27 Thread Tapani
Everything looks good, this will enable us to work on bunch of small corners of gles 3.1 even though some of the extensions are still being baked. I sent small comment to patch #2 which you can feel free to ignore, I've been reading ES spec a lot lately so happened to notice that I'm reading

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Henri Verbeet
On 27 May 2015 at 19:05, Kenneth Graunke wrote: > If you're using vim, this will give you the correct settings for Mesa: > > if has("autocmd") > au BufNewFile,BufRead */mesa/* set expandtab tabstop=8 softtabstop=3 > shiftwidth=3 > endif > setlocal is more appropriate than set for this kind of

[Mesa-dev] [PATCH] i965/fs: Fix lowering of integer multiplication with cmod.

2015-05-27 Thread Matt Turner
If the multiplication's result is unused, except by a conditional_mod, the destination will be null. Since the final instruction in the lowered sequence is a partial-write, we can't put the conditional mod on it and we have to store the full result to a register and do a MOV with a conditional mod.

Re: [Mesa-dev] [PATCH 03/15] egl: combine VersionMajor and VersionMinor into one variable

2015-05-27 Thread Chad Versace
On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 9 - > src/egl/main/egldisplay.h | 3 +-- > 2 files changed, 5 insertions(+), 7 deletions(-) Patches 1-3 are Reviewed-by: Chad Versace I'm looking at the other patches right now. _

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Ian Romanick
On 05/27/2015 04:21 AM, Ilia Mirkin wrote: > More trivia: > > On Wed, May 27, 2015 at 5:49 AM, Kevin Rogovin > wrote: >> Add helper convenience function that intersects the scissor values >> against a passed bounding box. In addition, to avoid replicated code, >> make the function _mesa_scissor_

Re: [Mesa-dev] [PATCH 2/5] mesa/es3.1: Enable ES 3.1 API and shading language version

2015-05-27 Thread Ian Romanick
On 05/27/2015 10:36 AM, Tapani wrote: > On 05/26/2015 10:37 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This is a bit of a hack for now. Several of the extensions required for >> OpenGL ES 3.1 have no support, at all, in Mesa. However, with this >> patch and a patch to allow MESA_GL_VERS

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-27 Thread Chad Versace
On Thu 14 May 2015, Emil Velikov wrote: > Hi Marek, > On 12/05/15 22:54, Marek Olšák wrote: > > From: Marek Olšák > > > > with the extension of keeping: > > #define KHRONOS_APICALL __attribute__((visibility("default"))) > > > > And don't include mesa headers in egl.h. > Can we do this more g

Re: [Mesa-dev] [PATCH 2/5] i965: Make fs/vec4_visitor inherit from ir_visitor directly

2015-05-27 Thread Kenneth Graunke
On Wednesday, May 20, 2015 11:09:03 AM Jason Ekstrand wrote: > This is using multiple inheritance in C++. However, ir_visitor is really > just an interface with no data so it shouldn't be so bad. You might also mention that this is a temporary measure that's going away in a few commits. Series i

Re: [Mesa-dev] [PATCH 3/7] tgsi: add support for geometry shader streams.

2015-05-27 Thread Michael Schellenberger Costa
Hi, Am 27/05/2015 um 09:45 schrieb Dave Airlie: > This adds support to retrieve the primitive counts > for each stream, along with the offset for each > primitive into the output array. > > It also adds support for parsing the stream argument > to the emit and end instructions. > > Signed-off-by

Re: [Mesa-dev] [PATCH 3/7] tgsi: add support for geometry shader streams.

2015-05-27 Thread Michael Schellenberger Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 27.05.2015 um 09:45 schrieb Dave Airlie: > This adds support to retrieve the primitive counts for each stream, > along with the offset for each primitive into the output array. > > It also adds support for parsing the stream argument to the em

Re: [Mesa-dev] [PATCH 09/15] egl: add EGL 1.5 functions that don't need any changes from extensions

2015-05-27 Thread Chad Versace
On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > Declare the functions without the suffix, so that the core names are exported. > --- > src/egl/main/eglapi.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) Patches 5-9 are Reviewed-by: Chad Versace I

Re: [Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

2015-05-27 Thread Chad Versace
On Fri 15 May 2015, Emil Velikov wrote: > On 15/05/15 16:18, Marek Olšák wrote: > > On Fri, May 15, 2015 at 1:23 AM, Emil Velikov > > wrote: > >> On 12/05/15 22:54, Marek Olšák wrote: > >>> From: Marek Olšák > >>> > >>> --- > >>> src/egl/main/eglapi.c | 12 > >>> 1 file changed, 12

Re: [Mesa-dev] [PATCH] i965/fs: Fix lowering of integer multiplication with cmod.

2015-05-27 Thread Kenneth Graunke
On Wednesday, May 27, 2015 10:58:01 AM Matt Turner wrote: > If the multiplication's result is unused, except by a conditional_mod, > the destination will be null. Since the final instruction in the lowered > sequence is a partial-write, we can't put the conditional mod on it and > we have to store

Re: [Mesa-dev] [PATCH V2 07/22] i965/gen9: Set horizontal alignment for the miptree

2015-05-27 Thread Ben Widawsky
On Fri, Apr 17, 2015 at 04:51:28PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 80 > ++ > 1 file changed, 80 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c > b/src/mesa/driver

Re: [Mesa-dev] [PATCH V2 08/22] i965/gen9: Use HALIGN_16 if MCS is enabled

2015-05-27 Thread Ben Widawsky
On Fri, Apr 17, 2015 at 04:51:29PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c > b/src/mesa/drivers/dri/i965/brw_te

Re: [Mesa-dev] [PATCH 11/15] egl: add eglGetSyncAttrib

2015-05-27 Thread Chad Versace
On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 14 +- > src/egl/main/eglapi.h | 2 +- > src/egl/main/eglsync.c | 2 +- > src/egl/main/eglsync.h | 2 +- > 4 files changed, 16 insertions(+), 4 deletions(-) > I see two issues below. >

Re: [Mesa-dev] [PATCH V2 07/22] i965/gen9: Set horizontal alignment for the miptree

2015-05-27 Thread Ben Widawsky
On Wed, May 27, 2015 at 11:56:24AM -0700, Ben Widawsky wrote: > On Fri, Apr 17, 2015 at 04:51:28PM -0700, Anuj Phogat wrote: > > Signed-off-by: Anuj Phogat > > --- > > src/mesa/drivers/dri/i965/brw_tex_layout.c | 80 > > ++ > > 1 file changed, 80 insertions(+) > > >

Re: [Mesa-dev] [PATCH V2 09/22] i965/gen9: Set vertical alignment for the miptree

2015-05-27 Thread Ben Widawsky
On Fri, Apr 17, 2015 at 04:51:30PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 74 > ++ > 1 file changed, 74 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c > b/src/mesa/driver

Re: [Mesa-dev] [PATCH] i965/fs: Properly handle explicit depth in SIMD16 with dual-source blend

2015-05-27 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-27 Thread Chad Versace
On Fri 15 May 2015, Emil Velikov wrote: > On 12/05/15 22:54, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/egl/main/eglapi.c | 38 ++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > > in

[Mesa-dev] [PATCH] i965: Silence warning in 3-src type-setting.

2015-05-27 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index e78d0be..a1d11f3 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dri/i965/brw_eu_em

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
Matt Turner wrote > On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri wrote: > > Cc: Kenneth Graunke > > --- > > > > It looks like this may never have actually worked, at least there > > is no way it could have for inteface block arrays :) > > > > No piglit regressions. > > > > src

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Dave Airlie
On 28 May 2015 at 06:51, Timothy Arceri wrote: > Matt Turner wrote > >> On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri >> wrote: >> > Cc: Kenneth Graunke >> > --- >> > >> > It looks like this may never have actually worked, at least there >> > is no way it could have for inteface bl

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
On Thu, 2015-05-28 at 07:07 +1000, Dave Airlie wrote: > On 28 May 2015 at 06:51, Timothy Arceri wrote: > > Matt Turner wrote > > > >> On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri > >> wrote: > >> > Cc: Kenneth Graunke > >> > --- > >> > > >> > It looks like this may never have actua

Re: [Mesa-dev] [PATCH V2 17/22] i965/gen9: Add XY_FAST_COPY_BLT support to intelEmitCopyBlit()

2015-05-27 Thread Anuj Phogat
On Wed, May 27, 2015 at 10:42 AM, Ben Widawsky wrote: > On Thu, May 21, 2015 at 05:46:48PM -0700, Anuj Phogat wrote: >> On Thu, May 21, 2015 at 12:26 PM, Ben Widawsky wrote: > > SNIP > >> > As I mentioned above wrt the CL alignment, I think it's safe to do for both >> > modes. Something like: >>

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-05-27 Thread Rogovin, Kevin
> Out of curiosity, what editor are you using? Usually setting the > indentation rules in your editor takes care of most of these problems. I am using emacs23 (under Ubuntu) and now for something amusing... > We have a .dir-locals.el file that should provide the correct settings > for Emacs. e

Re: [Mesa-dev] [PATCH V2 07/22] i965/gen9: Set horizontal alignment for the miptree

2015-05-27 Thread Anuj Phogat
On Wed, May 27, 2015 at 11:56 AM, Ben Widawsky wrote: > On Fri, Apr 17, 2015 at 04:51:28PM -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/brw_tex_layout.c | 80 >> ++ >> 1 file changed, 80 insertions(+) >> >> diff --git a/

Re: [Mesa-dev] [PATCH V2 09/22] i965/gen9: Set vertical alignment for the miptree

2015-05-27 Thread Anuj Phogat
On Wed, May 27, 2015 at 12:04 PM, Ben Widawsky wrote: > On Fri, Apr 17, 2015 at 04:51:30PM -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/brw_tex_layout.c | 74 >> ++ >> 1 file changed, 74 insertions(+) >> >> diff --git a/

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-27 Thread Marek Olšák
Hi Chad, I broke up the patches and sent them as a separate patch series a few days ago. [PATCH 1/3] egl: import egl.h from registry (v2) [PATCH 2/3] egl: import eglext.h from registry and cleanup eglmesaext.h (v2) [PATCH 3/3] egl: import platform headers from registry (v2) Marek On Wed, May 2

Re: [Mesa-dev] [PATCH 1/3] egl: import egl.h from registry (v2)

2015-05-27 Thread Chad Versace
On Sat 23 May 2015, Marek Olšák wrote: > From: Marek Olšák > > v2: split the commit into 3 patches Thanks for splitting the patches up. For the series, Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.fr

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-27 Thread Chad Versace
On Thu 28 May 2015, Marek Olšák wrote: > Hi Chad, > > I broke up the patches and sent them as a separate patch series a few days > ago. > > [PATCH 1/3] egl: import egl.h from registry (v2) > [PATCH 2/3] egl: import eglext.h from registry and cleanup eglmesaext.h (v2) > [PATCH 3/3] egl: import pl

Re: [Mesa-dev] [PATCH 7/7] docs/GL3.txt: update softpipe arb_gpu_shader5 status.

2015-05-27 Thread Dave Airlie
On 27 May 2015 at 21:23, Ilia Mirkin wrote: > On Wed, May 27, 2015 at 3:46 AM, Dave Airlie wrote: >> Signed-off-by: Dave Airlie >> --- >> docs/GL3.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/docs/GL3.txt b/docs/GL3.txt >> index 8e1c8cd..9fbde36 100644 >

Re: [Mesa-dev] [PATCH 4/7] softpipe: add support for indexed queries.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 09:45 schrieb Dave Airlie: > We need indexed queries to retrieve the geom shader info. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/softpipe/sp_context.h | 2 +- > src/gallium/drivers/softpipe/sp_prim_vbuf.c | 4 ++-- > src/gallium/drivers/softpipe/sp_query.c

Re: [Mesa-dev] [PATCH 5/7] draw: add support to tgsi paths for geometry streams.

2015-05-27 Thread Roland Scheidegger
Am 27.05.2015 um 09:45 schrieb Dave Airlie: > This hooks up the geometry shader processing to the TGSI > support added in the previous commits. > > It doesn't change the llvm interface other than to > keep things building. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/draw/draw_g

[Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-27 Thread Ben Widawsky
AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail because we hit the is_immediate && !is_compactable_immediate case. However, with sing

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-27 Thread Ben Widawsky
I forgot to mention that the predecessor to this patch fixed around 70 BSW failures on Jenkins. Note that our current Jenkins baseline for BSW is probably not fully baked atm. On Wed, May 27, 2015 at 10:16:04PM -0700, Ben Widawsky wrote: > AFAICT, there is no real way to make sure a send message w

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-27 Thread Tapani
On 05/27/2015 02:30 AM, Francisco Jerez wrote: Ian Romanick writes: On 05/26/2015 02:04 PM, Francisco Jerez wrote: Ian Romanick writes: On 05/26/2015 02:53 AM, Tapani Pälli wrote: Hello; I'd like to ping if this approach would be ok. We've had some discussions with Curro about it and ove

Re: [Mesa-dev] [PATCH] i965: Silence warning in 3-src type-setting.

2015-05-27 Thread Pohjolainen, Topi
On Wed, May 27, 2015 at 12:24:47PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Topi Pohjolainen > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c > b/src/mesa/drivers/dri/i965/brw_eu_emit.c > index e78