Re: [Mesa-dev] [PATCH v2 14/20] i965/cs: Add max_cs_threads

2015-04-27 Thread Jeff McGee
On Sat, Apr 25, 2015 at 09:06:53PM -0700, Ben Widawsky wrote: > On Sat, Apr 25, 2015 at 05:39:20PM -0700, Jordan Justen wrote: > > On 2015-04-25 13:54:41, Ben Widawsky wrote: > > > On Fri, Apr 24, 2015 at 04:33:06PM -0700, Jordan Justen wrote: > > > > Add some values for gen7 & gen8. These are the

[Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Rob Clark
From: Rob Clark I need something like this in a couple places. And didn't see anything like it anywhere. Signed-off-by: Rob Clark --- src/glsl/nir/nir.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 98b0ec3..3a96d56 100644 --- a/src

Re: [Mesa-dev] [PATCH v2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Rob Clark
On Mon, Apr 27, 2015 at 2:11 PM, Ilia Mirkin wrote: > In some situations it is convenient for a driver to expose a higher GLSL > version while some extensions are still incomplete. However in that > situation, it would report a GLSL version that was higher than the GL > version. Avoid that situati

Re: [Mesa-dev] [PATCH v2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
On Mon, Apr 27, 2015 at 3:10 PM, Rob Clark wrote: > On Mon, Apr 27, 2015 at 2:11 PM, Ilia Mirkin wrote: >> In some situations it is convenient for a driver to expose a higher GLSL >> version while some extensions are still incomplete. However in that >> situation, it would report a GLSL version t

Re: [Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Rob Clark
yeah, I'll probably end up pushing it together w/ freedreno/ir3 patches using it.. but that is a good point about garbage collecting existing open-coded versions of this.. I guess I should do that anyways. BR, -R On Mon, Apr 27, 2015 at 3:11 PM, Connor Abbott wrote: > When you push this, can y

Re: [Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Connor Abbott
When you push this, can you make sure there are users for it so it isn't just dead code? Either in your driver, or there are probably several places in core NIR where we currently open-code this. Otherwise, Reviewed-by: Connor Abbott On Mon, Apr 27, 2015 at 3:05 PM, Rob Clark wrote: > From: Rob

Re: [Mesa-dev] [PATCH] softpipe: fix another stencil-as-float issue

2015-04-27 Thread Dave Airlie
On 26 April 2015 at 06:17, wrote: > From: Roland Scheidegger Oh indeed, thanks, Reviewed-by: Dave Airlie > > Hopefully this is the last one now (for texture X32_S8X24_UINT views). > +4 piglits. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90167 > --- > src/gallium/auxiliary/ut

Re: [Mesa-dev] [PATCH] scons : Support LLVM 3.5 and 3.6 on windows.

2015-04-27 Thread Jose Fonseca
On 27/04/15 15:48, Olivier PENA wrote: Hi Jose, It seems the minimum version is 3.3 (var required_llvm_version). LLVM 3.3 already provided llvm-config.h. So, that should be enough ? Oh, I hadn't noticed that. It looks great then. In fact, now that llvm_config.h is guaranteed to exist, I wond

Re: [Mesa-dev] [RFC 6/9] nir: Add an entirely C-based linked list implementation

2015-04-27 Thread Jason Ekstrand
On Mon, Apr 27, 2015 at 11:12 AM, Connor Abbott wrote: > On Mon, Apr 27, 2015 at 1:36 PM, Eric Anholt wrote: >> Jason Ekstrand writes: >> >>> This commit adds a C-based linked list implementation for NIR. Unlike >>> exec_list in glsl/list.h, there is no C++ API. Also, this list is based on >>>

Re: [Mesa-dev] [PATCH v2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Brian Paul
On 04/27/2015 12:11 PM, Ilia Mirkin wrote: In some situations it is convenient for a driver to expose a higher GLSL version while some extensions are still incomplete. However in that situation, it would report a GLSL version that was higher than the GL version. Avoid that situation by limiting t

Re: [Mesa-dev] [PATCH v2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
On Mon, Apr 27, 2015 at 3:53 PM, Brian Paul wrote: > On 04/27/2015 12:11 PM, Ilia Mirkin wrote: >> >> In some situations it is convenient for a driver to expose a higher GLSL >> version while some extensions are still incomplete. However in that >> situation, it would report a GLSL version that wa

Re: [Mesa-dev] [RFC 7/9] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-27 Thread Connor Abbott
On Fri, Apr 24, 2015 at 7:32 PM, Jason Ekstrand wrote: > This commit switches us from the current setup of using hash sets for > use/def sets to using linked lists. Doing so should save us quite a bit of > memory because we aren't carrying around 3 hash sets per register and 2 per > SSA value. I

Re: [Mesa-dev] [PATCH 1/2] r600g, radeonsi: add driver queries for GPU temperature and shader+memory clocks

2015-04-27 Thread Aaron Watry
On Mon, Apr 27, 2015 at 9:46 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 13 +++-- > src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ > src/gallium/drivers/radeon/r600_query.c | 21 > +

Re: [Mesa-dev] [PATCH 1/2] r600g, radeonsi: add driver queries for GPU temperature and shader+memory clocks

2015-04-27 Thread Marek Olšák
DRM 3.0.0 (amdgpu) doesn't support all of these queries yet. I think it could only do the GPU load query if it was hooked up. Radeon will always be 2.x.x. Marek On Mon, Apr 27, 2015 at 10:53 PM, Aaron Watry wrote: > > > On Mon, Apr 27, 2015 at 9:46 AM, Marek Olšák wrote: >> >> From: Marek Olšá

Re: [Mesa-dev] [RFC 7/9] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-27 Thread Jason Ekstrand
On Mon, Apr 27, 2015 at 1:35 PM, Connor Abbott wrote: > On Fri, Apr 24, 2015 at 7:32 PM, Jason Ekstrand wrote: >> +struct nir_if; >> + >> typedef struct nir_src { >> union { >> + nir_instr *parent_instr; >> + struct nir_if *parent_if; >> + }; > > There's something I'm not quite u

[Mesa-dev] [PATCH] glsl: fix packing support for arrays of doubles

2015-04-27 Thread Timothy Arceri
Broke in commit f00c5f85b82efe9535b18dbf97c4591fb28aeae6 when adding support for multidimensional arrays --- src/glsl/lower_packed_varyings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/lower_packed_varyings.cpp b/src/glsl/lower_packed_varyings.cpp index f8e

Re: [Mesa-dev] [RFC 7/9] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-27 Thread Connor Abbott
On Mon, Apr 27, 2015 at 5:25 PM, Jason Ekstrand wrote: > On Mon, Apr 27, 2015 at 1:35 PM, Connor Abbott wrote: >> On Fri, Apr 24, 2015 at 7:32 PM, Jason Ekstrand wrote: >>> +struct nir_if; >>> + >>> typedef struct nir_src { >>> union { >>> + nir_instr *parent_instr; >>> + struct n

Re: [Mesa-dev] [PATCH] glsl: fix packing support for arrays of doubles

2015-04-27 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin (for the little that's worth... I didn't spot this in the original commit. Oh well.) On Mon, Apr 27, 2015 at 5:35 PM, Timothy Arceri wrote: > Broke in commit f00c5f85b82efe9535b18dbf97c4591fb28aeae6 when > adding support for multidimensional arrays > --- > src/glsl/low

[Mesa-dev] [PATCH] i965: Unhardcode a few more stage names and abbreviations.

2015-04-27 Thread Kenneth Graunke
The stage_abbrev and stage_name fields in backend_visitor provide what we need without any additional effort. It also means we'll get the right names for compute shaders, SIMD8 geometry shaders, and both kinds of tessellation shaders. This does unfortunately change the capitalization of the stage

Re: [Mesa-dev] [PATCH] i965: Unhardcode a few more stage names and abbreviations.

2015-04-27 Thread Matt Turner
On Mon, Apr 27, 2015 at 2:57 PM, Kenneth Graunke wrote: > The stage_abbrev and stage_name fields in backend_visitor provide what > we need without any additional effort. It also means we'll get the > right names for compute shaders, SIMD8 geometry shaders, and both kinds > of tessellation shaders

Re: [Mesa-dev] [PATCH] i965: Unhardcode a few more stage names and abbreviations.

2015-04-27 Thread Anuj Phogat
On Mon, Apr 27, 2015 at 2:57 PM, Kenneth Graunke wrote: > The stage_abbrev and stage_name fields in backend_visitor provide what > we need without any additional effort. It also means we'll get the > right names for compute shaders, SIMD8 geometry shaders, and both kinds > of tessellation shaders

Re: [Mesa-dev] [PATCH v2 10/20] i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:33:02 PM Jordan Justen wrote: > v2: > * Don't rely on brw_eu* to generate the send instruction. We now >generate the send here, and drop the "i965/cs: Add support for the >SEND message that terminates a CS thread" brw_eu* patch. > > Signed-off-by: Jordan Juste

Re: [Mesa-dev] [PATCH v2 13/20] i965/fs: Support compute programs in fs_visitor

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:33:05 PM Jordan Justen wrote: > v2: > * Clean out some unneeded code copied from run_fs (krh) > * Always use NIR > * Split shader time out into a separate commit > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 + > src/me

Re: [Mesa-dev] [PATCH 01/38] main: Add utility function _mesa_lookup_framebuffer_err.

2015-04-27 Thread Anuj Phogat
On Tue, Mar 3, 2015 at 5:31 PM, Laura Ekstrand wrote: > --- > src/mesa/main/fbobject.c | 18 ++ > src/mesa/main/fbobject.h | 4 > 2 files changed, 22 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index f8d0d92..8c2eb25 100644 > --- a/sr

[Mesa-dev] [PATCH 1/3] mesa: remove unused options var in compile_shader()

2015-04-27 Thread Brian Paul
--- src/mesa/main/shaderapi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index cc001ba..a04b287 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -861,14 +861,11 @@ static void compile_shader(struct gl_contex

[Mesa-dev] [PATCH 3/3] meta: remove unneeded #include colortab.h

2015-04-27 Thread Brian Paul
--- src/mesa/drivers/common/meta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index cf99d95..d2ab7b8 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/meta.c @@ -41,7 +41,6 @@ #include "main/bufferobj.

[Mesa-dev] [PATCH 2/3] mesa: remove unneeded #include colortab.h

2015-04-27 Thread Brian Paul
--- src/mesa/main/texobj.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index e018ab9..c563f1e 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -30,7 +30,6 @@ #include #include "bufferobj.h" -#include "colortab.h" #incl

Re: [Mesa-dev] [PATCH v2 15/20] i965/cs: Emit compute shader code and upload programs

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:33:07 PM Jordan Justen wrote: > v2: > * Don't bother checking for 'gen > 5' (krh) > * Populate sampler data in key (krh) > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_context.h | 1 + > src/mesa/drivers/dri/i965/brw_cs.cpp |

Re: [Mesa-dev] [PATCH 03/18] winsys/amdgpu: add a new winsys for the new kernel driver

2015-04-27 Thread Marek Olšák
On Tue, Apr 21, 2015 at 5:12 PM, Emil Velikov wrote: > Hi Marek, > > Must admit that the current "split"/location of the new winsys looks a > bit strange. I'm thinking that if one places the new winsys alongside > the radeon one (i.e. winsys/amdgpu/drm) things should still work and > thus we'll re

Re: [Mesa-dev] [PATCH v2 00/20] i965 basic CS program generation support

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:32:52 PM Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa i965-cs-prog-v2 > > These patches could use review: > * [08/20] i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE > * [10/20] i965/cs: Add generator support for CS_OPCODE_CS_TERMI

Re: [Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:02:18 PM Rogovin, Kevin wrote: > > > Actually I realized that you add quite a bit of support to gen4-6 logic > > that > > _isn't_ used for gen7 and higher. In the last patch of the series you claim > > to enable this only for gen7 and higher - I'm confused. > > The

[Mesa-dev] Regarding X.Org Endless Vacation of Code

2015-04-27 Thread Anish Kanchan
Hello, I am a final year Computer Engineering student from Sardar Patel Institute of Technology. I have a good understanding of C and I have worked on projects using C as a part of my coursework. I am interested in working on the "Improved application of GLSL complier optimizations" project idea f

Re: [Mesa-dev] Regarding X.Org Endless Vacation of Code

2015-04-27 Thread Matt Turner
On Mon, Apr 27, 2015 at 3:58 PM, Anish Kanchan wrote: > Hello, > > I am a final year Computer Engineering student from Sardar Patel Institute > of Technology. I have a good understanding of C and I have worked on > projects using C as a part of my coursework. I am interested in working on > the "I

Re: [Mesa-dev] [PATCH v2 00/20] i965 basic CS program generation support

2015-04-27 Thread Kenneth Graunke
On Monday, April 27, 2015 05:44:48 PM Kenneth Graunke wrote: > On Friday, April 24, 2015 04:32:52 PM Jordan Justen wrote: > > git://people.freedesktop.org/~jljusten/mesa i965-cs-prog-v2 > > > > These patches could use review: > > * [08/20] i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMI

Re: [Mesa-dev] [PATCH 6/7] i965/cs: Implement brw_emit_gpgpu_walker

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:33:43 PM Jordan Justen wrote: > Tested on Ivybridge, Haswell and Broadwell. > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_compute.c | 39 > - > src/mesa/drivers/dri/i965/brw_defines.h | 1 + > 2 files changed

Re: [Mesa-dev] [PATCH] i965: Upload atomic buffer state for compute shaders

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 04:35:46 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > git://people.freedesktop.org/~jljusten/mesa i965-cs-atomic-counters-v1 > > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > src/mesa/drivers/dri/i965/brw_state.h| 1 + > src/

Re: [Mesa-dev] [PATCH v2 02/11] glsl: Add builtin barrier() function

2015-04-27 Thread Kenneth Graunke
On Saturday, April 25, 2015 09:45:51 PM Jordan Justen wrote: > From: Chris Forbes > > [jordan.l.jus...@intel.com: Add CS support] > Signed-off-by: Jordan Justen > Reviewed-by: Ben Widawsky > --- > src/glsl/builtin_functions.cpp | 29 + > 1 file changed, 29 insertion

Re: [Mesa-dev] [PATCH 01/18] winsys/radeon: move radeon_winsys.h up one directory

2015-04-27 Thread Michel Dänzer
On 28.04.2015 03:57, Marek Olšák wrote: > Can you elaborate on what amdgpu/sw would be good for? Frankly I don't > see a point, therefore we don't need the "drm" subdirectory. I think Emil's main point (which I agree with) is that radeon_winsys.h should live somewhere under src/gallium/drivers/, p

Re: [Mesa-dev] [PATCH v2 00/11] Initial glsl + i965 barrier support

2015-04-27 Thread Kenneth Graunke
On Saturday, April 25, 2015 09:45:49 PM Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa i965-barrier-v2 > > This series had a fair amount of comments & r-b from v1. Patches 9 & > 10 probably would be the most import to look at. > > Chris Forbes (2): > glsl: Add ir node for ba

Re: [Mesa-dev] [PATCH 6/7] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-04-27 Thread Kenneth Graunke
On Friday, April 24, 2015 08:21:36 PM Rogovin, Kevin wrote: > > > Checking brw->ctx.Shader._CurrentFragmentProgram != NULL is unnecessary. > > There is always a valid pixel shader. (If the application is using > > fixed-function, we supply a fragment shader for them.) Please drop that > > chec

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 Bug ID: 90207 Summary: [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff) Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #1 from Dieter Nützel --- Created attachment 115389 --> https://bugs.freedesktop.org/attachment.cgi?id=115389&action=edit konqueror-20150428-051127.kcrash.txt -- You are receiving this mail because: You are on the CC list for the

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 Dieter Nützel changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #2 from Tapani Pälli --- seems to work with chrome and firefox, will attempt to reproduce with konqueror -- You are receiving this mail because: You are on the CC list for the bug. ___ mes

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #3 from Tapani Pälli --- My konqueror does not seems to support webgl (?) is there something special I need to do to enable it? -- You are receiving this mail because: You are on the CC list for the bug.

[Mesa-dev] [PATCH 12/13] SQUASH: nir: Add a helper for moving a source and use it in texture lowering

2015-04-27 Thread Jason Ekstrand
One of the side-effects of using a linked list for use/def sets is that you can no longer simply copy them around. There were a couple of places in the texture lowering passes that realloced or used memmove on lists of sources. Instead, this commit adds a helper for moving a source and uses it fo

[Mesa-dev] [PATCH 06/13] gallium/double_list: s/INLINE/inline and remove the p_compiler include

2015-04-27 Thread Jason Ekstrand
--- src/gallium/auxiliary/util/u_double_list.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/u_double_list.h b/src/gallium/auxiliary/util/u_double_list.h index 247f0f2..e808333 100644 --- a/src/gallium/auxiliary/util/u_double_list.h +

[Mesa-dev] [PATCH 04/13] nir: Add a function for rewriting the condition of an if statement

2015-04-27 Thread Jason Ekstrand
--- src/glsl/nir/nir.c | 22 ++ src/glsl/nir/nir.h | 1 + 2 files changed, 23 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 4cc074b..b8f5dd4 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1895,6 +1895,28 @@ nir_instr_rewrite_src(nir_in

[Mesa-dev] [PATCH 13/13] SQUASH: nir: Update various components for the new list-based use/def sets

2015-04-27 Thread Jason Ekstrand
--- src/glsl/nir/nir_from_ssa.c | 11 +-- src/glsl/nir/nir_lower_locals_to_regs.c | 14 ++ src/glsl/nir/nir_lower_to_source_mods.c | 20 src/glsl/nir/nir_lower_vars_to_ssa.c| 3 ++- src/glsl/nir/nir_opt_gcm.c | 14 ++---

[Mesa-dev] [PATCH 07/13] util: Move gallium's linked list to util

2015-04-27 Thread Jason Ekstrand
The linked list in gallium is pretty much the kernel list and we would like to have a C-based linked list for all of mesa. Let's not duplicate and just steal the gallium one. --- src/gallium/auxiliary/Makefile.sources | 1 - src/gallium/auxiliary/hud/hud_private.h| 2 +

[Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn

2015-04-27 Thread Jason Ekstrand
--- src/glsl/nir/nir_validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..35a853d 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -236,6 +236,8 @@ validate_ssa_def(nir_ssa_def *def, v

[Mesa-dev] [PATCH 02/13] nir: Modernize the out-of-SSA pass

2015-04-27 Thread Jason Ekstrand
The out-of-SSA pass was one of the first passes written when getting SSA up-and-going (for obvious reasons). As such, it came before a lot of the nifty SSA-based helpers were introduced. This commit modernizes it so that we're no longer doing nearly as much manual banging on use/def sets. --- sr

[Mesa-dev] [PATCH 08/13] util/list: Add C99-based iterator macros

2015-04-27 Thread Jason Ekstrand
--- src/util/list.h | 33 + 1 file changed, 33 insertions(+) diff --git a/src/util/list.h b/src/util/list.h index 9dcf671..6144b0c 100644 --- a/src/util/list.h +++ b/src/util/list.h @@ -141,6 +141,39 @@ static inline void list_delinit(struct list_head *item) #defi

[Mesa-dev] [PATCH 09/13] util/list: Add list_empty and list_length functions

2015-04-27 Thread Jason Ekstrand
--- src/util/list.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/util/list.h b/src/util/list.h index 6144b0c..246f826 100644 --- a/src/util/list.h +++ b/src/util/list.h @@ -92,6 +92,19 @@ static inline void list_delinit(struct list_head *item) item->prev = item; }

[Mesa-dev] [PATCH 10/13] util/list: Add a list validation function

2015-04-27 Thread Jason Ekstrand
--- src/util/list.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/util/list.h b/src/util/list.h index 246f826..f11b858 100644 --- a/src/util/list.h +++ b/src/util/list.h @@ -105,6 +105,13 @@ static inline unsigned list_length(struct list_head *list) return length; } +static

[Mesa-dev] [PATCH 03/13] nir: Add and use initializer #defines for nir_src and nir_dest

2015-04-27 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 2 +- src/glsl/nir/nir.h | 13 +++-- src/glsl/nir/nir_builder.h | 6 ++ src/glsl/nir/nir_lower_samplers.cpp| 5 ++--- src/glsl/nir/nir_lower_tex_projector.c | 5 ++--- src/glsl/nir/nir_search.c

[Mesa-dev] [PATCH 11/13] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-27 Thread Jason Ekstrand
This commit switches us from the current setup of using hash sets for use/def sets to using linked lists. Doing so should save us quite a bit of memory because we aren't carrying around 3 hash sets per register and 2 per SSA value. It should also save us CPU time because adding/removing things fr

[Mesa-dev] [PATCH 05/13] nir: Use nir_instr_rewrite_src in copy propagation

2015-04-27 Thread Jason Ekstrand
We were rolling our own rewrite_src variant in copy-propagation. Let's stop doing that and use the ones in core NIR. --- src/glsl/nir/nir_opt_copy_propagate.c | 71 +-- 1 file changed, 10 insertions(+), 61 deletions(-) diff --git a/src/glsl/nir/nir_opt_copy_propag

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #4 from Dieter Nützel --- (In reply to Tapani Pälli from comment #3) > My konqueror does not seems to support webgl (?) is there something special > I need to do to enable it? Hello Tapani! My Konqueror 4.14.6 and former versions (o

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #5 from Dieter Nützel --- (In reply to Dieter Nützel from comment #4) > (In reply to Tapani Pälli from comment #3) > > My konqueror does not seems to support webgl (?) is there something special > > I need to do to enable it? > > Hel

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #6 from Dieter Nützel --- (In reply to Dieter Nützel from comment #5) > (In reply to Dieter Nützel from comment #4) > > (In reply to Tapani Pälli from comment #3) > > > My konqueror does not seems to support webgl (?) is there somethi

[Mesa-dev] [Bug 90207] [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90207 --- Comment #7 from Tapani Pälli --- (In reply to Dieter Nützel from comment #6) > (In reply to Dieter Nützel from comment #5) > > (In reply to Dieter Nützel from comment #4) > > > (In reply to Tapani Pälli from comment #3) > > > > My konqueror d

[Mesa-dev] [PATCH] freedreno/ir3: fix immediate usage in tgsi tex fe

2015-04-27 Thread Ilia Mirkin
get_immediate will return a const reference, the requested immediate isn't necessarily in the x slot. Make sure to use the swizzle. Signed-off-by: Ilia Mirkin --- I know you're behind the "death to TGSI frontend" banner, but while it's around, should probably fix it up... src/gallium/drivers/f

Re: [Mesa-dev] [PATCH 01/18] winsys/radeon: move radeon_winsys.h up one directory

2015-04-27 Thread Emil Velikov
On 28 April 2015 at 03:30, Michel Dänzer wrote: > On 28.04.2015 03:57, Marek Olšák wrote: >> Can you elaborate on what amdgpu/sw would be good for? Frankly I don't >> see a point, therefore we don't need the "drm" subdirectory. > > I think Emil's main point (which I agree with) is that radeon_wins

Re: [Mesa-dev] [PATCH 01/18] winsys/radeon: move radeon_winsys.h up one directory

2015-04-27 Thread Chia-I Wu
On Tue, Apr 28, 2015 at 2:19 PM, Emil Velikov wrote: > On 28 April 2015 at 03:30, Michel Dänzer wrote: >> On 28.04.2015 03:57, Marek Olšák wrote: >>> Can you elaborate on what amdgpu/sw would be good for? Frankly I don't >>> see a point, therefore we don't need the "drm" subdirectory. >> >> I thi

Re: [Mesa-dev] [PATCH] glsl: properly setting var->data.binding if explicit_binding is true

2015-04-27 Thread Timothy Arceri
On Sun, 2015-04-26 at 15:23 +0200, Alejandro Piñeiro wrote: On 26/04/15 00:08, Timothy Arceri wrote: > > On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: > >> There was a typo on commit c0cd5b, doing it when explicit_binding > >> was false. This prevented to use any binding point differe

Re: [Mesa-dev] [PATCH 6/7] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-04-27 Thread Pohjolainen, Topi
On Fri, Apr 24, 2015 at 07:45:29PM +0300, Rogovin, Kevin wrote: > > > > I'll check with Jordan and others. I have a faint recollection that compute > > shaders have similar > > needs. I think your change is fine though, I just want to understand the > > bigger picture first. > > I do not thi

Re: [Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

2015-04-27 Thread Pohjolainen, Topi
On Fri, Apr 24, 2015 at 11:36:27PM +0300, Rogovin, Kevin wrote: > I want to add one more comment on why to replace with the _mesa_geometry_ > functions, which I had thought was so obvious I neglected to mention it: > > With this series the meaning of gl_framebuffer::Width, Height, and so on have

Re: [Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

2015-04-27 Thread Rogovin, Kevin
Why make it two separate patches even? Seems silly (not to mention more work really). I guess the issue is the commit message portion saying "for framebuffer_no_attachements".. perhaps I just change the commit to "use new geometry function to indicate want geometry not buffer thingies". -Kevin

Re: [Mesa-dev] [PATCH] glsl: properly setting var->data.binding if explicit_binding is true

2015-04-27 Thread Timothy Arceri
Timothy Arceri wrote > On Sun, 2015-04-26 at 15:23 +0200, Alejandro Piñeiro wrote: > On 26/04/15 00:08, Timothy Arceri wrote: > > > On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: > > >> There was a typo on commit c0cd5b, doing it when explicit_binding > > >> was false. This

Re: [Mesa-dev] GLSL versions that don't match GL versions

2015-04-27 Thread Marek Olšák
It sounds good. Marek On Mon, Apr 27, 2015 at 2:58 AM, Ilia Mirkin wrote: > Hello, > > Right now a driver has to be very careful about the GLSL version it > exposes, since it's computed separately from the GL version. The > main/version.c:compute_version code uses the consts->GLSLVersion as an >

Re: [Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-27 Thread Francisco Jerez
Marek Olšák writes: > On Tue, Apr 21, 2015 at 3:50 PM, Francisco Jerez > wrote: >> Marek Olšák writes: >> >>> From: Marek Olšák >>> >> Hi Marek, looks mostly OK to me, a few nits inline, >> >>> --- >>> src/gallium/include/state_tracker/opencl_interop.h | 42 ++ >>> src/gallium/st

[Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
Some required extension might be missing, and we may expose a GLSL version that does not match up with the GL version. Fix that up when computing the GL version. Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a

[Mesa-dev] [PATCH 2/2] st/mesa: allow glsl version up to 410, enable ARB_shader_precision

2015-04-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 25932dd..82e4a30 100644 --- a/src/mesa/state_tracker/st_extensions

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Brian Paul
On 04/27/2015 07:23 AM, Ilia Mirkin wrote: Some required extension might be missing, and we may expose a GLSL version that does not match up with the GL version. Fix that up when computing the GL version. Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 11 ++- 1 file changed

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
On Mon, Apr 27, 2015 at 9:38 AM, Brian Paul wrote: > On 04/27/2015 07:23 AM, Ilia Mirkin wrote: >> >> Some required extension might be missing, and we may expose a GLSL >> version that does not match up with the GL version. Fix that up when >> computing the GL version. >> >> Signed-off-by: Ilia Mi

Re: [Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-27 Thread Marek Olšák
Alright. I suppose it's okay to use bool, but hypothetically a gallium driver could have an OpenCL stack that isn't clover and the interop interface should work with it too. Marek On Mon, Apr 27, 2015 at 2:46 PM, Francisco Jerez wrote: > Marek Olšák writes: > >> On Tue, Apr 21, 2015 at 3:50 PM,

[Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-27 Thread Marek Olšák
From: Marek Olšák v2: - move interop.cpp to clover/api - change intptr_t to void* in the interface - add a virtual function fence() to simplify some code v3: - use bool in the interface --- src/gallium/include/state_tracker/opencl_interop.h | 40 +++ src/gallium/state_tracke

Re: [Mesa-dev] [RFC PATCH 03/12] glsl: support packing of arrays of arrays

2015-04-27 Thread Ilia Mirkin
I know I gave a R-b on this, but I only noticed this when you pushed it out: On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote: > --- > src/glsl/lower_packed_varyings.cpp | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/glsl/lower_packed_varyings.cpp >

Re: [Mesa-dev] [PATCH 1/2] util/macros: Move DIV_ROUND_UP to util/macros.h

2015-04-27 Thread Brian Paul
On 04/26/2015 03:23 PM, Axel Davy wrote: Move DIV_ROUND_UP to a shared location accessible everywhere Signed-off-by: Axel Davy --- I want to use DIV_ROUND_UP in a galliumm nine patch src/gallium/auxiliary/util/u_math.h | 1 - src/gallium/drivers/svga/include/svga3d_surfaced

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Brian Paul
On 04/27/2015 07:39 AM, Ilia Mirkin wrote: On Mon, Apr 27, 2015 at 9:38 AM, Brian Paul wrote: On 04/27/2015 07:23 AM, Ilia Mirkin wrote: Some required extension might be missing, and we may expose a GLSL version that does not match up with the GL version. Fix that up when computing the GL ver

Re: [Mesa-dev] [PATCH] softpipe: fix another stencil-as-float issue

2015-04-27 Thread Brian Paul
On 04/25/2015 02:17 PM, srol...@vmware.com wrote: From: Roland Scheidegger Hopefully this is the last one now (for texture X32_S8X24_UINT views). +4 piglits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90167 --- src/gallium/auxiliary/util/u_tile.c | 4 ++-- 1 file changed, 2 inse

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
On Mon, Apr 27, 2015 at 9:58 AM, Brian Paul wrote: > On 04/27/2015 07:39 AM, Ilia Mirkin wrote: >> >> On Mon, Apr 27, 2015 at 9:38 AM, Brian Paul wrote: >>> >>> On 04/27/2015 07:23 AM, Ilia Mirkin wrote: Some required extension might be missing, and we may expose a GLSL versio

[Mesa-dev] [PATCH] scons : Support LLVM 3.5 and 3.6 on windows.

2015-04-27 Thread olivier . pena . 80
From: Olivier Pena llvm/Config/llvm-config.h is parsed instead of llvm/Config/config.h for detecting LLVM version (http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/073707.html) --- scons/llvm.py | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff

Re: [Mesa-dev] [PATCH] mesa: the function name appears to have a gl prefix already

2015-04-27 Thread Brian Paul
On 04/24/2015 05:36 PM, Ilia Mirkin wrote: Currently we're producing errors like User error: GL_INVALID_OPERATION in glglDeleteProgramsARB(invalid call) And noop_warn appears to be called with the full function name. Don't prepend a gl prefix. Signed-off-by: Ilia Mirkin --- src/mesa/main/co

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Brian Paul
On 04/27/2015 08:05 AM, Ilia Mirkin wrote: On Mon, Apr 27, 2015 at 9:58 AM, Brian Paul wrote: On 04/27/2015 07:39 AM, Ilia Mirkin wrote: On Mon, Apr 27, 2015 at 9:38 AM, Brian Paul wrote: On 04/27/2015 07:23 AM, Ilia Mirkin wrote: Some required extension might be missing, and we may exp

Re: [Mesa-dev] [PATCH] scons: add target osmesa using gallium state tracker.

2015-04-27 Thread Jose Fonseca
Pushed. Thanks. Jose On 22/04/15 16:36, olivier.pena...@gmail.com wrote: From: Olivier Pena --- src/gallium/SConscript| 5 src/gallium/state_trackers/osmesa/Makefile.am | 2 ++ src/gallium/state_trackers/osmesa/SConscript | 26 src/gallium

Re: [Mesa-dev] [PATCH] scons : Support LLVM 3.5 and 3.6 on windows.

2015-04-27 Thread Jose Fonseca
On 27/04/15 11:23, olivier.pena...@gmail.com wrote: From: Olivier Pena llvm/Config/llvm-config.h is parsed instead of llvm/Config/config.h for detecting LLVM version (http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/073707.html) --- scons/llvm.py | 33 ++---

Re: [Mesa-dev] [PATCH 1/2] mesa: fix up GLSL version when computing GL version

2015-04-27 Thread Ilia Mirkin
On Mon, Apr 27, 2015 at 10:22 AM, Brian Paul wrote: > On 04/27/2015 08:05 AM, Ilia Mirkin wrote: >> >> On Mon, Apr 27, 2015 at 9:58 AM, Brian Paul wrote: >>> >>> On 04/27/2015 07:39 AM, Ilia Mirkin wrote: On Mon, Apr 27, 2015 at 9:38 AM, Brian Paul wrote: > > > On 04/2

[Mesa-dev] [PATCH 1/2] r600g, radeonsi: add driver queries for GPU temperature and shader+memory clocks

2015-04-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 13 +++-- src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_query.c | 21 + src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 19 +++

[Mesa-dev] [PATCH 2/2] r600g, radeonsi: add a driver query returning GPU load

2015-04-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.am| 4 +- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/r600_gpu_load.c| 141 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 7 +- src/gallium/dri

Re: [Mesa-dev] [PATCH] scons : Support LLVM 3.5 and 3.6 on windows.

2015-04-27 Thread Olivier PENA
Hi Jose, It seems the minimum version is 3.3 (var required_llvm_version). LLVM 3.3 already provided llvm-config.h. So, that should be enough ? I compiled and ran osmesa and libgl-gdi successfully with llvm 3.4.2, 3.5.0 and 3.6.0 (msvc 2013 32 bits) with this patch. It seems there is some change

Re: [Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-27 Thread Francisco Jerez
Marek Olšák writes: > From: Marek Olšák > > v2: - move interop.cpp to clover/api > - change intptr_t to void* in the interface > - add a virtual function fence() to simplify some code > > v3: - use bool in the interface > --- > src/gallium/include/state_tracker/opencl_interop.h | 40 +++

Re: [Mesa-dev] Patch: typo fixing

2015-04-27 Thread Francisco Jerez
Zoë Blade writes: > Hi! > >> In this line there is a second typo in "degnerate". > > Very well spotted, thank you! > > I've now fixed that particular typo, which appears in two different places: > > src/mesa/drivers/dri/i965/brw_clip_unfilled.c > src/mesa/vbo/vbo_save_draw.c > > While I was at it

Re: [Mesa-dev] [PATCH 1/2] r600g, radeonsi: add driver queries for GPU temperature and shader+memory clocks

2015-04-27 Thread Alex Deucher
On Mon, Apr 27, 2015 at 10:46 AM, Marek Olšák wrote: > From: Marek Olšák For the series: Reviewed-by: Alex Deucher > > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 13 +++-- > src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ > src/gallium/drivers/radeon/r600_qu

[Mesa-dev] [Bug 90167] [softpipe] piglit depthstencil-default_fb-drawpixels-32f_24_8_rev regression

2015-04-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90167 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] util/macros: Move DIV_ROUND_UP to util/macros.h

2015-04-27 Thread Axel Davy
On 27/04/2015 15:52, Brian Paul wrote : On 04/26/2015 03:23 PM, Axel Davy wrote: */ #include "svga3d_reg.h" +#include "util/macros.h" Actually, it looks like this #include may not be needed. We get ARRAY_SIZE via including svga3d_reg.h, which includes svga_types.h, which includes p_co

Re: [Mesa-dev] [PATCH] glsl: properly setting var->data.binding if explicit_binding is true

2015-04-27 Thread Emil Velikov
Hi Alejandro On 26 April 2015 at 14:23, Alejandro Piñeiro wrote: > On 26/04/15 00:08, Timothy Arceri wrote: >> On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: >>> There was a typo on commit c0cd5b, doing it when explicit_binding >>> was false. This prevented to use any binding point d

Re: [Mesa-dev] [PATCH 1/2] util/macros: Move DIV_ROUND_UP to util/macros.h

2015-04-27 Thread Brian Paul
On 04/27/2015 11:22 AM, Axel Davy wrote: On 27/04/2015 15:52, Brian Paul wrote : On 04/26/2015 03:23 PM, Axel Davy wrote: */ #include "svga3d_reg.h" +#include "util/macros.h" Actually, it looks like this #include may not be needed. We get ARRAY_SIZE via including svga3d_reg.h, which i

Re: [Mesa-dev] [RFC 6/9] nir: Add an entirely C-based linked list implementation

2015-04-27 Thread Eric Anholt
Jason Ekstrand writes: > This commit adds a C-based linked list implementation for NIR. Unlike > exec_list in glsl/list.h, there is no C++ API. Also, this list is based on > wl_list (from the Wayland project) which is, in turn, based on the kernel > list. As such, it should be fairly familiar

  1   2   >