Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-19 Thread Martin Peres
On 16/03/15 18:32, Laura Ekstrand wrote: That was basically my background (mechanical engineering + lots of OpenGL) when I started six months ago, but I have found the lack of mentoring to be a large roadblock. At that time, I wrote tests, but there were few people willing to review them and g

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-19 Thread Martin Peres
On 17/03/15 22:50, Bruno Jimenez wrote: Hi, Last year, I participated in GSoC, (yeah, I still read the mailing list every day :) ) so I will give my 2 cents to the topic. My background isn't at all related to graphics or computer science, I am a physicist, although my main interest is in simula

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-19 Thread Martin Peres
On 19/03/15 01:37, Jason Ekstrand wrote: On Wed, Mar 18, 2015 at 4:27 PM, Connor Abbott wrote: On Wed, Mar 18, 2015 at 2:58 PM, Matt Turner wrote: On Thu, Mar 12, 2015 at 9:46 PM, Matt Turner wrote: Here are some ideas I think might be reasonable GSoC ideas. - GLSL linking in NIR

[Mesa-dev] [Bug 89670] cmod_propagation_test.andnz_one regression

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89670 Bug ID: 89670 Summary: cmod_propagation_test.andnz_one regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords

[Mesa-dev] [PATCH] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-19 Thread Tapani Pälli
Patch adds a counter around the lowering pass so that arrays from different stages cannot end up having same name for uniform. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89590 Cc: 10.5 10.4 --- src/glsl/ir_optimization.h | 2 +- src/glsl

[Mesa-dev] [Bug 89590] Crash in glLinkProgram with shaders with multiple constant arrays

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89590 --- Comment #2 from Tapani Pälli --- I've sent a fix to mesa-dev mailing list for review. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

2015-03-19 Thread Samuel Pitoiset
On 03/18/2015 06:13 PM, Marek Olšák wrote: The Gallium interface looked good to me (except where I replied). Sorry, I probably won't have time to review the st/mesa patch. Ok, thank you. I'll submit a v2 for that. Marek On Wed, Mar 18, 2015 at 5:00 PM, Samuel Pitoiset wrote: Bump, is so

[Mesa-dev] [Bug 89662] context.c:943: undefined reference to `_glapi_new_nop_table'

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89662 --- Comment #7 from Christoph Haag --- Hm... I was very sure I had removed my complete build directory, but now I tried it again and the error is gone. Interesting. So it's probably a problem on my end somewhere. Sorry for the noise. -- You ar

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-19 Thread Eero Tamminen
Hi, On 03/16/2015 06:37 PM, Matt Turner wrote: On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: Is there some particular Piglit test case that hits this path and is it possible with gen>5 (by removing gen check)? I've tried this with handicrafted shader_test and also shader-db and cannot h

[Mesa-dev] [PATCH] gallivm: removes unused 'builder' variable

2015-03-19 Thread Brian Paul
--- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index 0d4eaea..956b37a 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_arit.c +++ b/src/gallium/auxiliary/

[Mesa-dev] [PATCH 2/2] mesa: simplify code setting boolean uniforms

2015-03-19 Thread Brian Paul
src[i] is a union. Just check if src[i].u is non-zero to choose between ctx->Const.UniformBooleanTrue and zero. --- src/mesa/main/uniform_query.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 2ab5

[Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa/main/uniform_query.cpp | 69 ++--- 1 file changed, 65 insertions(+), 4 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
On 03/19/2015 08:53 AM, Brian Paul wrote: Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa/main/uniform_query.cpp | 69 ++--- 1 file changed,

Re: [Mesa-dev] [PATCH] egl: cut down static storage size for {Version, ClientAPI}String

2015-03-19 Thread Brian Paul
On 03/18/2015 07:52 PM, Emil Velikov wrote: Both seems to be excessively long, namely: ClientAPIString can get up-to 47 based on current code, while the name of the driver can dictate the length of the VersionString, currently it is around 11. Let's pad each to 100, rather than the current 1000.

Re: [Mesa-dev] [PATCH] gallivm: removes unused 'builder' variable

2015-03-19 Thread Roland Scheidegger
Am 19.03.2015 um 15:53 schrieb Brian Paul: > --- > src/gallium/auxiliary/gallivm/lp_bld_arit.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c > b/src/gallium/auxiliary/gallivm/lp_bld_arit.c > index 0d4eaea..956b37a 100644 > --- a/src/gallium/a

[Mesa-dev] [Bug 89680] Hard link exist in Mesa 10.5.1 sources

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89680 Alexander von Gluck changed: What|Removed |Added CC||andreas.boll@gmail.com,

[Mesa-dev] [Bug 89680] Hard link exist in Mesa 10.5.1 sources

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89680 Bug ID: 89680 Summary: Hard link exist in Mesa 10.5.1 sources Product: Mesa Version: 10.5 Hardware: All OS: All Status: NEW Severity: normal Pri

[Mesa-dev] [Bug 89680] Hard link exist in Mesa 10.5.1 sources

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89680 --- Comment #1 from Matt Turner --- Probably just want to backport the gallium/egl state tracker removal to 10.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 2/2] mesa: simplify code setting boolean uniforms

2015-03-19 Thread Matt Turner
On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: > src[i] is a union. Just check if src[i].u is non-zero to choose > between ctx->Const.UniformBooleanTrue and zero. > --- > src/mesa/main/uniform_query.cpp | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/mesa/ma

Re: [Mesa-dev] [PATCH] glsl: Use INFINITY instead of std::numeric_limits::infinity().

2015-03-19 Thread Jose Fonseca
On 18/03/15 17:18, Matt Turner wrote: --- src/glsl/builtin_functions.cpp | 4 ++-- src/glsl/s_expression.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index c607572..524b8d6 100644 --- a/src/gl

Re: [Mesa-dev] [PATCH] gallivm: removes unused 'builder' variable

2015-03-19 Thread Jose Fonseca
On 19/03/15 14:53, Brian Paul wrote: --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index 0d4eaea..956b37a 100644 --- a/src/gallium/auxiliary/gallivm/l

Re: [Mesa-dev] [PATCH 10/16] main: Added entry point for glCreateQueries

2015-03-19 Thread Martin Peres
On 27/02/15 01:20, Laura Ekstrand wrote: On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres mailto:martin.pe...@linux.intel.com>> wrote: Signed-off-by: Martin Peres mailto:martin.pe...@linux.intel.com>> --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/q

Re: [Mesa-dev] [PATCH 10/16] main: Added entry point for glCreateQueries

2015-03-19 Thread Laura Ekstrand
Too much debugging in gdb. On Thu, Mar 19, 2015 at 9:35 AM, Martin Peres wrote: > On 27/02/15 01:20, Laura Ekstrand wrote: > >> >> >> On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres < >> martin.pe...@linux.intel.com > >> wrote: >> >> Signed-off-by: Martin P

Re: [Mesa-dev] [PATCH 15/16] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-19 Thread Martin Peres
On 27/02/15 02:24, Laura Ekstrand wrote: On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres mailto:martin.pe...@linux.intel.com>> wrote: Signed-off-by: Martin Peres mailto:martin.pe...@linux.intel.com>> --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/f

Re: [Mesa-dev] [PATCH] glsl: Use INFINITY instead of std::numeric_limits::infinity().

2015-03-19 Thread Emil Velikov
On 19/03/15 16:59, Jose Fonseca wrote: > On 19/03/15 16:51, Emil Velikov wrote: >> On 19/03/15 15:30, Jose Fonseca wrote: >>> On 18/03/15 17:18, Matt Turner wrote: --- src/glsl/builtin_functions.cpp | 4 ++-- src/glsl/s_expression.cpp | 4 ++-- 2 files changed, 4 ins

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-19 Thread Ian Romanick
On 03/19/2015 07:21 AM, Eero Tamminen wrote: > Hi, > > On 03/16/2015 06:37 PM, Matt Turner wrote: >> On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli >> wrote: >>> Is there some particular Piglit test case that hits this path and is it >>> possible with gen>5 (by removing gen check)? I've tried this

[Mesa-dev] [Bug 89642] dEQP-GLES3: dEQP-GLES3.functional.shaders.preprocessor.predefined_macros.line_2_vertex fails because of wrong __LINE__ values

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89642 Carl Worth changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |cwo...@cworth.org |org

Re: [Mesa-dev] [PATCH 2/2] mesa: simplify code setting boolean uniforms

2015-03-19 Thread Brian Paul
On 03/19/2015 09:26 AM, Matt Turner wrote: On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: src[i] is a union. Just check if src[i].u is non-zero to choose between ctx->Const.UniformBooleanTrue and zero. --- src/mesa/main/uniform_query.cpp | 6 +- 1 file changed, 1 insertion(+), 5 del

[Mesa-dev] [PATCH] main: Simplify debug messages for CopyTex*SubImage*D.

2015-03-19 Thread Laura Ekstrand
--- src/mesa/main/teximage.c | 86 +--- src/mesa/main/teximage.h | 3 +- 2 files changed, 39 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8b56d5b..7f0f7b7 100644 --- a/src/mesa/main/teximage.c ++

Re: [Mesa-dev] [PATCH 2/2] mesa: simplify code setting boolean uniforms

2015-03-19 Thread Ian Romanick
On 03/19/2015 10:45 AM, Brian Paul wrote: > On 03/19/2015 09:26 AM, Matt Turner wrote: >> On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: >>> src[i] is a union. Just check if src[i].u is non-zero to choose >>> between ctx->Const.UniformBooleanTrue and zero. >>> --- >>> src/mesa/main/uniform_

Re: [Mesa-dev] [PATCH 16/16] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-19 Thread Martin Peres
On 27/02/15 02:52, Laura Ekstrand wrote: On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres mailto:martin.pe...@linux.intel.com>> wrote: Signed-off-by: Martin Peres mailto:martin.pe...@linux.intel.com>> --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++ src/mesa/main/

Re: [Mesa-dev] [PATCH] main: Simplify debug messages for CopyTex*SubImage*D.

2015-03-19 Thread Martin Peres
This is indeed much more readable :) Reviewed-by: Martin Peres On 19/03/15 19:48, Laura Ekstrand wrote: --- src/mesa/main/teximage.c | 86 +--- src/mesa/main/teximage.h | 3 +- 2 files changed, 39 insertions(+), 50 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] main: Add TEXTURE_CUBE_MAP support in CopyTextureSubImage3D.

2015-03-19 Thread Laura Ekstrand
On Wed, Mar 18, 2015 at 3:15 PM, Anuj Phogat wrote: > On Wed, Mar 18, 2015 at 1:06 PM, Laura Ekstrand > wrote: > > So it turns out that this doesn't actually fix any bugs or add any > features, > > stictly speaking. However, it does avoid a lot of kludginess. > Previously, if > > you called > >

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Ian Romanick
On 03/19/2015 07:56 AM, Brian Paul wrote: > On 03/19/2015 08:53 AM, Brian Paul wrote: >> Different errors for type mismatches, size mismatches and matrix/ >> non-matrix mismatches. Use a common format of "uniformName"@location >> in the messags. >> --- >> src/mesa/main/uniform_query.cpp | 69 >>

[Mesa-dev] [Bug 89680] Hard link exist in Mesa 10.5.1 sources

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89680 --- Comment #2 from Emil Velikov --- Fear that we have links in src/mesa/drivers/dri/r200, which became hard ones with 10.5 as well. So porting that over will not really cut it. I will check who exactly is causing this - tar or autotools, and wi

Re: [Mesa-dev] [PATCH] main: Simplify debug messages for CopyTex*SubImage*D.

2015-03-19 Thread Anuj Phogat
On Thu, Mar 19, 2015 at 10:48 AM, Laura Ekstrand wrote: > --- > src/mesa/main/teximage.c | 86 > +--- > src/mesa/main/teximage.h | 3 +- > 2 files changed, 39 insertions(+), 50 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/tex

Re: [Mesa-dev] [PATCH] main: Add TEXTURE_CUBE_MAP support in CopyTextureSubImage3D.

2015-03-19 Thread Anuj Phogat
On Thu, Mar 19, 2015 at 10:56 AM, Laura Ekstrand wrote: > > > On Wed, Mar 18, 2015 at 3:15 PM, Anuj Phogat wrote: >> >> On Wed, Mar 18, 2015 at 1:06 PM, Laura Ekstrand >> wrote: >> > So it turns out that this doesn't actually fix any bugs or add any >> > features, >> > stictly speaking. However,

[Mesa-dev] [PATCH 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-19 Thread Martin Peres
v2: Review from Laura Ekstrand - get rid of a change that should not have happened in this patch - improve the error messages - fix alignments - fix a capitalization in a function name in an error message Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++ s

[Mesa-dev] [PATCH 17/17] docs: Update progress on ARB_direct_state_access.

2015-03-19 Thread Martin Peres
Signed-off-by: Martin Peres --- docs/GL3.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 93fa60d..a0aa251 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -193,14 +193,14 @@ GL 4.5, GLSL 4.50: GL_ARB_cull_distance

Re: [Mesa-dev] [PATCH 08/16] main: Added entry point for glGetTransformFeedbacki_v

2015-03-19 Thread Martin Peres
Laura, can I get your R-b on this one? On 16/02/15 16:13, Martin Peres wrote: v2: Review from Laura Ekstrand - use the transform feedback object lookup wrapper v3: - use the new name of _mesa_lookup_transform_feedback_object_err Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-03-19 Thread Martin Peres
Bump. I would really like to push this series ASAP and I only have a few patches without R-b. On 16/02/15 16:13, Martin Peres wrote: Maybe this should be the job of the dispatch layer. Signed-off-by: Martin Peres --- src/mesa/main/multisample.c | 9 + 1 file changed, 9 insertions(+

[Mesa-dev] [PATCH v2] i965: Refactor SIMD16-to-2xSIMD8 checks.

2015-03-19 Thread Neil Roberts
The places that were checking whether 3-source instructions are supported have now been combined into a small helper function. This will be used in the next patch to add an additonal restriction. Based on a patch by Kenneth Graunke. --- Matt's review for v1 of this patch was conditional based on

[Mesa-dev] [Bug 89670] cmod_propagation_test.andnz_one regression

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89670 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

[Mesa-dev] [PATCH v2] i965/skl: Break down SIMD16 3-source instructions when required.

2015-03-19 Thread Neil Roberts
From: Kenneth Graunke Several steppings of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. Based on a patch by Neil Roberts. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 6 ++ 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
On 03/19/2015 12:03 PM, Ian Romanick wrote: On 03/19/2015 07:56 AM, Brian Paul wrote: On 03/19/2015 08:53 AM, Brian Paul wrote: Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #11 from Dan Sebald --- "it's all a bit annoying as it uses cmake" Yes, as bit, but eventually was able to make everything. The one significant issue was making Waffles in /usr/local couldn't be found by Piglit ccmake. Because cmak

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #12 from Ian Romanick --- (In reply to Dan Sebald from comment #11) > "it's all a bit annoying as it uses cmake" > > Yes, as bit, but eventually was able to make everything. The one > significant issue was making Waffles in /usr/loc

[Mesa-dev] [PATCH v4] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

2015-03-19 Thread Marius Predut
On SNB and IVB hw, for 1 pixel line thickness or less, the general anti-aliasing algorithm give up - garbage line is generated. Setting a Line Width of 0.0 specifies the rasterization of the “thinnest” (one-pixel-wide), non-antialiased lines. Lines rendered with zero Line Width are rasterized using

[Mesa-dev] [PATCH v4] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN7

2015-03-19 Thread Marius Predut
On SNB and IVB hw, for 1 pixel line thickness or less, the general anti-aliasing algorithm give up - garbage line is generated. Setting a Line Width of 0.0 specifies the rasterization of the “thinnest” (one-pixel-wide), non-antialiased lines. Lines rendered with zero Line Width are rasterized using

Re: [Mesa-dev] [PATCH v4] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

2015-03-19 Thread Ian Romanick
On 03/19/2015 01:23 PM, Marius Predut wrote: > On SNB and IVB hw, for 1 pixel line thickness or less, > the general anti-aliasing algorithm give up - garbage line is generated. > Setting a Line Width of 0.0 specifies the rasterization of > the “thinnest” (one-pixel-wide), non-antialiased lines. > L

Re: [Mesa-dev] [PATCH v4] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

2015-03-19 Thread Predut, Marius
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of > Ian Romanick > Sent: Thursday, March 19, 2015 9:35 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v4] i965/aa: fixing anti-aliasing bug for > thinn

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #13 from Dan Sebald --- OK, thanks. I'll just run the executable binaries then: [sebald@ piglit]$ bin/ext_polygon_offset_clamp-draw piglit: error: waffle_config_choose failed due to WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM: GLX_ARB_cre

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #14 from Ilia Mirkin --- (In reply to Dan Sebald from comment #11) > "it's all a bit annoying as it uses cmake" > > Yes, as bit, but eventually was able to make everything. The one > significant issue was making Waffles in /usr/loca

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #15 from Ilia Mirkin --- (In reply to Dan Sebald from comment #13) > OK, thanks. I'll just run the executable binaries then: > > [sebald@ piglit]$ bin/ext_polygon_offset_clamp-draw > piglit: error: waffle_config_choose failed due t

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #16 from Ian Romanick --- (In reply to Ilia Mirkin from comment #15) > (In reply to Dan Sebald from comment #13) > > OK, thanks. I'll just run the executable binaries then: > > > > [sebald@ piglit]$ bin/ext_polygon_offset_clamp-draw

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #17 from Ilia Mirkin --- (In reply to Ian Romanick from comment #16) > (In reply to Ilia Mirkin from comment #15) > > (In reply to Dan Sebald from comment #13) > > > OK, thanks. I'll just run the executable binaries then: > > > > >

Re: [Mesa-dev] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

2015-03-19 Thread Anuj Phogat
On Fri, Mar 6, 2015 at 4:15 PM, Anuj Phogat wrote: > in different fragment shaders. This also applies to a case when gl_FragCoord > is redeclared with no layout qualifiers in one fragment shader and not > declared but used in other fragment shader. > > Signed-off-by: Anuj Phogat > Khronos Bug#129

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

2015-03-19 Thread Chris Forbes
LGTM. Reviewed-by: Chris Forbes On Sat, Mar 7, 2015 at 1:15 PM, Anuj Phogat wrote: > in different fragment shaders. This also applies to a case when gl_FragCoord > is redeclared with no layout qualifiers in one fragment shader and not > declared but used in other fragment shader. > > Signed-off

Re: [Mesa-dev] [PATCH 17/17] docs: Update progress on ARB_direct_state_access.

2015-03-19 Thread Laura Ekstrand
Program pipelines should just say "DONE." Query objects should say "DONE (will require changes when ...)." On Thu, Mar 19, 2015 at 11:13 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > docs/GL3.txt | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #18 from Dan Sebald --- Oh, that's right. Somehow I have to build or run the piglit tests using the local build of Mesa (which is repository-up-to-date), i.e., what is accomplished with PKG_CONFIG_PATH=/home/sebald/local/pkgconfig .

Re: [Mesa-dev] [PATCH 08/16] main: Added entry point for glGetTransformFeedbacki_v

2015-03-19 Thread Laura Ekstrand
Oops, apparently I sent it to just you. Reviewed-by: Laura Ekstrand On Thu, Mar 19, 2015 at 11:15 AM, Martin Peres wrote: > Laura, can I get your R-b on this one? > > > On 16/02/15 16:13, Martin Peres wrote: > >> v2: Review from Laura Ekstrand >> - use the transform feedback object lookup wra

Re: [Mesa-dev] [PATCH v2] i965: Refactor SIMD16-to-2xSIMD8 checks.

2015-03-19 Thread Kenneth Graunke
On Thursday, March 19, 2015 06:43:07 PM Neil Roberts wrote: > The places that were checking whether 3-source instructions are > supported have now been combined into a small helper function. This > will be used in the next patch to add an additonal restriction. > > Based on a patch by Kenneth Grau

Re: [Mesa-dev] [PATCH v2] i965: Refactor SIMD16-to-2xSIMD8 checks.

2015-03-19 Thread Matt Turner
On Thu, Mar 19, 2015 at 11:43 AM, Neil Roberts wrote: > The places that were checking whether 3-source instructions are > supported have now been combined into a small helper function. This > will be used in the next patch to add an additonal restriction. > > Based on a patch by Kenneth Graunke. >

Re: [Mesa-dev] [PATCH] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-19 Thread Kenneth Graunke
On Thursday, March 19, 2015 11:59:50 AM Tapani Pälli wrote: > Patch adds a counter around the lowering pass so that arrays > from different stages cannot end up having same name for uniform. > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89590 > Cc: 10.5

Re: [Mesa-dev] [PATCH 13/16] main: Added entry point for glCreateSamplers

2015-03-19 Thread Fredrik Höglund
On Monday 16 February 2015, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ > src/mesa/main/samplerobj.c | 26 > -- > src/mesa/main/samplerobj.h | 2 ++ > src/m

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-19 Thread Kenneth Graunke
On Thursday, March 19, 2015 04:21:25 PM Eero Tamminen wrote: > Hi, > > On 03/16/2015 06:37 PM, Matt Turner wrote: > > On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli > > wrote: > >> Is there some particular Piglit test case that hits this path and is it > >> possible with gen>5 (by removing gen ch

Re: [Mesa-dev] [PATCH 03/22] mesa: Keep track of the last looked-up VAO

2015-03-19 Thread Fredrik Höglund
On Thursday 19 March 2015, Brian Paul wrote: > On 03/18/2015 05:18 PM, Fredrik Höglund wrote: > > This saves the cost of repeated hash table lookups when the same > > vertex array object is referenced in a sequence of calls such as: > > > > glVertexArrayAttribFormat(vao, ...); > > glVerte

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

2015-03-19 Thread Robert Bragg
Hi Samuel, I thought I should let you and others know of some related changes I've been playing around with to try and improve our support for the INTEL_performance_query extension in the i965 dri driver, since it's quite related to your work. Some of my work-in-progress changes can currently be

[Mesa-dev] [PATCH] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Fredrik Höglund
Generate GL_INVALID_OPERATION and return NULL when the buffer object hasn't been created. All callers expect this. Cc: Laura Ekstrand --- src/mesa/main/bufferobj.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj

Re: [Mesa-dev] [PATCH] u_primconvert: add primitive restart support

2015-03-19 Thread Dave Airlie
On 19 March 2015 at 05:36, Brian Paul wrote: > On 03/17/2015 08:13 PM, Dave Airlie wrote: >> >> This add primitive restart support to the prim conversion. >> >> This involves changing the API for the translate functions >> as we need to pass the prim restart index and the original >> number of ind

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Kenneth Graunke
On Thursday, March 19, 2015 12:55:48 PM Brian Paul wrote: > On 03/19/2015 12:03 PM, Ian Romanick wrote: > > On 03/19/2015 07:56 AM, Brian Paul wrote: > >> On 03/19/2015 08:53 AM, Brian Paul wrote: > >>> Different errors for type mismatches, size mismatches and matrix/ > >>> non-matrix mismatches.

Re: [Mesa-dev] [PATCH] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Laura Ekstrand
You are right; I missed that subtle OpenGL definition of "exist" in the lookup functions. On Thu, Mar 19, 2015 at 3:48 PM, Fredrik Höglund wrote: > Generate GL_INVALID_OPERATION and return NULL when the buffer object > hasn't been created. All callers expect this. > > Cc: Laura Ekstrand > ---

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Laura Ekstrand
On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: > Different errors for type mismatches, size mismatches and matrix/ > non-matrix mismatches. Use a common format of "uniformName"@location > in the messags. > --- > src/mesa/main/uniform_query.cpp | 69 > ++--

[Mesa-dev] [Bug 89670] cmod_propagation_test.andnz_one regression

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89670 Ian Romanick changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

[Mesa-dev] [PATCH] i965/fs: Use correct null destination register in cmod tests

2015-03-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89670 Cc: Vinson Lee --- src/mesa/drivers/dri/i965/test_fs_cmod_propagation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/test_fs_cmod

[Mesa-dev] [Bug 89670] cmod_propagation_test.andnz_one regression

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89670 --- Comment #3 from Ian Romanick --- It was just a dumb error in the test. Patch sent: http://lists.freedesktop.org/archives/mesa-dev/2015-March/079946.html -- You are receiving this mail because: You are the QA Contact for the bug. _

Re: [Mesa-dev] [PATCH] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Anuj Phogat
On Thu, Mar 19, 2015 at 4:29 PM, Laura Ekstrand wrote: > You are right; I missed that subtle OpenGL definition of "exist" in the > lookup functions. > > On Thu, Mar 19, 2015 at 3:48 PM, Fredrik Höglund wrote: >> >> Generate GL_INVALID_OPERATION and return NULL when the buffer object >> hasn't bee

Re: [Mesa-dev] [PATCH] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Fredrik Höglund
On Friday 20 March 2015, Anuj Phogat wrote: > On Thu, Mar 19, 2015 at 4:29 PM, Laura Ekstrand wrote: > > You are right; I missed that subtle OpenGL definition of "exist" in the > > lookup functions. > > > > On Thu, Mar 19, 2015 at 3:48 PM, Fredrik Höglund wrote: > >> > >> Generate GL_INVALID_OPER

[Mesa-dev] [PATCH v2] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Fredrik Höglund
Generate GL_INVALID_OPERATION and return NULL when the buffer object hasn't been created. All callers expect this. v2: Use a more concise error message. Cc: Laura Ekstrand --- src/mesa/main/bufferobj.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH v2] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

2015-03-19 Thread Laura Ekstrand
Reviewed-by: Laura Ekstrand On Thu, Mar 19, 2015 at 5:06 PM, Fredrik Höglund wrote: > Generate GL_INVALID_OPERATION and return NULL when the buffer object > hasn't been created. All callers expect this. > > v2: Use a more concise error message. > > Cc: Laura Ekstrand > --- > src/mesa/main/bu

[Mesa-dev] [PATCH] i965/fs: bail on move-to-flag in sel peephole

2015-03-19 Thread Connor Abbott
Fixes a piglit regression (shaders/glsl-fs-vec4-indexing-temp-dst-in-nested-loop-combined) with my series for GVN. Signed-off-by: Connor Abbott --- I think this particular case might not trigger anymore after Matt's patch to improve cmod prop since we're better at getting rid of mov-to-flag befor

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #19 from Dan Sebald --- I've tried variations on the include and library directories but not much luck. Remade Waffles in /usr/local/lib64. I did get the local version of Mesa library in the test programs: [sebald@ piglit]$ LD_LIBR

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #20 from Ilia Mirkin --- (In reply to Dan Sebald from comment #19) > I've tried variations on the include and library directories but not much > luck. Remade Waffles in /usr/local/lib64. I did get the local version of > Mesa library

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #21 from Ilia Mirkin --- (In reply to Dan Sebald from comment #19) > I've tried variations on the include and library directories but not much > luck. Remade Waffles in /usr/local/lib64. I did get the local version of [...] > WAFF

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #22 from Dan Sebald --- glxinfo indicates GLX Version 1.4. I did find some tests that work without the GLX_ARB_create_context error. There seems to be no correlation with 1.0, 2.0, etc. For example, this one works: [sebald@ piglit

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #23 from Ilia Mirkin --- (In reply to Dan Sebald from comment #22) > glxinfo indicates GLX Version 1.4. Not really relevant... I was looking for the version of X to determine the general age of the system, as well as what libglx ship

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #24 from Dan Sebald --- Yes, Gallium version works: [sebald@ piglit]$ LD_LIBRARY_PATH=/home/sebald/local/lib:/usr/local/lib64 bin/ext_polygon_offset_clamp-draw libGL error: unable to load driver: nouveau_dri.so libGL error: driver po

[Mesa-dev] [Bug 89687] Mesa implementation error: GLX Error: maximum number of visuals exceeded

2015-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89687 Bug ID: 89687 Summary: Mesa implementation error: GLX Error: maximum number of visuals exceeded Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-19 Thread Tapani Pälli
On 03/19/2015 11:39 PM, Kenneth Graunke wrote: On Thursday, March 19, 2015 11:59:50 AM Tapani Pälli wrote: Patch adds a counter around the lowering pass so that arrays from different stages cannot end up having same name for uniform. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedes

Re: [Mesa-dev] [PATCH] i965/fs: Use correct null destination register in cmod tests

2015-03-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: bail on move-to-flag in sel peephole

2015-03-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev