On 19 March 2015 at 05:36, Brian Paul <bri...@vmware.com> wrote: > On 03/17/2015 08:13 PM, Dave Airlie wrote: >> >> This add primitive restart support to the prim conversion. >> >> This involves changing the API for the translate functions >> as we need to pass the prim restart index and the original >> number of indices into the translate functions. >> >> primitive restart is support for quads, quad strips >> and polygons. >> >> This deal with the case where the actual number of output >> primitives is less than the initially calculated number, >> by filling the rest of the output primitives with the restart >> index, the other option is to reduce the output prim number, >> but that will make the generator code a bit messier. >> >> Signed-off-by: Dave Airlie <airl...@redhat.com> > > > This is some pretty dense code. I know, I was working on adding prim > restart support a while back but never finished. > > Changes look good AFAICT. Just a minor unsigned->boolean nit/question > below. > > Reviewed-by: Brian Paul <bri...@vmware.com> > > If it were me I might replace "prim_restart_idx" with "restart_index", but > not a big deal.
Yeah that looks nicer, I'll do that before pushing. >> unsigned nr, >> unsigned in_pv, >> unsigned out_pv, >> + unsigned prim_restart, > > > boolean? Because I used it directly to dereference the array of translate objects I didn't think boolean was appropriate, and to be consistent with in_pv and out_pv being unsigned. Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
