Fixes misrendering in "Witcher 2" with INTEL_USE_NIR=1, and probably
many other programs.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
This depends on Jason's 3 patch series that removes emit_percomp.
It'
On Monday, February 02, 2015 05:28:37 PM Matt Turner wrote:
> ---
> src/glsl/list.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/glsl/list.h b/src/glsl/list.h
> index 85368a4..6f1a57b 100644
> --- a/src/glsl/list.h
> +++ b/src/glsl/list.h
> @@ -51,6 +51,10 @@
> * Therefore,
https://bugs.freedesktop.org/show_bug.cgi?id=79629
Chris Wilson changed:
What|Removed |Added
Status|VERIFIED|REOPENED
Resolution|FIXED
On 16/12/14 20:08, Rob Conde wrote:
I built Mesa 10.4 with LLVM 3.5 today and I had to make a couple of
fixes to get it to work:
1. root\src\mesa\compiler.h
After:
#include "c99_compat.h" /* inline, __func__, etc. */
Add:
#ifdef _MSC_VER
#define __attribute__(a)
#en
Caught by lit_sat.shader_test.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 153a1be..3c611af 100644
--- a/src/mesa/drivers
Am 03.02.2015 um 02:28 schrieb Matt Turner:
> Unclear circumstances lead to undefined symbols on x86.
>
> Bugzilla:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.gentoo.org_show-5Fbug.cgi-3Fid-3D536916&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9
On Mon, Feb 2, 2015 at 10:05 AM, Michel Dänzer wrote:
> On 02.02.2015 02:37, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> The stipple texture is bound to slot 16, so there are 17 sampler states and
>> 34 sampler views now (17 normal slots + 17 fmask slots).
>
> [...]
>
>> @@ -2742,16 +2743,26 @@
On 30/01/15 23:44, Kenneth Graunke wrote:
On Friday, January 30, 2015 04:19:47 PM Martin Peres wrote:
Reviewed-by: Kenneth Graunke
Signed-off-by: Martin Peres
---
src/mesa/drivers/dri/i915/intel_screen.c | 1 +
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
src/mesa/drivers/dri/i965/in
On 3 February 2015 at 02:53, Emil Velikov wrote:
> Hi Felix,
>
> On 2 February 2015 at 19:04, Felix Janda wrote:
>> Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
>> compatibility with old glibc. Since mesa defines __GNU_SOURCE__
>> on linux PTHREAD_MUTEX_RECURSIVE is also avail
On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner wrote:
> Unclear circumstances lead to undefined symbols on x86.
>
> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916
A comment[1] on the gentoo bug-tracker suggest doing something along
these lines instead (untested)...
[1]: https://bugs.gento
On Feb 2, 2015 10:59 PM, "Kenneth Graunke" wrote:
>
> On Monday, February 02, 2015 10:28:22 PM Jason Ekstrand wrote:
> > On Mon, Feb 2, 2015 at 9:08 PM, Kenneth Graunke
> > wrote:
> >
> > > On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
> [snip]
> > > > +static bool
> > > > +is_p
Ooh! I bet this fixes our rendering problems on some of those benchmarks
too! I was wondering why generating made was causing problems.
Reviewed-by: Jason Ekstrand
On Feb 3, 2015 1:18 AM, "Kenneth Graunke" wrote:
> Fixes misrendering in "Witcher 2" with INTEL_USE_NIR=1, and probably
> many oth
Hrm... I thought bcsel worked on integers. You shouldn't be able to sat it
anyway... This seems strange.
As a side-note, this is one of the downsides to typeless that we should
figure out how to solve. Not 100% sure how at the moment.
On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote:
> Caught b
When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
set, the environment variable takes precedence.
This will be used to fix Unigine Tropics and Sanctuary.
v2:
- change the name from mesa_extension_override to extension_override
- make the presence of the environment variabl
v2:
- change the commit name as per Marek's comment
- make the i830/i915 drivers actually use the force_glsl_version
Reviewed-by: Kenneth Graunke v1
Signed-off-by: Martin Peres
---
src/mesa/drivers/dri/i915/i830_context.c | 4
src/mesa/drivers/dri/i915/i915_context.c | 4
src/mesa/dri
v2:
- rename mesa_extension-override to extension_override
- improve the comment by telling we disable GL_ARB_gpu_shader5 (Ilia)
- fix the name ARB_GL_gpu_shader5 to GL_ARB_gpu_shader5 (Ilia)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82897
Signed-off-by: Martin Peres
---
src/mesa/dr
v2:
- rename mesa_extension-override to extension_override
- improve the comment by telling we disable GL_ARB_gpu_shader5
- fix the name ARB_GL_gpu_shader5 to GL_ARB_gpu_shader5 (Ilia)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82897
Signed-off-by: Martin Peres
---
src/mesa/drivers/d
From: Daniel van der Wath
The value stored in "handle" is trashed before being copied into the
surface's sid. Use the original value from "whandle->handle" instead.
This fixes a bug with Weston running on VMWare, where SVGA3D_SetRenderTarget()
would fail and prevent anything from being drawn on s
On 02/02/15 23:36, Laura Ekstrand wrote:
On Mon, Feb 2, 2015 at 2:58 AM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
if (!obj) {
-_mesa_error(ctx, GL_OUT_OF_MEMORY,
"glGenTransformFeedbacks");
+_mesa_error(ctx, GL_OUT_OF_MEMORY, "
On 02/02/15 23:46, Laura Ekstrand wrote:
On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
@@ -543,15 +545,12 @@ bind_buffer_range(struct gl_context *ctx,
GLuint index,
*/
void
_mesa_bind_buffer_range_transform_feedback(struct
On 02/02/15 16:09, Ilia Mirkin wrote:
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
wrote:
+static struct gl_transform_feedback_object *
+_mesa_lookup_transform_feedback_object_err(struct gl_context *ctx,
+ GLuint xfb, const char* func)
+{
+ struct gl
On 02/02/15 23:51, Laura Ekstrand wrote:
On Mon, Feb 2, 2015 at 3:30 AM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
if (index >= ctx->Const.MaxTransformFeedbackBuffers) {
- _mesa_error(ctx, GL_INVALID_VALUE,
"glBindBufferRange(index=%d "
-
On Tue, Feb 3, 2015 at 10:41 AM, Martin Peres
wrote:
> When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
> set, the environment variable takes precedence.
Just a thought -- combine them instead of having one override the
other? (With the env var being processed second so t
Dave Airlie wrote on 03.02.2015 05:48:
> From: Dave Airlie
>
> Like the RGTC code sharing this could be done nicer in the util lib.
>
> This slighty increase i965_dri.so size by ~100 bytes,
> but it decreases the combined gallium driver by over 1k,
> and its just nicer to avoid TAG().
>
> Signe
Because of your comments, there will be a v2 patch series. But I won't be
sending it for a week or so because I'm in the middle of implementing
BlitNamedFramebuffer, which has required a lot of concentration.
Laura
On Sat, Jan 31, 2015 at 11:46 PM, Ian Romanick wrote:
> On 01/31/2015 02:21 AM,
On Mon, Feb 2, 2015 at 11:59 AM, Thomas Helland
wrote:
> 2015-02-02 19:18 GMT+01:00 Jason Ekstrand :
>> Hi all,
>> I wanted to send out a quick message about naming conventions for mesa
>> entrypoints and dd table fallbacks. There has been some confusion and
>> disagreement about this with some o
---
src/glsl/nir/nir_validate.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
index 7c801b2..5b47f1a 100644
--- a/src/glsl/nir/nir_validate.c
+++ b/src/glsl/nir/nir_validate.c
@@ -488,16 +488,9 @@ valida
For whatever reason, I thought we might have non-ssa phi sources. However,
I looked again and I don't think it's possible. Also, this patch applies
with no piglit regressions.
On Tue, Feb 3, 2015 at 10:49 AM, Jason Ekstrand
wrote:
> ---
> src/glsl/nir/nir_validate.c | 13 +++--
> 1 fi
On Tue, Feb 3, 2015 at 6:13 AM, Erik Faye-Lund wrote:
> On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner wrote:
>> Unclear circumstances lead to undefined symbols on x86.
>>
>> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916
>
> A comment[1] on the gentoo bug-tracker suggest doing something a
On Tue, Feb 3, 2015 at 7:58 PM, Matt Turner wrote:
> On Tue, Feb 3, 2015 at 6:13 AM, Erik Faye-Lund wrote:
>> On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner wrote:
>>> Unclear circumstances lead to undefined symbols on x86.
>>>
>>> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916
>>
>> A co
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tuesday, February 03, 2015 03:50:58 PM Martin Peres wrote:
>
> On 30/01/15 23:44, Kenneth Graunke wrote:
> > On Friday, January 30, 2015 04:19:47 PM Martin Peres wrote:
> >> Reviewed-by: Kenneth Graunke
> >> Signed-off-by: Martin Peres
> >> ---
> >> src/mesa/drivers/dri/i915/intel_screen.c
On Tue, Feb 3, 2015 at 5:37 AM, Roland Scheidegger wrote:
> Am 03.02.2015 um 02:28 schrieb Matt Turner:
>> Unclear circumstances lead to undefined symbols on x86.
>>
>> Bugzilla:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.gentoo.org_show-5Fbug.cgi-3Fid-3D536916&d=AwIGaQ&c=Sqcl0E
On Tue, Feb 3, 2015 at 1:49 PM, Jason Ekstrand wrote:
> For whatever reason, I thought we might have non-ssa phi sources. However,
> I looked again and I don't think it's possible. Also, this patch applies
> with no piglit regressions.
Yeah, the only reason I made it so that phi instructions co
On Tuesday, February 03, 2015 07:10:20 AM you wrote:
> On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote:
> > Caught by lit_sat.shader_test.
> >
> > Signed-off-by: Kenneth Graunke
> > ---
> > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sr
On Tue, Feb 3, 2015 at 12:27 PM, Kenneth Graunke
wrote:
> On Tuesday, February 03, 2015 07:10:20 AM you wrote:
> > On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote:
> > > Caught by lit_sat.shader_test.
> > >
> > > Signed-off-by: Kenneth Graunke
> > > ---
> > > src/mesa/drivers/dri/i965/brw_fs_n
On Tue, Feb 3, 2015 at 3:27 PM, Kenneth Graunke wrote:
> On Tuesday, February 03, 2015 07:10:20 AM you wrote:
>> On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote:
>> > Caught by lit_sat.shader_test.
>> >
>> > Signed-off-by: Kenneth Graunke
>> > ---
>> > src/mesa/drivers/dri/i965/brw_fs_nir.cpp |
---
src/glsl/nir/nir_lower_to_source_mods.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/nir/nir_lower_to_source_mods.c
b/src/glsl/nir/nir_lower_to_source_mods.c
index c3f39bc..d6bf77f 100644
--- a/src/glsl/nir/nir_lower_to_source_mods.c
+++ b/src/glsl/nir/nir_lower_to_source_
---
src/glsl/nir/nir_validate.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
index 7c801b2..89dfdf8 100644
--- a/src/glsl/nir/nir_validate.c
+++ b/src/glsl/nir/nir_validate.c
@@ -239,6 +239,14 @@ validate_alu_dest(nir_alu_des
Reviewed-by: Connor Abbott
On Tue, Feb 3, 2015 at 3:43 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_lower_to_source_mods.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/glsl/nir/nir_lower_to_source_mods.c
> b/src/glsl/nir/nir_lower_to_source_mods.c
> index c3f39bc..d6b
On Tue, Feb 3, 2015 at 12:42 PM, Connor Abbott wrote:
> On Tue, Feb 3, 2015 at 3:27 PM, Kenneth Graunke
> wrote:
> > On Tuesday, February 03, 2015 07:10:20 AM you wrote:
> >> On Feb 3, 2015 2:35 AM, "Kenneth Graunke"
> wrote:
> >> > Caught by lit_sat.shader_test.
> >> >
> >> > Signed-off-by: Ke
Reviewed-by: Connor Abbott
Funny, I thought we already did this... whoops.
On Tue, Feb 3, 2015 at 3:43 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_validate.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
> inde
Reviewed-by: Jason Ekstrand
Tested-by: Jason Ekstrand
And here's the shader-db stats for the commit message:
total NIR instructions in shared programs: 2045293 -> 2041209 (-0.20%)
NIR instructions in affected programs: 126564 -> 122480 (-3.23%)
helped:615
HUR
On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_validate.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
> index 7c801b2..89dfdf8 100644
> --- a/src/glsl/nir/nir_validate.c
> +++ b/src/glsl
On Tue, Feb 3, 2015 at 1:08 PM, Erik Faye-Lund wrote:
> On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/nir/nir_validate.c | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
> > index 7c80
On Feb 3, 2015 10:39 PM, "Jason Ekstrand" wrote:
>
>
>
> On Tue, Feb 3, 2015 at 1:08 PM, Erik Faye-Lund
wrote:
>>
>> On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand
wrote:
>> > ---
>> > src/glsl/nir/nir_validate.c | 8
>> > 1 file changed, 8 insertions(+)
>> >
>> > diff --git a/src/glsl
Connor Abbott writes:
> I think this logic should be flipped around... you should have a flag
> 'lower_sub' which is false for vc4 but true for i965, and then if the
> flag is true we lower sub to add+neg and if false we try and
> reconstruct sub (and do other things like pulling neg's out of
> m
https://bugs.freedesktop.org/show_bug.cgi?id=88930
--- Comment #1 from Brian Paul ---
Thanks. Your patch looks correct. I believe we can also simply some code in
osmesa_st_framebuffer_flush_front() as a follow-on.
I'll apply your patch to master and the 10.4 branch.
--
You are receiving this
The osmesa->textures[] array is indexed by ST_ATTACHMENT_* so
there's no need to search the array to find the depth/stencil buffer.
This is a follow-on improvement after bug 88930.
---
src/gallium/state_trackers/osmesa/osmesa.c | 20 +---
1 file changed, 5 insertions(+), 15 deletio
https://bugs.freedesktop.org/show_bug.cgi?id=88930
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
When torus object is scaled up/down via glScalef call the lighting
effect is incorrectly expressed on render target because normals'
length is also changed when vertices are scaled up/down.
This patch enables "automatic normalization" of normals, which
is one of well-known ways to avoid this kind
In current code, color format is always hardcoded to __DRI_IMAGE_FORMAT_ARGB
when buffer or DRI image is allocated in function calls, get_back_bo and
dri2_get_buffers,
regardless of current target's color format. This problem may leads to
incorrect render
pitch calculation, which eventually e
On 02/03/2015 03:48 PM, Dongwon Kim wrote:
When torus object is scaled up/down via glScalef call the lighting
effect is incorrectly expressed on render target because normals'
length is also changed when vertices are scaled up/down.
This patch enables "automatic normalization" of normals, which
https://bugs.freedesktop.org/show_bug.cgi?id=85203
--- Comment #7 from Lorenzo Bona ---
I'm experiencing the same problem here.
Computer suddently hangs and I have to reboot.
In Xorg.0.log I have the same warnings.
Dmesg has no issue.
Running on drm-fixes-3.19 (rc6), mesa/ddx/xorg/drm from git,
https://bugs.freedesktop.org/show_bug.cgi?id=85203
--- Comment #8 from Lorenzo Bona ---
Created attachment 113141
--> https://bugs.freedesktop.org/attachment.cgi?id=113141&action=edit
Xorg.log
--
You are receiving this mail because:
You are the assignee for the bug.
__
On Tue, Feb 3, 2015 at 5:20 PM, Eric Anholt wrote:
> Connor Abbott writes:
>
>> I think this logic should be flipped around... you should have a flag
>> 'lower_sub' which is false for vc4 but true for i965, and then if the
>> flag is true we lower sub to add+neg and if false we try and
>> reconst
On Tue, Feb 3, 2015 at 7:41 AM, Martin Peres
wrote:
> v2:
> - rename mesa_extension-override to extension_override
> - improve the comment by telling we disable GL_ARB_gpu_shader5 (Ilia)
> - fix the name ARB_GL_gpu_shader5 to GL_ARB_gpu_shader5 (Ilia)
>
> Bugzilla: https://bugs.freedesktop.org/sho
Interesting. On radeonsi, the default value of an unbound texture can
be chosen but is the same for "load", "sample", and "gather"
instructions. We can't return (0,0,0,0) for "load" and (0,0,0,1) for
"sample".
I'll just modify the test to accept both return values.
Marek
On Mon, Feb 2, 2015 at 5
Emil Velikov wrote:
> On 3 February 2015 at 02:53, Emil Velikov wrote:
> > Hi Felix,
> >
Thanks for the review.
> > On 2 February 2015 at 19:04, Felix Janda wrote:
> >> Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
> >> compatibility with old glibc. Since mesa defines __GNU_S
https://bugs.freedesktop.org/show_bug.cgi?id=85203
--- Comment #9 from Michel Dänzer ---
(In reply to Lorenzo Bona from comment #7)
> I'm experiencing the same problem here.
>
> Computer suddently hangs and I have to reboot.
I doubt those hangs are directly related to these messages.
--
You a
On 03.02.2015 22:43, Marek Olšák wrote:
> On Mon, Feb 2, 2015 at 10:05 AM, Michel Dänzer wrote:
>> On 02.02.2015 02:37, Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> The stipple texture is bound to slot 16, so there are 17 sampler states and
>>> 34 sampler views now (17 normal slots + 17 fmask
Allows CMP instructions with float sources to be compacted and coissued.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 16 ++--
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 20
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/mesa/dri
---
src/mesa/drivers/dri/i965/brw_eu_emit.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c
b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 57161e2..308b305 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_
Prevents piglit regressions from the next patch.
---
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 37 +-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
index
https://bugs.freedesktop.org/show_bug.cgi?id=88962
Bug ID: 88962
Summary: [osmesa] Crash on postprocessing if z buffer is NULL
Product: Mesa
Version: git
Hardware: All
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=88962
--- Comment #2 from Park, Jeongmin ---
Created attachment 113148
--> https://bugs.freedesktop.org/attachment.cgi?id=113148&action=edit
patch #2
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee f
https://bugs.freedesktop.org/show_bug.cgi?id=88962
--- Comment #1 from Park, Jeongmin ---
Created attachment 113147
--> https://bugs.freedesktop.org/attachment.cgi?id=113147&action=edit
patch #1
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee f
https://bugs.freedesktop.org/show_bug.cgi?id=79629
--- Comment #13 from XiongZhang ---
(In reply to Chris Wilson from comment #12)
> Do you mind reconfirming that you actually tested with DRI3 since the
> proposed patch is not yet included?
Yes, I test with DRI3. When I compile xf86-video-intel
https://bugs.freedesktop.org/show_bug.cgi?id=79629
--- Comment #14 from Eero Tamminen ---
(In reply to XiongZhang from comment #13)
> Yes, I test with DRI3. When I compile xf86-video-intel and mesa, I add
> --enable-dri3 option.
> Without the proposed patch, I could easily reproduce this issue. A
69 matches
Mail list logo
