On 02/02/15 23:46, Laura Ekstrand wrote:


On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres <martin.pe...@linux.intel.com <mailto:martin.pe...@linux.intel.com>> wrote:


    @@ -543,15 +545,12 @@ bind_buffer_range(struct gl_context *ctx,
    GLuint index,
      */
     void
     _mesa_bind_buffer_range_transform_feedback(struct gl_context *ctx,
    -                                          GLuint index,
    -                                          struct gl_buffer_object
    *bufObj,
    -                                          GLintptr offset,
    -                                          GLsizeiptr size)

These don't line up?  Check for tabs here.  (Mesa uses 3-space indents)

Another visualisation artefact? Everything seems fine on my side. No tabs here and everything is perfectly aligned. I'm pretty sure I set my editor correctly + I see some dots instead of spaces which is quite helpful to investigate this kind of issues.

    +      struct gl_transform_feedback_object *obj,
    +                                           GLuint index,
    +                                           struct
    gl_buffer_object *bufObj,
    +                                           GLintptr offset,
    +                                           GLsizeiptr size)
     {


It'd be nice to include the PDF page.

Sure! Included!

    @@ -817,6 +889,10 @@ _mesa_GetTransformFeedbackVarying(GLuint
    program, GLuint index,
     struct gl_transform_feedback_object *
     _mesa_lookup_transform_feedback_object(struct gl_context *ctx,
    GLuint name)
     {

Again, a page number would be nice, but not necessary.

Done

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to