[Mesa-dev] [Bug 84145] UE4: Realistic Rendering Demo render blue

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84145 --- Comment #7 from Tapani Pälli --- IMO this not a Mesa core bug as the demo renders correctly on Intel. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 11/15] radeonsi: don't snoop currently-bound GS shader when compiling ES

2014-09-22 Thread Michel Dänzer
On 20.09.2014 05:17, Marek Olšák wrote: + assert(0 && "unreachable"); You can use: assert(!"unreachable"); Either way though, the series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast

Re: [Mesa-dev] [PATCH 04/17] auxiliary/vl: split out into a separate static library

2014-09-22 Thread Christian König
Am 22.09.2014 um 01:44 schrieb Emil Velikov: Avoid building the relatively large object every time and forcing on the non-vl targets. This gives us the following size improvement textdata bss dec hex filename 5898697 189212 1977864 8065773 7b12ed before/nouveau_dri.so 57712

Re: [Mesa-dev] [PATCH 12/17] gallium/r300, r600, radeonsi: add automake target 'templates'

2014-09-22 Thread Christian König
Am 22.09.2014 um 01:44 schrieb Emil Velikov: Rather than duplicating the libdeps, extra define... all over the targets, define them only once and use when applicable. Signed-off-by: Emil Velikov Do I get it right that this also allows for relatively easy definition of specialized targets? E.

[Mesa-dev] [Bug 84145] UE4: Realistic Rendering Demo render blue

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84145 --- Comment #8 from Michel Dänzer --- (In reply to comment #7) > IMO this not a Mesa core bug as the demo renders correctly on Intel. We're also using the 'Mesa core' component for Gallium state tracker bugs. The bisected commit only changes sta

Re: [Mesa-dev] [PATCH RESEND2 v3 0/3] add KHR_debug for gles contexts

2014-09-22 Thread Matthew Waters
Resend no2... On 31/08/14 20:21, Matthew Waters wrote: > v3: > - fix up the EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR check > > v2: > - replace &= with |= > - remove offset="assign" from the api xml > > Matthew Waters (3): > egl: rework handling EGL_CONTEXT_FLAGS for ES debug contexts > glap

Re: [Mesa-dev] [PATCH] radeonsi: fix CS tracing and remove excessive CS dumping

2014-09-22 Thread Michel Dänzer
I'm afraid I don't really understand how this stuff works. I hope Jerome or someone else can review it. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Michel Dänzer
The series looks good to me, but Tom should probably take a look as well. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list me

[Mesa-dev] [Bug 84145] UE4: Realistic Rendering Demo render blue

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84145 --- Comment #9 from Tapani Pälli --- (In reply to comment #8) > (In reply to comment #7) > > IMO this not a Mesa core bug as the demo renders correctly on Intel. > > We're also using the 'Mesa core' component for Gallium state tracker bugs. > Th

Re: [Mesa-dev] [PATCH 01/17] gallium/r300: remove obsolete declaration

2014-09-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 22, 2014 at 1:43 AM, Emil Velikov wrote: > The definition of rc_pair_regalloc_inputs_only() is no longer > around so drop the declaration. > > Signed-off-by: Emil Velikov > --- > src/gallium/drivers/r300/compiler/radeon_program_pair.h | 1 - > 1 file

Re: [Mesa-dev] [PATCH] mesa: Remove duplicate _mesa_{init, free}_shader_state prototypes.

2014-09-22 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 09/21/2014 09:39 PM, Matt Turner wrote: > --- > src/mesa/main/shaderobj.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/src/mesa/main/shaderobj.h b/src/mesa/main/shaderobj.h > index fae8be8..d72919c 100644 > --- a/src/mesa/main/shaderobj.h > +++ b/sr

[Mesa-dev] [PATCH] glsl: Structures must have same name to be considered same type.

2014-09-22 Thread Tapani Pälli
From: Kalyan Kondapally According to GLSL(4.2) and GLSL-ES (1.0, 3.0) spec, Structures must have the same name to be considered same type. We currently ignore the name check while checking if two records are same. This patch fixes this. Patch fixes failing tests in WebGL conformance test 'shader

Re: [Mesa-dev] [PATCH 12/17] gallium/r300, r600, radeonsi: add automake target 'templates'

2014-09-22 Thread Emil Velikov
On 22/09/14 09:29, Christian König wrote: > Am 22.09.2014 um 01:44 schrieb Emil Velikov: >> Rather than duplicating the libdeps, extra define... all over the >> targets, define them only once and use when applicable. >> >> Signed-off-by: Emil Velikov > > Do I get it right that this also allows fo

Re: [Mesa-dev] [PATCH 2/2] st/xa: silence unused variable warning

2014-09-22 Thread Emil Velikov
Thanks Brian. For both patches are Reviewed-by: Emil Velikov On 18/09/14 17:22, Brian Paul wrote: > --- > src/gallium/state_trackers/xa/xa_tracker.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/state_trackers/xa/xa_tracker.c > b/src/gallium/state_trackers/xa/xa_trac

[Mesa-dev] [Bug 84145] UE4: Realistic Rendering Demo render blue

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84145 --- Comment #10 from Ilia Mirkin --- (In reply to comment #6) > Ilia, any ideas? Oh neat. I was seeing that render blue as well, but was assuming it was due to some spill errors that I had only semi-fixed. The interesting thing to note is that

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-22 Thread Roland Scheidegger
Am 21.09.2014 16:40, schrieb Mathias Fröhlich: > > Hi, > > On Thursday, September 18, 2014 03:56:11 Roland Scheidegger wrote: >> I agree it is something which would be nice to have in mesa, however I'm >> not really a big proponent of implementing some half-baked bogus mess >> extension, which is

Re: [Mesa-dev] [PATCH 1/2] mesa: don't set ES versions to GLSLVersion in _mesa_init_constants

2014-09-22 Thread Brian Paul
For both, Reviewed-by: Brian Paul On 09/19/2014 01:03 PM, Marek Olšák wrote: From: Marek Olšák No place in Mesa expects an ES version there. Drivers don't even set it like this. --- src/mesa/main/context.c | 12 ++-- src/mesa/main/mtypes.h | 2 +- 2 files changed, 3 insertions(

Re: [Mesa-dev] [PATCH 1/4] st/mesa: drop dependence on API profile in st_init_extensions

2014-09-22 Thread Brian Paul
This series looks good too. Reviewed-by: Brian Paul On 09/19/2014 01:08 PM, Marek Olšák wrote: From: Marek Olšák The extensions and limits being set in the conditional block are core-only anyway and don't have any effect on other profiles. --- src/mesa/state_tracker/st_context.c| 2 +

[Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Brian Paul
--- src/glsl/link_uniforms.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 258d279..a6683a0 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -749,7 +749,7 @@ link_update_uniform_buff

[Mesa-dev] [PATCH 3/3] gallium: update comment for enum pipe_format

2014-09-22 Thread Brian Paul
--- src/gallium/include/pipe/p_format.h |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/gallium/include/pipe/p_format.h b/src/gallium/include/pipe/p_format.h index b007229..3f505f2 100644 --- a/src/gallium/include/pipe/p_format.h +++ b/src/gallium/include/pipe/p_f

[Mesa-dev] [PATCH 2/3] gallium: replace pipe_type enum with tgsi_type enum

2014-09-22 Thread Brian Paul
The only place the enum pipe_type was used is for the TGSI sampler view return type. So make it a TGSI type. --- src/gallium/auxiliary/tgsi/tgsi_build.c|8 src/gallium/auxiliary/tgsi/tgsi_strings.c |3 ++- src/gallium/auxiliary/tgsi/tgsi_strings.h |2 +- src/gallium/aux

[Mesa-dev] [PATCH 1/3] tgsi: rename TGSI_TYPE_x -> TGSI_OPCODE_TYPE_x

2014-09-22 Thread Brian Paul
To avoid conflicts with coming TGSI_TYPE_x enums. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 26 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 57 ++-- src/gallium/auxiliary/tgsi/tgsi_info.c | 14 ++--- src/gallium/auxiliary/tgsi/tgs

[Mesa-dev] [PATCH 1/9] tgsi: add prolog() method to tgsi_transform_context

2014-09-22 Thread Brian Paul
Called when the user can insert new decls, instructions. This could be used in a few places in the 'draw' module. --- src/gallium/auxiliary/tgsi/tgsi_transform.c |7 +++ src/gallium/auxiliary/tgsi/tgsi_transform.h |6 ++ 2 files changed, 13 insertions(+) diff --git a/src/gallium/a

[Mesa-dev] [PATCH 7/9] draw: use new tgsi_transform inst/decl helpers in aaline code

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 87 ++--- 1 file changed, 21 insertions(+), 66 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aaline.c b/src/gallium/auxiliary/draw/draw_pipe_aaline.c index c8344dd..2f14efe 100644 --- a/src/gallium/auxilia

[Mesa-dev] [PATCH 9/9] draw: use new tgsi_transform inst/decl helpers in pstipple code

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_pipe_pstipple.c | 87 +-- 1 file changed, 19 insertions(+), 68 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_pstipple.c b/src/gallium/auxiliary/draw/draw_pipe_pstipple.c index 7ef86a6..8f21c46 100644 --- a/src/gallium/aux

[Mesa-dev] [PATCH 8/9] draw: use new tgsi_transform inst/decl helpers in aapoint code

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 256 +--- 1 file changed, 54 insertions(+), 202 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c b/src/gallium/auxiliary/draw/draw_pipe_aapoint.c index 3f2ef08..7feb49a 100644 --- a/src/gallium/auxi

[Mesa-dev] [PATCH 5/9] draw: use tgsi transform prolog callback in polygon stipple code

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_pipe_pstipple.c | 235 +++ 1 file changed, 110 insertions(+), 125 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_pstipple.c b/src/gallium/auxiliary/draw/draw_pipe_pstipple.c index d216787..7ef86a6 100644 --- a/src/gallium/a

[Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Brian Paul
We want to call the caller's epilog callback when we find the TGSI END instruction, not after it. --- src/gallium/auxiliary/tgsi/tgsi_transform.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.c b/src/gallium/au

[Mesa-dev] [PATCH 3/9] draw: use tgsi transform prolog/epilog callbacks in AA point code

2014-09-22 Thread Brian Paul
This simplifies the code and makes it a little easier to understand. --- src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 621 1 file changed, 316 insertions(+), 305 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c b/src/gallium/auxiliary/draw/dr

[Mesa-dev] [PATCH 6/9] tgsi: add inst/decl helpers for tgsi_transform utility

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/tgsi/tgsi_transform.h | 333 +++ 1 file changed, 333 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.h b/src/gallium/auxiliary/tgsi/tgsi_transform.h index 5ec0719..bfcdd56 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_transfo

[Mesa-dev] [PATCH 4/9] draw: use tgsi transform prolog/epilog callbacks in AA line code

2014-09-22 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 182 + 1 file changed, 92 insertions(+), 90 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aaline.c b/src/gallium/auxiliary/draw/draw_pipe_aaline.c index 8955762..c8344dd 100644 --- a/src/gallium/auxilia

[Mesa-dev] [PATCH] clover: Add support to mem objects for multiple destructor callbacks v2

2014-09-22 Thread Tom Stellard
The spec says that mem objects should maintain a stack of callbacks not just one. v2: - Remove stray printf. CC: "10.3" --- src/gallium/state_trackers/clover/core/memory.cpp | 10 ++ src/gallium/state_trackers/clover/core/memory.hpp | 3 ++- 2 files changed, 8 insertions(+), 5 deleti

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Alex Deucher
On Sat, Sep 20, 2014 at 6:11 AM, Marek Olšák wrote: > From: Marek Olšák > Looks good. Tom should probably take a look as well. As a further improvement, it would be nice to be able to use the compute rings for compute rather than gfx, but I'm not sure how much additional effort it would take t

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Add support to mem objects for multiple destructor callbacks v2

2014-09-22 Thread Francisco Jerez
Thanks, looks good to me, Reviewed-by: Francisco Jerez Tom Stellard writes: > The spec says that mem objects should maintain a stack of callbacks > not just one. > > v2: > - Remove stray printf. > > CC: "10.3" > --- > src/gallium/state_trackers/clover/core/memory.cpp | 10 ++ > src

[Mesa-dev] [Bug 82635] vmw_screen.h:100:4: error: unknown type name 'dev_t'

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82635 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 83381] dri_screen.c:72:10: error: expected '}'

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83381 --- Comment #1 from Emil Velikov --- Vinson is this a regression, can you bisect please ? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-22 Thread Glenn Kennard
On Wed, 17 Sep 2014 06:10:48 +0200, Alexandre Demers wrote: Tested with v3. I get the same result as before: everything is fine except the gs-atan-vec2 test. I don't know if this is of any value, but running the command manually in a shell gives the following: /home/ademers/projects/di

Re: [Mesa-dev] [PATCH 00/17] Split out aux/vl and makefiles de-duplication

2014-09-22 Thread Matt Turner
I reviewed one trivial patch and skimmed the others, which looked reasonable to me. Thanks Emil, have an Acked-by: Matt Turner for the test. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 61361] Version mismatch error. This is libtool 2.4.2, but the definition of this LT_INIT comes from libtool 2.2.8.

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61361 Emil Velikov changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 61415] Clover ignores --with-opencl-libdir path

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61415 Emil Velikov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 83636] [LLVM 3.5] Mesa32 build failure with LLVM 3.5.

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83636 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 65676] Piglit: port remaining glean tests to piglit framework

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65676 Emil Velikov changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |e...@anholt.net |org

[Mesa-dev] [Bug 58446] src/glsl/glcpp/imports.h:161: undefined reference to `sqrtf'

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58446 Emil Velikov changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Emil Velikov

Re: [Mesa-dev] [PATCH 2/3] gallium: replace pipe_type enum with tgsi_type enum

2014-09-22 Thread Roland Scheidegger
The series looks good to me, though could rename the (quite underused) pipe_type enum to tgsi_return_type instead and leave tgsi_type alone? Or for further clarity, rename both (to tgsi_opcode_type and tgsi_ret_type or something). Either way though looks ok to me. (That said, I don't understand wh

Re: [Mesa-dev] [PATCH 07/12] i965/fs: Use the var_from_vgrf helper function instead of doing it manually

2014-09-22 Thread Matt Turner
On Fri, Sep 19, 2014 at 8:14 PM, Jason Ekstrand wrote: > > > On Fri, Sep 19, 2014 at 5:16 PM, Matt Turner wrote: >> >> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand >> wrote: >> > Signed-off-by: Jason Ekstrand >> > --- >> > src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 10 >> > +

Re: [Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Roland Scheidegger
Do you want to call it at (outermost) RET opcode (if any) instead? tgsi is kinda undecided if there should be a ret opcode in main but sometimes there is... Roland Am 22.09.2014 17:44, schrieb Brian Paul: > We want to call the caller's epilog callback when we find the TGSI > END instruction, not

Re: [Mesa-dev] [PATCH 08/12] i965/fs: Make null_reg_* const members of fs_visitor instead of globals

2014-09-22 Thread Matt Turner
On Fri, Sep 19, 2014 at 8:16 PM, Jason Ekstrand wrote: > > > On Fri, Sep 19, 2014 at 5:37 PM, Matt Turner wrote: >> >> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand >> wrote: >> > We also set the register width equal to the dispatch width. Right now, >> > this is effectively a no-op since we

[Mesa-dev] [PATCH] clover: Add support to mem objects for multiple destructor callbacks

2014-09-22 Thread Tom Stellard
The spec says that mem objects should maintain a stack of callbacks not just one. CC: "10.3" --- src/gallium/state_trackers/clover/core/memory.cpp | 11 +++ src/gallium/state_trackers/clover/core/memory.hpp | 3 ++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/gall

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Niels Ole Salscheider
On Monday 22 September 2014, 12:16:13, Alex Deucher wrote: > On Sat, Sep 20, 2014 at 6:11 AM, Marek Olšák wrote: > > From: Marek Olšák > > Looks good. Tom should probably take a look as well. As a further > improvement, it would be nice to be able to use the compute rings for > compute rather

[Mesa-dev] [Bug 57702] Eliminate RTLD_GLOBAL glapi hacks after removing support for static libglapi

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57702 --- Comment #1 from Emil Velikov --- I'm do not thing the lack of explicit link is our biggest issue. Afaick we aim to preserve compatibility different versions of mesa and the xserver. Up-to recently the server the second provider for those _gl

[Mesa-dev] [Bug 38906] Mesa compilation failure if libudev development files are not installed.

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38906 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 48833] dri library path issue

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48833 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [RFC PATCH 1/4] mesa: Unifdef _XBOX.

2014-09-22 Thread Matt Turner
Inexplicably added in commit 36940429. --- src/mesa/main/imports.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c index 4afe156..b18603c 100644 --- a/src/mesa/main/imports.c +++ b/src/mesa/main/imports.c @@ -532,7 +532,7 @@ _me

[Mesa-dev] [RFC PATCH 3/4] mesa: Drop _mesa_bsearch() wrapper.

2014-09-22 Thread Matt Turner
--- src/mapi/glapi/gen/gl_enums.py | 8 src/mesa/main/imports.c| 17 - src/mesa/main/imports.h| 4 3 files changed, 4 insertions(+), 25 deletions(-) diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py index 0214932..35919d6

[Mesa-dev] [RFC PATCH 2/4] mesa: Unifdef _WIN32_WCE.

2014-09-22 Thread Matt Turner
--- José: if you guys don't care about WinCE anymore, this will let us drop two wrapper functions (bsearch, getenv). src/gallium/auxiliary/util/u_snprintf.c | 9 - src/gallium/state_trackers/egl/x11/glcore.h | 2 -- src/mapi/glapi/gen/gl_gentable.py | 2 +- src/mapi

[Mesa-dev] [RFC PATCH 4/4] mesa: Drop _mesa_getenv() wrapper.

2014-09-22 Thread Matt Turner
--- src/gallium/state_trackers/glx/xlib/glx_api.c | 20 ++-- src/gallium/state_trackers/glx/xlib/xm_api.c | 4 ++-- src/mesa/drivers/x11/fakeglx.c| 20 ++-- src/mesa/drivers/x11/xm_api.c | 8 src/mesa/main/context.c

[Mesa-dev] [Bug 54431] [build errors] (.text+0x324): undefined reference to `dlopen'

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54431 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 19479] driCreateConfigs crashes Mesa compilation

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=19479 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 38688] Mesa 7.10.3 FTBFS (because libdrm?)

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38688 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Ian Romanick
This seems fine. But I don't get a warning here, and that seems a little odd. I'm a pretty old GCC... 4.7.2. What are you on? Either way, this patch is Reviewed-by: Ian Romanick On 09/22/2014 08:44 AM, Brian Paul wrote: > --- > src/glsl/link_uniforms.cpp |2 +- > 1 file changed, 1 inser

Re: [Mesa-dev] [RFC PATCH 1/4] mesa: Unifdef _XBOX.

2014-09-22 Thread Ian Romanick
Assuming the VMware folks are okay with dropping WinCE support, this series is Reviewed-by: Ian Romanick On 09/22/2014 11:22 AM, Matt Turner wrote: > Inexplicably added in commit 36940429. > --- > src/mesa/main/imports.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[Mesa-dev] [Bug 47193] can't statically link libglsl and libdricore into drivers

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47193 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/9] draw: use tgsi transform prolog/epilog callbacks in AA point code

2014-09-22 Thread Charmaine Lee
This series looks good. One nit below. >From: mesa-dev on behalf of Brian >Paul >Sent: Monday, September 22, 2014 8:44 AM >To: mesa-dev@lists.freedesktop.org >Subject: [Mesa-dev] [PATCH 3/9] draw: use tgsi transform prolog/epilog >callbacks in AA point code >This simplifies the code and make

[Mesa-dev] [Bug 58925] compis/kwin crashes on nouveau due to msaa

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58925 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2] replace file specific compiler optimization with inline attibute

2014-09-22 Thread Matt Turner
On Fri, Sep 12, 2014 at 4:56 AM, Marc Dietrich wrote: > File specific optimization as used for src/mesa/main/streaming-load-memcpy.c > currently will cause problems with LTO in the future > (see: https://bugs.freedesktop.org/show_bug.cgi?id=83669). Replace it with > in-file target specification. >

[Mesa-dev] [Bug 58446] src/glsl/glcpp/imports.h:161: undefined reference to `sqrtf'

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58446 --- Comment #2 from Ian Romanick --- Looking at the website, it doesn't seem like there has been much activity since 2011. This seems like it's either a bug in Open64 or we need more Open64-specific support in Mesa's build system. My preference

[Mesa-dev] [PATCH 04/12] ralloc: Mark ralloc functions with gcc's malloc attribute.

2014-09-22 Thread Matt Turner
Cuts a few hundred bytes from the DRI drivers, so it must give gcc some extra information. --- configure.ac | 1 + src/util/macros.h | 6 ++ src/util/ralloc.h | 16 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 0aec6eb

[Mesa-dev] [PATCH 02/12] mesa: Replace a priori knowledge of gcc builtins with configure tests.

2014-09-22 Thread Matt Turner
Presumbly this will let clang and other compilers use the built-ins as well. Notice two changes specifically: - in _mesa_next_pow_two_64(), always use __builtin_clzll and add a static assertion that this is safe. - in macros.h, remove the clang-specific definition since it should b

[Mesa-dev] [PATCH 01/12] mesa: Use realloc() instead of _mesa_realloc() and remove the latter.

2014-09-22 Thread Matt Turner
--- src/gallium/state_trackers/glx/xlib/glx_api.c | 3 +-- src/mesa/drivers/x11/fakeglx.c| 3 +-- src/mesa/main/imports.c | 14 -- src/mesa/main/imports.h | 3 --- src/mesa/main/shaderapi.c | 5 ++--- s

[Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Matt Turner
Note that I had to add support for testing the packed attribute to m4/ax_gcc_func_attribute.m4. --- configure.ac | 4 + m4/ax_gcc_func_attribute.m4| 223 + src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 - src/ut

[Mesa-dev] [PATCH 05/12] mesa: Consolidate used/visibility function attributes.

2014-09-22 Thread Matt Turner
And check for them in configure. --- configure.ac | 2 ++ src/mapi/u_compiler.h| 11 --- src/mesa/main/compiler.h | 20 src/util/macros.h| 14 ++ 4 files changed, 16 insertions(+), 31 deletions(-) diff --git a/configure.ac b/config

[Mesa-dev] [PATCH 06/12] mesa: Consolidate likely/unlikely macros.

2014-09-22 Thread Matt Turner
--- src/gallium/include/pipe/p_compiler.h | 45 +-- src/mapi/u_compiler.h | 10 --- src/mesa/drivers/dri/i915/intel_context.h | 10 --- src/util/macros.h | 32 ++ 4 files changed, 33 insertions(

[Mesa-dev] [PATCH 07/12] configure.ac: Use test -a, rather than another test.

2014-09-22 Thread Matt Turner
--- configure.ac | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 2fe1539..3f4fbca 100644 --- a/configure.ac +++ b/configure.ac @@ -477,7 +477,7 @@ asm_arch="" AC_MSG_CHECKING([whether to enable assembly]) test "x$enab

[Mesa-dev] [PATCH 12/12] configure.ac: Replace gallium_check_st with gallium_require_drm.

2014-09-22 Thread Matt Turner
--- configure.ac | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/configure.ac b/configure.ac index 60b2164..1219a80 100644 --- a/configure.ac +++ b/configure.ac @@ -1810,7 +1810,7 @@ AC_SUBST([OPENCL_LIB_INSTALL_DIR]) dnl dnl Gallium helper functions

[Mesa-dev] [PATCH 08/12] configure.ac: Stop checking for perl.

2014-09-22 Thread Matt Turner
Added by commit a75c6163, but no longer used. --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 3f4fbca..fe96e7a 100644 --- a/configure.ac +++ b/configure.ac @@ -70,8 +70,6 @@ AX_PROG_FLEX([], AS_IF([test ! -f "$srcdir/src/glsl/gl

[Mesa-dev] [PATCH 09/12] configure.ac: Use autoconf macro for GNU make.

2014-09-22 Thread Matt Turner
--- configure.ac| 2 +- m4/ax_check_gnu_make.m4 | 78 + 2 files changed, 79 insertions(+), 1 deletion(-) create mode 100644 m4/ax_check_gnu_make.m4 diff --git a/configure.ac b/configure.ac index fe96e7a..ebe329b 100644 --- a/configure.

[Mesa-dev] [PATCH 11/12] configure.ac: Drop gallium directory tracking.

2014-09-22 Thread Matt Turner
Was only tracked to be printed at the end of configure, but configure quits if it can't build something we requested, rather than silently dropping it, so printing these directories has little use. --- I don't build gallium drivers often, so perhaps I'm not a good judge of whether this is useful.

[Mesa-dev] [PATCH 10/12] configure.ac: Remove duplicate -DHAVE_PTHREAD.

2014-09-22 Thread Matt Turner
It's also defined by the AX_PTHREAD macro. --- configure.ac | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index ebe329b..071b32c 100644 --- a/configure.ac +++ b/configure.ac @@ -169,13 +169,13 @@ DEFINES="-DUSE_EXTERNAL_DXTN_LIB=1" AC_SUB

Re: [Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Brian Paul
g++ 4.8.2 warns on this. -Brian On 09/22/2014 12:41 PM, Ian Romanick wrote: This seems fine. But I don't get a warning here, and that seems a little odd. I'm a pretty old GCC... 4.7.2. What are you on? Either way, this patch is Reviewed-by: Ian Romanick On 09/22/2014 08:44 AM, Brian Paul

Re: [Mesa-dev] [RFC PATCH 2/4] mesa: Unifdef _WIN32_WCE.

2014-09-22 Thread Jose Fonseca
I don't think we (at VMware) care for WinCE support anymore. Series looks good to me. Jose From: Matt Turner Sent: 22 September 2014 19:22 To: mesa-dev@lists.freedesktop.org Cc: Jose Fonseca; Matt Turner Subject: [RFC PATCH 2/4] mesa: Unifdef _WIN32_WCE.

[Mesa-dev] [Bug 59879] reducing symbol visibility of shared objects / static libstdc++

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59879 --- Comment #3 from Emil Velikov --- The issue here is that while -static-libstdc++ should work for both executables and libraries and gcc is smart enough to understand it, libtool is not :\ The latter essentially ignores the switch and always e

Re: [Mesa-dev] [RFC PATCH 2/4] mesa: Unifdef _WIN32_WCE.

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 11:56 AM, Jose Fonseca wrote: > I don't think we (at VMware) care for WinCE support anymore. > > Series looks good to me. Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

[Mesa-dev] [Bug 62027] [build error] ln: accessing `.libs/libdricore9.0.3.so.1.0.0': No such file or directory

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62027 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 65420] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 04/12] ralloc: Mark ralloc functions with gcc's malloc attribute.

2014-09-22 Thread Ian Romanick
Should we also add __attribute__(alloc_size(2)) to these functions? On 09/22/2014 11:51 AM, Matt Turner wrote: > Cuts a few hundred bytes from the DRI drivers, so it must give gcc some > extra information. > --- > configure.ac | 1 + > src/util/macros.h | 6 ++ > src/util/ralloc.h | 16

Re: [Mesa-dev] [PATCH 06/12] mesa: Consolidate likely/unlikely macros.

2014-09-22 Thread Jason Ekstrand
On Mon, Sep 22, 2014 at 11:51 AM, Matt Turner wrote: > --- > src/gallium/include/pipe/p_compiler.h | 45 > +-- > src/mapi/u_compiler.h | 10 --- > src/mesa/drivers/dri/i915/intel_context.h | 10 --- > src/util/macros.h

Re: [Mesa-dev] [PATCH 2/3] gallium: replace pipe_type enum with tgsi_type enum

2014-09-22 Thread Brian Paul
The only real purpose to this patch series was to clean up some type cross-contamination I found between TGSI and p_formats.h (actually, I found and patched this a few months ago but only rediscovered it this weekend). I think the purpose of the return type is to know if the sampler returns f

Re: [Mesa-dev] [PATCH 01/12] mesa: Use realloc() instead of _mesa_realloc() and remove the latter.

2014-09-22 Thread Ian Romanick
Patches 1 through 8 and 10 are Reviewed-by: Ian Romanick I don't grok the others well enough to say anything about them. On 09/22/2014 11:50 AM, Matt Turner wrote: > --- > src/gallium/state_trackers/glx/xlib/glx_api.c | 3 +-- > src/mesa/drivers/x11/fakeglx.c| 3 +-- > src/me

[Mesa-dev] [Bug 70766] Run-time link error in swrast_dri.so

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70766 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 81785] MESA checks on configure for llvm 3.4.2 and fails to build with 3.4.2 being installed

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81785 Emil Velikov changed: What|Removed |Added CC||ahartm...@gmail.com --- Comment #11 from

[Mesa-dev] [Bug 73934] Function roundf undeclared in textparam.c when building with MSVC11

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73934 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 06/12] mesa: Consolidate likely/unlikely macros.

2014-09-22 Thread Jason Ekstrand
I won't claim to have reviewed the automake bits and I haven't built it. However, the C bits in 2, 3, 5, and 6 are Reviewed-by: Jason Ekstrand < jason.ekstr...@intel.com> On Mon, Sep 22, 2014 at 12:13 PM, Jason Ekstrand wrote: > > > On Mon, Sep 22, 2014 at 11:51 AM, Matt Turner wrote: > >> ---

[Mesa-dev] [PATCH 4/4] configure: use explicit enabled/disabled in config switch description

2014-09-22 Thread Emil Velikov
Rather than having double negatives -> disable-opencl, default=no simply use enabled/disabled. It makes things a bit easier for the reader and consistent throughout the file. Signed-off-by: Emil Velikov --- configure.ac | 24 1 file changed, 12 insertions(+), 12 deletion

[Mesa-dev] [PATCH 2/4] configure: drop --with-egl-driver-dir switch

2014-09-22 Thread Emil Velikov
The location of the egl driver(s) is matter that we should have never exposed to the user. Currently the dri2 driver is built into the libEGL loader, with the gallium based one soon to follow. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80615 Signed-off-by: Emil Velikov --- configure.

[Mesa-dev] [PATCH 3/4] configure: ask vdpau.pc for the default location of the vdpau drivers

2014-09-22 Thread Emil Velikov
Rather than using hardcoded values honor the value set at libvdpau build time - i.e. the moduledir variable from vdpau.pc Update the omx description to match reality while we're here. Cc: Christian König Cc: Alexandre Demers Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80615 Signed-of

[Mesa-dev] [Bug 77240] khrplatform.h not installed if EGL is disabled

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77240 --- Comment #2 from Ian Romanick --- GLX_EXT_create_context_es2_profile :) -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedeskto

[Mesa-dev] [PATCH 1/4] configure: remove non-functional --with-opencl-libdir

2014-09-22 Thread Emil Velikov
The parameter used to control where the gallium pipe-drivers were installed, but was broken since commit 45270fb0fd1abd7619933c2845f9dc74cdfbe6fd Author: Matt Turner Date: Thu Sep 13 10:45:01 2012 -0700 targets/pipe-loader: Convert to automake Considering that nowadays the pipe-drivers ca

Re: [Mesa-dev] [PATCH 06/12] mesa: Consolidate likely/unlikely macros.

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 12:13 PM, Jason Ekstrand wrote: > > > On Mon, Sep 22, 2014 at 11:51 AM, Matt Turner wrote: >> >> --- >> src/gallium/include/pipe/p_compiler.h | 45 >> +-- >> src/mapi/u_compiler.h | 10 --- >> src/mesa/drivers/dri/i9

[Mesa-dev] [Bug 80615] Files in bellagio directory [omx tracker] don't respect installation folder

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80615 --- Comment #8 from Emil Velikov --- Just sent out a few patches which should address all the points raised. Feel free to give them a try :) http://patchwork.freedesktop.org/patch/33915/ http://patchwork.freedesktop.org/patch/33916/ http://patch

Re: [Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Brian Paul
Good point, but as it is this follows the convention that's been working all along so far. I can add a comment about looking for the final RET in the future. -Brian On 09/22/2014 11:50 AM, Roland Scheidegger wrote: Do you want to call it at (outermost) RET opcode (if any) instead? tgsi is ki

  1   2   >