This seems fine. But I don't get a warning here, and that seems a
little odd. I'm a pretty old GCC... 4.7.2. What are you on?
Either way, this patch is
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
On 09/22/2014 08:44 AM, Brian Paul wrote:
> ---
> src/glsl/link_uniforms.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
> index 258d279..a6683a0 100644
> --- a/src/glsl/link_uniforms.cpp
> +++ b/src/glsl/link_uniforms.cpp
> @@ -749,7 +749,7 @@ link_update_uniform_buffer_variables(struct gl_shader
> *shader)
> if (end == NULL)
> continue;
>
> - if (l != (end - begin))
> + if ((ptrdiff_t) l != (end - begin))
> continue;
>
> if (strncmp(var->name, begin, l) == 0) {
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
