This series looks good. One nit below. >From: mesa-dev <mesa-dev-boun...@lists.freedesktop.org> on behalf of Brian >Paul <bri...@vmware.com> >Sent: Monday, September 22, 2014 8:44 AM >To: mesa-dev@lists.freedesktop.org >Subject: [Mesa-dev] [PATCH 3/9] draw: use tgsi transform prolog/epilog >callbacks in AA point code
>This simplifies the code and makes it a little easier to understand. >--- > src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 621 ++++++++++++------------ > 1 file changed, 316 insertions(+), 305 deletions(-) >diff --git a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c >b/src/gallium/auxiliary/draw/draw_pipe_aapoint.c ... > >+/** >+ * TGSI transform callback. >+ * Insert new instructions before the END instruction. >+ */ >+static void >+aa_transform_epilog(struct tgsi_transform_context *ctx) >+{ >+ /* emit our new declarations before the first instruction */ Please remove this comment. It's not relevant in aa_transform_epilog. Reviewed-by: Charmaine Lee <charmai...@vmware.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=iVNYIcCaC9TDvyNBQU%2F5q5NVsC01tSgJb3oX27T14ck%3D%0A&m=WgIxyFTTxM%2BE0jPoNIA%2BgSV62SjHkS7A3w%2B0jxpKY08%3D%0A&s=c72fc3620bd437c978970304ed52bb176594a46d3730767e9ed7af9bb3374354 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev