Re: [Mesa-dev] [PATCH] st/omx: keep the name, (name|role)_specific strings dynamically allocated

2014-06-27 Thread Christian König
Am 26.06.2014 18:45, schrieb Emil Velikov: ... as it's caller (the external program omxregister-bellagio) is the one who frees all of the allocated memory. Cc: Pedretti Fabio Reported-by: Pedretti Fabio Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/state_trac

[Mesa-dev] [PATCH] egl/gallium: implemlent EGL_KHR_create_context v3

2014-06-27 Thread Knut Andre Tidemann
v2: fix style and wrong major version comparison. v3: fix version check in context creation. --- src/gallium/state_trackers/egl/common/egl_g3d.c | 1 + src/gallium/state_trackers/egl/common/egl_g3d_api.c | 12 2 files changed, 13 insertions(+) diff --git a/src/gallium/state_trac

[Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Chris Forbes
If another layout qualifier appeared to the left of `invocations` in the GS input layout declaration, the invocation count would be dropped on the floor. Fixes the piglit test: spec/ARB_transform_feedback3/arb_transform_feedback3-ext_interleaved_two_bufs_gs_max Signed-off-by: Chris Forbes Cc: I

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Eric Anholt
Jason Ekstrand writes: > Right now, the Intel driver is the only driver in mesa that implements this > extension. Is anyone using this? Is it ok if we purge it? I'm doing some > work on the texture format code and DUDV8 is an ugly special case. My list of extensions used by old apps doesn't h

Re: [Mesa-dev] [PATCH] dri/xmlconfig: remove GL types.

2014-06-27 Thread Eric Anholt
Dave Airlie writes: > This just drops all the GL types from the xmlconfig and use > std C types from stdint and stdbool. Reviewed-by: Eric Anholt pgp0r3IlSS0ay.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Brian Paul
On 06/26/2014 06:39 PM, Ian Romanick wrote: On 06/26/2014 05:30 PM, Jason Ekstrand wrote: Right now, the Intel driver is the only driver in mesa that implements Also as far as we can tell... it's the only driver that implements it. git-blame says that VMware added it a long time ago... bef

Re: [Mesa-dev] [PATCH 0/8] gallium: add support for multiple vertex streams

2014-06-27 Thread Marek Olšák
Patches 1-5: Reviewed-by: Marek Olšák Marek On Fri, Jun 27, 2014 at 6:40 AM, Ilia Mirkin wrote: > This patch series is enough for xfb-streams to pass on a GK107 card. Haven't > done much more testing than that. > > The mesa/st bits apply on top of Iago's v2 23-patch series, all the other > pat

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Roland Scheidegger
Am 27.06.2014 14:39, schrieb Brian Paul: > On 06/26/2014 06:39 PM, Ian Romanick wrote: >> On 06/26/2014 05:30 PM, Jason Ekstrand wrote: >>> Right now, the Intel driver is the only driver in mesa that implements >> >> Also as far as we can tell... it's the only driver that implements it. >> git-blam

Re: [Mesa-dev] [PATCH 2/8] gallium: add support for stream in so info

2014-06-27 Thread Brian Paul
On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/drivers/trace/tr_dump_state.c | 1 + src/gallium/include/pipe/p_state.h | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 1/8] gallium: add vertex stream argument to EMIT/ENDPRIM

2014-06-27 Thread Brian Paul
On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 4 ++-- src/gallium/docs/source/tgsi.rst | 8 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Brian Paul
On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- src/gallium/drivers/freedreno/freedreno_query.c | 2 +- src/gallium/drivers/galahad/glhd_context.c | 6 -- src/gallium/drivers/i915/i

Re: [Mesa-dev] [PATCH 5/8] mesa/st: add vertex stream support

2014-06-27 Thread Brian Paul
On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_cb_queryobj.c| 2 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_queryobj.c b/

Re: [Mesa-dev] [PATCH 4/8] gallium: add a cap for max vertex streams

2014-06-27 Thread Brian Paul
On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Ilia Mirkin
On Fri, Jun 27, 2014 at 9:31 AM, Brian Paul wrote: > On 06/26/2014 10:40 PM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- >> src/gallium/drivers/freedreno/freedreno_query.c | 2 +- >> src/gallium/drivers/ga

Re: [Mesa-dev] [PATCH 4/8] gallium: add a cap for max vertex streams

2014-06-27 Thread Ilia Mirkin
On Fri, Jun 27, 2014 at 9:31 AM, Brian Paul wrote: > On 06/26/2014 10:40 PM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/docs/source/screen.rst | 2 ++ >> src/gallium/drivers/freedreno/freedreno_screen.c | 1 + >> src/gallium/drivers/i915/i915_scree

Re: [Mesa-dev] [PATCH 4/8] gallium: add a cap for max vertex streams

2014-06-27 Thread Brian Paul
On 06/27/2014 07:37 AM, Ilia Mirkin wrote: On Fri, Jun 27, 2014 at 9:31 AM, Brian Paul wrote: On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Brian Paul
On 06/27/2014 07:34 AM, Ilia Mirkin wrote: On Fri, Jun 27, 2014 at 9:31 AM, Brian Paul wrote: On 06/26/2014 10:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- src/gallium/drivers/freedreno/freedreno_query.c |

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Roland Scheidegger
Am 27.06.2014 06:40, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- > src/gallium/drivers/freedreno/freedreno_query.c | 2 +- > src/gallium/drivers/galahad/glhd_context.c | 6 -- > src/gallium/drivers/i

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Ilia Mirkin
On Fri, Jun 27, 2014 at 9:56 AM, Roland Scheidegger wrote: > Am 27.06.2014 06:40, schrieb Ilia Mirkin: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- >> src/gallium/drivers/freedreno/freedreno_query.c | 2 +- >> src/gallium/drivers/g

Re: [Mesa-dev] [PATCH 3/9] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

2014-06-27 Thread Ilia Mirkin
On Mon, Jun 16, 2014 at 7:51 PM, Marek Olšák wrote: > Since LLVM 3.5 will be released in August and my radeon patches adding > ARB_draw_indirect depend on it, I will commit ARB_draw_indirect > support for Gallium with softpipe and llvmpipe support earlier. My > plan is for patches 3,4,5,6 to get c

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Marek Olšák
FWIW, I prefer adding an "index" to create_query. Marek On Fri, Jun 27, 2014 at 4:11 PM, Ilia Mirkin wrote: > On Fri, Jun 27, 2014 at 9:56 AM, Roland Scheidegger > wrote: >> Am 27.06.2014 06:40, schrieb Ilia Mirkin: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/gallium/auxiliary/hud/hud_dri

Re: [Mesa-dev] [PATCH 3/9] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

2014-06-27 Thread Tom Stellard
On Tue, Jun 17, 2014 at 01:51:10AM +0200, Marek Olšák wrote: > Since LLVM 3.5 will be released in August and my radeon patches adding Which LLVM patches are required for ARB_draw_indirect? -Tom > ARB_draw_indirect depend on it, I will commit ARB_draw_indirect > support for Gallium with softpipe

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Connor Abbott
On Jun 26, 2014 5:30 PM, "Jason Ekstrand" wrote: > > Right now, the Intel driver is the only driver in mesa that implements this extension. Is anyone using this? Is it ok if we purge it? I'm doing some work on the texture format code and DUDV8 is an ugly special case. > Thanks, > --Jason Ekstra

Re: [Mesa-dev] [PATCH 22/23] glsl/glcpp: Add a catch-all rule for unexpected characters.

2014-06-27 Thread Kristian Høgsberg
On Thu, Jun 26, 2014 at 3:19 PM, Carl Worth wrote: > In some of the recent glcpp bug-fixing, we found that glcpp was emitting > unrecognized characters from the input source file to stdout, and dropping > them from the source passed onto the compiler proper. > > This was obviously confusing, and t

Re: [Mesa-dev] [PATCH 22/23] glsl/glcpp: Add a catch-all rule for unexpected characters.

2014-06-27 Thread Kristian Høgsberg
On Fri, Jun 27, 2014 at 9:11 AM, Kristian Høgsberg wrote: > On Thu, Jun 26, 2014 at 3:19 PM, Carl Worth wrote: >> In some of the recent glcpp bug-fixing, we found that glcpp was emitting >> unrecognized characters from the input source file to stdout, and dropping >> them from the source passed o

Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

2014-06-27 Thread Ilia Mirkin
Iago, Not sure where you are with these patches... I guess some updates have been requested to rename stream -> index in some places? Anyways, once the generic bits are all sorted out and reviewed, I'd appreciate it if they could be pushed out, even if you're still working out hw-related issues wi

Re: [Mesa-dev] [PATCH] dispatch: Do not generate extraneous parentheses.

2014-06-27 Thread Chad Versace
On Thu, Jun 26, 2014 at 10:24:44PM -0700, Vinson Lee wrote: > This patch fixes 592 clang parentheses-equality warnings on Fedora 20. > > Signed-off-by: Vinson Lee > --- > tests/util/piglit-dispatch-gen.c.mako | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) Thanks.

[Mesa-dev] [PATCH] i965: Extend compute-to-mrf pass to understand blocks of MOVs

2014-06-27 Thread Kristian Høgsberg
From: Kristian Høgsberg The current compute-to-mrf pass doesn't handle blocks of MOVs. Shaders that end with a texture fetch follwed by an fb write are left like this: 0x: pln(8) g6<1>F g4<0,1,0>F g2<8,8,1>F { align1 WE_normal 1Q compacted }; 0x0008: pln

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-27 Thread Emil Velikov
On 17/06/14 19:38, Emil Velikov wrote: > Hi all, > > As a follow up to the static/shared pipe-drivers series here is the final > series (if anyone is interested I may take a look at egl + opencl) of > refactoring the gallium dri targets into a single library/provider. > > In a nutshell: > - Conv

Re: [Mesa-dev] [PATCH v3] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-27 Thread Chris Forbes
Reviewed-by: Chris Forbes On Thu, Jun 26, 2014 at 6:24 PM, Iago Toral Quiroga wrote: > So far we have been using CL_INVOCATION_COUNT to resolve this query but this > is no good with streams, as only stream 0 reaches the clipping stage. Instead > we will use SO_PRIM_STORAGE_NEEDED which can keep

Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

2014-06-27 Thread Chris Forbes
Ilia, That bikeshed is already done :) I just send an r-b for v3 of patch 18, which is the last patch that lacked one. I think this is all good to land now. -- Chris On Sat, Jun 28, 2014 at 5:11 AM, Ilia Mirkin wrote: > Iago, > > Not sure where you are with these patches... I guess some updat

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Jason Ekstrand
Thanks, Connor. On that note... On Fri, Jun 27, 2014 at 8:48 AM, Connor Abbott wrote: > > On Jun 26, 2014 5:30 PM, "Jason Ekstrand" wrote: > > > > Right now, the Intel driver is the only driver in mesa that implements > this extension. Is anyone using this? Is it ok if we purge it? I'm doi

[Mesa-dev] [Bug 80614] New: [regression] Error in `omxregister-bellagio': munmap_chunk(): invalid pointer: 0x00007f5f76626dab

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80614 Priority: medium Bug ID: 80614 Assignee: mesa-dev@lists.freedesktop.org Summary: [regression] Error in `omxregister-bellagio': munmap_chunk(): invalid pointer: 0x7f5f76626dab

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

2014-06-27 Thread Matt Turner
On Fri, Jun 27, 2014 at 3:19 PM, Jason Ekstrand wrote: > include/GL/glext.h | 22 --- This file comes from Khronos. Don't modify it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Ilia Mirkin
On Fri, Jun 27, 2014 at 5:21 AM, Chris Forbes wrote: > If another layout qualifier appeared to the left of `invocations` in the > GS input layout declaration, the invocation count would be dropped on > the floor. > > Fixes the piglit test: > > spec/ARB_transform_feedback3/arb_transform_feedback3-e

Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Chris Forbes
Also fixes spec/ARB_gpu_shader5/execution/invocations-conflicting Apparently my baseline... wasnt. On Sat, Jun 28, 2014 at 11:18 AM, Ilia Mirkin wrote: > On Fri, Jun 27, 2014 at 5:21 AM, Chris Forbes wrote: >> If another layout qualifier appeared to the left of `invocations` in the >> GS input

[Mesa-dev] [Bug 80614] [regression] Error in `omxregister-bellagio': munmap_chunk(): invalid pointer: 0x00007f5f76626dab

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80614 --- Comment #1 from Emil Velikov --- Commit c35cf3400f5 removed a few calloc's that were required, so I've added them back with a001ca98e15. Yet I do not see how this issue can occur. Can you attach a backtrace of the issue ? I cannot seem to re

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

2014-06-27 Thread Emil Velikov
On 27/06/14 23:19, Jason Ekstrand wrote: > As far as I can tell, the Intel mesa driver is the only driver in the world > still supporting this legacy extension. If someone wants to do bump > mapping, they can use shaders. > --- > include/GL/gl_mangle.h | 4 - > include/

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

2014-06-27 Thread Chris Forbes
On Sat, Jun 28, 2014 at 10:19 AM, Jason Ekstrand wrote: > @@ -653,135 +613,6 @@ _swrast_texture_span( struct gl_context *ctx, SWspan > *span ) [snip] > - > - /* > -* Must do all texture sampling before combining in order to > -* accomodate GL_ARB_texture_env_crossbar. > -*/ > -

[Mesa-dev] [Bug 80615] New: Files in bellagio directory [omx tracker] don't respect installation folder

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80615 Priority: medium Bug ID: 80615 Assignee: mesa-dev@lists.freedesktop.org Summary: Files in bellagio directory [omx tracker] don't respect installation folder Severity: normal

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

2014-06-27 Thread Jason Ekstrand
On Fri, Jun 27, 2014 at 5:41 PM, Chris Forbes wrote: > On Sat, Jun 28, 2014 at 10:19 AM, Jason Ekstrand > wrote: > > > @@ -653,135 +613,6 @@ _swrast_texture_span( struct gl_context *ctx, > SWspan *span ) > [snip] > > > - > > - /* > > -* Must do all texture sampling before combining in orde

[Mesa-dev] [Bug 80615] Files in bellagio directory [omx tracker] don't respect installation folder

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80615 --- Comment #1 from Alexandre Demers --- Created attachment 101899 --> https://bugs.freedesktop.org/attachment.cgi?id=101899&action=edit make -n install result omx tracker doesn't respect specified installation folder. Look for bellagio VS any

[Mesa-dev] [Bug 80615] Files in bellagio directory [omx tracker] don't respect installation folder

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80615 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/8] gallium: add a stream argument to create_query

2014-06-27 Thread Roland Scheidegger
So I guess it's an index then. It's just slightly more code to adjust that's all :-). Roland Am 27.06.2014 16:54, schrieb Marek Olšák: > FWIW, I prefer adding an "index" to create_query. > > Marek > > On Fri, Jun 27, 2014 at 4:11 PM, Ilia Mirkin wrote: >> On Fri, Jun 27, 2014 at 9:56 AM, Rolan

[Mesa-dev] [PATCH 2/2] i965: Add initial support for ARB_copy_image

2014-06-27 Thread Jason Ekstrand
This adds very basic support of ARB_copy_image but does not quite handle all of the cases. It works as long as neither target is multisampled and the texture pitch is less than INT16_MAX. Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dr

[Mesa-dev] [PATCH 1/2] Add GL API support for ARB_copy_image

2014-06-27 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/gl_API.xml | 2 +- src/mapi/glapi/gen/gl_genexec.py | 1 + src/mesa/Makef

[Mesa-dev] [PATCH 0/2] Add initial support for GL_ARB_copy_image

2014-06-27 Thread Jason Ekstrand
This series adds initial support for GL_ARB_copy_image inside the intel driver. Currently, mipmap and extremely large textures are not supported due to constraints on the blitter hardware. We can work around that and I hope to get it solved soon. However, I'd like to get these on the list so the

[Mesa-dev] [PATCH v2 3/9] gallium: add an index argument to create_query

2014-06-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- v1 -> v2: - change new argument name from 'stream' to 'index' - update docs src/gallium/auxiliary/hud/hud_driver_query.c | 6 +++--- src/gallium/docs/source/context.rst | 4 src/gallium/drivers/freedreno/fr

[Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-06-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Brian Paul --- v1 -> v2: - add an assert to make sure it's <= 4 - add a note in docs about expected values src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/g

[Mesa-dev] [Bug 80614] [regression] Error in `omxregister-bellagio': munmap_chunk(): invalid pointer: 0x00007f5f76626dab

2014-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80614 --- Comment #2 from yas...@windowslive.com --- (In reply to comment #1) > Commit c35cf3400f5 removed a few calloc's that were required, so I've added > them back with a001ca98e15. Yet I do not see how this issue can occur. > > Can you attach a ba