[Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

We need to emit depth stall flushes before depth and hiz resolves. Placing them at the top of blorp's state emission fixes the hang. Fixes HiZ hang in the new WebGL Google maps on Sandybridge Chrome OS. Tested by zooming in and out continuously for 2 hours. This patch is based on https://chromium

[Mesa-dev] [PATCH 07/42] i965/blorp: unit test compiling msaa-8 cms to cms

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 62 ++ 1 file changed, 62 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index 29f815c..5d49ace 10

[Mesa-dev] Blorp blit compiler to use FS LIR

This is a rather long series but I suspect it will be eventually squashed into fewer patches. The motivation for the work is to prepare for gen8 blorp support. Currently the compiler for the blorp blit programs is written to emit EU-level instructions directly. This is not a big deal at the time b

[Mesa-dev] [PATCH 06/42] i965/blorp: unit test compiling msaa-8 ums to cms

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index d48c3db..29f815c 10

[Mesa-dev] [PATCH 14/42] i965/blorp: unit test compiling simple gen6 zero-src sampled

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index ec590ed..1545148 10

[Mesa-dev] [PATCH 13/42] i965/blorp: unit test compiling gen6 msaa-8 cms alpha blend

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 57 ++ 1 file changed, 57 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index fb9a60a..ec590ed 10

[Mesa-dev] [PATCH 09/42] i965/blorp: unit test compiling msaa-8 cms alpha blend

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 145 + 1 file changed, 145 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index fa6b53d..9692ce4 1

[Mesa-dev] [PATCH 20/42] i965: rename tex_ms to tex_cms

Prepares for the introduction of non-compressed multi-sampled lookup used in the blorp programs. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp

[Mesa-dev] [PATCH 12/42] i965/blorp: unit test compiling bilinear filtered

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 49 ++ 1 file changed, 49 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index e87ad60..fb9a60a 10

[Mesa-dev] [PATCH 02/42] i965/fs: allow fs-generator use without gl_fragment_program

Prepares the generator to accept hand-crafted blorp programs. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 15/42] i965/blorp: unit test compiling integer typed texture fetches

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 86 ++ 1 file changed, 86 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index 1545148..8b0cac2 10

[Mesa-dev] [PATCH 03/42] i965: dump the disassembly to the given file

instead of ignoring the argument and always dumping to standard output. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_eu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 08/42] i965/blorp: unit test compiling msaa-4 ums to cms

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 59 ++ 1 file changed, 59 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index 5d49ace..fa6b53d 10

[Mesa-dev] [PATCH 41/42] i965/eu: introduce blorp specific flavour of lrp

This is rather ugly but as I couldn't think of anything better for now and wanted to get the rest of the series under review, I left it as it is. Even though immediately surrounding code has tabs this piece is written space-indented. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 11/42] i965/blorp: unit test compiling simple zero-src sampled

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index 1d57640..e87ad60 10

[Mesa-dev] [PATCH 05/42] i965/blorp: unit test compiling blend and scaled

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/.gitignore | 1 + src/mesa/drivers/dri/i965/Makefile.am | 8 +- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 331 + 3 files changed, 339 insertions(+), 1 deletion(-) create mo

[Mesa-dev] [PATCH 19/42] i965/blorp: move emission of pixel kill into eu-emitter

The combination of four separate comparison operations and and the masked "and" require special treatment when moving to FS LIR. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 26 +++-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 2

[Mesa-dev] [PATCH 27/42] i965/blorp: wrap LRP

The split of the emission of the two halfs into single emission call prapares for fs_generator support that already does similar thing. No regressions seen on IVB (unit tests and piglit quick). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 26 ++-

[Mesa-dev] [PATCH 36/42] i965/blorp: wrap RNDD (/brw_RNDD(&func, /emit_rndd(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_

[Mesa-dev] [PATCH 22/42] i965/blorp: move emission of texture lookup into eu-emitter

Resolving of the hardware message type is moved into the emitter also in preparation for switching to use fs_generator. The generator wants to translate the high level op-code into the message type and hence the emitter needs to know the original op-code. Signed-off-by: Topi Pohjolainen --- src/

[Mesa-dev] [PATCH 21/42] i965/fs: introduce non-compressed equivalent of tex_cms

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 + src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +++ 3 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src

[Mesa-dev] [PATCH 10/42] i965/blorp: unit test compiling unaligned msaa-8

Signed-off-by: Topi Pohjolainen --- .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 135 + 1 file changed, 135 insertions(+) diff --git a/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp b/src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp index 9692ce4..1d57640 1

[Mesa-dev] [PATCH 32/42] i965/blorp: wrap SHL (/brw_SHL(&func, /emit_shl(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 24 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dr

[Mesa-dev] [PATCH 29/42] i965/blorp: wrap AND (/brw_AND(&func, /emit_and(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 78 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++ 2 files changed, 46 insertions(+), 39 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dri

[Mesa-dev] [PATCH 34/42] i965/blorp: wrap MUL (/brw_MUL(&func, /emit_mul(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 18 +- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++ 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/d

[Mesa-dev] [PATCH 31/42] i965/blorp: wrap SHR (/brw_SHR(&func, /emit_shr(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 24 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dr

[Mesa-dev] [PATCH 42/42] i965/blorp: switch eu-emitter to use FS IR and fs_generator

Unfortunately the unit tests need to be patched as well. This is because the direct eu-emitter only patches jump counters for if-else (see patch_IF_ELSE()) while the fs_generator patches the endif as well (see brw_set_uip_jip()). No regressions on IVB (piglit quick + unit tests). Signed-off-by: T

[Mesa-dev] [PATCH 04/42] i965/blorp: allow unit tests to compile and dump assembly

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index 51a3bef..112a307 100644 ---

[Mesa-dev] [PATCH 25/42] i965/blorp: wrap emission of conditional assignment

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 19 --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 11 +++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dri

[Mesa-dev] [PATCH 24/42] i965/blorp: move emission of sample combining into eu-emitter

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 13 - src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 12 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 5 + 3 files changed, 21 insertions(+), 9 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 26/42] i965/blorp: wrap emission of if-equal-assignment

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 30 ++- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 6 ++ 2 files changed, 12 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/

[Mesa-dev] [PATCH 38/42] i965/fs: allow unit tests to dump the final patched assembly

Unit tests comparing generated blorp programs to known good need to have the dump in designated file instead of in default standard output. The comparison also expects the jump counters of if-else-instructions to be correctly set and hence the dump needs to be taken _after_ 'patch_IF_ELSE()' is run

[Mesa-dev] [PATCH 18/42] i965/blorp: introduce separate eu-emitter for blit compiler

Prepares for presenting blorp blit programs using FS IR that allows EU-assembly generation using i965 glsl-compiler backend (fs_generator). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 41 ++-

[Mesa-dev] [PATCH 40/42] i965/fs: add support for BRW_OPCODE_AVG in fs_generator

Needed for compiling blorp blit programs. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 4c159e6..16c0

[Mesa-dev] [PATCH 30/42] i965/blorp: wrap ADD (/brw_ADD(&func, /emit_add(/)

In addition, the special case requiring explicit execution size control is wrapped manually. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 34 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 16 + 2 files changed, 32 i

[Mesa-dev] [PATCH 23/42] i965/blorp: move emission of rt-write into eu-emitter

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 15 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 18 ++ src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 5 + 3 files changed, 28 insertions(+), 10 deletions(-) diff -

[Mesa-dev] [PATCH 33/42] i965/blorp: wrap OR (/brw_OR(&func, /emit_or(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 48 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dr

[Mesa-dev] [PATCH 35/42] i965/blorp: wrap FRC (/brw_FRC(&func, /emit_frc(/)

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 6 ++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_b

[Mesa-dev] [PATCH 17/42] i965/blorp: reduce the scope of the explicit compression control

By highlighting these special cases makes it clearer to switch to the fs-generator as the wider scoped compression control settings used in the current implementation can be simply dropped. No regressions on IVB (piglit quick + unit tests). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/d

[Mesa-dev] [PATCH 37/42] i965/blorp: wrap brw_IF/ELSE/ENDIF() into eu-emitter

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 14 +- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 18 ++ 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/dr

[Mesa-dev] [PATCH 16/42] i965/blorp: remove dependency to compression control state

Effectively only the mask control bit gets altered for the single addition in question and hence there is no real need to use a fresh state control level for it -- that is more useful when multiple intructions share the same mask and compression settings. This is a preparation step for removing th

[Mesa-dev] [PATCH 39/42] i965/fs: introduce blorp specific rt-write for fs_generator

The compiler for blorp programs likes to emit instructions for the message construction itself meaning that the generator needs to skip any such when blorp programs are translated for the hw. In addition, the binding table control is special for blorp programs and the generator does not need to upd

[Mesa-dev] [PATCH 01/42] i965/fs: generate fs programs also without any 8-width instructions

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 0cc574c..2381fb0 100644 --- a/src/m

[Mesa-dev] [PATCH 28/42] i965/blorp: wrap MOV (/brw_MOV(&func, /emit_mov(/)

In addition, the two special cases requiring explicit execution size control are wrapped manually. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 68 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 12 + 2 files changed, 45 ins

Re: [Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

On 12/19/2013 06:47 PM, Michel Dänzer wrote: On Don, 2013-12-19 at 13:56 -0800, Mark Mueller wrote: Adjust MESA_FORMAT color component ordering to match API docs, driver specific formats (e.g. PIPE_FORMATs), Actually, there are a couple of examples of other format definitions which match the M

Re: [Mesa-dev] PATCHES: R600: Implement work-around for CF stack HW bug

Some cosmetic comments below, otherwise the patches are: reviewed-by: Vincent Lejeune >-OutStreamer.EmitRawText( >- Twine("; Kernel info:\n") + >- "; NumSgprs: " + Twine(KernelInfo.NumSGPR) + "\n" + >- "; NumVgprs: " + Twine(KernelInfo.NumVGPR) + "\n"); >+if (STM.getGenerat

Re: [Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 20 December 2013 04:47, Chad Versace wrote: > We need to emit depth stall flushes before depth and hiz resolves. > Placing them at the top of blorp's state emission fixes the hang. > > Fixes HiZ hang in the new WebGL Google maps on Sandybridge Chrome OS. > Tested by zooming in and out continuou

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

https://bugs.freedesktop.org/show_bug.cgi?id=68296 U. Artie Eoff changed: What|Removed |Added Priority|medium |high --- Comment #9 from U. Artie Eoff

Re: [Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 12/20/2013 07:56 AM, Paul Berry wrote: On 20 December 2013 04:47, Chad Versace wrote: We need to emit depth stall flushes before depth and hiz resolves. Placing them at the top of blorp's state emission fixes the hang. Fixes HiZ hang in the new WebGL Google maps on Sandybridge Chrome OS. Te

Re: [Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On Fri, Dec 20, 2013 at 7:56 AM, Paul Berry wrote: > On 20 December 2013 04:47, Chad Versace wrote: > >> We need to emit depth stall flushes before depth and hiz resolves. >> Placing them at the top of blorp's state emission fixes the hang. >> >> Fixes HiZ hang in the new WebGL Google maps on San

Re: [Mesa-dev] [PATCH 01/18] Remove glBlendColor and glBlendEquations decls from glext.h

On 12/13/2013 05:25 PM, Keith Packard wrote: > These are duplicates from gl.h; I'm not sure which file they belong in, but > you don't get to have them in both places. If you're doing something that involves defining GL_GLEXT_PROTOTYPES, you're doing it wrong. Also, unless you're sending kernel o

[Mesa-dev] [Bug 72926] New: Memory corruption (crash) in draw/draw_pt_fetch_shade_pipeline_llvm.c:435

https://bugs.freedesktop.org/show_bug.cgi?id=72926 Priority: medium Bug ID: 72926 Assignee: mesa-dev@lists.freedesktop.org Summary: Memory corruption (crash) in draw/draw_pt_fetch_shade_pipeline_llvm.c:435 Severity: normal

Re: [Mesa-dev] [PATCH] Report that no function found if signature lookup is empty

On 12/09/2013 01:18 AM, Kevin Rogovin wrote: > Enhancement: if no function signature is found for a function > name, report that the function is not found instead of printing > an empty list of candidates. I made the minor changes that I mention below and pushed it with my R-b. > --- > src/glsl/

Re: [Mesa-dev] [PATCH] Use line number information from entire function expression

On 12/09/2013 12:38 AM, Kevin Rogovin wrote: > This patch changes the error reporting behavior for incorrect > function invocation (triggered by match_function_by_name() > unable to find a matching function call) from using the line > number information associated to the function name term > to us

Re: [Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

On Fri, Dec 20, 2013 at 7:38 AM, Brian Paul wrote: > On 12/19/2013 06:47 PM, Michel Dänzer wrote: > >> On Don, 2013-12-19 at 13:56 -0800, Mark Mueller wrote: >> >>> Adjust MESA_FORMAT color component ordering to match API docs, driver >>> specific formats (e.g. PIPE_FORMATs), >>> >> >> Actually,

Re: [Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

This patch breaks the test_vec4_register_coalesce unit test. Did you run 'make check'? On 11/27/2013 05:28 AM, Petri Latvala wrote: > v2: Don't add function parameters, pass the required size in > prog_data->nr_params. > > Signed-off-by: Petri Latvala > --- > src/mesa/drivers/dri/i965/brw_vec4

Re: [Mesa-dev] Blorp blit compiler to use FS LIR

On Fri, Dec 20, 2013 at 6:38 AM, Topi Pohjolainen wrote: > Topi Pohjolainen (42): > i965/fs: generate fs programs also without any 8-width instructions > i965/fs: allow fs-generator use without gl_fragment_program > i965: dump the disassembly to the given file > i965/blorp: allow unit test

Re: [Mesa-dev] [PATCH 01/42] i965/fs: generate fs programs also without any 8-width instructions

On Fri, Dec 20, 2013 at 6:38 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

On 11/27/2013 05:28 AM, Petri Latvala wrote: > v2: Don't add function parameters, pass the required size in > prog_data->nr_params. > > Signed-off-by: Petri Latvala > --- > src/mesa/drivers/dri/i965/brw_vec4.h | 5 +++-- > src/mesa/drivers/dri/i965/brw_vec4_gs.c| 5 + > src

Re: [Mesa-dev] [PATCH 2/2] i965: Assert array index on access to vec4_visitor's arrays.

On 11/22/2013 12:09 AM, Petri Latvala wrote: > Signed-off-by: Petri Latvala > --- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp > i

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

I'm pretty sure this patch needs to add stub versions of _mesa_ClearBufferData and _mesa_ClearBufferSubData. Otherwise, I believe the build breaks here. I also think the change to dd_function_table should be in a different patch. On 12/10/2013 05:13 AM, Pi Tabred wrote: > - add xml file for ext

Re: [Mesa-dev] [PATCH 1/1] mesa: Add some convention to MESA_FORMATs with attention to PIPE_FORMATs

On 12/18/2013 08:44 PM, Mark Mueller wrote: > Though a large patch, this is simply a series of global search > and replace operations. Please refer to formats.h for the core > deltas. In summary this change adds UNORM, and UINT to formats > where no type is given, as necessary; replaces the SIGNED

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

On 12/11/2013 03:53 AM, Pi Tabred wrote: > On 10.12.2013 18:00, Marek Olšák wrote: >> On Tue, Dec 10, 2013 at 2:13 PM, Pi Tabred wrote: >>> - add xml file for extension >>> - add reference in gl_API.xml >>> - add pointer to device driver function table >>> - add new functions to list of availa

Re: [Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

On Thu, Dec 19, 2013 at 5:47 PM, Michel Dänzer wrote: > On Don, 2013-12-19 at 13:56 -0800, Mark Mueller wrote: > > Adjust MESA_FORMAT color component ordering to match API docs, driver > > specific formats (e.g. PIPE_FORMATs), > > Actually, there are a couple of examples of other format definitio

Re: [Mesa-dev] [PATCH 1/7] i965: Include brw_reg.h in brw_disasm.c.

On 12/19/2013 12:48 PM, Eric Anholt wrote: > Kenneth Graunke writes: > >> We're going to move some things from brw_defines.h there in a moment. >> Both files contain symbols named negate, so we need to arbitrarily >> rename them. (The "m_" prefix is a convention I adopted in the Gen8+ >> code).

Re: [Mesa-dev] [PATCH 1/1] mesa: Add some convention to MESA_FORMATs with attention to PIPE_FORMATs

Not all "_INT" occurences are changed to "_SINT". It's kinda obvious if you just read formats.h of the patch. Also, radeon and r200 will fail to compile with this. Therefore, NAK. The format-translation macros in the radeon drivers could be inlined to make find-and-replace operations possible there

Re: [Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 12/20/2013 07:56 AM, Paul Berry wrote: > On 20 December 2013 04:47, Chad Versace > wrote: > > We need to emit depth stall flushes before depth and hiz resolves. > Placing them at the top of blorp's state emission fixes the hang. > > Fixes HiZ h

Re: [Mesa-dev] [PATCH 1/5] mesa: Add infrastructure for GL_ARB_clear_buffer_object

On Fri, Dec 20, 2013 at 9:21 PM, Ian Romanick wrote: > > I think there are two ways a driver could implement this function, and I > suspect that drivers for UMA systems may dynamically switch between the > two. I'm pretty sure the i965 driver will, anyway. > > A driver could implement this using

Re: [Mesa-dev] [PATCH 2/2] swrast: silence driContextSetFlags() parameter type warning

Oops. All of the other drivers call the Mesa context ctx and the dri_context something else... and I managed to overlook the warning. Reviewed-by: Ian Romanick On 12/13/2013 03:55 PM, Brian Paul wrote: > --- > src/mesa/drivers/dri/swrast/swrast.c |2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] mesa: minor simplification in _mesa_es3_error_check_format_and_type()

On 12/17/2013 03:35 PM, Brian Paul wrote: > The type_valid local was set to true and never changed. Right... I think I just copy-and-paste _mesa_es_error_check_format_and_type, which does change the value of type_valid. Reviewed-by: Ian Romanick > --- > src/mesa/main/glformats.c |4 +--- >

Re: [Mesa-dev] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 12/20/2013 04:47 AM, Chad Versace wrote: > We need to emit depth stall flushes before depth and hiz resolves. > Placing them at the top of blorp's state emission fixes the hang. > > Fixes HiZ hang in the new WebGL Google maps on Sandybridge Chrome OS. > Tested by zooming in and out continuously

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 12/20/2013 01:36 PM, Kenneth Graunke wrote: On 12/20/2013 04:47 AM, Chad Versace wrote: We need to emit depth stall flushes before depth and hiz resolves. Placing them at the top of blorp's state emission fixes the hang. Fixes HiZ hang in the new WebGL Google maps on Sandybridge Chrome OS. T

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

On 12/19/2013 01:50 AM, Lauri Kasanen wrote: On Wed, 18 Dec 2013 17:57:16 -0800 Matt Turner wrote: On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen It seems to me that the Intel code that uses this SSE4.1 function is still buggy, as it has no runtime check - would it not crash if built on a

Re: [Mesa-dev] [PATCH 1/2] glcpp: Add a more descriptive comment for the SKIP state manipulation

Other than the code formatting comment below, this series is Reviewed-by: Ian Romanick On 12/19/2013 04:25 PM, Carl Worth wrote: > Two things make this code confusing: > > 1. The uncharacteristic manipulation of lexer start state outside of > flex rules. > > 2. The confusi

Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

On 12/17/2013 07:37 AM, Erik Faye-Lund wrote: > The preprocessor currently accepts multiple else/elif-groups > per if-section. The GLSL-preprocessor is defined by the C++ > specification, which defines the following parse-rule: > > if-section: > if-group elif-groups(opt) else-group(opt) endi

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/gen6: Fix HiZ hang in WebGL Google maps

On 12/20/2013 03:09 PM, Chad Versace wrote: > On 12/20/2013 01:36 PM, Kenneth Graunke wrote: >> On 12/20/2013 04:47 AM, Chad Versace wrote: >>> We need to emit depth stall flushes before depth and hiz resolves. >>> Placing them at the top of blorp's state emission fixes the hang. >>> >>> Fixes HiZ

[Mesa-dev] main/hash_table.h vs program/hash_table.h

Hi, While looking at the GLSL IR code, I noticed that different parts of the code use 2 different hash table implementations. ir_loop_analysis, ir_variable_refcount, ir_clone, etc. use struct hash_table under program/hash_table.h, whereas ir_variable_refcount and link_uniform_blocks use struct has

Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

On 12/17/2013 07:37 AM, Erik Faye-Lund wrote: > The preprocessor currently accepts multiple else/elif-groups > per if-section. The GLSL-preprocessor is defined by the C++ > specification, which defines the following parse-rule: > > if-section: > if-group elif-groups(opt) else-group(opt) endi

Re: [Mesa-dev] [PATCH 1/2] glx: Simplify __glxGetMscRate, it only needs the screen, not a drawable

On 12/15/2013 02:37 AM, Lauri Kasanen wrote: > Useful in its own right, but also needed for adaptive vsync. > > Last mail was accidentally wrapped. > > Signed-off-by: Lauri Kasanen I made minor tweaks to the commit message and pushed this patch with my Reviewed-by. Thanks! > --- > src/glx/dr

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

On Thu, Dec 19, 2013 at 11:43 AM, Lauri Kasanen wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 > > Signed-off-by: Lauri Kasanen > --- Thanks, R-b and pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.f

[Mesa-dev] [PATCH] i965: Remove unused depth_mode parameter from translate_tex_format().

According to git blame, this hasn't been used in over two years: commit d2235b0f4681f75d562131d655a6d7b7033d2d8b Author: Eric Anholt Date: Thu Nov 17 17:01:58 2011 -0800 i965: Always handle GL_DEPTH_TEXTURE_MODE through the shader. Signed-off-by: Kenneth Graunke --- src/

[Mesa-dev] [V2 PATCH 1/2] mesa: inline r200 radeon texture format macros to facility search and replace

Signed-off-by: Mark Mueller --- src/mesa/drivers/dri/r200/r200_texstate.c | 108 +++--- src/mesa/drivers/dri/radeon/radeon_texstate.c | 64 ++- 2 files changed, 70 insertions(+), 102 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_texstate.c b/src/m

[Mesa-dev] [V2 PATCH 1/2] mesa: inline r200 radeon texture format macros to facility search and replace

v2: This patch was inserted into the series to correct build problems with r200 and radeon drivers. The patch replaces macros that operate on the MESA_FORMATs with their inline equivalent to facilitate search and replace. Signed-off-by: Mark Mueller --- src/mesa/drivers/dri/r200/r200_texstate.c

[Mesa-dev] [Bug 72708] Master fails to build with older gcc due to -msse4.1

https://bugs.freedesktop.org/show_bug.cgi?id=72708 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---