[Mesa-dev] [Bug 72708] Master fails to build with older gcc due to -msse4.1

2013-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72708 --- Comment #2 from Lauri Kasanen --- Originally to be compatible with the BSDs and Mac, now it's just convenient for building binaries that run on any distro (with newer GCCs requiring newer libstdc++). I think it would be fair for you to fix i

Re: [Mesa-dev] gallium endianness and hw drivers

2013-12-16 Thread Michel Dänzer
On Mon, 2013-12-16 at 17:05 +1000, Dave Airlie wrote: > So the llvmpipe endian work broke the nouveau nv40 support for the > nv43 in the ppc G5 a few people have, Same for r300g: https://bugs.freedesktop.org/show_bug.cgi?id=71789 > Now I'm not really sure how this is supposed to be fixed, > > t

Re: [Mesa-dev] glBlitFramebuffer and sRGB vs piglit

2013-12-16 Thread Henri Verbeet
On 16 December 2013 01:37, Marek Olšák wrote: > Hi everybody, > > There is an inconsistence in the piglit glBlitFramebuffer tests. If > both src and dst are sRGB, piglit expects this from glBlitFramebuffer: > > if (dst.num_samples == 1 && src.num_samples > 1) { >enable the sRGB->linear convers

Re: [Mesa-dev] gallium endianness and hw drivers

2013-12-16 Thread Marek Olšák
Wouldn't it be easier to just revert the gallium endianness rework? If it breaks all hw drivers on big endian machines, it's apparently not done right. Marek On Mon, Dec 16, 2013 at 8:05 AM, Dave Airlie wrote: > So the llvmpipe endian work broke the nouveau nv40 support for the > nv43 in the ppc

[Mesa-dev] [PATCH 5/5] glx: add missing null check in dri2_bind_tex_image

2013-12-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..b72a859 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -990,6 +990,9 @@ dri2_bind_tex_image(Display * dpy, struc

[Mesa-dev] [PATCH 0/5] More null checks from Klocwork

2013-12-16 Thread Juha-Pekka Heikkila
I checked the issues Brian mentioned on the Push*Attrib and related patches. I agree this is just null checking patch but following Topi's suggestion PushAttrib becomes much more clean looking thus the bit bigger change than just checking after nulls here and there is worthy imho. Hope I did not mi

[Mesa-dev] [PATCH 2/5] mesa: Verify memory allocations success in _mesa_PushClientAttrib

2013-12-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..4ce8923 100644 --- a/src/mesa/main/attrib.c +++ b/s

[Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

2013-12-16 Thread Juha-Pekka Heikkila
Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 8a2a268..3ecf533 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 4/5] glx: Add missing null check in dri2CreateDrawable

2013-12-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index bfeebed..309c1e7 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -366,6 +366,10 @@ dri2CreateDrawable(struc

[Mesa-dev] [PATCH 3/5] mesa: Verify memory allocations success in _mesa_PushAttrib

2013-12-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/attrib.c | 236 +++-- 1 file changed, 152 insertions(+), 84 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 4ce8923..0671b74 100644 --- a/src/mesa/main/attrib.c +++ b/

Re: [Mesa-dev] [PATCH 4/8] r600/compute: Free compiled kernels when deleting compute state

2013-12-16 Thread Tom Stellard
On Thu, Dec 12, 2013 at 04:47:20PM -0600, Aaron Watry wrote: > --- > src/gallium/drivers/r600/evergreen_compute.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/r600/evergreen_compute.c > b/src/gallium/drivers/r600/evergreen_compute.c > index f0f537c..25ca5d4 10

Re: [Mesa-dev] [PATCH 0/8] Fix multiple memory leaks

2013-12-16 Thread Tom Stellard
Hi Aaron, Just one comment on patch 4, with that fixed the series is: Reviewed-by: Tom Stellard If you re-send an annotated series with the patch 4 fix I'll push it. Also, can you add CC: "10.0" so they get pulled into the stable branch. Thanks, Tom On Thu, Dec 12, 2013 at 04:47:16PM -0600

Re: [Mesa-dev] [PATCH] llvmpipe: use pipe_sampler_view_release() to avoid segfault

2013-12-16 Thread Brian Paul
On 12/15/2013 06:24 PM, Jonathan Liu wrote: This fixes another case of faulting when freeing a pipe_sampler_view that belongs to a previously destroyed context. Signed-off-by: Jonathan Liu --- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 ++ 1 file changed, 6 insertions(+) diff -

Re: [Mesa-dev] [PATCH V3 00/10] Newbie Project : Implement ARB_clear_buffer_object

2013-12-16 Thread Brian Paul
On 12/14/2013 10:32 AM, Pi Tabred wrote: Hello, third version of the patches to implement "ARB_clear_buffer_object". I hope I got everything this time. Looks good to me. I'll push these soon. Though I'll first fix a few minor issues: In patch 4 there's a bunch of "case GL_xxx" changes wi

Re: [Mesa-dev] [PATCH V3 00/10] Newbie Project : Implement ARB_clear_buffer_object

2013-12-16 Thread Brian Paul
On 12/16/2013 08:36 AM, Brian Paul wrote: On 12/14/2013 10:32 AM, Pi Tabred wrote: Hello, third version of the patches to implement "ARB_clear_buffer_object". I hope I got everything this time. Looks good to me. I'll push these soon. Though I'll first fix a few minor issues: In patch 4 the

[Mesa-dev] [PATCH] mesa: add API/extension checks for 3-component texture buffer formats

2013-12-16 Thread Brian Paul
The GL_RGB32F, GL_RGB32UI and GL_RGB32I texture buffer formats are only supposed to be allowed if the GL_ARB_texture_buffer_object_rgb32 extension is supported. Note that the texture buffer extensions require a core profile. This patch adds those checks. Fixes the soon-to-be-added arb_clear_buff

Re: [Mesa-dev] [PATCH 5/5] glx: add missing null check in dri2_bind_tex_image

2013-12-16 Thread Brian Paul
On 12/16/2013 07:04 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..b72a859 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -990,6

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] i915: Add support for gl_FragData[0] reads.

2013-12-16 Thread Ian Romanick
On 12/15/2013 03:31 AM, Henri Verbeet wrote: > Similar to 556a47a2621073185be83a0a721a8ba93392bedb, without this reading from > gl_FragData[0] would cause a software fallback. Oops. I'm surprised nobody ever noticed this problem before. :( Good catch. > Bugzilla: https://bugs.winehq.org/show_bu

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

2013-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68296 --- Comment #6 from U. Artie Eoff --- This issue still exists on latest tips in master and 10.0 branches (as of today): mesa (master) heads/master-0-gf9cfe5c mesa (10.0) heads/10.0-0-g6f7da01 -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-12-16 Thread Eric Anholt
Daniel Vetter writes: > On Sat, Dec 14, 2013 at 3:33 AM, Kenneth Graunke > wrote: >> On 11/18/2013 12:58 PM, Emil Velikov wrote: >>> On 18/11/13 01:08, Keith Packard wrote: libudev doesn't have a stable API/ABI, and if the application wants to use one version, we'd best not load

Re: [Mesa-dev] [PATCH 1/1] i915: Add support for gl_FragData[0] reads.

2013-12-16 Thread Eric Anholt
Henri Verbeet writes: > Similar to 556a47a2621073185be83a0a721a8ba93392bedb, without this reading from > gl_FragData[0] would cause a software fallback. I thought it might have been an RO register, but the specs say it's RW. Reviewed-by: Eric Anholt pgp4utZzUIbHm.pgp Description: PGP signatu

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-12-16 Thread Daniel Vetter
On Mon, Dec 16, 2013 at 11:19:56AM -0800, Eric Anholt wrote: > Daniel Vetter writes: > > > On Sat, Dec 14, 2013 at 3:33 AM, Kenneth Graunke > > wrote: > >> On 11/18/2013 12:58 PM, Emil Velikov wrote: > >>> On 18/11/13 01:08, Keith Packard wrote: > libudev doesn't have a stable API/ABI, and

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

2013-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68296 --- Comment #7 from U. Artie Eoff --- (In reply to comment #6) > This issue still exists on latest tips in master and 10.0 branches (as of > today): > > mesa (master) heads/master-0-gf9cfe5c > mesa (10.0) heads/10.0-0-g6f7da01 Ok, I can't seem

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

2013-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68296 --- Comment #8 from U. Artie Eoff --- (In reply to comment #7) > (In reply to comment #6) > > This issue still exists on latest tips in master and 10.0 branches (as of > > today): > > > > mesa (master) heads/master-0-gf9cfe5c > > mesa (10.0) hea

Re: [Mesa-dev] [PATCH 20/23] glsl/linker: Count and check image resources.

2013-12-16 Thread Paul Berry
On 12 December 2013 08:32, Francisco Jerez wrote: > Paul Berry writes: > > > On 26 November 2013 00:02, Francisco Jerez > wrote: > > > >> --- > >> src/glsl/link_uniforms.cpp | 13 +++- > >> src/glsl/linker.cpp| 50 > >> ++ > >> 2 file

Re: [Mesa-dev] [PATCH 7/7] i965: Add support for Broadwell's new register types.

2013-12-16 Thread Jordan Justen
"m_" in patch 1 seems a bit odd, but I've nothing better to suggest. Patch 5 seems like a definite improvement. Series Reviewed-by: Jordan Justen On Tue, Dec 10, 2013 at 2:33 AM, Kenneth Graunke wrote: > Broadwell introduces support for Q, UQ, and HF types. It also extends > DF support to all

Re: [Mesa-dev] [PATCH 2/2] i965: Use {point_sprite, flat}_enable variable names instead of dw*.

2013-12-16 Thread Jordan Justen
On Mon, Dec 9, 2013 at 4:11 PM, Kenneth Graunke wrote: > Calling the local variables flat_enable and point_sprite_enable is > clearer than dw16 and such. It also matches the names used in > calculate_attr_overrides, which computes them. > > Signed-off-by: Kenneth Graunke > Cc: Paul Berry > ---

[Mesa-dev] [PATCH 2/3] main: Move MESA_SHADER_TYPES outside of gl_shader_type enum.

2013-12-16 Thread Paul Berry
This will avoid spurious compiler warnings in the patch that follows. --- src/mesa/main/mtypes.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f7e1391..534c3bc 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtyp

[Mesa-dev] [PATCH 3/3] glsl: Replace _mesa_glsl_parser_targets enum with gl_shader_type.

2013-12-16 Thread Paul Berry
These enums were redundant. --- src/glsl/ast_to_hir.cpp | 82 - src/glsl/builtin_functions.cpp | 22 +-- src/glsl/builtin_variables.cpp | 20 +- src/glsl/glsl_parser.yy | 8 ++-- src/glsl/glsl_parser_extras.cpp | 14 +++

[Mesa-dev] [PATCH 1/3] glsl: Don't return bad values from _mesa_shader_type_to_index.

2013-12-16 Thread Paul Berry
This will avoid compiler warnings in the patch that follows. There should be no user-visible effect because the change only affects the behaviour when an invalid enum is passed to _mesa_shader_type_to_index(), and that can only happen if there is a bug elsewhere in Mesa. --- src/glsl/standalone_s

Re: [Mesa-dev] [PATCH 3/3] glsl: Replace _mesa_glsl_parser_targets enum with gl_shader_type.

2013-12-16 Thread Brian Paul
On 12/16/2013 03:27 PM, Paul Berry wrote: These enums were redundant. --- src/glsl/ast_to_hir.cpp | 82 - src/glsl/builtin_functions.cpp | 22 +-- src/glsl/builtin_variables.cpp | 20 +- src/glsl/glsl_parser.yy | 8 ++

Re: [Mesa-dev] [PATCH] configure.ac: remove -fcolor-diagnostics from LLVM flags

2013-12-16 Thread Brian Paul
On 12/13/2013 02:59 AM, Markus Trippelsdorf wrote: When LLVM is build with Clang, "llvm-config --cxxflags" contains the -fcolor-diagnostics flag. It is not recognized by gcc and the build fails. Fix by removing the flag. Signed-off-by: Markus Trippelsdorf diff --git a/configure.ac b/configure.

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

2013-12-16 Thread Paul Berry
On 12 December 2013 08:29, Francisco Jerez wrote: > Paul Berry writes: > > > On 26 November 2013 00:02, Francisco Jerez > wrote: > > > >> > >> +enum glsl_image_dim { > >> + GLSL_IMAGE_DIM_1D, > >> + GLSL_IMAGE_DIM_2D, > >> + GLSL_IMAGE_DIM_3D, > >> + GLSL_IMAGE_DIM_RECT, > >> + GLSL_I

[Mesa-dev] [PATCH] glsl: Fix gl_type of usamplerCube built-in type.

2013-12-16 Thread Paul Berry
I'm not aware of any piglit tests that this fixes, but the old code was obviously wrong. --- src/glsl/builtin_type_macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_type_macros.h b/src/glsl/builtin_type_macros.h index 263fd83..06b4dbd 100644 --- a/src/gl

Re: [Mesa-dev] [PATCH 3/3] glsl: Replace _mesa_glsl_parser_targets enum with gl_shader_type.

2013-12-16 Thread Paul Berry
On 16 December 2013 14:42, Brian Paul wrote: > On 12/16/2013 03:27 PM, Paul Berry wrote: > >> These enums were redundant. >> --- >> src/glsl/ast_to_hir.cpp | 82 -- >> --- >> src/glsl/builtin_functions.cpp | 22 +-- >> src/glsl/builtin_vari

[Mesa-dev] [PATCH] Haiku: Add in public GL kit headers

2013-12-16 Thread Alexander von Gluck IV
* These make up the base of what C++ GL Haiku applications use for 3D rendering. * Not placed in includes/GL to prevent Haiku headers from getting installed on non-Haiku systems --- include/HaikuGL/GLRenderer.h | 76 + include/HaikuGL/GLView.h | 193 +++

Re: [Mesa-dev] [PATCH] glsl: Fix gl_type of usamplerCube built-in type.

2013-12-16 Thread Kenneth Graunke
On 12/16/2013 03:18 PM, Paul Berry wrote: > I'm not aware of any piglit tests that this fixes, but the old code > was obviously wrong. > --- > src/glsl/builtin_type_macros.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/builtin_type_macros.h b/src/glsl/builtin_

Re: [Mesa-dev] [Mesa-stable] [PATCH] Haiku: Add in public GL kit headers

2013-12-16 Thread Brian Paul
On 12/16/2013 04:39 PM, Alexander von Gluck IV wrote: * These make up the base of what C++ GL Haiku applications use for 3D rendering. * Not placed in includes/GL to prevent Haiku headers from getting installed on non-Haiku systems --- include/HaikuGL/GLRenderer.h | 76 +

Re: [Mesa-dev] gallium endianness and hw drivers

2013-12-16 Thread Benjamin Herrenschmidt
On Mon, 2013-12-16 at 13:30 +0100, Marek Olšák wrote: > Wouldn't it be easier to just revert the gallium endianness rework? If > it breaks all hw drivers on big endian machines, it's apparently not > done right. It also makes llvmpipe work on P7 and P8 and enables r600 ... which some people rely o

Re: [Mesa-dev] gallium endianness and hw drivers

2013-12-16 Thread Michel Dänzer
On Mon, 2013-12-16 at 13:30 +0100, Marek Olšák wrote: > Wouldn't it be easier to just revert the gallium endianness rework? That would be putting our heads in the sand. > If it breaks all hw drivers on big endian machines, it's apparently not > done right. The HW drivers were already broken befo

Re: [Mesa-dev] [PATCH] radeonsi: Since we're not using HiS, use more buffer space for HiZ.

2013-12-16 Thread Marek Olšák
After reading some docs, I think it should only be set for depth buffers without stencil, because it also disables stencil compression. Would you like to make a new patch? Marek On Fri, Dec 13, 2013 at 4:58 PM, Andreas Hartmetz wrote: > Also move a comment that was in the wrong place. > --- > s

[Mesa-dev] [PATCH 3/3] radeonsi: improve HiZ precision for less and lequal depth functions

2013-12-16 Thread Marek Olšák
From: Marek Olšák r600g needs this too. --- src/gallium/drivers/radeonsi/si_state.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 8e08804..c1107c6 100644 --- a/src/gallium/driver

[Mesa-dev] [PATCH 2/3] radeonsi: make DB_RENDER_OVERRIDE an invariant register

2013-12-16 Thread Marek Olšák
From: Marek Olšák All this cruft was ported from r600g and isn't needed on SI and later according to hw docs. If we implemented HiS, we would set it to 0. --- src/gallium/drivers/radeonsi/si_state.c | 50 ++-- src/gallium/drivers/radeonsi/si_state.h | 2 -- src

[Mesa-dev] [PATCH 1/3] radeonsi: flush HTILE when appropriate

2013-12-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/r600_hw_context.c | 1 + src/gallium/drivers/radeonsi/si_state.c| 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 6 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/r600_hw_conte