[Mesa-dev] [PATCH] i965: Initialize the maximum number of GS threads on Haswell.

2013-08-02 Thread Kenneth Graunke
We'll need proper values for max_gs_threads when we eventually support geometry shaders. Also, we initialize it for every other platform. Signed-off-by: Kenneth Graunke Cc: Paul Berry --- src/mesa/drivers/dri/i965/brw_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/dr

[Mesa-dev] [PATCH regression-fix 2/2] glsl: Disallow interpolation qualifiers on non-input/output variables.

2013-08-02 Thread Kenneth Graunke
Commit 2548092ad8015 switched the sense of interpolation qualifier checks in order to permit them on geometry shader in/out variables. In doing so, it accidentally allowed interpolation qualifiers to be applied to ordinary variables and function parameters. Fixes a regression in Piglit's local-sm

[Mesa-dev] [PATCH regression-fix 1/2] glsl: Fix NULL pointer dereferences when linking fails.

2013-08-02 Thread Kenneth Graunke
Commit 7cfefe6965d50 introduced a check for whether linked->Type equals GL_GEOMETRY_SHADER. However, linked may be NULL due to an earlier error condition. Since the entire function after the error path is (or should be) guarded by linked != NULL checks, we may as well just return early and remove

[Mesa-dev] [PATCH] i965: Don't allocate curbe buffers on Gen6+.

2013-08-02 Thread Kenneth Graunke
These are only used on Gen4-5. Why waste the 8kB of space? Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c inde

[Mesa-dev] [PATCH 1/2] docs: Document that i965 Gen6+ requires Kernel 3.6 or later

2013-08-02 Thread Andreas Boll
Cc: "9.2" mesa-sta...@lists.freedesktop.org --- docs/relnotes/9.2.html |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/9.2.html b/docs/relnotes/9.2.html index 4e419f1..b9308eb 100644 --- a/docs/relnotes/9.2.html +++ b/docs/relnotes/9.2.html @@ -71,7 +71,8 @@

[Mesa-dev] [PATCH 2/2] docs: Document UVD (2.2 and 3.0) video decoding support in mesa 9.2

2013-08-02 Thread Andreas Boll
Cc: "9.2" mesa-sta...@lists.freedesktop.org --- docs/relnotes/9.2.html |1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/9.2.html b/docs/relnotes/9.2.html index b9308eb..1f93b89 100644 --- a/docs/relnotes/9.2.html +++ b/docs/relnotes/9.2.html @@ -53,6 +53,7 @@ Note: some of the

Re: [Mesa-dev] [PATCH] Makefile.am: Remove api_exec_es* from EXTRA_FILES.

2013-08-02 Thread Andreas Boll
Candidate for 9.1 and 9.2? Reviewed-by: Andreas Boll 2013/8/2 Matt Turner : > These files were removed in commits a0102154 and a8ab7e33. > --- > Makefile.am | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index ce391c4..343bade 100644 > --- a/Makefile.a

[Mesa-dev] [PATCH] docs: Update some out of date sourcetree information

2013-08-02 Thread Timothy Arceri
--- docs/devinfo.html| 2 +- docs/sourcetree.html | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index bf77259..4c1099c 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -36,7 +36,7 @@ To add a new GL extension to Mesa you ha

[Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-02 Thread Martin Andersson
Hi, I started to look at why the spec/!OpenGL 3.0/gl-3.0-texture-integer sometimes fails on my AMD 6950, using mesa master. It fails with errors like this: texture-integer: failure with format GL_RGB8I_EXT: texture color = 100, 9, 71, 0 expected color = 0.25, 0.5, 0.75, 0 result color = 0.2

Re: [Mesa-dev] [PATCH] docs: Update some out of date sourcetree information

2013-08-02 Thread Andreas Boll
Reviewed-by: Andreas Boll 2013/8/2 Timothy Arceri : > --- > docs/devinfo.html| 2 +- > docs/sourcetree.html | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/docs/devinfo.html b/docs/devinfo.html > index bf77259..4c1099c 100644 > --- a/docs/devinfo.html > +++ b/docs/

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-02 Thread Marek Olšák
The format doesn't have alpha. See what the texture fetch writes to the alpha channel. You may try setting "texture-integer.c:290" to "expected[3] = 1.0;" Marek On Fri, Aug 2, 2013 at 2:15 PM, Martin Andersson wrote: > Hi, > > I started to look at why the spec/!OpenGL 3.0/gl-3.0-texture-integer

Re: [Mesa-dev] [PATCH] docs: Update some out of date sourcetree information

2013-08-02 Thread Tim Arceri
Thanks for looking over this Andreas. Quick question I'm new to Mesa but I hope to contribute some more significant patches in future. What is the process for getting patches committed once reviewed? Do I just ask directly on this list for someone to do it? Our will someone usually just go throu

Re: [Mesa-dev] [PATCH] docs: Update some out of date sourcetree information

2013-08-02 Thread Andreas Boll
2013/8/2 Tim Arceri : > Thanks for looking over this Andreas. Quick question I'm new to Mesa but I > hope to contribute some more significant patches in future. What is the > process for getting patches committed once reviewed? > Do I just ask directly on this list for someone to do it? Yeah that

Re: [Mesa-dev] [PATCH 2/8] draw: stop crashing with extra shader outputs

2013-08-02 Thread Brian Paul
On 08/02/2013 12:28 AM, Zack Rusin wrote: Draw sometimes injects extra shader outputs (aa points, lines or front face), unfortunately most of the pipeline and llvm code didn't handle them at all. It only worked if number of inputs happened to be bigger or equal to the number of shader outputs plu

Re: [Mesa-dev] [PATCH 8/8] draw: implement proper primitive assembler as a pipeline stage

2013-08-02 Thread Brian Paul
Just minor nits... On 08/02/2013 12:28 AM, Zack Rusin wrote: we used to have a face primitive assembler that we ran after if the gs was missing but we had adjacency primitives in the pipeline, lets convert it to a pipeline stage, which allows us to use it to inject outputs (primitive id) into th

Re: [Mesa-dev] [PATCH 7/8] llvmpipe: don't interpolate front face or prim id

2013-08-02 Thread Brian Paul
On 08/02/2013 12:28 AM, Zack Rusin wrote: The loop was iterating over all the fs inputs and setting them to perspective interpolation, then after the loop we were creating extra output slots with the correct interpolation. Instead of injecting bogus extra outputs, just set the interpolation on fr

[Mesa-dev] [Bug 67672] New: 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 Priority: medium Bug ID: 67672 Assignee: mesa-dev@lists.freedesktop.org Summary: 9.2 git, Test failure in src/gallium/drivers/llvmpipe Severity: normal Classification: Unclassified

Re: [Mesa-dev] [PATCH 2/2] docs: Document UVD (2.2 and 3.0) video decoding support in mesa 9.2

2013-08-02 Thread Alex Deucher
On Fri, Aug 2, 2013 at 5:30 AM, Andreas Boll wrote: > Cc: "9.2" mesa-sta...@lists.freedesktop.org Reviewed-by: Alex Deucher > --- > docs/relnotes/9.2.html |1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/9.2.html b/docs/relnotes/9.2.html > index b9308eb..1f93b89 100644

[Mesa-dev] [PATCH] tgsi: remove unneeded File == TGSI_FILE_INPUT test

2013-08-02 Thread Brian Paul
We're already in an "if (File == TGSI_FILE_INPUT)" block at that point. --- src/gallium/auxiliary/tgsi/tgsi_scan.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 1fe1a07..7f30f88 100644 --- a/src/gallium/

Re: [Mesa-dev] [PATCH 2/8] draw: stop crashing with extra shader outputs

2013-08-02 Thread Roland Scheidegger
Am 02.08.2013 08:28, schrieb Zack Rusin: > Draw sometimes injects extra shader outputs (aa points, lines or > front face), unfortunately most of the pipeline and llvm code > didn't handle them at all. It only worked if number of inputs > happened to be bigger or equal to the number of shader output

Re: [Mesa-dev] [PATCH 1/2] docs: Document that i965 Gen6+ requires Kernel 3.6 or later

2013-08-02 Thread Kenneth Graunke
On 08/02/2013 02:30 AM, Andreas Boll wrote: Cc: "9.2" mesa-sta...@lists.freedesktop.org --- docs/relnotes/9.2.html |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/9.2.html b/docs/relnotes/9.2.html index 4e419f1..b9308eb 100644 --- a/docs/relnotes/9.2.html

Re: [Mesa-dev] [PATCH 4/8] draw: make sure clipping works with injected outputs

2013-08-02 Thread Roland Scheidegger
Am 02.08.2013 08:28, schrieb Zack Rusin: > clipping would drop the extra outputs because it always > used the number of standard vertex shader outputs, without > geometry shader or extra outputs. The commit makes sure > that clipping with geometry shaders which have more outputs > than the current

Re: [Mesa-dev] [PATCH] i965: Initialize the maximum number of GS threads on Haswell.

2013-08-02 Thread Paul Berry
On 2 August 2013 00:01, Kenneth Graunke wrote: > We'll need proper values for max_gs_threads when we eventually support > geometry shaders. Also, we initialize it for every other platform. > > Signed-off-by: Kenneth Graunke > Cc: Paul Berry > Thanks, Ken! Reviewed-by: Paul Berry ___

Re: [Mesa-dev] [PATCH 6/8] draw: fix front face injection

2013-08-02 Thread Roland Scheidegger
Am 02.08.2013 08:28, schrieb Zack Rusin: > Inject front face only if the fragment shader uses it and > propagate through all channels because otherwise we'll > need to figure out the exact swizzle that the fs expects and > it's just simpler to make sure all the components within > the front face re

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 Andreas Boll changed: What|Removed |Added Version|git |9.2 --- Comment #1 from Andreas Boll ---

[Mesa-dev] [Bug 67676] New: Transparent windows no longer work

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67676 Priority: medium Bug ID: 67676 Assignee: mesa-dev@lists.freedesktop.org Summary: Transparent windows no longer work Severity: normal Classification: Unclassified OS: All

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #2 from ken moffat --- (In reply to comment #1) > Which llvm version are you using? > It works for me with version 3.2 and 3.3. 3.3 (I'm using an r600 so I had to upgrade from 3.2 to build mesa-9.2) -- You are receiving this mail

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-02 Thread Michel Dänzer
On Mit, 2013-07-31 at 08:42 -0700, Tom Stellard wrote: > On Wed, Jul 31, 2013 at 01:04:01PM +0200, Michel Dänzer wrote: > > > > LLVM revision 187139 ('Allocate local registers in order for optimal > > coloring.') broke some derivative related piglit tests with the radeonsi > > driver. > > > > I'

Re: [Mesa-dev] [PATCH 8/8] draw: implement proper primitive assembler as a pipeline stage

2013-08-02 Thread Roland Scheidegger
Am 02.08.2013 08:28, schrieb Zack Rusin: > we used to have a face primitive assembler that we ran after if > the gs was missing but we had adjacency primitives in the pipeline, > lets convert it to a pipeline stage, which allows us to use it > to inject outputs (primitive id) into the vertices. it'

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #3 from Roland Scheidegger --- Does this also happen on master? If so do you have a cpu with sse2 but not sse3 by chance? I think there might potentially be a problem there with some tests because we set the FTZ but not the DAZ flag (

Re: [Mesa-dev] [PATCH] Makefile.am: Remove api_exec_es* from EXTRA_FILES.

2013-08-02 Thread Matt Turner
On Fri, Aug 2, 2013 at 2:48 AM, Andreas Boll wrote: > Candidate for 9.1 and 9.2? Yes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 8/8] draw: implement proper primitive assembler as a pipeline stage

2013-08-02 Thread Zack Rusin
Yea, it's quite bonkers, but that's the way it has to be to make it work right now. Personally I'd really like to write a new version of draw, without the 5 emit paths, 4 different vertex shading paths, with interface that is capable of emitting more than just float[4]'s... For now though this w

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #4 from ken moffat --- (In reply to comment #3) > Does this also happen on master? > If so do you have a cpu with sse2 but not sse3 by chance? I think there > might potentially be a problem there with some tests because we set the FTZ

Re: [Mesa-dev] [PATCH 0/4] Mark slices for depth resolve with layered rendering

2013-08-02 Thread Paul Berry
On 29 July 2013 16:18, Jordan Justen wrote: > How does this sub-series look as an alternative to > "[PATCH v2 12/13] intel_mipmap_tree: all layers need hiz resolves > with layered rendering" > Series is: Reviewed-by: Paul Berry > > Jordan Justen (4): > i965: add intel_miptree_set_all_slic

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-02 Thread Martin Andersson
On Fri, Aug 2, 2013 at 2:52 PM, Marek Olšák wrote: > The format doesn't have alpha. See what the texture fetch writes to > the alpha channel. I looked at the code but I can't figure out where the texture fetch happens, could you point me in the right direction? > > You may try setting "texture-i

[Mesa-dev] [PATCH 1/2] gallivm: fix comment wrt srgb accuracy.

2013-08-02 Thread sroland
From: Roland Scheidegger I think it's actually not good enough now... --- src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c b/src/gallium/auxiliary/gallivm/lp_bld_for

[Mesa-dev] [PATCH 2/2] util: implement table-based + linear interpolation linear-to-srgb conversion

2013-08-02 Thread sroland
From: Roland Scheidegger Should be much faster, seems to work in softpipe. While here (also it's now disabled) fix up the pow factor - the former value is what is in GL core it is however not actually accurate to fp32 standard (as it is 1.0/2.4), and if someone would do all the accurate math ther

[Mesa-dev] [PATCH] util: try much harder to set DAZ flag

2013-08-02 Thread sroland
From: Roland Scheidegger While so far this only causes some harmless test failures, there's lots more cpus with DAZ. All 64bit capable ones can do it (particularly relevant for AMD cpus as they supported sse3 very very late) but if really necessary we can check support for that for real with some

Re: [Mesa-dev] [PATCH 0/4] Mark slices for depth resolve with layered rendering

2013-08-02 Thread Chad Versace
On 07/29/2013 04:18 PM, Jordan Justen wrote: How does this sub-series look as an alternative to "[PATCH v2 12/13] intel_mipmap_tree: all layers need hiz resolves with layered rendering" Jordan Justen (4): i965: add intel_miptree_set_all_slices_need_depth_resolve i965: add intel_renderbuf

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #5 from Roland Scheidegger --- FWIW I've sent out a patch which should address this http://lists.freedesktop.org/archives/mesa-dev/2013-August/042729.html) but honestly I don't think it's 9.2 worthy. -- You are receiving this mail b

[Mesa-dev] [Bug 67692] New: [llvmpipe] piglit glsl-fs-frontfacing regression

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67692 Priority: medium Bug ID: 67692 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit glsl-fs-frontfacing regression

[Mesa-dev] Questions about arrays in GLSL 1.50 interface blocks

2013-08-02 Thread Paul Berry
1. Is it ok to declare an unsized array in an interface block? In other words, is this ok? out blk { vec4 foo[]; }; The nVidia Linux driver allows this, but Mesa currently doesn't. AFAICT the spec says it's ok. In fact, the spec defines the built-in interface block gl_PerVertex

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-02 Thread Marek Olšák
FragShaderText contains the shader code. Anyway, we have found the issue: expected[3] should really be set to 1.0, because RGB formats must return (r,g,b,1). It's a bug in the piglit test. Marek On Fri, Aug 2, 2013 at 11:44 PM, Martin Andersson wrote: > On Fri, Aug 2, 2013 at 2:52 PM, Marek Olšá

[Mesa-dev] [Bug 67692] [llvmpipe] piglit glsl-fs-frontfacing regression

2013-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67692 --- Comment #1 from Roland Scheidegger --- Looks like the gallium docs and the "old" tgsi_semantic_face value don't quite agree with what glsl actually wants: The shader does this: void main() { gl_FragColor = vec4(0.0,

[Mesa-dev] [PATCH v2] postprocess: Check ppq is null before calling pp_free_bos.

2013-08-02 Thread Vinson Lee
pp_free_bos dereferences ppq without a null check. Fixes "Dereference before null check" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/postprocess/pp_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/postproces