Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Michel Dänzer
On Don, 2013-05-02 at 05:45 +0200, Marek Olšák wrote: > --- > src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c > b/src/gallium/drivers/radeonsi/radeonsi_pipe.c > index c923c67..3

[Mesa-dev] [v4] EXT_image_dma_buf_import for intel

2013-05-02 Thread Topi Pohjolainen
The set introduces new target for 'eglCreateImageKHR()' allowing one to create EGL images out of externally allocated buffers. Especially one can combine up to three separate buffers into one single logical entity. Low level native buffers may not support planar formats and hence EGL layer will ins

[Mesa-dev] [v4 01/10] intel: allow packed prime buffers to be treated normally

2013-05-02 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c index ad1b351..1ba1279 100644 --- a/src/mesa/drivers/dri/in

[Mesa-dev] [v4 02/10] intel: do not create renderbuffers out of planar images

2013-05-02 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_fbo.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index 6730d26..6aaf6b6 100644 --- a/src/mesa/drivers/dri/intel/intel_fbo.c +++ b/src/

[Mesa-dev] [v4 03/10] intel: replace single region with a vector of regions

2013-05-02 Thread Topi Pohjolainen
No functional change in preparation for supporting multiple planes per image each having its own region. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_fbo.c | 6 +-- src/mesa/drivers/dri/intel/intel_regions.h | 7 ++- src/mesa/drivers/dri/intel/intel_screen.c

[Mesa-dev] [v4 04/10] intel: refactor planar format lookup

2013-05-02 Thread Topi Pohjolainen
v2: - refactor both occurences, not just one Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/in

[Mesa-dev] [v4 05/10] intel: set dri image dimensions even when creating out of primes

2013-05-02 Thread Topi Pohjolainen
Otherwise 'intel_set_texture_image_region()' won't have enough details to work with. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_s

[Mesa-dev] [v4 06/10] intel: prepare for dri images having more than one plane

2013-05-02 Thread Topi Pohjolainen
v2 (as advised by Eric): - use ARRAY_SIZE - re-use 'image_destroy' for cleaning up after failure - check directly the region pointer instead of the buffer object when determining if a region exists Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 103

[Mesa-dev] [v4 07/10] dri: propagate extra dma_buf import attributes to the drivers

2013-05-02 Thread Topi Pohjolainen
v2: - do not break ABI, but instead introduce new entry point for dma buffers and bump up the dri-interface version to eight Signed-off-by: Topi Pohjolainen --- include/GL/internal/dri_interface.h| 36 +- src/mesa/drivers/dri/intel/intel_regions.h | 7

[Mesa-dev] [v4 08/10] egl: update eglext.h from khronos

2013-05-02 Thread Topi Pohjolainen
Provides definitions for dma buffer import extension. Signed-off-by: Topi Pohjolainen --- include/EGL/eglext.h | 45 ++--- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h index b2b5a80..1d68178 100

[Mesa-dev] [v4 09/10] egl: definitions for EXT_image_dma_buf_import

2013-05-02 Thread Topi Pohjolainen
As specified in: http://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt Checking for the valid fourcc values is left for drivers avoiding dependency to drm header files here. v2: - enforce EGL_NO_CONTEXT v3: - declare the extension as EGL (not GLES) v4: -

[Mesa-dev] [v4 10/10] egl: dri2: support for creating images out of dma buffers

2013-05-02 Thread Topi Pohjolainen
v2: - upon success close the given file descriptors v3: - use specific entry for dma buffers instead of the basic for primes, and enable the extension based on the availability of the hook Signed-off-by: Topi Pohjolainen --- src/egl/drivers/dri2/egl_dri2.c | 280

Re: [Mesa-dev] [PATCH 1/3] r600g: increase array size for shader inputs and outputs

2013-05-02 Thread Michel Dänzer
On Don, 2013-05-02 at 05:45 +0200, Marek Olšák wrote: > and add assertions to prevent buffer overflow. This fixes corruption > of the r600_shader struct. Any pointers to tests exercising this? I noticed just yesterday that the corresponding code in radeonsi seems a bit wonky... -- Earthling Mi

[Mesa-dev] [PATCH 0/6] util/prim: clean up

2013-05-02 Thread Chia-I Wu
Hi list, This patch series attemps to clean up u_prim.h, with an exception that a new function to get the tessellated (as opposed to decomposed) primitive count is added by the last patch. I need that function for ilo to update PIPE_QUERY_PRIMITIVES_GENERATED.

[Mesa-dev] [PATCH 1/7] util/prim: fix primitive trimming for triangles with adjacency

2013-05-02 Thread Chia-I Wu
Fix for PIPE_PRIM_TRIANGLES_ADJACENCY and PIPE_PRIM_TRIANGLE_STRIP_ADJACENCY. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_prim.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/auxiliary/util/u_prim.h ind

[Mesa-dev] [PATCH 2/7] util/prim: clean up and add comments

2013-05-02 Thread Chia-I Wu
Move together (or add) functions to decompose/reduce/assemble a primitive, give them consistent names, and document them. Add u_prim_vertex_count() so that the vertex count information can be used elsewhere. u_assembled_primitive() will be removed in a folow-on commit. Signed-off-by: Chia-I Wu

[Mesa-dev] [PATCH 3/7] draw: use u_assembled_prim() instead of u_assembled_primitive()

2013-05-02 Thread Chia-I Wu
The latter function is also removed as a result of the change. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/draw/draw_prim_assembler.c |4 ++-- src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |2 +- src/gallium/auxiliary/util/u_prim.h |8

[Mesa-dev] [PATCH 4/7] util/prim: fix the name of the include guard

2013-05-02 Thread Chia-I Wu
It should be U_PRIM_H, not U_BLIT_H. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_prim.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/auxiliary/util/u_prim.h index b9c0c15..c6a0708 100644 --- a/src/gall

[Mesa-dev] [PATCH 5/7] util/prim: use vertex count info in u_validate_pipe_prim()

2013-05-02 Thread Chia-I Wu
As a side effect, primitives with adjacency are now correctly validated. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_prim.h | 34 ++ 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/a

[Mesa-dev] [PATCH 6/7] util/prim: assorted fixes for u_decomposed_prims_for_vertices()

2013-05-02 Thread Chia-I Wu
Switch to '>=' for comparisons, and it becomes obvious that the comparison for PIPE_PRIM_QUAD_STRIP was wrong. Add minimum vertex count check for PIPE_PRIM_LINE_LOOP. Return 1 for PIPE_PRIM_POLYGON with 3 vertices. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_prim.h | 22 +++

[Mesa-dev] [PATCH 7/7] util/prim: add u_reduced_prims_for_vertices()

2013-05-02 Thread Chia-I Wu
The function returns the number of reduced/tessellated primitives for the given vertex count. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_prim.h | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/auxiliary/util/u_prim.h b/src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Christian König
Am 02.05.2013 09:06, schrieb Michel Dänzer: On Don, 2013-05-02 at 05:45 +0200, Marek Olšák wrote: --- src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure

2013-05-02 Thread Christian König
Am 01.05.2013 21:17, schrieb Lauri Kasanen: Without this, the X lib path was not properly passed for tests/: /usr/bin/ld: cannot find -lXvMCW /usr/bin/ld: cannot find -lXvMC /usr/bin/ld: cannot find -lXv /usr/bin/ld: cannot find -lX11 collect2: ld returned 1 exit status Signed-off-by: Lauri Kasa

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Chris Wilson
On Wed, May 01, 2013 at 04:28:08PM -0700, Eric Anholt wrote: > The GPU apparently goes looking for constants even though there are no > shader stages enabled, and gets stuck because we haven't told it there are > no constants to collect. If any other user of the 3D pipeline had run > (even the Ren

[Mesa-dev] [PATCH] gallivm: Fix build with LLVM 3.3

2013-05-02 Thread Armin K
--- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index 717afa7..a531d98 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

[Mesa-dev] [PATCH] radeon: Fix build with LLVM 3.3

2013-05-02 Thread Armin K
--- src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.cpp b/src/gallium/drivers/radeon/radeon_llvm_emit.cpp index 55dad9b..e0ea31d 100644 --- a/src/gallium/drivers/radeon/radeon_llvm_em

Re: [Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

2013-05-02 Thread Jose Fonseca
- Original Message - > - Original Message - > > Am 02.05.2013 03:13, schrieb Zack Rusin: > > > It's valid. Some shaders do the negation on unsigned and then > > > use the results in opcodes taking signed integers. > > > > > > Signed-off-by: Zack Rusin > > > --- > > > src/galliu

Re: [Mesa-dev] [PATCH 2/2] draw/gs: don't crash when vs/gs signatures don't match

2013-05-02 Thread Jose Fonseca
- Original Message - > instead of crashing just fill zeros at the input slots that don't > match, that's the mandated behavior and it avoids debug asserts. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_gs.c | 93 > -- > 1 file

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Marek Olšák
Alright. I'm deleting the patch. Marek On Thu, May 2, 2013 at 9:06 AM, Michel Dänzer wrote: > On Don, 2013-05-02 at 05:45 +0200, Marek Olšák wrote: >> --- >> src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/gallium/d

Re: [Mesa-dev] [PATCH 1/3] r600g: increase array size for shader inputs and outputs

2013-05-02 Thread Marek Olšák
glsl-max-varyings uses 33 vertex shader outputs, but you need to be lucky to see any difference. In my case, there was a weird assertion failure during command buffer generation for a vertex shader (valgrind didn't help). I found the cause by moving the input and output arrays to the end of r600_sh

Re: [Mesa-dev] [PATCH] radeon/uvd: Fix build failure

2013-05-02 Thread Michel Dänzer
On Mit, 2013-05-01 at 19:26 +0300, Lauri Kasanen wrote: > Without this patch, radeon_uvd failed to find the libdrm includes: > > In file included from radeon_uvd.c:48: > ../../winsys/radeon/drm/radeon_winsys.h:44:35: error: > libdrm/radeon_surface.h: No such file or directory > > Signed-off-by:

[Mesa-dev] [Bug 63404] [wayland egl] intel_do_flush_locked failed: invalid argument, crash

2013-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63404 Emilio Pozuelo Monfort changed: What|Removed |Added CC||poch...@gmail.com -- You are r

[Mesa-dev] [PATCH 3/3] vl/idct: fix for commit 7d2f2a0c890b1993532a45c8c392c28950ddc06e

2013-05-02 Thread Christian König
From: Christian König We still need the option for handling 3D textures as well. Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=64143 Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c |6 +++--- src/gallium/auxiliary/vl/vl_video_buffer.c | 23 ++

[Mesa-dev] [PATCH 1/3] radeon/uvd: fix some MPEG4 artifacts

2013-05-02 Thread Christian König
From: Christian König Still not perfect, but a step in the right direction. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/

[Mesa-dev] [PATCH 2/3] vl/buffers: fix typo in function name

2013-05-02 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_video_buffer.c | 16 src/gallium/auxiliary/vl/vl_video_buffer.h | 10 +- src/gallium/drivers/r600/r600_uvd.c |6 +++--- src/gallium/drivers/radeonsi/radeonsi_uvd.c |

Re: [Mesa-dev] [PATCH 11/17] gallium: add PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE for GL

2013-05-02 Thread Brian Paul
On 05/01/2013 09:43 PM, Marek Olšák wrote: --- src/gallium/docs/source/screen.rst |2 ++ src/gallium/drivers/llvmpipe/lp_screen.c |2 ++ src/gallium/drivers/nv30/nv30_screen.c |1 + src/gallium/drivers/nv50/nv50_screen.c |2 ++ src/gallium/drivers/n

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-02 Thread Brian Paul
On 05/01/2013 09:42 PM, Marek Olšák wrote: Shaders are unified on most hardware (= same limits in all stages). No idea what the assertion was good for. --- src/mesa/main/config.h |6 ++ src/mesa/main/context.c|6 ++ src/mesa/state_tracker/st_ext

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Paul Berry
On 2 May 2013 02:13, Chris Wilson wrote: > On Wed, May 01, 2013 at 04:28:08PM -0700, Eric Anholt wrote: > > The GPU apparently goes looking for constants even though there are no > > shader stages enabled, and gets stuck because we haven't told it there > are > > no constants to collect. If any

Re: [Mesa-dev] [PATCH 11/17] gallium: add PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE for GL

2013-05-02 Thread Marek Olšák
Sorry, it's a typo. I'll fix that. Marek On Thu, May 2, 2013 at 4:23 PM, Brian Paul wrote: > On 05/01/2013 09:43 PM, Marek Olšák wrote: >> >> --- >> src/gallium/docs/source/screen.rst |2 ++ >> src/gallium/drivers/llvmpipe/lp_screen.c |2 ++ >> src/gallium/drivers/nv30/

[Mesa-dev] [PATCH] radeon/uvd: enable interlaced buffers by default

2013-05-02 Thread Christian König
From: Christian König Kills tilling on UVD buffers, but we currently don't really need that. Signed-off-by: Christian König --- src/gallium/drivers/r600/r600_uvd.c |6 +++--- src/gallium/drivers/radeon/radeon_uvd.c |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --g

[Mesa-dev] [Bug 64153] Mesa fails to build against master llvm

2013-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64153 Rafael Castillo changed: What|Removed |Added Priority|medium |highest Assignee|i...@freede

Re: [Mesa-dev] r600 sb test results

2013-05-02 Thread Lauri Kasanen
On Thu, 02 May 2013 00:45:13 +0400 Vadim Girlin wrote: > On 05/01/2013 11:36 PM, Lauri Kasanen wrote: > > Now that it built, I could test your optimizations in my own apps. > > These are on current master 8eef6ad, on a RV710 (HD 4350 pci-e). > > > > In one of my private apps, using R600_DEBUG=sb

Re: [Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

2013-05-02 Thread Roland Scheidegger
Am 02.05.2013 13:22, schrieb Jose Fonseca: > > > - Original Message - >> - Original Message - >>> Am 02.05.2013 03:13, schrieb Zack Rusin: It's valid. Some shaders do the negation on unsigned and then use the results in opcodes taking signed integers. Signed-of

Re: [Mesa-dev] [v4 08/10] egl: update eglext.h from khronos

2013-05-02 Thread Matt Turner
On Thu, May 2, 2013 at 12:08 AM, Topi Pohjolainen wrote: > Provides definitions for dma buffer import extension. > > Signed-off-by: Topi Pohjolainen > --- Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.f

[Mesa-dev] [PATCH] gallium: Fix build with LLVM >= r180881

2013-05-02 Thread Tom Stellard
From: Tom Stellard --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 - src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.

[Mesa-dev] [Bug 64153] Mesa fails to build against master llvm

2013-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64153 --- Comment #1 from Tom Stellard --- Created attachment 78784 --> https://bugs.freedesktop.org/attachment.cgi?id=78784&action=edit Build fix This patch should fix it. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure

2013-05-02 Thread Matt Turner
On Wed, May 1, 2013 at 12:17 PM, Lauri Kasanen wrote: > Without this, the X lib path was not properly passed for tests/: > /usr/bin/ld: cannot find -lXvMCW > /usr/bin/ld: cannot find -lXvMC > /usr/bin/ld: cannot find -lXv > /usr/bin/ld: cannot find -lX11 > collect2: ld returned 1 exit status > > S

[Mesa-dev] [PATCH 3/3] radeon/llvm: Always build libradeonllvm as static

2013-05-02 Thread Tom Stellard
From: Tom Stellard This library is very small, so there is not much to gain from building it as a shared library. Also, when linking statically with LLVM, a shared libradeonllvm exports LLVM symbols and creates problems when used with other shared objects that also link statically to LLVM. ---

[Mesa-dev] [PATCH 1/3] gallivm: Move LLVMStartMultithreaded() static initializer into gallivm

2013-05-02 Thread Tom Stellard
From: Tom Stellard This does not solve all of the problems with using LLVM in a multithreaded enivronment, but it should help in some cases. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 +++ src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 14 -- 2 files chan

[Mesa-dev] [PATCH 2/3] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA v2

2013-05-02 Thread Tom Stellard
From: Tom Stellard The LLVM C API is considered stable and should never change, so it is much more desirable to use than the LLVM C++ API, which is constantly in flux. v2: - Split target initialization and lookup into separate functions --- src/gallium/drivers/radeon/Makefile.am |

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Vadim Girlin
On 05/02/2013 11:06 AM, Michel Dänzer wrote: On Don, 2013-05-02 at 05:45 +0200, Marek Olšák wrote: --- src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] gallium: Fix build with LLVM >= r180881

2013-05-02 Thread Armin K.
On 05/02/2013 04:56 PM, Tom Stellard wrote: From: Tom Stellard --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 - src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.

[Mesa-dev] [Bug 64153] Mesa fails to build against master llvm

2013-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64153 --- Comment #2 from Rafael Castillo --- fixed thank you very much -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org htt

[Mesa-dev] [Bug 64153] Mesa fails to build against master llvm

2013-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64153 Rafael Castillo changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Chris Wilson
On Thu, May 02, 2013 at 07:26:06AM -0700, Paul Berry wrote: >Can you provide a documentation reference for why the value we're >currently programming (0xf001) is unsafe, and why 0x7fff0001 is >correct?� I don't see anything in the bspec. The largest GTT size for gen6 is 2GiB (it ca

[Mesa-dev] [PATCH 1/4] r600g/sb: fix allocation of indirectly addressed input arrays

2013-05-02 Thread Vadim Girlin
Some inputs may be preloaded into predefined GPRs, so we can't reallocate arrays with such inputs. Fixes issues with webgl demo: http://oos.moxiecode.com/js_webgl/snake/ Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/sb/sb_ra_coalesce.cpp | 14 +- src/gallium/drivers/r600/

[Mesa-dev] [PATCH 2/4] r600g/sb: fix handling of interference sets in post_scheduler

2013-05-02 Thread Vadim Girlin
post_scheduler clears interference set for reallocatable values when the value becomes live first time, and then updates it to take into account modified order of operations, but this was not handled properly if the value appears first time as a source in copy operation. Fixes issues with webgl de

[Mesa-dev] [PATCH 3/4] r600g/sb: silence warnings with gcc 4.8

2013-05-02 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/sb/sb_ra_init.cpp | 25 +++-- src/gallium/drivers/r600/sb/sb_sched.cpp | 4 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_ra_init.cpp b/src/gallium/drivers/r600/

[Mesa-dev] [PATCH 4/4] r600g/sb: don't run unnecessary passes

2013-05-02 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/sb/sb_core.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_core.cpp b/src/gallium/drivers/r600/sb/sb_core.cpp index 9f81ed4..b919fa4 100644 --- a/src/gallium/drivers/r600/sb/sb_core.cpp +++ b/src/ga

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Marek Olšák
AFAIK, there are 16 fetch shader resources. These are the resource slots for r600: [offset .. +count] PS: 0 .. +160 VS: 160 .. +160 FS: 320 .. +16 GS: 336 .. +160 Marek On Thu, May 2, 2013 at 5:04 PM, Vadim Girlin wrote: > On 05/02/2013 11:06 AM, Michel Dänzer wrote: >> >> On Don, 2013-05-02

Re: [Mesa-dev] [PATCH] gallium: Fix build with LLVM >= r180881

2013-05-02 Thread Tom Stellard
On Thu, May 02, 2013 at 05:18:51PM +0200, Armin K. wrote: > On 05/02/2013 04:56 PM, Tom Stellard wrote: > >From: Tom Stellard > > > >--- > > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 - > > src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 2 +- > > 2 files changed, 9 insertions

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Eric Anholt
Chris Wilson writes: > On Thu, May 02, 2013 at 07:26:06AM -0700, Paul Berry wrote: >>Can you provide a documentation reference for why the value we're >>currently programming (0xf001) is unsafe, and why 0x7fff0001 is >>correct?� I don't see anything in the bspec. > > The largest G

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Alex Deucher
On Thu, May 2, 2013 at 11:55 AM, Marek Olšák wrote: > AFAIK, there are 16 fetch shader resources. These are the resource > slots for r600: > > [offset .. +count] > PS: 0 .. +160 > VS: 160 .. +160 > FS: 320 .. +16 > GS: 336 .. +160 It's bigger on evergreen: PS: 0.. +176 VS: 176.. +160 GS: 336..

Re: [Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

2013-05-02 Thread Zack Rusin
- Original Message - > > I don't oppose either. Integer signedness has always been too loose for us > > to be pedantic about it here. > > > > Ok. We should update tgsi docs to reflect that, however. > Note that we already moved some opcodes (ok only one, uadd) to the > signed section in

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Vadim Girlin
On 05/02/2013 07:55 PM, Marek Olšák wrote: AFAIK, there are 16 fetch shader resources. These are the resource slots for r600: Ah, you are right (though it's higher on EG as Alex wrote). Anyway, I'm not against your patch, I just wanted to understand where this limit comes from. I think this ca

Re: [Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

2013-05-02 Thread Roland Scheidegger
Am 02.05.2013 18:16, schrieb Zack Rusin: > - Original Message - >>> I don't oppose either. Integer signedness has always been too loose for us >>> to be pedantic about it here. >>> >> >> Ok. We should update tgsi docs to reflect that, however. >> Note that we already moved some opcodes (ok

Re: [Mesa-dev] [PATCH 2/3] glsl: add AMD_vertex_shader_layer support

2013-05-02 Thread Ian Romanick
On 05/01/2013 08:41 PM, Jordan Justen wrote: On Tue, Apr 30, 2013 at 10:01 AM, Jordan Justen wrote: On Tue, Apr 30, 2013 at 9:57 AM, Ian Romanick wrote: On 04/27/2013 04:32 PM, Jordan Justen wrote: This GLSL extension requires that AMD_vertex_shader_layer be enabled by the driver. Most (a

Re: [Mesa-dev] [PATCH] r600g/llvm: Undefines unrequired texture coord values

2013-05-02 Thread Tom Stellard
On Tue, Apr 30, 2013 at 03:59:43PM +0200, Vincent Lejeune wrote: > This is a port of "r600g:mask unused source components for SAMPLE" > patch from Vadim Girlin. Reviewed-by: Tom Stellard Can you wrap those long line before you commit. > --- > src/gallium/drivers/r600/r600_llvm.c | 25 ++

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-02 Thread Eric Anholt
Marek Olšák writes: > Shaders are unified on most hardware (= same limits in all stages). > No idea what the assertion was good for. > --- > src/mesa/main/config.h |6 ++ > src/mesa/main/context.c|6 ++ > src/mesa/state_tracker/st_extensions.c |

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix the max vertex shader input limit

2013-05-02 Thread Marek Olšák
There is a single limit in OpenGL - GL_MAX_VERTEX_ATTRIBS, and there is one-to-one mapping between vertex array bindings and vertex shader inputs. Anyway, the core Mesa limit is 16 at the moment and I don't plan to change it (the vbo module has to analyze all available vertex attribs no matter how

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Kenneth Graunke
On 05/02/2013 02:13 AM, Chris Wilson wrote: On Wed, May 01, 2013 at 04:28:08PM -0700, Eric Anholt wrote: The GPU apparently goes looking for constants even though there are no shader stages enabled, and gets stuck because we haven't told it there are no constants to collect. If any other user o

Re: [Mesa-dev] [PATCH 07/17] mesa: add & use a new driver flag for UBO updates instead of _NEW_BUFFER_OBJECT

2013-05-02 Thread Eric Anholt
Marek Olšák writes: > diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.c > b/src/mesa/drivers/dri/intel/intel_buffer_objects.c > index 996518b..f941c56 100644 > --- a/src/mesa/drivers/dri/intel/intel_buffer_objects.c > +++ b/src/mesa/drivers/dri/intel/intel_buffer_objects.c > @@ -39,6

Re: [Mesa-dev] [PATCH 17/17] glsl: fix checking against the max uniform limit with UBOs

2013-05-02 Thread Eric Anholt
Marek Olšák writes: > MaxUniformComponents contains only the limit for the default uniform buffer, > but the linker also adds all uniforms blocks to the uniform usage stats, > causing bogus linker failures. So now you can have MaxCombinedUniformComponents in the default uniform block? It seems

Re: [Mesa-dev] [PATCH 01/12] sso: Create extensions entry points

2013-05-02 Thread gregory hainaut
On Fri, 12 Apr 2013 13:52:46 -0700 Eric Anholt wrote: > gregory hainaut writes: > > > On Fri, 12 Apr 2013 12:38:19 -0700 > > Eric Anholt wrote: > > > >> Please, patches for Mesa have to actually be addressed to Mesa. > > > > What do you mean? The github tree (was requested by Jordan)? Or > > b

Re: [Mesa-dev] [PATCH 01/12] sso: Create extensions entry points

2013-05-02 Thread Jordan Justen
On Thu, May 2, 2013 at 11:28 AM, gregory hainaut wrote: > On Fri, 12 Apr 2013 13:52:46 -0700 > Eric Anholt wrote: >> gregory hainaut writes: >> > On Fri, 12 Apr 2013 12:38:19 -0700 >> > Eric Anholt wrote: >> > >> >> Please, patches for Mesa have to actually be addressed to Mesa. >> > >> > What

Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure

2013-05-02 Thread Lauri Kasanen
On Thu, 2 May 2013 07:58:30 -0700 Matt Turner wrote: > > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 > > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 > > Doesn't XVMC_LIBS include all of those other libraries? I think > they're now redundant and should be removed. It doesn't here: XVMC_LIBS =

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Chris Wilson
On Thu, May 02, 2013 at 09:07:08AM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > On Thu, May 02, 2013 at 07:26:06AM -0700, Paul Berry wrote: > >>Can you provide a documentation reference for why the value we're > >>currently programming (0xf001) is unsafe, and why 0x7fff0001

Re: [Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

2013-05-02 Thread Zack Rusin
> Well in contrast to the IF/UIF they'd be really redundant unless I'm > missing something so just for supporting negation on inputs or not this > looks like not really worth it (and as said there are also other signed > instructions where supporting negation doesn't really make sense). OTOH > you'

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Paul Berry
On 2 May 2013 12:54, Chris Wilson wrote: > On Thu, May 02, 2013 at 09:07:08AM -0700, Eric Anholt wrote: > > Chris Wilson writes: > > > > > On Thu, May 02, 2013 at 07:26:06AM -0700, Paul Berry wrote: > > >>Can you provide a documentation reference for why the value we're > > >>currently p

Re: [Mesa-dev] [PATCH 0/6] util/prim: clean up

2013-05-02 Thread Zack Rusin
- Original Message - > Hi list, > > This patch series attemps to clean up u_prim.h, with an exception that a new > function to get the tessellated (as opposed to decomposed) primitive count is > added by the last patch. I need that function for ilo to update > PIPE_QUERY_PRIMITIVES_GENERA

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs when a blorp batch is the first thing to execute.

2013-05-02 Thread Kenneth Graunke
On 05/02/2013 01:08 PM, Paul Berry wrote: On 2 May 2013 12:54, Chris Wilson mailto:ch...@chris-wilson.co.uk>> wrote: On Thu, May 02, 2013 at 09:07:08AM -0700, Eric Anholt wrote: > Chris Wilson mailto:ch...@chris-wilson.co.uk>> writes: > > > On Thu, May 02, 2013 at 07:26:06AM -

Re: [Mesa-dev] [PATCH] st/xvmc/tests: Fix build failure

2013-05-02 Thread Matt Turner
On Thu, May 2, 2013 at 11:52 AM, Lauri Kasanen wrote: > On Thu, 2 May 2013 07:58:30 -0700 > Matt Turner wrote: > >> > -TEST_LIBS = -lXvMCW -lXvMC -lXv -lX11 >> > +TEST_LIBS = $(XVMC_LIBS) -lXvMCW -lXvMC -lXv -lX11 >> >> Doesn't XVMC_LIBS include all of those other libraries? I think >> they're no

Re: [Mesa-dev] [PATCH 1/7] i965/vs: Do round-robin register allocation on gen6+ like we do in the FS.

2013-05-02 Thread Kenneth Graunke
On 04/30/2013 09:15 AM, Eric Anholt wrote: This will free instruction scheduling to make better choices. No statistically significant performance difference on GLB2.7 (n=93). --- src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp |4 1 file changed, 4 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 05/14] glsl: Add constant evaluation of bit built-ins.

2013-05-02 Thread Matt Turner
v2: Order bits from LSB end (31 - count) for ir_unop_find_msb. v3: Add ir_triop_bitfield_extract as an exception to the op[0]->type == op[1]->type assertion in ir_constant_expression.cpp. Reviewed-by: Chris Forbes [v2] --- src/glsl/ir_constant_expression.cpp | 126 +++

[Mesa-dev] [PATCH] i965/gen7: Set src/dst types for 3-src instructions.

2013-05-02 Thread Matt Turner
Also update asserts to allow BFE and BFI2, which take (unsigned) doubleword arguments. v2: Allow BRW_REGISTER_TYPE_UD for src1 and src2 as well. Assert that src2.type (instead of src0.type) matches dest.type since it's the primary argument and src0 and src1 might correctly have differe

[Mesa-dev] [PATCH 12/14] i965/fs: Add support for bit instructions.

2013-05-02 Thread Matt Turner
Don't bother scalarizing ir_binop_bfm, since its results are identical for all channels. v2: Subtract result of FBH from 31 (unless an error) to convert MSB counts to LSB counts. v3: Use op0->clone() in ir_triop_bfi to prevent (var_ref channel_expressions) from appearing multiple times in

[Mesa-dev] [PATCH 14/14] i965: Lower bitfieldInsert.

2013-05-02 Thread Matt Turner
v2: Only lower bitfieldInsert to BFM+BFI (and don't lower bitfieldExtract at all) since three-source instructions are now usable in the vertex shader. v3: Lower bitfield_insert in the same pass with everything else, since it doesn't produce any instructions to be lowered (the other two

[Mesa-dev] [PATCH 15/14] i965/fs: Don't emit 16-wide BFI1 instructions.

2013-05-02 Thread Matt Turner
The Haswell Bspec says "A SIMD16 instruction is not allowed." (but 16-wide BFI1 works for me so far). Since GLSL's bitfieldInsert() function takes int parameters BFI1 produces the same results in all channels, so there's never any reason to emit a 16-wide BFI1. --- src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH] i965: Enable fast clears on non-8x4-aligned sizes.

2013-05-02 Thread Eric Anholt
Improves glb2.7 performance at a misaligned size by 2.3% +/- 0.7% (n=11). The workaround was to avoid bad primitive/surface sizes, but that's worked around as of a14dc4f92cdad6177d83f051a088a66e31a973bc. (One might note that pre-gen7 we don't know that the right half of an 8x4 at the right edge is

[Mesa-dev] X.Org Google Summer of Code

2013-05-02 Thread Alex Deucher
Just a reminder to all students and mentors planning to work on an X.Org GSoC project this year, the deadline for applications is tomorrow (May 3rd, 19:00 UTC). If you are a student planning to apply, please submit your application by the deadline. If you are planning to mentor a project and have

[Mesa-dev] [PATCH] tgsi/ureg: make the dst register match the src indirection

2013-05-02 Thread Zack Rusin
In ureg src registers could have an indirect register that was either a temp or an addr register, while dst registers allowed only addr. That made moving between them a little difficult so make them behave the same way and allow temp's and addr registers as indirect files for both (tgsi supports it

Re: [Mesa-dev] r600 sb test results

2013-05-02 Thread Vadim Girlin
On 05/02/2013 06:34 PM, Lauri Kasanen wrote: On Thu, 02 May 2013 00:45:13 +0400 Vadim Girlin wrote: On 05/01/2013 11:36 PM, Lauri Kasanen wrote: Now that it built, I could test your optimizations in my own apps. These are on current master 8eef6ad, on a RV710 (HD 4350 pci-e). In one of my pr

[Mesa-dev] [PATCH] i965/fs: Prefer picking texture ops when instruction scheduling.

2013-05-02 Thread Matt Turner
Texture operations have very long (hundreds of cycles) latencies. If a texture operation is ready to be scheduled, prefer it over other types of instructions. Typically this will mean the other instructions execute to completion during the time it takes the texturing operation to return results, s

Re: [Mesa-dev] [PATCH 1/7] i965/vs: Do round-robin register allocation on gen6+ like we do in the FS.

2013-05-02 Thread Matt Turner
On Tue, Apr 30, 2013 at 9:15 AM, Eric Anholt wrote: > This will free instruction scheduling to make better choices. No > statistically significant performance difference on GLB2.7 (n=93). > --- Series is: Reviewed-by: Matt Turner ___ mesa-dev mailing

[Mesa-dev] [PATCH 1/2] vbo: create a few utility functions for merging primitives

2013-05-02 Thread Brian Paul
To be used by following commit. --- src/mesa/vbo/vbo.h | 10 + src/mesa/vbo/vbo_exec.c | 94 +++ 2 files changed, 104 insertions(+), 0 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 9f800d8..08c67d6 100644 --- a/src

[Mesa-dev] [PATCH 2/2] vbo: implement primitive merging for glBegin/End sequences

2013-05-02 Thread Brian Paul
A surprising number of apps and benchmarks have poor code like this: glBegin(GL_LINE_STRIP); glVertex(v1); glVertex(v2); glEnd(); // Possibly some no-op state changes here glBegin(GL_LINE_STRIP); glVertex(v3); glVertex(v4); glEnd(); // repeat many, many times. The above sequence can be converted

[Mesa-dev] [PATCH 1/6] vbo: update comments for vbo_save_NotifyBegin()

2013-05-02 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 9ce3c6e..aa57ee7 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -928,8 +928,10 @@ _sav

[Mesa-dev] [PATCH 2/6] mesa; change ctx->Driver.SaveNeedFlush to boolean, and document it.

2013-05-02 Thread Brian Paul
--- src/mesa/main/dd.h |3 ++- src/mesa/vbo/vbo_save_api.c |8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index bc93026..c5531a4 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -703,8 +703,9 @@ struct

[Mesa-dev] [PATCH 3/6] mesa: change ctx->Driver.NeedFlush to GLbitfield and update comment

2013-05-02 Thread Brian Paul
--- src/mesa/main/dd.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index c5531a4..adace3b 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -696,13 +696,13 @@ struct dd_function_table { #define FLUSH_UPDATE_CURREN

[Mesa-dev] [PATCH 4/6] vbo: use new no-op ArrayElement in _mesa_noop_vtxfmt_init()

2013-05-02 Thread Brian Paul
As we do for the other commands which can appear between glBegin/End. --- src/mesa/vbo/vbo_noop.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_noop.c b/src/mesa/vbo/vbo_noop.c index 8ba4959..f869845 100644 --- a/src/mesa/vbo/vbo_noop.c +++ b/src

  1   2   >