Re: [Mesa-dev] [PATCH] sp_tex_sample: Fix stupid copy/paste error.

2012-07-25 Thread Olivier Galibert
[Sorry, mail was down yesterday] On Tue, Jul 24, 2012 at 10:06:05AM -0600, Brian Paul wrote: > Does this fix bug 52369? Yes. > Do you need me to commit this for you? Yes please. Perhaps I should see about getting a fdo account. Best, OG. ___ me

[Mesa-dev] [PATCH] gallium: specify resource_resolve destination via a pipe_surface

2012-07-25 Thread Christoph Bumiller
The format member of pipe_surface may differ from that of the pipe_resource, which is used to communicate, for instance, whether sRGB encode should be enabled in the resolve operation or not. Fixes resolve to sRGB surfaces in mesa/st when GL_FRAMEBUFFER_SRGB is disabled. --- src/gallium/drivers/n

[Mesa-dev] [PATCH] mesa: loosen small matrix determinant check

2012-07-25 Thread Brian Paul
When computing a matrix inverse, if the determinant is too small we could hit a divide by zero. There's a check to prevent this (we basically give up on computing the inverse and return the identity matrix.) This patch loosens this test to fix a lighting bug reported by Lars Henning Wendt. v2: u

[Mesa-dev] [PATCH] mesa: remove _math_matrix_alloc_inv()

2012-07-25 Thread Brian Paul
Always allocate space for the inverse matrix in _math_matrix_ctr() since we were always calling _math_matrix_alloc_inv() anyway. --- src/mesa/main/matrix.c|4 +-- src/mesa/math/m_matrix.c | 51 - src/mesa/math/m_matrix.h |

[Mesa-dev] [Bug 52369] [softpipe] piglit mipmap-setup regression

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52369 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #13 from Brian Paul 2012-07-25 13:53:09 PDT --- Sorry, I misread your update too quickly and thought that you had added some assertions. I think we still need to get to the root cause of those before trying to diagnose performance p

Re: [Mesa-dev] [PATCH] scons: Fix build with clang.

2012-07-25 Thread Brian Paul
On 07/25/2012 12:06 AM, Vinson Lee wrote: Signed-off-by: Vinson Lee --- scons/gallium.py |3 ++- src/gallium/winsys/svga/drm/SConscript |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scons/gallium.py b/scons/gallium.py index 001a5de..458651

Re: [Mesa-dev] Check the compilation problems in mesa-user

2012-07-25 Thread Brian Paul
On 07/23/2012 07:06 PM, Juhana Sadeharju wrote: Hello. Would you please check the compilation problem posted at mesa-user? Could you repost the issue here where more developers can see it? Several days passed and no software renderer. I rather would like to test the llvmpipe than fix the co

Re: [Mesa-dev] [PATCH] gallium: specify resource_resolve destination via a pipe_surface

2012-07-25 Thread Brian Paul
On 07/25/2012 05:54 AM, Christoph Bumiller wrote: The format member of pipe_surface may differ from that of the pipe_resource, which is used to communicate, for instance, whether sRGB encode should be enabled in the resolve operation or not. Fixes resolve to sRGB surfaces in mesa/st when GL_FRAM

[Mesa-dev] [Bug 52282] [softpipe] piglit arb_shader_texture_lod-texgrad regression

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52282 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [PATCH 1/4] mesa: Make more consistent use of _mesa_is_{user, winsys}_fbo()

2012-07-25 Thread Paul Berry
A lot of code was still differentiating between between winsys and user fbos by testing the fbo's name against zero. This converts everything in core mesa, the state tracker, and src/mesa/program over to use _mesa_is_user_fbo() and _mesa_is_winsys_fbo(). --- src/mesa/main/context.c

[Mesa-dev] [PATCH 2/4] intel: Make more consistent use of _mesa_is_{user, winsys}_fbo()

2012-07-25 Thread Paul Berry
A lot of code was still differentiating between between winsys and user fbos by testing the fbo's name against zero. This converts everything in the i915 and 965 drivers over to use _mesa_is_user_fbo() and _mesa_is_winsys_fbo(). --- src/mesa/drivers/dri/i915/i830_vtbl.c |3 ++- src/

[Mesa-dev] [PATCH 3/4] i965/msaa: Remove TODO comments that are no longer relevant.

2012-07-25 Thread Paul Berry
--- src/mesa/drivers/dri/i965/brw_state_upload.c |4 ++-- src/mesa/drivers/dri/i965/gen6_blorp.cpp |1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c index 551fa6a..12535ed 10

[Mesa-dev] [PATCH 4/4] i965: Use sendc for all render target writes on Gen6+.

2012-07-25 Thread Paul Berry
The sendc instruction causes the fragment shader thread to wait for any dependent threads (i.e. threads rendering to overlapping pixels) to complete before sending the message. We need to use sendc on the first render target write in order to guarantee that fragment shader outputs are written to t

Re: [Mesa-dev] [PATCH 1/4] mesa: Make more consistent use of _mesa_is_{user, winsys}_fbo()

2012-07-25 Thread Brian Paul
On 07/25/2012 08:19 AM, Paul Berry wrote: A lot of code was still differentiating between between winsys and user fbos by testing the fbo's name against zero. This converts everything in core mesa, the state tracker, and src/mesa/program over to use _mesa_is_user_fbo() and _mesa_is_winsys_fbo().

Re: [Mesa-dev] Check the compilation problems in mesa-user

2012-07-25 Thread Matt Turner
On Wed, Jul 25, 2012 at 6:57 AM, Brian Paul wrote: >> Several days passed and no software renderer. >> I rather would like to test the llvmpipe >> than fix the compiler... >> >> What is the status with OSMesa and llvmpipe? > > > OSMesa only works with the legacy swrast driver, not llvmpipe. One t

Re: [Mesa-dev] Check the compilation problems in mesa-user

2012-07-25 Thread Brian Paul
On 07/25/2012 09:01 AM, Matt Turner wrote: On Wed, Jul 25, 2012 at 6:57 AM, Brian Paul wrote: Several days passed and no software renderer. I rather would like to test the llvmpipe than fix the compiler... What is the status with OSMesa and llvmpipe? OSMesa only works with the legacy swrast

Re: [Mesa-dev] Check the compilation problems in mesa-user

2012-07-25 Thread Eric Anholt
Brian Paul writes: > On 07/25/2012 09:01 AM, Matt Turner wrote: >> On Wed, Jul 25, 2012 at 6:57 AM, Brian Paul wrote: Several days passed and no software renderer. I rather would like to test the llvmpipe than fix the compiler... What is the status with OSMesa and llvmpi

Re: [Mesa-dev] Check the compilation problems in mesa-user

2012-07-25 Thread Brian Paul
On 07/25/2012 10:57 AM, Eric Anholt wrote: Brian Paul writes: On 07/25/2012 09:01 AM, Matt Turner wrote: On Wed, Jul 25, 2012 at 6:57 AM, Brian Paul wrote: Several days passed and no software renderer. I rather would like to test the llvmpipe than fix the compiler... What is the status wi

Re: [Mesa-dev] [PATCH 1/4] mesa: Make more consistent use of _mesa_is_{user, winsys}_fbo()

2012-07-25 Thread Kenneth Graunke
On 07/25/2012 07:19 AM, Paul Berry wrote: > A lot of code was still differentiating between between winsys and > user fbos by testing the fbo's name against zero. This converts > everything in core mesa, the state tracker, and src/mesa/program over > to use _mesa_is_user_fbo() and _mesa_is_winsys_

Re: [Mesa-dev] [PATCH 2/4] intel: Make more consistent use of _mesa_is_{user, winsys}_fbo()

2012-07-25 Thread Kenneth Graunke
On 07/25/2012 07:20 AM, Paul Berry wrote: > A lot of code was still differentiating between between winsys and > user fbos by testing the fbo's name against zero. This converts > everything in the i915 and 965 drivers over to use _mesa_is_user_fbo() > and _mesa_is_winsys_fbo(). > --- > src/mesa/d

Re: [Mesa-dev] [PATCH 4/4] i965: Use sendc for all render target writes on Gen6+.

2012-07-25 Thread Kenneth Graunke
On 07/25/2012 07:20 AM, Paul Berry wrote: > The sendc instruction causes the fragment shader thread to wait for > any dependent threads (i.e. threads rendering to overlapping pixels) > to complete before sending the message. We need to use sendc on the > first render target write in order to guara

Re: [Mesa-dev] [PATCH] mesa: remove _math_matrix_alloc_inv()

2012-07-25 Thread Kenneth Graunke
On 07/25/2012 06:33 AM, Brian Paul wrote: > Always allocate space for the inverse matrix in _math_matrix_ctr() > since we were always calling _math_matrix_alloc_inv() anyway. > --- > src/mesa/main/matrix.c|4 +-- > src/mesa/math/m_matrix.c | 51 > ---

Re: [Mesa-dev] [PATCH 04/15] intel: Refactor quantize_num_samples

2012-07-25 Thread Eric Anholt
Chad Versace writes: > Rename quantize_num_samples to intel_quantize_num_samples and change the > first param from struct intel_context* to struct intel_screen*. The > function will later be used by intelCreateBuffer, which is not bound to > any context but is bound to a screen. Since the functio

Re: [Mesa-dev] [PATCH 05/15] intel: Set num samples for winsys renderbuffers

2012-07-25 Thread Eric Anholt
Chad Versace writes: > Add a new param, num_samples, to intel_create_renderbuffer and > intel_create_private_renderbuffer. The caller, intelCreateBuffer, passes > in the value of gl_config::NumSamples. > > No multisample GL config is yet advertised, so the value of num_samples is > currently 0. >

[Mesa-dev] [PATCH 2/5] radeonsi: fix shader size and handling

2012-07-25 Thread Christian König
We should always upload the shader here. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 26 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 1/5] radeonsi: rename r600_resource to si_resource

2012-07-25 Thread Christian König
Also split it into seperate header and add some helper functions. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/r600.h| 21 ++ src/gallium/drivers/radeonsi/r600_buffer.c | 12 ++-- src/gallium/drivers/radeonsi/r600_hw_context.c | 23 +++

[Mesa-dev] [PATCH 3/5] radeonsi: fix vertex buffer and elements

2012-07-25 Thread Christian König
Let's just use the T# descriptors until we get a fetch shader. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c |6 +- src/gallium/drivers/radeonsi/si_state.c| 43 +++-- src/gallium/drivers/radeonsi/si_state.h|9 +-- src/gallium/

[Mesa-dev] [PATCH 4/5] radeonsi: fix register count calculation

2012-07-25 Thread Christian König
Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_state_draw.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 0d9f009..74ed01f 100644 --- a/src/galli

[Mesa-dev] [PATCH 5/5] radeonsi: fix dst clobber of buffer loads

2012-07-25 Thread Christian König
Signed-off-by: Christian König --- src/gallium/drivers/radeon/SIInstrInfo.td |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/SIInstrInfo.td b/src/gallium/drivers/radeon/SIInstrInfo.td index aac6443..3fcf4e2 100644 --- a/src/gallium/drivers/radeon/SIInstrInfo.t

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-25 Thread Eric Anholt
Chad Versace writes: > Transform the code from clever, obfuscated, and imperative to > straight-forward and table-driven. I don't like this change. It increases the amount of code, and to change any single option, you need to change more code. If we were to change back_buffer_modes (and I thin

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #14 from Barto 2012-07-25 18:56:11 PDT --- (In reply to comment #13) > I also tried forcing fallback=1 so that _swrast_DrawPixels() gets called but I > didn't see any failed assertions. I'm using the Mesa 8.0.x branch. > > I don't

Re: [Mesa-dev] [PATCH v2, android-build] android-build: fix dricore build for autogenerated files

2012-07-25 Thread Chad Versace
On 07/23/2012 12:13 PM, Daniel Charles wrote: > Recently more files were removed from control to be auto-generated > in the dricore library. Android build was not able to locate the > new files if they were not created beforehand. > > LOCAL_SRC_FILES includes some of those files and Android.gen.mk

Re: [Mesa-dev] Can --enable-shared-glapi die?

2012-07-25 Thread Calvin Walton
On Tue, 2012-07-24 at 10:45 -0700, Ian Romanick wrote: > On 07/23/2012 12:59 PM, Ian Romanick wrote: > > Perhaps someone can refresh my memory as to what exactly this option > > does? Can we make this the default and remove the option from configure? > > Thanks to all for the refresher. Off-list

Re: [Mesa-dev] [PATCH 1/5] radeonsi: rename r600_resource to si_resource

2012-07-25 Thread Alex Deucher
On Wed, Jul 25, 2012 at 1:58 PM, Christian König wrote: > Also split it into seperate header and add > some helper functions. > > Signed-off-by: Christian König For the series: Reviewed-by: Alex Deucher ___ mesa-dev mailing list mesa-dev@lists.freede

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #15 from Brian Paul 2012-07-25 22:22:58 PDT --- (In reply to comment #14) > Brian, can you tell me what are the differences in swrast component between > the > 7.11.2-1 mesa release version and the 8.0.x release ? There's a ton of

Re: [Mesa-dev] [PATCH 00/15] i965: Enable window system multisampling

2012-07-25 Thread Paul Berry
On 21 July 2012 17:36, Chad Versace wrote: > No Piglit regressions on Ivybridge. > > Tested with `glxgears -samples 1`. > > Passes 53/70 of oglconform's winsys multisample tests. The failing tests > mostly consist of those that call glDrawPixels on the depth and stencil > buffer (which fail due t

[Mesa-dev] [PATCH] xlib: add X error handler around XGetImage() call

2012-07-25 Thread Brian Paul
XGetImage() will generate a BadMatch error if the source window isn't visible. When that happens, create a new XImage. Fixes piglit 'select' test failures with swrast/xlib driver. NOTE: This is a candidate for the 8.0 branch. --- src/mesa/drivers/x11/xm_buffer.c | 29 +

Re: [Mesa-dev] [PATCH 4/4] i965: Use sendc for all render target writes on Gen6+.

2012-07-25 Thread Eric Anholt
Paul Berry writes: > The sendc instruction causes the fragment shader thread to wait for > any dependent threads (i.e. threads rendering to overlapping pixels) > to complete before sending the message. We need to use sendc on the > first render target write in order to guarantee that fragment sh

[Mesa-dev] [Bug 52512] New: Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 Bug #: 52512 Summary: Build failures: glsl_lexer.cc & glsl_parser.cc don't exist Classification: Unclassified Product: Mesa Version: git Platform: All OS/Versi

[Mesa-dev] [Bug 52513] New: Building static libs doesn't work

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52513 Bug #: 52513 Summary: Building static libs doesn't work Classification: Unclassified Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Sev

[Mesa-dev] [Bug 52512] Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 --- Comment #1 from Kenneth Graunke 2012-07-25 23:06:30 UTC --- Presumably this is with the latest git master? Have you done make clean/git clean? Also, what version of automake do you have? -- Configure bugmail: https://bugs.freedesktop.org