Re: [Mesa-dev] Mesa (master): i965: clear global offset to zero in m0.2 for VS DP read.

2011-04-11 Thread Zou, Nanhai
In fact this is not zero at multi vs thread cases on GT1, it will trigger DP read error when multi vs thread is enabled. I can not find where in spec says this payload M0.2 is reserved as zero, Thanks Zou Nan hai >>-Original Message- >>From: mesa-dev-bounces+nanhai.zou=intel@lists.f

[Mesa-dev] [Bug 25588] Lots of ARB_vertex_program/fragment_program parser errors in ETQW (if GLSL is unavailable)

2011-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=25588 --- Comment #12 from Fabio Pedretti 2011-04-11 03:14:53 PDT --- Created an attachment (id=45469) --> (https://bugs.freedesktop.org/attachment.cgi?id=45469) game output with r300c (In reply to comment #11) > I can't reproduce this with current

[Mesa-dev] [Bug 25588] Lots of ARB_vertex_program/fragment_program parser errors in ETQW (if GLSL is unavailable)

2011-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=25588 --- Comment #13 from Benjamin Bellec 2011-04-11 03:54:32 PDT --- I saw that you use the version 1.4. You should try with the latest one (1.5). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving

Re: [Mesa-dev] How do I get start about gallium?

2011-04-11 Thread Jerome Glisse
On Fri, Apr 8, 2011 at 7:17 AM, Awin wrote: >  Hi all, >    I need to write a OpenGL driver for my company's IC, and base on gallium, > how do I get start? Is there any document or sample code to reference? > >    Awin src/gallium/docs has some doc mostly on internal, headers in src/gallium/inclu

Re: [Mesa-dev] [PATCH 0/2] Fix minor issues with GLSL extension usage

2011-04-11 Thread Brian Paul
On 04/08/2011 06:48 PM, Ian Romanick wrote: The first patch fixes a problem where a shader could enable GL_ARB_draw_instanced on a driver that does not support it. The second patch reformats the GL_ARB_shader_stencil_export enable block to look more like the other extension enable blocks. The s

Re: [Mesa-dev] How do I get start about gallium?

2011-04-11 Thread Corbin Simpson
On Fri, Apr 8, 2011 at 4:17 AM, Awin wrote: >  Hi all, >    I need to write a OpenGL driver for my company's IC, and base on gallium, > how do I get start? Is there any document or sample code to reference? This is a remarkably candid question. In the Mesa tree, the Gallium headers (src/gallium/

Re: [Mesa-dev] Mesa (master): i965: clear global offset to zero in m0.2 for VS DP read.

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 17:16:34 +0800, "Zou, Nanhai" wrote: > In fact this is not zero at multi vs thread cases on GT1, it will trigger DP > read error when multi vs thread is enabled. > > I can not find where in spec says this payload M0.2 is reserved as zero, g0.2 is delivered as 0. See vol2a.0

[Mesa-dev] gdb doesnt step into GL API calls of gears.

2011-04-11 Thread kumar vemuri
Hi All, A very basic question. I built the gallium softpipe driver setup. The gears demo is working on it. When i try to use gdb on gears, gdb "steps" into the glu* calls but not into the gl* (GL API) calls. Why is that? Am i missing something? thx K __

Re: [Mesa-dev] gdb doesnt step into GL API calls of gears.

2011-04-11 Thread Brian Paul
On 04/11/2011 09:56 AM, kumar vemuri wrote: Hi All, A very basic question. I built the gallium softpipe driver setup. The gears demo is working on it. When i try to use gdb on gears, gdb "steps" into the glu* calls but not into the gl* (GL API) calls. Why is that? Am i missing something?

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Constant-fold immediates in src0 of CMP instructions.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:08 PM, Eric Anholt wrote: > This is like what we do with add/mul, but we also have to flip the > conditional test. I assume this passes full piglit runs? If so, Reviewed-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_eu.c

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Constant-fold immediates in src0 of SEL instructions.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:08 PM, Eric Anholt wrote: > This is like what we do for add/mul, but we have to invert the > predicate to choose the other source instead. > > This removes 5 extra moves of constants in nexuiz shaders. > --- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] Mesa (master): i965: clear global offset to zero in m0.2 for VS DP read.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/2011 08:31 AM, Eric Anholt wrote: > On Mon, 11 Apr 2011 17:16:34 +0800, "Zou, Nanhai" > wrote: >> In fact this is not zero at multi vs thread cases on GT1, it will trigger DP >> read error when multi vs thread is enabled. >> >> I can not fi

[Mesa-dev] [Bug 35425] Instanced drawing: not implemented

2011-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35425 --- Comment #8 from s3734...@mail.zih.tu-dresden.de 2011-04-11 10:11:33 PDT --- You could apply the patch with the commit text "started implementing EXT_gpu_shader4 in GLSL: gl_InstanceID" (with some compatibility checks of course) -- Configure

[Mesa-dev] [PATCH 0/2] Misc i965 fixes / clean-ups

2011-04-11 Thread Ian Romanick
The first patch "fixes" an issue that Ken and I discovered last week with the ROUND_DOWN_TO macro in the i965 driver. The best fix is probably to pull this macro up into higher-level Mesa code. I'd like some review that changing this macro won't break existing code. The second patch follows from

[Mesa-dev] [PATCH 2/2] i965: Remove hint_gs_always and resulting dead code

2011-04-11 Thread Ian Romanick
From: Ian Romanick --- src/mesa/drivers/dri/i965/brw_gs.c | 52 +++--- src/mesa/drivers/dri/i965/brw_gs.h |5 +-- src/mesa/drivers/dri/i965/brw_gs_emit.c | 32 --- 3 files changed, 13 insertions(+), 76 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 1/2] intel: Fix ROUND_DOWN_TO macro

2011-04-11 Thread Ian Romanick
From: Ian Romanick Previously the macro would (ALIGN(value - alignment - 1, alignment)). At the very least, this was missing parenthesis around "alignment - 1". As a result, if value was already aligned, it would be reduced by alignment. Condisder: x = ROUND_DOWN_TO(256, 128); This becom

Re: [Mesa-dev] [PATCH 0/2] Misc i965 fixes / clean-ups

2011-04-11 Thread Keith Whitwell
On Mon, 2011-04-11 at 10:30 -0700, Ian Romanick wrote: > The first patch "fixes" an issue that Ken and I discovered last week > with the ROUND_DOWN_TO macro in the i965 driver. The best fix is > probably to pull this macro up into higher-level Mesa code. I'd like > some review that changing this

[Mesa-dev] [Bug 25588] Lots of ARB_vertex_program/fragment_program parser errors in ETQW (if GLSL is unavailable)

2011-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=25588 --- Comment #14 from almos 2011-04-11 10:37:29 PDT --- (In reply to comment #13) > I saw that you use the version 1.4. > You should try with the latest one (1.5). The attached log says Running in restricted mode. which means it's the demo, for w

Re: [Mesa-dev] [PATCH 1/2] intel: Fix ROUND_DOWN_TO macro

2011-04-11 Thread Kenneth Graunke
Acked-by: Kenneth Graunke I don't really care whether it's called ALIGN_FLOOR or ROUND_DOWN_TO; either is fine by me. I might add a comment saying that these only work if the second parameter is a power of two. ___ mesa-dev mailing list mesa-dev@li

Re: [Mesa-dev] [PATCH 1/2] intel: Fix ROUND_DOWN_TO macro

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/2011 11:06 AM, Kenneth Graunke wrote: > Acked-by: Kenneth Graunke > > I don't really care whether it's called ALIGN_FLOOR or ROUND_DOWN_TO; > either is fine by me. I might add a comment saying that these only work > if the second parameter

Re: [Mesa-dev] [PATCH 1/6] glsl: Avoid cascading errors when looking for a scalar boolean and failing.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: By always using a boolean, we should generally avoid further complaints. The failure case I see is logic_not, where the user might understandably make the mistake of using `!' on a boolean vector (like a piglit case did recently!), and then get a furthe

Re: [Mesa-dev] [PATCH 2/6] glsl: Semantically check the RHS of `&&' even when short-circuiting.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: We just do the AST-to-HIR processing, and only push the instructions if needed in the constant true case. Fixes glslparsertest/glsl2/logic-01.frag --- src/glsl/ast_to_hir.cpp | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) Sol

Re: [Mesa-dev] [PATCH 3/6] glsl: Semantically check the RHS of `||' even when short-circuiting.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: We just do the AST-to-HIR processing, and only push the instructions if needed in the constant false case. Fixes glslparsertest/glsl2/logic-02.frag --- src/glsl/ast_to_hir.cpp | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) Rev

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: This prevents later errors (including an assertion failure) from cascading the failure. Fixes invalid-equality-04.vert. --- src/glsl/ast_to_hir.cpp | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Kenneth Graunke __

Re: [Mesa-dev] [PATCH 5/6] glsl: Perform type checking on "^^" operands.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: We were letting any old operand through, which generally resulted in assertion failures later. Fixes array-logical-xor.vert. --- src/glsl/ast_to_hir.cpp | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) Good catch. Reviewed-b

[Mesa-dev] [PATCH] i965: Never enable the GS on Gen6.

2011-04-11 Thread Kenneth Graunke
Prior to Gen6, we use the GS for breaking down quads, quad-strips, and line loops. On Gen6, earlier stages already take care of this, so we never need the GS. Since this code is likely completely untested, remove it for now. We can write new code when enabling real geometry shaders. --- src/mesa

Re: [Mesa-dev] GL_ARB_sampler_objects branch

2011-04-11 Thread Gustaw Smolarczyk
Some of the changes in commit ecfaab88b2577bd0395bc05d75a036126806a9c4 of this branch are wrong (found by inspection), likely due to find-replace typo. As an example in r600c: > -static void evergreenSetTexBorderColor(radeonTexObjPtr t, const GLfloat > color[4]) > +static void evergreenSetTexSampl

Re: [Mesa-dev] GL_ARB_sampler_objects branch

2011-04-11 Thread Brian Paul
On 04/11/2011 01:08 PM, Gustaw Smolarczyk wrote: Some of the changes in commit ecfaab88b2577bd0395bc05d75a036126806a9c4 of this branch are wrong (found by inspection), likely due to find-replace typo. As an example in r600c: -static void evergreenSetTexBorderColor(radeonTexObjPtr t, const GLfloa

Re: [Mesa-dev] [PATCH 6/6] glsl: Allow instructions to be generated for array size declarations.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: The specs only say that they have to be a constant expression, which would allow things like builtin function calls that generate instructions as a side effect of their parsing. Fixes the fixed array-size-constant-relational.vert. --- src/glsl/ast.h

Re: [Mesa-dev] [PATCH 1/2] glsl: Only let a shader enable GL_ARB_draw_instanced if the driver supports it

2011-04-11 Thread Kenneth Graunke
On 04/08/2011 05:48 PM, Ian Romanick wrote: From: Ian Romanick The rest of the change it to make the GL_ARB_draw_instanced block follow the same pattern as the other blocks. --- src/glsl/glsl_parser_extras.cpp | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) "The rest of

Re: [Mesa-dev] [PATCH 2/2] glsl: Make GL_ARB_shader_stencil_export enable block be similar to other blocks

2011-04-11 Thread Kenneth Graunke
On 04/08/2011 05:48 PM, Ian Romanick wrote: From: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Kenneth Graunke ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: This prevents later errors (including an assertion failure) from cascading the failure. Fixes invalid-equality-04.vert. Also, this likely fixes bug #33303. ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH 1/6] glsl: Avoid cascading errors when looking for a scalar boolean and failing.

2011-04-11 Thread Kenneth Graunke
On 04/09/2011 10:17 PM, Eric Anholt wrote: By always using a boolean, we should generally avoid further complaints. The failure case I see is logic_not, where the user might understandably make the mistake of using `!' on a boolean vector (like a piglit case did recently!), and then get a furthe

Re: [Mesa-dev] [PATCH 6/6] glsl: Allow instructions to be generated for array size declarations.

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 12:59:12 -0700, Kenneth Graunke wrote: > On 04/09/2011 10:17 PM, Eric Anholt wrote: > > The specs only say that they have to be a constant expression, which > > would allow things like builtin function calls that generate > > instructions as a side effect of their parsing. > >

[Mesa-dev] [Bug 36139] New: static build with -fPIC misses some symbols

2011-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 Summary: static build with -fPIC misses some symbols Product: Mesa Version: 7.10 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Prior

Re: [Mesa-dev] [PATCH 1/2] intel: Fix ROUND_DOWN_TO macro

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 10:30:42 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > Previously the macro would (ALIGN(value - alignment - 1, alignment)). > At the very least, this was missing parenthesis around "alignment - > 1". As a result, if value was already aligned, it would be reduced by

Re: [Mesa-dev] [PATCH 2/2] i965: Remove hint_gs_always and resulting dead code

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 10:30:43 -0700, "Ian Romanick" wrote: > From: Ian Romanick Love this (and the following patch). They are: Reviewed-by: Eric Anholt pgpxMX3txzHX8.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH 2/6] glsl: Semantically check the RHS of `&&' even when short-circuiting.

2011-04-11 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:17 PM, Eric Anholt wrote: > Fixes glslparsertest/glsl2/logic-01.frag Incredible that we didn't verify the RHS... Reviewed-by: Chad Versace - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11

Re: [Mesa-dev] [PATCH 3/6] glsl: Semantically check the RHS of `||' even when short-circuiting.

2011-04-11 Thread Chad Versace
Reviewed-by: Chad Versace -- Chad Versace c...@chad-versace.us ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] glsl: Perform type checking on "^^" operands.

2011-04-11 Thread Eric Anholt
On Sun, 10 Apr 2011 13:07:29 +0200, Gustaw Smolarczyk wrote: > 2011/4/10 Eric Anholt : > > +      op[0] = get_scalar_boolean_operand(instructions, state, this, 0, > > "LHS", > > +                                        &error_emitted); > > +      op[1] = get_scalar_boolean_operand(instructions,

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-11 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:17 PM, Eric Anholt wrote: > This prevents later errors (including an assertion failure) from > cascading the failure. > > Fixes invalid-equality-04.vert. > --- > src/glsl/ast_to_hir.cpp | 10 +++--- > 1 files changed, 7 inserti

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Constant-fold immediates in src0 of SEL instructions.

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 09:16:32 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/09/2011 10:08 PM, Eric Anholt wrote: > > This is like what we do for add/mul, but we have to invert the > > predicate to choose the other source instead. > > > > This removes 5 ext

Re: [Mesa-dev] [PATCH 5/6] glsl: Perform type checking on "^^" operands.

2011-04-11 Thread Chad Versace
On 04/09/2011 10:17 PM, Eric Anholt wrote: > We were letting any old operand through, which generally resulted in > assertion failures later. > > Fixes array-logical-xor.vert. > --- > src/glsl/ast_to_hir.cpp | 13 ++--- > 1 files changed, 10 insertions(+), 3 deletions(-) get_scalar_boo

Re: [Mesa-dev] [PATCH 6/6] glsl: Allow instructions to be generated for array size declarations.

2011-04-11 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:17 PM, Eric Anholt wrote: > The specs only say that they have to be a constant expression, which > would allow things like builtin function calls that generate > instructions as a side effect of their parsing. > > Fixes the fixed arra

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:17 PM, Eric Anholt wrote: > This prevents later errors (including an assertion failure) from > cascading the failure. > > Fixes invalid-equality-04.vert. > --- > src/glsl/ast_to_hir.cpp | 10 +++--- > 1 files changed, 7 inserti

Re: [Mesa-dev] stuck-on-an-airplane GLSL fixes.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 10:17 PM, Eric Anholt wrote: > Here are fixes for a bunch of GLSL (mostly assertion) failures, which > were highlighted thanks to the lovely new piglit reports. For all of them except 4 and 6: Reviewed-by: Ian Romanick I replied direc

[Mesa-dev] [PATCH] glsl: Emit a warning when the left-hand operand of a comma has no effect

2011-04-11 Thread Ian Romanick
From: Ian Romanick The expression x = y, 5, 3; will generate 0:7(9): warning: left-hand operand of comma expression has no effect The warning is only emitted for the left-hand operands, becuase the right-most operand is the result of the expression. This could be used in an assignmen

Re: [Mesa-dev] [PATCH 1/2] i965: Add comments about URB size units and limits.

2011-04-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/09/2011 01:03 AM, Eric Anholt wrote: > On Fri, 8 Apr 2011 13:16:28 -0700, Kenneth Graunke > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_context.h |8 >> src/mesa/drivers/dri/i965/brw_vs_emit.c |6 ++ >> src/mesa/driver

Re: [Mesa-dev] Mesa (master): i965: clear global offset to zero in m0.2 for VS DP read.

2011-04-11 Thread Zou, Nanhai
>>-Original Message- >>From: Eric Anholt [mailto:e...@anholt.net] >>Sent: 2011年4月11日 23:32 >>To: Zou, Nanhai; mesa-dev@lists.freedesktop.org; >>mesa-com...@lists.freedesktop.org >>Subject: RE: [Mesa-dev] Mesa (master): i965: clear global offset to zero in >>m0.2 for VS DP read. >> >>On Mo

Re: [Mesa-dev] Mesa (master): i965: clear global offset to zero in m0.2 for VS DP read.

2011-04-11 Thread Zou, Nanhai
That is a duplicated fix as commit 9d60a7ce08a67eb8b79c60f829d090ba4a37ed7e. I have reverted the patch. Please pick 9d60a7ce08a67eb8b79c60f829d090ba4a37ed7e. Thanks Zou Nanhai >>-Original Message- >>From: Ian Romanick [mailto:i...@freedesktop.org] >>Sent: 2011年4月12日 0:20 >>To: Eric Anholt >

Re: [Mesa-dev] gdb doesnt step into GL API calls of gears.

2011-04-11 Thread kumar vemuri
Hi Brian, I did use --enable-debug with configure. But still i dont see gdb stepping into gl calls... it does step into the glu calls though. This is my configure command: ./configure --enable-debug --enable-gallium-i915 --enable-gallium-swrast --with-dri-drivers=swrast By the way, dont k