On Mon, 11 Apr 2011 10:30:42 -0700, "Ian Romanick" <i...@freedesktop.org> wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Previously the macro would (ALIGN(value - alignment - 1, alignment)). > At the very least, this was missing parenthesis around "alignment - > 1". As a result, if value was already aligned, it would be reduced by > alignment. Condisder:
Yeah, I pretty clearly meant to type "value - (alignment - 1)". > I also think that ALIGN_FLOOR would be a better name for this macro, > but ROUND_DOWN_TO matches rounddown in the Linux kernel. Wish I'd just made the macro match linux's naming, at least. Fail. Reviewed-by: Eric Anholt <e...@anholt.net>
pgp8U1leuB8Q7.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
