Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-22 Thread Dieter Nützel
Am 22.09.2014 18:54, schrieb Glenn Kennard: On Wed, 17 Sep 2014 06:10:48 +0200, Alexandre Demers wrote: Tested with v3. I get the same result as before: everything is fine except the gs-atan-vec2 test. I don't know if this is of any value, but running the command manually in a shell gives

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-22 Thread Glenn Kennard
On Wed, 17 Sep 2014 06:10:48 +0200, Alexandre Demers wrote: Tested with v3. I get the same result as before: everything is fine except the gs-atan-vec2 test. I don't know if this is of any value, but running the command manually in a shell gives the following: /home/ademers/projects/di

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-16 Thread Alexandre Demers
Tested with v3. I get the same result as before: everything is fine except the gs-atan-vec2 test. I don't know if this is of any value, but running the command manually in a shell gives the following: /home/ademers/projects/display/piglit/bin/shader_runner /home/ademers/projects/display/pigli

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-14 Thread Alexandre Demers
Sorry for the delay, I've been away for work and with not much free time lately. I'll have a look at it as soon as possible. Alexandre Demers On 10/09/14 06:16 AM, Glenn Kennard wrote: On Sat, 06 Sep 2014 04:00:01 +0200, Alexandre Demers wrote: Thanks Marek, you were right. So, on cayman,

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-10 Thread Glenn Kennard
On Sat, 06 Sep 2014 04:00:01 +0200, Alexandre Demers wrote: Thanks Marek, you were right. So, on cayman, after comparing results from both runs, it seems there is only one regression which is gs-atan-vec2 under glsl-1.50: piglit/bin/shader_runner /home/ademers/projects/display/piglit/gen

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-08 Thread Dieter Nützel
Am 05.09.2014 00:14, schrieb Glenn Kennard: Also fixes two sided lighting which was broken at least on pre-evergreen by commit b1eb00. Maybe there is a (Mesa-demos) test case around? Signed-off-by: Glenn Kennard --- Changes since patch v1: Factor out and set sample positions also for pre-eve

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-05 Thread Alexandre Demers
Thanks Marek, you were right. So, on cayman, after comparing results from both runs, it seems there is only one regression which is gs-atan-vec2 under glsl-1.50: piglit/bin/shader_runner /home/ademers/projects/display/piglit/generated_tests/spec/glsl-1.50/execution/built-in-functions/gs-atan-ve

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-05 Thread Marek Olšák
You can skip glx tests using these piglit-run parameters: -x glx -x makeCurrent That should prevent X from crashing. Marek On Fri, Sep 5, 2014 at 7:07 AM, Alexandre Demers wrote: > I've been testing your patch v2 on cayman. > > Here are my results. For now, my piglit runs are not conclusive bec

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-04 Thread Alexandre Demers
I've been testing your patch v2 on cayman. Here are my results. For now, my piglit runs are not conclusive because a quick run fails even without your patch: almost at the end of the run, X crashes. However, using Tesseract as you suggested gave good results. First, it fixes a visual glitch

[Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-04 Thread Glenn Kennard
Also fixes two sided lighting which was broken at least on pre-evergreen by commit b1eb00. Signed-off-by: Glenn Kennard --- Changes since patch v1: Factor out and set sample positions also for pre-evergreen Misc r600 breakage fixes Some cleanup Passes piglit without regressions on radeon 6670.