Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-15 Thread Eric Anholt
On Wed, 14 Dec 2011 14:38:52 -0700, Brian Paul wrote: > On 12/14/2011 02:13 PM, Eric Anholt wrote: > > On Tue, 13 Dec 2011 18:07:05 -0700, Brian Paul > > wrote: > >> From: Brian Paul > >> > >> This fixes two things: > >> 1. If the texture object was created with glTexStorage2D, the call > >>

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-14 Thread Brian Paul
On 12/14/2011 02:13 PM, Eric Anholt wrote: On Tue, 13 Dec 2011 18:07:05 -0700, Brian Paul wrote: From: Brian Paul This fixes two things: 1. If the texture object was created with glTexStorage2D, the call to _mesa_TexImage2D() would generate INVALID_OPERATION since the texture is marked

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-14 Thread Eric Anholt
On Tue, 13 Dec 2011 18:07:05 -0700, Brian Paul wrote: > From: Brian Paul > > This fixes two things: > 1. If the texture object was created with glTexStorage2D, the call >to _mesa_TexImage2D() would generate INVALID_OPERATION since the >texture is marked as immutable. > 2. _mesa_TexImage2

[Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-13 Thread Brian Paul
From: Brian Paul This fixes two things: 1. If the texture object was created with glTexStorage2D, the call to _mesa_TexImage2D() would generate INVALID_OPERATION since the texture is marked as immutable. 2. _mesa_TexImage2D() always frees any existing texture image memory before allocati

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:27 -0700, Brian Paul wrote: > This fixes two things: > 1. If the texture object was created with glTexStorage2D, the call >to _mesa_TexImage2D() would generate INVALID_OPERATION since the >texture is marked as immutable. > 2. _mesa_TexImage2D() always frees any ex

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:27 -0700, Brian Paul wrote: > This fixes two things: > 1. If the texture object was created with glTexStorage2D, the call >to _mesa_TexImage2D() would generate INVALID_OPERATION since the >texture is marked as immutable. > 2. _mesa_TexImage2D() always frees any ex

[Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-10 Thread Brian Paul
This fixes two things: 1. If the texture object was created with glTexStorage2D, the call to _mesa_TexImage2D() would generate INVALID_OPERATION since the texture is marked as immutable. 2. _mesa_TexImage2D() always frees any existing texture image memory before allocating new memory. Tha