On 21/12/2018 01:42, srol...@vmware.com wrote:
From: Roland Scheidegger
Whenever llvm removes an intrinsic (we're using), we're hitting segfaults
due to llvm doing calls to address 0 in the jitted code instead.
However, Jose figured out we can actually detect this with
LLVMGetIntrinsicID(), so
On 21/12/2018 00:25, srol...@vmware.com wrote:
From: Roland Scheidegger
This intrinsic disppeared with llvm 6.0, using it ends up in segfaults
(due to llvm issuing call to NULL address in the jited shaders).
Add code doing the same thing as the autoupgrade code in llvm so it
can be matched and
Hi everyone,
On Fri, Dec 14, 2018 at 5:17 PM Tomasz Figa wrote:
>
> If there is no last fence, due to no rendering happening yet, just
> create a new signaled fence and return it, to match the expectations of
> the EGL sync fence API.
>
> Fixes random "Could not create sync fence 0x3003" assertio
Sorry. Copy-paste decided to send a msg rather than paste into it.
On Fri, 21 Dec 2018 at 17:36, Stuart Young wrote:
> On Fri, 21 Dec 2018 at 04:18, Eero Tamminen
> wrote:
>
>> On 20.12.2018 4.40, Stuart Young wrote:
>> > Could this be reduced this from an error to a warning, with the
>> > comm
On Fri, 21 Dec 2018 at 04:18, Eero Tamminen
wrote:
> On 20.12.2018 4.40, Stuart Young wrote:
> > Could this be reduced this from an error to a warning, with the
> > command-line option suppressing the warning?
> >
> > Perhaps as well as producing the warning, the build could sleep for say
> > 30
From: Roland Scheidegger
Whenever llvm removes an intrinsic (we're using), we're hitting segfaults
due to llvm doing calls to address 0 in the jitted code instead.
However, Jose figured out we can actually detect this with
LLVMGetIntrinsicID(), so use this to abort, so we don't have to wonder
wha
https://bugs.freedesktop.org/show_bug.cgi?id=109107
--- Comment #1 from zhoulei ---
More details:
In function VASupportedProfiles::GetSupportedVAProfiles,
https://github.com/chromium/chromium/blob/master/media/gpu/vaapi/vaapi_wrapper.cc#L571
const int max_profiles = vaMaxNumProfiles(va_display_
Ahh great find!
I tried it out and it works, if it's not an intrinsic it will return 0,
otherwise some number (no idea how they are enumerated, but who cares).
Roland
Am 21.12.18 um 00:56 schrieb Jose Fonseca:
> There's an function -- LLVMGetIntrinsicID -- I wonder if we can use it
> to trap uns
From: Roland Scheidegger
This intrinsic disppeared with llvm 6.0, using it ends up in segfaults
(due to llvm issuing call to NULL address in the jited shaders).
Add code doing the same thing as the autoupgrade code in llvm so it
can be matched and replaced back with a pavgb.
While here, also imp
There's an function -- LLVMGetIntrinsicID -- I wonder if we can use it
to trap unsupported intrinsics?
Jose
On 20/12/2018 22:09, Roland Scheidegger wrote:
Am 20.12.18 um 16:56 schrieb Michel Dänzer:
On 2018-12-19 4:51 a.m., srol...@vmware.com wrote:
From: Roland Scheidegger
This is (much)
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/40
A couple of bugs have been reported on multisampled & multilayered
surfaces in Anv.
After having found what I thought was a workaround, it turned out to be
an actual fix.
Please visit the URL above for a full explanation.
I also wrot
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/39
Some upcoming Intel platforms do not have 64-bit type support. This
series implements support for ARB_gpu_shader_fp64 and
ARB_gpu_shader_int64 via software implementations.
To do this we add a .glsl file containing GLSL implementations of
Am 20.12.18 um 16:56 schrieb Michel Dänzer:
> On 2018-12-19 4:51 a.m., srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> This is (much) faster than using the util fallback.
>> (Note that there's two methods here, one would use a cache, similar to
>> the existing code (although the cache
We want to have debug info as well if using
meson's debugoptimized when ndebug is off.
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/basetexture9.c | 6 +++---
src/gallium/state_trackers/nine/basetexture9.h | 2 +-
src/gallium/state_trackers/nine/nine_debug.h | 10 +-
Awesome, thanks! Apologies that I was unable to get around to looking at
your feedback in the intervening period of time.
On Thu, Dec 20, 2018 at 2:34 PM Eric Anholt wrote:
> Eric Anholt writes:
>
> > [ Unknown signature status ]
> > Rhys Kidd writes:
> >
> >> Signed-off-by: Rhys Kidd
> >
> >
On Sat, Dec 15, 2018 at 12:27 PM Veluri Mithun wrote:
>
> Hi Everyone,
>
> we can obtain DRM device file from eglQueryDeviceStringEXT fun of
> EGL_EXT_device_query extension. But, how to retrieve name, configs from that?
>
> Can we get the name of the matched driver for a particular display from
Eric Anholt writes:
> [ Unknown signature status ]
> Rhys Kidd writes:
>
>> Signed-off-by: Rhys Kidd
>
> Does this actually do anything for us, though? Shouldn't we be hooking
> up our perf_debug() calls to it?
I hooked up perf_debug(), extended the commit messages, and pushed.
signature.as
Fixes: f4e499ec79 ('radv: add initial non-conformant radv vulkan driver')
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107986
Signed-off-by: Rhys Perry
---
src/amd/vulkan/radv_cmd_buffer.c | 59 ++--
src/amd/vulkan/radv_meta_clear.c | 8 +
src/amd/vulkan
https://bugs.freedesktop.org/show_bug.cgi?id=107594
Dylan Baker changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=109071
Dylan Baker changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Quoting Emil Velikov (2018-12-20 03:07:43)
> On Tue, 18 Dec 2018 at 21:53, Dylan Baker wrote:
> >
> > Quoting Emil Velikov (2018-12-18 03:09:55)
> > > On Mon, 17 Dec 2018 at 22:27, Matt Turner wrote:
> > > >
> > > > On Mon, Dec 17, 2018 at 2:12 PM Emil Velikov
> > > > wrote:
> > > > > Additiona
Hi,
On 20.12.2018 4.40, Stuart Young wrote:
Could this be reduced this from an error to a warning, with the
command-line option suppressing the warning?
Perhaps as well as producing the warning, the build could sleep for say
30 seconds after producing the warning message. This would be notice
On 12/20/18 3:30 PM, Bas Nieuwenhuizen wrote:
Happy to have this patch, but all descriptions and comments say this
is an optimization
Can we get some comment that this avoids hangs?
Pushed with a comment.
Thanks!
Otherwise
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 20, 2018 at 3:2
https://bugs.freedesktop.org/show_bug.cgi?id=35268
--- Comment #30 from Rich Felker ---
Given the lack of response on this issue, I think when I get some time to focus
on it again I'll just prepare a patch removing all of the asm dispatch stubs.
As noted before, they have no benefits at all on x
On 2018-12-19 4:51 a.m., srol...@vmware.com wrote:
> From: Roland Scheidegger
>
> This is (much) faster than using the util fallback.
> (Note that there's two methods here, one would use a cache, similar to
> the existing code (although the cache was disabled), except the block
> decode is done w
On Wed, 2018-12-19 at 09:15 +0100, Iago Toral Quiroga wrote:
> The former expects to see SSA-only things, but the latter injects registers.
>
> The assertions in the lowering where not seeing this because they asserted
> on the bit_size values only, not on the is_ssa field, so add that assertion
>
Signed-off-by: Alex Deucher
Cc: mesa-sta...@lists.freedesktop.org
---
include/pci_ids/radeonsi_pci_ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/pci_ids/radeonsi_pci_ids.h
b/include/pci_ids/radeonsi_pci_ids.h
index a2bc9213207..75ac7761bb4 100644
--- a/include/pci_ids/radeons
Happy to have this patch, but all descriptions and comments say this
is an optimization
Can we get some comment that this avoids hangs?
Otherwise
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 20, 2018 at 3:23 PM Samuel Pitoiset
wrote:
>
> This fixes GPU hangs on GFX9 with
> dEQP-VK.memory.e
This fixes GPU hangs on GFX9 with
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.with_zero_offset.*
Copied from RadeonSI.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 28 ++-
1 file changed, 27 insertions(+), 1 deletion(-)
On 12/20/18 10:13 AM, Bas Nieuwenhuizen wrote:
Exactly what title says, the new addrlib does not allow the above with
certain dimensions that the CTS seems to hit. Work around it by not
allowing the app to render to it via compat with other 128bpp formats
and do not render to it ourselves duri
On 12/20/2018 01:28 AM, Nils Wallménius wrote:
Den ons 19 dec. 2018 17:44 skrev Jonathan Marek :
When ffma is available, we can use a different arrangement of constants to
get a better result. On freedreno/ir3, this reduces the YUV->RGB to 7
scalar ffma. On freedreno/a2xx, it will allow YUV->R
https://bugs.freedesktop.org/show_bug.cgi?id=108967
--- Comment #7 from Vishwanath Chandapur ---
Hi,
Qtwebegine has already has support of EGL_KHR_surfaceless_context.
And also when we enabled more debug logs we found mesa driver is failing with
below error.when this error occurs we see black s
On Tue, 18 Dec 2018 at 21:52, Dylan Baker wrote:
>
> Quoting Emil Velikov (2018-12-18 02:33:56)
> > On Mon, 17 Dec 2018 at 19:44, Dylan Baker wrote:
> > >
> > > Quoting Emil Velikov (2018-12-17 10:58:11)
> > > > On Fri, 14 Dec 2018 at 17:13, Dylan Baker wrote:
> > > > >
> > > > > Quoting Emil Ve
On 12/20/18 12:18 PM, Bas Nieuwenhuizen wrote:
Is not ideal but will have to do for now
Yes, this can be improved.
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 20, 2018 at 12:01 PM Samuel Pitoiset
wrote:
The driver needs to decompress all image layers if a fast
depth/color clear has bee
Is not ideal but will have to do for now
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 20, 2018 at 12:01 PM Samuel Pitoiset
wrote:
>
> The driver needs to decompress all image layers if a fast
> depth/color clear has been performed.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_
On Tue, 18 Dec 2018 at 21:53, Dylan Baker wrote:
>
> Quoting Emil Velikov (2018-12-18 03:09:55)
> > On Mon, 17 Dec 2018 at 22:27, Matt Turner wrote:
> > >
> > > On Mon, Dec 17, 2018 at 2:12 PM Emil Velikov
> > > wrote:
> > > > Additionally, distributions build latest loader and use it with DRI1
On Tue, 18 Dec 2018 at 14:23, Kyle Brenneman wrote:
> On 12/14/2018 07:04 AM, Emil Velikov wrote:
> > -print(generate_public_stubs(functions))
> > +if target in "gldispatch":
> This should be an "==", not "in". The in operator would do a substring
> search.
Thanks Kyle, fixed locally. If
The driver needs to decompress all image layers if a fast
depth/color clear has been performed.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
On Thu, Dec 20, 2018, 4:05 AM Bas Nieuwenhuizen On Thu, Dec 20, 2018 at 9:00 AM Marek Olšák wrote:
> >
> > I prefer Nicolai's patch because it's shorter and doesn't need driver
> changes.
> >
> > Reviewed-by: Marek Olšák
>
> This patch still needs driver changes because radv will render to a
> c
Being able to retrieve the log level can be useful to enable/disable
debug code. The alternative, which is calling 'getenv' function every
time to retrieve the log level, is more "expensive".
Signed-off-by: Silvestrs Timofejevs
---
src/egl/main/egllog.c | 9 +
src/egl/main/egllog.h | 4 +
Feature to print out EGL returned configs for debug purposes.
'eglChooseConfig' and 'eglGetConfigs' debug information printout is
enabled when the log level equals '_EGL_DEBUG'. The configs are
printed, and if any of them are "chosen" they are marked with their
index in the chosen configs array.
This patch series provides an easy way to see what configs
have been returned by the 'eglGetConfigs' and 'eglChooseConfig'
functions, and give an overview of config attributes.
v2:
a) refactor the code in line with Eric's comments
b) rename function _snprintfStrcat, split it out and put into
This function is similar to strncat, but unlike strncat it allows to
concatenate the buffer with a formatted string. The alternative would
be to have an intermediate string that is formated first, and then
appended via strncat.
Signed-off-by: Silvestrs Timofejevs
---
src/util/u_string.h | 16 +++
On Thursday, 2018-12-20 08:30:53 +, Silvestrs Timofejevs wrote:
> Eric, thank you for reviewing my patch. I have expanded little bit
> on some of your comments bellow. I will be sending fallow up V2 of the patch
> shortly.
> On Thu, Dec 06, 2018 at 11:00:25AM +, Eric Engestrom wrote:
[...]
On Tue, Dec 18, 2018, 9:57 PM Samuel Pitoiset We don't ever want to do the fmask lookup on a atomic or
> store, the fmask should have been decompressed if the
> surface has been moved to IMAGE_LAYOUT.
>
Clarify the description to be a *storage* image layout?
>
> Original patch by Dave Airlie.
>
Hello all,
With the last (minor) update I moved the series to an MR:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/14
There are only one minor change from the series last posted here
v7: use _mesa_has_EXT_framebuffer_sRGB instead of testing the extension
flag directly.
v6: - rename
Reviewed-by: Bas Nieuwenhuizen
On Wed, Dec 19, 2018, 6:13 PM Samuel Pitoiset This workaround has been introduced by 135e4d434f6 for fixing
> DXVK GPU hangs with many games. It is no longer needed since
> LLVM r345718.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_shader.c | 12
Exactly what title says, the new addrlib does not allow the above with
certain dimensions that the CTS seems to hit. Work around it by not
allowing the app to render to it via compat with other 128bpp formats
and do not render to it ourselves during copies.
Fixes: 776b9113656 "amd/addrlib: update
On Thu, Dec 20, 2018 at 9:00 AM Marek Olšák wrote:
>
> I prefer Nicolai's patch because it's shorter and doesn't need driver changes.
>
> Reviewed-by: Marek Olšák
This patch still needs driver changes because radv will render to a
compressed surface as r32g32b32a32, so allocating a non-renderabl
Eric, thank you for reviewing my patch. I have expanded little bit
on some of your comments bellow. I will be sending fallow up V2 of the patch
shortly.
On Thu, Dec 06, 2018 at 11:00:25AM +, Eric Engestrom wrote:
> On Friday, 2018-11-09 18:04:12 +, Silvestrs Timofejevs wrote:
> > Feature to
Reviewed-by: Marek Olšák
Marek
On Wed, Dec 19, 2018 at 11:50 AM Samuel Pitoiset
wrote:
> This workaround has been introduced by 3d41757788a and it
> is no longer needed since LLVM r346422.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 24 +++
I prefer Nicolai's patch because it's shorter and doesn't need driver
changes.
Reviewed-by: Marek Olšák
Marek
On Tue, Dec 18, 2018 at 12:50 PM Haehnle, Nicolai
wrote:
> On 18.12.18 18:36, Bas Nieuwenhuizen wrote:
> > Hi Nicolai,
> >
> > I happened to be writing something similar which also fi
52 matches
Mail list logo
