[Mesa-dev] [Bug 106972] vulkan.h:75:35: fatal error: X11/extensions/Xrandr.h: No such file or directory

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106972 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 08/13] mesa: add support for glNamedBufferStorageEXT

2018-09-07 Thread Timothy Arceri
This is available in ARB_buffer_storage when EXT_direct_state_access is present. --- src/mapi/glapi/gen/gl_API.xml | 7 +++ src/mesa/main/bufferobj.c | 15 +++ src/mesa/main/bufferobj.h | 3 +++ src/mesa/main/tests/dispatch_sanity.cpp | 1 +

[Mesa-dev] [PATCH 11/13] mesa: add support for glCompressedTextureSubImage2DEXT()

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 15 src/mesa/main/tests/dispatch_sanity.cpp | 2 +- src/mesa/main/teximage.c | 75 +-- src/mesa/main/teximage.h | 7 ++ 4 files changed, 74 insertions(+), 25 deletions(-) dif

[Mesa-dev] [PATCH 09/13] mesa: add support for glMapNamedBufferRangeEXT()

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 10 + src/mesa/main/bufferobj.c | 45 +-- src/mesa/main/bufferobj.h | 3 ++ src/mesa/main/tests/dispatch_sanity.cpp | 2 +- 4 files changed, 46 insertions(+), 14 deletions(-) di

[Mesa-dev] [PATCH 13/13] mesa: add support for glMapNamedBufferEXT()

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 6 + src/mesa/main/bufferobj.c | 23 +++ src/mesa/main/bufferobj.h | 2 ++ src/mesa/main/tests/dispatch_sanity.cpp | 2 +- 4 files changed, 32 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 12/13] mesa: add support for glUnmapNamedBufferEXT()

2018-09-07 Thread Timothy Arceri
Since the ARB DSA function glUnmapNamedBuffer() is only exposed for 3.1 or above we make glUnmapNamedBuffer() an alias of glUnmapNamedBufferEXT() rather than the other way around. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/EXT_direct_state_access.xml | 5 + s

[Mesa-dev] [PATCH 10/13] mesa: add support for glTextureSubImage2DEXT()

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 15 ++ src/mesa/main/tests/dispatch_sanity.cpp | 2 +- src/mesa/main/teximage.c | 137 ++ src/mesa/main/teximage.h | 6 + 4 files changed, 131 insertions(+), 29 deletions(-) di

[Mesa-dev] [PATCH 06/13] mesa: add support for glBindMultiTextureEXT

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 9 +++- src/mesa/main/tests/dispatch_sanity.cpp | 2 +- src/mesa/main/texobj.c| 42 +++ src/mesa/main/texobj.h| 3 ++ 4 files changed, 45 insertions(+), 11 deletions(-) dif

[Mesa-dev] [PATCH 01/13] mesa: add a list of EXT_direct_state_access to dispatch sanity

2018-09-07 Thread Timothy Arceri
This extension is huge and this gives us a TODO list of functions to implement. --- src/mesa/main/tests/dispatch_sanity.cpp | 219 1 file changed, 219 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index fb2ac

[Mesa-dev] [PATCH 03/13] mesa: EXT_dsa add selectorless matrix stack functions

2018-09-07 Thread Timothy Arceri
From: Chris Forbes Allows the legacy matrix stacks to be manipulated without disturbing the matrix mode selector. Signed-off-by: Chris Forbes --- src/mesa/main/matrix.c | 370 +++-- src/mesa/main/matrix.h | 46 + 2 files changed, 363 insertions(+), 53 d

[Mesa-dev] Get Wolfenstein: The Old Blood running (Part 2)

2018-09-07 Thread Timothy Arceri
EXT_direct_state_access is a huge extension so patch 1 adds a list of the functions to displatch sanity that can be used as a TODO list. Wolfenstein doesn't use the matrix stuff but since Chris implemented it and we are eventually going to add this extension it seemed worth sending out with this s

[Mesa-dev] [PATCH 07/13] mesa: add support for glNamedBuffer*DataEXT()

2018-09-07 Thread Timothy Arceri
--- .../glapi/gen/EXT_direct_state_access.xml | 16 ++ src/mesa/main/bufferobj.c | 31 +++ src/mesa/main/bufferobj.h | 6 src/mesa/main/tests/dispatch_sanity.cpp | 4 +-- 4 files changed, 55 insertions(+), 2 deletions

[Mesa-dev] [PATCH 04/13] glapi: add EXT_direct_state_access

2018-09-07 Thread Timothy Arceri
From: Chris Forbes Signed-off-by: Chris Forbes --- .../glapi/gen/EXT_direct_state_access.xml | 101 ++ src/mapi/glapi/gen/gl_API.xml | 3 + src/mesa/main/tests/dispatch_sanity.cpp | 30 +++--- 3 files changed, 119 insertions(+), 15 deletions(-) crea

[Mesa-dev] [PATCH 05/13] mesa: add new EXT_direct_state_access tokens

2018-09-07 Thread Timothy Arceri
--- src/mapi/glapi/gen/EXT_direct_state_access.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/EXT_direct_state_access.xml b/src/mapi/glapi/gen/EXT_direct_state_access.xml index c19afe80a22..58adc9da29d 100644 --- a/src/mapi/glapi/gen/EXT_direct_state_access.xml +++

[Mesa-dev] [PATCH 02/13] mesa: factor out enum -> matrix stack lookup

2018-09-07 Thread Timothy Arceri
From: Chris Forbes Split this out from glMatrixMode since we're about to need it independently for EXT_DSA. Signed-off-by: Chris Forbes --- src/mesa/main/matrix.c | 110 - 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/src/mesa/main/matr

[Mesa-dev] Get Wolfenstein: The Old Blood running (Part 1)

2018-09-07 Thread Timothy Arceri
This enables a couple more extension that the game expects in the core profile (and yes Nvidia exposes them in core). These changes allow the game to start without crashing. The second part adds some EXT_direct_state_access support so I'm sending it separately. _

[Mesa-dev] [PATCH 1/2] mesa: enable EXT_framebuffer_object in core profile

2018-09-07 Thread Timothy Arceri
Since user defined names are not allowed in core profile we remove the allow_user_names bool and just check if we have a core profile like all other buffer/texture object handling code does. This extension is required by "Wolfenstein: The Old Blood" and is exposed in core in the Nvidia binary driv

[Mesa-dev] [PATCH 2/2] mesa: enable ARB_vertex_program in core profile

2018-09-07 Thread Timothy Arceri
This extension is required by "Wolfenstein: The Old Blood". Without it the app causes wine to crash on startup. --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 09bf923

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

2018-09-07 Thread Timothy Arceri
On 07/09/18 13:36, Timothy Arceri wrote: On 07/09/18 11:49, Ian Romanick wrote: On 09/06/2018 06:08 PM, Timothy Arceri wrote: On 07/09/18 11:00, Ian Romanick wrote: On 09/06/2018 03:24 PM, Timothy Arceri wrote: On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least Ope

Re: [Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-09-07 Thread Timothy Arceri
On 08/09/18 07:37, Marek Olšák wrote: Ping I had additional patches for bindless somewhere, tbh it's hard to know if this is all thats needed since we can't test but if you think this is correct feel free to push. It's not like it's going to break anything and we can always fix it later when

[Mesa-dev] [PATCH] mesa: remove duplicate dispatch sanity tests

2018-09-07 Thread Timothy Arceri
This removes duplicate tests from gl_core_functions_possible that are already covered by common_desktop_functions_possible. --- src/mesa/main/tests/dispatch_sanity.cpp | 265 1 file changed, 265 deletions(-) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa

Re: [Mesa-dev] [PATCH] mesa/st: Prefer RG_float when emulating INTENSITY Float over LA float

2018-09-07 Thread Marek Olšák
RG can't be used to represent intensity, because RG uses swizzle RG01, while intensity uses . Marek On Wed, Sep 5, 2018 at 4:36 AM, Gert Wollny wrote: > From: Gert Wollny > > Gallium picked R16G16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver. However

[Mesa-dev] [AppVeyor] mesa master #8837 failed

2018-09-07 Thread AppVeyor
Build mesa 8837 failed Commit ecfe41e690 by Andres Gomez on 9/7/2018 9:40 PM: docs: update calendar, add news item and link release notes for 18.2.0\n\nSigned-off-by: Andres Gomez Configure your notification preferences _

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 6, 2018 at 5:46 AM, Elie Tournier wrote: > This patch fixes the following Piglit test: > spec@egl_mesa_configless_context@basic > It also fixes few test in a virgl guest. > > v2: Evaluate the value of no_config (Ilia) > > Suggested-by: Emil Velikov >

[Mesa-dev] [ANNOUNCE] mesa 18.2.0

2018-09-07 Thread Andres Gomez
Mesa 18.2.0 is now available. This release consists of nearly 2200 commits from approximately 130 developers. The top highlights include: - OpenGL 4.3 on virgl. - OpenGL 4.4 Compatibility profile on radeonsi. - OpenGL ES 3.2 on radeonsi and virgl. - GL_ARB_ES3_2_compatibility on radeonsi. -

Re: [Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-09-07 Thread Marek Olšák
Ping On Wed, Aug 29, 2018 at 4:13 PM, Marek Olšák wrote: > From: Marek Olšák > > These might be all missing changes for bindless textures. > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 80 > 1 file changed, 50 insertions(+), 30 deletions(-) > > diff --git a/src/gal

[Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-07 Thread Marek Olšák
From: Marek Olšák Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 83013df53f1..820d3080a5c 100644 --- a/src/gal

[Mesa-dev] [PATCH 4/4] gallium/u_inlines: remove the destroy variable in pipe_reference_described

2018-09-07 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 820d3080a5c..b06f

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-07 Thread Marek Olšák
From: Marek Olšák +1.2% performance with: piglit/drawoverhead - DrawElements (no state changes) on radeonsi Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/

[Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes (v2)

2018-09-07 Thread Marek Olšák
From: Marek Olšák v2: update comments Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 94 +- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary

[Mesa-dev] [AppVeyor] mesa 18.2 #8834 completed

2018-09-07 Thread AppVeyor
Build mesa 8834 completed Commit 7378180e7a by Andres Gomez on 9/7/2018 9:10 PM: docs: update 18.2.0 release notes\n\nSigned-off-by: Andres Gomez Configure your notification preferences ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 3:34 PM, Alan Swanson wrote: > On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer >> wrote: >> > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> > > >> > > I don't think the performance can be worse than it is right now. >

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Alan Swanson
On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: > On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer > wrote: > > On 2018-09-07 4:31 p.m., Marek Olšák wrote: > > > > > > I don't think the performance can be worse than it is right now. > > > > In the worst case, all processes using OpenGL (or a

Re: [Mesa-dev] [PATCH 2/4] anv: Implement a VF cache invalidate workaround

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:49 PM PDT Jason Ekstrand wrote: > Known to fix nothing whatsoever but it's in the docs. > --- > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_b

[Mesa-dev] [PATCH] gallium/util: start with a random L3 cache index for AMD Zen

2018-09-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_helpers.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index f773360adde..466add53fc9 100644 --- a/src/gallium/auxiliar

Re: [Mesa-dev] [PATCH 3/4] anv: Disable the vertex cache when tessellating on SKL GT4

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:50 PM PDT Jason Ekstrand wrote: > I have no idea if I'm correct about what's going wrong or if this is the > correct fix. However, in my multiple weeks of banging my head on this > hang, a VUE reference counting bug seems to match all the symptoms and > it definite

Re: [Mesa-dev] [PATCH 1/4] anv: Re-emit vertex buffers when the pipeline changes

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:48 PM PDT Jason Ekstrand wrote: > Some of the bits of VERTEX_BUFFER_STATE such as access type, instance > data step rate, and pitch come from the pipeline. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/genX_cmd_buffer.c | 2 ++ > 1 file change

[Mesa-dev] [AppVeyor] mesa master #8831 failed

2018-09-07 Thread AppVeyor
Build mesa 8831 failed Commit 25ffb84016 by Marek Olšák on 9/6/2018 3:13 AM: radeonsi: pin the winsys thread to the requested L3 cache (v2)\n\nv2: rebase\n\nReviewed-by: Brian Paul Configure your notification preferences

Re: [Mesa-dev] [PATCH 4/4] anv: Clamp scissors to the framebuffer boundary

2018-09-07 Thread Kenneth Graunke
On Tuesday, August 21, 2018 6:57:51 PM PDT Jason Ekstrand wrote: > The Vulkan 1.1.81 spec says: > > "It is legal for offset.x + extent.width or offset.y + extent.height > to exceed the dimensions of the framebuffer - the scissor test still > applies as defined above. Rasterization does

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
I'm changing the initial L3 cache number to this: +static unsigned L3_cache_number; +static once_flag init_cache_number_flag = ONCE_FLAG_INIT; + +static void +util_init_cache_number(void) +{ + /* Get a semi-random number. */ + int64_t t = os_time_get_nano(); + L3_cache_number = (t ^ (t >> 8)

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >>> On 2018-09-06 10:56 p.m., Axel Davy wrote: >>> I fear if we begin to do the work manually, there won't be interest to do that in t

Re: [Mesa-dev] [PATCH] Require Visual Studio 2015.

2018-09-07 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 07.09.2018 um 17:59 schrieb Jose Fonseca: > We no longer need or use Visual Studio 2013. > > https://ci.appveyor.com/project/jrfonseca/mesa/build/52 > --- > docs/install.html | 2 +- > include/c11/threads_win32.h | 12 +---

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106465 --- Comment #4 from Andrés Gómez García --- (In reply to Andrés Gómez García from comment #3) > Curro, is this fixed by? [...] My bad, I just realized that the report is about a missing piglit test. In that case, shouldn't we move this report

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

2018-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106465 Andrés Gómez García changed: What|Removed |Added CC||ago...@igalia.com,

[Mesa-dev] [ANNOUNCE] mesa 18.1.8

2018-09-07 Thread Dylan Baker
Hi list, This mail announces the immediate availability of mesa 18.1.8. This release is a bugfix release, and thought it was previously planned to be the last 18.1 release, it is not, there will be at least 18.1.9. This has been a busier cycle than last time, apart from all of the book keeping do

Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Dylan Baker
Quoting Sergii Romantsov (2018-09-07 02:43:41) > Building of 32bit mesa with meson causes linkage issue: > "undefined reference to `util_get_process_name'" > Fixed by adding link-with mesa_util for xmlconfig primary. > > v2: Removed '[]', commit message corrected. > > v3: Reverted changes in gbm

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Józef Kucia
On Fri, Sep 7, 2018 at 6:44 PM Ilia Mirkin wrote: > > On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia wrote: > > On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev > > wrote: > > > >> @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, > >> .format = format, > >>

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia wrote: > On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev > wrote: > >> @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, >> .format = format, >> .base_level = obj->MinLevel + u->Level, >> .levels

Re: [Mesa-dev] [PATCH] meson: remove invalid "opencl" llvm component

2018-09-07 Thread Dylan Baker
Quoting Emil Velikov (2018-09-07 06:58:03) > From: Emil Velikov > > Seeming copy/paste mistake from configure.ac which uses $2 for the > component and $3 for the fancy name printing. > > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Józef Kucia
On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev wrote: > @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, > .format = format, > .base_level = obj->MinLevel + u->Level, > .levels = 1, > -.base_array_layer = obj->MinLayer + u->_La

[Mesa-dev] [PATCH] Require Visual Studio 2015.

2018-09-07 Thread Jose Fonseca
We no longer need or use Visual Studio 2013. https://ci.appveyor.com/project/jrfonseca/mesa/build/52 --- docs/install.html | 2 +- include/c11/threads_win32.h | 12 +--- include/c99_compat.h| 4 ++-- src/util/macros.h | 4 +--- 4 files changed, 5 insertions(

Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
FWIW, this looks right. Reviewed-by: Ilia Mirkin On Fri, Sep 7, 2018 at 11:39 AM, Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > to

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Lionel Landwerlin
On 07/09/2018 16:32, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 11:09 AM, Danylo Piliaiev wrote: On 9/7/18 5:48 PM, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: Comment for array_len field states: "Indicates the number of array elements starting at Base A

Re: [Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Sep 7, 2018 at 10:39 AM Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > total layers - base laye

[Mesa-dev] [PATCH v2] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base layer v2: Do not subtract base layer if image unit is not layered (Ilia Mirkin) Fixes: 5a8c8903 Bugz

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 11:09 AM, Michel Dänzer wrote: On 2018-09-07 4:13 p.m., Leo Liu wrote: On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 11:09 AM, Danylo Piliaiev wrote: > > On 9/7/18 5:48 PM, Ilia Mirkin wrote: >> >> On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev >> wrote: >>> >>> Comment for array_len field states: >>> "Indicates the number of array elements starting at >>> Base Array Layer." >>> >

Re: [Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread Kenneth Graunke
On Friday, September 7, 2018 6:34:45 AM PDT Chris Wilson wrote: > As a prelude to handling large address spaces, first allow ourselves the > luxury of handling the full 4G. > > Reported-by: Andrey Simiklit > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > src

Re: [Mesa-dev] [PATCH] intel/genxml: remove SLM Enable bit from Gen11

2018-09-07 Thread Emil Velikov
Hi Lionel, On 7 September 2018 at 14:43, Lionel Landwerlin wrote: > Documentation says this bit is gone and we've indeed set all the slm > field to 0 in common/gen_l3_config.c > > Signed-off-by: Lionel Landwerlin > --- > src/intel/genxml/gen11.xml | 1 - > src/intel/vulkan/genX_cmd_buff

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
On 9/7/18 5:48 PM, Ilia Mirkin wrote: On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Michel Dänzer
On 2018-09-07 4:13 p.m., Leo Liu wrote: > On 09/07/2018 10:07 AM, Michel Dänzer wrote: >> On 2018-09-07 3:55 p.m., Leo Liu wrote: >>> Signed-off-by: Leo Liu >>> >>> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c >>> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c >>> index 0233f58441..7ac6924c

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Michel Dänzer
On 2018-09-07 4:31 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >> On 2018-09-06 10:56 p.m., Axel Davy wrote: >> >>> I fear if we begin to do the work manually, there won't be interest to >>> do that in the kernel, >>> and thus all applications will need to include

Re: [Mesa-dev] [PATCH] i965: compute the right number of array layers use base layer

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 10:59 AM, Lionel Landwerlin wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/s

[Mesa-dev] [PATCH] i965: compute the right number of array layers use base layer

2018-09-07 Thread Lionel Landwerlin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Ilia Mirkin
On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev wrote: > Comment for array_len field states: > "Indicates the number of array elements starting at >Base Array Layer." > > And most usages of array_len expect it to be equal or less than > total layers - base layer > > Fixes: 5a8c8903 > Bugzil

[Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

2018-09-07 Thread Danylo Piliaiev
Comment for array_len field states: "Indicates the number of array elements starting at Base Array Layer." And most usages of array_len expect it to be equal or less than total layers - base layer Fixes: 5a8c8903 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856 Signed-off-by: D

Re: [Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread andrey simiklit
On Fri, Sep 7, 2018 at 4:35 PM Chris Wilson wrote: > As a prelude to handling large address spaces, first allow ourselves the > luxury of handling the full 4G. > > Reported-by: Andrey Simiklit > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > src/mesa/driver

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m., Axel Davy wrote: > > Yeah by pinning to cores, I meant to group of cores. > > > > I think a reasonable policy would be for the kernel to put all threads > > of a given process on the same L3 > > as long as the number of

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxi

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Michel Dänzer
On 2018-09-07 3:55 p.m., Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c > b/src/gallium/auxiliary/vl/vl_winsys_dri3.c > index 0233

[Mesa-dev] [PATCH 1/2] travis: pull xenial for python3.5 (and friends) on meson

2018-09-07 Thread Emil Velikov
From: Emil Velikov The meson requirement was bumped recently to 0.45, which requires python 3.5 On travis that is only available on xenial. Additionally we need to pull setuptools package otherwise pip fails to install meson. Pulling setuptools via pip, attempts to recursively attepmting to ins

[Mesa-dev] [PATCH 2/2] travis: adding missing x11-xcb for meson+vulkan

2018-09-07 Thread Emil Velikov
From: Emil Velikov Required by the x11 WSI Fixes: df82012b2cb ("travis: add meson build for vulkan drivers.") Cc: Dylan Baker Signed-off-by: Emil Velikov --- Dylan comparing the list vs the autotools build the meson one is missing x11proto-xf86vidmode-dev. Can I interest you in double-checking

[Mesa-dev] [PATCH] meson: remove invalid "opencl" llvm component

2018-09-07 Thread Emil Velikov
From: Emil Velikov Seeming copy/paste mistake from configure.ac which uses $2 for the component and $3 for the fancy name printing. Cc: Dylan Baker Signed-off-by: Emil Velikov --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0

[Mesa-dev] [PATCH 4/4] vl/dri: add 10 bits format support for DRI2

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c b/src/gallium/auxiliary/vl/vl_winsys_dri.c index bb1ff50488..f3ae788f72 100644 --- a/src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH v2] i965: Workaround the gen9 hw astc5x5 sampler bug

2018-09-07 Thread Pohjolainen, Topi
On Thu, Sep 06, 2018 at 03:50:42PM -0500, Jason Ekstrand wrote: > From: Topi Pohjolainen > > gen9 hardware has a bug in the sampler cache that can cause GPU hangs > whenever an texture with aux compression enabled is in the sampler cache > together with an ASTC5x5 texture. Because we can't contr

[Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 0233f58441..7ac6924c78 100644 --- a/src/gallium/auxiliary/vl

[Mesa-dev] [PATCH 3/4] st/vdpau: Use output buffer as DRI3 back buffer with 24 bits color only

2018-09-07 Thread Leo Liu
Using output buffer with 8 bits video RGB as back buffer certainly is not working for 30 bits color depth visual. Signed-off-by: Leo Liu --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/output.c

[Mesa-dev] [PATCH 2/4] vl/dri: add color depth to vl_winsys

2018-09-07 Thread Leo Liu
It will be used for dri2 and dri3 Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 1 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src/gallium/auxiliary/vl/vl_winsys.h index 77277ce

[Mesa-dev] [PATCH] intel/genxml: remove SLM Enable bit from Gen11

2018-09-07 Thread Lionel Landwerlin
Documentation says this bit is gone and we've indeed set all the slm field to 0 in common/gen_l3_config.c Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - src/intel/vulkan/genX_cmd_buffer.c | 6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH 1/2] intel/genxml: turn SLM Enable bit into boolean

2018-09-07 Thread Jason Ekstrand
Rb On September 7, 2018 05:55:57 Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen10.xml b/sr

[Mesa-dev] [PATCH] i965: Bump aperture tracking to u64

2018-09-07 Thread Chris Wilson
As a prelude to handling large address spaces, first allow ourselves the luxury of handling the full 4G. Reported-by: Andrey Simiklit Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 9 + src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Sergii Romantsov
Oh, thanks. So maybe that one https://patchwork.freedesktop.org/patch/247572/ one more time :)? And this https://patchwork.freedesktop.org/patch/247729/ ? On Fri, Sep 7, 2018 at 3:46 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > It's good, pushed. > > On 07/09/2018 10:57, Lionel

Re: [Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes

2018-09-07 Thread Philipp Zabel
Hi Marek, there are two comments that will be confusing if they are not updated as well: On Sat, 2018-09-01 at 02:54 -0400, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_inlines.h | 86 +- > 1 file changed, 43 insertions(+), 43 deletions(

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-07 Thread Michel Dänzer
On 2018-09-06 8:11 p.m., Marek Olšák wrote: > On Thu, Sep 6, 2018 at 6:25 AM, Michel Dänzer wrote: >> On 2018-09-05 11:49 p.m., Marek Olšák wrote: >>> On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: > On 2018-09-01 8:54 a.m., Marek

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Lionel Landwerlin
It's good, pushed. On 07/09/2018 10:57, Lionel Landwerlin wrote: There was a test that failed, but I think it might be flakyness. I'm retrying one more time. Will get back to you in ~1h. - Lionel On 07/09/2018 10:32, Sergii Romantsov wrote: Hello, Lionel. Any regression with CI? On Thu, Sep

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-07 Thread andrey simiklit
Hi all, Could somebody check it on CI to confirm that this patch do not add regressions or maybe even take a look at this patch. Regards, Andrii. On Mon, Aug 27, 2018 at 12:39 PM andrey simiklit wrote: > Hi all, > > It would be great if somebody look at this. > I guess that this issue can affe

Re: [Mesa-dev] [PATCH] i965/glsl: don't add unused aoa elements to the program resource list

2018-09-07 Thread andrey simiklit
Hi all, Could somebody run it on CI to confirm that this patch fixes one test and not add regressions or maybe even take a look at this patch) Regards, Andrii. On Fri, Aug 31, 2018 at 5:13 PM wrote: > From: Andrii Simiklit > > It fixes a bit incorrectly implemented ARB_program_interface_query

[Mesa-dev] [PATCH v5 6/8] util: use cross platform implementation 'util_vsnprintf'

2018-09-07 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

[Mesa-dev] [PATCH v5 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

2018-09-07 Thread asimiklit . work
From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. v5: remove _mesa_*snprintf functions and replace it by u

[Mesa-dev] [PATCH v2] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
From Section 4.6.4 (Invariance and Linkage) of the GLSL ES 1.0 specification "The invariance of varyings that are declared in both the vertex and fragment shaders must match. For the built-in special variables, gl_FragCoord can only be declared invariant if and only if gl_Positi

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: remove SLM Enable bit on Gen11

2018-09-07 Thread Lionel Landwerlin
Arg didn't this on anv which sets this be through genxml even though the documentation says it's reserved. Will send an update. On 07/09/2018 11:55, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/i

[Mesa-dev] [PATCH 2/2] intel/genxml: remove SLM Enable bit on Gen11

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen11.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/genxml/gen11.xml b/src/intel/genxml/gen11.xml index 1b3befbbfc9..f497c2df825 100644 --- a/src/intel/genxml/gen11.xml +++ b/src/intel/genxml/gen11.xml @@ -3544,7 +3544,6 @@

[Mesa-dev] [PATCH 1/2] intel/genxml: turn SLM Enable bit into boolean

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml index 541e4405716..abd5da297d6 10064

[Mesa-dev] [PATCH] gallium: freedreno: fix compile issue

2018-09-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Fixes: daa19363def83c ("gallium: split depth_clip into depth_clip_near & depth_clip_far") --- src/gallium/drivers/freedreno/freedreno_draw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c b/sr

Re: [Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
Hi Tapani, Thanks for the review! I'll add the needed space. On Fri, Sep 7, 2018 at 8:16 AM, Tapani Pälli wrote: > LGTM > > It would be nice to have this as part of 'cross_validate_globals' or some > other pass but considering how special/specific rules we are dealing with > here IMO it's fine

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Lucas Stach
Hi Emil, Am Freitag, den 07.09.2018, 10:52 +0100 schrieb Emil Velikov: > Hi Lukas, > > Adding the etnaviv ML - people in there may have some tips. > > > On 6 September 2018 at 15:43, Lukas F. Hartmann wrote: > > Hi, > > > > I've updated to and rebuilt the latest git versions of linux, drm, mes

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Lionel Landwerlin
There was a test that failed, but I think it might be flakyness. I'm retrying one more time. Will get back to you in ~1h. - Lionel On 07/09/2018 10:32, Sergii Romantsov wrote: Hello, Lionel. Any regression with CI? On Thu, Sep 6, 2018 at 12:33 PM, Lionel Landwerlin mailto:lionel.g.landwer...@

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Lucas Stach
Am Donnerstag, den 06.09.2018, 16:43 +0200 schrieb Lukas F. Hartmann: > Hi, > > I've updated to and rebuilt the latest git versions of linux, drm, mesa > and kmscube on an imx6qp system. I tried both with etnaviv as a module > and compiled into the kernel (no difference). > > Mesa no longer picks

Re: [Mesa-dev] imx/etnaviv: loader_open_render_node() fails

2018-09-07 Thread Emil Velikov
Hi Lukas, Adding the etnaviv ML - people in there may have some tips. On 6 September 2018 at 15:43, Lukas F. Hartmann wrote: > Hi, > > I've updated to and rebuilt the latest git versions of linux, drm, mesa > and kmscube on an imx6qp system. I tried both with etnaviv as a module > and compiled i

Re: [Mesa-dev] sorry Was: GLU problem with gluNurbsSurface

2018-09-07 Thread j. scheurich
The problem is in gluNurbsSurface. Sorry, the problem do not exist 8-( so long MUFTI ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

  1   2   >