Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

Ping v2. @Emil, @Michel, could you help to review this new version of patch? Thanks, Qiang From: Yu, Qiang Sent: Friday, August 10, 2018 2:22:03 PM To: mesa-dev@lists.freedesktop.org Cc: Adam Jackson; Michel Dänzer; Eric Engestrom; Emil Velikov Subject: Re

[Mesa-dev] [PATCH 2/3] gallium/format: Add a helper to combine separate Z24 and S8 stencil.

This new function takes separate Z24 depth and S8 stencil sources, and packs them into a single combined Z24S8 buffer. --- src/gallium/auxiliary/util/u_format_zs.c | 20 src/gallium/auxiliary/util/u_format_zs.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/src/galli

[Mesa-dev] [PATCH 1/3] gallium/auxiliary: Add util_format_get_depth_only() helper.

This will be used by u_transfer_helper.c shortly, in order to split packed depth-stencil into separate resources. --- src/gallium/auxiliary/util/u_format.h | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.h b/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 3/3] gallium/u_transfer_helper: Add support for separate Z24/S8 as well.

u_transfer_helper already had code to handle treating packed Z32_S8 as separate Z32_FLOAT and S8_UINT resources, since some drivers can't handle that interleaved format natively. Other hardware needs depth and stencil as separate resources for all formats. For example, V3D3 needs this for 24-bit

Re: [Mesa-dev] [PATCH v4 13/15] mesa/st/glsl_to_tgsi: Expose array live range tracking and merging

On Wed, 6 Jun 2018 at 06:30, Gert Wollny wrote: > > This patch ties in the array split, merge, and interleave code. > > shader-db changes in the TGSI code are: This regresses tests/spec/glsl-1.50/execution/variable-indexing/gs-input-array-vec4-index-rd.shader_test on virgl for me here. Dave. __

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

On 09/08/18 05:05, Jason Ekstrand wrote: Commit 4434591bf56a6b0 caused substantially more URB messages in geometry and tessellation shaders. Before we can really enable this sort of optimization, We either need some way of combining them back together into vectors or we need to do cross-stage v

Re: [Mesa-dev] [PATCH] i965: Add a new CFL PCI ID.

On Thu, Aug 09, 2018 at 11:25:31AM +0100, Lionel Landwerlin wrote: > Reviewed-by: Lionel Landwerlin pushed, thanks. > > On 09/08/18 06:44, Rodrigo Vivi wrote: > > One more CFL ID added to spec. > > > > Align with kernel commit d0e062ebb3a4 ("drm/i915/cfl: > > Add a new CFL PCI ID.") > > > > C

Re: [Mesa-dev] [PATCH v2] i965: do not emit empty surface state

Quoting the original patch: ---8<--- This fixes an assert that triggers for me when running dEQP-GLES31.functional.shaders.opaque_type_indexing.ssbo.const_literal_vertex on top of a debug-build of mesa on top of i965. Since setting up a virgl setup is rather convoluted, here's a piglit shader-tes

Re: [Mesa-dev] [PATCH v2] i965: do not emit empty surface state

Hey Erik, Out of curiosity, what app/test managed to run into this assert? We could have some test added :) Thanks, - Lionel On 08/08/18 09:34, Lionel Landwerlin wrote: On 07/08/18 20:31, Erik Faye-Lund wrote: If called with an empty size, brw_emit_buffer_surface_state asserts. We already ha

Re: [Mesa-dev] [PATCH] radv/meta_decompress: fix pointer to integer conversion

On Tue, Aug 14, 2018 at 10:48 PM, Mauro Rossi wrote: > (VkShaderModule) cast is added before NULL to avoid following building error: > > external/mesa/src/amd/vulkan/radv_meta_decompress.c:365:54: error: > incompatible pointer to integer conversion passing 'void *' to parameter > of type 'VkShader

[Mesa-dev] [PATCH] radv/meta_decompress: fix pointer to integer conversion

(VkShaderModule) cast is added before NULL to avoid following building error: external/mesa/src/amd/vulkan/radv_meta_decompress.c:365:54: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'VkShaderModule' (aka 'unsigned long long') [-Werror,-Wint-conversion]

Re: [Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

Hi all, sorry for the typo in the subject the patch is only one, it should have been titled [PATCH] egl/android: fix regression in drm_gralloc path Please review and I am available to test if there are working alternatives to avoid the breakage of drm_gralloc users. Mauro Il giorno mar 14 ago 20

[Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

This patch fixes a regression in mesa 18.2 and mesa-dev branches for HAVE_DRM_GRALLOC code path which is causing black screen on Android and prevents boot due to SIGSEGV MAPERR crash related to unproper handling of drm_gralloc drm FD in new droid_open_device() path. The problem due to c7bb82136b

Re: [Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

On Tue, Aug 14, 2018 at 6:11 PM, Samuel Pitoiset wrote: > The last parameter of radeon_set_sh_reg_seq() is the number of > dwords to emit. We were lucky because WAVES_PER_SH(0x3) is 3 but > it was initialized to 0. > > COMPUTE_RESOURCE_LIMITS is correctly set when generating > compute pipelines, s

Re: [Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

Quoting Jose Fonseca (2018-08-14 11:30:48) > On 14/08/18 18:34, Dylan Baker wrote: > > Bugzilla: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107565&data=02%7C01%7Cjfonseca%40vmware.com%7C2d939ac68f994873752708d6020c5ecf%7Cb39138ca

Re: [Mesa-dev] New EGL extension in mesa and 'adriconf' packaging - EVoC'18

On 8/14/18 4:37 PM, Emil Velikov wrote: If yes, then I think the best approach would be to make a EGL extension based on the two functions, and simply ignore the existing ones, so that backwars-compatibility stays the same. Apart from xdriinfo, driconf and adriconf, I don't think any other a

Re: [Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

On 14/08/18 18:34, Dylan Baker wrote: Bugzilla: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107565&data=02%7C01%7Cjfonseca%40vmware.com%7C2d939ac68f994873752708d6020c5ecf%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C6366986494968873

[Mesa-dev] [PATCH] i965: Reuse the same single-page bo for all zero sized allocations

Similar in principle to how malloc(0) can return the same constant address knowing that the client is not allowed to access any of its bytes (as they do not exist!), we can return the same bo for all zero sized allocation requests. Having a single identifier should help track down the redundant all

Re: [Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

With the one nit, patches 1 and 3 are: Reviewed-by: Dylan Baker I'm not confident on patch 2 to give you an rb. Quoting Eric Engestrom (2018-08-14 10:24:13) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] Why are pbuffers backed by a pixmaps (Was Re: [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.)

On Mon, 2018-08-13 at 16:32 -0700, Kristian Høgsberg wrote: > On Mon, Aug 13, 2018 at 3:53 AM Emil Velikov wrote: > > > > So if I understood you correctly [and the spec] there is no > > requirement (nor ban) on rendering to pbuffers from X11. > > It's an implementation decision to allow it. > >

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

If you are referring to PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS, then that's already taken care of for virgl... On Tue, Aug 14, 2018 at 6:00 PM, Marek Olšák wrote: I'm saying that the limit should be 16k except for the layer/slice dimension where it can be 2k. See radeonsi. Marek On Tue, Aug 14,

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

Hi Sergii, This patch causes 2,384 failures in CI. The issue is that we're apparently trying to allocate 0 size BOs in some places, which are getting rounded up to 4096 with the current code...but with your patch, we get ALIGN(0, 4096) == 0, and assert(bo_size) triggers. We might want to continu

Re: [Mesa-dev] [PATCH mesa 1/3] bin: split `write_if_different()` out

Quoting Eric Engestrom (2018-08-14 10:24:11) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py > index 68a87e72ec563ce6298f..bc0279ccef16d42bb88d 10

[Mesa-dev] [PATCH 2/5] meson: use python3 module to find python3

This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build +

[Mesa-dev] [PATCH 1/5] meson: Ensure that mako is >= 0.8.0

It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif prog_py

[Mesa-dev] [PATCH 4/5] scons: Require python 2.7

less than 2.7 is not supported. --- SConstruct | 1 + 1 file changed, 1 insertion(+) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 --- a/SConstruct +++ b/SConstruct @@ -31,6 +31,7 @@ import common # Minimal scons version EnsureSConsVersion(2, 4) +EnsurePythonVersi

[Mesa-dev] [PATCH 3/5] configure: Enforce python 2.7.x

We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac @

[Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 92a762a0c1e..e05fb40f157 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -29,6 +29,7 @@ Frontend-t

Re: [Mesa-dev] [PATCH v2] egl/android: use drmDevice instead of the manual /dev/dri iteration

On Tuesday, 2018-08-14 10:05:06 +0100, Emil Velikov wrote: > From: Emil Velikov > > Replace the manual handling of /dev/dri in favor of the drmDevice API. > The latter provides a consistent way of enumerating the devices, > providing device details as needed. > > v2: > - Use ARRAY_SIZE (Frank)

[Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index bcc29de1c6218ab3af79..dd967a7ee2b654c1ab92 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py @@ -42,14 +42,14 @@

[Mesa-dev] [PATCH mesa 2/3] bin: make MESA_GIT_SHA1 directly usable in code

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py| 2 +- src/gallium/drivers/svga/svga_screen.c | 6 +- src/gallium/state_trackers/clover/api/device.cpp | 6 +- src/gallium/state_trackers/clover/api/platform.cpp | 6 +- src/git_sha1.h.

[Mesa-dev] [PATCH mesa 1/3] bin: split `write_if_different()` out

Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index 68a87e72ec563ce6298f..bc0279ccef16d42bb88d 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py @@

Re: [Mesa-dev] Piglit for VA-API - Intern - Interested Student

On Tue, Aug 14, 2018 at 3:05 AM Naveen Naidu wrote: > > Hello Everyone, > > I am Naveen a Junior year computer science undergrad from India. I really > apologize for disturbing you people. But I have been going through the > available projects for the XorgEVoC internship program and the project

[Mesa-dev] [Bug 107460] radv: OpControlBarrier does not always work correctly (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=107460 --- Comment #3 from Samuel Pitoiset --- I can confirm the issue with DXVK 0.63 on my RX480, as well as the potential fix. Though, the attached compute shader doesn't seem to be affected. I have to find the good one first. I will let you know. -

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

On 08/13/2018 03:43 PM, Ian Romanick wrote: > On 08/09/2018 01:14 PM, Sagar Ghuge wrote: >> >> >> On 08/09/2018 01:09 PM, Marek Olšák wrote: >>> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and >>>

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

I don't think this will be picked up by the stable spotting scripts, does it need a Fixes: tag? Dylan Quoting Jason Ekstrand (2018-08-08 12:05:00) > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of op

Re: [Mesa-dev] [PATCH mesa] travis: install correct version of mako for each build system

Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-13 04:15:06) > Meson now uses python3, so let's add a block for Autotools, move that > line into the buildsys-specific blocks, and set the correct version for > Meson. > > Fixes: 2ee1c86d71bee5ddca2c "meson: Build with Python 3" > Signed-o

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

Quoting Emil Velikov (2018-08-14 03:00:45) > On 8 August 2018 at 15:36, Juan A. Suarez Romero wrote: > > Like in the autotools target, make the list of drivers to be built in > > each of the Meson targets explicit. > > > > This will help to identify missing dependencies and other issues more > > e

[Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

The last parameter of radeon_set_sh_reg_seq() is the number of dwords to emit. We were lucky because WAVES_PER_SH(0x3) is 3 but it was initialized to 0. COMPUTE_RESOURCE_LIMITS is correctly set when generating compute pipelines, so we don't need to initialize it. Signed-off-by: Samuel Pitoiset -

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

On Wednesday, August 8, 2018 12:05:00 PM PDT Jason Ekstrand wrote: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of optimization, We either need some way of combining them back > together into vector

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

On 14/08/18 16:16, Rafael Antognolli wrote: On Tue, Aug 14, 2018 at 03:36:18PM +0100, Lionel Landwerlin wrote: On 14/08/18 12:55, asimiklit.work wrote: Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START

[Mesa-dev] [Bug 107565] TypeError: __init__() got an unexpected keyword argument 'future_imports'

https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- Comment #1 from Dylan Baker --- Scons doesn't check that mako is at least 0.8.0 like autotools does (which was released in 2013, btw). The real bug here is that scons doesn't do proper checks like it should. -- You are receiving this mail

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

I'm saying that the limit should be 16k except for the layer/slice dimension where it can be 2k. See radeonsi. Marek On Tue, Aug 14, 2018, 11:57 AM Erik Faye-Lund wrote: > What are you referring to, exactly? In OpenGL, texture size-limits are per > axis, not in total... > > On Tue, Aug 14, 2018

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

What are you referring to, exactly? In OpenGL, texture size-limits are per axis, not in total... On Tue, Aug 14, 2018 at 5:43 PM, Marek Olšák wrote: You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14, 2018, 9:02 AM Erik Faye-Lund wrote: These macro-na

Re: [Mesa-dev] [PATCH 2/3] radv: hardcode shader WAVE_LIMIT to the maximum value

On 8/14/18 5:46 PM, Marek Olšák wrote: On Tue, Aug 14, 2018, 8:28 AM Samuel Pitoiset > wrote: On 8/1/18 5:12 AM, Marek Olšák wrote: > On Fri, Oct 20, 2017 at 4:34 PM, Andres Rodriguez mailto:andre...@gmail.com>> wrote: >> When WAVE_LIMIT

[Mesa-dev] [Bug 107566] AttributeError: 'tuple' object has no attribute 'major'

https://bugs.freedesktop.org/show_bug.cgi?id=107566 Dylan Baker changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 107564] AttributeError: 'module' object has no attribute 'combinations_with_replacement'

https://bugs.freedesktop.org/show_bug.cgi?id=107564 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/3] radv: hardcode shader WAVE_LIMIT to the maximum value

On Tue, Aug 14, 2018, 8:28 AM Samuel Pitoiset wrote: > > > On 8/1/18 5:12 AM, Marek Olšák wrote: > > On Fri, Oct 20, 2017 at 4:34 PM, Andres Rodriguez > wrote: > >> When WAVE_LIMIT is set, a submission will opt-in for SPI based resource > >> scheduling. Because this mechanism is cooperative, we

Re: [Mesa-dev] [PATCH] virgl: bump 3D texture limit to 2048, as GL4.1 requires

On Tue, Aug 14, 2018 at 2:59 AM Erik Faye-Lund wrote: > > > > On Tue, Aug 14, 2018 at 5:47 AM, Gurchetan Singh > wrote: > > This is virgl analogue to cf6dad. Fixes: > dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases: > dEQP-GLES31.functional.image_load_store.3d.atomic.add

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14, 2018, 9:02 AM Erik Faye-Lund wrote: > These macro-names are also used for softpipe, so let's avoid confusion > by avoiding them. Besides, they are just used in one place in virgl, so > let's just inline t

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

On Tue, Aug 14, 2018 at 03:36:18PM +0100, Lionel Landwerlin wrote: > On 14/08/18 12:55, asimiklit.work wrote: > > Hi Lionel, > > > Hi Andrii, > > > > > > Again sorry, I don't think this is the right fix. > > > I'm sending another patch to fix the parsing of > > > MI_BATCH_BUFFER_START which seems

[Mesa-dev] [Bug 107460] radv: OpControlBarrier does not always work correctly (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=107460 --- Comment #2 from Philip Rebohle --- Created attachment 141081 --> https://bugs.freedesktop.org/attachment.cgi?id=141081&action=edit Screenshot that shows the issue Here's a screenshot. Basically, the water geometry is extremely messed up a

Re: [Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

On Tuesday, 2018-08-14 14:49:28 +0300, Tapani Pälli wrote: > > > On 08/14/2018 01:54 PM, Eric Engestrom wrote: > > On Tuesday, 2018-08-14 11:58:52 +0300, Tapani Pälli wrote: > > > Patch implements common bits for EXT_surface_SMPTE2086_metadata > > > and EXT_surface_CTA861_3_metadata extensions by

Re: [Mesa-dev] New EGL extension in mesa and 'adriconf' packaging - EVoC'18

On 14 August 2018 at 14:59, Jean Hertel wrote: > Emil Velikov wrote: > >>Hi everyone, >> >>As Veluri has noticed, I made a few comments earlier to his proposal/plans. >>Having a comprehensive configuration tool is a great task, although >>there is an underlying issue as pointed out [A]. >> >>Or l

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

On 14/08/18 12:55, asimiklit.work wrote: Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, Thanks for your fast reply. I agree that it

[Mesa-dev] [Bug 107460] radv: OpControlBarrier does not always work correctly (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=107460 --- Comment #1 from Samuel Pitoiset --- Can you upload a screenshot of the rendering issue, please? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] New EGL extension in mesa and 'adriconf' packaging - EVoC'18

Emil Velikov wrote: >Hi everyone, > >As Veluri has noticed, I made a few comments earlier to his proposal/plans. >Having a comprehensive configuration tool is a great task, although >there is an underlying issue as pointed out [A]. > >Or looking for a proper solution for [A]. Since that hack is f

Re: [Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

I forgot to mention, this patch depends on a virglrenderer MR that hasn't been merged yet. So it shouldn't be merged before the MR has landed. https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/25 On Tue, Aug 14, 2018 at 3:02 PM, Erik Faye-Lund wrote: Instead of doing conser

[Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

These macro-names are also used for softpipe, so let's avoid confusion by avoiding them. Besides, they are just used in one place in virgl, so let's just inline them into the place they are used instead. While we're at it, fixup an error in the comment for the 3D version. Mesa subtracts computes m

[Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

Instead of doing conservative guesses, we should report the max levels based on the max sizes we get from GL on the host. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_hw.h | 3 +++ src/gallium/drivers/virgl/virgl_screen.c | 7 +++ 2 files changed, 10 insertions(+) d

Re: [Mesa-dev] New EGL extension in mesa and 'adriconf' packaging - EVoC'18

Hi everyone, On 4 July 2018 at 19:36, Veluri Mithun wrote: > Dear developers, > > I'm an undergraduate student in India. I've great enthusiasm to contribute > to mesa and I've already done a few contributions to adriconf. > > Currently, adriconf isn't able to configure the mesa drivers in a machi

Re: [Mesa-dev] [PATCH 04/18] radeonsi: use get_resinfo diretly in lower_gather4_integer

*directly* Assuming this doesn't break anything, series is: Reviewed-by: Samuel Pitoiset On 8/4/18 9:54 AM, Marek Olšák wrote: From: Marek Olšák --- .../drivers/radeonsi/si_shader_tgsi_mem.c | 25 +-- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 2/3] radv: hardcode shader WAVE_LIMIT to the maximum value

On 8/1/18 5:12 AM, Marek Olšák wrote: On Fri, Oct 20, 2017 at 4:34 PM, Andres Rodriguez wrote: When WAVE_LIMIT is set, a submission will opt-in for SPI based resource scheduling. Because this mechanism is cooperative, we must ensure that all submissions have this field set, otherwise they wil

Re: [Mesa-dev] [PATCH] radv: Update to new VK_EXT_vertex_attribute_divisor to version 2.

Reviewed-by: Samuel Pitoiset On 7/23/18 4:24 PM, Bas Nieuwenhuizen wrote: Behavior wrt firstInstance got changed, and a divisor of 0 has been disallowed. The new version of the ext got published in specification 1.1.81. --- src/amd/vulkan/radv_extensions.py | 2 +- src/amd/vulkan/radv_nir_t

Re: [Mesa-dev] [PATCH] radv: Allow ETC2 on RAVEN and VEGA10 instead of all GFX9.

Reviewed-by: Samuel Pitoiset On 7/28/18 2:01 PM, Bas Nieuwenhuizen wrote: Follow radeonsi. Fixes: 3665f66ef26 "radv: Add support for ETC2 textures." --- src/amd/vulkan/radv_formats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/am

Re: [Mesa-dev] [PATCH 1/6] configure: bump libdrm for AMDGPU to 2.4.92

Hi Dieter, Not really, I still have some weird regressions to fix on Polaris before landing the series. Thanks! On 7/28/18 11:03 PM, Dieter Nützel wrote: Hello Samuel, any progress on this? Greetings, Dieter Am 04.07.2018 15:06, schrieb Samuel Pitoiset: This will allow us to submit more I

Re: [Mesa-dev] [PATCH 1/4] ddebug: implement set_window_rectangles

Series is: Reviewed-by: Samuel Pitoiset On 8/9/18 3:29 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/driver_ddebug/dd_context.c b/src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH] radv: Fix missing Android platform define.

Acked-by: Samuel Pitoiset On 8/10/18 2:27 AM, Bas Nieuwenhuizen wrote: CC: --- src/amd/vulkan/Android.mk | 2 ++ src/amd/vulkan/Makefile.am | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk index cee3744f40b..51b035

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, Thanks for your fast reply. I agree that it is not correct patch for this issue but a

Re: [Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

On 08/14/2018 01:54 PM, Eric Engestrom wrote: On Tuesday, 2018-08-14 11:58:52 +0300, Tapani Pälli wrote: Patch implements common bits for EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata extensions by adding new required attributes and eglQuerySurface + eglSurfaceAttrib changes

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

Hello, seems some part of the World is still may waiting for a possibility to play Dying Light... till pushed :) On Mon, Aug 6, 2018 at 4:26 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 06/08/18 13:41, Sergii Romantsov wrote: > >> Kernel (for ppgtt) requires memory address t

Re: [Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

On Tuesday, 2018-08-14 11:58:52 +0300, Tapani Pälli wrote: > Patch implements common bits for EXT_surface_SMPTE2086_metadata > and EXT_surface_CTA861_3_metadata extensions by adding new required > attributes and eglQuerySurface + eglSurfaceAttrib changes. > > Currently none of the drivers are util

Re: [Mesa-dev] [PATCH v3 1/4] nv50/ir: add preliminary support for OP_XMAD

okay, with that removed, patch is Reviewed-by: Karol Herbst On Fri, Aug 10, 2018 at 6:33 PM, Rhys Perry wrote: > I don't think so. > > On Wed, Aug 8, 2018 at 11:27 PM, Karol Herbst wrote: >> On Mon, Jul 23, 2018 at 12:40 PM, Rhys Perry >> wrote: >>> Signed-off-by: Rhys Perry >>> --- >>> src

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

On 08/14/2018 12:15 PM, Danylo Piliaiev wrote: Hi, On 08/14/2018 10:53 AM, Tapani Pälli wrote: Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);    

[Mesa-dev] [PATCH] intel: decoder: unify MI_BB_START field naming

The batch decoder looks for a field with a particular name to decide whether an MI_BB_START leads into a second batch buffer level. Because the names are different between Gen7.5/8 and the newer generation we fail that test and keep on reading (invalid) instructions. Signed-off-by: Lionel Landwerl

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, - Lionel On 14/08/18 10:04, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit The "gen_gro

Re: [Mesa-dev] [1/2] loader: add loader_open_name(..)

Am Fr., 10. Aug. 2018 um 19:52 Uhr schrieb Emil Velikov : > > On 10 August 2018 at 13:25, Martin Fuzzey > wrote: > > Hi Christian, > > > > On 01/08/18 23:07, Christian Gmeiner wrote: > >> > >> Add an improved drmOpenWithType(..) clone which fixes some serious > >> flaws. Some highlights: > >> -

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

On 8 August 2018 at 15:36, Juan A. Suarez Romero wrote: > Like in the autotools target, make the list of drivers to be built in > each of the Meson targets explicit. > > This will help to identify missing dependencies and other issues more > easily. > > CC: Emil Velikov Thanks Juan! Sorry for mis

Re: [Mesa-dev] [PATCH] virgl: bump 3D texture limit to 2048, as GL4.1 requires

On Tue, Aug 14, 2018 at 5:47 AM, Gurchetan Singh wrote: This is virgl analogue to cf6dad. Fixes: dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases: dEQP-GLES31.functional.image_load_store.3d.atomic.add_r32ui_return_value dEQP-GLES31.functional.image_load_store.3

Re: [Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

On 14 August 2018 at 10:20, Dave Airlie wrote: > > > On Tue., 14 Aug. 2018, 19:19 Emil Velikov, wrote: >> >> On 7 August 2018 at 23:44, Dave Airlie wrote: >> >> > +/* texture barrier */ >> > +#define VIRGL_TEXTURE_BARRIER_SIZE 1 >> > +#define VIRGL_TEXTURE_BARRIER_FLAGS 1 >> > + >> Seemingly unu

[Mesa-dev] [PATCH libdrm v3] radeon, evergreen: ensure equal sizes for certain depth-stencil textures

On evergreen depth-stencil textures are allocated as two objects, and when using the eg_surface_init_1d_miptrees code path the size evaluation uses the generalized surf_minify function. Here when allocating the depth texture the alignment takes the depth bpe value into account, and uses bpe=1 for t

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

Hi, On 08/14/2018 10:43 AM, Tapani Pälli wrote: On 08/13/2018 08:54 PM, Ian Romanick wrote: On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);     vec2 t =

Re: [Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

On Tue., 14 Aug. 2018, 19:19 Emil Velikov, wrote: > On 7 August 2018 at 23:44, Dave Airlie wrote: > > > +/* texture barrier */ > > +#define VIRGL_TEXTURE_BARRIER_SIZE 1 > > +#define VIRGL_TEXTURE_BARRIER_FLAGS 1 > > + > Seemingly unused. Left over from prototype stage or the patches that > use t

Re: [Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

On 7 August 2018 at 23:44, Dave Airlie wrote: > +/* texture barrier */ > +#define VIRGL_TEXTURE_BARRIER_SIZE 1 > +#define VIRGL_TEXTURE_BARRIER_FLAGS 1 > + Seemingly unused. Left over from prototype stage or the patches that use then haven't made it out? -Emil ___

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

Hi, On 08/14/2018 10:53 AM, Tapani Pälli wrote: Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);     vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.free

[Mesa-dev] [PATCH v2] egl/android: use drmDevice instead of the manual /dev/dri iteration

From: Emil Velikov Replace the manual handling of /dev/dri in favor of the drmDevice API. The latter provides a consistent way of enumerating the devices, providing device details as needed. v2: - Use ARRAY_SIZE (Frank) - s/famour/favor/ typo (Frank) - Make MAX_DRM_DEVICES a macro - fix vla e

[Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

From: Andrii Simiklit The "gen_group_get_length" function can return a negative value and it can lead to the out of bounds group_iter. v2: printing of "unknown command type" was added Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107544 Signed-off-by: Andrii Simiklit --- src/intel/com

Re: [Mesa-dev] [PATCH] mesa: shader dump/read support for ARB programs

On 14/08/18 10:58, Tapani Pälli wrote: > > > On 08/14/2018 11:53 AM, Alejandro Piñeiro wrote: >> >> >> On 24/07/18 09:41, Tapani Pälli wrote: >>> Signed-off-by: Tapani Pälli >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106283 >>> --- >>>   src/mesa/main/arbprogram.c | 26

[Mesa-dev] [PATCH v2] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

Patch implements common bits for EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata extensions by adding new required attributes and eglQuerySurface + eglSurfaceAttrib changes. Currently none of the drivers are utilizing this data but this patch is enabler in getting there. v2: don'

Re: [Mesa-dev] [PATCH] mesa: shader dump/read support for ARB programs

On 08/14/2018 11:53 AM, Alejandro Piñeiro wrote: On 24/07/18 09:41, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106283 --- src/mesa/main/arbprogram.c | 26 ++ src/mesa/main/shaderapi.c | 17 ++

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

Hi Chad; On 08/08/2018 06:53 PM, Tapani Pälli wrote: On 07.08.2018 21:16, Chad Versace wrote: On Mon 06 Aug 2018, Chad Versace wrote: On Fri 03 Aug 2018, Tapani Pälli wrote: One tiny nit below but for patches 3,4 and 5: Reviewed-by: Tapani Pälli Special thanks for the documentation. I wa

Re: [Mesa-dev] [PATCH] mesa: shader dump/read support for ARB programs

On 24/07/18 09:41, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106283 > --- > src/mesa/main/arbprogram.c | 26 ++ > src/mesa/main/shaderapi.c | 17 ++--- > src/mesa/main/shaderapi.h | 6 ++

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

On 13/08/18 20:43, Dylan Baker wrote: > This probably should have a Fixes tag? Yes, should had, but I pushed it as soon as I got a Rb :/ Sorry > > Quoting Alejandro Piñeiro (2018-08-13 07:50:38) >> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this >> patch replaces it with unsigne

Re: [Mesa-dev] [PATCH] mesa: shader dump/read support for ARB programs

ping .. On 07/24/2018 10:41 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106283 --- src/mesa/main/arbprogram.c | 26 ++ src/mesa/main/shaderapi.c | 17 ++--- src/mesa/main/shaderapi.h | 6 ++

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 Signed-off-by:

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

On 08/13/2018 08:54 PM, Ian Romanick wrote: On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Do we have tests like this in pigli

[Mesa-dev] [Bug 107566] AttributeError: 'tuple' object has no attribute 'major'

https://bugs.freedesktop.org/show_bug.cgi?id=107566 --- Comment #2 from Tomeu Vizoso --- (In reply to Tomeu Vizoso from comment #1) > Workaround: > > diff --git a/src/util/xmlpool/gen_xmlpool.py > b/src/util/xmlpool/gen_xmlpool.py > index 327709c7f8dd..0d97fbcfcf3f 100644 > --- a/src/util/xmlpoo

[Mesa-dev] [Bug 107566] AttributeError: 'tuple' object has no attribute 'major'

https://bugs.freedesktop.org/show_bug.cgi?id=107566 Tomeu Vizoso changed: What|Removed |Added CC||to...@tomeuvizoso.net --- Comment #1 fro

[Mesa-dev] [Bug 107566] AttributeError: 'tuple' object has no attribute 'major'

https://bugs.freedesktop.org/show_bug.cgi?id=107566 Bug ID: 107566 Summary: AttributeError: 'tuple' object has no attribute 'major' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Sta

[Mesa-dev] Piglit for VA-API - Intern - Interested Student

Hello Everyone, I am Naveen a Junior year computer science undergrad from India. I really apologize for disturbing you people. But I have been going through the available projects for the XorgEVoC internship program and the project *Piglit for VA-API *caught my attention. This project really intri

  1   2   >