From: Mathias Fröhlich
Using the newly introduced VAO array maps, we can
simplify vbo_bind_vertex_list.
Signed-off-by: Mathias Fröhlich
---
src/mesa/vbo/vbo_save_draw.c | 54 +++-
1 file changed, 8 insertions(+), 46 deletions(-)
diff --git a/src/mesa/vb
From: Mathias Fröhlich
The materials are now moved to the end of the
generic attributes block to the range 4-15.
Before, the way the position and generic 0 attribute
is handled was dependent on the presence and kind of
the currently attached vertex program. With this
change the way the position
From: Mathias Fröhlich
Using the newly introduced VAO array maps, we can
simplify vbo_exec_bind_arrays.
Signed-off-by: Mathias Fröhlich
---
src/mesa/vbo/vbo_exec_draw.c | 81
1 file changed, 15 insertions(+), 66 deletions(-)
diff --git a/src/mesa/v
From: Mathias Fröhlich
When executing a display list draw, for the offset
list to be correct, the offset computation needs to
accumulate all attribute size values in order.
Specifically, if we are shuffling around the position
and generic0 attributes, we may violate the order or
if we do not walk
From: Mathias Fröhlich
Instead of each context having its own map instance for
this purpose, use a global static const map.
Signed-off-by: Mathias Fröhlich
---
src/mesa/vbo/vbo_context.c| 23 ++
src/mesa/vbo/vbo_exec.c | 74 +++
src
From: Mathias Fröhlich
Instead of just assuming that the material attributes
just overlap with the generic attributes 0-12, give
them symbolic defines so that we can easier move them
to an other range.
Signed-off-by: Mathias Fröhlich
---
src/compiler/shader_enums.h | 10 +++
From: Mathias Fröhlich
This is the starting point to a patch series that I intent to feed.
The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently
happen at about any draw call.
The series tries to separate out one of the depencies of the attribute
aliasing code as a preparation
From: Mathias Fröhlich
Since the first material attribute no longer aliases with
the generic0 attribute, only aliasing between generic0 and
position is left and entirely dependent on the enabled
state of the VAO. So introduce a gl_attribute_map_mode
in the VAO that is used to track how the positi
From: Mathias Fröhlich
Using the newly introduced VAO state variable, we can
simplify recalculate_input_bindings.
Signed-off-by: Mathias Fröhlich
---
src/mesa/vbo/vbo_exec_array.c | 110 +++---
1 file changed, 27 insertions(+), 83 deletions(-)
diff --git a/
From: Dave Airlie
This is a cayman only patch, it doesn't appear that
evergreen supports the ALU on VPM. I'll try and figure it out later.
All I can say for this patch is it passes the piglit test and
the CTS tests.
This also disable sb for helper invocations until it doesn't
mess up the MBCNTs
Patch moves functions higher so that we can utilize them from
test_disk_cache_create which is modified by next patch.
Signed-off-by: Tapani Pälli
---
src/compiler/glsl/tests/cache_test.c | 70 ++--
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/sr
v2: add disk_cache_has_key, disk_cache_put_key support
using blob cache (Nicolai, Jordan)
v3: rename set_cb as put_cb to match existing naming (Timothy)
Signed-off-by: Tapani Pälli
---
src/util/disk_cache.c | 49 +
src/util/disk_cache.h | 19 +
v2: adjust to change that moved cache from ctx to screen
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_screen.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index
v2: move from __DRIcontext to __DRIscreen (Emil Velikov)
Signed-off-by: Tapani Pälli
---
include/GL/internal/dri_interface.h | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_interface.h
i
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without a path using callback
functionality introduced by next patch.
v2: unmap mmap and destroy queue only if index_mmap exists
Signed-off-by: Tapani Pälli
---
src/util/disk_cache.c | 127 +++
Yet another EGL_ANDROID_blob_cache, some patches are re-sent but I
thought it would be easier to read when sending all patches at once.
This functionality can be tested on desktop with any EGL app using this
branch:
https://cgit.freedesktop.org/~tpalli/mesa/log/?h=ANDROID_blob_cache_debug_v2
An
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
Signed-off-by: Tapani Pälli
---
src/egl/drivers/dri2/egl_dri2.c | 25 +
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/main/eglapi.c | 30
Next patch will allow disk_cache instance to be created without
path set for it, remove some test cases that assume disk_cache
creation to fail with invalid path.
To test if different paths work, insert put/get cycle before
directory check so that path gets properly created.
Signed-off-by: Tapani
2018-01-31 3:38 GMT+01:00 Dave Airlie :
> On 31 January 2018 at 12:27, Dieter Nützel wrote:
>> Ping!
>
> I'm not sure this was much of a win, and if it makes things worse in some
> cases,
> then it needs a lot more investigation, so probably consider it dead for now.
>
> Dave.
>
I have a new has
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:43 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] st/mesa: whitespace, formatting fixes in
st_glsl_to_tgsi.cpp
--
On 31/01/18 15:05, Timothy Arceri wrote:
This has been unused since 100796c15c3a.
---
Please note this is not even compile tested as I don't have clover > 7.0.0
repo to go with my current llvm 7.0.0 setup. Any testing is
appreciated.
That was meant to say clang repo.
__
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:27 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use opcode local var to simplify some code
---
src/gall
This has been unused since 100796c15c3a.
---
Please note this is not even compile tested as I don't have clover
7.0.0 repo to go with my current llvm 7.0.0 setup. Any testing is
appreciated.
src/gallium/docs/source/screen.rst | 4 ++--
src/gallium/include/pipe/p_defin
On 30 January 2018 at 02:26, Matthew Nicholls
wrote:
> This can lead to a situation where cache flushes could get conditionally
> disabled while still clearing the flush_bits, and thus flushes due to
> application pipeline barriers may never get executed.
Thanks I've pushed this now.
Dave.
_
On 01/30/2018 08:25 PM, Roland Scheidegger wrote:
I wasn't sure if someone wanted to fix it by using special getter for
it, but it might not be worth the trouble... Thanks!
If someone wants to do it that way, that's fine by me. This is just
simpler for the time being.
-Brian
Reviewed-by:
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 273 ++---
1 file changed, 169 insertions(+), 104 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index a1e37cf..c92b1d9 100644
--- a/src/mesa/state_tracker/
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 84ed614..a1e37cf 100644
--- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
+++
---
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
index 2f16935..da520be 100644
--- a/src/gallium/drivers/svga/svga_t
---
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
index da520be..73aa78b 100644
--- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
+++ b
On 01/30/2018 07:48 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> This only affects drivers that set DriverFlags.NewBlend.
> ---
> src/mesa/main/blend.c | 6 --
> src/mesa/main/blend.h | 41
> +++
> src/mesa/main/enable.c
I wasn't sure if someone wanted to fix it by using special getter for
it, but it might not be worth the trouble... Thanks!
Reviewed-by: Roland Scheidegger
Am 31.01.2018 um 03:35 schrieb Brian Paul:
> This reverts part of the patch which introduced the GLenum16 change.
> Fixes a conform regressio
Am 12.01.2018 01:31, schrieb Dieter Nützel:
Tested-by: Dieter Nützel
This offer an additional 1-1,5% (~20 fps) boost with 'smoketest'.
6290 presents in 5.00045 seconds (FPS: 1257.89)
6291 presents in 5.00041 seconds (FPS: 1258.1)
6293 presents in 5.00065 seconds (FPS: 1258.44)
6289 presents in
Support for these extensions is available in radeonsi.
Signed-off-by: Andres Rodriguez
---
docs/features.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/features.txt b/docs/features.txt
index 2e110d9994..1672460a2f 100644
--- a/docs/features.txt
+++ b/docs/featur
On 31 January 2018 at 12:27, Dieter Nützel wrote:
> Ping!
I'm not sure this was much of a win, and if it makes things worse in some cases,
then it needs a lot more investigation, so probably consider it dead for now.
Dave.
>
> Am 11.01.2018 04:53, schrieb Dave Airlie:
>>
>> From: Dave Airlie
>
This reverts part of the patch which introduced the GLenum16 change.
Fixes a conform regression found by Roland.
Fixes: f96a69f916aed405 ("mesa: replace GLenum with GLenum16 in
common structures (v4)")
---
src/mesa/main/get_hash_params.py | 2 +-
src/mesa/main/mtypes.h | 4 ++--
2 files
On 01/30/2018 07:25 PM, Roland Scheidegger wrote:
FWIW the same commit also broke conform (completely - it will
refuse to run even a single test due to failing mustpass).
Default State test failed.
State Report. (Current) <-> (Default)
GL_POLYGON_MODE (State Information)
Marek Olšák writes:
> From: Marek Olšák
>
> Broken by f96a69f916aed40519e755d0460a83940a587
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mai
Ping!
Am 11.01.2018 04:53, schrieb Dave Airlie:
From: Dave Airlie
This should make the merging of cmd buffers less CPU intensive,
note I said *should* :)
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 47
---
1 file changed, 20 insertions(+), 27 deletions(-)
di
FWIW the same commit also broke conform (completely - it will
refuse to run even a single test due to failing mustpass).
Default State test failed.
State Report. (Current) <-> (Default)
GL_POLYGON_MODE (State Information)
GL_FILL -1 (Bad enumeration) <-> GL_FILL GL_FILL
Can
On 31 January 2018 at 12:04, Gurchetan Singh
wrote:
> Any plans to merge this? This fixes Chrome not starting with Virgl.
Oops pushed now.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/me
Any plans to merge this? This fixes Chrome not starting with Virgl.
Reviewed-by: Gurchetan Singh
Tested-by: Gurchetan Singh
On Mon, Nov 13, 2017 at 12:53 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes some dEQP tests that generated bad shaders.
>
> Fixes: b6f6ead19 (virgl: drop co
I forgot to add that adding the opts also required some of the lowering
passes to be called slightly earlier.
On 31/01/18 12:58, Timothy Arceri wrote:
All of the current gallium nir driver use these optimisations but
they do so in their backends. Having these called in the backend
only can caus
All of the current gallium nir driver use these optimisations but
they do so in their backends. Having these called in the backend
only can cause a number of problems:
- Shader compile times are greater because the opts need to do
significant passes over all shader variants.
- The shader cache i
Completely untested.
---
src/intel/blorp/blorp_clear.c | 12 +++-
src/intel/blorp/blorp_genX_exec.h | 6 ++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index dd29d9e..32ec31b 100644
--- a/src/intel/bl
On Tue, Jan 30, 2018 at 5:03 PM, Nanley Chery wrote:
> On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote:
> > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery
> wrote:
> >
> > > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote:
> > > > Even though the blorp pass looks a b
On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote:
> On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote:
>
> > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote:
> > > Even though the blorp pass looks a bit on the sketchy side, the end
> > > result in the Vulkan driver
On Fri, Jan 19, 2018 at 03:47:40PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.c | 2 +-
> src/intel/blorp/blorp.h | 19 +
> src/intel/blorp/blorp_clear.c | 2 +-
> src/intel/blorp/blorp_genX_exec.h
On Fri, Jan 19, 2018 at 03:47:39PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.h | 9 +--
> src/intel/blorp/blorp_clear.c | 10
> src/intel/blorp/blorp_genX_exec.h | 16 ++--
> src/intel/blorp/blorp_priv.h
2018-01-30 16:11 GMT+01:00 Juan A. Suarez Romero :
> According with OpenGL GLSL 3.20 spec, section 4.3.9:
>
> "It is a link-time error if any particular shader interface
>contains:
> - two different blocks, each having no instance name, and each
>having a member of the same name,
On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote:
> On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote:
> > Even though the blorp pass looks a bit on the sketchy side, the end
> > result in the Vulkan driver is very nice. Instead of having this weird
> > case where you do a fast c
From: Dave Airlie
Bas's pipeline rework made me relook at the struct packing:
radv_cmd_state: 984->968
radv_cmd_buffer: 2910->2896
radv_image: 1008->1000
radv_pipeline: 1640->1632
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_private.h | 25 ++---
1 file changed, 14 i
From: Dave Airlie
This makes this got from 136->128 bytes.
Signed-off-by: Dave Airlie
---
src/compiler/shader_info.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h
index f6dedb8d624..2edf8220bdd 100
This month's Dave hasn't got enough sleep to do real work, lets
repack some structs.
The format descriptions one is quite good though it reduces the
radv binary data segment.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.
From: Dave Airlie
This reduces the size from 28->24 bytes.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_shader_info.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_shader_info.h b/src/amd/common/ac_shader_info.h
index 59b749576aa..7283433bfce 100644
From: Dave Airlie
This repacks to reduce the usage from 72->64 bytes, but also
makes the descriptions static const so they don't just stay in
the same unit.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/vk_format.h| 3 ++-
src/amd/vulkan/vk_format_table.py | 4 ++--
2 files changed, 4
On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote:
> Even though the blorp pass looks a bit on the sketchy side, the end
> result in the Vulkan driver is very nice. Instead of having this weird
> case where you do a fast clear and then maybe have to resolve, we just
> do the ambiguate
On Tue, Jan 30, 2018 at 2:24 PM, Nanley Chery wrote:
> On Fri, Jan 19, 2018 at 05:25:41PM -0800, Jason Ekstrand wrote:
> > On Fri, Jan 19, 2018 at 3:47 PM, Jason Ekstrand
> > wrote:
> >
> > > This pass performs an "ambiguate" operation on a CCS-compressed surface
> > > by manually writing zeros
On Fri, Jan 19, 2018 at 05:25:41PM -0800, Jason Ekstrand wrote:
> On Fri, Jan 19, 2018 at 3:47 PM, Jason Ekstrand
> wrote:
>
> > This pass performs an "ambiguate" operation on a CCS-compressed surface
> > by manually writing zeros into the CCS. On gen8+, ISL gives us a fairly
> > detailed notion
Reviewed-by: Brian Paul
On 01/30/2018 02:46 PM, Marek Olšák wrote:
From: Marek Olšák
Broken by f96a69f916aed40519e755d0460a83940a587
---
src/mesa/main/get_hash_params.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/m
From: Marek Olšák
Broken by f96a69f916aed40519e755d0460a83940a587
---
src/mesa/main/get_hash_params.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
index 7cd195c..55d29e9 100644
--- a/src/mesa/main/g
From: Marek Olšák
Please test RADV.
---
src/amd/common/ac_nir_to_llvm.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 0ab16c4..428764b 100644
--- a/src/amd/common/ac_nir_to_llvm.c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index c958da6..b5fad34 100644
--- a/s
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c| 3 ++-
src/amd/common/ac_llvm_build.h| 1 +
src/amd/common/ac_nir_to_llvm.c | 4 ++--
src/gallium/drivers/radeonsi/si_shader.c | 2 +-
src/gallium/drivers/radeonsi/si_shader_t
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader_internal.h | 4
src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 7 ---
2 files changed, 11 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_internal.h
b/src/gallium/drivers/radeonsi/si_shader_internal
From: Marek Olšák
The supported counts are 1, 2, 4. (3=4)
The following snippet loads float, vec2, vec3, and vec4:
Before:
buffer_load_format_x v9, v4, s[0:3], 0 idxen ; E0002000 8904
buffer_load_format_xyzw v[0:3], v5, s[8:11], 0 idxen ; E00C2000 80020005
s_waitcnt vm
Quoting Emil Velikov (2018-01-30 10:43:06)
> On 29 January 2018 at 18:57, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-01-29 10:15:50)
> >> The big comment is taken from the equivalent block in configure.ac
> >>
> >> Signed-off-by: Eric Engestrom
> >> ---
> >> meson.build
On Tue, Jan 30, 2018 at 12:32 AM, Samuel Pitoiset
wrote:
>
>
> On 01/30/2018 12:03 AM, Bas Nieuwenhuizen wrote:
>>
>> llvm.amdgcn.kill is currently broken for SGPRs. The old intrinsic
>> had that issue too, but did not fold the preceding comparison into
>> the machine instruction in LLVM. As the p
Hi Brian,
> Ah right. At one point I thought about dlist sharing, but I forgot to
> address that in the end.
>
> I think one way to address that would be to put a mutex in the
> vbo_save_vertex_list so it can only be accessed by one context at a
> time. Plus, check if the calling context mat
Hi Axel,
>Hi all,
>
>Don't hesitate to recycle parts of my old try at DriConf Replacement:
>
>https://github.com/axeldavy/driCenter
>
>It had automatic detection of prime system and of the device_id.
>It detected also on which card apps run, and running apps.
Thanks for pointing this out.
Righ
Quoting Emil Velikov (2018-01-30 10:56:42)
> Hi Jon,
>
> On 28 January 2018 at 14:24, Jon Turney wrote:
> > ---
> > meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 7e194a9f10d..8fdbaa8b8d8 100644
> > --- a/meson.build
On 2018-01-29 02:02 PM, Marek Olšák wrote:
On Tue, Jan 23, 2018 at 10:16 PM, Andres Rodriguez wrote:
Also, the associated piglit patches:
https://lists.freedesktop.org/archives/piglit/2017-December/023600.html
You can just push the piglit patches if you get no review there.
Thanks for the
Hi Jon,
On 28 January 2018 at 14:24, Jon Turney wrote:
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7e194a9f10d..8fdbaa8b8d8 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -935,7 +935,7 @@ elif with_dri_i965 a
On 29 January 2018 at 18:57, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-01-29 10:15:50)
>> The big comment is taken from the equivalent block in configure.ac
>>
>> Signed-off-by: Eric Engestrom
>> ---
>> meson.build | 30
>> +
>>
ping
Quoting Dylan Baker (2018-01-25 16:14:45)
> Signed-off-by: Dylan Baker
> ---
>
> I have tested building every mesa driver against this (with and without udev!)
> so I'm pretty sure that this is the last pkgbuild problem.
>
> I'm sure I'll be sad in a day or two...
>
> nouveau/meson.build
Quoting Eric Engestrom (2018-01-30 09:55:53)
>
>
> On January 30, 2018 5:34:07 PM UTC, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-01-29 10:15:50)
> > > The big comment is taken from the equivalent block in configure.ac
> > >
> > > Signed-off-by: Eric Engestrom
> > > ---
> > > meson.b
Hi Brian,
On Monday, 29 January 2018 19:24:15 CET Brian Paul wrote:
> On 01/27/2018 08:01 AM, Mathias Fröhlich wrote:
> > Hi Brian,
> >
> > The change should not change the current behavior.
> > Nevertheless the current behavior as well as past your change the code has
a
> > corner case that wil
https://bugs.freedesktop.org/show_bug.cgi?id=104863
Brian Paul changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Am Dienstag, den 30.01.2018, 10:14 -0700 schrieb Brian Paul:
> On 01/30/2018 09:59 AM, Mark Janes wrote:
> > This series that was just pushed to master generates ~200
> > assertions on
> > all platforms, eg:
> >
> > piglit.spec.ext_framebuffer_multisample.formats 2
> >
> > ext_framebuffer_multisa
Am Dienstag, den 30.01.2018, 08:26 -0700 schrieb Brian Paul:
> On 01/30/2018 01:38 AM, Gert Wollny wrote:
> > Am Montag, den 29.01.2018, 13:42 -0700 schrieb Brian Paul:
> > > Slightly better readbility.
> > > ---
> > > src/mesa/main/arrayobj.c | 2 +-
> > > src/mesa/main/varray.c | 12 ++-
On January 30, 2018 5:34:07 PM UTC, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-01-29 10:15:50)
> > The big comment is taken from the equivalent block in configure.ac
> >
> > Signed-off-by: Eric Engestrom
> > ---
> > meson.build | 30
> +++
On 01/30/2018 10:35 AM, Roland Scheidegger wrote:
Should the meta module not do this?
The meta module is OK. It's using this function to enable vertex
position, for example.
In any case,
Reviewed-by: Roland Scheidegger
Thanks!
-Brian
Am 30.01.2018 um 18:14 schrieb Brian Paul:
The
Should the meta module not do this?
In any case,
Reviewed-by: Roland Scheidegger
Am 30.01.2018 um 18:14 schrieb Brian Paul:
> The meta module passes some 0-based attrib values. Should fix Piglit
> regressions reported by Mark Janes.
>
> Bugzilla:
> https://urldefense.proofpoint.com/v2/url?u=ht
Quoting Marc Dietrich (2018-01-27 06:36:51)
> Hi Dylan,
>
> Am Donnerstag, 25. Januar 2018, 20:32:23 CET schrieb Dylan Baker:
> > Currently meson implements the same logic as SCons for translations,
> > namely it doesn't do them. This patch changes meson to use logic more
> > like autotools, and g
Quoting Jon Turney (2018-01-28 06:24:07)
> This also requires my "fix osx" series to actually build
>
> Dylan Baker (2):
> meson: find python2 on macOS
> meson: set apple glx defines
>
> Jon Turney (4):
> meson: build src/glx/apple
> meson: osx doesn't have librt, so don't require it
>
Quoting Jon Turney (2018-01-28 06:24:10)
> ---
> src/glx/apple/meson.build | 62
> +++
> src/glx/meson.build | 4 +++
> 2 files changed, 66 insertions(+)
> create mode 100644 src/glx/apple/meson.build
>
> diff --git a/src/glx/apple/meson.build
Quoting Jon Turney (2018-01-28 06:24:11)
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7e194a9f10d..8fdbaa8b8d8 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -935,7 +935,7 @@ elif with_dri_i965 and get_option('
Quoting Eric Engestrom (2018-01-29 10:15:50)
> The big comment is taken from the equivalent block in configure.ac
>
> Signed-off-by: Eric Engestrom
> ---
> meson.build | 30
> +
> src/gallium/targets/d3dadapter9/meson.build | 2 +-
>
Hi Brian,
On Monday, 29 January 2018 17:05:57 CET Brian Paul wrote:
> The series looks good tome.
>
> Reviewed-by: Brian Paul
Thanks for the review!
> Can you push this or do you need me to do it?
And Thanks for pushing.
I used to have a git account and I assume it is still working.
So the nex
https://bugs.freedesktop.org/show_bug.cgi?id=104863
--- Comment #2 from Brian Paul ---
Patch posted to mesa-dev. Please review and I'll push it.
--
You are receiving this mail because:
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa
https://bugs.freedesktop.org/show_bug.cgi?id=104863
--- Comment #1 from Mark Janes ---
4ab7e03e1fc7ac6c7cd3a5a1c160726f2a262e66 is the first bad commit
commit 4ab7e03e1fc7ac6c7cd3a5a1c160726f2a262e66
Author: Brian Paul
Date: Fri Jan 26 11:03:57 2018 -0700
mesa: add an assertion in _mesa_en
The meta module passes some 0-based attrib values. Should fix Piglit
regressions reported by Mark Janes.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104863
---
src/mesa/main/varray.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
ind
On 01/30/2018 09:59 AM, Mark Janes wrote:
This series that was just pushed to master generates ~200 assertions on
all platforms, eg:
piglit.spec.ext_framebuffer_multisample.formats 2
ext_framebuffer_multisample-formats: ../src/mesa/main/varray.c:1068:
_mesa_enable_vertex_array_attrib: Assertion
https://bugs.freedesktop.org/show_bug.cgi?id=104863
Bug ID: 104863
Summary: 186 assertions in piglit
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Keywords: regression
Severity:
This series that was just pushed to master generates ~200 assertions on
all platforms, eg:
piglit.spec.ext_framebuffer_multisample.formats 2
ext_framebuffer_multisample-formats: ../src/mesa/main/varray.c:1068:
_mesa_enable_vertex_array_attrib: Assertion `attrib >=
VERT_ATTRIB_GENERIC0' failed.
S
Series is:
Reviewed-by: Nicolai Hähnle
On 27.01.2018 19:01, Marek Olšák wrote:
From: Marek Olšák
it's useless and shader-db stats only report the main shader part.
---
src/gallium/drivers/radeon/r600_pipe_common.h | 1 -
src/gallium/drivers/radeonsi/si_pipe.c | 1 -
src/gal
On Mon, Nov 27, 2017 at 08:41:42PM +0200, Pohjolainen, Topi wrote:
> On Mon, Nov 27, 2017 at 11:40:49AM -0800, Matt Turner wrote:
> > On 11/24, Topi Pohjolainen wrote:
> > > ---
> > > src/compiler/glsl/ir_print_visitor.cpp | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/src/com
From: Marek Olšák
This only affects drivers that set DriverFlags.NewBlend.
---
src/mesa/main/blend.c | 6 --
src/mesa/main/blend.h | 41 +++
src/mesa/main/enable.c| 14 +
src/mesa/program/prog_statevars.c |
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.h | 4
src/gallium/drivers/radeon/r600_texture.c | 20 +---
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h
b/src/gallium/drivers/radeon/r60
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_texture.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeon/r600_texture.c
index a0e9129..125e7ef 100644
--- a/src/gallium/drivers/radeon/r600_text
From: Marek Olšák
I'm not fully convinced that the hw can do it with MSAA.
Maybe without CMASK, FMASK, and with sample shading, i.e. the slowest
possible way.
---
docs/features.txt | 2 +-
docs/relnotes/18.1.0.html | 2 +-
src/gallium/dri
1 - 100 of 126 matches
Mail list logo
