[Mesa-dev] [Bug 102516] regression on glsl shaders on BE architecture mesa-17.2.0-rc6

2017-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102516 intermedi...@hotmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 102516] regression on glsl shaders on BE architecture mesa-17.2.0-rc6

2017-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102516 --- Comment #5 from intermedi...@hotmail.com --- Hi Emil and Aero, the issue is fixed i had been tested with last mesa git. but new one come if i build with radeonsi, amdgpu and with an ld error. i will open a new bug report. thanks Luigi --

Re: [Mesa-dev] [PATCH 1/2] configure:enabling va for surfaceless platform

2017-10-09 Thread Christian König
Am 10.10.2017 um 08:20 schrieb sguttula: This patch will fix some failures on surfaceless platforms when we enable va. Cc: mesa-sta...@lists.freedesktop.org Cc: Emil Velikov Cc: Christian König Cc: Deepak Sharma Signed-off-by: sguttula Reviewed-by: Deepak Sharma I would reorder the patch,

Re: [Mesa-dev] [PATCH] i965/tes: account for the fact that dvec3/4 inputs take two slots

2017-10-09 Thread Kenneth Graunke
On Monday, October 9, 2017 11:51:24 PM PDT Iago Toral Quiroga wrote: > When computing the total size of the URB for tessellation evaluation > inputs we were not accounting for this, and instead we were always > assuming that each input would take a single vec4 slot, which could > lead to computing

[Mesa-dev] [PATCH] i965/tes: account for the fact that dvec3/4 inputs take two slots

2017-10-09 Thread Iago Toral Quiroga
When computing the total size of the URB for tessellation evaluation inputs we were not accounting for this, and instead we were always assuming that each input would take a single vec4 slot, which could lead to computing a smaller read size than required. Specifically, this is a problem when the l

Re: [Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

2017-10-09 Thread Timothy Arceri
On 10/10/17 09:31, Timothy Arceri wrote: On 10/10/17 09:06, Eric Anholt wrote: Timothy Arceri writes: This is intended to be called before nir_lower_io() so that we can do some linking optimisations with the results. It can also be used with drivers that don't use nir_lower_io() at all such

Re: [Mesa-dev] [PATCH v2 0/5] i965: add support for loadable OA configs

2017-10-09 Thread Kenneth Graunke
On Tuesday, August 29, 2017 6:05:00 AM PDT Lionel Landwerlin wrote: > Hi again, > > Improvement on detection of loadable configs as suggested by Chris. > Change is in patch 4. Patches 1-3 are: Reviewed-by: Kenneth Graunke I'm still not sure about this whole loadable configs thing... signature

Re: [Mesa-dev] [PATCH 2/2] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Jason Ekstrand
On Mon, Oct 9, 2017 at 7:29 PM, Brian Paul wrote: > v2: use !! in the function to be explicit about type conversion. Though, > gcc generates the same code with or without the logical !!. > --- > src/mesa/main/imports.h | 6 -- > src/util/half_float.h | 8 > 2 files changed, 8 ins

[Mesa-dev] [PATCH 2/2] radeonsi: lower ffma in nir to mad.

2017-10-09 Thread Dave Airlie
From: Dave Airlie This lowers ffma to a * b + c. This seems like it should keep Marek happiest, so we'd never get to the fma instruction emission code. Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 1/2] radv: lower ffma in nir.

2017-10-09 Thread Dave Airlie
From: Dave Airlie So it appears the Vulkan SPIR-V fma opcode can be equivalent to a mad operation, and the fma hw opcode on AMD hw is issued like a double opcode so is slower. Also the radeonsi stack does this. This appears to improve performance on a number of games from Feral, and thanks to Fe

[Mesa-dev] [RFC 1/3] mesa: Add new fast mtx_t mutex type for basic use cases

2017-10-09 Thread Timothy Arceri
While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features of pthread mutexes. Most mutexes in mesa only needs lock/unlock, and the idea here is that we can inline the atomic operation and make the fast case just two intruction

[Mesa-dev] Testing out Kristian's fast mtx patch

2017-10-09 Thread Timothy Arceri
After a recent discussion about this code from 2015 I was curious to give it a try. The outstanding review item was that we shouldn't be replacing the C11 mtx type/functions with our own, so I've renamed the fast path to simple_mtx* and added a couple of patches to make use of it. The idea is this

[Mesa-dev] [RFC 3/3] amdgpu: use simple mtx

2017-10-09 Thread Timothy Arceri
--- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 34 +-- src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 2 +- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 20 src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 28 +++--- src/gallium/win

[Mesa-dev] [RFC 2/3] mesa: use simple mtx in core mesa

2017-10-09 Thread Timothy Arceri
--- src/gallium/state_trackers/dri/dri2.c | 22 +++--- src/mesa/main/bufferobj.c | 14 +++--- src/mesa/main/debug_output.c | 16 src/mesa/main/errors.c| 4 ++-- src/mesa/main/fbobject.c | 14 +++---

[Mesa-dev] [PATCH 2/2] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Brian Paul
v2: use !! in the function to be explicit about type conversion. Though, gcc generates the same code with or without the logical !!. --- src/mesa/main/imports.h | 6 -- src/util/half_float.h | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/imports.h

[Mesa-dev] [PATCH 1/2] mesa: move _mesa_exec_malloc/free() prototypes to their own header

2017-10-09 Thread Brian Paul
Try to start removing things from the cluttered imports.h file. v2: add new header to Makefile.sources --- src/mesa/Makefile.sources | 1 + src/mesa/main/execmem.c | 1 + src/mesa/main/execmem.h | 37 + src/mesa/main/imports.h | 7 --- src/

[Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-09 Thread Brian Paul
If one uses a parent build script to download/build Mesa we may not have a full git repository (maybe a tar archive) so the 'git rev-parse' command will fail. This updates the script to look for a MESA_GIT_SHA1_OVERRIDE env var. If it's set, use that sha1 instead of using git rev-parse. With this

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-09 Thread Marek Olšák
Hi Nicolai, Is there any difference with piglit/drawoverhead? If yes, would this be useful? https://patchwork.freedesktop.org/patch/41241/ Marek On Fri, Oct 6, 2017 at 10:38 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > r600 expects the context that created the sampler view to still

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-09 Thread Andres Rodriguez
On 2017-10-05 11:29 AM, Nicolai Hähnle wrote: On 04.10.2017 23:02, Rob Clark wrote: On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: Am 04.10.2017 um 17:44 schrieb Rob Clark: Signed-off-by: Rob Clark ---   src/gallium/drivers/etnaviv/etnaviv_screen.c    |  1 +   src/gallium/dr

Re: [Mesa-dev] [Mesa-stable] [PATCH] spirv: Fix SpvOpAtomicISub

2017-10-09 Thread Ian Romanick
D'oh... and it was already handled in fill_common_atomic_sources. Reviewed-by: Ian Romanick On 10/09/2017 01:33 PM, Józef Kucia wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/spirv/spirv_to_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/spirv/s

Re: [Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-09 Thread Dylan Baker
Quoting Brian Paul (2017-10-09 13:56:33) > If one uses a parent build script to download/build Mesa we may not > have a full git repository (maybe a tar archive) so the 'git rev-parse' > command will fail. > > This updates the script to look for a MESA_GIT_SHA1_OVERRIDE env var. > If it's set, use

Re: [Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-09 Thread Jose Fonseca
On 09/10/17 21:56, Brian Paul wrote: If one uses a parent build script to download/build Mesa we may not have a full git repository (maybe a tar archive) so the 'git rev-parse' command will fail. This updates the script to look for a MESA_GIT_SHA1_OVERRIDE env var. If it's set, use that sha1 ins

Re: [Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

2017-10-09 Thread Jason Ekstrand
I just pushed this and the SPIR-V patch. Thanks! On Mon, Oct 9, 2017 at 2:13 PM, Nanley Chery wrote: > On Mon, Oct 09, 2017 at 10:42:06PM +0200, Józef Kucia wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > This patch is >

Re: [Mesa-dev] [PATCH 1/3] mesa: move _mesa_exec_malloc/free() prototypes to their own header

2017-10-09 Thread Roland Scheidegger
Am 09.10.2017 um 22:56 schrieb Brian Paul: > Try to start removing things from the cluttered imports.h file. > --- > src/mesa/main/execmem.c | 1 + > src/mesa/main/execmem.h | 37 + > src/mesa/main/imports.h | 7 --- > src/mesa/tnl/t_vertex.c

Re: [Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Roland Scheidegger
Am 09.10.2017 um 23:33 schrieb Brian Paul: > On 10/09/2017 03:24 PM, Ilia Mirkin wrote: >> On Mon, Oct 9, 2017 at 5:07 PM, Roland Scheidegger >> wrote: >>> Am 09.10.2017 um 22:56 schrieb Brian Paul: ---   src/mesa/main/imports.h | 6 --   src/util/half_float.h   | 8

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

2017-10-09 Thread Timothy Arceri
On 10/10/17 10:02, Eric Anholt wrote: Timothy Arceri writes: On 10/10/17 09:31, Eric Anholt wrote: Timothy Arceri writes: We won't split varyings marked as always active because there is no point in doing so. This means we need to mark both sides of the interface as always active otherwise

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > On 10/10/17 09:31, Eric Anholt wrote: >> Timothy Arceri writes: >> >>> We won't split varyings marked as always active because there >>> is no point in doing so. This means we need to mark both >>> sides of the interface as always active otherwise we will have >>> a mis

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

2017-10-09 Thread Timothy Arceri
On 10/10/17 09:31, Eric Anholt wrote: Timothy Arceri writes: We won't split varyings marked as always active because there is no point in doing so. This means we need to mark both sides of the interface as always active otherwise we will have a mismatch and start removing things we shouldn't.

Re: [Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

2017-10-09 Thread Timothy Arceri
On 10/10/17 09:06, Eric Anholt wrote: Timothy Arceri writes: This is intended to be called before nir_lower_io() so that we can do some linking optimisations with the results. It can also be used with drivers that don't use nir_lower_io() at all such as RADV. +static void +lower_load_to_sca

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > We won't split varyings marked as always active because there > is no point in doing so. This means we need to mark both > sides of the interface as always active otherwise we will have > a mismatch and start removing things we shouldn't. Is this just needed because the

Re: [Mesa-dev] [PATCH 5/6] nir: add component level support to remove_unused_io_vars()

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > --- > src/compiler/nir/nir_linking_helpers.c | 37 > +++--- > 1 file changed, 21 insertions(+), 16 deletions(-) > > diff --git a/src/compiler/nir/nir_linking_helpers.c > b/src/compiler/nir/nir_linking_helpers.c > index 838054e42a4..28141a6ec

Re: [Mesa-dev] [PATCH 1/6] nir: add glsl_type_is_64bit() to nir_types

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > From: Timothy Arceri Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/6] nir: add glsl_channel_type() helper

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > --- > src/compiler/nir_types.cpp | 29 + > src/compiler/nir_types.h | 2 ++ > 2 files changed, 31 insertions(+) > > diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp > index b0d84aae384..44c4b5d60cf 100644 > --- a/src/com

Re: [Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

2017-10-09 Thread Eric Anholt
Timothy Arceri writes: > This is intended to be called before nir_lower_io() so that we > can do some linking optimisations with the results. It can also > be used with drivers that don't use nir_lower_io() at all such > as RADV. > +static void > +lower_load_to_scalar_early(nir_builder *b, nir_i

Re: [Mesa-dev] [PATCH v2 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-10-09 Thread Timothy Arceri
On 10/10/17 01:26, Nicolai Hähnle wrote: On 21.09.2017 12:55, Timothy Arceri wrote: The old code assumed that loop terminators will always be at the start of the loop, resulting in otherwise unrollable loops not being unrolled at all. For example the current code would unroll:    int j = 0;  

Re: [Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Brian Paul
On 10/09/2017 03:24 PM, Ilia Mirkin wrote: On Mon, Oct 9, 2017 at 5:07 PM, Roland Scheidegger wrote: Am 09.10.2017 um 22:56 schrieb Brian Paul: --- src/mesa/main/imports.h | 6 -- src/util/half_float.h | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/m

Re: [Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Brian Paul
On 10/09/2017 03:07 PM, Roland Scheidegger wrote: Am 09.10.2017 um 22:56 schrieb Brian Paul: --- src/mesa/main/imports.h | 6 -- src/util/half_float.h | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index a4

Re: [Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Ilia Mirkin
On Mon, Oct 9, 2017 at 5:07 PM, Roland Scheidegger wrote: > Am 09.10.2017 um 22:56 schrieb Brian Paul: >> --- >> src/mesa/main/imports.h | 6 -- >> src/util/half_float.h | 8 >> 2 files changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/src/mesa/main/imports.h b/src/mesa/m

Re: [Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Roland Scheidegger
Am 09.10.2017 um 22:56 schrieb Brian Paul: > --- > src/mesa/main/imports.h | 6 -- > src/util/half_float.h | 8 > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h > index a4964a3..51fa72c 100644 > --- a/src/mesa/mai

Re: [Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

2017-10-09 Thread Nanley Chery
On Mon, Oct 09, 2017 at 10:42:06PM +0200, Józef Kucia wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 2/3] mesa: move _mesa_half_is_negative() to half_float.h

2017-10-09 Thread Brian Paul
--- src/mesa/main/imports.h | 6 -- src/util/half_float.h | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index a4964a3..51fa72c 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -333,12 +333,6

[Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-09 Thread Brian Paul
If one uses a parent build script to download/build Mesa we may not have a full git repository (maybe a tar archive) so the 'git rev-parse' command will fail. This updates the script to look for a MESA_GIT_SHA1_OVERRIDE env var. If it's set, use that sha1 instead of using git rev-parse. With this

[Mesa-dev] [PATCH 1/3] mesa: move _mesa_exec_malloc/free() prototypes to their own header

2017-10-09 Thread Brian Paul
Try to start removing things from the cluttered imports.h file. --- src/mesa/main/execmem.c | 1 + src/mesa/main/execmem.h | 37 + src/mesa/main/imports.h | 7 --- src/mesa/tnl/t_vertex.c | 1 + src/mesa/x86/rtasm/x86sse.c | 1 + 5 files

Re: [Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

2017-10-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 9, 2017 at 1:42 PM, Józef Kucia wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index 93d360a1bb..434

[Mesa-dev] [PATCH 2/2] st/va: Return correct width and height for encode/decode support

2017-10-09 Thread Mark Thompson
Previously this would return the largest possible buffer size, which is much larger than the codecs themselves support. This caused confusion when client applications attempted to decode 8K video thinking it was supported when it isn't. Signed-off-by: Mark Thompson --- Before this change, when g

[Mesa-dev] [PATCH 1/2] st/va: Fix config entrypoint handling

2017-10-09 Thread Mark Thompson
Consistently use it as a PIPE_VIDEO_ENTRYPOINT. Signed-off-by: Mark Thompson --- src/gallium/state_trackers/va/config.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/va/config.c b/src/gallium/state_trackers/va/config.c index 1484f

[Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

2017-10-09 Thread Józef Kucia
--- src/intel/vulkan/genX_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 93d360a1bb..43437c8eb0 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.

Re: [Mesa-dev] [PATCH] spirv: Fix SpvOpAtomicISub

2017-10-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 9, 2017 at 1:33 PM, Józef Kucia wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/spirv/spirv_to_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c > in

[Mesa-dev] [PATCH] spirv: Fix SpvOpAtomicISub

2017-10-09 Thread Józef Kucia
Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 8fe379e4e0..079ff0fe95 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spir

[Mesa-dev] [PATCH 1/2] r600: drop tc_L2_dirty bit, this was SI only.

2017-10-09 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_buffer_common.c | 2 -- src/gallium/drivers/r600/r600_pipe_common.h | 12 src/gallium/drivers/r600/r600_query.c | 1 - 3 files changed, 15 deletions(-) diff --git a/src/gallium/drivers/r600/

[Mesa-dev] [PATCH 2/2] r600: cleanup llvm ir target selection.

2017-10-09 Thread Dave Airlie
From: Dave Airlie Only r600 target used now for compute IR. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe_common.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe_common.c b/src/gallium/drivers/r6

Re: [Mesa-dev] [PATCH 5/5] mesa: Implement a new GL_MESA_tile_raster_order extension.

2017-10-09 Thread Eric Anholt
Nicolai Hähnle writes: > Patches 1 & 2: > > Acked-by: Nicolai Hähnle > > Patches 4 & 5: > > Reviewed-by: Nicolai Hähnle > (for the gallium parts; it would have been nice to split patch 4 up into > gallium and driver parts, but I won't insist) Thanks! I've pinged on the registry PR, so hopefu

Re: [Mesa-dev] [PATCH 1/6] mesa: Add X1B5G5R5 along with A1B5G5R5.

2017-10-09 Thread Eric Anholt
Nicolai Hähnle writes: > On 17.08.2017 18:10, Eric Anholt wrote: >> For supporting RGB5 in hardware with A in the low bit (vc4), we need this >> format as well. >> --- >> src/mesa/main/formats.c | 2 ++ >> src/mesa/main/formats.csv| 1 + >> src/mesa/main/formats.h | 1 + >> src

Re: [Mesa-dev] [PATCH] editorconfig: Add meson configuration

2017-10-09 Thread Eric Anholt
Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > .editorconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/.editorconfig b/.editorconfig > index 6eb0702a25a..06848f68c08 100644 > --- a/.editorconfig > +++ b/.editorconfig > @@ -33,3 +33,7 @@ indent_size = 2 > > [*.pat

Re: [Mesa-dev] [PATCH 6/6] st/dri: implement createImageFromRenderbuffer(2)

2017-10-09 Thread Eric Anholt
Nicolai Hähnle writes: > From: Nicolai Hähnle > > Tested with dEQP-EGL tests. The image struct setup and error list all appear to be complete. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lis

Re: [Mesa-dev] [PATCH v4] meson: build glx

2017-10-09 Thread Eric Anholt
Dylan Baker writes: > This gets GLX and the loader building. The resulting GLX and i965 have > been tested on piglit and seem to work fine. This patch leaves a lot of > todo's in it's wake, GLX is quite complicated, and the build options > involved are many, and the goal at the moment is to get d

[Mesa-dev] [PATCH v4] meson: build glx

2017-10-09 Thread Dylan Baker
This gets GLX and the loader building. The resulting GLX and i965 have been tested on piglit and seem to work fine. This patch leaves a lot of todo's in it's wake, GLX is quite complicated, and the build options involved are many, and the goal at the moment is to get dri and gallium drivers buildin

Re: [Mesa-dev] [PATCH v3 07/12] meson: build glx

2017-10-09 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > I looked at what autotools generates in it's make files and output and matches > that with what meson is generating now. Does this look good to you? It's the > last patch waiting for review in the series. Yeah, looks good to me (other than pkg

Re: [Mesa-dev] [PATCH 04/14] intel: Add simple logging façade for Android

2017-10-09 Thread Dylan Baker
Quoting Chad Versace (2017-09-27 17:11:50) > I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). > > On Android, stdio goes to /dev/null. On Android, remote gdb is even more > painful than the usual remote gdb. On Android, nothing works like you > expect and debugging is hell. I

Re: [Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Jason Ekstrand
This patch is technically correct (the best kind of correct!) but I'm not sure I like it. width/height and x/y will always come in pairs. This makes the code messier just to get rid of a coverity warning that can easily be verified to never be an issue (by just looking at all 3 callers). --Jason

[Mesa-dev] [PATCH 4/4] st/dri: implement __DRIimageExtension::validateUsage properly

2017-10-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 8672174..e972528 100644 --- a/src/gallium/state_tra

[Mesa-dev] [PATCH 3/4] gallium: add pipe_screen::check_resource_capability

2017-10-09 Thread Marek Olšák
From: Marek Olšák This is optional (and no CAP). Implemented by radeonsi, ddebug, rbug, trace. --- src/gallium/drivers/ddebug/dd_screen.c| 11 +++ src/gallium/drivers/radeon/r600_texture.c | 21 + src/gallium/drivers/rbug/rbug_screen.c| 14 ++ src

[Mesa-dev] [PATCH 2/4] ac/surface: add ac_surface::is_displayable

2017-10-09 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_surface.c | 10 ++ src/amd/common/ac_surface.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 22c653f..821ad56 100644 --- a/src/amd/common/ac_surface.c +++ b/src/amd/common/a

[Mesa-dev] [PATCH 0/4] Gallium+RadeonSI: implement __DRIimageExtension::validateUsage properly

2017-10-09 Thread Marek Olšák
Hi, This implements __DRIimageExtension::validateUsage properly. It also modifies Addrlib and adds a new pipe_screen function. Please review! Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/

[Mesa-dev] [PATCH 1/4] amd/addrlib: add Addr2IsValidDisplaySwizzleMode

2017-10-09 Thread Marek Olšák
From: Marek Olšák Some "standard" (_S) swizzle modes are displayable on Raven, even though the micro tile mode says it's not displayable. Expose the addrlib function to the driver. --- src/amd/addrlib/addrinterface.cpp | 34 ++ src/amd/addrlib/addrinterface.h

Re: [Mesa-dev] [PATCH 03/14] intel: Move definition of LOG_TAG from header into Makefiles

2017-10-09 Thread Rob Herring
On Mon, Oct 9, 2017 at 11:17 AM, Chad Versace wrote: > On Mon 09 Oct 2017, Tapani Pälli wrote: >> >> >> On 09/28/2017 03:11 AM, Chad Versace wrote: >> > This patch prevents compilation failures in upcoming Android Vulkan >> > patches, failures due to redefinition of LOG_TAG in Android system >> >

Re: [Mesa-dev] [PATCH 03/14] intel: Move definition of LOG_TAG from header into Makefiles

2017-10-09 Thread Chad Versace
On Mon 09 Oct 2017, Tapani Pälli wrote: > > > On 09/28/2017 03:11 AM, Chad Versace wrote: > > This patch prevents compilation failures in upcoming Android Vulkan > > patches, failures due to redefinition of LOG_TAG in Android system > > headers. > > > > This patch does not change the value of LO

Re: [Mesa-dev] [PATCH] anv: Implement VK_ANDROID_native_buffer (v5)

2017-10-09 Thread Chad Versace
On Mon 25 Sep 2017, Tapani Pälli wrote: > > > On 09/22/2017 03:09 AM, Chad Versace wrote: > > On Thu 21 Sep 2017, Tapani Pälli wrote: > > > Hi Chad; > > > > > > The build works ok now on Android-IA. There is still something wrong with > > > 'exec async' though. It behaves differently with small/

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-09 Thread Daniel Stone
Hi, On 9 October 2017 at 16:29, Marek Olšák wrote: > On Mon, Oct 9, 2017 at 5:22 PM, Daniel Stone wrote: >> Which is exactly the problem validateUsage() is supposed to solve. All >> we can do is rely on gbm_bo_import failing (which is best, as it can >> never be used for scanout), or at least th

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-09 Thread Marek Olšák
On Mon, Oct 9, 2017 at 5:22 PM, Daniel Stone wrote: > Hi Marek, > > On 4 October 2017 at 12:38, Marek Olšák wrote: >> Yeah I don't have an answer to that. I think it's better to pageflip than >> blit. Can Wayland reallocate the buffer to make it displayable? If not, it >> may be better to create

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-09 Thread Daniel Stone
Hi Marek, On 4 October 2017 at 12:38, Marek Olšák wrote: > Yeah I don't have an answer to that. I think it's better to pageflip than > blit. Can Wayland reallocate the buffer to make it displayable? If not, it > may be better to create displayable buffers always. Not sure what you mean by 'Wayla

Re: [Mesa-dev] [PATCH 5/6] st_api: remove unused get_resource_for_egl_image

2017-10-09 Thread Eric Engestrom
On Friday, 2017-10-06 20:16:07 +, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/include/state_tracker/st_api.h | 37 > -- > 1 file changed, 37 deletions(-) > > diff --git a/src/gallium/include/state_tracker/st_api.h > b/src/gallium/include/

Re: [Mesa-dev] [PATCH 6/6] mesa/st/tests: Add tests for liefetime tracking with indirect addressing

2017-10-09 Thread Nicolai Hähnle
Looks mostly good, but the duplication of the MockCodelines starts to be a bit tedious. Perhaps you could unify the MockCodeline structs and simply provide different constructors for with/without swizzles and relative addresses? I'd suggest to first merge MockCodeline and MockCodelineWithSwizz

Re: [Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Antia Puentes
Reviewed-by: Antia Puentes On 09/10/17 16:37, Lionel Landwerlin wrote: CID: 1418616, 1418607 Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_blit.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blor

Re: [Mesa-dev] [PATCH 5/6] mesa/st/glsl_to_tgsi: Add tracking of indirect addressing registers

2017-10-09 Thread Nicolai Hähnle
Patches 1 & 5: Reviewed-by: Nicolai Hähnle On 04.10.2017 11:45, Gert Wollny wrote: So far indirect addressing was not tracked to estimate the temporary life time, and it was not needed, because code to load the address registers was always emitted eliminating the reladdr* handles in the past

Re: [Mesa-dev] [PATCH] i965: Set 3DSTATE_VERTEX_BUFFER::Null Vertex Buffer.

2017-10-09 Thread Jason Ekstrand
Seems reasonable to me. I would say we should set it in Vulkan too except that the only way you can get a buffer size of 0 is invalid usage so meh. Reviewed-by: Jason Ekstrand On Sun, Oct 8, 2017 at 7:47 PM, Kenneth Graunke wrote: > According to the Broadwell VERTEX_BUFFER_STATE documentation

Re: [Mesa-dev] [PATCH 2/2] i965: silence coverity warning

2017-10-09 Thread Antia Puentes
Reviewed-by: Antia Puentes On 09/10/17 16:37, Lionel Landwerlin wrote: Also makes this statement a bit clearer. CID: 1418920 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 2/2] i965: silence coverity warning

2017-10-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 9, 2017 at 7:37 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Also makes this statement a bit clearer. > > CID: 1418920 > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_draw.c | 2 +- > 1 file changed, 1 insertio

Re: [Mesa-dev] [PATCH 3/6] mesa/st/glsl_to_tgsi: Add tracking of ifelse writes in register merging

2017-10-09 Thread Nicolai Hähnle
On 04.10.2017 11:45, Gert Wollny wrote: + int write_unconditional_in_loop_id; + unsigned int if_write_flags; + int next_ifelse_nesting_depth; > + + bool else_write; I kind of hoped you learned the lesson from last time that you really need to document your data for algorithms like this

Re: [Mesa-dev] [PATCH 2/6] mesa/st/glsl_to_tgsi: Correct debug output for indirect access

2017-10-09 Thread Nicolai Hähnle
On 04.10.2017 11:45, Gert Wollny wrote: For arrays print the array ID, and with indirect access also print the reladdr* registers. The reladdr* registers are always used in the printout, even though the actual code may use an address register. Specifically, a sequence involving src.reladdr = TEM

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

2017-10-09 Thread Marek Olšák
On Fri, Oct 6, 2017 at 1:24 AM, Roland Scheidegger wrote: > Am 06.10.2017 um 00:34 schrieb Marek Olšák: >> On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote: >>> On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote: On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote: > Like Roland, I don't

[Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Lionel Landwerlin
CID: 1418616, 1418607 Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_blit.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 11c2116a758..84e46d7d31b 100644 --- a/src/intel/blorp/blo

[Mesa-dev] [PATCH 2/2] i965: silence coverity warning

2017-10-09 Thread Lionel Landwerlin
Also makes this statement a bit clearer. CID: 1418920 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index c7ed7284501..7ebe

Re: [Mesa-dev] [PATCH 5/7] radeonsi: import cayman_msaa.c from drivers/radeon

2017-10-09 Thread Nicolai Hähnle
On 09.10.2017 16:26, Marek Olšák wrote: On Mon, Oct 9, 2017 at 3:26 PM, Nicolai Hähnle wrote: On 08.10.2017 00:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.sources | 1 - src/gallium/drivers/radeon/cayman_msaa.c | 269 ---

Re: [Mesa-dev] [PATCH 4/3] glsl: tidy up IR after loop unrolling

2017-10-09 Thread Nicolai Hähnle
On 22.09.2017 01:49, Timothy Arceri wrote: c7affbf6875622a enabled GLSLOptimizeConservatively on some drivers. The idea was to speed up compile times by running the GLSL IR passes only once each time do_common_optimization() is called. However loop unrolling can create a big mess and with large l

Re: [Mesa-dev] [PATCH 5/7] radeonsi: import cayman_msaa.c from drivers/radeon

2017-10-09 Thread Marek Olšák
On Mon, Oct 9, 2017 at 3:26 PM, Nicolai Hähnle wrote: > On 08.10.2017 00:47, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/Makefile.sources | 1 - >> src/gallium/drivers/radeon/cayman_msaa.c | 269 >> -- >> src/gallium/driv

Re: [Mesa-dev] [PATCH v2 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-10-09 Thread Nicolai Hähnle
On 21.09.2017 12:55, Timothy Arceri wrote: The old code assumed that loop terminators will always be at the start of the loop, resulting in otherwise unrollable loops not being unrolled at all. For example the current code would unroll: int j = 0; do { if (j > 5) break;

Re: [Mesa-dev] [PATCH] anv: fix null pointer dereference

2017-10-09 Thread Jason Ekstrand
Rb On October 9, 2017 3:20:55 AM Lionel Landwerlin wrote: Reviewed-by: Lionel Landwerlin On 09/10/17 06:19, Tapani Pälli wrote: CID: 1419033 Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-09 Thread Nicolai Hähnle
At least for async compute, this is gated by HQD_PQ_CONTROL.UNORD_DISPATCH, which the kernel doesn't set. Presumably because it can increase scheduling latency between queues. I don't know if it applies to compute shaders launched via the graphics queue. In any case, turning the bit on from the

Re: [Mesa-dev] [PATCH v2 2/2] main/format: skip format conversion if src and dst format are equal

2017-10-09 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 07.10.2017 22:42, Kenneth Graunke wrote: From: Karol Herbst Fixes 'KHR-GL45.copy_image.functional' on Nouveau and i965. v2: (by Kenneth Graunke) Rewrite patch according to Jason Ekstrand's review feedback. This makes it handle differing

Re: [Mesa-dev] [PATCH 7/7] amd: move r600d_common.h into r600g

2017-10-09 Thread Nicolai Hähnle
I've sent a comment on patch #5. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 08.10.2017 00:47, Marek Olšák wrote: From: Marek Olšák --- src/amd/Makefile.sources | 1 - src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/

Re: [Mesa-dev] [PATCH 5/7] radeonsi: import cayman_msaa.c from drivers/radeon

2017-10-09 Thread Nicolai Hähnle
On 08.10.2017 00:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.sources | 1 - src/gallium/drivers/radeon/cayman_msaa.c | 269 -- src/gallium/drivers/radeon/r600_pipe_common.c | 1 - src/gallium/drivers/radeon/r600_pipe_c

Re: [Mesa-dev] [PATCH] radeonsi: add performance thresholds for CP DMA, decrease it for clears

2017-10-09 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 07.10.2017 20:56, Marek Olšák wrote: From: Marek Olšák The first one isn't used yet. --- src/gallium/drivers/radeonsi/si_cp_dma.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/galliu

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive binning on Vega10 (v2)

2017-10-09 Thread Nicolai Hähnle
On 07.10.2017 18:20, Marek Olšák wrote: On Sat, Oct 7, 2017 at 6:19 PM, Marek Olšák wrote: From: Marek Olšák Our driver implementation is known to decrease performance for some tests, but we don't know if any apps and benchmarks (e.g. those tested by Phoronix) are affected. This disables the

Re: [Mesa-dev] [PATCH] r600: drop a bunch of post-cayman code.

2017-10-09 Thread Marek Olšák
Acked-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] radv: unused variable ‘total_count’

2017-10-09 Thread Samuel Pitoiset
Yeah, we should add MAYBE_UNUSED to avoid compiler warnings. Not a big deal though. On 10/09/2017 02:12 PM, Dieter Nützel wrote: Hello, not that I have any app which need Vulkan currently (hint, hint any game for 'testing'), but...   CC   radv_meta_blit.lo radv_cmd_buffer.c: In functio

[Mesa-dev] radv: unused variable ‘total_count’

2017-10-09 Thread Dieter Nützel
Hello, not that I have any app which need Vulkan currently (hint, hint any game for 'testing'), but... CC radv_meta_blit.lo radv_cmd_buffer.c: In function ‘radv_CmdSetViewport’: radv_cmd_buffer.c:2496:17: warning: unused variable ‘total_count’ [-Wunused-variable] const uint32_t tot

Re: [Mesa-dev] [PATCH 0/6] Prehash all the things

2017-10-09 Thread Dieter Nützel
Hello Thomas, now, that you have write commit 'only' this one is missing. Maybe you have time for this. Latest version do not apply any longer. Wende an: util: Avoid computing hash twice in string_to_uint_map error: src/util/string_to_uint_map.h ist nicht im Index Anwendung des Patches fehlgesc

Re: [Mesa-dev] [PATCH] r600: drop a bunch of post-cayman code.

2017-10-09 Thread Nicolai Hähnle
On 09.10.2017 06:05, Dave Airlie wrote: From: Dave Airlie Now that Marek has split the two drivers apart, drop a bunch of unnecessary code from the r600 half. There is probably a bunch more hiding in the video code. No piglit regressions on caicos. Signed-off-by: Dave Airlie --- [snip] dif

Re: [Mesa-dev] [PATCH] anv: fix null pointer dereference

2017-10-09 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 09/10/17 06:19, Tapani Pälli wrote: CID: 1419033 Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 487ff27594..c8ebdce0b4 10064

  1   2   >