Reviewed-by: Samuel Iglesias Gonsálvez
On Thu, 2017-08-31 at 08:52 +0300, Tapani Pälli wrote:
> error: incompatible pointer to integer conversion initializing
> 'VkFence'
> (aka 'unsigned long long') with an expression of type 'void *' [-
> Werror,-Wint-conversion]
>
> Signed-off-by: Tapani P
error: incompatible pointer to integer conversion initializing 'VkFence'
(aka 'unsigned long long') with an expression of type 'void *'
[-Werror,-Wint-conversion]
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
v2: Per Brian's comment, initialize offset to avoid compiler warning.
Cc: mesa-sta...@lists.fre
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/vulkan/wsi/wsi_common.h | 3 +
src/vulkan/wsi/wsi_common_x11.c | 143 ++--
2 files changed, 113 insertions(+), 33 deletions(-)
diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h
ind
Xorg server uses the OpenGL API by default and we still want
to support fencing in that situation. Fences seem to work
properly even is not using the OpenGL ES API.
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/egl/main/eglapi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Allow drivers to add a list of semaphores to wait on
when queuing a image to present.
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/amd/vulkan/radv_wsi.c | 2 +-
src/intel/vulkan/anv_wsi.c | 2 ++
src/vulkan/wsi/wsi_common.h | 6 ++
src/vulkan/wsi/wsi_com
Hi,
This patchset makes use of Jason Ekstrand's recent work on SYNC_FD
semaphores and DRI3 v1.1 support for DMA fences:
https://lists.freedesktop.org/archives/mesa-dev/2017-August/168154.html
It allows Vulkan WSI clients (X11 only for now) to use explicit fencing.
That means vkQueuePresent can ha
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/intel/vulkan/anv_wsi.c | 121 -
1 file changed, 119 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c
index 2c6c4db4eb..38eec76a97 100644
--- a/src/in
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/vulkan/wsi/wsi_common_x11.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index ecdaf91434..d132541156 100644
--- a/src/vulkan/wsi/wsi_comm
2017-08-31 2:20 GMT+02:00 Timothy Arceri :
>
>
> On 31/08/17 06:19, Thomas Helland wrote:
>>
>> Length of the token was already calculated by flex and stored in yyleng,
>> no need to implicitly call strlen() via linear_strdup().
>>
>> V2: Also convert this pattern in glsl_lexer.ll
>> This has
From: Chad Versace
Update vulkan.h and vk.xml from [1]:
git://github.com/chadversary/vulkan-spec
refs/tags/chadv/test/2017-03-06-VK_MESAX_external
This pulls in the following extensions:
- VK_EXT_get_image_properties
- VK_MESAX_external_memory_dma_buf
- VK_MESAX_external_image_dma_buf
From: Chad Versace
When creating a VkSurface for X11, we created the underlying VkImage by
calling anv_image_create() and passing driver-private info to it. We can
now accomplish the same thing without driver-private info, using
VK_MESAX_external_image_dma_buf.
In anv_wsi.c, replace the combo o
From: Chad Versace
When creating a VkSurface for X11, we created the underlying VkImage by
calling anv_image_create() and passing driver-private info to it. We can
now accomplish the same thing without driver-private info, using
VK_MESAX_external_image_dma_buf.
In anv_wsi.c, replace the combo o
From: Daniel Stone
Allow the WSI to provide a set of modifiers to be used along with the
format.
For now, no winsys provides any modifier support. Add a fallback to the
previous default (X-tiling) inside ANV.
RADV remains somewhat broken in the presence of a winsys which will
suggest modifiers,
From: Chad Versace
This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created
it during the early days of bringing up the Vulkan driver. We used it
for testing the early driver because, in those early days, there was no
other way to import/export a tiled VkImage and examine it. No
V
From: Chad Versace
---
src/intel/vulkan/anv_image.c | 26 ++
src/intel/vulkan/anv_private.h | 5 -
2 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 241b7c9fe0..a99f0e4b29 100644
--- a/
From: Chad Versace
---
src/intel/vulkan/anv_image.c | 26 ++
src/intel/vulkan/anv_private.h | 5 -
2 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 241b7c9fe0..a99f0e4b29 100644
--- a/
From: Chad Versace
- Rename the anv_image_create_info vars from 'create_info' to 'anv_info'.
- Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to
'base_info'.
This reduces the diff and eliminates ambiguity in follow-up patches for
upcoming extensions, because the extensions
From: Daniel Stone
Adds support for multiple planes and buffer modifiers.
---
src/intel/vulkan/anv_wsi.c | 7 ++-
src/vulkan/wsi/wsi_common_x11.c | 118
2 files changed, 112 insertions(+), 13 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi.c b/
From: Daniel Stone
Add a simple conversion from ISL tiling to GEM BO tiling flags, and use
that instead of hardcoding I915_TILING_X in the ANV WSI.
Signed-off-by: Daniel Stone
---
src/intel/isl/isl.c| 28
src/intel/isl/isl.h| 8
src/intel/
From: Chad Versace
For now, we support dma_buf images for only a single format,
VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D,
single-sample, non-mipmappped, non-array, non-cube.
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 144
From: Chad Versace
This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created
it during the early days of bringing up the Vulkan driver. We used it
for testing the early driver because, in those early days, there was no
other way to import/export a tiled VkImage and examine it. No
V
From: Chad Versace
Like anv_get_format(), but the returned format is not adjusted, not even
for the aspect.
Add anv_get_raw_isl_format() too, to match anv_get_isl_format().
---
src/intel/vulkan/anv_formats.c | 7 +++
src/intel/vulkan/anv_private.h | 8
2 files changed, 15 insertion
From: Daniel Stone
Adds support for multiple planes and buffer modifiers.
---
src/intel/vulkan/anv_wsi.c | 7 ++-
src/vulkan/wsi/wsi_common_x11.c | 118
2 files changed, 112 insertions(+), 13 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi.c b/
From: Chad Versace
Now that anv_image_create() is gone, there is no need for struct
anv_image_create_info. The struct just adds an unused layer of
indirection.
---
src/intel/vulkan/anv_image.c | 38 +++---
src/intel/vulkan/anv_private.h | 9 -
2 files c
From: Daniel Stone
Allow the WSI to provide a set of modifiers to be used along with the
format.
For now, no winsys provides any modifier support. Add a fallback to the
previous default (X-tiling) inside ANV.
RADV remains somewhat broken in the presence of a winsys which will
suggest modifiers,
From: Chad Versace
---
src/intel/vulkan/anv_private.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 7b4e9dfbe0..55840d5325 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_privat
From: Chad Versace
make_surface() always returns VK_SUCCESS, so change its return type to
'void'. This simplifies the return-code handling in
anv_image_create_info() and removes a goto.
---
src/intel/vulkan/anv_image.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff
From: Chad Versace
make_ccs_surface_maybe() correctly handles failure
isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still
valid, just without a ccs surface.
Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf().
Fix make_hiz_surface_maybe() to do the same.
---
src/int
From: Chad Versace
For now, we support dma_bufs only for VkBuffers. The
VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf
VkImages, but we choose to defer that support until
VK_MESAX_external_image_dma_buf.
---
src/intel/vulkan/anv_device.c | 25 +++--
From: Chad Versace
Now that anv_image_create() is gone, there is no need for struct
anv_image_create_info. The struct just adds an unused layer of
indirection.
---
src/intel/vulkan/anv_image.c | 38 +++---
src/intel/vulkan/anv_private.h | 9 -
2 files c
From: Chad Versace
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_image.c | 13 +
2 files changed, 14 insertions(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 6b3d72e4b4..4377d4b985 100644
--- a/src/intel/vu
From: Chad Versace
For now, we support dma_bufs only for VkBuffers. The
VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf
VkImages, but we choose to defer that support until
VK_MESAX_external_image_dma_buf.
---
src/intel/vulkan/anv_device.c | 25 +++--
From: Chad Versace
Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree
at the tail of make_surface(). This patch extracts that 'if' tree into
the new functions:
make_hiz_surface_maybe()
make_ccs_surface_maybe()
make_mcs_surface_maybe()
For clarity, also rename ma
From: Chad Versace
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_image.c | 13 +
2 files changed, 14 insertions(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 6b3d72e4b4..4377d4b985 100644
--- a/src/intel/vu
From: Chad Versace
Set anv_surface::offset *before* calling add_surface().
No intended change in behavior. This patch prepares for supporting
user-provided surface offsets, a feature required for
VK_MESAX_external_image_dma_buf.
---
src/intel/vulkan/anv_image.c | 15 ---
1 file chan
From: Chad Versace
The code that chooses the image's tiling flags, extract it into a new
function, choose_isl_tiling_flags(). This reduces the diff in future
patches for the upcoming dma_buf-import extension, in which the the
tiling code will become more complex.
---
src/intel/vulkan/anv_image.
From: Chad Versace
make_ccs_surface_maybe() correctly handles failure
isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still
valid, just without a ccs surface.
Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf().
Fix make_hiz_surface_maybe() to do the same.
---
src/int
From: Chad Versace
---
src/intel/isl/isl.c | 35 +++
src/intel/isl/isl.h | 15 +++
2 files changed, 50 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 8ebe8538fa..5e911e4f4d 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/i
From: Chad Versace
Set anv_surface::offset *before* calling add_surface().
No intended change in behavior. This patch prepares for supporting
user-provided surface offsets, a feature required for
VK_MESAX_external_image_dma_buf.
---
src/intel/vulkan/anv_image.c | 15 ---
1 file chan
From: Chad Versace
make_surface() always returns VK_SUCCESS, so change its return type to
'void'. This simplifies the return-code handling in
anv_image_create_info() and removes a goto.
---
src/intel/vulkan/anv_image.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff
From: Chad Versace
For now, we support dma_buf images for only a single format,
VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D,
single-sample, non-mipmappped, non-array, non-cube.
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 144
From: Chad Versace
---
src/intel/vulkan/anv_private.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 7b4e9dfbe0..55840d5325 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_privat
From: Chad Versace
The code that chooses the image's tiling flags, extract it into a new
function, choose_isl_tiling_flags(). This reduces the diff in future
patches for the upcoming dma_buf-import extension, in which the the
tiling code will become more complex.
---
src/intel/vulkan/anv_image.
From: Chad Versace
Update vulkan.h and vk.xml from [1]:
git://github.com/chadversary/vulkan-spec
refs/tags/chadv/test/2017-03-06-VK_MESAX_external
This pulls in the following extensions:
- VK_EXT_get_image_properties
- VK_MESAX_external_memory_dma_buf
- VK_MESAX_external_image_dma_buf
From: Chad Versace
Like anv_get_format(), but the returned format is not adjusted, not even
for the aspect.
Add anv_get_raw_isl_format() too, to match anv_get_isl_format().
---
src/intel/vulkan/anv_formats.c | 7 +++
src/intel/vulkan/anv_private.h | 8
2 files changed, 15 insertion
From: Chad Versace
Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree
at the tail of make_surface(). This patch extracts that 'if' tree into
the new functions:
make_hiz_surface_maybe()
make_ccs_surface_maybe()
make_mcs_surface_maybe()
For clarity, also rename ma
Add support for DRI3 v1.1, which allows pixmaps to be backed by
multi-planar buffers, or those with format modifiers. This is both
for allocating render buffers, as well as EGLImage imports from a
native pixmap (EGL_NATIVE_PIXMAP_KHR).
Signed-off-by: Louis-Francis Ratté-Boulianne
Reviewed-by: Eri
From: Daniel Stone
Add a simple conversion from ISL tiling to GEM BO tiling flags, and use
that instead of hardcoding I915_TILING_X in the ANV WSI.
Signed-off-by: Daniel Stone
---
src/intel/isl/isl.c| 28
src/intel/isl/isl.h| 8
src/intel/
From: Chad Versace
It converts a DRM format modifier to and from enum isl_tiling and
aux_usage. That's all.
---
src/intel/Makefile.isl.am | 1 +
src/intel/isl/isl.c | 59 +++
src/intel/isl/isl.h | 16 +
3 files changed, 76 inse
Some DRI image properties weren't properly duplicated in the
new image. Some properties are still missing, but I'm not
certain if there was a good reason to let them out in the first
place.
Signed-off-by: Louis-Francis Ratté-Boulianne
---
src/mesa/drivers/dri/i965/intel_screen.c | 3 +++
1 file
From: Chad Versace
- Rename the anv_image_create_info vars from 'create_info' to 'anv_info'.
- Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to
'base_info'.
This reduces the diff and eliminates ambiguity in follow-up patches for
upcoming extensions, because the extensions
Hi,
With full support for modifiers in DRIimage, this patch series adds
support for fully plumbing them through X11. This is the second
revision, more context can be found here:
https://lists.freedesktop.org/archives/mesa-dev/2017-June/158457.html
Not much has changed since last time apart from r
From: Chad Versace
---
src/intel/isl/isl.c | 35 +++
src/intel/isl/isl.h | 15 +++
2 files changed, 50 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 8ebe8538fa..5e911e4f4d 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/i
From: Chad Versace
It converts a DRM format modifier to and from enum isl_tiling and
aux_usage. That's all.
---
src/intel/Makefile.isl.am | 1 +
src/intel/isl/isl.c | 59 +++
src/intel/isl/isl.h | 16 +
3 files changed, 76 inse
Add support for DRI3 v1.1, which allows pixmaps to be backed by
multi-planar buffers, or those with format modifiers. This is both
for allocating render buffers, as well as EGLImage imports from a
native pixmap (EGL_NATIVE_PIXMAP_KHR).
Signed-off-by: Louis-Francis Ratté-Boulianne
Reviewed-by: Eri
On 2017-08-22 19:09:23, Kenneth Graunke wrote:
> It doesn't seem like the old code could possibly work.
>
> 1. brw_gs_state_dirty made us bail unless one of these flags were set:
>_NEW_TEXTURE, BRW_NEW_GEOMETRY_PROGRAM, BRW_NEW_TRANSFORM_FEEDBACK
> 2. If there was no geometry program, we calle
On 08/30/2017 03:49 PM, Charmaine Lee wrote:
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
Wow, nice working finding that! Looks good to m
On 31/08/17 06:19, Thomas Helland wrote:
Length of the token was already calculated by flex and stored in yyleng,
no need to implicitly call strlen() via linear_strdup().
V2: Also convert this pattern in glsl_lexer.ll
This has a surprising result of reducing executed cyles from
1.06
https://bugs.freedesktop.org/show_bug.cgi?id=101832
Bernhard Rosenkraenzer changed:
What|Removed |Added
Hardware|x86-64 (AMD64) |All
OS|Linux (
https://bugs.freedesktop.org/show_bug.cgi?id=101832
--- Comment #13 from Bernhard Rosenkraenzer ---
Created attachment 133894
--> https://bugs.freedesktop.org/attachment.cgi?id=133894&action=edit
Fix
Here's a fix... Probably should (in addition to this) catch the cache directory
pointing somew
https://bugs.freedesktop.org/show_bug.cgi?id=101832
--- Comment #12 from Bernhard Rosenkraenzer ---
The debug output was more useful than I initially thought ;)
The crash happens when getenv() in GetEnv() returns NULL, leading to the
std::string constructor getting a NULL constructor.
--
You a
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
---
src/mesa/vbo/vbo_minmax_index.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-
https://bugs.freedesktop.org/show_bug.cgi?id=101832
--- Comment #11 from Bernhard Rosenkraenzer ---
The output of the patch doesn't look too helpful to me:
(II) glamor: OpenGL accelerated X.org driver based.
SWR_DEBUG env /tmp/Rast/DebugOutput
SWR_DEBUG env ${HOME}/.swr/jitcache
(EE)
(EE) Backtr
2017-08-29 7:25 GMT+02:00 Thomas Helland :
> 2017-08-28 11:47 GMT+02:00 Nicolai Hähnle :
>> On 28.08.2017 11:13, Nicolai Hähnle wrote:
>>>
>>> On 28.08.2017 03:51, Timothy Arceri wrote:
On 27/08/17 05:18, Thomas Helland wrote:
>
> Plowed through it a couple times, and it looks sol
Length of the token was already calculated by flex and stored in yyleng,
no need to implicitly call strlen() via linear_strdup().
V2: Also convert this pattern in glsl_lexer.ll
This has a surprising result of reducing executed cyles from
1.06 trillion to 1.03 trillion, a significant change
Am 30.08.2017 um 16:46 schrieb Brian Paul:
> On 08/30/2017 02:43 AM, Roland Scheidegger wrote:
>> Am 30.08.2017 um 04:49 schrieb Brian Paul:
>>> On 08/29/2017 06:17 PM, Roland Scheidegger wrote:
Looks good to me, thanks.
Reviewed-by: Roland Scheidegger
Albeit I'm not quite
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, August 30, 2017 10:16:05 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: include sample count in surface_size() computation
Use MAX2() because sample
On 30 August 2017 at 17:59, Marek Olšák wrote:
> On Wed, Aug 30, 2017 at 6:36 PM, Emil Velikov
> wrote:
>> Hi all,
>>
>> On 14 March 2017 at 23:51, Samuel Pitoiset wrote:
>>> On 03/14/2017 10:21 PM, Dave Airlie wrote:
On 15 March 2017 at 07:17, Dave Airlie wrote:
>
> From: Da
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf
> Of Emil Velikov
> Sent: Wednesday, August 30, 2017 9:44 PM
> To: Marathe, Yogesh
> Cc: Gao, Shuo ; Liu, Zhiquan ;
> dani...@collabora.com; nicolai.haeh...@amd.com; Antognolli, Rafael
> ; e...@
Use MAX2() because sampleCount will be zero for non-MSAA surfaces.
No Piglit regressions.
---
src/gallium/drivers/svga/svga_screen_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/svga/svga_screen_cache.c
b/src/gallium/drivers/svga/svga_screen_cache.
On Wed, Aug 30, 2017 at 6:36 PM, Emil Velikov wrote:
> Hi all,
>
> On 14 March 2017 at 23:51, Samuel Pitoiset wrote:
>> On 03/14/2017 10:21 PM, Dave Airlie wrote:
>>>
>>> On 15 March 2017 at 07:17, Dave Airlie wrote:
From: Dave Airlie
LLVM 4.0 released with a pretty messy re
On Wednesday, 2017-08-30 15:37:31 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Should prevent accidental check-in of patch artefacts.
>
> Cc: Mike Lothian
> Suggested-by: Mike Lothian
> Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
> ---
> Thanks for the idea Mike!
> ---
>
Hi all,
On 14 March 2017 at 23:51, Samuel Pitoiset wrote:
> On 03/14/2017 10:21 PM, Dave Airlie wrote:
>>
>> On 15 March 2017 at 07:17, Dave Airlie wrote:
>>>
>>> From: Dave Airlie
>>>
>>> LLVM 4.0 released with a pretty messy regression, that hopefully
>>> get fixed in the future.
>>>
>>> This
On 30 August 2017 at 15:39, Marathe, Yogesh wrote:
>
> Thank you, Tomasz and all involved for the help and guidance.
>
Our excitement was short lived - see commit
8c9df0daf20206fafb7df77b1edcbc41b8e91372.
Seems the patch was not run through the Intel CI, though I'm should
not have assumed that y
Reviewed-by: Marek Olšák
Marek
On Wed, Aug 30, 2017 at 1:05 PM, Emil Velikov wrote:
> On 18 August 2017 at 17:37, Emil Velikov wrote:
>> On 3 August 2017 at 19:29, Emil Velikov wrote:
>>> From: Emil Velikov
>>>
>>> Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE")
>>> Cc: Timot
On Wed, Aug 30, 2017 at 2:22 PM, Timothy Arceri wrote:
> On 30/08/17 20:07, Marek Olšák wrote:
>>
>> If LLVM was fixed to do the correct thing, we could enable CONSTBUF
>> LOAD for LLVM 6.0 and later.
>
>
> You seem to think that the compiler *should* be placing them near where they
> are used? Wh
From: Emil Velikov
Should prevent accidental check-in of patch artefacts.
Cc: Mike Lothian
Suggested-by: Mike Lothian
Signed-off-by: Emil Velikov
---
Thanks for the idea Mike!
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 964409265fa..b798
LOL didn't even spot this sorry
It might be a good idea to pop *.orig and *.rej into the gitignore file
On Wed, 30 Aug 2017 at 14:17 Emil Velikov wrote:
> On 30 August 2017 at 14:11, Eric Engestrom wrote:
> > Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl"
> > Cc: Emil Veli
On Wednesday, August 30, 2017 3:57:48 AM PDT kevin.rogo...@intel.com wrote:
> From: Kevin Rogovin
>
> For Gen8, add 2xMSAA. For Gen9, add 2xMSAA and 16xMSAA.
> Special thanks to Eero Tamminen for reporting rasterizer
> numbers being twice what it should be for 2xMSAA under
> a benchmark.
>
> V2:
On 08/30/2017 02:43 AM, Roland Scheidegger wrote:
Am 30.08.2017 um 04:49 schrieb Brian Paul:
On 08/29/2017 06:17 PM, Roland Scheidegger wrote:
Looks good to me, thanks.
Reviewed-by: Roland Scheidegger
Albeit I'm not quite sure why it is never set here?
This particular test sets a 0 x 0 sci
On Wed, Aug 30, 2017 at 10:18 AM, Qiang Yu wrote:
> On Wed, Aug 30, 2017 at 9:03 PM, Rob Clark wrote:
>> On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote:
btw, does lima have some way to write to memory from cmdstream (ie.
without setting up a full blown draw)? If so perhaps you could
> -Original Message-
> From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
> Sent: Wednesday, August 30, 2017 4:39 PM
> To: Marathe, Yogesh
> Cc: mesa-dev@lists.freedesktop.org; tf...@chromium.org; Gao, Shuo
> ; Liu, Zhiquan ;
> dani...@collabora.com; nicolai.haeh...@amd.com; Antognolli,
On Wed, Aug 30, 2017 at 9:03 PM, Rob Clark wrote:
> On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote:
>>> btw, does lima have some way to write to memory from cmdstream (ie.
>>> without setting up a full blown draw)? If so perhaps you could get
>>> away with leaving some extra space at the end of
On Wed, Aug 30, 2017 at 12:50 PM, Emil Velikov wrote:
> On 30 August 2017 at 10:38, Marek Olšák wrote:
>> On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov
>> wrote:
>>> Hi Marek,
>>>
>>> There's a couple of subtle changes in the patch. If intentional, could
>>> you mention that in the commit mess
On 30 August 2017 at 14:11, Eric Engestrom wrote:
> Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl"
> Cc: Emil Velikov
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
/me puts on a brown paper bag
-Emil
___
mesa-dev mai
Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl"
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
src/mesa/state_tracker/st_glsl_to_nir.cpp.orig | 479 -
1 file changed, 479 deletions(-)
delete mode 100644 src/mesa/state_tracker/st_glsl_to_nir.cpp.or
This introduces a new separate option because the output can
be quite verbose. If spirv-dis is not found in the path, this
debug option is useless.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_debug.c| 30 ++
src/amd/vulkan/radv_debug.h| 3 +++
src/
Ported from RadeonSI (original patch by Marek).
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pipeline.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 637fed625f..e3a8dff992 100644
At the moment, debugging radv is not really easy because the
driver doesn't report enough information when it hangs. This
new file will be the main location for all debug tools.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/Makefile.sources | 1 +
src/amd/vulkan/radv_debug.c |
On 29 August 2017 at 10:51, Michael Olbrich wrote:
> dri2_display_destroy may be called by dri2_initialize_wayland_drm() if
> initialization fails. In this case, these objects may not be initialized.
>
Only if the wayland API had some basic NULL checks ... ;-)
Thanks patch is Reviewed-by: Emil Ve
On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote:
>> btw, does lima have some way to write to memory from cmdstream (ie.
>> without setting up a full blown draw)? If so perhaps you could get
>> away with leaving some extra space at the end of your uniform buffer
>> that you copy driver internal un
On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
wrote:
> So as a random drive-by review, I think the risk in this implementation
> is that apps just set maxdrawcount to some high value . If I'm reading
> the spec correctly there is no real bound on the value except for the
> max-representable v
On 30/08/17 20:07, Marek Olšák wrote:
If LLVM was fixed to do the correct thing, we could enable CONSTBUF
LOAD for LLVM 6.0 and later.
You seem to think that the compiler *should* be placing them near where
they are used? What part of LLVM were you expecting to do this? I'm
happy to do some d
Hi Emil,
Thanks Leo, for the split.
There's a vl_compositor_set_yuv_layer reference loose in the header.
Yeah, thanks for catching that.
It's very appreciated.
Leo
Please remove that one with the patch, but don't bother resending.
-Emil
___
m
On 28 August 2017 at 11:27, Marathe, Yogesh wrote:
> This still doesn't seem to be merged. Can someone please look at it? It does
> have Rbs.
>
Done. Thanks for the work and patience on getting this sorted.
-Emil
___
mesa-dev mailing list
mesa-dev@list
On 18 August 2017 at 17:37, Emil Velikov wrote:
> On 3 August 2017 at 19:29, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE")
>> Cc: Timothy Arceri
>> Signed-off-by: Emil Velikov
>> ---
>> src/egl/drivers/dri2/platform_x11.c | 1 +
From: Kevin Rogovin
For Gen8, add 2xMSAA. For Gen9, add 2xMSAA and 16xMSAA.
Special thanks to Eero Tamminen for reporting rasterizer
numbers being twice what it should be for 2xMSAA under
a benchmark.
V2: Make pointer name less ugly + add 2xMSAA for Gen8
---
src/mesa/drivers/dri/i965/intel_scre
On 30 August 2017 at 10:38, Marek Olšák wrote:
> On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov
> wrote:
>> Hi Marek,
>>
>> There's a couple of subtle changes in the patch. If intentional, could
>> you mention that in the commit message?
>>
>> On 29 August 2017 at 23:25, Marek Olšák wrote:
>>
>
Hi,
Please do not push yet. I will post a V2 that makes the pointer thing not so
offensively ugly. Also, I missed the opportunity to also fix the DRI conf for
Gen8, as it does have 2xMSAA.
-Kevin
-Original Message-
From: Ben Widawsky [mailto:b...@bwidawsk.net]
Sent: Thursday, August
1 - 100 of 141 matches
Mail list logo
