[Mesa-dev] [PATCH 2/4] mesa: create copyteximage_err() helper and always inline copyteximage()

2017-06-25 Thread Timothy Arceri
This will be useful in the following patch when we add KHR_no_error support. --- src/mesa/main/teximage.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 796c8ad..29a795f 100644 --- a/src/mesa/main/te

[Mesa-dev] [PATCH 1/4] mesa: tidy up copyteximage()

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index a9086a2..796c8ad 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3808,11 +3808,7 @@ copyteximage(str

[Mesa-dev] [PATCH 3/4] mesa: add no error support to copyteximage()

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 29a795f..a08f34b 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3806,7

[Mesa-dev] [PATCH 4/4] mesa: add KHR_no_error support for glCopyTexImage*D()

2017-06-25 Thread Timothy Arceri
--- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/teximage.c | 20 src/mesa/main/teximage.h | 11 +++ 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 9857e39..d878a04

Re: [Mesa-dev] [PATCH 22/31] mesa: don't flag _NEW_TRANSFORM for st/mesa if possible

2017-06-25 Thread Michel Dänzer
On 24/06/17 09:50 AM, Marek Olšák wrote: > Thanks. It can only be reproduced with process isolation enabled in > piglit, which is not something I test. I'm running piglit with process isolation disabled as well. Maybe this issue depended on the order in which this test was run relative to other te

[Mesa-dev] [PATCH 3/5] mesa: remove redundant NULL check

2017-06-25 Thread Timothy Arceri
This can never be NULL in any of the entry paths. --- src/mesa/main/teximage.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 9d39759..a039747 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 1/5] mesa: make _mesa_copy_texture_sub_image() static

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 175 +++ src/mesa/main/teximage.h | 9 --- 2 files changed, 85 insertions(+), 99 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 128e010..88c76f0 100644 --- a/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 2/5] mesa: create copy_texture_sub_image_err() helper

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 84 +++- 1 file changed, 48 insertions(+), 36 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 88c76f0..9d39759 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -37

[Mesa-dev] [PATCH 4/5] mesa: add copy_texture_sub_image_no_error() helper

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index a039747..ac25985 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3783,6 +3783,23 @@ copy_texture_sub_image_err(stru

[Mesa-dev] [PATCH 5/5] mesa: add KHR_no_error support for glCopyTex{ture}SubImage*D()

2017-06-25 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +- src/mapi/glapi/gen/gl_API.xml | 6 +- src/mesa/main/teximage.c | 81 ++ src/mesa/main/teximage.h | 28 + 4 files changed, 115 insertions(+), 6 d

[Mesa-dev] [PATCH 1/3] radv/clear: add r32g32b32a32 fast clear support

2017-06-25 Thread Dave Airlie
From: Dave Airlie We can only fast clear 128-bit images if the r/g/b channels are the same, and we are using DCC. For DCC we'll bail out on translate if this isn't true, and we catch cmask clears explicitly. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c| 7 +++ src/amd/

[Mesa-dev] [PATCH 3/3] [rfc] radv: predicate cmask eliminate when using DCC.

2017-06-25 Thread Dave Airlie
From: Dave Airlie When using DCC some clear values don't require a cmask eliminate step. This patch adds support for black and black with alpha 1, there are other values, but I don't have access to a comprehensive list. This works by setting the cmask eliminate predicate when doing the fast clea

[Mesa-dev] [PATCH 2/3] radv: add support for cmd predication.

2017-06-25 Thread Dave Airlie
From: Dave Airlie This doesn't get used yet, it just adds support to various PKT3 emissions to enable it later. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 11 --- src/amd/vulkan/radv_device.c | 3 ++ src/amd/vulkan/radv_private.h| 5 +++ src/amd/vulkan/radv

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI v2

2017-06-25 Thread Peter Frühberger
Hi all, just as information: https://github.com/FernetMenta/kodi-agile/commit/ca8119b4e11a52415125af959f220b280f56ecae Rainer moved the specific parts of the buffer sharing into a separate infrastructure see the VAAPIEGL.cpp and VAAPIEGL.h in the above patch. This basically encapsulates the fourc

[Mesa-dev] [PATCH] radeonsi: don't flush and wait for CB after depth-only rendering

2017-06-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 0f39ede..b236bed 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++

[Mesa-dev] [PATCH 2/2] mesa: optimize GL_PRIMITIVE_RESTART_NV more

2017-06-25 Thread Marek Olšák
From: Marek Olšák And other client state changes don't have to call update_derived_primitive_restart_state. --- src/mesa/main/enable.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 18a288d..2e5fb00 1

[Mesa-dev] [PATCH 1/2] mesa: fix clip plane enable breakage

2017-06-25 Thread Marek Olšák
From: Marek Olšák Broken by: commit 00173d91b70ae4dcea7c6324ee4858c498cae14b Author: Marek Olšák Date: Sat Jun 10 12:09:43 2017 +0200 mesa: don't flag _NEW_TRANSFORM for st/mesa if possible It also optimizes the case slightly for GL core. It doesn't try to fix that glEnable might be a

[Mesa-dev] [PATCH 3/3] mesa: add KHR_no_error support for gl{Compressed}TexImage*D()

2017-06-25 Thread Timothy Arceri
--- src/mapi/glapi/gen/gl_API.xml | 14 src/mesa/main/teximage.c | 82 +++ src/mesa/main/teximage.h | 34 ++ 3 files changed, 124 insertions(+), 6 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/ge

[Mesa-dev] [PATCH 2/3] mesa: add no error support to teximage()

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/teximage.c | 61 +--- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 4301070..4ff7d33 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -28

[Mesa-dev] [PATCH 1/3] mesa: create wrapper around teximage()

2017-06-25 Thread Timothy Arceri
This is used to inline KHR_no_error logic without inlining the function into all its callers. --- src/mesa/main/teximage.c | 40 ++-- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 69ad88

[Mesa-dev] [AppVeyor] mesa master #4738 failed

2017-06-25 Thread AppVeyor
Build mesa 4738 failed Commit 4a34f3244a by Dave Airlie on 6/14/2017 10:46 PM: radv/meta: don't need vertex info for resolve shader.\n\nReviewed-by: Bas Nieuwenhuizen \nSigned-off-by: Dave Airlie Configure your notification preferences _

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Jason Ekstrand
On June 25, 2017 3:47:09 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 6:24 PM, Nicolai Hähnle wrote: On 25.06.2017 23:42, Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 5:39 PM, Jason Ekstrand wrote: On June 25, 2017 2:31:56 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 5:25 PM, Jason Ek

[Mesa-dev] [PATCH] mesa: fix unused variable warning in release builds

2017-06-25 Thread Timothy Arceri
--- src/mesa/main/uniforms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 91c3bf6..1c3d89b 100644 --- a/src/mesa/main/uniforms.c +++ b/src/mesa/main/uniforms.c @@ -104,7 +104,7 @@ _mesa_update_shader_textures_used(str

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom marshalling for glNamedBuffer(Sub)Data

2017-06-25 Thread Timothy Arceri
On 25/06/17 18:31, Grigori Goronzy wrote: On 2017-06-25 02:37, Timothy Arceri wrote: Please try the series from Marek which reduces the batch size [1], the reduced size helps reduce the impact of syncs. MARSHAL_MAX_CMD_SIZE is also greatly reduced to help reduce thrashing the cache so its possi

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Ilia Mirkin
On Sun, Jun 25, 2017 at 6:24 PM, Nicolai Hähnle wrote: > On 25.06.2017 23:42, Ilia Mirkin wrote: >> >> On Sun, Jun 25, 2017 at 5:39 PM, Jason Ekstrand >> wrote: >>> >>> On June 25, 2017 2:31:56 PM Ilia Mirkin wrote: >>> On Sun, Jun 25, 2017 at 5:25 PM, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Dave Airlie
On 26 June 2017 at 06:55, Bas Nieuwenhuizen wrote: > On Sun, Jun 25, 2017 at 10:29 PM, Dave Airlie wrote: >> On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: >>> v2: Don't pass layout to image view usage mask. >>> >>> Signed-off-by: Bas Nieuwenhuizen >>> Fixes: 0628580eff6 "radv: Specify sema

Re: [Mesa-dev] [PATCH] radv: Remove unused args of radv_image_view_init.

2017-06-25 Thread Dave Airlie
On 26 June 2017 at 07:01, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Dave Airlie ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Nicolai Hähnle
On 25.06.2017 23:42, Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 5:39 PM, Jason Ekstrand wrote: On June 25, 2017 2:31:56 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 5:25 PM, Jason Ekstrand wrote: On June 25, 2017 1:40:09 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 4:33 PM, Jason Eks

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Ilia Mirkin
On Sun, Jun 25, 2017 at 5:39 PM, Jason Ekstrand wrote: > On June 25, 2017 2:31:56 PM Ilia Mirkin wrote: > >> On Sun, Jun 25, 2017 at 5:25 PM, Jason Ekstrand >> wrote: >>> >>> On June 25, 2017 1:40:09 PM Ilia Mirkin wrote: >>> On Sun, Jun 25, 2017 at 4:33 PM, Jason Ekstrand wrote: >>>

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Jason Ekstrand
On June 25, 2017 2:31:56 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 5:25 PM, Jason Ekstrand wrote: On June 25, 2017 1:40:09 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 4:33 PM, Jason Ekstrand wrote: Anyone have thoughts on this? Am I being foolish for trying to hold onto GL_RGBA4 t

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Ilia Mirkin
On Sun, Jun 25, 2017 at 5:25 PM, Jason Ekstrand wrote: > On June 25, 2017 1:40:09 PM Ilia Mirkin wrote: > >> On Sun, Jun 25, 2017 at 4:33 PM, Jason Ekstrand >> wrote: Anyone have thoughts on this? Am I being foolish for trying to hold onto GL_RGBA4 texturing? (Any decision here al

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Jason Ekstrand
On June 25, 2017 1:40:09 PM Ilia Mirkin wrote: On Sun, Jun 25, 2017 at 4:33 PM, Jason Ekstrand wrote: Anyone have thoughts on this? Am I being foolish for trying to hold onto GL_RGBA4 texturing? (Any decision here also affects st/nine.) Yes. Chances are that you're also doing texture view

[Mesa-dev] [PATCH] radv: Remove unused args of radv_image_view_init.

2017-06-25 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_image.c | 6 ++ src/amd/vulkan/radv_meta_blit.c | 12 ++-- src/amd/vulkan/radv_meta_blit2d.c | 16 +++- src/amd/vulkan/radv_meta_bufimage.c | 13 ++--- src/amd/vulkan/radv_meta_clear.c

Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Bas Nieuwenhuizen
On Sun, Jun 25, 2017 at 10:29 PM, Dave Airlie wrote: > On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: >> v2: Don't pass layout to image view usage mask. >> >> Signed-off-by: Bas Nieuwenhuizen >> Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." > > Just wondering what thi

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Ilia Mirkin
On Sun, Jun 25, 2017 at 4:33 PM, Jason Ekstrand wrote: >> Anyone have thoughts on this? Am I being foolish for trying to hold >> onto GL_RGBA4 texturing? (Any decision here also affects st/nine.) > > > Yes. Chances are that you're also doing texture views wrong. Are there any > formats supp

Re: [Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Jason Ekstrand
On June 25, 2017 1:21:33 PM Ilia Mirkin wrote: I was hoping I could solicit some ideas from the group. As you're likely aware, CopyImageSubData supports copying between a texture and a renderbuffer that were created with sized formats. NVIDIA hardware supports texturing from BGRA4 but not ren

Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Dave Airlie
On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: > v2: Don't pass layout to image view usage mask. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." Just wondering what this actually fixes, I've mostly left GENERAL in use in meta as it

[Mesa-dev] Help! CopyImageSubData is defeating me

2017-06-25 Thread Ilia Mirkin
I was hoping I could solicit some ideas from the group. As you're likely aware, CopyImageSubData supports copying between a texture and a renderbuffer that were created with sized formats. NVIDIA hardware supports texturing from BGRA4 but not rendering to it. So when a renderbuffer is created, st

[Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Bas Nieuwenhuizen
v2: Don't pass layout to image view usage mask. Signed-off-by: Bas Nieuwenhuizen Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." --- src/amd/vulkan/radv_meta_blit2d.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/r

Re: [Mesa-dev] [PATCH] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Bas Nieuwenhuizen
On Sun, Jun 25, 2017 at 9:42 PM, Dave Airlie wrote: > On 25 June 2017 at 04:58, Bas Nieuwenhuizen wrote: >> Signed-off-by: Bas Nieuwenhuizen >> Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." >> --- >> src/amd/vulkan/radv_meta_blit2d.c | 29 +++-- >>

Re: [Mesa-dev] [PATCH] blorp: Use normalized coordinates on Gen6

2017-06-25 Thread Eduardo Lima Mitev
Looks good to me. Reviewed-by: Eduardo Lima Mitev On 06/23/2017 10:51 PM, Ian Romanick wrote: > From: Ian Romanick > > Apparently, the sampler has some sort of precision issues for > non-normalized texture coordinates with linear filtering. This caused > some small precision issues in scaled

Re: [Mesa-dev] [PATCH] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Dave Airlie
On 25 June 2017 at 04:58, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." > --- > src/amd/vulkan/radv_meta_blit2d.c | 29 +++-- > 1 file changed, 11 insertions(+), 18 deletions(-) > > diff

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-06-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 tuks...@gmail.com changed: What|Removed |Added CC||tuks...@gmail.com -- You are receivi

Re: [Mesa-dev] Updating Khronos-supplied headers (and gl.xml)

2017-06-25 Thread Matt Turner
On Sun, Jun 25, 2017 at 7:32 AM, Nicolai Hähnle wrote: > Hi all, > > For the ARB_gl_spirv work I need some new definitions from the Khronos > headers, and I'd like to push the corresponding update to our master branch > already. > > The patch is rather big, so I'm posting it here: > https://cgit.f

Re: [Mesa-dev] [PATCH] radeonsi: enable LLVM sisched for Unigine Superposition

2017-06-25 Thread Marek Olšák
On Sun, Jun 25, 2017 at 12:55 PM, Grigori Goronzy wrote: > On 2017-06-22 17:10, Marek Olšák wrote: >> >> From: Marek Olšák >> >> +2.3% better score on Fiji. It might be better without HBM. > > > Is this really useful? Superposition is a benchmark. It would make more > sense if this also targeted

Re: [Mesa-dev] [PATCH 1/3] mesa/glthread: track buffer creation/destruction

2017-06-25 Thread Gregory Hainaut
Hello Fredrik, Yes the shadow hash feels useless now. I will update the patch in a couple of days (vacation currently). Cheers, Gregory Le 22 juin 2017 2:24 PM, "Fredrik Höglund" a écrit : > On Thursday 22 June 2017, Timothy Arceri wrote: > > From: Gregory Hainaut > > > > It would be used in

[Mesa-dev] Updating Khronos-supplied headers (and gl.xml)

2017-06-25 Thread Nicolai Hähnle
Hi all, For the ARB_gl_spirv work I need some new definitions from the Khronos headers, and I'd like to push the corresponding update to our master branch already. The patch is rather big, so I'm posting it here: https://cgit.freedesktop.org/~nh/mesa/commit/?h=khronos-update&id=aa846e6b551797

Re: [Mesa-dev] [PATCH] radeonsi: enable LLVM sisched for Unigine Superposition

2017-06-25 Thread Grigori Goronzy
On 2017-06-22 17:10, Marek Olšák wrote: From: Marek Olšák +2.3% better score on Fiji. It might be better without HBM. Is this really useful? Superposition is a benchmark. It would make more sense if this also targeted some actual games. Optimizations specific to only benchmarks are considere

Re: [Mesa-dev] [PATCH] radeonsi: enable LLVM sisched for Unigine Superposition

2017-06-25 Thread Marek Olšák
On Jun 25, 2017 9:23 AM, "Nicolai Hähnle" wrote: On 24.06.2017 13:35, Marek Olšák wrote: > > > On Jun 24, 2017 12:01 PM, "Nicolai Hähnle" nhaeh...@gmail.com>> wrote: > > On 22.06.2017 17 :10, Marek Olšák wrote: > > From: Marek Olšák mailto:marek.ol...@amd.com > >> > > > +2.3

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom marshalling for glNamedBuffer(Sub)Data

2017-06-25 Thread Grigori Goronzy
On 2017-06-25 02:37, Timothy Arceri wrote: Please try the series from Marek which reduces the batch size [1], the reduced size helps reduce the impact of syncs. MARSHAL_MAX_CMD_SIZE is also greatly reduced to help reduce thrashing the cache so its possible this patch won't be as effective anymore

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Timothy Arceri
On Sun, Jun 25, 2017, at 12:30 AM, Nicolai Hähnle wrote: > On 25.06.2017 09:18, Nicolai Hähnle wrote: > > On 25.06.2017 03:31, Timothy Arceri wrote: > >> There are still a handful of piglit tests failing and I'm yet to test > >> that there are no regressions in the non-packed path, but I'd really >

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Timothy Arceri
On Sun, Jun 25, 2017, at 12:18 AM, Nicolai Hähnle wrote: > On 25.06.2017 03:31, Timothy Arceri wrote: > > There are still a handful of piglit tests failing and I'm yet to test > > that there are no regressions in the non-packed path, but I'd really > > like some feedback on the approach as Dave has

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Nicolai Hähnle
On 25.06.2017 09:18, Nicolai Hähnle wrote: On 25.06.2017 03:31, Timothy Arceri wrote: There are still a handful of piglit tests failing and I'm yet to test that there are no regressions in the non-packed path, but I'd really like some feedback on the approach as Dave has flagged it as a possible

Re: [Mesa-dev] [PATCH] radeonsi: enable LLVM sisched for Unigine Superposition

2017-06-25 Thread Nicolai Hähnle
On 24.06.2017 13:35, Marek Olšák wrote: On Jun 24, 2017 12:01 PM, "Nicolai Hähnle" > wrote: On 22.06.2017 17 :10, Marek Olšák wrote: From: Marek Olšák mailto:marek.ol...@amd.com>> +2.3% better score on Fiji. It might be better without HBM.

[Mesa-dev] [PATCH v5 1/6] mesa/st: glsl_to_tgsi move some helper classes to extra files

2017-06-25 Thread Gert Wollny
To prepare the implementation of a temp register lifetime tracker some of the classes are moved into seperate header/implementation files to make them accessible from other files. Specifically these are: class st_src_reg; class st_dst_reg; class glsl_to_tgsi_instruction; struct re

[Mesa-dev] [PATCH v5 6/6] mesa/st: glsl_to_tgsi: tie in new temporary register merge approach

2017-06-25 Thread Gert Wollny
This patch ties in the new temporary register lifetime estiamtion and rename mapping evaluation. In order to enable it, the evironment variable MESA_GLSL_TO_TGSI_NEW_MERGE must be set. Performance to compare between the current and the new implementation were measured by running the shader-db in o

[Mesa-dev] [PATCH v5 5/6] mesa/st: glsl_to_tgsi: Add test set for evaluation of rename mapping

2017-06-25 Thread Gert Wollny
The patch adds tests for the register rename mapping evaluation. --- .../tests/test_glsl_to_tgsi_lifetime.cpp | 94 ++ 1 file changed, 94 insertions(+) diff --git a/src/mesa/state_tracker/tests/test_glsl_to_tgsi_lifetime.cpp b/src/mesa/state_tracker/tests/test_glsl_

[Mesa-dev] [PATCH v5 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

2017-06-25 Thread Gert Wollny
This patch adds a set of unit tests for the new lifetime tracker. --- configure.ac | 1 + src/mesa/Makefile.am | 2 +- src/mesa/state_tracker/tests/Makefile.am | 36 + .../tests/test_glsl_to_tgsi_lifetime.cpp

[Mesa-dev] [PATCH v5 4/6] mesa/st: glsl_to_tgsi: add register renamame mapping evaluator

2017-06-25 Thread Gert Wollny
The remapping evaluator first sorts the temporary registers ascending based on their first life time instruction, and then uses a binary search to find merge canidates. For the initial sorting it uses std::sort because qsort is quite slow in comparison. By removing the define USE_STL_SORT in src/

[Mesa-dev] [PATCH v5 0/6] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-25 Thread Gert Wollny
Dear all, this is a minor update to the patch set. Changes are: - correct formatting following Emil's suggetions - remove un-needed libraries for the tests - rebase to master (e25950808f4eee) I didn't change anything to the code logic and I'm using mesa with the patch applied for a few days now

[Mesa-dev] [PATCH v5 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

2017-06-25 Thread Gert Wollny
This patch adds a class for tracking the life times of temporary registers in the glsl to tgsi translation. The algorithm runs in three steps: First, in order to minimize the number of needed memory allocations the program is scanned to evaluate the number of scopes. Then, the program is scanned s

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Nicolai Hähnle
On 25.06.2017 03:31, Timothy Arceri wrote: There are still a handful of piglit tests failing and I'm yet to test that there are no regressions in the non-packed path, but I'd really like some feedback on the approach as Dave has flagged it as a possible controversial tgsi change. In order to avo