On 26 June 2017 at 06:55, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > On Sun, Jun 25, 2017 at 10:29 PM, Dave Airlie <airl...@gmail.com> wrote: >> On 26 June 2017 at 06:19, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: >>> v2: Don't pass layout to image view usage mask. >>> >>> Signed-off-by: Bas Nieuwenhuizen <ba...@google.com> >>> Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." >> >> Just wondering what this actually fixes, I've mostly left GENERAL in >> use in meta as it seems like it would avoid transitions in meta paths, >> which mostly seems like the correct thing to do, the app should be >> transitioning things before/after the entrypoint that causes the meta >> path to be hit. >> >> Though of course there are problems knowing exactly what to flush >> before we know which meta path we want to use. > > Because HTILE is enabled for TRANSFER_DST_OPTIMAL, but not for > GENERAL. Ignoring a compressed HTILE is not a good idea. > > So I think it makes sense to at least keep these as > TRANSFER_DST_OPTIMAL to keep them in sync with whatever we decide the > compression to be. This doesn't result in any transitions either, as > the initial_layout/final_layout are also set to TRANSFER_DST_OPTIMAL.
Cool thanks for explaining! Reviewed-by: Dave Airlie <airl...@redhat.com> Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
