Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

thanks, pushed! On 11/17/2016 12:29 AM, Eric Engestrom wrote: I introduced this code last month, but didn't follow the naming convention. Fix this. Fixes: 0a606a400fe382a9bc72 ("egl: add eglSwapBuffersWithDamageKHR") Reviewed-by: Tapani Pälli Signed-off-by: Eric Engestrom --- src/egl/main/eg

[Mesa-dev] [PATCH] mesa: fix empty program log length

In case we have empty log (""), we should return 0. This fixes Khronos WebGL conformance test 'program-infolog'. From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: "If pname is INFO_LOG_LENGTH , the length of the info log, including a null terminator, is returned. If there is no info log, zero

Re: [Mesa-dev] [PATCH 11/13] glsl: push layout-qualifier-name values from variable declarations to global

On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > After the previous modifications in the merging of the > layout-qualifier-name values, we no longer push the final value in a > declaration to the global values. > > This regression happens because we don't call for merging on the > right-mo

Re: [Mesa-dev] [PATCH 09/13] glsl: simplified ast_type_qualifier::merge_into_[in|out]_qualifier API

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/13] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > Currently, the default in layout qualifier merge performs specific > validation and merge. > > We want to split out the validation from the merge so they can be > done > independently. > > Additionally, for simplification, the direction of

Re: [Mesa-dev] [PATCH 07/13] glsl: Add comments for the point mode layout-id-qualifier validation

On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > The point mode value in an ast_type_qualifier can only be true if the > flag is already set since this layout-id-qualifier can only be or not > be present in a shader. > > Hence, it is useless to check for its value if the flag is already >

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > Currently, the default in layout qualifier merge performs specific > validation and merge. > > We want to split out the validation from the merge so they can be > done > independently. > > Additionally, for simplification, the direction of

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

Patches 3-4 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/13] glsl: Remove unneeded check for incompatible primitive types in GS

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

Forget this patch. It's bogus. The computation of prog_data->nr_params requires gathered info so the earliest we could put it is at the top of this function. Instead, we'll just call anv_nir_lower_input_attachments earlier. On Wed, Nov 16, 2016 at 11:31 AM, Jason Ekstrand wrote: > The lower_i

Re: [Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > The merge into the default in layout qualifier duplicates a lot of > code that can be reused from the generic merge method. > > Now, we use the generic merge method inside the specific merge for > the > default in layout qualifier. The gener

Re: [Mesa-dev] [PATCH 07/14] nir: add a pass to compact clip/cull distances.

On Wednesday, November 16, 2016 8:37:50 PM PST Jason Ekstrand wrote: > On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke > wrote: > > > Signed-off-by: Kenneth Graunke > > --- > > src/compiler/Makefile.sources | 1 + > > src/compiler/nir/nir.h |

Re: [Mesa-dev] [PATCH 11/14] i965/fs: Handle compact outputs.

On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke wrote: > We need to calculate the number of vec4 slots correctly. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 +- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 +++- > 2 files changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH 13/14] anv: Enable clip and cull distance support.

Mind also checking it off in vulkan/TODO? On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke wrote: > Everything is now in place, and we appear to pass the tests on Gen7+. > > Signed-off-by: Kenneth Graunke > --- > src/intel/vulkan/anv_device.c | 10 +- > 1 file changed, 5 insertions(+),

Re: [Mesa-dev] [PATCH 09/14] anv: Set clip/cull distances fields in packets.

On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/vulkan/anv_private.h| 18 ++ > src/intel/vulkan/gen8_pipeline.c | 15 --- > src/intel/vulkan/genX_pipeline_util.h | 5 + > 3 files changed, 31

Re: [Mesa-dev] [PATCH 07/14] nir: add a pass to compact clip/cull distances.

On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 1 + > .../nir/nir_lower_clip_cull_distance_arrays.c | 187 > +++

Re: [Mesa-dev] [PATCH 06/14] nir: Add a "compact array" flag and IO lowering code.

On Wednesday, November 16, 2016 8:20:44 PM PST Jason Ekstrand wrote: > On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke > wrote: > > > Certain built-in arrays, such as gl_ClipDistance[], gl_CullDistance[], > > gl_TessLevelInner[], and gl_TessLevelOuter[] are specified as scalar > > arrays. Norma

Re: [Mesa-dev] [PATCH 06/14] nir: Add a "compact array" flag and IO lowering code.

On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke wrote: > Certain built-in arrays, such as gl_ClipDistance[], gl_CullDistance[], > gl_TessLevelInner[], and gl_TessLevelOuter[] are specified as scalar > arrays. Normal scalar arrays are sparse - each array element usually > occupies a whole vec4 s

Re: [Mesa-dev] [PATCH 04/18] intel/isl: Rework the asserts and fails in isl_surf_get_ccs

On Thu, Nov 3, 2016 at 7:26 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Oct 28, 2016 at 02:17:00AM -0700, Jason Ekstrand wrote: > > There are some invariants such as number of samples on which we should > > assert. However, most other things should silently return false s

[Mesa-dev] [PATCH] swr: [rasterizer core] don't attempt to load another RTAI when storing

Since we don't pass a renderTargetArrayIndex in, and the current hot tile may be for a different index, we may end up loading the RTAI=0 into the hot tile for no reason. Signed-off-by: Ilia Mirkin --- Noticed this when doing an audit of GetHotTile calls without a renderTargetArrayIndex being pa

[Mesa-dev] [PATCH] i965/blorp: Rework resolve handling

This commit moves the handling of resolves into blorp_surf_for_miptree(). Instead of each helper doing resolves and checks itself, it simply tells blorp_surf_for_miptree which aux modes are supported by the given blorp operation and blorp_surf_for_miptree will resolve as-needed. Cc: Topi Pohjolain

Re: [Mesa-dev] [PATCH] i965/gen7: Minify blit size for stencil tree copy

Reviewed-by: Jason Ekstrand On Wed, Nov 16, 2016 at 6:42 PM, Jordan Justen wrote: > Found by the piglit 'fbo-depth-array stencil-clear' test when > implementing blorp blit splitting for gen7. > > Signed-off-by: Jordan Justen > Cc: Jason Ekstrand > Reviewed-by: Ben Widawsky > --- > src/mesa/

[Mesa-dev] [PATCH] i965/gen7: Minify blit size for stencil tree copy

Found by the piglit 'fbo-depth-array stencil-clear' test when implementing blorp blit splitting for gen7. Signed-off-by: Jordan Justen Cc: Jason Ekstrand Reviewed-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) dif

[Mesa-dev] [PATCH V2 11b/70] glsl: create gl_program at the start of linking rather than the end

This will allow us to directly store metadata we want to retain in gl_program this metadata is currently stored in gl_linked_shader and will be lost if relinking fails even though the program will remain in use and is still valid according to the spec. "If a program object that is active for any s

[Mesa-dev] [PATCH V2 11a/70] st/mesa/i965: simplify gl_program references and stop leaking

In i965 we were calling _mesa_reference_program() after creating gl_program and then later calling it again will NULL as a param to get the refcount back down to 1. This changes things to not use _mesa_reference_program() at all and just have gl_linked_shader take ownership of gl_program since refc

Re: [Mesa-dev] [PATCH] radv: make sure to flush input attachments correctly.

Reviewed-by: Edward O'Callaghan On 11/17/2016 10:42 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes 9 of the > dEQP-VK.renderpass.attachment_allocation.input_output.* > tests. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 1 + > 1 file changed, 1 inserti

Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

On 2016-11-16 11:25:32, Jason Ekstrand wrote: >On Tue, Nov 15, 2016 at 5:35 PM, Ben Widawsky > wrote: > > From: Ben Widawsky > > When 1 BO is used for aux data, it needs to point to the correct offset, > which will not be the BOs offset but instead an offset from the BOs >

Re: [Mesa-dev] [PATCH] mesa/fbobject: Update CubeMapFace when reusing textures

On 11/16/2016 04:33 PM, Nanley Chery wrote: Framebuffer attachments can be specified through FramebufferTexture* calls. Upon specifying a depth (or stencil) framebuffer attachment that internally reuses a texture, the cube map face of the new attachment would not be updated (defaulting to TEXTURE

[Mesa-dev] [PATCH] radv: make sure to flush input attachments correctly.

From: Dave Airlie This fixes 9 of the dEQP-VK.renderpass.attachment_allocation.input_output.* tests. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index b37

[Mesa-dev] [PATCH] mesa/fbobject: Update CubeMapFace when reusing textures

Framebuffer attachments can be specified through FramebufferTexture* calls. Upon specifying a depth (or stencil) framebuffer attachment that internally reuses a texture, the cube map face of the new attachment would not be updated (defaulting to TEXTURE_CUBE_MAP_POSITIVE_X). Fix this issue by actua

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #15 from Jonathan Gray --- It remains broken here with latest master (a456ea17fb460a68e28c13dd4b7086dc4309f410). Is the fix you are referring to the commit related to microsoft compilers or a different one? Starting program: /usr/X1

Re: [Mesa-dev] [PATCH 11/12] docs: rework/update install.html

Am Mittwoch, 16. November 2016, 22:56:10 CET schrieb Eric Engestrom: > On Wednesday, 2016-11-16 18:46:23 +, Emil Velikov wrote: > > From: Emil Velikov > > > > Still far from perfect, but a few small steps in the right direction. > > > > - Split build systems, compilers, third party tools >

[Mesa-dev] [Bug 98526] glsl/tests/general-ir-test regression

https://bugs.freedesktop.org/show_bug.cgi?id=98526 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 11/12] docs: rework/update install.html

On Wednesday, 2016-11-16 22:56:10 +, Eric Engestrom wrote: > On Wednesday, 2016-11-16 18:46:23 +, Emil Velikov wrote: > > -4. Building for other systems > > +4. Building with AOSP (Android) > > > > > > -Documentation for other environments (some may be very out of date): > > +Currently

Re: [Mesa-dev] [PATCH 11/12] docs: rework/update install.html

On Wednesday, 2016-11-16 18:46:23 +, Emil Velikov wrote: > From: Emil Velikov > > Still far from perfect, but a few small steps in the right direction. > > - Split build systems, compilers, third party tools > - Mention building mesa for Android (part of AOSP) > - Drop explicit "other" de

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #14 from Brian Paul --- (In reply to Jonathan Gray from comment #13) > The "proposed fix" patch attached here does not seem to have been applied to > master yet? A different, better fix was committed and that fixed the assertion. --

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #13 from Jonathan Gray --- The "proposed fix" patch attached here does not seem to have been applied to master yet? -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH 06/12] docs/autoconf: update glx driver / enable-debug text

On Wednesday, 2016-11-16 18:46:18 +, Emil Velikov wrote: > From: Emil Velikov > > With earlier commit we folded all the xlib handling in --enable-glx, but > we forgot to update the documentation. > > Elaborate on --enable-debug and drop mentions about depenencies. > > Signed-off-by: Emil Ve

[Mesa-dev] [PATCH mesa] egl: fix helper function name

I introduced this code last month, but didn't follow the naming convention. Fix this. Fixes: 0a606a400fe382a9bc72 ("egl: add eglSwapBuffersWithDamageKHR") Reviewed-by: Tapani Pälli Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely wrote: > On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: >> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >> 3.9 and older versionsin Clover. This patch restores it and refactors >> the support using Clover compatibility

Re: [Mesa-dev] [PATCH 05/12] docs/repository: refer to Submitting patches

On Wednesday, 2016-11-16 18:46:17 +, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > docs/repository.html | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/repository.html b/docs/repository.html > index 784ae2c..e4731d2 100644

Re: [Mesa-dev] [PATCH 11/70] glsl: create gl_program at the start of linking rather than the end

On Wed, 2016-11-16 at 21:17 +, Emil Velikov wrote: > On 11 November 2016 at 00:45, Timothy Arceri > wrote: > > > > This will allow us to directly store metadata we want to retain in > > gl_program this metadata is currently stored in gl_linked_shader > > and > > will be lost if relinking fail

[Mesa-dev] [PATCH] mesa: Add missing call to _mesa_unlock_debug_state(ctx);

cd724208d3e1e3307f84a794f2c1fc83b69ccf8a added a call to _mesa_lock_debug_state(ctx) but wasn't unlocking the debug state. This fixes a hang in glsl-fs-loop piglit test with MESA_DEBUG=context. --- src/gallium/drivers/radeonsi/si_pipe.c | 8 +--- src/mesa/main/debug_output.c | 5 +++

Re: [Mesa-dev] [PATCH 09/70] st/mesa/r200/i915/i965: move ARB program fields into a union

On Wed, 2016-11-16 at 20:41 +, Emil Velikov wrote: > On 11 November 2016 at 00:45, Timothy Arceri > wrote: > > > > It's common for games to compile 2000 programs or more so at > > > > 32bits x 2000 programs x 22 fields x 2 (at least) stages > > > > This should give us something like 352 kil

Re: [Mesa-dev] [PATCH] mesa: Add missing call to _mesa_unlock_debug_state(ctx); v2

On 11/16/2016 02:30 PM, Tom Stellard wrote: cd724208d3e1e3307f84a794f2c1fc83b69ccf8a added a call to _mesa_lock_debug_state(ctx) but wasn't unlocking the debug state. This fixes a hang in glsl-fs-loop piglit test with MESA_DEBUG=context. v2: - Remove unrelated changes. --- src/mesa/main/de

[Mesa-dev] [PATCH] mesa: Add missing call to _mesa_unlock_debug_state(ctx); v2

cd724208d3e1e3307f84a794f2c1fc83b69ccf8a added a call to _mesa_lock_debug_state(ctx) but wasn't unlocking the debug state. This fixes a hang in glsl-fs-loop piglit test with MESA_DEBUG=context. v2: - Remove unrelated changes. --- src/mesa/main/debug_output.c | 4 +++- 1 file changed, 3 inserti

Re: [Mesa-dev] [PATCH 00/12] docs: split devinfo.html, releasing.html et al.

On 11/16/2016 11:46 AM, Emil Velikov wrote: Hi all, Here's a lovely series that's been baking for a while. Considering format and density (plus how often people read it) I've went ahead and split many things out of devinfo.html. Along the way a few HTML errors were squashed and some extensive r

Re: [Mesa-dev] [PATCH 11/70] glsl: create gl_program at the start of linking rather than the end

On 11 November 2016 at 00:45, Timothy Arceri wrote: > This will allow us to directly store metadata we want to retain in > gl_program this metadata is currently stored in gl_linked_shader and > will be lost if relinking fails even though the program will remain > in use and is still valid accordin

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

On 16.11.2016 16:38, Tom Stellard wrote: On Wed, Nov 16, 2016 at 11:13:45AM +0100, Nicolai Hähnle wrote: Have you looked at the shader-db impact? shader-db is mostly unchanged. There are a few decreases in SGPR usage and code size, and a 4 byte increase in code size for one shader. Okay, i

Re: [Mesa-dev] [PATCH 09/70] st/mesa/r200/i915/i965: move ARB program fields into a union

On 11 November 2016 at 00:45, Timothy Arceri wrote: > It's common for games to compile 2000 programs or more so at > > 32bits x 2000 programs x 22 fields x 2 (at least) stages > > This should give us something like 352 kilobytes in savings. > --- At first I was going to say "sed job", only to noti

Re: [Mesa-dev] [PATCH] mesa: fix empty program log length

On 08/17/2016 01:18 AM, Tapani Pälli wrote: > In case we have empty log (""), we should return 0. This fixes > Khronos WebGL conformance test 'program-infolog'. > > From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: >"If pname is INFO_LOG_LENGTH , the length of the info log, including > a null

Re: [Mesa-dev] [PATCH 08/70] mesa: make use of ralloc when creating ARB program instructions

On 11 November 2016 at 00:45, Timothy Arceri wrote: > This will allow us to move the ARB asm fields in gl_program into > a union as we will be able call ralloc_free() on the entire struct > when destroying the context. > --- > src/mesa/main/ffvertex_prog.c | 7 +++ > src/mesa/program/a

Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

On 16-11-16 11:25:32, Jason Ekstrand wrote: On Tue, Nov 15, 2016 at 5:35 PM, Ben Widawsky wrote: From: Ben Widawsky When 1 BO is used for aux data, it needs to point to the correct offset, which will not be the BOs offset but instead an offset from the BOs offset. Since today there are alway

[Mesa-dev] [Bug 83596] reuse_framebuffer_texture_attachment does not set Layered field

https://bugs.freedesktop.org/show_bug.cgi?id=83596 Nanley Chery changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 08/13] anv/pass: Calculate the combined image usage of attachments

--- src/intel/vulkan/anv_pass.c| 12 +++- src/intel/vulkan/anv_private.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 8d7a43b..897adbd 100644 --- a/src/intel/vulkan/anv_pass.c +++ b/src/intel/vulk

[Mesa-dev] [PATCH 12/13] anv/pipeline: Handle depth/stencil self-dependencies

--- src/intel/vulkan/anv_pass.c | 4 src/intel/vulkan/anv_private.h | 3 +++ src/intel/vulkan/genX_pipeline.c | 30 -- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 897adbd..

[Mesa-dev] [PATCH 07/13] anv: Add an input attachment lowering pass

--- src/intel/vulkan/Makefile.sources | 1 + src/intel/vulkan/anv_nir.h | 2 + src/intel/vulkan/anv_nir_lower_input_attachments.c | 141 + src/intel/vulkan/anv_pipeline.c| 3 + 4 files changed, 147 insertions(+)

[Mesa-dev] [PATCH 13/13] anv: Set up binding tables and surface states for input attachments

This commit adds the last remaining bits to support input attachments in the Intel Vulkan driver. For color and depth attachments, we allocate an input attachment surface state during vkCmdBeginRenderPass like we do for the render target surface states. This is so that we can incorporate the clea

[Mesa-dev] [PATCH 05/13] i965/fs: Implement load_layer_id for fragment shaders

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index e84e371..864f754 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 09/13] anv/pipeline: Add a input_attachment_index to the bindings

This allows us to go from the binding to either the descriptor or the input attachment at will. --- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 27 src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 30 insertions(+) diff --git a/src/intel/v

[Mesa-dev] [PATCH 01/13] compiler: Add the rest of the subpassInput types

There are actually 6 of them according to the GL_KHR_vulkan_glsl spec. --- src/compiler/builtin_type_macros.h | 7 ++- src/compiler/glsl_types.cpp| 20 +++- src/compiler/glsl_types.h | 1 + src/mesa/program/prog_to_nir.c | 1 + 4 files changed, 23 insert

[Mesa-dev] [PATCH 11/13] anv: Use pass attachment information to insert flushes

Input and resolve attachments can cause an implicit dependency in the pipeline. It's our job to insert the needed flushes. Fortunately, we can easily reuse the usage tracking that we use for CCS resolves. --- src/intel/vulkan/anv_blorp.c | 60 1 file

[Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

The lower_input_attachments pass that we're about to add will generate additional uses of system values and we want those to be reflected in gather_info. --- src/intel/vulkan/anv_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/sr

[Mesa-dev] [PATCH 00/13] anv: Implement input attachments

This series adds input attachment support to the Intel Vulkan driver. It applies on top of my series to implement CCS. It can be found here: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=review/anv-input-att Jason Ekstrand (13): compiler: Add the rest of the subpassInput types spirv:

[Mesa-dev] [PATCH 04/13] nir: Add a layer_id system value intrinsic

--- src/compiler/nir/nir_intrinsics.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_intrinsics.h b/src/compiler/nir/nir_intrinsics.h index 00bd294..f45bfe2 100644 --- a/src/compiler/nir/nir_intrinsics.h +++ b/src/compiler/nir/nir_intrinsics.h @@ -328,6 +328,7 @@ SYSTEM_

[Mesa-dev] [PATCH 03/13] spirv: Stop warning about input attachments

--- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 9c5d331..9440341 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -2443,6

[Mesa-dev] [PATCH 02/13] spirv: Handle the InputAttachmentIndex decoration

--- src/compiler/spirv/vtn_private.h | 1 + src/compiler/spirv/vtn_variables.c | 4 2 files changed, 5 insertions(+) diff --git a/src/compiler/spirv/vtn_private.h b/src/compiler/spirv/vtn_private.h index 6f34f09..47579fe 100644 --- a/src/compiler/spirv/vtn_private.h +++ b/src/compiler/spir

[Mesa-dev] [PATCH 10/13] anv/cmd_buffer: Fix pipeline barriers for input attachments

We were using VK_IMAGE_ACCESS_COLOR_ATTACHMENT_READ_BIT to detect an input attachment read. We should use VK_IMAGE_ACCESS_INPUT_ATTACHMENT_READ_BIT instead. --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.

Re: [Mesa-dev] [PATCH] i965: "Fix" aux offsets

On Tue, Nov 15, 2016 at 5:35 PM, Ben Widawsky wrote: > From: Ben Widawsky > > When 1 BO is used for aux data, it needs to point to the correct offset, > which will not be the BOs offset but instead an offset from the BOs > offset. Since today there are always multiple BOs for aux, this doesn't >

[Mesa-dev] [PATCH] vc4: Fix resource leak

Add missed free() CID 1394322 Signed-off-by: Mun Gwan-gyeong --- src/gallium/drivers/vc4/vc4_register_allocate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_register_allocate.c b/src/gallium/drivers/vc4/vc4_register_allocate.c index 72e453a..247467b 100644

[Mesa-dev] [PATCH 10/12] docs: sourcetree.html misc updates

From: Emil Velikov A mixed bag of updates/fixes - mostly aiming at removing no longer applicable directories. Add a few more state-trackers, drivers, etc. alongside "XXX more" where applicable. Attribute for the GLSL/NIR movement and nukage of src/egl/docs. Signed-off-by: Emil Velikov --- doc

[Mesa-dev] [PATCH 02/12] docs: mention/suggest testing your patch against dEQP

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/devinfo.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index c75fa8e..58025e6 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -250,8 +250,9 @@ to update the tes

[Mesa-dev] [PATCH 12/12] docs: recommend using --enable-mangling over the manual -DUSE...

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/contents.html | 2 +- docs/mangling.html | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/contents.html b/docs/contents.html index d2b63a3..c2fe391 100644 --- a/docs/contents.html +++ b/docs/contents.h

[Mesa-dev] [PATCH 11/12] docs: rework/update install.html

From: Emil Velikov Still far from perfect, but a few small steps in the right direction. - Split build systems, compilers, third party tools - Mention building mesa for Android (part of AOSP) - Drop explicit "other" dependencies. Reference to disto methods to get them. - HTML 4.01 Traditiona

[Mesa-dev] [PATCH 06/12] docs/autoconf: update glx driver / enable-debug text

From: Emil Velikov With earlier commit we folded all the xlib handling in --enable-glx, but we forgot to update the documentation. Elaborate on --enable-debug and drop mentions about depenencies. Signed-off-by: Emil Velikov --- docs/autoconf.html | 31 +-- 1 file c

[Mesa-dev] [PATCH 03/12] docs: split Codying style into separate document

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/codingstyle.html | 142 ++ docs/contents.html| 1 + docs/devinfo.html | 128 + 3 files changed, 145 insertions(+), 126 deletions(-) crea

[Mesa-dev] [PATCH 08/12] docs/submittingpatches: fix tags mis/abuse

From: Emil Velikov Fix the odd tag so that we're HTML 4.01 Traditional compliant Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 0ab..9af1cb7

[Mesa-dev] [PATCH 07/12] docs/submittingpatches: flesh out "how to nominate" methods

From: Emil Velikov Currently things are a bit buried within the text, making it harder to find out. Move at the top and be clear what is _not_ a good idea. We had some people consistently using the "bad" way and then being unhappy that their patches were missed/delayed. Cc: Marek Olšák Signed-

[Mesa-dev] [PATCH 09/12] docs: flesh out releasing.html

From: Emil Velikov Properly document the whole process: - Brief on what, when, where - Picking, testing, branchpoints, pre-release announcement - Releasing, announcement, website and bugzilla updates Signed-off-by: Emil Velikov --- docs/devinfo.html | 239 - docs/r

[Mesa-dev] [PATCH 05/12] docs/repository: refer to Submitting patches

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/repository.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/repository.html b/docs/repository.html index 784ae2c..e4731d2 100644 --- a/docs/repository.html +++ b/docs/repository.html @@ -75,7 +75,8 @@ follow

[Mesa-dev] [PATCH 01/12] docs: mention that coding style can differ between drivers

From: Emil Velikov ... and point people to use/honour the EditorConfig/Emacs files, where applicable. Signed-off-by: Emil Velikov --- docs/devinfo.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index afd92fd..c75fa8e 100644 --- a/docs/devin

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

https://bugs.freedesktop.org/show_bug.cgi?id=98691 Daniel Stone changed: What|Removed |Added Product|a big freedesktop.org fly |Mesa |ribbon

[Mesa-dev] [PATCH 04/12] docs: split Submitting Patches into separate document

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/contents.html | 1 + docs/devinfo.html | 285 docs/submittingpatches.html | 309 3 files changed, 310 insertions(+), 285 deletions(-

[Mesa-dev] [PATCH 00/12] docs: split devinfo.html, releasing.html et al.

Hi all, Here's a lovely series that's been baking for a while. Considering format and density (plus how often people read it) I've went ahead and split many things out of devinfo.html. Along the way a few HTML errors were squashed and some extensive releasing.html (et al.) came to be. Let's s

[Mesa-dev] [PATCH 10/20] radeonsi: fix culling if clip & cull distances are used at the same time

From: Marek Olšák Fixed piglits: - arb_cull_distance/clip-cull-3 - arb_cull_distance/clip-cull-4 --- src/gallium/drivers/radeonsi/si_state.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 09/20] radeonsi: clean up si_emit_clip_regs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 24c7b10..683a157 100644 --- a/src/gallium/drivers/radeonsi/si_state.

[Mesa-dev] [PATCH 13/20] radeonsi: simplify checking for monolithic compilation

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 1 + src/gallium/drivers/radeonsi/si_shader.c| 9 + src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++ 4 files changed, 9 insertions(+), 8 delet

[Mesa-dev] [PATCH 17/20] radeonsi: make si_shader_io_get_unique_index stricter

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 14 -- src/gallium/drivers/radeonsi/si_state_shaders.c | 11 ++- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 15/20] radeonsi: add infrastr. for compiling optimized shader variants asynchronously

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 7 ++ src/gallium/drivers/radeonsi/si_state_shaders.c | 136 ++-- 2 files changed, 109 insertions(+), 34 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 06/20] tgsi/scan: use a big switch for scanning outputs

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 68 ++ 1 file changed, 28 insertions(+), 40 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 40a1340..f0dba0b 100644 --- a/src/gallium/a

[Mesa-dev] [PATCH 11/20] radeonsi: split the shader key into 3 logical parts

From: Marek Olšák key->part.*: prolog and epilog flags only key->as_{ls,es}: special flags key->mono.*: flags for monolithic compilation only --- src/gallium/drivers/radeonsi/si_pipe.h | 4 +- src/gallium/drivers/radeonsi/si_shader.c| 194 src/gallium/

[Mesa-dev] [PATCH 12/20] radeonsi: print all flags in si_dump_shader_key

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 4e73d59..c7028de 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gall

[Mesa-dev] [PATCH 20/20] radeonsi: remove all varyings for depth-only rendering or rasterization off

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 2 ++ src/gallium/drivers/radeonsi/si_state_shaders.c | 19 ++- 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 02/20] radeonsi: check for !is_linear in do_hardware_msaa_resolve

From: Marek Olšák We don't want opt4Space here. --- src/gallium/drivers/radeonsi/si_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 075d76a..f5f49c1 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 08/20] radeonsi: assume that a VS without POSITION is LS

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 9e95fea..d0869e3 100644 --- a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 07/20] tgsi/scan: record if a shader writes the position output

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index f0dba0b..84d6456 100644 --- a/src/gallium/auxil

[Mesa-dev] [PATCH 14/20] radeonsi: don't set vs.epilog.export_prim_id if TES is bound

From: Marek Olšák there is no VS epilog in this case --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 9df8f47..7

[Mesa-dev] [PATCH 04/20] radeonsi: fast exit si_emit_derived_tess_state early

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 25 ++--- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.

[Mesa-dev] [PATCH 18/20] radeonsi: record information about all written and read varyings

From: Marek Olšák It's just tgsi_shader_info with DEFAULT_VAL varyings removed. --- src/gallium/drivers/radeonsi/si_shader.c| 22 src/gallium/drivers/radeonsi/si_shader.h| 10 ++-- src/gallium/drivers/radeonsi/si_state_shaders.c | 69 + 3 files ch

  1   2   >