Re: [Mesa-dev] [PATCH 0/4] i965: Fixes and cleanups for intel_syncobj.c

2016-10-04 Thread Iago Toral
For the series: Reviewed-by: Iago Toral Quiroga On Tue, 2016-10-04 at 15:37 -0700, Chad Versace wrote: > I'm preparing to implement EGL_ANDROID_native_fence_sync, and I > wanted > to land these fixes and cleanups before doing the real work. > > Patch 1 is a bugfix. The other patches are cleanups

[Mesa-dev] [PATCH 5/8] i965: get outputs read from nir info

2016-10-04 Thread Timothy Arceri
This is a step towards dropping the GLSL IR version of do_set_program_inouts() in i965 and moving towards native nir support. This is important because we want to eventually convert to nir and use its optimisations passes before we can call this GLSL IR pass. --- src/mesa/drivers/dri/i965/brw_con

[Mesa-dev] [PATCH 7/8] i965: get inputs read from nir info

2016-10-04 Thread Timothy Arceri
This is a step towards dropping the GLSL IR version of do_set_program_inouts() in i965 and moving towards native nir support. This is important because we want to eventually convert to nir and use its optimisations passes before we can call this GLSL IR pass. --- src/mesa/drivers/dri/i965/brw_cur

[Mesa-dev] [PATCH 8/8] i965: remove remaining tabs in brw_draw.c

2016-10-04 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_draw.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index df35651..961aeb8 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++ b/src/

[Mesa-dev] [PATCH 6/8] i965: get outputs written from nir info

2016-10-04 Thread Timothy Arceri
This is a step towards dropping the GLSL IR version of do_set_program_inouts() in i965 and moving towards native nir support. This is important because we want to eventually convert to nir and use its optimisations passes before we can call this GLSL IR pass. --- src/mesa/drivers/dri/i965/brw_gs.

[Mesa-dev] [PATCH 4/8] i965: remove remaining tabs in brw_wm.c

2016-10-04 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_wm.c | 88 +++--- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c index 29dd21e..36b6374 100644 --- a/src/mesa/drivers/dri/i965/brw_wm.c +++ b/

[Mesa-dev] [PATCH 3/8] mesa: remove the UsesDFdy flag

2016-10-04 Thread Timothy Arceri
Seems the last user of this was removed in 08bc74e69. --- src/compiler/glsl/ir_set_program_inouts.cpp | 19 ++- src/mesa/main/mtypes.h | 1 - src/mesa/program/arbprogparse.c | 1 - src/mesa/program/program_parse.y| 2 -- src/mesa/prog

[Mesa-dev] [PATCH 1/8] i965: get uses texture gather from nir info

2016-10-04 Thread Timothy Arceri
This is a step towards dropping the GLSL IR version of do_set_program_inouts() in i965 and moving towards native nir support. This is important because we want to eventually convert to nir and use its optimisations passes before we can call this GLSL IR pass. --- src/mesa/drivers/dri/i965/brw_sha

[Mesa-dev] [PATCH 2/8] i965: get uses discard from nir info

2016-10-04 Thread Timothy Arceri
This is a step towards dropping the GLSL IR version of do_set_program_inouts() in i965 and moving towards native nir support. This is important because we want to eventually convert to nir and use its optimisations passes before we can call this GLSL IR pass. --- src/mesa/drivers/dri/i965/brw_wm.

[Mesa-dev] [Bug 97260] R9 290 low performance in Linux 4.7

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #58 from Michel Dänzer --- (In reply to Alex Deucher from comment #57) > If you can't bisect, does disabling async flips help (see attached patch)? Phoronix was still hitting the bad performance even with the broken drm_mode_page_fli

Re: [Mesa-dev] radv submission 2

2016-10-04 Thread Edward O'Callaghan
On 10/05/2016 01:05 PM, Timothy Arceri wrote: > On Wed, 2016-10-05 at 10:48 +1000, Dave Airlie wrote: >> Again I'm sure this will hit limits, and I've asked Michel to >> drop the big patch before it gets here. >> >> All of these are in a new branch radv-submit2. >> https://github.com/airlied/mesa

[Mesa-dev] [PATCH] winsys/radeon: (trivial) rename variable for consistency

2016-10-04 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- src/gallium/drivers/radeon/radeon_uvd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index fb1491a..81fba95 100644 --- a/src/gallium/drivers/radeon

[Mesa-dev] [PATCH] i965/l3: Add explicit way size calculation for bxt

2016-10-04 Thread Ben Widawsky
There should be no functional change here because Broxton and CHV are both gt1. Without this code however, it might seem like broxton support is missing. While here, put the gt1 check in front to hopefully short-circuit the condition for the mobile cases. Cc: Francisco Jerez Signed-off-by: Ben W

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #12 from Alexander Tsoy --- (In reply to Clément Guérin from comment #11) > Hello, I built mesa 12.0.3 against llvm 3.9.0 on arch linux. Rocket League > and Portal were working properly, however Tomb Raider was crashing right > before

Re: [Mesa-dev] Mesa include guard style. (Was: [PATCH] i965/cfg: Remove redundant #pragma once.)

2016-10-04 Thread Dave Airlie
On 13 March 2016 at 11:29, Ian Romanick wrote: > On 03/11/2016 03:46 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> On 03/10/2016 05:53 PM, Francisco Jerez wrote: Iago Toral writes: > On Wed, 2016-03-09 at 19:04 -0800, Francisco Jerez wrote: >> Matt Turner writes: >

Re: [Mesa-dev] radv submission 2

2016-10-04 Thread Timothy Arceri
On Wed, 2016-10-05 at 10:48 +1000, Dave Airlie wrote: > Again I'm sure this will hit limits, and I've asked Michel to > drop the big patch before it gets here. > > All of these are in a new branch radv-submit2. > https://github.com/airlied/mesa/commits/radv-submit2 > > I've incorporated all the f

Re: [Mesa-dev] [PATCH 05/11] nir: Add a LCSAA-pass

2016-10-04 Thread Timothy Arceri
On Tue, 2016-10-04 at 16:47 -0700, Jason Ekstrand wrote: > On Fri, Sep 16, 2016 at 6:24 AM, Timothy Arceri bora.com> wrote: > > From: Thomas Helland > > > > V2: Do a "depth first search" to convert to LCSSA > > > > V3: Small comment fixup > > > > V4: Rebase, adapt to removal of function overlo

Re: [Mesa-dev] [PATCH] i965/l3: Remove redundant is_cherryview check

2016-10-04 Thread Francisco Jerez
Ben Widawsky writes: > All mobile parts (so far) are GT1. The check added extra confusion > because it appeared Broxton was missing when it wasn't. Replace it with > a comment. > > Alternatively, I'd be willing to add an is_broxton check. > > Cc: Francisco Jerez > Signed-off-by: Ben Widawsky >

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Xu, Randy
Hi, Jason & Tapani Thanks for your review, let me introduce the dEQP failure first. In dEQP-EGL.functional.image.create.gles2_cubemap_negative_*_texture, 2D textures are generated from all 6 faces of a Cubemap texture (64x64), and then rendered through glDrawXXX. In brw_miptree_get_vertical_sli

[Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build (v1.1)

2016-10-04 Thread Dave Airlie
From: Dave Airlie This moves some of the llvm checks around to allow them to be used for non-gallium drivers as well. radv requires llvm 3.9.0 as vulkan requires compute shaders. v1.1: add all make infrastructure to this patch for easier review. Authors: Bas Nieuwenhuizen and Dave Airlie Signe

[Mesa-dev] [PATCH 2/4] radv/winsys: import the amdgpu winsys for the radv vulkan driver. (v1.1)

2016-10-04 Thread Dave Airlie
From: Dave Airlie This just brings these files into the tree, it doesn't integrate them with the build system. The radv winsys is based on the gallium one with some changes, due to how command buffers are built and lack of flushing behaviour. v1.1: cleanup whitespace issues, move Makefiles to o

[Mesa-dev] radv submission 2

2016-10-04 Thread Dave Airlie
Again I'm sure this will hit limits, and I've asked Michel to drop the big patch before it gets here. All of these are in a new branch radv-submit2. https://github.com/airlied/mesa/commits/radv-submit2 I've incorporated all the feedback except two things: a) #pragma once - this is used in lots o

Re: [Mesa-dev] [PATCH] radeonsi: fix texture border colors for compute shaders

2016-10-04 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 10/05/2016 10:51 AM, Marek Olšák wrote: > From: Marek Olšák > > There are VM faults without this. > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/si_compute.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Nanley Chery
On Tue, Oct 04, 2016 at 03:55:13PM -0700, Chad Versace wrote: > On Tue 04 Oct 2016, Nanley Chery wrote: > > On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > > > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand > > > wrote: > > > > > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Cher

Re: [Mesa-dev] [PATCH 1/4] amd/common: add nir->llvm translation.

2016-10-04 Thread Dave Airlie
On 4 October 2016 at 21:05, Emil Velikov wrote: > Hi Dave, > > On 4 October 2016 at 02:48, Dave Airlie wrote: >> From: Bas Nieuwenhuizen >> >> This adds the basic files for the NIR->LLVM translation layer, >> along with some hopefully generic code to load the binary >> result, and other helpers

Re: [Mesa-dev] [PATCH 1/4] amd/common: add nir->llvm translation.

2016-10-04 Thread Dave Airlie
On 4 October 2016 at 20:09, Nicolai Hähnle wrote: > On 04.10.2016 03:48, Dave Airlie wrote: >> >> From: Bas Nieuwenhuizen >> >> This adds the basic files for the NIR->LLVM translation layer, >> along with some hopefully generic code to load the binary >> result, and other helpers required. >> >>

[Mesa-dev] [PATCH] radeonsi: fix texture border colors for compute shaders

2016-10-04 Thread Marek Olšák
From: Marek Olšák There are VM faults without this. Cc: 12.0 --- src/gallium/drivers/radeonsi/si_compute.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 9a5a4a9..1d1df2f 100644 ---

Re: [Mesa-dev] [PATCH 05/11] nir: Add a LCSAA-pass

2016-10-04 Thread Jason Ekstrand
On Fri, Sep 16, 2016 at 6:24 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > From: Thomas Helland > > V2: Do a "depth first search" to convert to LCSSA > > V3: Small comment fixup > > V4: Rebase, adapt to removal of function overloads > > V5: Rebase, adapt to relocation of nir to comp

Re: [Mesa-dev] [PATCH v2 01/13] anv: Use blorp for VkCmdFillBuffer

2016-10-04 Thread Nanley Chery
On Mon, Oct 03, 2016 at 02:22:15PM -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/intel/vulkan/anv_blorp.c | 106 + > src/intel/vulkan/anv_meta_clear.c | 120 > -- > 2 files changed, 96 insertions(

[Mesa-dev] [Bug 98048] Mesa CANNOT use libpthread-stubs

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98048 Ian Romanick changed: What|Removed |Added CC||jfons...@vmware.com, |

[Mesa-dev] [Bug 98048] Mesa CANNOT use libpthread-stubs

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98048 Bug ID: 98048 Summary: Mesa CANNOT use libpthread-stubs Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

2016-10-04 Thread Chad Versace
On Tue 27 Sep 2016, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:14AM -0700, Chad Versace wrote: > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > Create a function that performs one of three HiZ operations - > > > depth/stencil clears, HiZ resolve, and depth resolves. > > > > > > Signed-of

Re: [Mesa-dev] [PATCH] aubinator: use the correct format specifier for printing ptrdiff_t.

2016-10-04 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 3:48 PM, Nanley Chery wrote: > On Mon, Oct 03, 2016 at 04:27:53PM -0700, Jason Ekstrand wrote: > > On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery > wrote: > > > > > From: Chad Versace > > > > > > Nanley Chery: > > > (rebase) > > > - Use isl_surf_get_hiz_surf() > > > (amen

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Chad Versace
On Tue 04 Oct 2016, Nanley Chery wrote: > On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > > > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > > > wrote: > > > > > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Ver

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97952 --- Comment #3 from Timothy Arceri --- I believe its because the ffs param in string.h is an int while the one in bitscan.h is unsigned. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bu

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

2016-10-04 Thread Nanley Chery
On Mon, Oct 03, 2016 at 04:27:53PM -0700, Jason Ekstrand wrote: > On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > > > From: Chad Versace > > > > Nanley Chery: > > (rebase) > > - Use isl_surf_get_hiz_surf() > > (amend) > > - Only add a HiZ surface onto a depth/stencil attachment > > - A

Re: [Mesa-dev] radv initial submission

2016-10-04 Thread Dave Airlie
On 4 October 2016 at 20:47, Albert Freeman wrote: > It might be a good idea to consider moving the nir -> llvm code out of > the amd folder for reuse by a Vulkan software rasterizer or something. > I have heard another developers recent interest in developing a Vulkan > software rasterizer. I at o

[Mesa-dev] [PATCH 2/4] i965/sync: Replace 'intel' prefix with 'brw'

2016-10-04 Thread Chad Versace
This is yet another patch for the great renaming begun long ago. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_syncobj.c | 70 +++ 3 files changed, 37 insertions(+), 37 deletions

[Mesa-dev] [PATCH 3/4] i965/sync: Rename intel_syncobj.c -> brw_sync.c

2016-10-04 Thread Chad Versace
--- src/mesa/drivers/dri/i965/Makefile.sources| 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/{intel_syncobj.c => brw_sync.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename src/mesa/drivers/dri/i965/{intel_syncobj.c

[Mesa-dev] [PATCH 4/4] i965/sync: Rename awkward variable

2016-10-04 Thread Chad Versace
What is the difference between a 'driver_fence' and a 'fence'? Do the characters 'driver_' add anything helpful? Nope. They do, though, add an extra 7 chars and pull your eyeballs away to ask "huh? what's that?" one microsecond too many. --- src/mesa/drivers/dri/i965/brw_sync.c | 12 ++--

[Mesa-dev] [PATCH 0/4] i965: Fixes and cleanups for intel_syncobj.c

2016-10-04 Thread Chad Versace
I'm preparing to implement EGL_ANDROID_native_fence_sync, and I wanted to land these fixes and cleanups before doing the real work. Patch 1 is a bugfix. The other patches are cleanups. This series lives at http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=review/brw-sync-v02 Chad Versace (4): i

[Mesa-dev] [PATCH 1/4] i965/sync: Fix uninitalized usage and leak of mutex

2016-10-04 Thread Chad Versace
We locked an unitialized mutex in the callstack glClientWaitSync intel_gl_client_wait_sync brw_fence_client_wait_sync because we forgot to initialize it in intel_gl_fence_sync. (The EGLSync codepath didn't have this bug. It initialized the mutex in intel_dri_create_sync). We also forgo

[Mesa-dev] [PATCH] gallium/radeon/winsyses: set reasonable max_alloc_size

2016-10-04 Thread Marek Olšák
From: Marek Olšák which is returned for GL_MAX_TEXTURE_BUFFER_SIZE. It doesn't have any other use at the moment. Bigger allocations are not rejected. This fixes GL45-CTS.texture_buffer.texture_buffer_max_size on Bonaire. --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- src/gallium/

[Mesa-dev] [PATCH] ddebug: dump most driver information with GALLIUM_DDEBUG=always

2016-10-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/ddebug/dd_draw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c index 511daf4..970712c 100644 --- a/src/gallium/drivers/ddebug/dd_draw.c +++ b/src/gall

[Mesa-dev] [PATCH 3/4] radeonsi: add assertions to validate interpolation flags

2016-10-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 34 + 1 file changed, 34 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 9662625..f6bd129 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 4/4] radeonsi: fix interpolateAt opcodes for .zw components

2016-10-04 Thread Marek Olšák
From: Marek Olšák Not returning garbage in .zw seems pretty important. This fixes: GL45-CTS.shader_multisample_interpolation.render.interpolate_at_*_check.* Cc: 11.2 12.0 --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/galli

[Mesa-dev] [PATCH 2/4] radeonsi: interpolate colors after interpolation weight shuffling

2016-10-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 96 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 30bf093..590ae64 100644 --- a/src/galli

[Mesa-dev] [PATCH 1/4] tgsi/scan: don't set interp flags for inputs only used by INTERP (v2)

2016-10-04 Thread Marek Olšák
From: Marek Olšák (v1 pushed, then reverted) This fixes 9 randomly failing tests on radeonsi: GL45-CTS.shader_multisample_interpolation.render.interpolate_at_centroid.* v2: use input_interpolate[input] (correct) instead of input_interpolate[index] (incorrect) --- src/gallium/auxiliary/tg

Re: [Mesa-dev] [PATCH 2/6] i965/sync: Stop cacheing fence's signal status

2016-10-04 Thread Chad Versace
On Sun 02 Oct 2016, Kenneth Graunke wrote: > On Tuesday, September 27, 2016 11:51:20 PM PDT Chad Versace wrote: > > Cacheing the signal status complicates the code for questionable > > performance benefit. I added the cacheing long ago, and I now think it > > was the wrong decision. > > > > When w

Re: [Mesa-dev] radv initial submission

2016-10-04 Thread Dave Airlie
> It would have been great if the build/integration bits were properly > split, but I won't sweat too much over it. I thought they were, all the bits outside src/amd are in this patch really. I suppose I could move the Makefile.am and Makefile.sources into this patch to make it easier to review.

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-04 Thread Chad Versace
On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace wrote: > > Pre-patch, there were two code paths for parsing EGLSync attribute > > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, > > and another for new-style EGLAttrib lists, used by eglCr

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-04 Thread Chad Versace
On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace wrote: > > > + if (sizeof(int_list[0]) == sizeof(attrib_list[0])) { > > + attrib_list = (EGLAttrib *) int_list; > > + } else { > > + err = _eglConvertIntsToAttribs(int_list, &attrib_list); > > +

Re: [Mesa-dev] [PATCH] i965/l3: Remove redundant is_cherryview check

2016-10-04 Thread Anuj Phogat
On Tue, Oct 4, 2016 at 1:30 PM, Ben Widawsky wrote: > All mobile parts (so far) are GT1. The check added extra confusion > because it appeared Broxton was missing when it wasn't. Replace it with > a comment. > > Alternatively, I'd be willing to add an is_broxton check. > > Cc: Francisco Jerez > S

[Mesa-dev] [PATCH] i965/l3: Remove redundant is_cherryview check

2016-10-04 Thread Ben Widawsky
All mobile parts (so far) are GT1. The check added extra confusion because it appeared Broxton was missing when it wasn't. Replace it with a comment. Alternatively, I'd be willing to add an is_broxton check. Cc: Francisco Jerez Signed-off-by: Ben Widawsky --- src/intel/common/gen_l3_config.c |

Re: [Mesa-dev] [PATCH 0/2] Enable aubinator to decode a running application

2016-10-04 Thread Gandikota, Sirisha
I like the cleanup of the code and making it more modular. My only comment is please include the patch version number in the subject - I found it very hard to look for the latest version of the patches after other's comments were addressed. Thanks Sirisha >-Original Message- >From: Lio

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97952 --- Comment #2 from Rob Clark --- /me shrugs.. I don't really have a setup for building with clang.. I guess the issue is introduction of #include "bitscan.h" in mtypes.h. Although bitscan.h was already used elsewhere, so not entirely sure why

Re: [Mesa-dev] [PATCH v2] clover: add GetKernelArgInfo (CL 1.2)

2016-10-04 Thread Serge Martin
On Saturday 01 October 2016 15:54:49 Serge Martin wrote: CC curro > --- > src/gallium/state_trackers/clover/api/kernel.cpp | 47 -- > src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++ > src/gallium/state_trackers/clover/core/kernel.hpp | 1 + > src/gallium/state_t

Re: [Mesa-dev] [PATCH v2 0/2] Add support for some of the missing CL1.2 queries

2016-10-04 Thread Serge Martin
On Saturday 01 October 2016 18:51:09 Serge Martin wrote: > Updated serie, please review. CC curro > > Serge Martin (2): > clover: add CL_PROGRAM_BINARY_TYPE support (CL1.2) > clover: add missing clGetDeviceInfo CL1.2 queries > > src/gallium/state_trackers/clover/api/device.cpp | 23 > +++

Re: [Mesa-dev] [PATCH] clover: clGetExtensionFunctionAddressForPlatform

2016-10-04 Thread Serge Martin
On Saturday 01 October 2016 19:03:11 Serge Martin wrote: > On Sunday 27 September 2015 11:15:14 Serge Martin wrote: > > add clGetExtensionFunctionAddressForPlatform (CL 1.2) > > ping (one year reminder :p ) CC curro > > > --- > > > > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-

Re: [Mesa-dev] [PATCH 0/2] clover: clEnqueueMigrateMemObjects

2016-10-04 Thread Serge Martin
On Monday 03 October 2016 19:37:53 Serge Martin wrote: > Ping CC curro > > On Saturday 12 September 2015 21:08:20 Serge Martin wrote: > > Now that mem object can be move back to the host, I think we should latter > > come with a way to optimize read mapping for such objets. For the moment > > if

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Nanley Chery
On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > > wrote: > > > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > >> > On Tue 27 Sep 2016, Nanley Chery wr

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

2016-10-04 Thread Nanley Chery
On Mon, Oct 03, 2016 at 05:23:27PM -0700, Jason Ekstrand wrote: > On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > > > Create a function that performs one of three HiZ operations - > > depth/stencil clears, HiZ resolve, and depth resolves. > > > > Signed-off-by: Nanley Chery > > > > --- >

Re: [Mesa-dev] [PATCH] aubinator: Use less -RS instead of -r for the implicit pager.

2016-10-04 Thread Gandikota, Sirisha
>-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Kenneth Graunke >Sent: Monday, October 03, 2016 5:59 PM >To: mesa-dev@lists.freedesktop.org >Cc: Kenneth Graunke >Subject: [Mesa-dev] [PATCH] aubinator: Use less -RS instead of -r for the >i

Re: [Mesa-dev] [PATCH] glsl: Don't emit ir_binop_carry during ir_binop_imul_high lowering

2016-10-04 Thread Ilia Mirkin
On Tue, Oct 4, 2016 at 2:08 PM, Ian Romanick wrote: > From: Ian Romanick > > st_glsl_to_tgsi only calls lower_instructions once (instead of in a > loop), so the ir_binop_carry generated would not get lowered. Fixes > assertion failure > > state_tracker/st_glsl_to_tgsi.cpp:2265: void > glsl_to_t

Re: [Mesa-dev] [PATCH] intel/blorp: Use documented RECTLIST vertex positions

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 10:33 AM, Marek Olšák wrote: > On Wed, Sep 21, 2016 at 11:42 PM, Nanley Chery > wrote: > > Use the vertex positions described in the PRMs. This has no effect on > > rendering but quiets the simulator warnings seen when the vertices > > appear out of order. > > Does it mean

[Mesa-dev] [PATCH] glsl: Don't emit ir_binop_carry during ir_binop_imul_high lowering

2016-10-04 Thread Ian Romanick
From: Ian Romanick st_glsl_to_tgsi only calls lower_instructions once (instead of in a loop), so the ir_binop_carry generated would not get lowered. Fixes assertion failure state_tracker/st_glsl_to_tgsi.cpp:2265: void glsl_to_tgsi_visitor::visit_expression(ir_expression*, st_src_reg*): Asserti

[Mesa-dev] [Bug 98042] Git master fails to build with clang++/libc++ on Linux

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98042 Vinson Lee changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97952 Vinson Lee changed: What|Removed |Added CC||kre...@email.com --- Comment #1 from Vinson

Re: [Mesa-dev] [PATCH] util: use GCC atomic intrinsics with explicit memory model

2016-10-04 Thread Nicolai Hähnle
On 04.10.2016 17:50, Jan Vesely wrote: On Tue, 2016-10-04 at 16:14 +0200, Nicolai Hähnle wrote: From: Nicolai Hähnle This is motivated by the fact that p_atomic_read and p_atomic_set may somewhat surprisingly not do the right thing in the old version: while stores and loads are de facto atomic

Re: [Mesa-dev] [PATCH] intel/blorp: Use documented RECTLIST vertex positions

2016-10-04 Thread Marek Olšák
On Wed, Sep 21, 2016 at 11:42 PM, Nanley Chery wrote: > Use the vertex positions described in the PRMs. This has no effect on > rendering but quiets the simulator warnings seen when the vertices > appear out of order. Does it mean that the vertex order doesn't matter for the hardware?? Marek ___

Re: [Mesa-dev] [PATCH] aubinator: use the correct format specifier for printing ptrdiff_t.

2016-10-04 Thread Anuj Phogat
On Tue, Oct 4, 2016 at 10:01 AM, Kenneth Graunke wrote: > Fixes more warnings in 32-bit builds. > > Signed-off-by: Kenneth Graunke > --- > src/intel/tools/aubinator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.

[Mesa-dev] [PATCH] aubinator: use the correct format specifier for printing ptrdiff_t.

2016-10-04 Thread Kenneth Graunke
Fixes more warnings in 32-bit builds. Signed-off-by: Kenneth Graunke --- src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9b32e5b..27d7647 100644 --- a/src/intel/tools/aubinator.c +++ b

Re: [Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

2016-10-04 Thread Ben Widawsky
On 16-10-04 09:50:55, Kenneth Graunke wrote: On Tuesday, October 4, 2016 9:26:39 AM PDT Ben Widawsky wrote: On 16-10-04 15:38:52, Lionel Landwerlin wrote: >Embed the xml files into the binary, so aubinator can be used from any >location. > >Signed-off-by: Lionel Landwerlin >Cc: Sirisha Gandikot

Re: [Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

2016-10-04 Thread Kenneth Graunke
On Tuesday, October 4, 2016 9:26:39 AM PDT Ben Widawsky wrote: > On 16-10-04 15:38:52, Lionel Landwerlin wrote: > >Embed the xml files into the binary, so aubinator can be used from any > >location. > > > >Signed-off-by: Lionel Landwerlin > >Cc: Sirisha Gandikota > >--- > > src/intel/Makefile.am

Re: [Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Ben Widawsky
On 16-10-04 15:38:53, Lionel Landwerlin wrote: In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota Cc: Kristian Høgsberg --- sr

Re: [Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Ben Widawsky
On 16-10-04 16:03:28, Lionel Landwerlin wrote: On 04/10/16 16:01, Eero Tamminen wrote: Hi, On 04.10.2016 17:38, Lionel Landwerlin wrote: In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_g

Re: [Mesa-dev] Mesa 12.1.0 release plan (Was Re: Next Mesa release, anyone?)

2016-10-04 Thread Axel Davy
On 04/10/2016 12:32, Emil Velikov wrote: On 2 October 2016 at 14:17, Axel Davy wrote: Hi, If I understand, there hasn't been yet statements on whether the freeze is for Oct 7 or Oct 14. Could there be one ? I'd prefer myself Oct 14, because we have a lot of patches for nine, and they deserv

Re: [Mesa-dev] Mesa 12.1.0 release plan (Was Re: Next Mesa release, anyone?)

2016-10-04 Thread Emil Velikov
On 4 October 2016 at 15:57, Rob Herring wrote: > On Tue, Oct 4, 2016 at 5:26 AM, Emil Velikov wrote: >> On 4 October 2016 at 02:05, Rob Clark wrote: >>> On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov >>> wrote: On 28 September 2016 at 19:53, Marek Olšák wrote: > Hi, > > It's

Re: [Mesa-dev] [PATCH] intel/blorp: Use documented RECTLIST vertex positions

2016-10-04 Thread Ben Widawsky
Reviewed-by: Ben Widawsky On 16-10-04 08:03:05, Jason Ekstrand wrote: Reviewed-by: Jason Ekstrand On Wed, Sep 21, 2016 at 2:42 PM, Nanley Chery wrote: Use the vertex positions described in the PRMs. This has no effect on rendering but quiets the simulator warnings seen when the vertices ap

Re: [Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

2016-10-04 Thread Ben Widawsky
On 16-10-04 15:38:52, Lionel Landwerlin wrote: Embed the xml files into the binary, so aubinator can be used from any location. Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/Makefile.am | 1 + src/intel/Makefile.aubinator.am | 36 +++ src/intel/Makef

Re: [Mesa-dev] [PATCH] util: use GCC atomic intrinsics with explicit memory model

2016-10-04 Thread Emil Velikov
On 4 October 2016 at 15:14, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is motivated by the fact that p_atomic_read and p_atomic_set may > somewhat surprisingly not do the right thing in the old version: while > stores and loads are de facto atomic at least on x86, the compiler may > ap

Re: [Mesa-dev] [PATCH 4/5] intel: aubinator: generate a standalone binary

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 8:59 AM, Lionel Landwerlin wrote: > Embed the xml files into the binary, so aubinator can be used from any > location. > > v2: Split generation packing into another patch (Jason) > Check for xxd (Jason) > > Signed-off-by: Lionel Landwerlin > Cc: Sirisha Gandikota > --

Re: [Mesa-dev] [PATCH 1/5] intel: aubinator: pack supported generations into an array

2016-10-04 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Oct 4, 2016 at 8:59 AM, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > Cc: Sirisha Gandikota > --- > src/intel/tools/aubinator.c | 79 +- > --- > 1 file changed, 30 insertions(+), 49 deletions(-) > > d

Re: [Mesa-dev] [PATCH 4/5] intel: aubinator: generate a standalone binary

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 8:59 AM, Lionel Landwerlin wrote: > Embed the xml files into the binary, so aubinator can be used from any > location. > > v2: Split generation packing into another patch (Jason) > Check for xxd (Jason) > > Signed-off-by: Lionel Landwerlin > Cc: Sirisha Gandikota > --

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 8:55 AM, Tapani Pälli wrote: > On 10/04/2016 06:09 PM, Jason Ekstrand wrote: > > On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy wrote: > >> Add the miptree level/slice x/y_offset when count the surface offset >> in brw_emit_surface_state. The surface offset has two parts, one

[Mesa-dev] [PATCH 5/5] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Lionel Landwerlin
In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app v2: Add print_help() comment about standard input handling (Eero) Remove shrinked gtt space debug workaround (Eero) Signed-off-by:

[Mesa-dev] [PATCH 2/5] intel: aubinator: add missing return characters

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 4e2cafa..9939de7 100644 --- a/src/intel/tools/aubinator.c +++ b/sr

[Mesa-dev] [PATCH 3/5] intel: aubinator: retain input file in its own variable

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9939de7..459e3d4 100644 --- a/src/intel/tools/aubinator.c +++ b/src/inte

[Mesa-dev] [PATCH 4/5] intel: aubinator: generate a standalone binary

2016-10-04 Thread Lionel Landwerlin
Embed the xml files into the binary, so aubinator can be used from any location. v2: Split generation packing into another patch (Jason) Check for xxd (Jason) Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- configure.ac| 1 + src/intel/Makefile.am

[Mesa-dev] [PATCH 1/5] intel: aubinator: pack supported generations into an array

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 79 + 1 file changed, 30 insertions(+), 49 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9b32e5b..4e2cafa 100644 --- a

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Tapani Pälli
On 10/04/2016 06:09 PM, Jason Ekstrand wrote: On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy > wrote: Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which

Re: [Mesa-dev] [PATCH] util: use GCC atomic intrinsics with explicit memory model

2016-10-04 Thread Jan Vesely
On Tue, 2016-10-04 at 16:14 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is motivated by the fact that p_atomic_read and p_atomic_set may > somewhat surprisingly not do the right thing in the old version: > while > stores and loads are de facto atomic at least on x86, afaik, this

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Jason Ekstrand
On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy wrote: > Add the miptree level/slice x/y_offset when count the surface offset > in brw_emit_surface_state. The surface offset has two parts, one is > from mt->offset, which should be 32 aligned in width/height for tiled > buffer; another is from mt->leve

[Mesa-dev] [Bug 97260] R9 290 low performance in Linux 4.7

2016-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #57 from Alex Deucher --- Created attachment 126995 --> https://bugs.freedesktop.org/attachment.cgi?id=126995&action=edit disable async flip support If anyone else is seeing a regression not already fixed, please bisect and open a

[Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs (v2)

2016-10-04 Thread Chuck Atkins
This fixes a problem where GL headers would only get installed if glx was enabled. So if osmesa was enabled but not glx, then the GL headers required by osmesa would be missing from the install. v2: Dropped unneeded mesa_glinterop.h redundant osmesa.h install CC: Emil Velikov Signed-off-by: Chu

Re: [Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Lionel Landwerlin
On 04/10/16 16:01, Eero Tamminen wrote: Hi, On 04.10.2016 17:38, Lionel Landwerlin wrote: In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Maybe you could add also a patch to docu

Re: [Mesa-dev] [PATCH] intel/blorp: Use documented RECTLIST vertex positions

2016-10-04 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Sep 21, 2016 at 2:42 PM, Nanley Chery wrote: > Use the vertex positions described in the PRMs. This has no effect on > rendering but quiets the simulator warnings seen when the vertices > appear out of order. > > Signed-off-by: Nanley Chery > Cc: Jason Ekstr

Re: [Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Eero Tamminen
Hi, On 04.10.2016 17:38, Lionel Landwerlin wrote: In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Maybe you could add also a patch to document this usage? Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 7:38 AM, Lionel Landwerlin wrote: > Embed the xml files into the binary, so aubinator can be used from any > location. > Thank you for doing this!!! Dynamically loading the xml has a few benefits, but I think the benefits of not having to find them on disk are far bigger.

  1   2   >