I like the cleanup of the code and making it more modular. My only comment is please include the patch version number in the subject - I found it very hard to look for the latest version of the patches after other's comments were addressed.
Thanks Sirisha >-----Original Message----- >From: Lionel Landwerlin [mailto:llandwer...@gmail.com] >Sent: Tuesday, October 04, 2016 7:39 AM >To: mesa-dev@lists.freedesktop.org >Cc: Landwerlin, Lionel G <lionel.g.landwer...@intel.com>; Kristian Høgsberg ><k...@bitplanet.net>; Gandikota, Sirisha <sirisha.gandik...@intel.com>; Ben >Widawsky <b...@bwidawsk.net>; Kenneth Graunke <kenn...@whitecape.org> >Subject: [PATCH 0/2] Enable aubinator to decode a running application > >Hi, > >Discussing with Kristian about ksim the other week, it came up that it would be >interesting to be able to look at an application's output while it's running. >The end >goal being that we could remove some hand written code from the driver >(brw_state_dump.c) and have more complete output. > >This series enables aubinator to decode its standard input like it would with >normal aubdump file. > >This change requires a slight modification to intel_aubdump (so it sets up the >communication between the running application and aubinator) : > >https://patchwork.freedesktop.org/patch/113618/ > >Looking forward to comments from Ben and Kenneth who seem to rely a fair bit >on brw_state_dump. > >Cheers, > >Lionel Landwerlin (2): > intel: aubinator: generate a standalone binary > intel: aubinator: enable loading dumps from standard input > > src/intel/Makefile.am | 1 + > src/intel/Makefile.aubinator.am | 36 ++++++ > src/intel/Makefile.sources | 7 ++ > src/intel/tools/.gitignore | 5 + > src/intel/tools/aubinator.c | 253 ++++++++++++++++++++++++++-------------- > src/intel/tools/decoder.c | 82 ++++++++----- > src/intel/tools/decoder.h | 4 +- > 7 files changed, 268 insertions(+), 120 deletions(-) create mode 100644 >src/intel/Makefile.aubinator.am > >-- >2.9.3 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
