Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On 09/28/2016 12:19 AM, Ian Romanick wrote: On 09/26/2016 12:41 AM, Tapani Pälli wrote: This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test and same crash in many dEQP EGL tests. I also found that some Qt example did a workaround because of this crash: https://bugreports.qt.io/bro

[Mesa-dev] [PATCH 4/6] i965/sync: Replace 'intel' prefix with 'brw'

'intel' is s yesterday ;) This is yet another patch for the great renaming begun long ago. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_syncobj.c | 70 +++ 3 files changed,

Re: [Mesa-dev] [PATCH 88/88] i965: handle 32bit and 64bit version of shader cache objects

On Sun, 2016-09-25 at 19:51 -0700, Kenneth Graunke wrote: > On Saturday, September 24, 2016 3:26:09 PM PDT Timothy Arceri wrote: > > > > Pointers will have different lengths so we simple create a > > different > > sha1 for each platform. > > I don't understand...you're putting pointers in the blo

[Mesa-dev] [PATCH 0/6] i965/sync: Fix dEQP-EGL.functional.gles2.multithread.*

Test results of dEQP-EGL.functional.gles2.multithread.* on Skylake, using deqp-egl directly (no Piglit): * Before: Bajillions of failures and randomly occuring crashes. The testrun died on me on 10/10 tries. * After: Passed:1253/1254 (99.9%) Failed:

[Mesa-dev] [PATCH 6/6] i965/sync: Rename awkward variable

What is the difference between a 'driver_fence' and a 'fence'? Do the characters 'driver_' add anything helpful? Nope. They do, though, add an extra 7 chars and pull your eyeballs away to ask "huh? what's that?" one microsecond too many. --- src/mesa/drivers/dri/i965/brw_sync.c | 12 ++--

[Mesa-dev] [PATCH 5/6] i965/sync: Rename intel_syncobj.c -> brw_sync.c

--- src/mesa/drivers/dri/i965/Makefile.sources| 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/{intel_syncobj.c => brw_sync.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename src/mesa/drivers/dri/i965/{intel_syncobj.c

[Mesa-dev] [PATCH 1/6] i965/sync: Fix uninitalized usage and leak of mutex

We locked an unitialized mutex in the callstack glClientWaitSync intel_gl_client_wait_sync brw_fence_client_wait_sync because we forgot to initialize it in intel_gl_fence_sync. (The EGLSync codepath didn't have this bug. It initialized the mutex in intel_dri_create_sync). We also forgo

[Mesa-dev] [PATCH 2/6] i965/sync: Stop cacheing fence's signal status

Cacheing the signal status complicates the code for questionable performance benefit. I added the cacheing long ago, and I now think it was the wrong decision. When we later add support for fences based on sync fds (that is, a fd backed by struct sync_file in Linux 4.8), the cacheing becomes even

[Mesa-dev] [PATCH 3/6] i965/sync: Fold brw_fence_has_completed() into caller

The function is tiny and called exactly once. There's no need for it. --- src/mesa/drivers/dri/i965/intel_syncobj.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_syncobj.c b/src/mesa/drivers/dri/i965/intel_syncobj.c

[Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

Pre-patch, there were two code paths for parsing EGLSync attribute lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, and another for new-style EGLAttrib lists, used by eglCreateSync (1.5) and eglCreateSync64 (EGL_KHR_cl_event2). There were two attrib_list parsing functions, _

[Mesa-dev] [PATCH 2/7] egl: Fix truncation error in _eglParseSyncAttribList64

The function stores EGLAttrib values in EGLint variables. On 64-bit systems, this truncated the values. Cc: mesa-sta...@lists.freedesktop.org --- src/egl/main/eglsync.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c index

[Mesa-dev] [PATCH 1/7] egl: Fix missing unlock in eglGetSyncAttribKHR

On the error path, eglGetSyncAttribKHR neglected to unlock the EGLDisplay before returning. Fixes deadlock in dEQP-EGL.functional.fence_sync.invalid.get_invalid_value. Cc: mesa-sta...@lists.freedesktop.org Cc: Mark Janes --- src/egl/main/eglapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[Mesa-dev] [PATCH 6/7] egl: Drop duplicate check on EGLSync type

_eglInitSync checked that the display supported the sync type (such as EGL_SYNC_FENCE), and did it wrong. When the check failed it emitted EGL_BAD_ATTRIBUTE, but sometimes EGL_BAD_PARAMETER is needed. _eglCreateSync already does the error checking, and it does it right. --- src/egl/main/eglsync.c

[Mesa-dev] [PATCH 5/7] egl: Cleanup control flow in _eglParseSyncAttribList

When the function encountered an error, it effectively returned immediately. However, it did so indirectly by breaking out of a loop. Replace the loop breakout with a explicit 'return'. Do the same for _eglParseSyncAttribList64 too. --- src/egl/main/eglsync.c | 14 -- 1 file changed,

[Mesa-dev] [PATCH 0/7] egl: Fixes and cleanups for EGLSync

Fixes a deadlock in dEQP-EGL.functional.fence_sync.invalid.get_invalid_value. With the deadlock fixed, it's now possible to run all of 'dEQP-EGL.functional.fence_sync.*'. The patch series' main goal is to unify the attribute parsing between eglCreateSyncKHR(..., EGLint *attrib_list) and e

[Mesa-dev] [PATCH 4/7] egl: Add _eglConvertIntsToAttribs()

This function converts an attribute list from EGLint[] to EGLAttrib[]. Will be used in following patches to cleanup EGLSync attribute parsing. --- src/egl/main/eglapi.c | 41 + src/egl/main/eglapi.h | 2 ++ 2 files changed, 43 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH 3/7] egl: Fix an error path in eglCreateSync*

When the user called eglCreateSync64KHR on a display without EGL_KHR_cl_event2 (the only extension that exposes it), we returned EGL_NO_SYNC but did not update the error code. We also did the same for eglCreateSync on a display without EGL 1.5. --- src/egl/main/eglapi.c | 14 -- 1 fil

[Mesa-dev] [PATCH 5/5] glsl: remove remaining tabs from ast_type.cpp

--- src/compiler/glsl/ast_type.cpp | 39 --- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index f3f6b29..b586f94 100644 --- a/src/compiler/glsl/ast_type.cpp +++ b/src/compiler/gls

[Mesa-dev] [PATCH 4/5] glsl: remove remaining tabs from ast_to_hir.cpp

--- src/compiler/glsl/ast_to_hir.cpp | 78 1 file changed, 38 insertions(+), 40 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 9de8454..2ad97d9 100644 --- a/src/compiler/glsl/ast_to_hir.cpp +++ b/src/com

[Mesa-dev] [PATCH 1/5] glsl: remove tabs from linker.{cpp,h}

--- src/compiler/glsl/linker.cpp | 807 +-- src/compiler/glsl/linker.h | 8 +- 2 files changed, 407 insertions(+), 408 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 290811f..e6b2231 100644 --- a/src/compiler

[Mesa-dev] [PATCH 2/5] glsl: remove tabs from ast_expr.cpp

--- src/compiler/glsl/ast_expr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_expr.cpp b/src/compiler/glsl/ast_expr.cpp index e624d11..1fd5b6e 100644 --- a/src/compiler/glsl/ast_expr.cpp +++ b/src/compiler/glsl/ast_expr.cpp @@ -79,7 +79,7 @@ ast_expre

[Mesa-dev] [PATCH 3/5] glsl: remove remaining tabs from ast_array_index.cpp

--- src/compiler/glsl/ast_array_index.cpp | 73 +-- 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/src/compiler/glsl/ast_array_index.cpp b/src/compiler/glsl/ast_array_index.cpp index 2e36035..e29dafb 100644 --- a/src/compiler/glsl/ast_array_index.c

Re: [Mesa-dev] [PATCH] gallium/r300: initialize pipe_resource::next to NULL

On 28/09/16 12:33 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > I had a scan through the rest of pipe_resource allocations, and I think > this is the only remaining one (besides r600_alloc_buffer_struct()) > which was using MALLOC_STRUCT().. sorry 'bout that Note that the MALLOC_STRUCT

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #30 from Michel Dänzer --- (In reply to Eero Tamminen from comment #20) > Apitrace's own CPU overhead is so high that it's not very good for > identifying CPU bottlenecks. That may be true in general, but taking a CPU profile while r

Re: [Mesa-dev] [PATCH v3] HUD: Add support for block I/O, network I/O and lmsensor stats

On 09/27/2016 05:17 PM, Steven Toth wrote: On Fri, Sep 23, 2016 at 12:19 PM, Brian Paul wrote: Hi Steven, I did a more thorough review per your request... Thank you Brian. All of your suggestions have been implemented, and new patches pushed to the ML. Were you planning on squashing the t

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: On 27/09/16 16:48, Andy Furniss wrote: Ok, thanks, so with that I am back to where I was before it stopped working. In summary baseline works but JM ref decoder doesn't like the pocs. b frames don't work properly, but then they don't with gst vaapi either. They do work wi

Re: [Mesa-dev] [PATCH v3] HUD: Add support for block I/O, network I/O and lmsensor stats

On Fri, Sep 23, 2016 at 12:19 PM, Brian Paul wrote: > Hi Steven, > > I did a more thorough review per your request... Thank you Brian. All of your suggestions have been implemented, and new patches pushed to the ML. ...with the exception of one, primarily because I wanted to comment. >> +#if H

Re: [Mesa-dev] [PATCH] i965: Remove useless (harmful) assertion

On Tue, Sep 27, 2016 at 3:02 PM, Ben Widawsky wrote: > From: Ben Widawsky > > The code already skips doing the depth stall on gen >= 8, and as we > enable new platforms this assertion will fail needlessly. Instead of > changing the caller, make this simple change. > > Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

On Tue, Sep 27, 2016 at 11:00:14AM -0700, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > Create a function that performs one of three HiZ operations - > > depth/stencil clears, HiZ resolve, and depth resolves. > > > > Signed-off-by: Nanley Chery > > > > --- > > > > v2. Add do

[Mesa-dev] [PATCH 2/2] HUD: Add support for block I/O, network I/O and lmsensor stats

V5: Feedback based on peer review convert sprintf to snprintf convert char * to const char * int arg converted to bool Func changes to take a filename vs a larger struct. omit the space between '*' and the param name. Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_diskstat.c

[Mesa-dev] [PATCH 1/2] HUD: Add support for block I/O, network I/O and lmsensor stats

V4: Merged with master as of 2016/9/27 6pm V3: Flatten the entire patchset ready for the ML V2: Additional seperate patches based on feedback a) configure.ac: Add a comment related to libsensors b) HUD: Disable Block/NIC I/O stats by default. Implement configuration option --enable-gallium-extra

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > On Tue 27 Sep 2016, Nanley Chery wrote: > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > > As a consequence of that reasoning, we should set > > > 3DSTATE_CLEAR_PARAMS.DepthClearValueValid = 1 > > > whenever h

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Tue 27 Sep 2016, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > As a consequence of that reasoning, we should set > > 3DSTATE_CLEAR_PARAMS.DepthClearValueValid = 1 > > whenever hiz is enabled, even if we don't care about the actual clear value. > > In

[Mesa-dev] [PATCH] i965: Remove useless (harmful) assertion

From: Ben Widawsky The code already skips doing the depth stall on gen >= 8, and as we enable new platforms this assertion will fail needlessly. Instead of changing the caller, make this simple change. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +- 1 file

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > From: Nanley Chery > > > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > > demos. > > > > Clears that happen within a render pass via vkCmdClearAttachments ar

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Vedran Miletić changed: What|Removed |Added Depends on|97917 | Referenced Bugs: https://bugs.freede

Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On 09/26/2016 12:41 AM, Tapani Pälli wrote: > This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test > and same crash in many dEQP EGL tests. > > I also found that some Qt example did a workaround because of this > crash: https://bugreports.qt.io/browse/QTBUG-47509 Eh... I would have t

Re: [Mesa-dev] [PATCH V2 09/11] genX/cmd_buffer: Enable rendering to HiZ

On Tue, Sep 27, 2016 at 11:00:06AM -0700, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > From: Chad Versace > > > > Nanley Chery: > > (rebase) > > - Resolve conflicts with new anv_batch_emit macro > > (amend) > > - Handle a QPitch TODO > > - Emit 3DSTATE_HIER_DEPTH_BUFFER on

[Mesa-dev] [PATCH] nvc0: update GM107 sched control codes format

envyas now uses a much better representation for those control codes and it displays the different flags instead of an unreadable hex number. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/lib/gm107.asm | 42 +++ src/gallium/drivers/nouveau/nvc0/nvc0_s

Re: [Mesa-dev] [PATCH v3 8/8] intel/isl: Allow non-2D HiZ surfaces

On Sep 27, 2016 10:10 AM, "Nanley Chery" wrote: > > On Tue, Sep 27, 2016 at 09:22:05AM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > This patch is > Reviewed-by: Nanley Chery That's all of them. Feel free to pu

Re: [Mesa-dev] [PATCH v3 00/14] add support for ARB_compute_variable_group_size

On 26.09.2016 19:23, Samuel Pitoiset wrote: v3: - use a new case statement in r600_pipe_common.c - fix compilation with softpipe - initialize max_variable_threads_per_block to 0 I have sent some remarks on patches 2 and 4. Patches 1, 3, 5-11: Reviewed-by: Nicolai Hähnle v2: - updat

Re: [Mesa-dev] [PATCH v3 04/14] glsl: process local_size_variable input qualifier

On 26.09.2016 19:23, Samuel Pitoiset wrote: This is the new layout qualifier introduced by ARB_compute_variable_group_size which allows to use a variable work group size. Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- src/compiler/glsl/ast.h | 5 + src/comp

Re: [Mesa-dev] [PATCH v3 1/6] nv50/ir: add preliminary support for SHLADD

Reviewed-by: Ilia Mirkin On Tue, Sep 27, 2016 at 2:55 PM, Samuel Pitoiset wrote: > This instruction is available since SM20 (Fermi) and allow to do > (a << b) + c in one shot. In some situations, IMAD should be > replaced by SHLADD when b is a power of 2, and ADD+SHL should be > replaced by SHLA

Re: [Mesa-dev] [PATCH v3 02/14] mesa/main: add support for ARB_compute_variable_groups_size

On 26.09.2016 19:23, Samuel Pitoiset wrote: v2: - update formatting spec quotations (Ian) - move the total_invocations check outside of the loop (Ian) Signed-off-by: Samuel Pitoiset --- src/mesa/main/api_validate.c | 96 src/mesa/main/api_valida

[Mesa-dev] [PATCH v3 2/6] nvc0/ir: add emission for SHLADD

Unfortunately, we can't use the emit helpers for GF100/GK110 because src1 and src2 are swapped. v3: - remove useless use of src1 neg mod v2: - s/emitSHLADD/emitISCADD for GM107 emitter Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 52 +++

Re: [Mesa-dev] [PATCH v3 2/6] nvc0/ir: add emission for SHLADD

Reviewed-by: Ilia Mirkin On Tue, Sep 27, 2016 at 2:57 PM, Samuel Pitoiset wrote: > Unfortunately, we can't use the emit helpers for GF100/GK110 > because src1 and src2 are swapped. > > v3: - remove useless use of src1 neg mod > v2: - s/emitSHLADD/emitISCADD for GM107 emitter > > Signed-off-by: S

[Mesa-dev] [PATCH v3 1/6] nv50/ir: add preliminary support for SHLADD

This instruction is available since SM20 (Fermi) and allow to do (a << b) + c in one shot. In some situations, IMAD should be replaced by SHLADD when b is a power of 2, and ADD+SHL should be replaced by SHLADD as well. v3: - fix neg flag - remove isFloatType() in isOpSupported() - teach is

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #29 from Silvan Jegen --- (In reply to Micael Bergeron from comment #28) > I asked Psyonix for the debug symbols bug had no response. > http://psyonix.com/forum/viewtopic.php?f=36&t=27894 Maybe you can add a link to this bug report o

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

On 27/09/16 16:48, Andy Furniss wrote: > Ok, thanks, so with that I am back to where I was before it stopped working. > > In summary baseline works but JM ref decoder doesn't like the pocs. > > b frames don't work properly, but then they don't with gst vaapi either. They > do work with gst omx.

[Mesa-dev] [PATCH] swr: Removed stalling SwrWaitForIdle from queries.

Previous fundamental change in stats gathering added a temporary SwrWaitForIdle to begin_query and end_query. Code has been reworked to remove stall. --- src/gallium/drivers/swr/swr_context.cpp | 33 +++ src/gallium/drivers/swr/swr_context.h | 11 ++- src/gallium/drivers/swr/swr_query.cpp

[Mesa-dev] [PATCH 1/6] util/slab: re-design to allow migration between pools

From: Nicolai Hähnle This is basically a re-write of the slab allocator into a design where multiple child pools are linked to a parent pool. The intention is that every (GL, pipe) context has its own child pool, while the corresponding parent pool is held by the winsys or screen, or possibly the

[Mesa-dev] [PATCH 4/6] freedreno: use the new parent/child pools for transfers

From: Nicolai Hähnle --- src/gallium/drivers/freedreno/freedreno_context.c | 5 ++--- src/gallium/drivers/freedreno/freedreno_context.h | 2 +- src/gallium/drivers/freedreno/freedreno_resource.c | 4 ++-- src/gallium/drivers/freedreno/freedreno_screen.c | 4 src/gallium/drivers/freedren

[Mesa-dev] [PATCH 6/6] virgl: use the new parent/child pools for transfers

From: Nicolai Hähnle --- src/gallium/drivers/virgl/virgl_buffer.c | 4 ++-- src/gallium/drivers/virgl/virgl_context.c | 5 ++--- src/gallium/drivers/virgl/virgl_context.h | 2 +- src/gallium/drivers/virgl/virgl_screen.c | 4 src/gallium/drivers/virgl/virgl_screen.h | 3 +++ src/gallium/d

[Mesa-dev] [PATCH 3/6] r300: use the new parent/child pools for transfers

From: Nicolai Hähnle --- src/gallium/drivers/r300/r300_context.c | 5 ++--- src/gallium/drivers/r300/r300_context.h | 2 +- src/gallium/drivers/r300/r300_screen.c| 3 +++ src/gallium/drivers/r300/r300_screen.h| 2 ++ src/gallium/drivers/r300/r300_screen_buffer.c | 4 +

[Mesa-dev] [PATCH 0/6] Fix map/unmaps from different contexts

Hi all, it can happen that a buffer that is mapped from one context ends up being unmapped in another one. I found nothing in the spec to forbid it, and in any case it's a scenario that people are increasingly likely to run into with persistent maps and multiple contexts. This leads to crashes in

[Mesa-dev] [PATCH 2/6] gallium/radeon: use the new parent/child pools for transfers

From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97894 --- src/gallium/drivers/radeon/r600_buffer_common.c | 4 ++-- src/gallium/drivers/radeon/r600_pipe_common.c | 9 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++- 3 files changed, 11 insertions(

[Mesa-dev] [PATCH 5/6] vc4: use the new parent/child pools for transfers

From: Nicolai Hähnle --- src/gallium/drivers/vc4/vc4_context.c | 5 ++--- src/gallium/drivers/vc4/vc4_context.h | 2 +- src/gallium/drivers/vc4/vc4_resource.c | 4 ++-- src/gallium/drivers/vc4/vc4_screen.c | 3 +++ src/gallium/drivers/vc4/vc4_screen.h | 3 +++ 5 files changed, 11 insertion

Re: [Mesa-dev] [PATCH V2 09/11] genX/cmd_buffer: Enable rendering to HiZ

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Resolve conflicts with new anv_batch_emit macro > (amend) > - Handle a QPitch TODO > - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems > - Only use HiZ for single-subpass renderpasses > - Emit the

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

On Mon 26 Sep 2016, Nanley Chery wrote: > Create a function that performs one of three HiZ operations - > depth/stencil clears, HiZ resolve, and depth resolves. > > Signed-off-by: Nanley Chery > > --- > > v2. Add documentation > Fix the alignment check > Don't minify clear rectangle (Ja

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Use isl_surf_get_hiz_surf() > (amend) > - Only add a HiZ surface onto a depth/stencil attachment > - Add comment above HiZ surface addition > - Hide HiZ behind INTEL_VK_HIZ prior to BDW > - Disable

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Nanley Chery > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > demos. > > Clears that happen within a render pass via vkCmdClearAttachments are safe > even if the clear color changes. This is because the meta implement

Re: [Mesa-dev] [PATCH V2 07/11] anv/image: Memset hiz surfaces to 0 when binding memory

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Jason Ekstrand > > Nanley Chery (amend): > - Change memset value from 0xff to 0 (a defined value for HiZ). > > Signed-off-by: Nanley Chery > > --- > > v2. Add asserts (Jason) > Handle NULL return value of the mmap Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH v3 8/8] intel/isl: Allow non-2D HiZ surfaces

On Tue, Sep 27, 2016 at 09:22:05AM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 749d228..9735d26 100644 > --- a/src

Re: [Mesa-dev] [PATCH v3 4/8] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

On Tue, Sep 27, 2016 at 09:22:01AM -0700, Jason Ekstrand wrote: > HiZ buffers can be multisampled and, on Broadwell and earlier, simply using > interleaved multisampling with a compression block size of 8x4 samples > yields the correct HiZ surface size calculations. Unfortunately, > choose_msaa_la

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

https://bugs.freedesktop.org/show_bug.cgi?id=97952 Bug ID: 97952 Summary: /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration Product: Mesa Version: git

Re: [Mesa-dev] [PATCH v3 3/8] intel/isl: Allow creation of 1-D compressed textures

On Tue, Sep 27, 2016 at 09:22:00AM -0700, Jason Ekstrand wrote: > Compressed 1-D textures are not well-defined thing in either GL or Vulkan. > However, auxiliary surfaces are treated as compressed textures in ISL and > we can do HiZ and CCS with 1-D so we need to be able to create them. In > order

[Mesa-dev] [PATCH v3 4/8] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

HiZ buffers can be multisampled and, on Broadwell and earlier, simply using interleaved multisampling with a compression block size of 8x4 samples yields the correct HiZ surface size calculations. Unfortunately, choose_msaa_layout was rejecting multisampled HiZ buffers because of format checks. N

[Mesa-dev] [PATCH v3 2/8] intel/isl: Fix up asserts in calc_phys_level0_extent_sa

The assertion that a format is uncompressed in the multisample layouts isn't quite right. What we really want to assert is that the format supports multisampling which is a bit more complicated query. We also want to assert that it has a block size of 1x1 since we do nothing with the block size i

[Mesa-dev] [PATCH v3 8/8] intel/isl: Allow non-2D HiZ surfaces

--- src/intel/isl/isl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 749d228..9735d26 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1346,11 +1346,11 @@ isl_surf_get_hiz_surf(const struct isl_device *dev,

[Mesa-dev] [PATCH v3 6/8] intel/isl: Remove tiling checks from choose_msaa_layout

We already do those checks in filter_tiling. There's no good reason to repeat them in choose_msaa_layout. If anything they should have been asserts and not "return false" checks. Also, this check was causing us to outright reject multisampled HiZ surfaces which wasn't intended. Signed-off-by: J

[Mesa-dev] [PATCH v3 3/8] intel/isl: Allow creation of 1-D compressed textures

Compressed 1-D textures are not well-defined thing in either GL or Vulkan. However, auxiliary surfaces are treated as compressed textures in ISL and we can do HiZ and CCS with 1-D so we need to be able to create them. In order to prevent actually using them (the docs say no), we assert in the stat

[Mesa-dev] [PATCH v3 7/8] intel/isl: Add a detailed comment about multisampling with HiZ

Signed-off-by: Jason Ekstrand Reviewed-by: Chad Versace Reviewed-by: Nanley Chery --- src/intel/isl/isl.c | 60 +++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ee5330e..749d228 1

[Mesa-dev] [PATCH v3 5/8] intel/isl: Handle HiZ and CCS tiling more directly

The HiZ and CCS tiling formats are always used for HiZ and CCS surfaces respectively. There's no reason why we should go through filter_tiling and it's much easier to always get HiZ and CCS right if we just handle them directly. Signed-off-by: Jason Ekstrand Reviewed-by: Topi Pohjolainen Review

[Mesa-dev] [PATCH v3 1/8] intel/isl: Add a format_supports_multisampling helper

Signed-off-by: Jason Ekstrand Reviewed-by: Chad Versace Reviewed-by: Nanley Chery --- src/intel/isl/isl.h| 2 ++ src/intel/isl/isl_format.c | 28 src/intel/isl/isl_gen6.c | 19 +-- src/intel/isl/isl_gen7.c | 16 +--- src/inte

Re: [Mesa-dev] [PATCH v4 3/7] intel/isl: Allow creation of 1-D compressed textures

On Fri, Sep 23, 2016 at 9:52 AM, Nanley Chery wrote: > On Fri, Sep 23, 2016 at 12:17:19AM -0700, Jason Ekstrand wrote: > > Compressed 1-D textures are not well-defined thing in either GL or > Vulkan. > > However, auxiliary surfaces are treated as compressed textures in ISL and > > we can do HiZ a

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #28 from Micael Bergeron --- I can reproduce this every time. Using amdgpu-pro seems to fix the problem. I asked Psyonix for the debug symbols bug had no response. http://psyonix.com/forum/viewtopic.php?f=36&t=27894 I opened a bug

Re: [Mesa-dev] [PATCH] egl: use unsigned int index when iterating over attrib_list

On 27 September 2016 at 16:18, Eric Engestrom wrote: > On Tue, Sep 27, 2016 at 04:10:53PM +0200, Nicolai Hähnle wrote: >> On 27.09.2016 14:40, Emil Velikov wrote: >> > From: Emil Velikov >> > >> > Otherwise one can overflow the signed variable and (attempt to) cause >> > all sorts of strange beha

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: On 27/09/16 00:49, Andy Furniss wrote: Mark Thompson wrote: --- A simple fix to the problem described here: . With this applied, the driver no longer hangs/crashes when vaSyncSurface() is called

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #27 from Eero Tamminen --- (In reply to Silvan Jegen from comment #22) > Created attachment 126796 [details] > perf report of RocketLeague stalling/freezing Overview: - 74.86% RocketLeague 76.73%

Re: [Mesa-dev] [PATCH] gallium/r300: initialize pipe_resource::next to NULL

Reviewed-by: Marek Olšák Marek On Tue, Sep 27, 2016 at 5:33 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > I had a scan through the rest of pipe_resource allocations, and I think > this is the only remaining one (besides r600_alloc_buffer_struct()) > which was using MALLOC_STRUCT()..

[Mesa-dev] [PATCH] gallium/r300: initialize pipe_resource::next to NULL

Signed-off-by: Rob Clark --- I had a scan through the rest of pipe_resource allocations, and I think this is the only remaining one (besides r600_alloc_buffer_struct()) which was using MALLOC_STRUCT().. sorry 'bout that src/gallium/drivers/r300/r300_screen_buffer.c | 1 + 1 file changed, 1 inse

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #26 from Silvan Jegen --- I generated the report and uploaded the result. I may have hit a bug in perf while doing it. "perf report" was blocking on a pread64 call on /dev/dri/card0 when creating the report. I had to use gdb to close

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #25 from Silvan Jegen --- Created attachment 126813 --> https://bugs.freedesktop.org/attachment.cgi?id=126813&action=edit perf report of RocketLeague stalling/freezing, including callgraphs -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH] egl: use unsigned int index when iterating over attrib_list

On Tue, Sep 27, 2016 at 04:10:53PM +0200, Nicolai Hähnle wrote: > On 27.09.2016 14:40, Emil Velikov wrote: > > From: Emil Velikov > > > > Otherwise one can overflow the signed variable and (attempt to) cause > > all sorts of strange behaviour. > > As long as we're worrying about such things, sho

Re: [Mesa-dev] st/omx/dec/h265: Correct the timestamping (derived from commit 3b6bda665a5a890f2c98e19d2939d7de92b8cb4c)

On 27 September 2016 at 13:13, Christian König wrote: > Hi Indrajit, > > please send this patch once more as text mail. I can't commit it like this. > Having a commit message is strongly recommended. A fixes and/or stable tag would be even better :-) Thanks Emil __

[Mesa-dev] [PATCH 1/2] gallium/radeon/winsyses: add radeon_winsys::min_alloc_size

From: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 4 3 files changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src

[Mesa-dev] [PATCH 2/2] gallium/radeon: use smaller buffers for query results

From: Nicolai Hähnle Most of the time, even the 512 bytes that we now get is more than sufficient (pipeline stats queries are the largest at 184 bytes per shot). --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ra

Re: [Mesa-dev] [RFC 1/7] eglplatform.h: introduce and use EGL_USE_PLATFORM_*_KHR

On 25 September 2016 at 00:17, Eric Engestrom wrote: > On Thu, Sep 22, 2016 at 09:38:06AM +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> In order to avoid the current, somewhat fragile detection in >> eglplatform.h introduce explicit platform selection. >> >> The approach is based on the

Re: [Mesa-dev] [PATCH] egl: use unsigned int index when iterating over attrib_list

On 27.09.2016 14:40, Emil Velikov wrote: From: Emil Velikov Otherwise one can overflow the signed variable and (attempt to) cause all sorts of strange behaviour. As long as we're worrying about such things, shouldn't it really be a size_t then? With that, Reviewed-by: Nicolai Hähnle Chee

Re: [Mesa-dev] st/omx/dec/h265: Correct the timestamping (derived from commit 3b6bda665a5a890f2c98e19d2939d7de92b8cb4c)

Hi Indrajit, please send this patch once more as text mail. I can't commit it like this. Regards, Christian. Am 20.09.2016 um 13:48 schrieb Das, Indrajit-kumar: From: Indrajit Das Reviewed-by: Christian König Reviewed-by: Nishanth Peethambaran Signed-off-by: Indrajit Das --- src/gall

[Mesa-dev] [PATCH] egl: use unsigned int index when iterating over attrib_list

From: Emil Velikov Otherwise one can overflow the signed variable and (attempt to) cause all sorts of strange behaviour. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/main/eglconfig.c| 3 ++- src/egl/main/eglcontext.c | 3 ++- src/egl/main/egldis

[Mesa-dev] [PATCH] glx: don't expose systemTimeExtension for DRI2/DRI3/DRISW

Used/applicable to only dri1 drivers. Signed-off-by: Emil Velikov --- If anyone wants to go ahead and start moving the DRI1 only functionality to src/glx/dri[1] that'll be appreciated. --- src/glx/dri2_glx.c | 2 -- src/glx/dri3_glx.c | 1 - src/glx/drisw_glx.c | 1 - 3 files changed, 4 deleti

Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On Tue, Sep 27, 2016 at 2:34 PM, Emil Velikov wrote: > On 26 September 2016 at 08:41, Tapani Pälli wrote: >> This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test >> and same crash in many dEQP EGL tests. >> >> I also found that some Qt example did a workaround because of this >> cras

Re: [Mesa-dev] [PATCH] gallium/radeon: Initialize pipe_resource::next to NULL

Reviewed-by: Marek Olšák Marek On Tue, Sep 27, 2016 at 11:18 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes lots of piglit tests crashing due to using uninitialized memory. > > Fixes: ecd6fce2611e ("mesa/st: support lowering multi-planar YUV") > Signed-off-by: Michel Dänzer > --- >

Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On 26 September 2016 at 08:41, Tapani Pälli wrote: > This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test > and same crash in many dEQP EGL tests. > > I also found that some Qt example did a workaround because of this > crash: https://bugreports.qt.io/browse/QTBUG-47509 > > Signed-off

Re: [Mesa-dev] [PATCH] v2 st/va Avoid VBR bitrate calculation overflow

Am 27.09.2016 um 12:42 schrieb Emil Velikov: On 26 September 2016 at 14:35, Christian König wrote: Am 26.09.2016 um 11:44 schrieb Andy Furniss: VBR bitrate calc needs 64 bits at high rates. v2 use float. Signed-off-by: Andy Furniss Reviewed-by: Christian König . Since Leo is on vacation I

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

I just pushed the patch for now cause this is really a rather obvious bugfix. Please keep digging thinks like this up. Thanks for the help, Christian. Am 27.09.2016 um 02:18 schrieb Mark Thompson: On 27/09/16 00:49, Andy Furniss wrote: Mark Thompson wrote: --- A simple fix to the problem de

Re: [Mesa-dev] [PATCH] v2 st/va Avoid VBR bitrate calculation overflow

On 26 September 2016 at 14:35, Christian König wrote: > Am 26.09.2016 um 11:44 schrieb Andy Furniss: >> >> VBR bitrate calc needs 64 bits at high rates. >> v2 use float. >> >> Signed-off-by: Andy Furniss > > > Reviewed-by: Christian König . > > Since Leo is on vacation I will probably collect all

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 Alexander Tsoy changed: What|Removed |Added CC||alexan...@tsoy.me bastian.beisc...@rwth

Re: [Mesa-dev] [PATCH 5/5] st/omx/dec/h265: fix the skip for before and after list

On 23 September 2016 at 17:32, Leo Liu wrote: > Should not be skipped when rps->used false > Please 'translate' "rps->used false" to English ? Also one might want to mention if the patch/es fix any known issue - bugzilla, fixes "jerky" playback, etc. Afaict 3-5 are bugfixes so please add a bit mo

  1   2   >