On Fri, Sep 23, 2016 at 12:19 PM, Brian Paul <bri...@vmware.com> wrote:
> Hi Steven,
>
> I did a more thorough review per your request...
Thank you Brian.
All of your suggestions have been implemented, and new patches pushed to the ML.
...with the exception of one, primarily because I wanted to comment.
>> +#if HAVE_LIBSENSORS
>> + else if (sscanf(name, "sensors_temp_cu-%s", arg_name) == 1) {
>> + hud_sensors_temp_graph_install(pane, &name[16],
>
>
> What's the significance of name[16]? Should that be a #define ?
Everything after the hyphen is essentially its unique sensor name,
prior to the hyphen is a routing string that tells mesa HUD us to use
the lmsensor HUD module, rather than say... the disk stats module.
So 16, is the length of "sensors_temp_cu-" and we pass the remainder
into the sensor specific initializer func - which is all it cares
about.
I'm happy to implement whatever the project recommends, so are you
suggesting instead:
#define SOMEPREFIX "sensors_temp_cu-"
then
hud_sensors_temp_graph_install(pane, &name[sizeof(SOMEPREFIX - 1)]
Or, have I misunderstood your comment?
Thanks again.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
