Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 14, 2016 at 11:58 PM, Dave Airlie wrote: > From: Dave Airlie > > This reverts commit d180de35320eafa3df3d76f0e82b332656530126. > > This is a radeon specific hack that causes problems on nouveau > when combined with the SHARED flag later. If radeonsi needs a fix > for this, please fix

[Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-09-14 Thread Dave Airlie
From: Dave Airlie This reverts commit d180de35320eafa3df3d76f0e82b332656530126. This is a radeon specific hack that causes problems on nouveau when combined with the SHARED flag later. If radeonsi needs a fix for this, please fix it in the driver. Signed-off-by: Dave Airlie --- src/gallium/st

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Dave Airlie
On 15 September 2016 at 13:03, Ilia Mirkin wrote: > On Wed, Sep 14, 2016 at 10:15 PM, Michel Dänzer wrote: >>> No, the current impl is pretty radeon-specific (note - it doesn't work >>> on nouveau, and no other drivers support the interfaces, so ... it's >>> radeon-specific). >> >> We're getting

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-14 Thread Romain Failliot
2016-09-13 13:53 GMT-04:00 Marek Olšák : > LLVM 32-bit: > > mkdir -p build32 > cd build32 > cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/i386-linux-gnu > -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=ON > -DCMAKE_BUILD_TYPE=RelWithDebInfo > -DLLVM_BUILD_LLVM_

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 14, 2016 at 10:15 PM, Michel Dänzer wrote: >> No, the current impl is pretty radeon-specific (note - it doesn't work >> on nouveau, and no other drivers support the interfaces, so ... it's >> radeon-specific). > > We're getting into semantics here, but since the reason it doesn't work

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 14, 2016 at 10:15 PM, Michel Dänzer wrote: >> This shouldn't be too hard - just make the compositor output to a temporary >> surface before copying things out to the prime-shareable one. > > You mean something like https://patchwork.freedesktop.org/patch/110375/ ? Something like that,

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Michel Dänzer
On 15/09/16 11:01 AM, Ilia Mirkin wrote: > On Wed, Sep 14, 2016 at 9:42 PM, Michel Dänzer wrote: >> On 15/09/16 08:20 AM, Ilia Mirkin wrote: >>> On Wed, Sep 7, 2016 at 12:06 PM, Marek Olšák wrote: On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: > On Wed, Sep 7, 2016 at 4:08 AM, Miche

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 14, 2016 at 9:42 PM, Michel Dänzer wrote: > On 15/09/16 08:20 AM, Ilia Mirkin wrote: >> On Wed, Sep 7, 2016 at 12:06 PM, Marek Olšák wrote: >>> On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: > On 07/09/16 04:19 AM, Ch

Re: [Mesa-dev] [PATCH] st/vdpau: remove nouveau target

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 14, 2016 at 9:52 PM, Ilia Mirkin wrote: > Recent changes have been made to the VDPAU state tracker to make it > unusable with nouveau. Don't provide users with an awfully slow > "hardware" decoding option. > > [To preemptively answer the question that will invariably be asked - > this

[Mesa-dev] [PATCH] st/vdpau: remove nouveau target

2016-09-14 Thread Ilia Mirkin
Recent changes have been made to the VDPAU state tracker to make it unusable with nouveau. Don't provide users with an awfully slow "hardware" decoding option. [To preemptively answer the question that will invariably be asked - this is due to the state tracker's use of PIPE_BIND_SHARED, which nou

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-14 Thread Michel Dänzer
On 14/09/16 07:41 PM, Marek Olšák wrote: > On Wed, Sep 14, 2016 at 5:26 AM, Michel Dänzer wrote: >> On 14/09/16 02:53 AM, Marek Olšák wrote: >>> >>> cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu >>> -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=O >>>

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Michel Dänzer
On 15/09/16 08:20 AM, Ilia Mirkin wrote: > On Wed, Sep 7, 2016 at 12:06 PM, Marek Olšák wrote: >> On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: >>> On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: > Am 06.09.2016 um 21:05 schrieb Ili

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #49 from Michel Dänzer --- Seems like there are various different issues at play here. The bottom line is: Don't expect your issue to get fixed without bisecting it. -- You are receiving this mail because: You are the assignee for t

Re: [Mesa-dev] [PATCH] mesa: Expose RESET_NOTIFICATION_STRATEGY with KHR_robustness.

2016-09-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Sep 14, 2016 at 8:47 PM, Kenneth Graunke wrote: > This is supposed to be exposed with the GL_KHR_robustness extension, > which we support on ES 2.0 and later. On desktop GL, it's also exposed > by GL_ARB_robustness, which is supported by all drivers ("dummy_true

[Mesa-dev] [PATCH] mesa: Expose RESET_NOTIFICATION_STRATEGY with KHR_robustness.

2016-09-14 Thread Kenneth Graunke
This is supposed to be exposed with the GL_KHR_robustness extension, which we support on ES 2.0 and later. On desktop GL, it's also exposed by GL_ARB_robustness, which is supported by all drivers ("dummy_true"). so we also allow desktop GL. Fixes: - ES32-CTS.robust.robustness.noResetNotification

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #48 from alvarex --- edit: It's from september the 6th not from the 7th. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ me

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #47 from alvarex --- *edit* I get 50 fps we newer kernel 4.8rc5; with kernel 4.8rc5 and Mesa 12.0.2 the performance is the same. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for th

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #45 from Clésio Luiz --- Padoka PPA finally updated, version 2.1~git1600912162600.546bc07~x~padoka0. Here the bug continues. This time a take the time to test in various games. Valve's Source Engine take less hit by this bug, only ab

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-14 Thread Ilia Mirkin
On Wed, Sep 7, 2016 at 12:06 PM, Marek Olšák wrote: > On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: >> On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: >>> On 07/09/16 04:19 AM, Christian König wrote: Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: > On Tue, Sep 6, 2016 at 2:22 PM,

[Mesa-dev] [PATCH v2] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

2016-09-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: adjust typedef in vdpau_dmabuf.h, per Nayan src/gallium/include/state_tracker/vdpau_dmabuf.h | 2 +- src/gallium/state_trackers/vdpau/output.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/include/state_tracker

Re: [Mesa-dev] [PATCH] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

2016-09-14 Thread Nayan Deshmukh
Hi Ilia, You also need to change the arguments in gallium/include/st/vdpau_dmabuf.h. Regards, Nayan. On Thu, Sep 15, 2016 at 3:56 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/state_trackers/vdpau/output.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Mesa-dev] [PATCH] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

2016-09-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/state_trackers/vdpau/output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c index 85751ea..f4d62a3 100644 --- a/src/gallium/state_trackers/vdpau/

[Mesa-dev] [PATCH 1/3] i965/reg: Make brw_sr0_reg take a subnr and return a vec1 reg

2016-09-14 Thread Jason Ekstrand
The state register sr0 is really a collection of dwords not a SIMD8 anything. It's much more convenient for brw_sr0_reg to return the particular dword you're looking for rather than a giant blob you have to massage into what you want. Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 2/3] i965/fs: Take Dispatch/Vector mask into account in FIND_LIVE_CHANNEL

2016-09-14 Thread Jason Ekstrand
On at least Sky Lake, ce0 does not contain the full story as far as enabled channels goes. It is possible to have completely disabled channels where the corresponding bits in ce0 are 1. In order to get the correct execution mask, you have to mask off those channels which were disabled from the be

[Mesa-dev] [PATCH 3/3] i965/vec4: Always use the predicated MOV path for FIND_LIVE_CHANNEL

2016-09-14 Thread Jason Ekstrand
The old method of looking at ce0 assumed that the enabled channels are tightly packed. There is no documentation that guarantees this, however, so it's a bit dangerous to assume it. In any case, the predicated MOV implementation was only 2 instructions so it's not that bad to just use that all th

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

2016-09-14 Thread Anuj Phogat
On Wed, Sep 14, 2016 at 1:31 PM, Jason Ekstrand wrote: > > > On Wed, Sep 14, 2016 at 1:29 PM, Anuj Phogat wrote: >> >> On Wed, Sep 14, 2016 at 10:45 AM, Jason Ekstrand >> wrote: >> > From the ARB_gpu_shader5 spec: >> > >> >The built-in functions interpolateAtCentroid() and >> > interpolateAt

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

2016-09-14 Thread Jason Ekstrand
On Wed, Sep 14, 2016 at 1:29 PM, Anuj Phogat wrote: > On Wed, Sep 14, 2016 at 10:45 AM, Jason Ekstrand > wrote: > > From the ARB_gpu_shader5 spec: > > > >The built-in functions interpolateAtCentroid() and > interpolateAtSample() > >will sample variables as though they were declared with

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

2016-09-14 Thread Anuj Phogat
On Wed, Sep 14, 2016 at 10:45 AM, Jason Ekstrand wrote: > From the ARB_gpu_shader5 spec: > >The built-in functions interpolateAtCentroid() and interpolateAtSample() >will sample variables as though they were declared with the "centroid" >or "sample" qualifiers, respectively. > > When r

[Mesa-dev] [PATCH v3 3/7] intel/isl: Add support for 1-D compressed textures

2016-09-14 Thread Jason Ekstrand
Compressed 1-D textures are a well-defined thing in both GL and Vulkan. v2: Fix some asserts (Nanley) Signed-off-by: Jason Ekstrand --- src/intel/isl/isl.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index a75fddf..7

Re: [Mesa-dev] [PATCH v2 3/7] intel/isl: Add support for 1-D compressed textures

2016-09-14 Thread Jason Ekstrand
On Wed, Sep 14, 2016 at 11:10 AM, Nanley Chery wrote: > On Mon, Sep 12, 2016 at 05:58:20PM -0700, Jason Ekstrand wrote: > > Compressed 1-D textures are a well-defined thing in both GL and Vulkan. > > --- > > src/intel/isl/isl.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > >

[Mesa-dev] [PATCH] nv50/ir: drop unused NVISA_XXX_CHIPSET constants

2016-09-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h index 58a5d38..e85b5fa 100644 --- a/src/gallium

[Mesa-dev] [PATCH] nvc0: allow to force compiling programs in debug build

2016-09-14 Thread Samuel Pitoiset
This adds a new envvar called NOUVEAU_FORCE_CHIPSET which allows to compile shaders with a different target, especially useful for shader-db. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions

[Mesa-dev] [PATCH] gallium/util: make use of strtol() in debug_get_num_option()

2016-09-14 Thread Samuel Pitoiset
This allows to use hexadecimal numbers which are automatically detected by strtol() when the base is 0. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/util/u_debug.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/gallium/auxiliary/uti

Re: [Mesa-dev] [PATCH] intel/aubinator: Properly handle batch buffer chaining

2016-09-14 Thread Gandikota, Sirisha
aubinator.c: In function ‘parse_commands’: aubinator.c:768:19: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses] if (p[0] & (1 << 22) == 0) -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Jason Ekstra

Re: [Mesa-dev] [PATCH] aubinator: add a custom handler for immediate register load

2016-09-14 Thread Gandikota, Sirisha
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Lionel Landwerlin Sent: Friday, September 09, 2016 3:26 AM To: mesa-dev@lists.freedesktop.org Cc: Landwerlin, Lionel G Subject: [Mesa-dev] [PATCH] aubinator: add a custom handler for immediate

Re: [Mesa-dev] [PATCH v2 3/7] intel/isl: Add support for 1-D compressed textures

2016-09-14 Thread Nanley Chery
On Mon, Sep 12, 2016 at 05:58:20PM -0700, Jason Ekstrand wrote: > Compressed 1-D textures are a well-defined thing in both GL and Vulkan. > --- > src/intel/isl/isl.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index a75

[Mesa-dev] [PATCH 3/3] glx/glvnd: Use bsearch() in FindGLXFunction instead of open-coding it

2016-09-14 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxglvnd.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c index 2fc9b00..b6b4151 100644 --- a/src/glx/glxglvnd.c +++ b/src/glx/glxglvnd.c @@ -1,11 +1,11 @@ #inclu

[Mesa-dev] [PATCH 2/3] glx/glvnd: Fix dispatch function names and indices

2016-09-14 Thread Adam Jackson
As this array was not actually sorted, FindGLXFunction's binary search would only sometimes work. Signed-off-by: Adam Jackson --- src/glx/g_glxglvnddispatchfuncs.c | 254 ++-- src/glx/g_glxglvnddispatchindices.h | 36 ++--- 2 files changed, 144 insertions(+), 1

Re: [Mesa-dev] [PATCH] glvnd: Fix dynamic GLX entrypoint lookup

2016-09-14 Thread Adam Jackson
On Mon, 2016-09-05 at 11:23 +0100, Eric Engestrom wrote: > > +static int > > +compare(const void *l, const void *r) > > +{ > > +const char *s = *(const char **)r; > > Shouldn't we do the same with `l`? No. 'l' is the key we're looking for (the function name), r is the current element of the a

[Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

2016-09-14 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxglvnd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c index 098304d..2fc9b00 100644 --- a/src/glx/glxglvnd.c +++ b/src/glx/glxglvnd.c @@ -50,6 +50,9 @@ static void __glXGLVNDSetDispatchIndex(const GLubyte

[Mesa-dev] [PATCH 3/4] i965/fs: Use NIR for handling forced per-sample interpolation

2016-09-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 40 +++- src/mesa/drivers/dri/i965/brw_nir.c | 9 ++-- src/mesa/drivers/dri/i965/brw_nir.h | 3 ++- 3 files changed, 12 insertions(+), 40 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/d

[Mesa-dev] [PATCH 4/4] i965/nir: Roll set_default_interpolation into lower_fs_inputs

2016-09-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 40 +--- src/mesa/drivers/dri/i965/brw_nir.c | 24 ++ src/mesa/drivers/dri/i965/brw_nir.h | 1 + 3 files changed, 26 insertions(+), 39 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 2/4] nir: Add a flag to lower_io to force "sample" interpolation

2016-09-14 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 10 +- src/compiler/nir/nir_lower_io.c | 20 ++-- src/gallium/drivers/freedreno/ir3/ir3_cmdline.c | 2 +- src/intel/blorp/blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_nir.c

[Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

2016-09-14 Thread Jason Ekstrand
From the ARB_gpu_shader5 spec: The built-in functions interpolateAtCentroid() and interpolateAtSample() will sample variables as though they were declared with the "centroid" or "sample" qualifiers, respectively. When running with persample dispatch forced by the API, we interpolate anyt

Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-14 Thread Nicholas Bishop
Thanks for review. Could someone with commit access push this for me? On Wed, Sep 14, 2016 at 8:48 AM, Eric Engestrom wrote: > On Thu, Sep 08, 2016 at 03:55:02PM -0400, Nicholas Bishop wrote: >> Changed dri2_query_image to check the return value of >> resource_get_handle and return GL_FALSE if an

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 --- Comment #5 from raffa...@zoho.com --- Created attachment 126522 --> https://bugs.freedesktop.org/attachment.cgi?id=126522&action=edit LoL 32 bit - decoration + shadows (radeonsi gallium nine) -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH 00/14] EGL_KHR_debug v3

2016-09-14 Thread Adam Jackson
On Tue, 2016-09-13 at 17:30 +0100, Emil Velikov wrote: > Everything else (1-12 incl.) is > Reviewed-by: Emil Velikov Merged these, thanks. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/m

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 --- Comment #4 from raffa...@zoho.com --- Created attachment 126521 --> https://bugs.freedesktop.org/attachment.cgi?id=126521&action=edit LoL 32 bit - bush (radeonsi gallium nine) -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 --- Comment #3 from Christoph Haag --- Also artifacts in native csgo: https://www.youtube.com/watch?v=pMBz2grTAQg -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 --- Comment #2 from raffa...@zoho.com --- (In reply to Ilia Mirkin from comment #1) > Any particular driver? Gallium Nine on radeonsi -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 --- Comment #1 from Ilia Mirkin --- Any particular driver? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-d

[Mesa-dev] [Bug 97808] "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97808 Bug ID: 97808 Summary: "tgsi/scan: don't set interp flags for inputs only used by INTERP instructions" causes glitches in wine with gallium nine Product: Mesa Ver

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-09-14 Thread Kyle Brenneman
This looks right to me. -Kyle On 09/14/2016 07:59 AM, Adam Jackson wrote: From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Kyle Brenneman
Note that the primary object can still be meaningful even on a function that's defined to never throw an error. Those functions could still send a WARN or INFO level message if they had reason to, just not a CRITICAL or ERROR level. Until any of those are added to Mesa, though, it's an academic

[Mesa-dev] [PATCH mesa] glsl: grammar fix

2016-09-14 Thread Eric Engestrom
From: Eero Tamminen Signed-off-by: Eero Tamminen Reviewed-by: Eric Engestrom --- Eero, this is the format a patch should have when sent to mesa-dev. You can find more info on our website [1], but the gist of it is: - Use `git send-email`, don't attach patches to emails - Describe the change do

Re: [Mesa-dev] [PATCH 09/14] egl: Lock the display in _eglCreateSync's callers

2016-09-14 Thread Adam Jackson
On Wed, 2016-09-14 at 14:29 +0100, Emil Velikov wrote: > It's surprising that you haven't heard about this, considering it's > been in use for more than three years. Guess you simply forgot ? Most of my own patches to Mesa have been so far from being "features" that I've never had to care. - aja

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Emil Velikov
On 14 September 2016 at 15:00, Adam Jackson wrote: > On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote: > >> Thanks for reminding me - eglQueryAPI should never throw an error, >> indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an >> error, one should leave the API out of the

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Close drm device filedescriptor on kms_dri_sw_winsys release

2016-09-14 Thread Emil Velikov
Hi Lukasz, On 5 September 2016 at 17:48, Lukasz Spintzyk wrote: > This closes filedescriptor owned by kms_dri_sw_winsys struct. It fixes issue > where removal of udl or evdi module used by DisplayLink devices was impossible > due to not closed filedescriptors. > > When this file descriptor was no

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Adam Jackson
On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote: > Thanks for reminding me - eglQueryAPI should never throw an error, > indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an > error, one should leave the API out of the spec text shouldn't they ? I mean, sure, but this patch i

[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

2016-09-14 Thread Adam Jackson
From: Kyle Brenneman This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and calls them when appropriate. This would be useful enough for debugging on its own,

Re: [Mesa-dev] [PATCH v2] gallium: fix return value check

2016-09-14 Thread Emil Velikov
On 14 September 2016 at 13:47, Eric Engestrom wrote: > On Thu, Sep 08, 2016 at 03:12:42PM +0300, Martina Kollarova wrote: >> A possible error (-1) was being lost because it was first converted to an >> unsigned int and only then checked. >> >> Reviewed-by: Nicolai Hähnle >> Signed-off-by: Martina

Re: [Mesa-dev] [PATCH mesa] configure.ac: fix the name of the Wayland Scanner pc file

2016-09-14 Thread Emil Velikov
On 13 September 2016 at 17:31, Eric Engestrom wrote: > From: Brendan King > > The Wayland Scanner pkg-config file is called wayland-scanner.pc. > Nice one, thanks. Added the stable tag and pushed alongside the GBM cleanup patch. Emil ___ mesa-dev maili

Re: [Mesa-dev] [PATCH 09/14] egl: Lock the display in _eglCreateSync's callers

2016-09-14 Thread Emil Velikov
On 14 September 2016 at 13:36, Adam Jackson wrote: > On Wed, 2016-09-14 at 11:15 +0100, Emil Velikov wrote: > >> Nice one... I wonder if your view will be the same if you were never >> involved in distribution packaging? Guess we'll never know :-\ >> In case you've forgotten things have been like

Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-14 Thread Eric Engestrom
On Thu, Sep 08, 2016 at 03:55:02PM -0400, Nicholas Bishop wrote: > Changed dri2_query_image to check the return value of > resource_get_handle and return GL_FALSE if an error occurs. Similarly > changed gbm_dri_bo_get_fd to check the return value of queryImage and > return -1 (an invalid file descr

Re: [Mesa-dev] [PATCH v2] gallium: fix return value check

2016-09-14 Thread Eric Engestrom
On Thu, Sep 08, 2016 at 03:12:42PM +0300, Martina Kollarova wrote: > A possible error (-1) was being lost because it was first converted to an > unsigned int and only then checked. > > Reviewed-by: Nicolai Hähnle > Signed-off-by: Martina Kollarova Good cleanup :) Reviewed-by: Eric Engestrom B

Re: [Mesa-dev] [PATCH 09/14] egl: Lock the display in _eglCreateSync's callers

2016-09-14 Thread Adam Jackson
On Wed, 2016-09-14 at 11:15 +0100, Emil Velikov wrote: > Nice one... I wonder if your view will be the same if you were never > involved in distribution packaging? Guess we'll never know :-\ > In case you've forgotten things have been like that for a long time - > long before I jumped in. I wasn'

[Mesa-dev] [PATCH mesa] gbm: remove left-over array

2016-09-14 Thread Eric Engestrom
e7c8c85785b3a8f29e3f ("gbm: Removed unused function.") forgot to remove the global array used only by that function. Signed-off-by: Eric Engestrom --- src/gbm/main/gbm.c | 12 1 file changed, 12 deletions(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 1acbbcd..5a8e8b

[Mesa-dev] [PATCH mesa] configure.ac: fix the name of the Wayland Scanner pc file

2016-09-14 Thread Eric Engestrom
From: Brendan King The Wayland Scanner pkg-config file is called wayland-scanner.pc. Fixes: 153539bd9d4445b50411 ("configure: rework wayland_scanner handling (fix make distcheck)") CC: Emil Velikov Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom Signed-off-by: Brendan King ---

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

2016-09-14 Thread Emil Velikov
On 13 September 2016 at 21:05, Eric Anholt wrote: > Ilia Mirkin writes: > >> On Mon, Sep 12, 2016 at 11:55 AM, Emil Velikov >> wrote: >>> On 12 September 2016 at 15:35, Ilia Mirkin wrote: On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov wrote: > Keeping diff/patches in git always

[Mesa-dev] [Bug 97804] Later precision statement isn't overriding earlier one

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97804 Bug ID: 97804 Summary: Later precision statement isn't overriding earlier one Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: nor

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

2016-09-14 Thread Emil Velikov
On 13 September 2016 at 17:46, Adam Jackson wrote: > On Tue, 2016-09-13 at 16:54 +0100, Emil Velikov wrote: >> Going through table 13.2 and the below there are some discrepancies. >> >> AFAICT some of those can be seen as spec bugs (B), while others seem >> to be missing (M) >> - thread - eglBind

[Mesa-dev] Linker warning typo fix

2016-09-14 Thread Eero Tamminen
Hi, Attached is fix to linker typo I noticed. (It's so trivial that I'm not going to send updates to it for process reasons / attributions. Apply it as you wish.) - Eero diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index c95edf3..f008b4f 100644 --- a/src/

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-14 Thread Marek Olšák
On Wed, Sep 14, 2016 at 5:26 AM, Michel Dänzer wrote: > On 14/09/16 02:53 AM, Marek Olšák wrote: >> >> cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu >> -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=O >> -DCMAKE_BUILD_TYPE=RelWithDebInfo >> -D

Re: [Mesa-dev] [PATCH 09/14] egl: Lock the display in _eglCreateSync's callers

2016-09-14 Thread Emil Velikov
On 13 September 2016 at 19:22, Adam Jackson wrote: > On Tue, 2016-09-13 at 19:18 +0100, Emil Velikov wrote: > >> For the series as a whole ? >> Two words which contradict any software's stable scheme - new feature. > > Disagree, but I'm not the one running Mesa's stable branch, so my > opinion doe

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-14 Thread Evgenii Shatokhin
On 13.09.2016 21:27, Romain Failliot wrote: Thanks a lot! I'll try that tonight! I have a 64-bit distrib, I don't think so but do I need to compile the 32-bit version of llvm as well (is it because Steam is using 32-bit libraries?). Yes, you likely need both 64-bit and 32-bit LLVM and Mesa. 32

[Mesa-dev] [PATCH] i965/fs: Take Dispatch/Vector mask into account in FIND_LIVE_CHANNEL

2016-09-14 Thread Jason Ekstrand
On at least Sky Lake, ce0 does not contain the full story as far as enabled channels goes. It is possible to have completely disabled channels where the corresponding bits in ce0 are 1. In order to get the correct execution mask, you have to mask off those channels which were disabled from the be

Re: [Mesa-dev] [PATCH 62/95] i965/vec4: Add a shuffle_64bit_data helper

2016-09-14 Thread Iago Toral
On Tue, 2016-09-13 at 22:24 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > > > On Mon, 2016-09-12 at 14:19 -0700, Francisco Jerez wrote: > > > > > > Iago Toral Quiroga writes: > > > > > > > > > > > > > > > SIMD4x2 64bit data is stored in register space like this: > > > > > > > >

Re: [Mesa-dev] [PATCH] i965/fs: Take the sample mask into account in FIND_LIVE_CHANNEL

2016-09-14 Thread Jason Ekstrand
On Wed, Sep 14, 2016 at 12:02 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > Just looking at the channel enables is not sufficient, at least not on > Sky > > Lake. Channels that are disabled by the sample_mask may show up in the > > channel enable register as being enabled even if th

Re: [Mesa-dev] [PATCH] radeonsi: reload PS inputs with direct indexing at each use (v2)

2016-09-14 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.09.2016 22:20, Marek Olšák wrote: From: Marek Olšák The LLVM compiler can CSE interp intrinsics thanks to LLVMReadNoneAttribute. 26011 shaders in 14651 tests Totals: SGPRS: 1146340 -> 1132676 (-1.19 %) VGPRS: 727371 -> 711730 (-2.15 %) Spilled SGPRs: 2218 ->

Re: [Mesa-dev] [PATCH] radeonsi: get rid of img/buf/sampler descriptor preloading (v2)

2016-09-14 Thread Nicolai Hähnle
On 13.09.2016 22:20, Marek Olšák wrote: From: Marek Olšák 26011 shaders in 14651 tests Totals: SGPRS: 1251920 -> 1152636 (-7.93 %) VGPRS: 728421 -> 728198 (-0.03 %) Spilled SGPRs: 16644 -> 3776 (-77.31 %) Spilled VGPRs: 369 -> 369 (0.00 %) Scratch VGPRs: 1344 -> 1344 (0.00 %) dwords per thread

Re: [Mesa-dev] [PATCH] radeonsi: load streamout buffer descriptors before use (v2)

2016-09-14 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.09.2016 22:20, Marek Olšák wrote: From: Marek Olšák v2: inline the code and remove the conditional that's a no-op now --- src/gallium/drivers/radeonsi/si_shader.c | 47 ++-- 1 file changed, 14 insertions(+), 33 deletions(-) diff

[Mesa-dev] [Bug 94627] Game Risen on wine black grass

2016-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94627 Nicolai Hähnle changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] radeonsi/compute: Use the HSA abi for non-TGSI compute shaders v2

2016-09-14 Thread Nicolai Hähnle
On 13.09.2016 19:16, Tom Stellard wrote: This patch switches non-TGSI compute shaders over to using the HSA ABI described here: https://github.com/RadeonOpenCompute/ROCm-Docs/blob/master/AMDGPU-ABI.md The HSA ABI provides a much cleaner interface for compute shaders and allows us to share more

Re: [Mesa-dev] [PATCH] egl/wayland-egl: Fix for segfault in dri2_wl_destroy_surface.

2016-09-14 Thread Pekka Paalanen
On Wed, 24 Aug 2016 10:23:11 +0100 Emil Velikov wrote: > On 24 August 2016 at 08:48, Stencel, Joanna wrote: > > I couldn't find any clear requirement about order of destroys in EGL (or > > wayland) specification. > > Also, in EGL spec (3.7.3, about eglMakeCurrent) one can find: > > > > " If a n

Re: [Mesa-dev] [PATCH] i965/fs: Take the sample mask into account in FIND_LIVE_CHANNEL

2016-09-14 Thread Francisco Jerez
Jason Ekstrand writes: > Just looking at the channel enables is not sufficient, at least not on Sky > Lake. Channels that are disabled by the sample_mask may show up in the > channel enable register as being enabled even if they are not executing. > This can cause FIND_LIVE_CHANNEL to return a c