Re: [Mesa-dev] [PATCH v2 31/34] i965/state: Account for the element size in emit_buffer_surface_state

On Tue, Jun 28, 2016 at 09:22:49AM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 23, 2016 at 02:00:30PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 11 ++- > > src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 9 + > > src/mesa/dr

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

Rob Clark writes: > On Tue, Jun 28, 2016 at 11:28 AM, Marek Olšák wrote: >> On Mon, Jun 27, 2016 at 9:28 PM, Rob Clark wrote: >>> On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke >>> wrote: On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: > On Mon, Jun 27, 2016 at 4:44 AM,

[Mesa-dev] [PATCH 2/2] st/mesa: get max supported number of image samples from driver

Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b87c9ce..b55b2c2 100644 --- a/src/mesa/state_tracker/st_extensions.

[Mesa-dev] [PATCH 1/2] nvc0: fix up image support for allowing multiple samples

Basically we just have to scale up the coordinates and then add the relevant sample offset. The code to handle this was already largely present from Christoph's earlier attempts to pipe images through back in the dark ages, this just hooks it all up. Signed-off-by: Ilia Mirkin --- Only tested on

[Mesa-dev] [PATCH v2] gallium: Force blend color to 16-byte alignment

This aligns the 4-element color float array to 16 byte boundaries. This should allow compiler vectorizers to generate better optimizations. Also fixes broken vectorization generated by Intel compiler. v2: Fixed indentation and added a lengthy comment explaining the reason for the alignment.

Re: [Mesa-dev] [PATCH] gallium: Force blend color to 16-byte alignment

Really it's a workaround to fix bad vectorization in the Intel compiler, but it doesn't it doesn't hurt for other compilers, even if the performance difference is marginal if at all, and could only help. If it was problematic otherwise I'd guard it with an #ifdef _INTEL_COMPILER. I can update the

Re: [Mesa-dev] [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ > - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ > - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ > - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 Reviewed-by: D

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri wrote: > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote: >> > Tried this while playing with apitrace and am getting segfaults >> > when >> > running any trace with a cached (sec

[Mesa-dev] [PATCH 09/16] svga: set render target flag for snorm surfaces

We don't normally support rendering to SNORM surfaces, but with GL_ARB_copy_image we can copy to them if we treat them as typeless and use a UNORM surface view. --- src/gallium/drivers/svga/svga_resource_texture.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 10/16] svga: use vgpu10 CopyRegion command when possible

From: Neha Bhende Do texture->texture copies host-side with this command when possible. Use the previous software fallback otherwise. Reviewed-by: Brian Paul --- src/gallium/drivers/svga/svga_pipe_blit.c | 149 +- 1 file changed, 147 insertions(+), 2 deletions(-) d

[Mesa-dev] [PATCH 16/16] svga: use SVGA3D_vgpu10_BufferCopy() for buffer copies

So that we do copies host-side rather than in the guest with map/memcpy. Tested with piglit arb_copy_buffer-subdata-sync test and new arb_copy_buffer-intra-buffer-copy test. Reviewed-by: Charmaine Lee --- src/gallium/drivers/svga/svga_pipe_blit.c | 32 +++ 1 file cha

[Mesa-dev] [PATCH 07/16] svga: adjust sampler view format for RGBX

We previously handled the case of a RGBX sampler view of a RGBA surface. Add the reverse case too. For GL_ARB_copy_image. --- src/gallium/drivers/svga/svga_state_sampler.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_state_sampler.c b/src

[Mesa-dev] [PATCH 13/16] svga: enable ARB_copy_image extension in the driver

From: Neha Bhende Reviewed-by: Brian Paul --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 4c2774d..359a159 100644 --- a/src/gallium/drivers/svg

[Mesa-dev] [PATCH 12/16] svga: try blitting with copy region in more cases

We previously could do blits with util_resource_copy_region() when doing 'loose' format checking. Also do blits with util_resource_copy_region() when the blit src/dst formats (not the underlying resources) exactly match. Needed for GL_ARB_copy_image. --- src/gallium/drivers/svga/svga_pipe_blit.c

[Mesa-dev] [PATCH 11/16] svga: use copy_region_vgpu10() for region copies when possible

--- src/gallium/drivers/svga/svga_pipe_blit.c | 42 --- 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_blit.c b/src/gallium/drivers/svga/svga_pipe_blit.c index 564af51..ad54dc5 100644 --- a/src/gallium/drivers/svga/svg

[Mesa-dev] [PATCH 15/16] svga: add SVGA3D_vgpu10_BufferCopy()

--- src/gallium/drivers/svga/svga_cmd.h| 6 ++ src/gallium/drivers/svga/svga_cmd_vgpu10.c | 24 2 files changed, 30 insertions(+) diff --git a/src/gallium/drivers/svga/svga_cmd.h b/src/gallium/drivers/svga/svga_cmd.h index 26e4690..06e1b4a 100644 --- a/src/g

[Mesa-dev] [PATCH 08/16] svga: add new svga_format_is_uncompressed_snorm() helper

--- src/gallium/drivers/svga/svga_format.c | 20 src/gallium/drivers/svga/svga_format.h | 4 2 files changed, 24 insertions(+) diff --git a/src/gallium/drivers/svga/svga_format.c b/src/gallium/drivers/svga/svga_format.c index 17c3bf9..1b3cebe 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 06/16] svga: adjust render target view format for RGBX

For GL_ARB_copy_image we may be asked to create an RGBA view of a RGBX surface. Use an RGBX view format for that case. --- src/gallium/drivers/svga/svga_surface.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_surface.c b/src/gall

[Mesa-dev] [PATCH 14/16] svga: flush buffers when mapping for reading

With host-side buffer copies (via SVGA3D_vgpu10_BufferCopy()) we have to make sure any pending map-write operations are completed before reading. Otherwise the ReadbackSubResource operation could get stale data from the host buffer. This allows the piglit arb_copy_buffer-subdata-sync test to pass

[Mesa-dev] [PATCH 04/16] svga: use untyped surface formats in most cases

This allows us to do copies between different, but compatible, surface formats such as RGBA8_UNORM, RGBA8_SINT, RGBA8_UINT, etc. for GL_ARB_copy_image. --- src/gallium/drivers/svga/svga_resource_texture.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 02/16] util: simplify a few things in util_can_blit_via_copy_region()

Since only the src box can have negative dims for flipping, just comparing the src/dst box sizes is enough to detect flips. --- src/gallium/auxiliary/util/u_surface.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b

[Mesa-dev] [PATCH 03/16] gallium/util: add tight_format_check param to util_can_blit_via_copy_region()

The VMware driver will use this for implementing GL_ARB_copy_image. --- src/gallium/auxiliary/util/u_surface.c | 38 +- src/gallium/auxiliary/util/u_surface.h | 3 ++- 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_sur

[Mesa-dev] [PATCH 01/16] util: new util_try_blit_via_copy_region() function

Pulled out of the util_try_blit_via_copy_region() function. Subsequent changes build on this. --- src/gallium/auxiliary/util/u_surface.c | 44 ++ src/gallium/auxiliary/util/u_surface.h | 3 +++ 2 files changed, 32 insertions(+), 15 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 05/16] svga: don't advertise support for R32G32B32_UINT/SINT surface formats

From: Neha Bhende We want to be able to copy between different 32-bit, 3-channel surface formats for GL_ARB_copy_image but since we don't have a 3-channel float format, we can't support 32-bit, 3-channel integer formats. The state tracker will choose 4-channel formats instead. Fixes the piglit

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use conformant line rasterization

This series is, Reviewed-by: Edward O'Callaghan On 06/29/2016 03:53 AM, Marek Olšák wrote: > From: Marek Olšák > > AA lines are not completely correct (see TODO), but everything else > should be. > > + 3 linestipple piglits > --- > src/gallium/drivers/radeon/cayman_msaa.c | 12 ++

Re: [Mesa-dev] [PATCH] gallium: Force blend color to 16-byte alignment

Am 28.06.2016 um 22:45 schrieb Chuck Atkins: > This aligns the 4-element color float array to 16 byte boundaries. This > should allow compiler vectorizers to generate better optimizations. > Also fixes broken vectorization generated by Intel compiler. > > Reported-by: Tim Rowley > Signed-off-by:

Re: [Mesa-dev] [Intel-gfx] [PATCH 2/2] i965: Removing PCI IDs that are no longer listed as Kabylake.

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurati

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] i956: Add more Kabylake PCI IDs.

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > include/pci_ids/i965_pci_ids.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids

[Mesa-dev] [PATCH 2/2 v2] mesa/st: Silence unused variable warning

v2: Use MAYBE_UNUSED Changed commit tag (Suggested by Ian Romanick) Signed-off-by: Gurkirpal Singh --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH 1/2 v2] gallium: Silence unused variable warnings

v2: Use MAYBE_UNUSED as suggested by Ian Romanick Signed-off-by: Gurkirpal Singh --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 4 +++- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 4 +++- src/gallium/drivers/nouveau/nv50/nv98_video.c | 4 +++- src/gal

Re: [Mesa-dev] [PATCH] gallium: Force blend color to 16-byte alignment

On Tue, Jun 28, 2016 at 1:45 PM, Chuck Atkins wrote: > This aligns the 4-element color float array to 16 byte boundaries. This > should allow compiler vectorizers to generate better optimizations. > Also fixes broken vectorization generated by Intel compiler. > > Reported-by: Tim Rowley > Signed

Re: [Mesa-dev] [PATCH] i965: adds gen7_emit_cs_stall_flush on intel_texture_barrier

Alejandro Piñeiro writes: > Fixes: > GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass > > On Haswell, Broadwell and Skylake (note that in order to execute > that test, it is needed to override GL and GLSL versions). > > I was not able to find a documentation reference that justifies it. > --

Re: [Mesa-dev] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

On Mon, 2016-06-27 at 17:10 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > v2: Avoid using "H" instead of HALO to keep names uniform - DK. > > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi > --- > intel/intel_chipset.h | 14 ++ > 1 file chang

[Mesa-dev] [PATCH] mesa/main: handle gl_buffer_index correctly

--- src/mesa/main/buffers.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index e8aedde..3ff6061 100644 --- a/src/mesa/main/buffers.c +++ b/src/mesa/main/buffers.c @@ -170,7 +170,7 @@ draw_buffer_enum_to_bitmask(c

Re: [Mesa-dev] [PATCH 2/2] intel: Removing PCI IDs that are no longer listed as Kabylake.

On Mon, 2016-06-27 at 17:10 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurati

[Mesa-dev] [PATCH] gallium: Force blend color to 16-byte alignment

This aligns the 4-element color float array to 16 byte boundaries. This should allow compiler vectorizers to generate better optimizations. Also fixes broken vectorization generated by Intel compiler. Reported-by: Tim Rowley Signed-off-by: Chuck Atkins --- src/gallium/include/pipe/p_state.h |

Re: [Mesa-dev] [PATCH 1/3] i965: Refactor intel_get_param()

When I first saw spriv in the last hunk, my brain parsed it as spirv. That was confusing. :) Patches 1 and 3 are Reviewed-by: Ian Romanick On 06/28/2016 10:07 AM, Chad Versace wrote: > Replace the function's __DRIscreen parameter with struct intel_screen. > The callsites feel more natural that

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Tue, Jun 28, 2016 at 11:28 AM, Marek Olšák wrote: > On Mon, Jun 27, 2016 at 9:28 PM, Rob Clark wrote: >> On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke >> wrote: >>> On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark wrote: > O

Re: [Mesa-dev] [PATCH 2/2] mesa: Silence unused variable warning

On 06/28/2016 01:01 PM, Gurkirpal Singh wrote: > Signed-off-by: Gurkirpal Singh > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp > b/src/mesa/state_tracker/st_glsl_to_nir.cpp > index a880564..a91

[Mesa-dev] [PATCH 2/2] mesa: Silence unused variable warning

Signed-off-by: Gurkirpal Singh --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index a880564..a914c8d 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 1/2] gallium: Silence unused variable warnings

Signed-off-by: Gurkirpal Singh --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 ++ src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + src/gallium/drivers/nouveau/nv50/nv98_video.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 3 +++

Re: [Mesa-dev] [PATCH 2/3] i965: Use drmIoctl for DRM_I915_GETPARAM

On Tue, Jun 28, 2016 at 10:07:10AM -0700, Chad Versace wrote: > Stop using drmCommandWriteRead for such a simple ioctl. > --- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mes

[Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

Encapsulate the test for which flags are needed to get a compiler to support certain features. Along with this, give various options to try for AVX and AVX2 support. Ideally we want to use specific instruction set feature flags, like -mavx2 for instance instead of -march=haswell, but the flags re

Re: [Mesa-dev] [PATCH] i965: adds gen7_emit_cs_stall_flush on intel_texture_barrier

Hi, On 28/06/16 18:00, Ilia Mirkin wrote: > On Tue, Jun 28, 2016 at 11:46 AM, Alejandro Piñeiro > wrote: >> Fixes: >> GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass >> >> On Haswell, Broadwell and Skylake (note that in order to execute >> that test, it is needed to override GL and GLSL ver

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Christian König wrote: Am 28.06.2016 um 20:11 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing the patches. On Tue, Jun 28, 2016 at 11:26 PM, Andy Furniss mailto:adf.li...@gmail.com>> wrote: Nayan Deshmukh wrote: Hi Christian and Andy, I have sent new series of patche

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi Christian, I will send a new patch in which the calculation is done before using the constant buffer. Also, Grigori suggested me to use gather4 instead of sampler to get the textures. I tried using it but I don't see any code from where I can take inspiration to use that. Regards, Nayan. On

[Mesa-dev] [PATCH v3] swr: Refactor checks for compiler feature flags

Encapsulate the test for which flags are needed to get a compiler to support certain features. Along with this, give various options to try for AVX and AVX2 support. Ideally we want to use specific instruction set feature flags, like -mavx2 for instance instead of -march=haswell, but the flags re

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Am 28.06.2016 um 20:11 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing the patches. On Tue, Jun 28, 2016 at 11:26 PM, Andy Furniss > wrote: Nayan Deshmukh wrote: Hi Christian and Andy, I have sent new series of patches which takes care of

Re: [Mesa-dev] [PATCH] mesa/st: Include nir.h for nir_shader symbol.

On Tue, Jun 28, 2016 at 7:51 AM, Rob Clark wrote: > Already half of the world gets recompiled when you touch nir.h, and > I'd rather not make that worse.. Exactly my thoughts. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freede

Re: [Mesa-dev] [PATCH] swr: Refactor checks for compiler feature flags

The only guaranteed way I can think of to ensure compiler support is to try compiling source that calls one intrinsic from each of the used groups. I can see that being "more correct" but I can't really think of a situation where just checking for the __AVX2__ define will fail to build wither. -

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi Andy, Thanks for testing the patches. On Tue, Jun 28, 2016 at 11:26 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Christian and Andy, >> >> I have sent new series of patches which takes care of the points Christian >> pointed out. >> >> I have also made some changes to make it more

Re: [Mesa-dev] [PATCH] swr: Refactor checks for compiler feature flags

So this seems to be different across versions as well. It looks like __AVX__ and __AVX2__ are the only ones we can really count on being there. I can drop the second check to just __AVX2__. I think it's redundant by chance though that all CPUs that supported AVX2 also seem to support the addition

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Nayan Deshmukh wrote: Hi Christian and Andy, I have sent new series of patches which takes care of the points Christian pointed out. I have also made some changes to make it more efficient than before. Also due to a wrong message id, I have sent the messages as a new thread instead of replyin

[Mesa-dev] [PATCH 4/4] radeonsi: enable distributed tess on multi-SE parts only

From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_pipe.c | 4 src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 4 files changed, 7 insertions(

Re: [Mesa-dev] [PATCH] swr: Refactor checks for compiler feature flags

> On Jun 28, 2016, at 8:24 AM, Chuck Atkins wrote: > > Encapsulate the test for which flags are needed to get a compiler to > support certain features. Along with this, give various options to try > for AVX and AVX2 support. Ideally we want to use specific instruction > set feature flags, like

[Mesa-dev] [PATCH 1/4] radeonsi: use conformant line rasterization

From: Marek Olšák AA lines are not completely correct (see TODO), but everything else should be. + 3 linestipple piglits --- src/gallium/drivers/radeon/cayman_msaa.c | 12 ++-- src/gallium/drivers/radeon/r600d_common.h| 6 ++ src/gallium/drivers/radeonsi/si_state.c | 1

[Mesa-dev] [PATCH 3/4] radeonsi: set optimal VGT_HS_OFFCHIP_PARAM

From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_pipe.c | 6 +++ src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.h | 2 - src/gallium/drivers/radeonsi/si_state_draw.c| 5 ++- src/gallium/drivers/radeons

[Mesa-dev] [PATCH 2/4] radeonsi: enable CU0 in each SE for LS-HS execution

From: Marek Olšák Offchip-only tessellation allows this. --- src/gallium/drivers/radeonsi/si_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index b21fa5c..54febce 100644 --- a/src/ga

[Mesa-dev] [PATCH 1/3] i965: Refactor intel_get_param()

Replace the function's __DRIscreen parameter with struct intel_screen. The callsites feel more natural that way. --- src/mesa/drivers/dri/i965/intel_screen.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/dri

[Mesa-dev] [PATCH 0/3] i965: Cleanups for DRM_IOCTL_I915_GETPARAM

I've begun investigating Android sync fds, whose support will be advertised with a new i915 getparam. While investigating the new feature, I wrote this little cleanup series. Chad Versace (3): i965: Refactor intel_get_param() i965: Use drmIoctl for DRM_I915_GETPARAM i965: Use intel_get_param

[Mesa-dev] [PATCH 2/3] i965: Use drmIoctl for DRM_I915_GETPARAM

Stop using drmCommandWriteRead for such a simple ioctl. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b693c45..f7f806e 100644 --- a/src/me

[Mesa-dev] [PATCH 3/3] i965: Use intel_get_param() more often

Replace some open-coded ioctls with intel_get_param(). This is just a cleanup. No change in behavior. --- src/mesa/drivers/dri/i965/intel_screen.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

Hi Ilia, Setting it correctly initially is more messy. At least in my use case, we know the context type from EGL_RENDERABLE_TYPE before the framebuffer is created. We would need to add the context information to the visual used by _mesa_initialize_window_framebuffer. That requires including ma

Re: [Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

As I wrote in my other message yesterday, I was going to disable support in our VMware driver for the RGBX8 formats because of difficulties with ARB_copy_image functionality. This led to the issue of blending to RGBA surfaces as if they were RGBX. I guess we could set pipe_surface::format = R

Re: [Mesa-dev] [PATCH] i965: adds gen7_emit_cs_stall_flush on intel_texture_barrier

On Tue, Jun 28, 2016 at 11:46 AM, Alejandro Piñeiro wrote: > Fixes: > GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass > > On Haswell, Broadwell and Skylake (note that in order to execute > that test, it is needed to override GL and GLSL versions). > > I was not able to find a documentation re

[Mesa-dev] [PATCH] i965: adds gen7_emit_cs_stall_flush on intel_texture_barrier

Fixes: GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass On Haswell, Broadwell and Skylake (note that in order to execute that test, it is needed to override GL and GLSL versions). I was not able to find a documentation reference that justifies it. --- Having said, I didn't find a documentati

Re: [Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

On Tue, Jun 28, 2016 at 5:16 PM, Ilia Mirkin wrote: > The main issue is when the st selects an alpha-ful format, but the GL > wants an alpha-less format. The driver has no way of knowing. This > gives it a way of knowing. > > The alternative is that the driver has to support every format and we >

Re: [Mesa-dev] [PATCH 2/2] clover: fix getting struct args api size

On Thu, 2016-06-23 at 18:03 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Wed, 2016-06-22 at 20:22 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Wed, 2016-06-22 at 17:07 -0700, Francisco Jerez wrote: > > > > > Jan Vesely writes: > > > > > > > > > > > On

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 9:28 PM, Rob Clark wrote: > On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke > wrote: >> On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: >>> On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark wrote: >>> > On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson >>> > wrote: >

Re: [Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

The main issue is when the st selects an alpha-ful format, but the GL wants an alpha-less format. The driver has no way of knowing. This gives it a way of knowing. The alternative is that the driver has to support every format and we drop all the fallbacks from st_format. Brian's proposal seems li

Re: [Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

I guess you need this because your driver doesn't support LUMINANCE and st/mesa selects RGBA, right? In that case, you can just set RGBX in pipe_surface::format and you don't need another flag. It would be better to select RGBX at renderbuffer creation, but doing it later is fine as well. Marek

Re: [Mesa-dev] [PATCH] mesa/st: Include nir.h for nir_shader symbol.

On Mon, Jun 27, 2016 at 10:08 PM, Matt Turner wrote: > On Mon, Jun 27, 2016 at 6:45 PM, Vinson Lee wrote: >> Fix this build error with GCC 4.4. >> >> CC state_tracker/st_nir_lower_builtin.lo >> In file included from state_tracker/st_nir_lower_builtin.c:61: >> state_tracker/st_nir.h:34: erro

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Tue, Jun 28, 2016 at 10:45 AM, Samuel Pitoiset wrote: > > > On 06/28/2016 04:38 PM, Ilia Mirkin wrote: >> >> On Tue, Jun 28, 2016 at 10:27 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 06/28/2016 04:23 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 10:21 AM, Samuel Pitoiset >

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Tue, Jun 28, 2016 at 10:27 AM, Samuel Pitoiset wrote: > > > On 06/28/2016 04:23 PM, Ilia Mirkin wrote: >> >> On Tue, Jun 28, 2016 at 10:21 AM, Samuel Pitoiset >> wrote: >>> >>> On 06/28/2016 04:15 PM, Ilia Mirkin wrote: Again, what problem was this patch trying to solve? >>> >>>

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 04:38 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 10:27 AM, Samuel Pitoiset wrote: On 06/28/2016 04:23 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 10:21 AM, Samuel Pitoiset wrote: On 06/28/2016 04:15 PM, Ilia Mirkin wrote: Again, what problem was this patch tryin

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On 27 June 2016 at 18:38, Ian Romanick wrote: > On 06/24/2016 09:30 AM, Emil Velikov wrote: >> On 20 June 2016 at 19:14, Ian Romanick wrote: >>> On 06/17/2016 11:15 AM, Emil Velikov wrote: On 17 June 2016 at 18:20, Ian Romanick wrote: > From: Ian Romanick > > Khronos recommends

Re: [Mesa-dev] Split gl_shader in two and clean-ups

On Tue, 2016-06-28 at 11:52 +1000, Timothy Arceri wrote: > There are two distinctly different uses of this struct. The first > is to store GL shader objects. The second is to store information > about a shader stage thats been linked. > > The only place the new structs overlap is the shader layout

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 04:23 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 10:21 AM, Samuel Pitoiset wrote: On 06/28/2016 04:15 PM, Ilia Mirkin wrote: Again, what problem was this patch trying to solve? The problem is that FADD can only emits 19-bits but longIMMD() will return false because it o

Re: [Mesa-dev] [PATCH 4/7] glsl: pass symbols to find_matching_signature() rather than shader

On Tue, 2016-06-28 at 11:52 +1000, Timothy Arceri wrote: > This will allow us to later split gl_shader into two structs. > --- > src/compiler/glsl/link_functions.cpp | 47 > +--- > 1 file changed, 22 insertions(+), 25 deletions(-) > > diff --git a/src/compiler/gls

[Mesa-dev] [PATCH] swr: Refactor checks for compiler feature flags

Encapsulate the test for which flags are needed to get a compiler to support certain features. Along with this, give various options to try for AVX and AVX2 support. Ideally we want to use specific instruction set feature flags, like -mavx2 for instance instead of -march=haswell, but the flags re

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Tue, Jun 28, 2016 at 10:21 AM, Samuel Pitoiset wrote: > On 06/28/2016 04:15 PM, Ilia Mirkin wrote: >> >> Again, what problem was this patch trying to solve? > > > The problem is that FADD can only emits 19-bits but longIMMD() will return > false because it only checks for the high 12-bits. > >

Re: [Mesa-dev] [PATCH] doc: improve INTEL_DEBUG documentation

On Tuesday, June 28, 2016 1:33:21 AM PDT Grazvydas Ignotas wrote: > Remove 'reg' option that does not actually exist, elaborate more about > 'sync' and add the missing options. > > Signed-off-by: Grazvydas Ignotas > --- > no commit access, if this is ok please somebody push > > docs/envvars.ht

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 04:15 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 10:11 AM, Samuel Pitoiset wrote: On 06/28/2016 04:00 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 4:33 AM, Samuel Pitoiset wrote: On 06/28/2016 05:10 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:08 PM, Samuel

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Tue, Jun 28, 2016 at 10:11 AM, Samuel Pitoiset wrote: > > > On 06/28/2016 04:00 PM, Ilia Mirkin wrote: >> >> On Tue, Jun 28, 2016 at 4:33 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 06/28/2016 05:10 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:08 PM, Samuel Pitoiset >>>

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 04:00 PM, Ilia Mirkin wrote: On Tue, Jun 28, 2016 at 4:33 AM, Samuel Pitoiset wrote: On 06/28/2016 05:10 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:08 PM, Samuel Pitoiset wrote: On 06/28/2016 12:06 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mi

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Tue, Jun 28, 2016 at 4:33 AM, Samuel Pitoiset wrote: > > > On 06/28/2016 05:10 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 27, 2016 at 6:08 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 06/28/2016 12:06 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mirkin wr

[Mesa-dev] [PATCH] swr: Refactor checks for compiler feature flags

Encapsulate the test for which flags are needed to get a compiler to support certain features. Along with this, give various options to try for AVX and AVX2 support. Ideally we want to use specific instruction set feature flags, like -mavx2 for instance instead of -march=haswell, but the flags re

Re: [Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter(v4)

On 2016-06-28 11:25, Nayan Deshmukh wrote: This is a shader based bicubic interpolater which uses cubic Hermite spline algorithm. v2: set dst_area and dst_clip during scaling (Christian) v3: clear the render target before rendering v4: intialize offsets while initializing shaders use a const

Re: [Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter(v4)

Am 28.06.2016 um 11:25 schrieb Nayan Deshmukh: This is a shader based bicubic interpolater which uses cubic Hermite spline algorithm. v2: set dst_area and dst_clip during scaling (Christian) v3: clear the render target before rendering v4: intialize offsets while initializing shaders use a

Re: [Mesa-dev] [PATCH resend] pipe_loader_sw: Fix fd leak when instantiated via pipe_loader_sw_probe_kms

Hi, On 27-05-16 16:24, Emil Velikov wrote: Hi Hans, On 27 May 2016 at 15:06, Hans de Goede wrote: Make pipe_loader_sw_probe_kms take ownership of the passed in fd, like pipe_loader_drm_probe_fd does. The only caller is dri_kms_init_screen which passes in a dupped fd, just like dri2_init_scre

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi Christian and Andy, I have sent new series of patches which takes care of the points Christian pointed out. I have also made some changes to make it more efficient than before. Also due to a wrong message id, I have sent the messages as a new thread instead of replying to this thread. Regar

[Mesa-dev] [PATCH 2/2] st/vdpau: use bicubic filter for scaling(v6)

use bicubic filtering as high quality scaling L1. v2: fix a typo and add a newline to code v3: -render the unscaled image on a temporary surface (Christian) -apply noise reduction and sharpness filter on unscaled surface -render the final scaled surface using bicubic interpolatio

[Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter(v4)

This is a shader based bicubic interpolater which uses cubic Hermite spline algorithm. v2: set dst_area and dst_clip during scaling (Christian) v3: clear the render target before rendering v4: intialize offsets while initializing shaders use a constant buffer to send dst_size to frag shader

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

Hi Leo, nice catch patch is Reviewed-by: Christian König . But we still need to fix transcoding issue with interlaced as true. Our transcode support tunneling, basic the decode buffer will be used directly for encode. Ah, yes of course. Sorry I was a bit fast with giving my rb on that, shou

Re: [Mesa-dev] [PATCH 0/7] mesa: Enable -fstrict-aliasing

On Mon, Jun 27, 2016 at 11:42 PM, Matt Turner wrote: > Based on work by Davin McCall from last summer. > > The biggest change is to exec_list. Previously, the head and tail sentinels > overlapped, saving the size of a pointer. Unfortunately this is not allowed by > the aliasing rules. > > I have

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 05:10 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:08 PM, Samuel Pitoiset wrote: On 06/28/2016 12:06 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:04 PM, Samuel Pitoiset wrote: On 06/28/2016 12:02 AM, Ilia Mi

[Mesa-dev] nouveau_drv_video.so ?

nouveau_drv_video.so - what should it be? https://koji.fedoraproject.org/koji/buildinfo?buildID=722316 ... 0.7.4-13 - Revert symlinks - should be handled by mesa rhbz#1271842 https://bugzilla.redhat.com/show_bug.cgi?id=1271842 ... 0.7.4-12 - Add symlinks for radeonsi,r600,nou

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: > On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote: > > Tried this while playing with apitrace and am getting segfaults > > when > > running any trace with a cached (second) run. Not sure if it's > > "wrong" > > traces I've chosen o

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

Thx Leo. I confirm it works with nouveau driver so your fix is: Tested-by: Julien Isorce On 28 June 2016 at 02:27, Liu, Leo wrote: > Hi Julien and Christian, > > > I got a patch attached to fix the "fillout" problem, and please review. > > > But we still need to fix transcoding issue with inter