Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Iago Toral
On Mon, 2015-11-23 at 14:03 -0800, Ian Romanick wrote: > On 11/23/2015 02:01 PM, Ian Romanick wrote: > > On 11/23/2015 10:54 AM, Jason Ekstrand wrote: > >> This fixes a regression introduced in b1a83b5d1 that caused basically all > >> shaders to fail to compile on 32-bit platforms. > > > > Here's

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 Bug ID: 93091 Summary: [opencl] segfault when running any opencl programs (like clinfo) Product: Mesa Version: git Hardware: Other OS: All Statu

Re: [Mesa-dev] [PATCH v2 07/42] i965: Implement programming of the L3 configuration.

2015-11-23 Thread Jordan Justen
On 2015-11-17 21:54:39, Jordan Justen wrote: > From: Francisco Jerez > > --- > src/mesa/drivers/dri/i965/gen7_l3_state.c | 95 > +++ > 1 file changed, 95 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/gen7_l3_state.c > b/src/mesa/drivers/dri/i965/gen7_l3_

Re: [Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

2015-11-23 Thread Michel Dänzer
On 24.11.2015 01:21, Ilia Mirkin wrote: > Module: Mesa > Branch: master > Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 > > Author: Ilia Mirkin > Date: Sat Nov 21 10:44:00 2015 -0500 > > g

Re: [Mesa-dev] [PATCH 4/7] i965/nir: Remove unused indirect handling

2015-11-23 Thread Jason Ekstrand
On Nov 23, 2015 20:51, "Matt Turner" wrote: > > On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > > The one and only place where the FS backend allows reladdr is on uniforms. > > For locals, inputs, and outputs, we lower it away before the backend ever > > sees it. This commit gets rid of

Re: [Mesa-dev] [PATCH 5/7] i965/nir: Add a nir_lower_uniforms helper

2015-11-23 Thread Jason Ekstrand
On Nov 23, 2015 20:50, "Matt Turner" wrote: > > On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > > This matches what we're already doing for inputs and outputs > > --- > > src/mesa/drivers/dri/i965/brw_nir.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 1/2] targets/nine: remove vc4 target

2015-11-23 Thread Eric Anholt
Emil Velikov writes: > On 23 November 2015 at 18:36, Emil Velikov wrote: >> Any nir powered targets outside of DRI have been broken for a little >> while now (due to unresolved symbols). > PEBKAC things link fine. Either way, I'm happy to simplify things. I have a hard time imagining any use f

Re: [Mesa-dev] [PATCH 2/2] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/24/2015 03:08 AM, Timothy Arceri wrote: From: Timothy Arceri Enables 200+ dEQP SSO tests to proceed past validation, and fixes a ES31-CTS.sepshaderobjs.PipelineApi subtest. V2: split out change that reverts a previous patch into its own commit, move variable d

Re: [Mesa-dev] [PATCH 1/2] Revert "mesa: return initial value for VALIDATE_STATUS if pipe not bound"

2015-11-23 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/24/2015 03:08 AM, Timothy Arceri wrote: From: Timothy Arceri This reverts commit ba02f7a3b6a0e4314753a8e5080db61241563f9c. The commit checked whether the pipeline was currently bound instead of checking whether it had ever been bound. The previous setting of

Re: [Mesa-dev] [PATCH 4/7] i965/nir: Remove unused indirect handling

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > The one and only place where the FS backend allows reladdr is on uniforms. > For locals, inputs, and outputs, we lower it away before the backend ever > sees it. This commit gets rid of the dead indirect handling code. > --- > src/mesa/dri

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Use a stride of 1 and byte offsets for UBOs

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 16 > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- > 3 files changed, 13 insertions(

Re: [Mesa-dev] [PATCH 3/7] i965/vec4: Use a stride of 1 and byte offsets for UBOs

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 16 +++- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 13 +++-- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 5 + > 3 files changed, 7 inserti

Re: [Mesa-dev] [PATCH 5/7] i965/nir: Add a nir_lower_uniforms helper

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 6:11 PM, Jason Ekstrand wrote: > This matches what we're already doing for inputs and outputs > --- > src/mesa/drivers/dri/i965/brw_nir.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_nir.c > b/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH] swrast: Fix the coordinates passed to _mesa_regions_overlap()

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 5:35 PM, Anuj Phogat wrote: > Cc: "11.1" > Signed-off-by: Anuj Phogat > --- > src/mesa/swrast/s_copypix.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/swrast/s_copypix.c b/src/mesa/swrast/s_copypix.c > index 0dbccc0..31e1d3d 100

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 Michel Dänzer changed: What|Removed |Added CC||markus.p...@gmx.at --- Comment #48 from

Re: [Mesa-dev] [PATCH] glsl: Pass ast_type_qualifier by const reference.

2015-11-23 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/7] i965/vec4: Use a stride of 1 and byte offsets for UBOs

2015-11-23 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 16 +++- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 13 +++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 5 + 3 files changed, 7 insertions(+), 27 deletions(-) diff --git a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 5/7] i965/nir: Add a nir_lower_uniforms helper

2015-11-23 Thread Jason Ekstrand
This matches what we're already doing for inputs and outputs --- src/mesa/drivers/dri/i965/brw_nir.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index 91358d8..e602df7 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 2/7] i965/fs: Use a stride of 1 and byte offsets for UBOs

2015-11-23 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH 4/7] i965/nir: Remove unused indirect handling

2015-11-23 Thread Jason Ekstrand
The one and only place where the FS backend allows reladdr is on uniforms. For locals, inputs, and outputs, we lower it away before the backend ever sees it. This commit gets rid of the dead indirect handling code. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 44

[Mesa-dev] [PATCH 6/7] i965/fs: Make uniform offsets be in terms of bytes

2015-11-23 Thread Jason Ekstrand
This commit pushes makes uniform offsets be terms of bytes starting with nir_lower_io. They get converted to be in terms of floats when we cram them in the UNIFORM register file but reladdr remains in terms of bytes all the way down to the point where we lower it to a pull constant load. --- src/

[Mesa-dev] [PATCH 7/7] i965/vec4: Make uniform offsets be in terms of bytes

2015-11-23 Thread Jason Ekstrand
This makes all uniform offsets be in terms of bytes starting from nir_lower_uniforms. We convert to vec4's before we encode it in the UNIFORM register file, but reladdr is in terms of bytes all the way down to where we lower it to a pull constant load. --- src/mesa/drivers/dri/i965/brw_nir.c

[Mesa-dev] [PATCH 0/7] Use byte offsets for ubo pulls

2015-11-23 Thread Jason Ekstrand
This little patch series converts both backends to use byte offsets for UBO pulls. This has the advantage of allowing us to just use a stried of 1 on the surface in both cases and unifies surface state across backends. Unfortunately, this does not unify it with SSBOs because they use SURFACEFORMAT

[Mesa-dev] [PATCH 1/7] i965/vec4: Use byte offsets for UBO pulls on Sandy Bridge

2015-11-23 Thread Jason Ekstrand
Previously, the VS_OPCODE_PULL_CONSTANT_LOAD opcode operated on vec4-aligned byte offsets on Iron Lake and below and worked in terms of vec4 offsets on Sandy Bridge. On Ivy Bridge, we add a new *LOAD_GEN7 variant which works in terms of vec4s. We're about to change the GEN7 version to work in ter

[Mesa-dev] [PATCH] glsl: Pass ast_type_qualifier by const reference.

2015-11-23 Thread Matt Turner
Coverity noticed that we were passing this by value, and it's 152 bytes. --- src/glsl/ast.h | 10 +- src/glsl/ast_type.cpp | 6 +++--- src/glsl/glsl_parser_extras.cpp | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/glsl/ast.h b/src/gl

Re: [Mesa-dev] [Mesa-announce] Mesa 11.1.0 release candidate 1

2015-11-23 Thread Thierry Vignaud
On 21 November 2015 at 15:28, Emil Velikov wrote: > The first release candidate for Mesa 11.1.0 is now available. > > The plan is to have one release candidate every Friday, until the final > release on December 11th 2015. > > As a reminder, with the 11.1 branch now created, patches nominated with

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 Bug ID: 93089 Summary: mesa fails to check for gcc atomic primitives before using them Product: Mesa Version: git Hardware: Other OS: OpenBSD St

[Mesa-dev] [PATCH] swrast: Fix the coordinates passed to _mesa_regions_overlap()

2015-11-23 Thread Anuj Phogat
Cc: "11.1" Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_copypix.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_copypix.c b/src/mesa/swrast/s_copypix.c index 0dbccc0..31e1d3d 100644 --- a/src/mesa/swrast/s_copypix.c +++ b/src/mesa/swrast/s_copypi

Re: [Mesa-dev] [PATCH 5/7] glsl: add always_active_io attribute to ir_variable

2015-11-23 Thread Timothy Arceri
On Sat, 2015-11-21 at 19:02 +1100, Timothy Arceri wrote: > From: Gregory Hainaut > > The value will be set in separate-shader program when an input/output > must remains active. e.g. when deadcode removal isn't allowed because > it will create interface location/name-matching mismatch. > > v3: >

[Mesa-dev] [PATCH 1/2] Revert "mesa: return initial value for VALIDATE_STATUS if pipe not bound"

2015-11-23 Thread Timothy Arceri
From: Timothy Arceri This reverts commit ba02f7a3b6a0e4314753a8e5080db61241563f9c. The commit checked whether the pipeline was currently bound instead of checking whether it had ever been bound. The previous setting of Validated during object creation makes this unnecessary. The real problem w

[Mesa-dev] [PATCH 2/2] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
From: Timothy Arceri Enables 200+ dEQP SSO tests to proceed past validation, and fixes a ES31-CTS.sepshaderobjs.PipelineApi subtest. V2: split out change that reverts a previous patch into its own commit, move variable declaration to top of function, and fix some formatting all suggested by Ian.

Re: [Mesa-dev] [PATCH 1/2] r600: define registers required for tessellation

2015-11-23 Thread Glenn Kennard
On Mon, 23 Nov 2015 23:46:24 +0100, Dave Airlie wrote: From: Dave Airlie This adds the defines for a bunch of registers and shader values that are required to implement tessellation. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 123 +++-

Re: [Mesa-dev] [PATCH 2/2] r600: add missing register to initial state

2015-11-23 Thread Glenn Kennard
On Mon, 23 Nov 2015 23:46:25 +0100, Dave Airlie wrote: From: Dave Airlie We really should initialise HS/LS_2 and SQ_LDS_ALLOC exists on all evergreen not just cayman, so we should initialise it as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- sr

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Ian Romanick
On 11/23/2015 02:09 PM, Matt Turner wrote: > On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: >> Have you built this series with debug and release builds? There have >> been cases in the past where removing or changing headers worked fine in >> one but not the other. > > Yes. Cool. This se

[Mesa-dev] [PATCH 1/2] r600: define registers required for tessellation

2015-11-23 Thread Dave Airlie
From: Dave Airlie This adds the defines for a bunch of registers and shader values that are required to implement tessellation. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 123 +++--- src/gallium/drivers/r600/r600_sq.h| 8 +++ 2 file

[Mesa-dev] [PATCH 2/2] r600: add missing register to initial state

2015-11-23 Thread Dave Airlie
From: Dave Airlie We really should initialise HS/LS_2 and SQ_LDS_ALLOC exists on all evergreen not just cayman, so we should initialise it as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- src/gallium/drivers/r600/evergreen_state.c | 19 +++

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: > Have you built this series with debug and release builds? There have > been cases in the past where removing or changing headers worked fine in > one but not the other. Yes. ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Leo Liu
the patch series Reviewed-by: Leo Liu On 11/23/2015 09:37 AM, Christian König wrote: From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_track

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Jason Ekstrand
On Mon, Nov 23, 2015 at 10:54 AM, Jason Ekstrand wrote: > This fixes a regression introduced in b1a83b5d1 that caused basically all > shaders to fail to compile on 32-bit platforms. > > Reported-by: Mark Janes > Cc: Matt Turner > --- > src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- > 1 file cha

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Ian Romanick
On 11/23/2015 01:51 PM, Ian Romanick wrote: > On 11/23/2015 04:24 AM, Timothy Arceri wrote: >> From: Timothy Arceri >> >> Enables 200+ dEQP SSO tests to proceed passed validation, > ^^ past? > >> while not regressing ES31-CTS.sepshaderobjs.PipelineApi.

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Ian Romanick
On 11/23/2015 02:01 PM, Ian Romanick wrote: > On 11/23/2015 10:54 AM, Jason Ekstrand wrote: >> This fixes a regression introduced in b1a83b5d1 that caused basically all >> shaders to fail to compile on 32-bit platforms. > > Here's the part from the b1a83b5d1 commit message that makes me sad: > >

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Ian Romanick
On 11/23/2015 10:54 AM, Jason Ekstrand wrote: > This fixes a regression introduced in b1a83b5d1 that caused basically all > shaders to fail to compile on 32-bit platforms. Here's the part from the b1a83b5d1 commit message that makes me sad: v2 (Iago) - Replace ~0 by ~0ull - Removed

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Ian Romanick
Have you built this series with debug and release builds? There have been cases in the past where removing or changing headers worked fine in one but not the other. On 11/23/2015 01:55 PM, Matt Turner wrote: > It's never used. > --- > src/mesa/drivers/dri/i965/brw_clear.c | 1 - > src/m

[Mesa-dev] [PATCH 06/13] i965: Push down inclusion of vbo/vbo.h.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_draw.h | 1 - src/mesa/drivers/dri/i965/brw_primitive_restart.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.h b/src/mesa/drivers/dri/i965/brw_draw.h index 695973b..23d98ef 100644 --- a/src/me

[Mesa-dev] [PATCH 02/13] i965: Remove useless gen6_blorp.h/gen7_blorp.h headers.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/Makefile.sources | 2 -- src/mesa/drivers/dri/i965/brw_blorp.cpp| 2 -- src/mesa/drivers/dri/i965/brw_blorp.h | 7 + src/mesa/drivers/dri/i965/gen6_blorp.cpp | 1 - src/mesa/drivers/dri/i965/gen6_blorp.h | 41 -- src/

[Mesa-dev] [PATCH 05/13] i965: Remove duplicate #includes.

2015-11-23 Thread Matt Turner
Added in commits 36fd65381 and 337dad8ce even though the existing include was in view. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index c439da2..1e39b39 10064

[Mesa-dev] [PATCH 12/13] i965: Move brw_new_shader and brw_link_shader prototypes from brw_wm.h.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.h | 3 +++ src/mesa/drivers/dri/i965/brw_wm.h | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.h b/src/mesa/drivers/dri/i965/brw_shader.h index d78e552..5c226ec 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH 10/13] i965: Move MRF macros from brw_inst.h to brw_eu.h.

2015-11-23 Thread Matt Turner
brw_inst.h is only for the brw_inst/brw_compact_inst functions. --- src/mesa/drivers/dri/i965/brw_eu.h| 9 + src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 + src/mesa/drivers/dri/i965/brw_inst.h | 9 - 3 files changed, 10 insertions(+), 9 deleti

[Mesa-dev] [PATCH 08/13] i965: Push down inclusion of brw_program.h.

2015-11-23 Thread Matt Turner
We were including it in headers, which then caused it to be included in tons of places it wasn't needed. --- src/mesa/drivers/dri/i965/brw_cs.c | 1 + src/mesa/drivers/dri/i965/brw_cs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri

[Mesa-dev] [PATCH 11/13] i965: Compile brw_cs_fill_local_id_payload() as C.

2015-11-23 Thread Matt Turner
It's only called from C, it compiles as C, so just compile it as C. Notice the missing extern "C" on the definition of the function, which would screw things up if the prototype wasn't parsed before the definition. --- src/mesa/drivers/dri/i965/brw_cs.c | 36

[Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Matt Turner
It's never used. --- src/mesa/drivers/dri/i965/brw_clear.c | 1 - src/mesa/drivers/dri/i965/brw_clip.c | 1 - src/mesa/drivers/dri/i965/brw_clip_line.c | 1 - src/mesa/drivers/dri/i965/brw_clip_point.c | 1 - src/mesa/drivers/dri/i965/brw_clip_tri.c | 1 - src/mes

[Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

2015-11-23 Thread Matt Turner
--- src/util/macros.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/macros.h b/src/util/macros.h index 84e4f18..5014b91 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -24,6 +24,8 @@ #ifndef UTIL_MACROS_H #define UTIL_MACROS_H +#include + /* Compute the size of an

[Mesa-dev] [PATCH 04/13] i965: Remove unneeded forward declarations.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_gs.h | 2 -- src/mesa/drivers/dri/i965/intel_asm_annotation.h | 3 --- src/mesa/drivers/dri/i965/intel_fbo.h| 1 - src/mesa/drivers/dri/i965/intel_tex.h| 2 -- 4 files changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 13/13] i965: Clean up #includes in the compiler.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp.cpp | 1 - src/mesa/drivers/dri/i965/brw_blorp.h| 1 - src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 1 - src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h| 1 - src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 07/13] i965: Mark functions called from C as extern "C".

2015-11-23 Thread Matt Turner
These functions' prototypes are marked with extern "C", which apparently overrides a lack of extern "C" at the definition site if the prototype has been seen first. --- src/mesa/drivers/dri/i965/brw_link.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- 2 files changed, 3 insertions

[Mesa-dev] [PATCH 03/13] i965: Mark count_trailing_one_bits() static.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index ba11d3d..cb3c6f7 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp +++ b/s

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Ian Romanick
On 11/23/2015 04:24 AM, Timothy Arceri wrote: > From: Timothy Arceri > > Enables 200+ dEQP SSO tests to proceed passed validation, ^^ past? > while not regressing ES31-CTS.sepshaderobjs.PipelineApi. > > Cc: Tapani Pälli > Cc: Gregory Hainaut > ---

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Chad Versace
On Mon 23 Nov 2015, Jason Ekstrand wrote: > On Mon, Nov 23, 2015 at 6:15 AM, Francisco Jerez > wrote: > > Jason Ekstrand writes: > > For that reason 'has_matching_typed_format(MESA_FORMAT_NONE) = true' > > makes sense to me, but 'has_matching_typed_format(BRW_SURFACEFORMAT_RAW) > > = true' and

Re: [Mesa-dev] [PATCH] r600: consolidate clip state updates

2015-11-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 23, 2015 at 9:50 PM, Dave Airlie wrote: > From: Dave Airlie > > Move some common code into one place, tess will also need > to use this function. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_state_common.c | 31 > +++

Re: [Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 14:36, Christian König wrote: > From: Christian König > > The workarounds are to hacky to enable them by default > and otherwise MPEG4 doesn't work reliable. > > Signed-off-by: Christian König Thanks Christian. Should we document the new variable in docs/envvars.html and

Re: [Mesa-dev] [PATCH] pipe-loader: fix off-by one error

2015-11-23 Thread Tom Stellard
On Mon, Nov 23, 2015 at 09:37:51PM +, Emil Velikov wrote: > With earlier commit we've dropped the manual iteration over the fixed > size array and prepemtively set the variable storing the size, that is > to be returned. Yet we forgot to adjust the comparison, as before we > were comparing the

[Mesa-dev] [PATCH] pipe-loader: fix off-by one error

2015-11-23 Thread Emil Velikov
With earlier commit we've dropped the manual iteration over the fixed size array and prepemtively set the variable storing the size, that is to be returned. Yet we forgot to adjust the comparison, as before we were comparing the index, now we're comparing the size. Fixes: ff9cd8a67ca "pipe-loader:

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
On Mon, 2015-11-23 at 15:19 +0200, Tapani Pälli wrote: > Hi; > > On 11/23/2015 02:24 PM, Timothy Arceri wrote: > > From: Timothy Arceri > > > > Enables 200+ dEQP SSO tests to proceed passed validation, > > while not regressing ES31-CTS.sepshaderobjs.PipelineApi. > > > > Cc: Tapani Pälli > > Cc

[Mesa-dev] [PATCH] r600: consolidate clip state updates

2015-11-23 Thread Dave Airlie
From: Dave Airlie Move some common code into one place, tess will also need to use this function. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 31 ++-- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/r

[Mesa-dev] [PATCH] nv50: add edgeflag support when using inline vertex data submit

2015-11-23 Thread Samuel Pitoiset
Fixes the following piglit tests: - gl-1.0-edgeflag - gl-1.0-edgeflag-quads - gl-2.0-edgeflag - gl-2.0-edgeflag-immediate - point-vertex-id divisor - point-vertex-id gl_InstanceID - point-vertex-id gl_InstanceID divisor I still need to figure out why point-vertex-id fails with gl_vertexID.

[Mesa-dev] [PATCH 2/5] st/dri: fd management cleanups

2015-11-23 Thread Emil Velikov
Add some checks if the original/dup'd fd is valid, one and ensure that we don't leak it on error. In the former case the pipe_loader would correctly handle things, although let's make things more explicit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 5/5] auxiliary/vl/dri: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit, minus the extra dup. We are the one opening the device thus we can directly use the fd. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 7 +-- 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH 1/5] pipe-loader: check if winsys.name is non-null prior to strcmp

2015-11-23 Thread Emil Velikov
In theory this wouldn't be an issue, as we'll find the correct name and break out of the loop before we hit the sentinel. Let's fix this and avoid issues in the future. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/

[Mesa-dev] [PATCH 3/5] st/xa: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/state_trackers/xa/xa_tracker.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/galli

[Mesa-dev] [PATCH 4/5] auxiliary/vl/drm: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_drm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_drm.c b/src/gallium/au

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2015-11-23 Thread Neil Roberts
Hi, Has this situation changed at all? It's probably quite important to get this working because we have to disable fast clears for X-tiled buffers on SKL which effectively means we currently can't do it for window system buffers. Regards, - Neil Chris Wilson writes: > On Mon, Apr 13, 2015 at

Re: [Mesa-dev] [PATCH 1/2] targets/nine: remove vc4 target

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 18:36, Emil Velikov wrote: > Any nir powered targets outside of DRI have been broken for a little > while now (due to unresolved symbols). PEBKAC things link fine. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org htt

Re: [Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 18:44, Rob Clark wrote: > just curious, but which syms? > Seems that I had some local glsl/nir changes which caused the issue. I should stop doing so many things at one :-) > That said, I'm not really sure if wine/gallium9 has much usefulness on ARM, so > > Acked-by: Rob Cl

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Jason Ekstrand
On Mon, Nov 23, 2015 at 6:15 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez >> wrote: >>> Chad Versace writes: >>> On Wed 04 Nov 2015, Jason Ekstrand wrote: > Previously, we were relying on has_matching_typed_format returning

[Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Jason Ekstrand
This fixes a regression introduced in b1a83b5d1 that caused basically all shaders to fail to compile on 32-bit platforms. Reported-by: Mark Janes Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] i965: Branch for debugging fast clears

2015-11-23 Thread Chad Versace
I recently spent a lot of time debugging fast clears. The hardware documentation is confusing on the subject, so I began poking individual bits in the auxiliary surface to better understand why things were not working as expecting. Some of you (CC'd) may find my debug branch useful if you ever fin

Re: [Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Rob Clark
just curious, but which syms? That said, I'm not really sure if wine/gallium9 has much usefulness on ARM, so Acked-by: Rob Clark On Mon, Nov 23, 2015 at 1:36 PM, Emil Velikov wrote: > Analogous to previous commit. As we no longer have anyone who uses NIR > we can drop the link. > > Cc: Rob Cla

[Mesa-dev] [PATCH 1/2] targets/nine: remove vc4 target

2015-11-23 Thread Emil Velikov
Any nir powered targets outside of DRI have been broken for a little while now (due to unresolved symbols). Not to mention that there are no users for it, yet. Cc: Eric Anholt Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 2 -- 1 file changed, 2 deletions(-) dif

[Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Emil Velikov
Analogous to previous commit. As we no longer have anyone who uses NIR we can drop the link. Cc: Rob Clark Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/targets/d3dadapter9/Makefile.am b/src/gallium

Re: [Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 9:36 AM, Christian König wrote: > From: Christian König > > The workarounds are to hacky to enable them by default to hacky -> too hacky > and otherwise MPEG4 doesn't work reliable. reliable -> reliably > > Signed-off-by: Christian König > --- > src/gallium/state_tra

Re: [Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Julien Isorce
Nice cleanups. I also tested these changes on "nouveau" driver with one video per format (except HEVC) and works fine with mpv and gstreamer. Patches "[PATCH 2/8] st/va: move post processing function into own file" to "[PATCH 8/8] st/va: fix indentation" are: Reviewed-by: Julien Isorce On 23 Nov

Re: [Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

2015-11-23 Thread Julien Isorce
Make sense it was a copy past I did from vlVdpPresentationQueueDisplay. I tested this change and works fine. Thx for catching this. (feel free to set "clear_dirty" param of vl_compositor_render to false even if it will be ignored anyway) Reviewed-by: Julien Isorce On 23 November 2015 at 14:37,

Re: [Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

2015-11-23 Thread Neil Roberts
I've pushed this patch to master but I think it would be a good candidate to go on the 11.1 branch as well. Do I have to do something to make that happen? - Neil Neil Roberts writes: > It looks like the sampler hardware doesn't take into account the > surface format when sampling a cleared colo

[Mesa-dev] Mesa i965 instruction scheduler latency values

2015-11-23 Thread Eero Tamminen
Hi, Mesa i965 instruction scheduler latency values look weird. For example: -- void schedule_node::set_latency_gen7(bool is_haswell) { switch (inst->opcode) { ... case SHADER_OPCODE_UNTYPED_SURFACE_READ: case SHADER_OPCODE_UNTYPED_SURFACE_WRITE: case SHADER_OPCODE

Re: [Mesa-dev] [PATCH v2 2/2] targets: use the non-inline sw helpers

2015-11-23 Thread Oded Gabbay
On Mon, Nov 23, 2015 at 5:28 PM, Emil Velikov wrote: > Previously (with the inline ones) things were embedded into the > pipe-loader, which means that we cannot control/select what we want in > each target. > > That also meant that at runtime we ended up with the empty > sw_screen_create() as the

[Mesa-dev] [PATCH v2 2/2] targets: use the non-inline sw helpers

2015-11-23 Thread Emil Velikov
Previously (with the inline ones) things were embedded into the pipe-loader, which means that we cannot control/select what we want in each target. That also meant that at runtime we ended up with the empty sw_screen_create() as the GALLIUM_SOFTPIPE/LLVMPIPE were not set. v2: Cover all the target

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jan Vesely
On Tue, 2015-11-24 at 01:07 +1100, Jonathan Gray wrote: > On Mon, Nov 23, 2015 at 07:52:44AM -0600, Jan Vesely wrote: > > On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > > > Use PKG_CHECK_MODULES to get the flags to link libelf. > > > > This has been discussed before, and it does not wor

[Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index ce75e2d..25d2940 100644 --

[Mesa-dev] [PATCH 6/8] st/va: move MPEG4 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 186 +- src/gallium/state_trackers/va/picture_mpeg4.c | 209 + src/gallium/state_tracker

[Mesa-dev] [PATCH 2/8] st/va: move post processing function into own file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 58 +--- src/gallium/state_trackers/va/postproc.c | 94 ++ src/gallium/state_trackers/va/va_

[Mesa-dev] [PATCH 7/8] st/va: move HEVC functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 174 + src/gallium/state_trackers/va/picture_hevc.c | 159 ++ src/gallium/state_tracker

[Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

2015-11-23 Thread Christian König
From: Christian König The dirty area in this call isn't related to the screen at all. Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_

[Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Christian König
From: Christian König The workarounds are to hacky to enable them by default and otherwise MPEG4 doesn't work reliable. Signed-off-by: Christian König --- src/gallium/state_trackers/va/config.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trac

[Mesa-dev] [PATCH 3/8] st/va: move MPEG12 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 57 +++--- src/gallium/state_trackers/va/picture_mpeg12.c | 80 ++ src/gallium/state_trackers/va/v

[Mesa-dev] [PATCH 5/8] st/va: move VC-1 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 36 +- src/gallium/state_trackers/va/picture_vc1.c| 67 ++ src/gallium/state_trackers/va/va_pr

[Mesa-dev] [PATCH 4/8] st/va: move H264 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 76 + src/gallium/state_trackers/va/picture_h264.c | 113 + src/gallium/state_trackers/va/

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez > wrote: >> Chad Versace writes: >> >>> On Wed 04 Nov 2015, Jason Ekstrand wrote: Previously, we were relying on has_matching_typed_format returning true for MESA_FORMAT_NONE which, in turn, relied on _mesa_get

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jonathan Gray
On Mon, Nov 23, 2015 at 07:52:44AM -0600, Jan Vesely wrote: > On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > > Use PKG_CHECK_MODULES to get the flags to link libelf. > > This has been discussed before, and it does not work with elfutils: > http://lists.freedesktop.org/archives/mesa-dev/

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 03:24, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf. > > Signed-off-by: Jonathan Gray > Cc: "11.0 11.1" > --- > configure.ac | 4 +--- > src/gallium/drivers/radeon/Makefile.am | 2 +- > src/gallium/targets/opencl/M

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jan Vesely
On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf. This has been discussed before, and it does not work with elfutils: http://lists.freedesktop.org/archives/mesa-dev/2014-October/069748.html Jan > > Signed-off-by: Jonathan Gray > Cc

  1   2   >