On Wed, 2015-07-29 at 21:58 +0200, Marek Olšák wrote:
> Hi,
>
> Where does the spec say we should fail to link? I don't see such a
> statement there.
I have reviewed ARB_gpu_shader5 and I don't see any specific mentions to
what should be done in this particular case. That said, isn't this the
log
This fixes a lot of failing tests in:
ES31-CTS.program_interface_query.uniform-types
Signed-off-by: Tapani Pälli
---
src/mesa/main/program_resource.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c
Hi;
This together with Timothy's "set stage flag for structs and arrays
in resource list" fixes following failing conformance test:
ES31-CTS.program_interface_query.uniform-types
Tapani Pälli (1):
mesa: support arrays of structures in GetProgramResourceIndex
src/mesa/main/program_resource
On 07/30/2015 08:50 AM, Timothy Arceri wrote:
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote:
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote:
>On 07/30/2015 08:25 AM, Tapani Pälli wrote:
>> Hi Timothy;
>>
>> Would it be OK for you to wait a bit with these 3 first patches? I'm
>> currently going through failing PIQ tests and I have a 1 line fix to
>> valid_program_resource_index_
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
valid_program_resource_index_name() that together with your patch
"glsl: set stage flag for structs
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
valid_program_resource_index_name() that together with your patch "glsl:
set stage flag for structs and arrays in resource list" will fix all of
I had sightly different fix for this but on same lines;
Reviewed-by: Tapani Pälli
On 07/29/2015 04:56 PM, Timothy Arceri wrote:
This fixes the remaining failing tests in:
ES31-CTS.program_interface_query.uniform-types
Reviewed-by: Samuel Iglesias Gonsálvez
---
src/glsl/linker.cpp | 16
On Wed, 2015-07-29 at 12:31 -0700, Ian Romanick wrote:
> On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> > When a transform feedback object is bound and not active, the
> > OpenGL ES
> > 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow
> > its
> > deletion. Only the d
On Wed, Jul 29, 2015 at 8:33 PM, Matt Turner wrote:
> On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee wrote:
>> u_surface.c: In function 'util_resource_copy_region':
>> u_surface.c:257:21: warning: variable 'src_format' set but not used
>> [-Wunused-but-set-variable]
>> enum pipe_format src_form
On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee wrote:
> u_surface.c: In function 'util_resource_copy_region':
> u_surface.c:257:21: warning: variable 'src_format' set but not used
> [-Wunused-but-set-variable]
> enum pipe_format src_format, dst_format;
> ^
>
> Signed-off-by:
draw/draw_llvm.c: In function 'create_jit_sampler_type':
draw/draw_llvm.c:178:22: warning: unused variable 'target' [-Wunused-variable]
LLVMTargetDataRef target = gallivm->target;
^
draw/draw_llvm.c: In function 'create_jit_context_type':
draw/draw_llvm.c:218:22: warning:
lp_bld_tgsi_soa.c: In function 'lp_emit_immediate_soa':
lp_bld_tgsi_soa.c:3065:18: warning: unused variable 'size' [-Wunused-variable]
const uint size = imm->Immediate.NrTokens - 1;
^
Signed-off-by: Vinson Lee
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 3 +--
u_surface.c: In function 'util_resource_copy_region':
u_surface.c:257:21: warning: variable 'src_format' set but not used
[-Wunused-but-set-variable]
enum pipe_format src_format, dst_format;
^
Signed-off-by: Vinson Lee
---
src/gallium/auxiliary/util/u_surface.c | 1 +
1
pb_buffer_fenced.c: In function 'fenced_buffer_fence':
pb_buffer_fenced.c:849:18: warning: variable 'destroyed' set but not used
[-Wunused-but-set-variable]
boolean destroyed;
^
Signed-off-by: Vinson Lee
---
src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c | 1 +
On Wed, Jul 29, 2015 at 10:18 PM, Edward O'Callaghan
wrote:
> On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote:
>> I assume that you mean the C99 spec? I don't think MSVC supports %t or %z
>> :(
>
> Correct, why not it is standard C99 sounds like a compiler bug to me if
> that is really the ca
On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote:
> I assume that you mean the C99 spec? I don't think MSVC supports %t or %z
> :(
Correct, why not it is standard C99 sounds like a compiler bug to me if
that is really the case :/
>
> On Wed, Jul 29, 2015 at 7:46 PM, Edward O'Callaghan
> wro
From: Dave Airlie
these also hit the problem case but I don't think this patch
is the answer,
do I need to flesh out the .8.8.8.8_UNORM ones into .8.8.8.8_UINT
types?
Signed-off-by: Dave Airlie
---
src/mesa/main/glformats.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/
From: Dave Airlie
GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies
a lot more things than just rgb10/a2ui.
While playing with ogl conform one of the tests must
attempted all valid formats for GL3.3 and hits the
unreachable here.
This adds the first chunk of formats that hit the
assert.
S
I ran GL41-CTS.gtf32.* from ogl conform, and fell over a lot
in the unreachable in glformats.c
Looks like a bunch of stuff is missing, now I'm not sure
how much is required to add it all, the first patch is probably
okay, the second is just a hint on if I need to flesh out some
types for the _UIN
From: Dave Airlie
The API can hit this, as the ogl confirm suite showed, I've
sent a piglit test to also demonstrate hitting it.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_cb_xformfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_cb_xformfb.c
b/sr
On Wed, 2015-07-29 at 10:14 -0400, Ilia Mirkin wrote:
> On Wed, Jul 29, 2015 at 9:56 AM, Timothy Arceri
> wrote:
> > These changes are also needed to allow linking of
> > struct and interface arrays of arrays.
> > ---
> > src/glsl/link_uniforms.cpp | 16 ++--
> > 1 file changed, 6 in
From: Dave Airlie
This is the final piece for ARB_gpu_shader5,
The code is based on the r600 code from Glenn Kennard,
and myself.
While developing this, I'm not 100% sure of all the calculations
made in the GS registers, this is why the max_stream is worked
out there and used to limit the chang
I assume that you mean the C99 spec? I don't think MSVC supports %t or %z :(
On Wed, Jul 29, 2015 at 7:46 PM, Edward O'Callaghan
wrote:
> See §7.19.6.1, paragraph 7 of the ISO C specification.
>
> Signed-off-by: Edward O'Callaghan
> ---
> src/mesa/main/bufferobj.c | 2 +-
> 1 file changed, 1 in
See §7.19.6.1, paragraph 7 of the ISO C specification.
Signed-off-by: Edward O'Callaghan
---
src/mesa/main/bufferobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 9425b09..453b864 100644
--- a/src/mesa/main/buffe
Signed-off-by: Edward O'Callaghan
---
src/gallium/drivers/r600/compute_memory_pool.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600/compute_memory_pool.c
index 413aa3d..7c5113e 100644
--- a/src
Rather boring patches to fix a few compiler warnings.
Edward O'Callaghan (2):
r600: Fix some printf format warns pretaining to PRIi64
mesa: Fix printf format specifier warn of the ptrdiff_t
src/gallium/drivers/r600/compute_memory_pool.c | 8
src/mesa/main/bufferobj.c
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Iago Toral Quiroga
>
> Currently, we only consider precision qualifiers at compile-time. This patch
> adds precision information to ir_variable so we can also do link time checks.
> Specifically, from the GLSL ES3 spec, 4.5.3 Precis
On Tuesday, July 21, 2015 07:54:24 PM Connor Abbott wrote:
> Signed-off-by: Connor Abbott
> ---
> src/glsl/nir/nir_control_flow.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/glsl/nir/nir_control_flow.c b/src/glsl/nir/nir_control_flow.c
> index b416a58..b99bf89 100644
> -
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Iago Toral Quiroga
>
> We will need this later on when we implement proper support for precision
> qualifiers in the drivers and also to do link time checks for uniforms as
> indicated by the spec.
>
> This patch also adds compile-
The pass is now working (it does the right thing) but something
ends up crashing after the pass is run, for some reason.
I haven't gotten to debug this yet, but thought I'd replace
the incredibly faulty patch that was on the list with a better one.
Sorry for the noise.
I've confirmed that phi's ge
On Wednesday, July 29, 2015 05:51:46 PM Neil Roberts wrote:
> Previously it could end up using the “SKL early” device on BXT
> depending on the revision number. This would probably break things
> because for example has_llc would be wrong.
> ---
> src/mesa/drivers/dri/i965/brw_device_info.c | 4 ++
On 07/29/2015 02:50 PM, Ian Romanick wrote:
> On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
>> From: Iago Toral Quiroga
>>
>> The GLSL ES spec specifies default precision qualifiers for certain types,
>> so populate the symbol table with these.
>>
>> Notice that the desktop GLSL spec al
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Iago Toral Quiroga
>
> The GLSL ES spec specifies default precision qualifiers for certain types,
> so populate the symbol table with these.
>
> Notice that the desktop GLSL spec also indicates defaults for some types
> but this is
R600/R700 can also do:
- ARB_conditional_render_inverted
- ARB_cull_distance
Marek
On Wed, Jul 29, 2015 at 11:46 PM, Marek Olšák wrote:
> Hi Ilia,
>
> R600/R700:
> - can't do ARB_shader_storage_buffer_object
> - can do ARB_robust_buffer_access_behavior (I think this one can
> really be exposed u
Hi Ilia,
R600/R700:
- can't do ARB_shader_storage_buffer_object
- can do ARB_robust_buffer_access_behavior (I think this one can
really be exposed unconditionally on all GL>=3 hardware)
- can do ARB_framebuffer_no_attachments
- ARB_query_buffer_object can be emulated with a vertex shader to read
t
Reviewed-by: Marek Olšák
Marek
On Wed, Jul 29, 2015 at 1:20 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This enables GL4.1 for radeonsi, and updates the
> docs in the correct places.
>
> v2: enable only for llvm 3.7 which has fixes in place.
>
> Reviewed-by: Marek Olšák
> Signed-off-by: Da
On Wed, Jul 29, 2015 at 1:20 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This is the final piece for ARB_gpu_shader5,
>
> The code is based on the r600 code from Glenn Kennard,
> and myself.
>
> While developing this, I'm not 100% sure of all the calculations
> made in the GS registers, this i
https://bugs.freedesktop.org/show_bug.cgi?id=90264
Gustaw Smolarczyk changed:
What|Removed |Added
CC||wielkie...@gmail.com
--
You are rec
This patch is
Reviewed-by: Ian Romanick
I think this patch could also be tagged for the 10.6.x series.
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Eduardo Lima Mitev
>
> Page 161 of the OpenGL-ES 3.1 (PDF) spec, and page 207 of the OpenGL 4.5
> (PDF),
> both on section '
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Eduardo Lima Mitev
>
> Argument validation for glTexSubImageXD is missing a check of format and type
> against texture object's internal format when profile is OpenGL-ES 3.0+.
Blarg. I see that we have nearly identical code in
tex
Hi,
Where does the spec say we should fail to link? I don't see such a
statement there.
It looks like varyings with stream > 0 should not be linked with the
fragment shader.
Marek
On Wed, Jun 18, 2014 at 11:51 AM, Iago Toral Quiroga wrote:
> Outputs that are linked to inputs in the next stage
This patch is
Reviewed-by: Ian Romanick
This patch should definitely be tagged for the 10.6.x series. I suspect
this problem was introduced when the DSA work landed.
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Eduardo Lima Mitev
>
> Currently, glTexSubImageXD attempt to
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Eduardo Lima Mitev
>
> Page 68, section 7.2 'Shader Binaries" of the of the OpenGL ES 3.1,
> and page 88 of the OpenGL 4.5 specs state:
>
> "An INVALID_VALUE error is generated if count or length is negative.
> An INVALID_
This patch is
Reviewed-by: Ian Romanick
I think this patch could also be tagged for the 10.6.x series.
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> From: Iago Toral Quiroga
>
> From section 9.2. Binding and Managing Framebuffer Objects:
>
> "Upon successful return from Get*Fram
This patch adjusts the SKL values to the best known values we have. It also adds
the missing HS/DS/CS fields. To support this patch I needed to add some default
values to BXT. Those values are just minimal values which we can use for
enabling.
Note to backporter: You can drop the BXT change (secon
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote:
> When a transform feedback object is bound and not active, the OpenGL ES
> 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its
> deletion. Only the deletion of the default framebuffer object is
On 07/29/2015 09:05 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 2:55 PM, Mario Kleiner
wrote:
On 07/29/2015 08:50 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner
wrote:
On 07/29/2015 05:46 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 10:44 AM, Emil Veli
On Wed, Jul 29, 2015 at 2:55 PM, Mario Kleiner
wrote:
> On 07/29/2015 08:50 PM, Alex Deucher wrote:
>>
>> On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner
>> wrote:
>>>
>>>
>>>
>>> On 07/29/2015 05:46 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov
w
On 07/29/2015 08:50 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner
wrote:
On 07/29/2015 05:46 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov
wrote:
Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
Although it did not consid
On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner
wrote:
>
>
> On 07/29/2015 05:46 PM, Alex Deucher wrote:
>>
>> On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov
>> wrote:
>>>
>>> Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
>>> Although it did not consider the (very unlikely) cas
On 07/29/2015 05:46 PM, Alex Deucher wrote:
On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov wrote:
Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
Although it did not consider the (very unlikely) case where we might end
up with the valid fd == 0.
Fixes: 28dda47ae4d(winsys/ra
On Wed, Jul 29, 2015 at 2:20 PM, Emil Velikov wrote:
> Hi all,
>
> Below is the preliminary release schedule for Mesa 11.0.0
>
> August 21st 2015 - Feature freeze/Release candidate 1
> August 28th 2015 - Release candidate 2
> September 04th 2015 - Release candidate 3
> September 11th 2015 - Releas
Hi all,
Below is the preliminary release schedule for Mesa 11.0.0
August 21st 2015 - Feature freeze/Release candidate 1
August 28th 2015 - Release candidate 2
September 04th 2015 - Release candidate 3
September 11th 2015 - Release candidate 4/Mesa 11.0.0
We have roughly three weeks for new featu
On Wed, Jul 29, 2015 at 05:51:38PM +0100, Neil Roberts wrote:
> I tested this on my BXT by running the glsl-fs-color-matrix test (which
> ends up using MAD in SIMD16) and it worked fine.
>
> Tested-by: Neil Roberts
> Reviewed-by: Neil Roberts
>
> - Neil
Crap. I just pushed this before I notice
On 29 July 2015 at 18:21, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin
>
> Do you also need to do something for it to claim it's 11.0-gblah in the
> version?
>
Nice one, thanks. I'll squash the following hunk.
diff --git a/VERSION b/VERSION
index 1edd8fc..2b1181d 100644
--- a/VERSION
+++ b/VER
https://bugs.freedesktop.org/show_bug.cgi?id=90264
--- Comment #42 from Thomas Hellström ---
Hi!
I'm on vacation and will be back on August 2nd 2015.
Thanks,
Thomas Hellstr?m
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=90264
Furkan changed:
What|Removed |Added
CC||jajo...@nvidia.com,
|
Looks good to me.
Reviewed-by: Neil Roberts
- Neil
Anuj Phogat writes:
> Signed-off-by: Anuj Phogat
> Cc: Neil Roberts
> ---
> src/mesa/main/format_parser.py | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/src/mesa/main/format_parser.py b/src/mesa/main/format_parser.py
> ind
Static analysis tools don't like partial object initializations.
---
src/glsl/lower_subroutine.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/glsl/lower_subroutine.cpp b/src/glsl/lower_subroutine.cpp
index e45ccfe..b29912a 100644
--- a/src/glsl/lower_subroutine.c
Signed-off-by: Anuj Phogat
Cc: Neil Roberts
---
src/mesa/main/format_parser.py | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/mesa/main/format_parser.py b/src/mesa/main/format_parser.py
index 11184f7..799b14f 100755
--- a/src/mesa/main/format_parser.py
+++ b/src/mesa/main/format_p
https://bugs.freedesktop.org/show_bug.cgi?id=90264
Heiko changed:
What|Removed |Added
CC||lil_...@web.de
--- Comment #40 from Heiko ---
C
Reviewed-by: Ilia Mirkin
Do you also need to do something for it to claim it's 11.0-gblah in the version?
On Wed, Jul 29, 2015 at 1:20 PM, Emil Velikov wrote:
> Recently a few drivers have grown OpenGL 4+ support so we might as
> well go all the way to... 11 ;-)
>
> Signed-off-by: Emil Velikov
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov wrote:
> This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
> lookup over the server's.) from glx/dri2.
>
> Cc: Eric Anholt
> Cc: Julien Isorce
> Reported-by: Julien Isorce
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dr
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov wrote:
> Strictly speaking the xcb_connection_has_error() might be sufficient,
> yet the documentation does not mention what will happen if NULL is fed
> to the function.
>
> Keep things explicit, which will allow us to remove the dri2_dpy->conn
> chec
Recently a few drivers have grown OpenGL 4+ support so we might as
well go all the way to... 11 ;-)
Signed-off-by: Emil Velikov
---
Hats down for all that made it possible. Keep up the amazing work !
-Emil
docs/relnotes/{10.7.0.html => 11.0.0.html} | 12 ++--
1 file changed, 6 inserti
On Wed, Jul 29, 2015 at 10:11 AM, Anuj Phogat wrote:
> Fixes following compiler warning:
> brw_cs.cpp:386:27: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
> Signed-off-by: Anuj Phogat
> Cc: Matt Turner
> ---
Perfect. Thanks!
Reviewed-by: Matt Turner
Fixes following compiler warning:
brw_cs.cpp:386:27: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
Signed-off-by: Anuj Phogat
Cc: Matt Turner
---
src/mesa/drivers/dri/i965/brw_context.h | 12 ++--
src/mesa/drivers/dri/i965/brw_cs.cpp| 2 +-
2
On Wed, Jul 29, 2015 at 9:45 AM, Matt Turner wrote:
> On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat wrote:
>> brw_cs.cpp:386:27: warning: comparison between signed and unsigned
>> integer expressions [-Wsign-compare]
>>
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/dri/i965/brw_cs.cpp
Previously it could end up using the “SKL early” device on BXT
depending on the revision number. This would probably break things
because for example has_llc would be wrong.
---
src/mesa/drivers/dri/i965/brw_device_info.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/m
I tested this on my BXT by running the glsl-fs-color-matrix test (which
ends up using MAD in SIMD16) and it worked fine.
Tested-by: Neil Roberts
Reviewed-by: Neil Roberts
- Neil
Ben Widawsky writes:
> This is easily accomplished by moving simd16 3src to GEN9_FEATURES.
>
> Signed-off-by: Ben
On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat wrote:
> brw_cs.cpp:386:27: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 28 July 2015 at 14:37, Brian Paul wrote:
> On 07/28/2015 07:33 AM, Emil Velikov wrote:
>>
>> On 20 July 2015 at 17:12, Brian Paul wrote:
>>>
>>> On 07/17/2015 02:14 PM, Emil Velikov wrote:
On 17 July 2015 at 20:22, Brian Paul wrote:
>
>
> Can you elaborate in the co
On Wed, Jul 29, 2015 at 8:16 AM, Neil Roberts wrote:
> It seems a bit weird to modify the the is_power_of_two functions in
> format_parser.py, was that intentional? It doesn't look like those
> functions are actually used anywhere so maybe we could just remove them,
> although it would probably ma
On Tue, Jul 28, 2015 at 12:06 PM, Jason Ekstrand wrote:
> The meta CopyImageSubData path uses BlitFramebuffers to do the actual copy.
> The only thing that can affect BlitFramebuffers other than the currently
> bound framebuffers is the scissor so we need to save that off and reset it.
> If we don
On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral wrote:
> Funny, we had 3 instances of the same function with the same
> implementation :), there is still util_is_power_of_two in Gallium btw.
>
Yes. I wasn't sure if we can use main/imports.h in gallium. So, I didn't
touch it.
> Reviewed-by: Iago Tor
On Wed, Jul 29, 2015 at 12:19 PM, Emil Velikov wrote:
> Strictly speaking the xcb_connection_has_error() might be sufficient,
> yet the documentation does not mention what will happen if NULL is fed
> to the function.
>
> Keep things explicit, which will allow us to remove the dri2_dpy->conn
> che
This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
lookup over the server's.) from glx/dri2.
Cc: Eric Anholt
Cc: Julien Isorce
Reported-by: Julien Isorce
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 11 ++-
1 file changed, 10 insertions(+), 1
Allows us, with the next commit, to use alternative driver_name rather
than the one from xserver.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_
If the connection is NULL we won't be able to get here.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index 7a2
No real change, apart from keeping the calls to the underlying winsys
(x11) next to each other. Just like platform_wayland.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_
Strictly speaking the xcb_connection_has_error() might be sufficient,
yet the documentation does not mention what will happen if NULL is fed
to the function.
Keep things explicit, which will allow us to remove the dri2_dpy->conn
checking with the next commit.
Signed-off-by: Emil Velikov
---
src
With the follow up commits we're about to further reshuffle things. Thus
we'll honour our our driver_name lookup (src/loader), and use the one
provided by xserver as a fall-back.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 10 +-
1 file changed, 5 insertions(+),
On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov wrote:
> Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
> Although it did not consider the (very unlikely) case where we might end
> up with the valid fd == 0.
>
> Fixes: 28dda47ae4d(winsys/radeon: Use dup fd as key in drm-winsys ha
Marek Olšák wrote on 28.07.2015 21:42:
> On Tue, Jul 28, 2015 at 6:35 PM, Kai Wasserbäch
> wrote:
>> Marek Olšák wrote on 28.07.2015 12:05:
>>> From: Marek Olšák
>>>
>>> ---
>>> src/gallium/auxiliary/util/u_debug.c | 8
>>> src/gallium/auxiliary/util/u_debug.h | 6 +++---
>>> 2 files ch
It seems a bit weird to modify the the is_power_of_two functions in
format_parser.py, was that intentional? It doesn't look like those
functions are actually used anywhere so maybe we could just remove them,
although it would probably make sense to do that in a separate patch.
Regards,
- Neil
Anu
On 29 July 2015 at 15:16, Emil Velikov wrote:
> This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
> lookup over the server's.) from glx/dri2.
>
> Cc: Eric Anholt
> Reported-by: Julien Isorce
> Signed-off-by: Emil Velikov
> ---
Scratch this patch. Seems like we need to reshuff
Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue.
Although it did not consider the (very unlikely) case where we might end
up with the valid fd == 0.
Fixes: 28dda47ae4d(winsys/radeon: Use dup fd as key in drm-winsys hash
table to fix ZaphodHeads.)
Cc: Mario Kleiner
Signed-off-by:
Jason Ekstrand writes:
> On Jul 29, 2015 3:12 AM, "Francisco Jerez" wrote:
>>
>> Jason Ekstrand writes:
>>
>> > On Tue, Jul 28, 2015 at 1:23 AM, Francisco Jerez
> wrote:
>> >> Instead of relying on the default one. This shouldn't lead to any
>> >> functional changes because DEP_RESOLVE_MOV ov
On Wed, Jul 29, 2015 at 9:56 AM, Timothy Arceri wrote:
> These changes are also needed to allow linking of
> struct and interface arrays of arrays.
> ---
> src/glsl/link_uniforms.cpp | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/link_uniforms.
On Jul 29, 2015 3:12 AM, "Francisco Jerez" wrote:
>
> Jason Ekstrand writes:
>
> > On Tue, Jul 28, 2015 at 1:23 AM, Francisco Jerez
wrote:
> >> Instead of relying on the default one. This shouldn't lead to any
> >> functional changes because DEP_RESOLVE_MOV overrides the execution
> >> controls
This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
lookup over the server's.) from glx/dri2.
Cc: Eric Anholt
Reported-by: Julien Isorce
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff
From: Iago Toral Quiroga
The GLSL ES spec specifies default precision qualifiers for certain types,
so populate the symbol table with these.
Notice that the desktop GLSL spec also indicates defaults for some types
but this is not really useful since precision qualifiers are completely
ignored in
From: Iago Toral Quiroga
Shaders with excessive number of attributes (>16) can produce a crash
due to buffer overflow in assign_attribute_or_color_locations. The
overflow can happen because we declare a fixed size array that can hold
up to 16 attributes and we don't check that we don't go beyond
This patch is
Reviewed-by: Ilia Mirkin
On Wed, Jul 29, 2015 at 9:57 AM, Timothy Arceri wrote:
> V2: add missing 's' to the extension name in error messages
> and add decimal place in version string
> ---
> src/glsl/ast_to_hir.cpp | 13 -
> src/glsl/glsl_parser.yy | 22
---
src/glsl/nir/nir_types.cpp | 6 ++
src/glsl/nir/nir_types.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp
index 62176f5..06f5b0a 100644
--- a/src/glsl/nir/nir_types.cpp
+++ b/src/glsl/nir/nir_types.cpp
@@ -106,6 +106,12 @@
This marks all counters in an AoA as active.
For AoA all but the innermost array are threated as separate
counters/uniforms. The Nvidia binary also goes further and
finds inactive counters in the AoA, in future we should do
this too, however this gets things working for the time being.
This chang
From: Iago Toral Quiroga
So they can hide declarations with the same name in other scopes.
Otherwise we get a parsing error for things like:
struct S { int val; };
int func (int S) { return S; }
Fixes the following 2 dEQP tests:
dEQP-GLES3.functional.shaders.scoping.valid.function_parameter_hid
From: Eduardo Lima Mitev
Currently, glTexSubImageXD attempt to resolve the texture object
(by calling _mesa_get_current_tex_object()) before validating the given
target. However, that method explicitly states that target must have been
validated before calling it, so it never returns a user error
From: Iago Toral Quiroga
These have scoping rules that match the ones defined for other things such
as variables, so we want them in the symbol table.
---
src/glsl/glsl_symbol_table.cpp | 24
src/glsl/glsl_symbol_table.h | 2 ++
2 files changed, 26 insertions(+)
diff
1 - 100 of 154 matches
Mail list logo
