https://bugs.freedesktop.org/show_bug.cgi?id=91099
José Fonseca changed:
What|Removed |Added
CC||i...@freedesktop.org
Blocks|
https://bugs.freedesktop.org/show_bug.cgi?id=90539
José Fonseca changed:
What|Removed |Added
Depends on||91099
--
You are receiving this mail bec
Hi,
The ARB asm programs only allow indirect addressing into the constant buffer.
Only GLSL allows indirect addressing everywhere and GLSL-to-TGSI
already generates proper array declarations, so we should be fine.
I think we can just assume that indirect addressing into TEMP, INPUT,
or OUTPUT wi
On 06/09/2015 07:41 PM, Ian Romanick wrote:
> On 06/04/2015 06:38 PM, Ben Widawsky wrote:
>> On Wed, Mar 11, 2015 at 10:01:24AM +0100, Eduardo Lima Mitev wrote:
>>> Page 68, section 7.2 'Shader Binaries" of the of the OpenGL ES 3.1,
>>> and page 88 of the OpenGL 4.5 specs state:
>>>
>>> "An INV
On 06/05/2015 03:43 AM, Ben Widawsky wrote:
> On Wed, Mar 11, 2015 at 10:01:25AM +0100, Eduardo Lima Mitev wrote:
>>
>> Fixes 1 dEQP test:
>> * dEQP-GLES3.functional.negative_api.texture.copyteximage2d_invalid_format
>> ---
>> src/mesa/main/teximage.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 d
On Wed, 2015-06-24 at 18:39 -0700, Anuj Phogat wrote:
> Meta pbo path for ReadPixels rely on BlitFramebuffer which doesn't support
> signed to unsigned integer conversions and vice versa.
>
> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, when
> forced to use the meta pbo
From: Dave Airlie
This isn't pretty and I'd suggest it the pm4 interface builder
could be tweaked to do this more efficently, but I'd need
guidance on how that would look.
This seems to pass the few piglit tests I threw at it.
v2: handle passing layer/viewport index to fragment shader.
fix cras
I'd be a big fan of letting it go.. if needed for old ARB shader
stuff we can give entire IN/OUT file ArrayID==1.. if someone points me
in the right direction I don't mind going and poking at it since the
whole assuming-the-worst thing if ArrayID==0 is not so nice for
register allocation..
BR,
-R
gen8 had some special restrictions which don't seem to carry over to gen9.
Quoting the spec for SKL:
"The Z_Height and Z_Width values must equal those present in
3DSTATE_DEPTH_BUFFER incremented by one."
This fixes nothing in piglit (and regresses nothing).
Cc: Jordan Justen
Signed-off-by: Ben W
From: Dave Airlie
This isn't pretty and I'd suggest it the pm4 interface builder
could be tweaked to do this more efficently, but I'd need
guidance on how that would look.
This seems to pass the few piglit tests I threw at it.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/radeonsi/si_bli
On 24.06.2015 22:16, Emil Velikov wrote:
> On 24 June 2015 at 10:28, Marek Olšák wrote:
>>
>> This is how I build 32-bit Mesa:
>>
>> # Mandatory for 32-bit
>> dir=i386-linux-gnu
>> build=i686-linux-gnu
>> export CFLAGS="-m32 -O2 -g"
>> export CXXFLAGS="$CFLAGS"
>> export LDFLAGS="-L/usr/lib/$dir"
I thought this was needed by something in the gl state tracker. relative
addressing with ARB_vp maybe, can't remember...
I dunno if all places where this is used are fixed up it can go.
Roland
Am 25.06.2015 um 01:31 schrieb Rob Clark:
> tgsi.rst currently says:
>
>
> If no ArrayID is speci
Reviewed-by: Roland Scheidegger
And probably reference the other two too (91100,91101) if it fixes them.
Roland
Am 25.06.2015 um 01:09 schrieb Brian Paul:
> Reviewed-by: Brian Paul
>
> Want to reference bug 91099 in the commit msg?
>
>
> On 06/24/2015 04:59 PM, Marek Olšák wrote:
>> From: M
On Wed, Jun 24, 2015 at 6:39 PM, Anuj Phogat wrote:
> Meta pbo path for ReadPixels rely on BlitFramebuffer which doesn't support
> signed to unsigned integer conversions and vice versa.
>
> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, when
> forced to use the meta pbo pa
Meta pbo path for ReadPixels rely on BlitFramebuffer which doesn't support
signed to unsigned integer conversions and vice versa.
Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, when
forced to use the meta pbo path.
v2: Make need_rgb_to_luminance_conversion() a static func
On Jun 24, 2015 4:29 AM, "Francisco Jerez" wrote:
>
> Jason Ekstrand writes:
>
> > On Tue, Jun 23, 2015 at 9:22 AM, Francisco Jerez
wrote:
> >> Jason Ekstrand writes:
> >>
> >>> We want to move these into the builder so that they know the current
> >>> builder's dispatch width. This will be ne
I Have successfully tested and validate patch 1,3,4 on BXT
Regards,
Philippe
Intel Corporation NV/SA
Kings Square, Veldkant 31
2550 Kontich
RPM (Bruxelles) 0415.497.718.
Citibank, Brussels, account 570/1031255/09
This e-mail and any attachments may contain confidential material for the sole
use
On Wed, Jun 24, 2015 at 3:51 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> Although the horizontal and vertical alignment fields are ignored here,
> 0 is a reserved value for them and may cause undefined behavior. Change
> the default value to an abitrary valid one.
>
> Signed-off-by: Nanley C
On Tue, Jun 23, 2015 at 3:34 AM, Iago Toral Quiroga wrote:
> readpixels_can_use_memcpy will later call _mesa_format_matches_format_and_type
> which does much tighter checks than these to decide if we can use
> memcpy for readpixels.
>
> Also, the checks do not seem to be extensive enough anyway, s
https://bugs.freedesktop.org/show_bug.cgi?id=91101
Bug ID: 91101
Summary: [softpipe] piglit
glsl-1.50@execution@geometry@max-input-components
regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64
> -fno-strict-aliasing:with strict aliasing:
> libGL.so 699188 699188(no change)
> *_dri.so 9575876 9563104(-2772)
>
Use the size command to get the actual text segment size,
otherwise debugging symbols can drown change
On Wed, Jun 24, 2015 at 08:12:36PM +, Lecluse, Philippe wrote:
> I Have successfully tested and validate patch 1,3,4 on BXT
> Regards,
> Philippe
> Intel Corporation NV/SA
> Kings Square, Veldkant 31
> 2550 Kontich
> RPM (Bruxelles) 0415.497.718.
> Citibank, Brussels, account 570/1031255/09
>
This is an alternative to my earlier patch [1] (and it is now constructed
properly using git format-patch).
Quick background:
There is a problem in exec_list due to it directly including a trio
of 'struct exec_node *' members to implement two overlapping sentinel
nodes. The sentinel nodes do not
tgsi.rst currently says:
If no ArrayID is specified with an indirect addressing operand the whole
register file might be accessed by this operand. This is strongly discouraged
and will prevent packing of scalar/vec2 arrays and effective alias analysis.
I'd be pretty happy to remove it a
https://bugs.freedesktop.org/show_bug.cgi?id=91100
Bug ID: 91100
Summary: [softpipe] piglit egl-create-pbuffer-surface
regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Reviewed-by: Brian Paul
Want to reference bug 91099 in the commit msg?
On 06/24/2015 04:59 PM, Marek Olšák wrote:
From: Marek Olšák
PIPE_MAX_SHADER_INPUTS was recently bumped to 80 because of tessellation.
---
src/gallium/auxiliary/gallivm/lp_bld_limits.h | 2 +-
src/gallium/auxiliary/tg
From: Marek Olšák
PIPE_MAX_SHADER_INPUTS was recently bumped to 80 because of tessellation.
---
src/gallium/auxiliary/gallivm/lp_bld_limits.h | 2 +-
src/gallium/auxiliary/tgsi/tgsi_exec.h| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm
From: Nanley Chery
Although the horizontal and vertical alignment fields are ignored here,
0 is a reserved value for them and may cause undefined behavior. Change
the default value to an abitrary valid one.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/gen8_surface_state.c | 4 ++--
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> ALIGN is changed to ALIGN_NPOT because alignment values are sometimes not
> powers of two when working with ASTC.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/drivers/dri/i965/brw_tex_layout.c| 12 ++--
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> Aligning with a non-power-of-two number is a general task that can be used in
> various places. This commit is required for the next one.
>
> Signed-off-by: Nanley Chery
> ---
> src/mesa/drivers/dri/i965/intel_upload.
https://bugs.freedesktop.org/show_bug.cgi?id=91099
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
CC|
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> ALIGN and ROUND_DOWN_TO both require that the alignment value passed
> into the macro be a power of two in the comments. Using software assertions
> verifies this to be the case.
>
> v2: use static inline functions inst
Indirect addressing without the ArrayID is undefined in the general
case. You need the ArrayID to be able to tell where the array
declaration starts and what its semantic name is.
Marek
On Wed, Jun 24, 2015 at 8:35 PM, Rob Clark wrote:
> On Wed, Jun 24, 2015 at 12:31 PM, Marek Olšák wrote:
>> Y
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> In agreement with the coding style, functions that aren't directly visible
> to the GL API should prefer the use of bool over GLboolean.
>
> Suggested-by: Ian Romanick
> Signed-off-by: Nanley Chery
> ---
> src/mesa/m
https://bugs.freedesktop.org/show_bug.cgi?id=91098
--- Comment #1 from Thomas Hellström ---
Hi.
Thanks for the bug report.
I think the root problem is gnome-shell(gdm) dropping its master privileges and
then trying to render.
The reason this is not allowed in the vmwgfx driver is the following
https://bugs.freedesktop.org/show_bug.cgi?id=91099
Bug ID: 91099
Summary: [llvmpipe] piglit glsl-max-varyings
>max_varying_components regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux
On Wed, Jun 24, 2015 at 12:04 AM, Kenneth Graunke wrote:
> This is always 0 - only brw_workaround_depthstencil_alignment ever sets
> it, and that doesn't run on Gen6+. My initial Broadwell depth state
> commit had this mistake.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i96
https://bugs.freedesktop.org/show_bug.cgi?id=91098
Bug ID: 91098
Summary: vmwgfx null ptr dereference at vmw_screen_ioctl.c:76
due to ioctl failure
Product: Mesa
Version: 10.6
Hardware: Other
OS: All
On Wed, Jun 24, 2015 at 02:29:09PM +0100, Neil Roberts wrote:
> Ben Widawsky writes:
>
> > I think this is beginning to infringe upon the definition of align_w.
> > The total width is a function of it's miptree properties and not the
> > compressed block properties, right?
> >
> > In other words,
The HUD doesn't check if query_create() fails and it calls other
pipe_query functions with NULL pointer instead of a valid query object.
Signed-off-by: Samuel Pitoiset
---
src/gallium/auxiliary/hud/hud_driver_query.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --gi
On Wed, Jun 24, 2015 at 3:59 PM, Davin McCall wrote:
> Hi Ian,
>
> On 23/06/15 23:26, Ian Romanick wrote:
>
> On 06/23/2015 02:36 PM, Thomas Helland wrote:
>
> 2015-06-24 23:05 GMT+02:00 Davin McCall :
>
> Hi - I'm new here.
>
> I've recently started poking the Mesa codebase for little reason othe
On Wed, Jun 24, 2015 at 12:31 PM, Marek Olšák wrote:
> Yes, ArrayID != 0 means it's an array, otherwise it's just a compact
> way to add declarations.
ok.. hmm, I guess tgsi.rst needs an update then..
> I recently added the array support for inputs and outputs, we just
> need to enable it on non
On Sat, Jun 20, 2015 at 5:32 AM, Timothy Arceri wrote:
> Hi all,
>
> The restrictions in ES make the extension easier to implement so
> I thought I'd try get this stuff reviewed an committed before finishing
> up the full extension.
> The bits that I'm still working on for the desktop version are
On Wed, Jun 24, 2015 at 6:07 AM, Emil Velikov wrote:
> Signed-off-by: Emil Velikov
> ---
> src/mesa/main/get_hash_params.py | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
Doh!
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-
Yes, ArrayID != 0 means it's an array, otherwise it's just a compact
way to add declarations.
I recently added the array support for inputs and outputs, we just
need to enable it on non-radeon non-swrast drivers:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6ebe7eabf54936a02acc0968e718e0c264a
On Wed, Jun 24, 2015 at 7:56 AM, Francisco Jerez wrote:
> Jason Ekstrand writes:
>
>> On Wed, Jun 24, 2015 at 6:44 AM, Francisco Jerez
>> wrote:
>>> Jason Ekstrand writes:
>>>
On Jun 24, 2015 6:29 AM, "Francisco Jerez" wrote:
>
> Jason Ekstrand writes:
>
> > On Jun 24, 2
Jason Ekstrand writes:
> On Wed, Jun 24, 2015 at 6:44 AM, Francisco Jerez
> wrote:
>> Jason Ekstrand writes:
>>
>>> On Jun 24, 2015 6:29 AM, "Francisco Jerez" wrote:
Jason Ekstrand writes:
> On Jun 24, 2015 4:29 AM, "Francisco Jerez"
>>> wrote:
>>
>> Jason Ekst
On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
> Iago Toral writes:
>
> > On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote:
> >> I wanted to question whether this was required, based on this text
> >> from the extension spec:
> >>
> >> "The ability to write to buffer objects cre
On Tue, 2015-06-23 at 15:45 -0700, Jordan Justen wrote:
> On 2015-06-22 23:38:14, Iago Toral wrote:
> > On Mon, 2015-06-22 at 14:28 -0700, Jordan Justen wrote:
> > > 24-26 once again makes me wonder if these optimization *can* be used
> > > with SSBOs based on the same ext spec wording I referenced
The cherry-picking to 1.6 is okay with me.
Marek
On Wed, Jun 24, 2015 at 3:52 PM, Brian Paul wrote:
> On 06/24/2015 06:49 AM, Emil Velikov wrote:
>>
>> Hello gents,
>>
>> On 19 June 2015 at 15:39, Brian Paul wrote:
>>>
>>> If the driver says
>>> PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_
It seemed minor enough to not really matter, but I wouldn't be against this
going into 10.5/10.6
On Jun 24, 2015 08:57, "Emil Velikov" wrote:
> Hi Ilia,
> On 19 June 2015 at 17:23, Ilia Mirkin wrote:
> > When adding EXT_polygon_offset_clamp, I first made it core-only, and
> > never moved the enu
On 06/24/2015 06:49 AM, Emil Velikov wrote:
Hello gents,
On 19 June 2015 at 15:39, Brian Paul wrote:
If the driver says PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY=1,
the driver should never receive a pipe_vertex_element::src_offset value
that's not a multiple of four. But the vbuf
On Wed, Jun 24, 2015 at 6:44 AM, Francisco Jerez wrote:
> Jason Ekstrand writes:
>
>> On Jun 24, 2015 6:29 AM, "Francisco Jerez" wrote:
>>>
>>> Jason Ekstrand writes:
>>>
>>> > On Jun 24, 2015 4:29 AM, "Francisco Jerez"
>> wrote:
>>> >>
>>> >> Jason Ekstrand writes:
>>> >>
>>> >> > On Tue, Ju
On 24/06/15 03:35, Ian Romanick wrote:
I'd also like to see assembly dumps with and without
-fno-strict-aliasing of some place where this goes wrong. If you,
Davin, or someone else can point out a specific function that actually
does the wrong thing, I can generate assembly myself. For that
ma
Jason Ekstrand writes:
> On Jun 24, 2015 6:29 AM, "Francisco Jerez" wrote:
>>
>> Jason Ekstrand writes:
>>
>> > On Jun 24, 2015 4:29 AM, "Francisco Jerez"
> wrote:
>> >>
>> >> Jason Ekstrand writes:
>> >>
>> >> > On Tue, Jun 23, 2015 at 9:22 AM, Francisco Jerez <
> curroje...@riseup.net>
>> >
https://bugs.freedesktop.org/show_bug.cgi?id=91077
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Ben Widawsky writes:
> I think this is beginning to infringe upon the definition of align_w.
> The total width is a function of it's miptree properties and not the
> compressed block properties, right?
>
> In other words, if there is a case where align_w != bw, I think
> total_width should be ali
Jason Ekstrand writes:
> On Jun 24, 2015 4:29 AM, "Francisco Jerez" wrote:
>>
>> Jason Ekstrand writes:
>>
>> > On Tue, Jun 23, 2015 at 9:22 AM, Francisco Jerez
> wrote:
>> >> Jason Ekstrand writes:
>> >>
>> >>> We want to move these into the builder so that they know the current
>> >>> build
On 24 June 2015 at 10:28, Marek Olšák wrote:
> Hi,
>
> This is how I build 32-bit Mesa:
>
> # Mandatory for 32-bit
> dir=i386-linux-gnu
> build=i686-linux-gnu
> export CFLAGS="-m32 -O2 -g"
> export CXXFLAGS="$CFLAGS"
> export LDFLAGS="-L/usr/lib/$dir"
On Arch/Gentoo (and maybe others) don't need t
Hi,
If we are going to have to prod all of the code using this list
implementation to solve this problem anyway maybe it would make more
sense to switch to a kernel-style list instead. There is already an
implementation of this in src/util/list.h. I think this style of list
only accesses the point
Signed-off-by: Emil Velikov
---
src/mesa/main/get_hash_params.py | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
index 74ff3ba..c25e1b6 100644
--- a/src/mesa/main/get_hash_params.py
+++ b/src/mesa/main
Hi Ilia,
On 19 June 2015 at 17:23, Ilia Mirkin wrote:
> When adding EXT_polygon_offset_clamp, I first made it core-only, and
> never moved the enum getter back to the GL/GL_CORE section. Similarly,
> ARB_gs5 is a core-only extension, so move its getters to the GL_CORE
> section.
>
Would this be wo
Hello gents,
On 19 June 2015 at 15:39, Brian Paul wrote:
> If the driver says PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY=1,
> the driver should never receive a pipe_vertex_element::src_offset value
> that's not a multiple of four. But the vbuf code wasn't actually adjusting
> the src_
Zoltan Gilian writes:
> Image attributes are passed to the kernel as hidden parameters after the
> image attribute itself. An llvm pass replaces the getter builtins to
> the appropriate parameters.
This seems to be doing essentially the same thing as v1? Is it the
right patch?
> ---
> src/gal
Iago Toral writes:
> On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote:
>> I wanted to question whether this was required, based on this text
>> from the extension spec:
>>
>> "The ability to write to buffer objects creates the potential for
>> multiple independent shader invocations to re
small style nits below ..
On 06/15/2015 02:19 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
v3: only expose enums from GL_ARB_shader_image_load_store
for gles 3.1 and GL core
Signed-off-by: Marta Lofstedt
---
src/mesa/main/get.c | 6 ++
src/mesa/main/get_hash_params.py
On 06/15/2015 02:19 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
v3 : only expose ARB_shader_atomic_counters enums
for gles 3.1 and GL core.
Signed-off-by: Marta Lofstedt
---
src/mesa/main/get.c | 6 ++
src/mesa/main/get_hash_params.py | 22 +-
2
Hi Marta;
In all of the commits you state 'for gles 3.1 and GL core', however we
move enums to a section where they are available for both desktop core
and compatibility contexts (as expected), please change 'GL core' to
'desktop GL' in the message.
I've sent some small comments to patches 1
Ok, I *thought* we didn't get ArrayID on IN/OUT, but only TEMP? If it
is safe to assume that we always get ArrayID that makes it much
easier.
BR,
-R
On Wed, Jun 24, 2015 at 5:39 AM, Marek Olšák wrote:
> It's not an array, because the ArrayID is 0. It's a valid non-array
> declaration. If any TG
Jason Ekstrand writes:
> On Tue, Jun 23, 2015 at 9:22 AM, Francisco Jerez
> wrote:
>> Jason Ekstrand writes:
>>
>>> We want to move these into the builder so that they know the current
>>> builder's dispatch width. This will be needed by a later commit.
>>
>> I very much like the idea of this
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On Tuesday 23 June 2015 23:17:53 Kenneth Graunke wrote:
> Suggested by Jason Ekstrand.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/glsl/nir/nir_opt_peephole_select.c | 20 ++--
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
It's not an array, because the ArrayID is 0. It's a valid non-array
declaration. If any TGSI user doesn't understand it, that user should
be fixed.
Marek
On Tue, Jun 23, 2015 at 3:20 PM, Rob Clark wrote:
> From: Rob Clark
>
> Ok, so actually there is a ttn issue here to fix as well.. but it
> b
Hi,
This is how I build 32-bit Mesa:
# Mandatory for 32-bit
dir=i386-linux-gnu
build=i686-linux-gnu
export CFLAGS="-m32 -O2 -g"
export CXXFLAGS="$CFLAGS"
export LDFLAGS="-L/usr/lib/$dir"
export PKG_CONFIG_PATH="/usr/lib/$dir/pkgconfig"
# Optional
export USER_CFLAGS="-fno-omit-frame-pointer"
expo
On Wed, Jun 24, 2015 at 2:18 AM, Rob Clark wrote:
> On Tue, Jun 23, 2015 at 7:27 PM, Dylan Baker wrote:
>> I have a couple of python pointers for you, feel free to take them or
>> leave them.
>
> cool, thanks..
>
> What do others think about including shadertoy in shader-db? If it is
> a useful
On 24/06/15 03:35, Ian Romanick wrote:
On 06/23/2015 07:01 PM, Dave Airlie wrote:
Oh we've always had aliasing problems this is just one, you can't
expect one person to fix them all at once.
But "With this patch, I can build a working (though perhaps not 100%
bug-free) Mesa without using -fno-
On Wednesday 24 June 2015 00:34:04 Kenneth Graunke wrote:
> From the "apparently I don't know C" files...GCC apparently supports:
>
> x ?: y
>
> which is equivalent to
>
> x ? x : y
>
> except that it doesn't cause side-effects to occur twice. See:
> https://gcc.gnu.org/onlinedocs/gcc/
From the "apparently I don't know C" files...GCC apparently supports:
x ?: y
which is equivalent to
x ? x : y
except that it doesn't cause side-effects to occur twice. See:
https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html#Conditionals
This was confusing and looked like a typo. It
https://bugs.freedesktop.org/show_bug.cgi?id=91079
Marta Löfstedt changed:
What|Removed |Added
CC||cwo...@cworth.org,
|
https://bugs.freedesktop.org/show_bug.cgi?id=91079
--- Comment #1 from Marta Löfstedt ---
Created attachment 116684
--> https://bugs.freedesktop.org/attachment.cgi?id=116684&action=edit
Public PGP key
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assi
https://bugs.freedesktop.org/show_bug.cgi?id=91079
Bug ID: 91079
Summary: New account request
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: med
This is always 0 - only brw_workaround_depthstencil_alignment ever sets
it, and that doesn't run on Gen6+. My initial Broadwell depth state
commit had this mistake.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/gen8_depth_state.c |7 ++-
1 file changed, 2 insertions(+), 5
81 matches
Mail list logo
