[Mesa-dev] [Bug 90162] glGetFramebufferAttachmentParameteriv failing if certain FB attributes are zero

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90162 --- Comment #2 from Tapani Pälli --- I'm not able to reproduce this (tested using Mesa 10.6 and 10.4.7). I noticed from your glxinfo.output that you are using quite old version, Mesa 10.1.3. Could you test with more recent version? -- You are

Re: [Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Tapani Pälli
On 05/11/2015 10:09 PM, Ilia Mirkin wrote: On Mon, May 11, 2015 at 3:02 PM, Ian Romanick wrote: On 05/11/2015 08:23 AM, Ilia Mirkin wrote: On Mon, May 11, 2015 at 9:03 AM, Marta Lofstedt wrote: From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/bufferobj.c | 5 +++--

[Mesa-dev] [Bug 90383] assembly enabled mesa crashes dota2

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90383 --- Comment #10 from Tapani Pälli --- (In reply to Sylvain BERTRAND from comment #8) > I tried -m32. Did not change anything. -m32 and -m64 are only for a gcc > multilib toolchains. Here, it's a normal x86 toolchain, with i686-pc-gnu-gcc > callin

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

2015-05-11 Thread Kenneth Graunke
On Monday, May 11, 2015 05:12:41 PM Matt Turner wrote: > On Tue, May 5, 2015 at 9:57 AM, Francisco Jerez wrote: > > Kenneth Graunke writes: > > > >> On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote: > >>> --- > >>> src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ > >>> src/mes

Re: [Mesa-dev] Regarding X.Org Endless Vacation of Code

2015-05-11 Thread Emil Velikov
Hi Anish, On 11 May 2015 at 20:47, Anish Kanchan wrote: > I looked through the project ideas at > http://www.x.org/wiki/SummerOfCodeIdeas/ which seemed doable to me. I > would like to know more about the following projects - > > 1. Add support for performances counters in the profiling view > I

Re: [Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

2015-05-11 Thread Emil Velikov
On 11 May 2015 at 23:43, Emil Velikov wrote: > The only user (egl_gallium) is not longer around. > > Signed-off-by: Emil Velikov Seems like I goofed up the numbering - there is no patch 6/6 in the series. I've picked up Marc-André Lureau's fix to silence the compiler warnings. -Emil

[Mesa-dev] Regarding X.Org Endless Vacation of Code

2015-05-11 Thread Anish Kanchan
I looked through the project ideas at http://www.x.org/wiki/SummerOfCodeIdeas/ which seemed doable to me. I would like to know more about the following projects - 1. Add support for performances counters in the profiling view 2. GL/GLSL tests for GL 4.0 and newer I have worked on projects using C

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

2015-05-11 Thread Matt Turner
On Tue, May 5, 2015 at 9:57 AM, Francisco Jerez wrote: > Kenneth Graunke writes: > >> On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ >>> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 9 + >>> 2 files changed,

[Mesa-dev] [PATCH] egl/main: fix EGL_KHR_get_all_proc_addresses

2015-05-11 Thread Emil Velikov
The extension requires that the address of the core functions should be available via eglGetProcAddress. Currently the list is guarded by _EGL_GET_CORE_ADDRESSES, which was only set for the scons (windows) build. Unconditionally enable it for all the builds (automake, android and haiku) considerin

Re: [Mesa-dev] [PATCH 6/6] egl: more define fixes for EGL_MESA_image_dma_buf_export

2015-05-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, May 12, 2015 at 12:43 AM, Emil Velikov wrote: > From: Marc-André Lureau > > s/EGL_MESA_dma_buf_image_export/EGL_MESA_image_dma_buf_export as defined by > the spec > --- > src/egl/main/eglapi.c | 2 +- > src/egl/main/eglfallbacks.c | 2 +- > 2 file

[Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

2015-05-11 Thread Emil Velikov
The only user (egl_gallium) is not longer around. Signed-off-by: Emil Velikov --- src/egl/main/egldriver.c | 364 ++- 1 file changed, 13 insertions(+), 351 deletions(-) diff --git a/src/egl/main/egldriver.c b/src/egl/main/egldriver.c index 6983af9..4c

[Mesa-dev] [PATCH 5/6] egl/main: expose only core EGL functions statically

2015-05-11 Thread Emil Velikov
The EGL 1.3, 1.4 and 1.5 spec explicitly mentions that providing static symbols for functions provided by EGL extensions is not portable. Considering that relatively recently we've seen a non-mesa desktop EGL implementation, the fact that we opt for such behaviour has gone unnoticed. To encourage

[Mesa-dev] [PATCH 4/6] egl: fix the EGL_MESA_image_dma_buf_export header declarations

2015-05-11 Thread Emil Velikov
Similar to other EGL extensions - guard the function prototypes by EGL_EGLEXT_PROTOTYPES as the libEGL library does (should) not provide the symbols statically. Instead users should call eglGetProcAddress, which returns the function pointer. The latter of which was missing the type declaration (ty

[Mesa-dev] [PATCH 3/6] egl/main: Update README.txt

2015-05-11 Thread Emil Velikov
The driver search/load is not done at eglGetDisplay (or eglOpenDisplay as the readme called it) time, but during eglInitialize(). Drop _eglMain (available only for external drivers) reference. Mention we use function(s), specific to the built-in driver(s). Signed-off-by: Emil Velikov --- src/eg

[Mesa-dev] [PATCH 2/6] egl/main: cleanup function prototypes

2015-05-11 Thread Emil Velikov
Cleanup the function propotypes which were part of the previous EGL drivers. Signed-off-by: Emil Velikov --- src/egl/main/egldriver.c | 4 src/egl/main/egldriver.h | 12 ++-- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/egl/main/egldriver.c b/src/egl/main/egl

Re: [Mesa-dev] [PATCH 08/29] i965/vec4: Introduce VEC4 IR builder.

2015-05-11 Thread Matt Turner
On Sat, May 2, 2015 at 8:29 AM, Francisco Jerez wrote: > See "i965/fs: Introduce FS IR builder." for the rationale. > > v2: Drop scalarizing VEC4 builder. I think part of v2 was supposed to be dropping this whole patch. :) ___ mesa-dev mailing list mesa

[Mesa-dev] [Bug 90383] assembly enabled mesa crashes dota2

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90383 Sylvain BERTRAND changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] Mesa 10.5.5

2015-05-11 Thread Emil Velikov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 10.5.5 is now available. This release includes a selection of i965 and nouveau driver fixes. Everyone using a gallium driver (r300, r600 and others) is also encouraged to update. Boyan Ding (1): i965: Add XRGB format to intel_screen_ma

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Ian Romanick
On 05/11/2015 01:43 PM, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 4:34 PM, Ian Romanick wrote: >> On 05/11/2015 07:57 AM, Ilia Mirkin wrote: >>> On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund >>> wrote: On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt wrote: > From: Marta Lofs

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 4:34 PM, Ian Romanick wrote: > On 05/11/2015 07:57 AM, Ilia Mirkin wrote: >> On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund wrote: >>> On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt >>> wrote: From: Marta Lofstedt GLES 3.1 must be allowed to use multisa

Re: [Mesa-dev] [PATCH 9/9] mesa/es3.1: Pass sample count check for multisampled textures

2015-05-11 Thread Ian Romanick
On 05/11/2015 06:03 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > For GLES 3.1 to support Multisample textures it needs > to be able to pass the sample count test. > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/multisample.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Ian Romanick
On 05/11/2015 07:57 AM, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund wrote: >> On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt >> wrote: >>> From: Marta Lofstedt >>> >>> GLES 3.1 must be allowed to use multisampled >>> frambuffer textures. >>> >>> Signed-off-by: Marta Lo

Re: [Mesa-dev] [PATCH] st/mesa: make sure to create a "clean" bool when doing i2b

2015-05-11 Thread Roland Scheidegger
Am 11.05.2015 um 21:38 schrieb Ilia Mirkin: > On Mon, May 11, 2015 at 3:29 PM, Roland Scheidegger > wrote: >> Reviewed-by: Roland Scheidegger >> >> As for b2i I'm not really convinced using INEG is preferable there. >> Generally I'd favor logic ops over arithmetic any day. >> I suppose backend p

[Mesa-dev] [PATCH 2/2] radeon/vce: adapt new firmware interface changes

2015-05-11 Thread Christian König
From: Christian König v2: make this also compatible with original released firmware v3 (chk): switch to original idea of separate files for fw versions Signed-off-by: Leo Liu Signed-off-by: Christian König Reviewed-by: Alex Deucher (v2) --- src/gallium/drivers/radeon/Makefile.sources | 1 +

[Mesa-dev] [PATCH 1/2] radeon/vce: move CPB handling function into common code

2015-05-11 Thread Christian König
From: Christian König They are not firmware version dependent. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_vce.c| 38 ++ src/gallium/drivers/radeon/radeon_vce.h| 7 + src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 32 ++---

Re: [Mesa-dev] [PATCH] nvc0: do not expose MP counters for nvf0 (GK110+)

2015-05-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin The comments about nvc0 not always being enabled are a little misplaced now... esp since now nvf0+ are also not enabled. But not a big deal. On Mon, May 11, 2015 at 3:36 PM, Samuel Pitoiset wrote: > This fixes a crash when trying to monitor MP counters because compute >

Re: [Mesa-dev] [PATCH] st/mesa: make sure to create a "clean" bool when doing i2b

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 3:29 PM, Roland Scheidegger wrote: > Reviewed-by: Roland Scheidegger > > As for b2i I'm not really convinced using INEG is preferable there. > Generally I'd favor logic ops over arithmetic any day. > I suppose backend probably need to try to recognize such patterns anyway

[Mesa-dev] [PATCH] nvc0: do not expose MP counters for nvf0 (GK110+)

2015-05-11 Thread Samuel Pitoiset
This fixes a crash when trying to monitor MP counters because compute support is not implemented for nvf0. Reported-by: Ilia Mirkin Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 89 +++ 1 file changed, 50 insertions(+), 39 deletions(-

Re: [Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Emil Velikov
On 11 May 2015 at 20:09, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 3:02 PM, Ian Romanick wrote: >> On 05/11/2015 08:23 AM, Ilia Mirkin wrote: >>> On Mon, May 11, 2015 at 9:03 AM, Marta Lofstedt >>> wrote: From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/m

Re: [Mesa-dev] [PATCH] st/mesa: make sure to create a "clean" bool when doing i2b

2015-05-11 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger As for b2i I'm not really convinced using INEG is preferable there. Generally I'd favor logic ops over arithmetic any day. I suppose backend probably need to try to recognize such patterns anyway for best performance (so that for instance things like b2i->i2b shoul

Re: [Mesa-dev] [PATCH 1/3] clover: Refactor event::trigger and ::abort to prevent deadlock and reentrancy issues.

2015-05-11 Thread Tom Stellard
On Sat, May 09, 2015 at 04:42:29PM +0300, Francisco Jerez wrote: > Refactor ::trigger and ::abort to split out the operations that access > concurrently modified data members and require locking from the > recursive and possibly re-entrant part of these methods. This will > avoid some deadlock sit

Re: [Mesa-dev] [PATCH] st/mesa: make sure to create a "clean" bool when doing i2b

2015-05-11 Thread Marek Olšák
Reviewed-by: Marek Olšák If there are no piglit regressions after switching b2i to INEG, then why not. Marek On Mon, May 11, 2015 at 8:38 PM, Ilia Mirkin wrote: > Could any of the Gallium folk R-b this? It's been this way since Bryan > Cain introduced it... I don't think that there was a USNE/

Re: [Mesa-dev] [PATCH] egl: more define fixes for EGL_MESA_image_dma_buf_export

2015-05-11 Thread Emil Velikov
On 11 May 2015 at 20:07, Emil Velikov wrote: > On 11 May 2015 at 14:23, Marc-André Lureau wrote: >> s/EGL_MESA_dma_buf_image_export/EGL_MESA_image_dma_buf_export as defined by >> the spec >> --- >> src/egl/main/eglapi.c | 2 +- >> src/egl/main/eglfallbacks.c | 2 +- >> 2 files changed, 2

Re: [Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 3:02 PM, Ian Romanick wrote: > On 05/11/2015 08:23 AM, Ilia Mirkin wrote: >> On Mon, May 11, 2015 at 9:03 AM, Marta Lofstedt >> wrote: >>> From: Marta Lofstedt >>> >>> Signed-off-by: Marta Lofstedt >>> --- >>> src/mesa/main/bufferobj.c | 5 +++-- >>> 1 file changed, 3 i

Re: [Mesa-dev] [PATCH] egl: more define fixes for EGL_MESA_image_dma_buf_export

2015-05-11 Thread Emil Velikov
On 11 May 2015 at 14:23, Marc-André Lureau wrote: > s/EGL_MESA_dma_buf_image_export/EGL_MESA_image_dma_buf_export as defined by > the spec > --- > src/egl/main/eglapi.c | 2 +- > src/egl/main/eglfallbacks.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/egl

Re: [Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Ian Romanick
On 05/11/2015 08:23 AM, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 9:03 AM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> Signed-off-by: Marta Lofstedt >> --- >> src/mesa/main/bufferobj.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/src/mesa/main/bu

Re: [Mesa-dev] [PATCH v2] nir: fix sampler lowering pass for arrays

2015-05-11 Thread Jason Ekstrand
On Mon, May 11, 2015 at 4:50 AM, Tapani Pälli wrote: > This fixes bugs with special cases where we have arrays of > structures containing samplers or arrays of samplers. > > I've verified that patch results in calculating same index value as > returned by _mesa_get_sampler_uniform_value for IR. Pa

Re: [Mesa-dev] [PATCH 2/2 v3] i965: Use predicate enable bit for conditional rendering w/o stalling

2015-05-11 Thread Kenneth Graunke
On Monday, May 11, 2015 03:14:21 PM Neil Roberts wrote: > Kenneth Graunke writes: > > > It might be nice to create a brw_load_register_mem64 function, for > > symmetry with brw_store_register_mem64 - we might want to reuse it > > elsewhere someday. > > Ok, that sounds sensible. > > > One intere

Re: [Mesa-dev] [PATCH] st/mesa: make sure to create a "clean" bool when doing i2b

2015-05-11 Thread Ilia Mirkin
Could any of the Gallium folk R-b this? It's been this way since Bryan Cain introduced it... I don't think that there was a USNE/etc variant at the time. Also, what do people think of making b2i do INEG instead of AND? That should allow implementations to fold the neg into instructions that suppor

Re: [Mesa-dev] [PATCH 09/13] util/list: Add list_empty and list_length functions

2015-05-11 Thread Neil Roberts
Ian Romanick writes: >> For what it's worth, I'm strongly in favour of using these >> kernel-style lists instead of exec_list. The kernel ones seem much >> less confusing. > > Huh? They're practically identical. The only difference is the > kernel-style lists have a single sentinel node, and that

Re: [Mesa-dev] [PATCH] egl: Remove skeleton implementation of EGL_MESA_screen_surface

2015-05-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, May 1, 2015 at 5:35 PM, Adam Jackson wrote: > No backend wires this up to anything, and the extension spec has been > marked obsolete for 4+ years. > > Signed-off-by: Adam Jackson > --- > include/EGL/eglmesaext.h | 46 -- > src/egl/main/Makefil

Re: [Mesa-dev] [PATCH 4/9] egl/wayland: Add support for render-nodes

2015-05-11 Thread Matt Turner
On Mon, May 11, 2015 at 10:38 AM, Axel Davy wrote: > Le 11/05/2015 17:42, Matt Turner a écrit : >> >> On Sat, May 9, 2015 at 4:20 AM, Axel Davy wrote: >>> >>> for drmGetNodeTypeFromFd, it looks like a very recent libdrm function, >>> and >>> we would require libdrm 2.4.60, which is quite recent.

Re: [Mesa-dev] [PATCH 4/9] egl/wayland: Add support for render-nodes

2015-05-11 Thread Axel Davy
Le 11/05/2015 17:42, Matt Turner a écrit : On Sat, May 9, 2015 at 4:20 AM, Axel Davy wrote: for drmGetNodeTypeFromFd, it looks like a very recent libdrm function, and we would require libdrm 2.4.60, which is quite recent. Currently mesa requires 2.4.38, when libdrm is needed. I guess we cannot

[Mesa-dev] [PATCH 47/57] mesa: Add ARB_direct_state_access checks in renderbuffer functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 65e194c..8db651c 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -1489,6 +1489,1

[Mesa-dev] [PATCH 07/57] main: Require that the texture exists in framebuffer_texture

2015-05-11 Thread Fredrik Höglund
Generate GL_INVALID_OPERATION if the texture hasn't been created. Cc: "10.4 10.5" Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 9486ded..4524e51 100644 ---

[Mesa-dev] [PATCH 46/57] mesa: Add ARB_direct_state_access checks in FBO functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/blit.c | 7 + src/mesa/main/buffers.c | 21 +++ src/mesa/main/clear.c| 32 +++ src/mesa/main/fbobject.c | 67 4 files changed, 127 insertions(+) diff --

[Mesa-dev] [PATCH 52/57] mesa: Add ARB_direct_state_access checks in query object functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/queryobj.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 5ff1b95..2784b4c 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -284,6 +284,13 @@ _mesa_CreateQ

[Mesa-dev] [PATCH 49/57] mesa: Add ARB_direct_state_access checks in VAO functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/arrayobj.c | 22 + src/mesa/main/varray.c | 64 2 files changed, 86 insertions(+) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 7c40040..320f435 100644 ---

[Mesa-dev] [PATCH 57/57] docs/relnotes: Mark off ARB_direct_state_access for 10.6

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- docs/relnotes/10.6.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html index b7cd486..7fbf702 100644 --- a/docs/relnotes/10.6.0.html +++ b/docs/relnotes/10.6.0.html @@ -48,6 +48,7 @@ Note: some of the

[Mesa-dev] [PATCH 43/57] mesa: Make GL_TEXTURE_CUBE_MAP valid in FramebufferTextureLayer

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 971dc68..c2bc081 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/mai

[Mesa-dev] [PATCH 54/57] i965: Enable ARB_direct_state_access

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index c3eee31..6e5d40d 100644 --- a/src/mesa/drivers/dri/i965/intel_exte

[Mesa-dev] [PATCH 45/57] mesa: Add ARB_direct_state_access checks in buffer object functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/bufferobj.c | 105 ++ 1 file changed, 105 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 66dee68..660bc94 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/mai

[Mesa-dev] [PATCH 42/57] mesa: Add an extension flag for ARB_direct_state_access

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/extensions.c | 2 +- src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index f7ce064..c82416a 100644 --- a/src/mesa/main/extensions.c +++ b/src/me

[Mesa-dev] [PATCH 27/57] main: Complete error conditions for glInvalidate*Framebuffer.

2015-05-11 Thread Fredrik Höglund
From: Laura Ekstrand Cc: "10.4 10.5" Reviewed-by: Fredrik Höglund Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 15878d3..7ba7255 100

[Mesa-dev] [PATCH 51/57] mesa: Add ARB_direct_state_access checks in program pipeline functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/pipelineobj.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 0fefa7d..a33cdd1 100644 --- a/src/mesa/main/pipelineobj.c +++ b/src/mesa/main/pipelineobj.c @@ -553,6 +553,12 @@

[Mesa-dev] [PATCH 53/57] i915: Enable ARB_direct_state_access

2015-05-11 Thread Fredrik Höglund
This extension requires OpenGL 2.0, so enable the extension on gen3 and later. Signed-off-by: Fredrik Höglund --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i915/intel_extensions.c b/src/mesa/drivers/dri/i915/intel_exten

[Mesa-dev] [PATCH 50/57] mesa: Add ARB_direct_state_access checks in sampler object functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/samplerobj.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index a3aacc6..60711a5 100644 --- a/src/mesa/main/samplerobj.c +++ b/src/mesa/main/samplerobj.c @@ -221,6 +221,13 @@ voi

[Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/transformfeedback.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 103011c..642fa96 100644 --- a/src/mesa/main/transformfeedb

[Mesa-dev] [PATCH 00/57] Finish enabling ARB_direct_state_access

2015-05-11 Thread Fredrik Höglund
This is a respin of Laura's FBO patches. I've rebased them, fixed the issues I found, and added my R-b tags. Note that there is a total of 57 patches, so I'm only posting the ones that don't already have R-b tags, and the ones that are candidates for the stable branches. But all the patches are

[Mesa-dev] [PATCH 56/57] docs: Update the ARB_direct_state_access status

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 7a7c1bd..1b764ee 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -192,10 +192,10 @@ GL 4.5, GLSL 4.50: GL_ARB_conditional_render_inverted

[Mesa-dev] [PATCH 09/57] main: Fix an error generated by FramebufferTexture

2015-05-11 Thread Fredrik Höglund
From: Laura Ekstrand gl*FramebufferTexture should generate GL_INVALID_VALUE when the texture doesn't exist. [Fredrik: Split this change out from the next commit] Cc: "10.4 10.5" Reviewed-by: Fredrik Höglund Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 17 +

[Mesa-dev] [PATCH 08/57] mesa: Generate GL_INVALID_VALUE in framebuffer_texture when layer < 0

2015-05-11 Thread Fredrik Höglund
Cc: "10.4 10.5" Signed-off-by: Fredrik Höglund --- src/mesa/main/fbobject.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4524e51..20a4e86 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2668,6

[Mesa-dev] [PATCH 48/57] mesa: Add ARB_direct_state_access checks in texture functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/genmipmap.c | 7 src/mesa/main/texgetimage.c | 14 src/mesa/main/teximage.c| 74 +++ src/mesa/main/texobj.c | 14 src/mesa/main/texparam.c| 84 ++

[Mesa-dev] [PATCH 55/57] st/mesa: Enable ARB_direct_state_access

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/state_tracker/st_extensions.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..d3f31db 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/me

[Mesa-dev] [Bug 90311] Fail to build libglx with clang at linking stage

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90311 --- Comment #2 from Jon TURNEY --- I don't remember all the details, but when I wrote "XXX: There has to be a better way fixing this.", I think my concern was that perhaps this indicates that the partitioning of functionality into whatever it is

[Mesa-dev] [Bug 90383] assembly enabled mesa crashes dota2

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90383 --- Comment #8 from Sylvain BERTRAND --- I tried -m32. Did not change anything. -m32 and -m64 are only for a gcc multilib toolchains. Here, it's a normal x86 toolchain, with i686-pc-gnu-gcc calling i686-pc-gnu-as (I checked i686-pc-gnu-gcc verbos

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 Jon TURNEY changed: What|Removed |Added CC||jon.tur...@dronecode.org.uk --- Comment #9

[Mesa-dev] [PATCH] clover: log build options when dumping clc source

2015-05-11 Thread EdB
--- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 7d2d941..fc7ab9c 100644 --- a/src/gallium/state_t

Re: [Mesa-dev] [PATCH 4/9] egl/wayland: Add support for render-nodes

2015-05-11 Thread Matt Turner
On Sat, May 9, 2015 at 4:20 AM, Axel Davy wrote: > for drmGetNodeTypeFromFd, it looks like a very recent libdrm function, and > we would require libdrm 2.4.60, which is quite recent. Currently mesa > requires 2.4.38, when libdrm is needed. I guess we cannot require 2.4.60 for > now. Sure you can.

Re: [Mesa-dev] [RFC 4/6] i965: Implement INTEL_performance_query extension

2015-05-11 Thread Samuel Pitoiset
On 05/06/2015 02:53 AM, Robert Bragg wrote: This adds a bare-bones backend for the INTEL_performance_query extension that exposes the pipeline statistics on gen 6 and 7 hardware. Although this could be considered redundant given that the same statistics are now available via query objects, the

Re: [Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 9:03 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/bufferobj.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index 66dee68..

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Erik Faye-Lund
On Mon, May 11, 2015 at 5:21 PM, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 11:07 AM, Erik Faye-Lund wrote: >> On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin wrote: >>> On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund >>> wrote: Shouldn't this be like this instead (and make sure ARB_

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 11:07 AM, Erik Faye-Lund wrote: > On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin wrote: >> On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund wrote: >>> Shouldn't this be like this instead (and make sure >>> ARB_texture_multisample is enabled for ES3.1)? >>> >>> @@ -2756,8 +2

Re: [Mesa-dev] [RFC 3/6] Model INTEL perf query backend after query object BE

2015-05-11 Thread Samuel Pitoiset
Patches 1 and 2 look fine to me. See my comments below for this one. On 05/06/2015 02:53 AM, Robert Bragg wrote: Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is based on the ARB_query_buffer_object interfa

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-11 Thread Samuel Pitoiset
Did you write piglit tests according to what the spec says, btw ? On 05/06/2015 02:53 AM, Robert Bragg wrote: As we've learned more about the observability capabilities of Gen graphics we've found that it's not enough to only try and configure the OA unit from userspace without any dedicated sup

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Erik Faye-Lund
On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin wrote: > On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund wrote: >> Shouldn't this be like this instead (and make sure >> ARB_texture_multisample is enabled for ES3.1)? >> >> @@ -2756,8 +2756,9 @@ _mesa_FramebufferTexture2D(GLenum target, GLenum >> att

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Ilia Mirkin
On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund wrote: > On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> GLES 3.1 must be allowed to use multisampled >> frambuffer textures. >> >> Signed-off-by: Marta Lofstedt >> --- >> src/mesa/main/fbobject.c | 5 +++--

Re: [Mesa-dev] [PATCH 2/2 v3] i965: Use predicate enable bit for conditional rendering w/o stalling

2015-05-11 Thread Neil Roberts
Kenneth Graunke writes: > It might be nice to create a brw_load_register_mem64 function, for > symmetry with brw_store_register_mem64 - we might want to reuse it > elsewhere someday. Ok, that sounds sensible. > One interesting quirk: the two halves of your register write may land > in two separ

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Erik Faye-Lund
On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > GLES 3.1 must be allowed to use multisampled > frambuffer textures. > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/fbobject.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/

[Mesa-dev] [PATCH] egl: more define fixes for EGL_MESA_image_dma_buf_export

2015-05-11 Thread Marc-André Lureau
s/EGL_MESA_dma_buf_image_export/EGL_MESA_image_dma_buf_export as defined by the spec --- src/egl/main/eglapi.c | 2 +- src/egl/main/eglfallbacks.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index ba1d0dd..6d2b51d 1006

[Mesa-dev] [PATCH 3/9] mesa/es3.1: Allow GL_DEPTH_STENCIL_TEXTURE_MODE

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 must support the parameter GL_DEPTH_STENCIL_TEXTURE_MODE. Signed-off-by: Marta Lofstedt --- src/mesa/main/texparam.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index b5d42d3..c5cb2b1 1

[Mesa-dev] [PATCH 0/9] OpenGL ES 3.1 enablement continued

2015-05-11 Thread Marta Lofstedt
Some of the functionality needed for GLES 3.1 conformance has been limited to usage for desktop Open GL and/or excluded Open GL ES usage. This patch-set removes some of those limitation for Open GL ES 3.1. Marta Lofstedt (9): mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1 m

[Mesa-dev] [PATCH 9/9] mesa/es3.1: Pass sample count check for multisampled textures

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt For GLES 3.1 to support Multisample textures it needs to be able to pass the sample count test. Signed-off-by: Marta Lofstedt --- src/mesa/main/multisample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/mul

[Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 must be allowed to use multisampled frambuffer textures. Signed-off-by: Marta Lofstedt --- src/mesa/main/fbobject.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 27cf97f..14a015e

[Mesa-dev] [PATCH 8/9] mesa/es3.1: Allow multisampled textures for GLES 3.1

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 must be allowed to create multisampled textures. Signed-off-by: Marta Lofstedt --- src/mesa/main/teximage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 44fad2d..1442113 100644 --

[Mesa-dev] [PATCH 2/9] mesa/es3.1: Allow GL_SAMPLE_MASK

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 should be allowed to enable GL_SAMPLE_MASK. Signed-off-by: Marta Lofstedt --- src/mesa/main/enable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 9008a38..801a5ca 100644 --- a/src/mesa/ma

[Mesa-dev] [PATCH 5/9] mesa/es3.1: Allow enable of GL_SAMPLE_MASK

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 must be able to enable GL_SAMPLE_MASK. Signed-off-by: Marta Lofstedt --- src/mesa/main/enable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 801a5ca..9109120 100644 --- a/src/mesa/main/en

[Mesa-dev] [PATCH 4/9] mesa/es3.1: Allow textures with target GL_TEXTURE_2D_MULTISAMPLE

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 should be able to bind a texture with the target GL_TEXTURE_2D_MULTISAMPLE. Signed-off-by: Marta Lofstedt --- src/mesa/main/teximage.c | 2 +- src/mesa/main/texobj.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.

[Mesa-dev] [PATCH 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/bufferobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 66dee68..07f82cd 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/buffe

[Mesa-dev] [PATCH 7/9] mesa/es3.1: Allow query of GL_TEXTURE_MULTISAMPLE

2015-05-11 Thread Marta Lofstedt
From: Marta Lofstedt GLES 3.1 must allow a query for GL_TEXTURE_MULTISAMPLED. Signed-off-by: Marta Lofstedt --- src/mesa/main/formatquery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 7741cab..a6c8971 10

[Mesa-dev] [PATCH v2] nir: fix sampler lowering pass for arrays

2015-05-11 Thread Tapani Pälli
This fixes bugs with special cases where we have arrays of structures containing samplers or arrays of samplers. I've verified that patch results in calculating same index value as returned by _mesa_get_sampler_uniform_value for IR. Patch makes following ES3 conformance test pass: ES3-CTS

[Mesa-dev] [Bug 90383] assembly enabled mesa crashes dota2

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90383 --- Comment #7 from Tapani Pälli --- (In reply to Sylvain BERTRAND from comment #6) > It's not a multilib build. It's a standard 32 bits build on x86_64 > (CC="i686-pc-linux-gnu") > > So you think the issue is the assembly code from the glapi di

[Mesa-dev] [Bug 90383] assembly enabled mesa crashes dota2

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90383 --- Comment #6 from Sylvain BERTRAND --- It's not a multilib build. It's a standard 32 bits build on x86_64 (CC="i686-pc-linux-gnu") So you think the issue is the assembly code from the glapi dispatch table not compiled properly? -- You are re

Re: [Mesa-dev] [PATCH v3] glsl: set the binding value regardless explicit_binding

2015-05-11 Thread Alejandro Piñeiro
Sorry, forgot to include the version number of the patch. On 11/05/15 12:37, Alejandro Piñeiro wrote: > Since commit c0cd5b var->data.binding was set only when explicit_binding > was false, thas was wrong, should be a test to true. This prevented > to use any binding point different to 0. > > In a

[Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-11 Thread Alejandro Piñeiro
Since commit c0cd5b var->data.binding was set only when explicit_binding was false, thas was wrong, should be a test to true. This prevented to use any binding point different to 0. In any case, that if statement is not needed. Right now mesa requires all atomic counters to have an explicit bindin

[Mesa-dev] [PATCH] glsl: add stage references for UBO uniforms

2015-05-11 Thread Tapani Pälli
Patch marks uniforms inside UBO properly referenced by stages. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- src/glsl/linker.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index ea73c6f.

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #3 from Samuel Iglesias --- (In reply to Tapani Pälli from comment #2) > Created attachment 115690 [details] [review] > patch to fix the issue > > Does this fix the issue for you? Yes, it does :-D Thanks! -- You are receiving thi

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #2 from Tapani Pälli --- Created attachment 115690 --> https://bugs.freedesktop.org/attachment.cgi?id=115690&action=edit patch to fix the issue Does this fix the issue for you? -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

Re: [Mesa-dev] [PATCH] nir: fix sampler lowering pass for arrays

2015-05-11 Thread Tapani Pälli
On 05/08/2015 10:35 PM, Jason Ekstrand wrote: Over-all, I think this is on the right track, but I still don't think it's 100% correct. On Fri, May 8, 2015 at 12:04 AM, Tapani Pälli wrote: On 05/08/2015 09:56 AM, Pohjolainen, Topi wrote: On Fri, May 08, 2015 at 09:51:54AM +0300, Tapani P?

  1   2   >