[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #12 from Tapani Pälli --- The 'terrain section not rendered' does not feel like regression, I can reproduce them with trace (comment #6) with Mesa 10.3.7 on Haswell. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #11 from Ilia Mirkin --- (In reply to Tapani Pälli from comment #10) > (In reply to Sami Liedes from comment #9) > > Ok, interesting results. I managed to get an apitrace from an fglrx-enabled > > machine. From it I suspect that what'

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #10 from Tapani Pälli --- (In reply to Sami Liedes from comment #9) > Ok, interesting results. I managed to get an apitrace from an fglrx-enabled > machine. From it I suspect that what's missing is at least something that > CivBE uses

Re: [Mesa-dev] [PATCH 09/12] nir: Add a simple growing array data structure

2015-04-12 Thread Matt Turner
On Sun, Apr 12, 2015 at 6:38 PM, Jason Ekstrand wrote: > > On Apr 12, 2015 3:24 PM, "Thomas Helland" wrote: >> >> Hi, >> >> This looks correct as far as I can tell. >> I have some comments inline, but I don't feel strongly about >> either of them, so do as you please. >> >> Also, maybe this is a

Re: [Mesa-dev] [PATCH 09/12] nir: Add a simple growing array data structure

2015-04-12 Thread Jason Ekstrand
On Apr 12, 2015 3:24 PM, "Thomas Helland" wrote: > > Hi, > > This looks correct as far as I can tell. > I have some comments inline, but I don't feel strongly about > either of them, so do as you please. > > Also, maybe this is a candidate for /src/util ? Maybe. If so I'm OK leaving it here until

[Mesa-dev] [PATCH 4/4] gallium/ttn: add UBO support

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 63 - 1 file changed, 54 insertions(+), 9 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 610e5d9..bdbbe16 1

[Mesa-dev] [PATCH 2/4] gallium/ttn: add support for TXL2

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index c9f9e03..a2f15ed 100644 --- a/src/gallium/auxiliary/nir/

[Mesa-dev] [PATCH 3/4] gallium/ttn: minor cleanup

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index a2f15ed..610e5d9 100644 --- a/src/gal

[Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 9d988b06..c9f9e03 1006

[Mesa-dev] Mesa 10.5.3

2015-04-12 Thread Emil Velikov
Mesa 10.5.3 is now available. This release addresses issues in the OpenCL state-tracker (clover) and nearly every dri driver. Unlike mesa 10.5.2, the build process should finally be python/mako free :-) Dave Airlie (1): st_glsl_to_tgsi: only do mov copy propagation on temps (v2) Emil Velik

[Mesa-dev] [PATCH 09/12] nir: Add a simple growing array data structure

2015-04-12 Thread Thomas Helland
Hi, This looks correct as far as I can tell. I have some comments inline, but I don't feel strongly about either of them, so do as you please. Also, maybe this is a candidate for /src/util ? 2015-04-11 2:48 GMT+02:00 Jason Ekstrand : > --- > src/glsl/nir/nir_array.h | 96 >

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #9 from Sami Liedes --- Ok, interesting results. I managed to get an apitrace from an fglrx-enabled machine. From it I suspect that what's missing is at least something that CivBE uses to color the terrain. Perhaps that being missing

[Mesa-dev] [PATCH 1/3 v2] util/tests: Expand collision test for hash table

2015-04-12 Thread Thomas Helland
Add a test to exercise a worst case collision scenario that may cause us to not be able to find an empty slot in the table even though it is not full. This hits the bug in my last revision of the series converting the hash table to quadratic probing. V2: Feedback from Emil Velikov -Don't inclu

[Mesa-dev] [Bug 89905] scons build broken on 10.5.2 due to activated vega st

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89905 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 89905] scons build broken on 10.5.2 due to activated vega st

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89905 --- Comment #6 from Emil Velikov --- Alexander I've just pushed an alternative patch which adds the missing files to the tarball and confirmed that the Linux Scons build works like a charm. Mesa 10.5.3 (coming out in a second) will feature the f

[Mesa-dev] [PATCH 1/3] util/tests: Expand collision test for hash table

2015-04-12 Thread Thomas Helland
12. apr. 2015 18.33 skrev "Emil Velikov" : > > Hi Thomas, > > On 11/04/15 23:25, Thomas Helland wrote: > > Add a test to exercise a worst case collision scenario > > that may cause us to not be able to find an empty > > slot in the table even though it is not full. > > This hits the bug in my last

Re: [Mesa-dev] [PATCH] i965: Flush batchbuffer containing the query on glQueryCounter.

2015-04-12 Thread Kenneth Graunke
On Sunday, April 12, 2015 07:08:58 PM mathias.froehl...@gmx.net wrote: > From: Mathias Froehlich > > Hi all, > > the attached patch fixes timer queries as noticed with osgviewer. > Please review! > > Greetings and thanks > > Mathias > > > > This change fixes a regression with timer querie

Re: [Mesa-dev] [PATCH] i965: Flush batchbuffer containing the query on glQueryCounter.

2015-04-12 Thread Matt Turner
On Sun, Apr 12, 2015 at 10:08 AM, wrote: > From: Mathias Froehlich > > Hi all, > > the attached patch fixes timer queries as noticed with osgviewer. > Please review! > > Greetings and thanks > > Mathias > In the future, instead of putting this in the commit message itself, use git send-email

[Mesa-dev] [PATCH] i965: Flush batchbuffer containing the query on glQueryCounter.

2015-04-12 Thread Mathias . Froehlich
From: Mathias Froehlich Hi all, the attached patch fixes timer queries as noticed with osgviewer. Please review! Greetings and thanks Mathias This change fixes a regression with timer queries introduced with commit 3eb6258. There the pending batchbuffer is flushed only if glEndQuery is ex

Re: [Mesa-dev] [PATCH 1/3] util/tests: Expand collision test for hash table

2015-04-12 Thread Emil Velikov
Hi Thomas, On 11/04/15 23:25, Thomas Helland wrote: > Add a test to exercise a worst case collision scenario > that may cause us to not be able to find an empty > slot in the table even though it is not full. > This hits the bug in my last revision of the series > converting the hash table to quad

Re: [Mesa-dev] [PATCH] i965: Fix INTEL_DEBUG=shader_time for SIMD8 VS.

2015-04-12 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 22/38] main: Add entry point for BlitNamedFramebuffer.

2015-04-12 Thread Fredrik Höglund
On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 > src/mesa/main/blit.c | 50 > ++ > src/mesa/main/blit.h | 6 > src/mesa/main/tests/dispatch_sa

Re: [Mesa-dev] [PATCH 21/38] main: Refactor _mesa_update_draw_buffer_bounds.

2015-04-12 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- > src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- > src/mesa/drivers/dri/r200/r200_state.c | 2 +- > src/mesa/drivers/dri/radeon/radeon_common.c | 2

Re: [Mesa-dev] [PATCH 20/38] main: Refactor _mesa_get_clamp_read_color.

2015-04-12 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > This wasn't neccessary for ARB_direct_state_access, but felt like a good idea > for the sake of completeness. > --- > src/mesa/main/blend.c | 5 +++-- > src/mesa/main/blend.h | 3 ++- > src/mesa/main/readpix.c |

Re: [Mesa-dev] [PATCH 19/38] main: Refactor _mesa_[update|get]_clamp_fragment_color.

2015-04-12 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/blend.c | 19 ++- > src/mesa/main/blend.h | 6 -- > src/mesa/main/framebuffer.c | 2 +- > src/mesa/main/get.c | 8 > sr

Re: [Mesa-dev] [PATCH 18/38] main: Refactor _mesa_[update|get]_clamp_vertex_color.

2015-04-12 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/blend.c | 13 - > src/mesa/main/blend.h | 7 +-- > src/mesa/main/framebuffer.c | 2 +- > 3 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 17/38] main: Refactor _mesa_update_framebuffer.

2015-04-12 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > _mesa_update_framebuffer now operates on arbitrary read and draw framebuffers. > This allows BlitNamedFramebuffer to update the state of its arbitrary read and > draw framebuffers. > --- > src/mesa/drivers/dri/i915/

Re: [Mesa-dev] [PATCH 15/38] main: Fix whitespace in blit.c

2015-04-12 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/blit.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c > index 2898723

Re: [Mesa-dev] [PATCH 16/38] main: Refactor glBlitFramebuffer.

2015-04-12 Thread Fredrik Höglund
There should be two blank lines between the function defintions, but with that nitpick fixed: Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/blit.c | 119 > --- > src/mesa/main/blit.h | 7 ++

Re: [Mesa-dev] [PATCH 14/38] main: Add entry point GetNamedFramebufferAttachmentParameteriv.

2015-04-12 Thread Fredrik Höglund
On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ > src/mesa/main/fbobject.c | 131 > - > src/mesa/main/fbobject.h | 10 ++ > src/mesa/main/tests/dispatch_sanity.c

Re: [Mesa-dev] [PATCH 13/38] main: Add entry point for CheckNamedFramebufferStatus.

2015-04-12 Thread Fredrik Höglund
On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ > src/mesa/main/fbobject.c | 73 > -- > src/mesa/main/fbobject.h | 7 +++ > src/mesa/main/tests/dispatch_sanity.c

Re: [Mesa-dev] [PATCH 12/38] main: Fix indents in former get_texture_for_framebuffer functions.

2015-04-12 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/fbobject.c | 82 > > 1 file changed, 41 insertions(+), 41 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main

Re: [Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

2015-04-12 Thread Fredrik Höglund
This looks like a very nice cleanup indeed! One thing I noticed though is that fbobject.c seems to use two blank lines between function definitions, although it's not consistent about it. The functions introduced in this patch only have one blank line between them. Some more comments (mostly nitp

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89978 --- Comment #3 from Emil Velikov --- (In reply to David Heidelberg (okias) from comment #2) > Created attachment 115012 [details] [review] > 0001-st-nine-require-gcc-4.6.patch > > This is clearly GCC bug[1], should be fixed since GCC 4.6 which e

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Combine tex/fb_write operations (opt)

2015-04-12 Thread Pohjolainen, Topi
On Sun, Apr 12, 2015 at 10:02:03AM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 10, 2015 at 12:52:04PM -0700, Ben Widawsky wrote: > > Certain platforms support the ability to sample from a texture, and write > > it out > > to the file RT - thus saving a costly send instructions (note that this is

Re: [Mesa-dev] [PATCH] configure.ac: enable non-gallium assertions for people not using --enable-debug

2015-04-12 Thread Marek Olšák
Sure. I have just realized the patch doesn't work, because autoconf replaces [[ ]] with [ ]. Marek On Sun, Apr 12, 2015 at 2:48 PM, Emil Velikov wrote: > Hi Marek, > > On 11 April 2015 at 20:11, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> configure.ac | 4 +++- >> 1 file changed, 3 i

Re: [Mesa-dev] [PATCH] configure.ac: enable non-gallium assertions for people not using --enable-debug

2015-04-12 Thread Emil Velikov
Hi Marek, On 11 April 2015 at 20:11, Marek Olšák wrote: > From: Marek Olšák > > --- > configure.ac | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 4ed4b74..113fb49 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -421,7 +421,9

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #8 from Sami Liedes --- (In reply to Jason Ekstrand from comment #7) > Running it on proprietary drivers on Linux would probably be useful if you > have easy access to it. Access, yes, but easy, not sure. I'll try to find a way, perh

[Mesa-dev] [PATCH] i965: Fix INTEL_DEBUG=shader_time for SIMD8 VS.

2015-04-12 Thread Kenneth Graunke
In commit 4ebeb71573ad44f7657810dc5dd2c9030e3e63db, I deleted the emit_shader_time_end() call in emit_urb_writes(). But I failed to add it to run_vs(), as I intended. So no data was recorded at all. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ 1 file changed

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Combine tex/fb_write operations (opt)

2015-04-12 Thread Pohjolainen, Topi
On Fri, Apr 10, 2015 at 12:52:04PM -0700, Ben Widawsky wrote: > Certain platforms support the ability to sample from a texture, and write it > out > to the file RT - thus saving a costly send instructions (note that this is a > potnential win if one wanted to backport to a tag that didn't have the