Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

Thanks Neil! I was planning to fix this once I was done with the format conversion stuff, so you saved me some work :) I tested the patch and it fixes the following dEQP tests: dEQP-GLES3.functional.shaders.constants.float_int_f_suffix_0_vertex dEQP-GLES3.functional.shaders.constants.float_int_f_

[Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like most of the work, this patch seems to do enough, to advertise GLSL 1.30. TODO: fix extension numbering get piglit to execute tests on this

Re: [Mesa-dev] [PATCH] Set llvmpipe and softpipe note only for MSAA.

Hi! I'm not familiar with the "patch and merge" process, I just wonder if it is normal that my patch isn't merged yet (it's been more than 20 days). I can wait, but I just want to be sure I'm not waiting for nothing :D Thanks! 2014-11-03 6:02 GMT-05:00 Roland Scheidegger : > > Am 02.11.2014 um 1

Re: [Mesa-dev] [PATCH] r600g: merge the TXQ and BUFFER constant buffers

On Mon, 24 Nov 2014 04:36:06 +0100, Dave Airlie wrote: From: Dave Airlie We are using 1 more buffer than we have, although in the future the driver should just end up using one buffer in total probably, this is a good first step, it merges the txq cube array and buffer info constants on r600

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

Timothy Arceri writes: > On the subject of the hash table performance I spent way to much time > looking into this recently. In the end it was taking up to much time > benchmarking and profiling for what it was worth (at least in my test > cases) so I've moved on for now. However for those interes

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 01/19] st/nine: clean device9ex.

Thanks, patch 1 is not needed for patch 2 and 3. As for patch 2, I'm 99% sure it's not needed for patch 3. Axel On 26/11/2014 21:14, Emil Velikov wrote : Hi guys, I've picked up patches 1-10 & 13 for master. Afaict there is still a comment on two on the topic of queries, so I'll leave these o

Re: [Mesa-dev] [PATCH] r600g: do all CUBE ALU operations before gradient texture operations (v2)

Hello Dave, Cherry picking this commit for the 10.3 branch resulted in a number of non-trivial conflicts. Can you or anyone else familiar with the code backport this for 10.3 ? Thanks Emil On 24/11/14 00:32, Dave Airlie wrote: > From: Dave Airlie > > This moves all the CUBE section above the g

Re: [Mesa-dev] [PATCH] r600: fix texture gradients instruction emission (v2)

Hello Dave, Cherry picking this commit for the 10.3 branch resulted in a number of non-trivial conflicts. Can you or anyone else familiar with the code backport this for 10.3 ? Thanks Emil On 18/11/14 22:53, Dave Airlie wrote: > From: Dave Airlie > > The piglit tests were failing, and it appea

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

On Wed, Nov 26, 2014 at 12:02 PM, Neil Roberts wrote: > According to the GLSL spec float literals like ‘1f’ shouldn't be allowed > without adding a decimal point or an exponent. Apparently the AMD driver also > disallows this so it seems unlikely that anything would be relying on it. > --- Thanks

Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

On 21/11/14 09:02, Siavash Eliasi wrote: > > On 11/10/2014 04:28 AM, Emil Velikov wrote: >> I'm not sure did you just said that you've checked it, or that's what >> it ought to do ? There is a reason why I'm so picky - this bizarre (as >> one might call it) setup is just the tip of the iceberg whe

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

On Wed, Nov 26, 2014 at 12:14 PM, Jose Fonseca wrote: > On 26/11/14 19:01, Matt Turner wrote: >> >> On Wed, Nov 26, 2014 at 10:47 AM, wrote: >>> >>> From: José Fonseca >>> >>> Just use the same entrypoints we use for st/wgl's opengl32.dll. >>> --- >> >> >> Subject: s/mesadef.py/mesa.def/ > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 01/19] st/nine: clean device9ex.

Hi guys, I've picked up patches 1-10 & 13 for master. Afaict there is still a comment on two on the topic of queries, so I'll leave these out for now. Patches 1&2 does not seem to be mesa-stable material based on the commit message, yet they seem to be a requirement for #3. Can you add a couple o

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

On 26/11/14 19:01, Matt Turner wrote: On Wed, Nov 26, 2014 at 10:47 AM, wrote: From: José Fonseca Just use the same entrypoints we use for st/wgl's opengl32.dll. --- Subject: s/mesadef.py/mesa.def/ Ah, yes. If mesadef.py is indeed dead after this, maybe you'd like to grab the patch tha

Re: [Mesa-dev] [PATCH 3/3] glapi: Remove dead mesadef.py.

Reviewed-by: Jose Fonseca On 21/11/14 18:35, Matt Turner wrote: Dead since commit 4e120c97, in which apiparser (which mesadef.py imports) was removed. --- src/mapi/glapi/gen/Makefile.am | 1 - src/mapi/glapi/gen/mesadef.py | 215 - 2 files changed,

[Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this so it seems unlikely that anything would be relying on it. --- This was discussed here: http://lists.freedesktop.org/archives/mesa-

[Mesa-dev] [PATCH 2/2] glsl: Use | action in the lexer source to avoid duplicating the float action

Flex and lex have a special action ‘|’ which means to use the same action as the next rule. We can use this to reduce a bit of code duplication in the rules for the various float literal formats. --- src/glsl/glsl_lexer.ll | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) dif

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

On 26/11/14 19:16, Jan Vesely wrote: On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: From: José Fonseca Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little more than noise, potent

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

On 26/11/14 19:16, Jan Vesely wrote: > On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: >> From: José Fonseca >> >> Unfortunately gcc completely ignores the issue, and as result code that >> mixes signed/unsigned is so widespread through the code base end up >> being little more than

Re: [Mesa-dev] [PATCH 4/9] draw, gallivm, llvmpipe: Avoid implicit casts of 32-bit shifts to 64-bits.

I guess we could do explicit cast after the shift but we probably don't care enough about the slight performance hit on 32bit platforms (though actually some compilers might be smart enough to figure out a 32bit shift is really all that's needed). In any case, for the series: Reviewed-by: Roland

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

Am 26.11.2014 um 19:47 schrieb jfons...@vmware.com: > From: José Fonseca > > Unfortunately gcc completely ignores the issue, and as result code that > mixes signed/unsigned is so widespread through the code base end up > being little more than noise, potentially obscuring more pertinent > warning

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

On Wed, Nov 26, 2014 at 11:10 AM, Matt Turner wrote: > On Wed, Nov 26, 2014 at 10:59 AM, Jason Ekstrand > wrote: > > On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner > wrote: > >> > >> --- > >> src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + > >> 1 file changed, 5 insertions(+) > >> > >> di

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: > From: José Fonseca > > Unfortunately gcc completely ignores the issue, and as result code that > mixes signed/unsigned is so widespread through the code base end up > being little more than noise, potentially obscuring more pertinent

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

On Wed, Nov 26, 2014 at 10:59 AM, Jason Ekstrand wrote: > On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner wrote: >> >> --- >> src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c >> b/src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/9] scons: Remove dead code/comments.

The series LGTM. Reviewed-by: Brian Paul On 11/26/2014 11:47 AM, jfons...@vmware.com wrote: From: José Fonseca - Remove no-op if-clause. - -mstackrealign has been enabled again on MinGW for quite some time and appears to work alright nowadays. - Drop -mmmx option as it is implied my -m

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

On Wed, Nov 26, 2014 at 10:59 AM, Matt Turner wrote: > On Wed, Nov 26, 2014 at 10:56 AM, Jason Ekstrand > wrote: > > On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner > wrote: > >> > >> The i965 backends pass something out of 'screen', which is allocated > >> per-process, making using this as a ral

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

On Wed, Nov 26, 2014 at 10:47 AM, wrote: > From: José Fonseca > > Just use the same entrypoints we use for st/wgl's opengl32.dll. > --- Subject: s/mesadef.py/mesa.def/ If mesadef.py is indeed dead after this, maybe you'd like to grab the patch that deletes it from one of my previous series. __

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > index 7117890..8e33bcb 100644 > --- a/

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

On Wed, Nov 26, 2014 at 10:56 AM, Jason Ekstrand wrote: > On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner wrote: >> >> The i965 backends pass something out of 'screen', which is allocated >> per-process, making using this as a ralloc context not thread-safe. >> >> All callers ra_alloc_interference_

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner wrote: > The i965 backends pass something out of 'screen', which is allocated > per-process, making using this as a ralloc context not thread-safe. > > All callers ra_alloc_interference_graph() already ralloc_free() its > return value. > --- > src/ut

[Mesa-dev] [PATCH 5/9] gallivm: Removed unused variable.

From: José Fonseca --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c index 2ef5db1..738d5e9 100644 --- a/src/gallium/auxiliary/

[Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

From: José Fonseca Just use the same entrypoints we use for st/wgl's opengl32.dll. --- src/mesa/drivers/windows/gdi/mesa.def | 839 -- 1 file changed, 192 insertions(+), 647 deletions(-) diff --git a/src/mesa/drivers/windows/gdi/mesa.def b/src/mesa/drivers/windo

[Mesa-dev] [PATCH 6/9] util/u_snprintf: Don't redefine HAVE_STDINT_H as 0.

From: José Fonseca We now always guarantee availability of stdint.h on MSVC -- if MSVC doesn't supply one we use our own. --- src/gallium/auxiliary/util/u_snprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_snprintf.c b/src/gallium/auxilia

[Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

From: José Fonseca Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little more than noise, potentially obscuring more pertinent warnings. This change disables them. --- scons/gallium.py | 1 + 1 fi

[Mesa-dev] [PATCH 2/9] scons: Generate SSE2 floating-point arithmetic.

From: José Fonseca - SSE2 is available on all x86 processors we care about. - It's recommended by Intel: https://software.intel.com/en-us/blogs/2012/09/26/gcc-x86-performance-hints - And has been the default since MSVC 2012: http://msdn.microsoft.com/en-us/library/7t5yh4fd(v=vs.110).aspx

[Mesa-dev] [PATCH 8/9] st/wgl: Don't export wglGetExtensionsStringARB.

From: José Fonseca It's not exported by the official opengl32.dll neither. Applications are supposed to get it via wglGetProcAddress(), not GetProcAddress(). --- src/gallium/state_trackers/wgl/opengl32.def | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/wgl/opengl3

[Mesa-dev] [PATCH 7/9] mapi/glapi: Fix dll linkage of GLES1 symbols.

From: José Fonseca This fixes several MSVC warnings like: warning C4273: 'glClearColorx' : inconsistent dll linkage In fact, we should avoid using `declspec(dllexport)` altogether, and use exclusively the .DEF instead, which gives more precise control of which symbols must be exported, but al

[Mesa-dev] [PATCH 1/9] scons: Remove dead code/comments.

From: José Fonseca - Remove no-op if-clause. - -mstackrealign has been enabled again on MinGW for quite some time and appears to work alright nowadays. - Drop -mmmx option as it is implied my -msse, and we don't use MMX intrinsics anyway. --- scons/gallium.py | 5 + 1 file changed, 1 i

[Mesa-dev] [PATCH 4/9] draw, gallivm, llvmpipe: Avoid implicit casts of 32-bit shifts to 64-bits.

From: José Fonseca Addresses MSVC warnings "result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)", which can often be symptom of bugs, but in these cases were all benign. --- src/gallium/auxiliary/draw/draw_llvm.c| 4 ++-- src/gallium/auxiliary/gallivm/lp_b

[Mesa-dev] [PATCH 5/5] i965/fs: Clean up some whitespace in reg_allocate.

--- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index 44c74a3..0813f64 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_

[Mesa-dev] [PATCH 1/5] glsl: Initialize static temporaries_allocate_names once per process.

--- src/glsl/glsl_parser_extras.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 27e3301..5772d13 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -29,6 +29,7 @@ e

[Mesa-dev] [PATCH 3/5] i965: Initialize INTEL_DEBUG once per process.

--- src/mesa/drivers/dri/i965/intel_debug.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c index a283357..6391cf7 100644 --- a/src/mesa/drivers/dri/i965/intel_debug.c +++ b/src/mesa/drivers/

[Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 7117890..8e33bcb 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_compact.c +++ b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

The i965 backends pass something out of 'screen', which is allocated per-process, making using this as a ralloc context not thread-safe. All callers ra_alloc_interference_graph() already ralloc_free() its return value. --- src/util/register_allocate.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #29 from Emil Velikov --- OK so it seems that, on relink, libtool prepends an extra -L or two prior to -L/opt/lib thus gcc/ld might end up finding the system library thus never bothers searching in /opt/lib. The extra -L can be seen w

Re: [Mesa-dev] [PATCH] Add support for Texture Float extensions.

The subject line of the patch should be something like "mesa: add support for GL_OES_texture_*float* extensions" A bunch of other nitpicks below... On 11/26/2014 06:55 AM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)

[Mesa-dev] [PATCH] Add support for Texture Float extensions.

This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear. Support for these extensions need to be explicitly enabled per driver and this patch enables support for i96

[Mesa-dev] [PATCH] Add support for GLES2 Texture Float extensions.

This patch is based on initial work done by Kevin Rogovin here: http://lists.freedesktop.org/archives/mesa-dev/2014-May/059012.html Piglit tests can be found here: http://lists.freedesktop.org/archives/piglit/2014-July/011964.html The main changes in this patch are: 1)Add boolean flags to toggle

Re: [Mesa-dev] [PATCH] Add support for following Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear.

Hi, Please ignore this patch. Will re-send with the commit message fixed. Thanks, Kalyan On Wed, Nov 26, 2014 at 5:31 AM, Kalyan Kondapally wrote: > Support for these extensions need to be explicitly enabled per driver > and this patch enables support for i965 drivers. > > Signed-off-by: Kevin

[Mesa-dev] [PATCH] Add support for following Texture Float extensions.

This patch is based on initial work done by Kevin Rogovin here: http://lists.freedesktop.org/archives/mesa-dev/2014-May/059012.html Piglit tests can be found here: http://lists.freedesktop.org/archives/piglit/2014-July/011964.html The main changes in this patch are: 1)Add boolean flags to toggle

[Mesa-dev] [PATCH] Add support for following Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear.

Support for these extensions need to be explicitly enabled per driver and this patch enables support for i965 drivers. Signed-off-by: Kevin Rogovin Signed-off-by: Kalyan Kondapally --- src/mesa/drivers/dri/i965/intel_extensions.c | 6 +++ src/mesa/main/extensions.c | 4 ++ s

Re: [Mesa-dev] [PATCH 0/7] util: Move u_atomic.h to src/util and modify API

On 26/11/14 01:01, Matt Turner wrote: On Mon, Nov 24, 2014 at 4:39 PM, Matt Turner wrote: I've got some thread-safety fixes queued up after this and thought I'd be a good Mesa citizen and pull some code into src/util. I did some clean ups like replacing INLINE (MSVC knows about "inline" these

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Felix Schwarz changed: What|Removed |Added Depends on||86720 -- You are receiving this mail be

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #28 from Juha-Pekka Heikkilä --- Created attachment 110039 --> https://bugs.freedesktop.org/attachment.cgi?id=110039&action=edit log of failed dri3 build with Emil's patch included Here is the log with Emil's patch included. Log co