On 26/11/14 19:16, Jan Vesely wrote: > On Wed, 2014-11-26 at 18:47 +0000, jfons...@vmware.com wrote: >> From: José Fonseca <jfons...@vmware.com> >> >> Unfortunately gcc completely ignores the issue, and as result code that >> mixes signed/unsigned is so widespread through the code base end up >> being little more than noise, potentially obscuring more pertinent >> warnings. > > gcc does not ignore the issue. there is -Wsign-compare. it's part of > -Wextra (and thus disabled by default). I build mesa with -Wextra (and > -Wno-unused-paramter) and my setup adds these warnings: > > 154 -Wmissing-field-initializers > 1 -Wold-style-declaration > 614 -Wsign-compare > 8 -Wtype-limits > > I think it might be worth fixing these and and adding -Wextra to gcc > build flags. > I had the same noble idea, but the numbers are enough to push most/all people away. Until we resolve them, it might be worth keeping the annoyance factor low. Please send in patches I'm sure Jose won't object. I might even join the "fun" :)
Cheers, Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
