On 09.07.2014 08:10, Carl Worth wrote:
>
> 3. I'd like to receive a testing report from each driver team
>
> This is the meat of my proposal. I'm requesting that each driver
> team designate one (or more) people that will be responsible for
> running (or collecting) tests for
https://bugs.freedesktop.org/show_bug.cgi?id=81174
--- Comment #10 from Florian Link ---
What I don't understand yet is why the effect is not stable (if my example is
repainted several times, the wrap appears at different positions over time).
--
You are receiving this mail because:
You are the
Hi folks,
I've pushed out an update to the 10.2 branch and I need some specific
testing in the next three days.
I've tested the branch on Intel (Haswell) as well as both swrast and
Gallium softpipe and found no piglit regressions compared to the 10.2.3
release.
The branch includes a few patches
This makes some of the UE4 engine demos (Stylized, Mobile Temple)
render correctly, tested on Intel Haswell machine.
Signed-off-by: Tapani Pälli
---
src/mapi/glapi/gen/GL4x.xml | 26 ++
src/mesa/main/tests/dispatch_sanity.cpp | 10 +-
2 files changed,
https://bugs.freedesktop.org/show_bug.cgi?id=81174
--- Comment #9 from Roland Scheidegger ---
(In reply to comment #8)
> Line loops aren't so critical, since they are rarely used. But what about
> triangle strips... every split kills 2 triangles...
That shouldn't happen, the code is supposed to
https://bugs.freedesktop.org/show_bug.cgi?id=81174
--- Comment #8 from Marek Olšák ---
Line loops aren't so critical, since they are rarely used. But what about
triangle strips... every split kills 2 triangles...
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=81174
--- Comment #7 from Roland Scheidegger ---
Hmm interesting. I thought more than 512 vertices would fit before it uses a
new buffer (the buffer size is 64kB though I don't know what the vertex size
ends up with). But if the bug is due to that I gu
On 07/14/2014 01:41 PM, Matt Turner wrote:
> On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
>> configure to change them for me.
>>
>> Signed-off-by: Ian Romanick
>> ---
>> configure.ac |
Looks good to me.
Reviewed-by: Ian Romanick
On 07/08/2014 11:29 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> This is needed to make Unigine Heaven 4.0 and Unigine Valley 1.0 work
> with sample shading.
>
> Also, if this is disabled, the error message at least makes sense now.
> ---
> src/g
From: Ian Romanick
The only values allowed are 0 and 1, and the value is checked before
assigning.
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 74 40,580,119,657 6
From: Ian Romanick
If the name is just going to get dropped, don't bother making it. If
the name is made, release it sooner (rather than later).
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/ast_function.cpp | 11 +++
1 fi
From: Ian Romanick
Also move num_state_slots inside ir_variable_data for better packing.
The payoff for this will come in a few more patches.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/builtin_variables.cpp | 5
From: Ian Romanick
Most of the overhead of the name allocation is the ralloc tracking,
especially on 64-bit. The allocation of the variable name "i" is 2
bytes for the name and 40 bytes for the ralloc tracking.
I collected data from shader-db. At the end of link_shaders I added a
visitor to pr
From: Ian Romanick
The use of the Bloom filter rejects the vast majority of strings that
are not in the table before expensive comparisons are performed. This
Bloom filter uses two hashes. One is explicit (calculate_hash in the
code), and the other is implicit. The implicit hash is just the le
From: Ian Romanick
Specifically, ir_var_temporary variables constructed with a NULL name
will all have the name "compiler_temp" in static storage.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/ir.cpp | 20 +
From: Ian Romanick
In the next patch, the type of ir_type is going to change from enum to
uint8_t. Since the type won't be an enum, we won't get compiler
warnings about, for example, switch statements that don't have cases for
all the enum values. Using a getter that returns the enum type will
From: Ian Romanick
If the name is just going to get dropped, don't bother making it. If
the name is made, release it sooner (rather than later).
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/mesa/drivers/dri/i965/brw_fs_vector_splittin
From: Ian Romanick
No change Valgrind massif results for a trimmed apitrace of dota2.
v2: Fix a couple spelling errors in the comment.
Signed-off-by: Ian Romanick
---
src/glsl/ir.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index 5c565ff.
From: Ian Romanick
After compilation (and before linking) we can eliminate quite a few
built-in variables. Basically, any uniform or constant (e.g.,
gl_MaxVertexTextureImageUnits) that isn't used (with one exception) can
be eliminated. System values, vertex shader inputs (with one
exception), a
Most of these patches have been sent to the list already in one form or
another. There are a few changes, removals, and additions. The series
has also been re-ordered.
- The extra memory accounting code has been removed. This was suggested
by Ken. Instead, all memory usage data is from Valgr
From: Ian Romanick
Just use ir_variable::data.binding... because that's the where the
binding is stored for everything else that can use layout(binding=).
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)
From: Ian Romanick
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/ir.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index ee42857..5c565ff 100644
--- a/src/glsl/ir.h
+++ b/src
From: Ian Romanick
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 52 40,521,071,734 66,157,928 61,054,870
5,103,0580
After (32-bit): 79 40,523
From: Ian Romanick
The payoff for this will come in a few more patches.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/ast_array_index.cpp | 10 --
src/glsl/ir.h| 37 -
src
From: Ian Romanick
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 74 40,578,719,715 67,762,208 62,263,404
5,498,8040
After (32-bit): 52 40,565
From: Ian Romanick
At least one of these pointers must be NULL, and we can determine which
will be NULL by looking at other fields. Use this information to store
both pointers in the same location.
If anyone can think of a better name for the union than "u", I'm all
ears.
Valgrind massif resul
From: Ian Romanick
All built-in uniforms are supposed to be backed by some GL state. The
state_slots field describes this backing state.
This helped me track down a bug in a later patch.
Signed-off-by: Ian Romanick
Acked-by: Anuj Phogat
---
src/glsl/ir_validate.cpp | 8
1 file chan
From: Ian Romanick
These few places were using ir_var_auto for seemingly no reason. The
names were not added to the symbol table.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/lower_offset_array.cpp | 3 ++-
src/glsl/lower_t
From: Ian Romanick
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/main.cpp | 1 +
src/mesa/main/context.c | 6 ++
src/mesa/main/mtypes.h| 13 +
src/mesa/main/shaderapi.c | 3 +++
4 files changed, 23 i
From: Ian Romanick
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 44 40,577,049,140 68,118,608 62,441,063
5,677,5450
After (32-bit): 71 40,583
From: Ian Romanick
Also move the new warn_extension_index into ir_variable::data. This
enables slightly better packing.
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 82
From: Ian Romanick
All of the GL image enums fit in 16-bits.
Also move the fields from the anonymous "image" structucture to the next
higher structure. This will enable packing the bits with the other
bitfield.
Valgrind massif results for a trimmed apitrace of dota2:
n
From: Ian Romanick
Previously we had to keep unreachable global symbols in the symbol table
because the symbol table is used during linking. Having the symbol
table retain pointers to freed memory... what could possibly go wrong?
At the same time, this meant that we kept live references to tons
From: Ian Romanick
warn_extension_index was moved to improve packing.
Valgrind massif results for a trimmed apitrace of dota2:
ntime(i) total(B) useful-heap(B)
extra-heap(B)stacks(B)
Before (32-bit): 73 40,580,476,304 68,488,400 62,796,151
From: Ian Romanick
Later patches will give every ir_var_temporary the same name in release
builds. Adding a bunch of variables named "compiler_temp" to the symbol
table can only cause problems.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
From: Ian Romanick
The payoff for this will come in the next patch.
No change Valgrind massif results for a trimmed apitrace of dota2.
Signed-off-by: Ian Romanick
---
src/glsl/builtin_variables.cpp | 4 ++--
src/glsl/ir.cpp| 11 +++
src/glsl/ir.h | 22
On Thursday, July 10, 2014 11:26:52 AM Matt Turner wrote:
> If we saw a tree that looked like
>
> vec3
>/ \
> vec3 float
> / \
> vec3 float
> / \
>vec3 float
>
> We would see that all of the expression types were vec3, and then
> rebal
From: Thomas Helland
When writing that A || (A && B) patch some
days ago I also wrote some other patches
that have no impact on my collection of shaders.
(shader-db + Some TF2 and Portal-shaders).
No reduction in instruction count, and no
significant increase in compilation time.
I decided to pu
From: Thomas Helland
This also only handles floats.
ir_unop_saturate should also be added when the
support for this lands in the ir.
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/glsl
From: Thomas Helland
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index 385f0a2..748fd05 100644
--- a/src/glsl/opt_algebraic.cpp
+++ b/src/glsl/opt_algebraic.cpp
@
From: Thomas Helland
Silly optimization indeed, but who knows.
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index ac7514a..c179d53 100644
--- a/src/glsl/opt_algebraic.
From: Thomas Helland
Specifically x^-1 = rcp(x)
.0^x = 0
.x^0 = 1
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index fba9de6..1
From: Thomas Helland
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index c179d53..385f0a2 100644
--- a/src/glsl/opt_algebraic.cpp
+++ b/src/glsl/opt_algebraic
From: Thomas Helland
And it's exp2() equivalent.
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index e2abf5f..2361d0f 100644
--- a/src/glsl/opt_algebraic.cpp
From: Thomas Helland
This patch is a bit sketchy.
It only handles float-constants, otherwise it bails.
Also, ir_unop_saturate should be added here when
support for it lands in the ir.
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 37 +
1 fil
From: Thomas Helland
...and neg(A) - B == neg(A + B)
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index 2361d0f..fba9de6 100644
--- a/src/glsl/opt_algebraic.cpp
++
From: Thomas Helland
And the log2() equivalent.
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index deaa49e..e2abf5f 100644
--- a/src/glsl/opt_algebraic.cpp
From: Thomas Helland
And it's cousins
Signed-off-by: Thomas Helland
---
src/glsl/opt_algebraic.cpp | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index 748fd05..230fb1b 100644
--- a/src/glsl/opt_algebraic.cpp
+++ b/src/gl
On Thursday, July 10, 2014 11:59:40 AM Matt Turner wrote:
> Should potentially allow a few more cases, while avoiding doing CSE on
> texture operations on Gen <= 6 with the MRF.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80211
> ---
> src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +
My advice is: The shader being compiled should be analyzed before
compilation and an array of bool flags (or one uint16_t for all flags)
should be produced saying which sampler units use TG4. Then, you only
need to set the swizzle in the key for the i-th sampler if the i-th
sampler is really used b
On 14/07/14 19:49, Ian Romanick wrote:
> From: Ian Romanick
>
> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
> configure to change them for me.
>
The topic is a rather messy and whatever we do there will always be a case
where this breaks someone's setup/workflow.
In
On Wednesday, July 09, 2014 12:41:25 PM Matt Turner wrote:
> Otherwise we'd compare uninitialized pointers with NULL and dereference,
> leading to crashes.
> ---
> src/mesa/drivers/dri/i965/intel_asm_annotation.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i9
Tested-by and Reviewed-by: Aaron Watry
On Mon, Jul 14, 2014 at 3:51 PM, Tom Stellard wrote:
> We were trying to print the error message after disposing the
> message object.
> ---
> src/gallium/drivers/radeon/radeon_llvm_emit.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>> Also, have you looked at Dave Airlie's impl? Not sure what's been
>> going on there...
>> http://cgit.freedesktop.org/~airlied/mesa/log/?h=r600g-texture-gather
>> . He seemed to enable 4 components for >= CEDAR.
>>
>
> No, didn't pop up when i searched the archives for any prior work on this.
>
You can also just add -DDEBUG by yourself since you override the flags
anyway (me too).
Marek
On Mon, Jul 14, 2014 at 8:49 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
> configure to change them for me.
>
> Signed-off-
On Mon, Jul 14, 2014 at 4:41 PM, Matt Turner wrote:
> On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
>> configure to change them for me.
>>
>> Signed-off-by: Ian Romanick
>> ---
>> confi
We were trying to print the error message after disposing the
message object.
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_em
On Mon, Jul 14, 2014 at 11:49 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
> configure to change them for me.
>
> Signed-off-by: Ian Romanick
> ---
> configure.ac | 14 --
> 1 file changed, 12 insertions(+)
On Mon, 14 Jul 2014 20:33:08 +0200, Ilia Mirkin
wrote:
On Mon, Jul 14, 2014 at 2:20 PM, Glenn Kennard
wrote:
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600/r600_pipe.c
index ca6399f..d967f0f 100644
--- a/src/gallium/drivers/r600/r600_pipe.c
+++ b/src/gallium
Sorry Tom, the patch does break the driver with LLVM 3.4.2. It looks
like LLVM wasn't installed properly.
I have reverted it.
Marek
On Fri, Jul 11, 2014 at 4:20 PM, Tom Stellard wrote:
> On Fri, Jul 11, 2014 at 01:00:34AM +0200, Marek Olšák wrote:
>> I have just tested it and it works with LLVM
Hm, indeed. PIPE_CAP_TEXTURE_GATHER_SM5 should be 0.
Marek
On Mon, Jul 14, 2014 at 9:10 PM, Ilia Mirkin wrote:
> On Mon, Jul 14, 2014 at 3:06 PM, Marek Olšák wrote:
>> Reviewed-by: Marek Olšák
>>
>> Yes, Dave Airlie's branch seems to support multi-component textures as
>> well as texture offse
On Mon, Jul 14, 2014 at 3:06 PM, Marek Olšák wrote:
> Reviewed-by: Marek Olšák
>
> Yes, Dave Airlie's branch seems to support multi-component textures as
> well as texture offsets. However, his solution triggers shader
> recompilation when the format and/or swizzle is changed even if the
> shader
Reviewed-by: Marek Olšák
Yes, Dave Airlie's branch seems to support multi-component textures as
well as texture offsets. However, his solution triggers shader
recompilation when the format and/or swizzle is changed even if the
shader doesn't use GATHER4. The recompilation should only be done for
On Monday, July 14, 2014 11:49:57 AM Ian Romanick wrote:
> From: Ian Romanick
>
> I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
> configure to change them for me.
>
> Signed-off-by: Ian Romanick
> ---
> configure.ac | 14 --
> 1 file changed, 12 insertion
From: Ian Romanick
I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want
configure to change them for me.
Signed-off-by: Ian Romanick
---
configure.ac | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 464621
On Mon, Jul 14, 2014 at 2:20 PM, Glenn Kennard wrote:
> Only supported on evergreen and later. Limited to
> single component textures as the hardware GATHER4
> instruction ignores texture swizzles.
>
> Piglit quick run passes on radeon 6670 with all
> applicable textureGather tests, no regressions
Only supported on evergreen and later. Limited to
single component textures as the hardware GATHER4
instruction ignores texture swizzles.
Piglit quick run passes on radeon 6670 with all
applicable textureGather tests, no regressions.
Signed-off-by: Glenn Kennard
---
docs/GL3.txt
On Mon, Jul 14, 2014 at 9:17 AM, Kenneth Graunke wrote:
> On Friday, July 11, 2014 11:26:30 AM Kristian Høgsberg wrote:
>> For now, this can only be triggered with a new 'no8' INTEL_DEBUG option
>>
>> Signed-off-by: Kristian Høgsberg
>> ---
>> src/mesa/drivers/dri/i965/brw_context.h | 2 ++
>>
On 07/11/2014 12:52 PM, Vinson Lee wrote:
This patch fixes this MinGW build error.
glapi_gentable.c: In function '_glapi_create_table_from_handle':
glapi_gentable.c:123:9: error: implicit declaration of function 'dlsym'
[-Werror=implicit-function-declaration]
*procp = dlsym(handle, sy
On Tuesday, July 08, 2014 08:29:44 PM Marek Olšák wrote:
> From: Marek Olšák
>
> This is needed to make Unigine Heaven 4.0 and Unigine Valley 1.0 work
> with sample shading.
>
> Also, if this is disabled, the error message at least makes sense now.
> ---
> src/glsl/glsl_parser.yy | 8 ++
On Thursday, July 10, 2014 09:55:31 AM Cody Northrop wrote:
> Vectors are falling in to the ir_dereference_array() path.
>
> Without this change, the following glsl aborts the debug driver,
> or gets the wrong answer in release:
>
> mat2x2 a = mat2( vec2( 1.0, vertex.x ), vec2( 0.0, 1.0 ) );
>
>
On Friday, July 11, 2014 11:26:30 AM Kristian Høgsberg wrote:
> For now, this can only be triggered with a new 'no8' INTEL_DEBUG option
>
> Signed-off-by: Kristian Høgsberg
> ---
> src/mesa/drivers/dri/i965/brw_context.h | 2 ++
> src/mesa/drivers/dri/i965/brw_fs.cpp | 14 --
https://bugs.freedesktop.org/show_bug.cgi?id=78716
--- Comment #11 from Kenneth Graunke ---
(In reply to comment #10)
> Created attachment 102771 [details] [review]
> patch that adds 4.0 missing blend functions api
>
> attached patch makes some of these new demos work for me on Intel Haswell
> m
https://bugs.freedesktop.org/show_bug.cgi?id=78716
--- Comment #10 from Tapani Pälli ---
Created attachment 102771
--> https://bugs.freedesktop.org/attachment.cgi?id=102771&action=edit
patch that adds 4.0 missing blend functions api
attached patch makes some of these new demos work for me on I
74 matches
Mail list logo
